Repository navigation
[backport cloud/1.58] fix(agent): recheck funds after an admitted send before showing the out-of-credits card - #22055
Conversation
…ut-of-credits card (#21538) ## Summary A new account's first prompt showed the standing "Out of credits" card for the whole turn, although the turn ran normally. The panel had read billing before the send, and pre-turn admission granted the free Agent credits inside that send, so the stale no-funds read stayed on screen until the turn finished. Stopping or finishing the turn cleared it. Now, when the last read says no funds, the panel holds the standing card from the send until a billing read taken after admission settles. A send that is refused keeps its inline card, and funded users make no extra request. Reported by Windows Local Agent QA in `#comfy-agent-user-feedback` on 2026-10-21. The card is shared frontend code, so Cloud has the same race whenever a grant is minted at admission. This finishes the work of [PM-2066](https://linear.app/comfyorg/issue/PM-2066), whose #21241 kept the card hidden only until the first message. <details><summary>Full context for agent readers</summary> - The standing card reads `subscription.agentHasFunds`, which is `scoped_effective_has_funds.agent` from `GET /api/billing/status`. Before this change, billing was refreshed only when a turn finished (`AgentPanelRoot.vue`, the idle branch of the `[status, conversationTurnId]` watch). - Cloud ingest mints the monthly or Local Agent gratis grant in `agentGratisEnsureBeforeAdmission` before `/v1/decide`, and it writes the funds snapshot synchronously. So a 2xx on the turn POST means a status read made after admission shows the grant. - Ingest's `billing_status` websocket push is not consumed by the frontend, and its payload has no Agent funds field, so it cannot correct this read. - The existing empty-thread spec still passes: when a post-admission read still says exhausted, the card shows. </details> ## Verification - New black-box case in `browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts`: billing is exhausted at load, and the turn POST flips the fixture to funded. On the parent commit it fails with `Expected: 0, Received: 1` (the card is visible during the admitted turn). With this change it passes, after waiting for the billing read that follows admission. - `playwright test` over `agentCreditsExhaustionEmptyThread`, `agentCreditsExhaustionLifecycle`, `agentPanel` and `agentFreeUsePlacement` (`--project=cloud`): 19 passed. - `vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts`: 465 passed. - Commit hooks passed: oxfmt, stylelint, oxlint, eslint, server-facts, `typecheck:app`, `typecheck:browser`. - Not run: a packaged Desktop build with a brand-new account. ## Linear Fixes [PM-2239](https://linear.app/comfyorg/issue/PM-2239/out-of-credits-banner-shows-on-a-new-account-even-though-free-credits).
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-27T07:34:16.705Z",
"gitSha": "76e705d72efe15c97eb87c4c44042b4df9d54788",
"branch": "backport-21538-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2045.1550000000225,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.058,
"layouts": 10,
"layoutDurationMs": 2.9979999999999998,
"taskDurationMs": 665.841,
"heapDeltaBytes": -1318196,
"heapUsedBytes": 88972580,
"domNodes": -200,
"jsHeapTotalBytes": 3465216,
"scriptDurationMs": 13.090000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.4440000000168,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8240000000000003,
"layouts": 9,
"layoutDurationMs": 2.587,
"taskDurationMs": 468.665,
"heapDeltaBytes": 1375896,
"heapUsedBytes": 91849832,
"domNodes": -200,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 11.239000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2090.1929999999993,
"styleRecalcs": 85,
"styleRecalcDurationMs": 15.868,
"layouts": 9,
"layoutDurationMs": 2.608,
"taskDurationMs": 1203.994,
"heapDeltaBytes": -17462252,
"heapUsedBytes": 89711788,
"domNodes": -180,
"jsHeapTotalBytes": 8015872,
"scriptDurationMs": 168.19,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666400000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.1869999999062,
"styleRecalcs": 79,
"styleRecalcDurationMs": 14.485000000000001,
"layouts": 10,
"layoutDurationMs": 3.3579999999999997,
"taskDurationMs": 973.3580000000001,
"heapDeltaBytes": 4737560,
"heapUsedBytes": 95462448,
"domNodes": -180,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 155.791,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.817272727272723,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.6189999999947,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.598999999999999,
"layouts": 11,
"layoutDurationMs": 3.408,
"taskDurationMs": 350.526,
"heapDeltaBytes": -809912,
"heapUsedBytes": 89823736,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 14.841999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.9380000000792,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.8709999999999996,
"layouts": 10,
"layoutDurationMs": 2.4859999999999993,
"taskDurationMs": 338.80699999999996,
"heapDeltaBytes": 25452280,
"heapUsedBytes": 115278692,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 13.687000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 661.8520000000103,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2680000000000002,
"layouts": 9,
"layoutDurationMs": 2.8189999999999995,
"taskDurationMs": 459.538,
"heapDeltaBytes": 3762396,
"heapUsedBytes": 93988104,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 166.855,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 729.6929999999975,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1710000000000003,
"layouts": 9,
"layoutDurationMs": 3.0349999999999997,
"taskDurationMs": 497.10699999999997,
"heapDeltaBytes": 4558400,
"heapUsedBytes": 94456796,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 181.82199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1230.3939999999898,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 898.463,
"heapDeltaBytes": -15298744,
"heapUsedBytes": 102200948,
"domNodes": -230,
"jsHeapTotalBytes": 15269888,
"scriptDurationMs": 66.499,
"eventListeners": -168,
"totalBlockingTimeMs": 543,
"frameDurationMs": 33.32972972972973,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1258.7559999999485,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 960.798,
"heapDeltaBytes": -16326988,
"heapUsedBytes": 102453976,
"domNodes": -230,
"jsHeapTotalBytes": 15532032,
"scriptDurationMs": 67.262,
"eventListeners": -168,
"totalBlockingTimeMs": 551,
"frameDurationMs": 33.78108108108107,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 822.2400000000221,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.7629999999998,
"heapDeltaBytes": -3967748,
"heapUsedBytes": 97418948,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.34599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 180,
"frameDurationMs": 24.017647058823542,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 826.3869999999542,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.9330000000002,
"heapDeltaBytes": -2097596,
"heapUsedBytes": 98346224,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.24900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 193,
"frameDurationMs": 24.508823529411742,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9767.544000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8920.587,
"heapDeltaBytes": 46983368,
"heapUsedBytes": 151404268,
"domNodes": -296,
"jsHeapTotalBytes": 37806080,
"scriptDurationMs": 7138.156,
"eventListeners": -130,
"totalBlockingTimeMs": 427,
"frameDurationMs": 31.39677419354839,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9224.99799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8390.464,
"heapDeltaBytes": 46105960,
"heapUsedBytes": 149738000,
"domNodes": -296,
"jsHeapTotalBytes": 24174592,
"scriptDurationMs": 6762.816,
"eventListeners": -130,
"totalBlockingTimeMs": 239,
"frameDurationMs": 29.923051948051953,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9467.787999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8602.975,
"heapDeltaBytes": 35469324,
"heapUsedBytes": 160076308,
"domNodes": -296,
"jsHeapTotalBytes": 32919552,
"scriptDurationMs": 6660.792,
"eventListeners": -130,
"totalBlockingTimeMs": 332,
"frameDurationMs": 31.345364238410593,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9409.963000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8596.984,
"heapDeltaBytes": 52569212,
"heapUsedBytes": 162504516,
"domNodes": -296,
"jsHeapTotalBytes": 35708928,
"scriptDurationMs": 6953.829,
"eventListeners": -130,
"totalBlockingTimeMs": 610,
"frameDurationMs": 31.75506756756757,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 227.83900000001722,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.934999999999997,
"layouts": 11,
"layoutDurationMs": 3.4540000000000006,
"taskDurationMs": 185.766,
"heapDeltaBytes": 15510352,
"heapUsedBytes": 121033228,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 8.857000000000003,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 236.8060000000014,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.960999999999999,
"layouts": 10,
"layoutDurationMs": 3.24,
"taskDurationMs": 204.709,
"heapDeltaBytes": 13273464,
"heapUsedBytes": 119137496,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 8.669999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 1,
"frameDurationMs": 22.73636363636367,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2056.1440000000175,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7439999999999998,
"layouts": 8,
"layoutDurationMs": 2.6960000000000006,
"taskDurationMs": 580.0450000000001,
"heapDeltaBytes": -526020,
"heapUsedBytes": 109710124,
"domNodes": -296,
"jsHeapTotalBytes": -729088,
"scriptDurationMs": 35.331,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2059.6060000000307,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.377,
"layouts": 8,
"layoutDurationMs": 2.502,
"taskDurationMs": 715.457,
"heapDeltaBytes": 971752,
"heapUsedBytes": 111236936,
"domNodes": -276,
"jsHeapTotalBytes": -299008,
"scriptDurationMs": 37.516999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2614.379999999983,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.212,
"layouts": 7,
"layoutDurationMs": 2.004,
"taskDurationMs": 1829.383,
"heapDeltaBytes": 863136,
"heapUsedBytes": 124879068,
"domNodes": -296,
"jsHeapTotalBytes": 5918720,
"scriptDurationMs": 833.423,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.773717948717948,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2264.788000000067,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.098000000000003,
"layouts": 7,
"layoutDurationMs": 1.758,
"taskDurationMs": 1560.54,
"heapDeltaBytes": 2481396,
"heapUsedBytes": 113494108,
"domNodes": -276,
"jsHeapTotalBytes": -241664,
"scriptDurationMs": 811.142,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66691176470588,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3668.0800000000318,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.979999999999999,
"layouts": 64,
"layoutDurationMs": 11.149,
"taskDurationMs": 1726.9900000000002,
"heapDeltaBytes": -17275596,
"heapUsedBytes": 95606032,
"domNodes": -272,
"jsHeapTotalBytes": -1384448,
"scriptDurationMs": 795.796,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74200913242009,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3592.932000000019,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.389000000000001,
"layouts": 65,
"layoutDurationMs": 11.385000000000002,
"taskDurationMs": 1649.1670000000004,
"heapDeltaBytes": 7526264,
"heapUsedBytes": 120635636,
"domNodes": 24,
"jsHeapTotalBytes": 5246976,
"scriptDurationMs": 792.7289999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3167.160000000024,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.506,
"layouts": 6,
"layoutDurationMs": 1.5339999999999998,
"taskDurationMs": 1890.015,
"heapDeltaBytes": -19719544,
"heapUsedBytes": 95745920,
"domNodes": 0,
"jsHeapTotalBytes": 2809856,
"scriptDurationMs": 1031.315,
"eventListeners": 182,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.022459893048126,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3165.0900000000775,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.3500000000000005,
"layouts": 6,
"layoutDurationMs": 1.94,
"taskDurationMs": 1925.441,
"heapDeltaBytes": -21580040,
"heapUsedBytes": 92879888,
"domNodes": 0,
"jsHeapTotalBytes": 712704,
"scriptDurationMs": 1041.224,
"eventListeners": 182,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.022459893048126,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2063.9580000000137,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2950000000000004,
"layouts": 7,
"layoutDurationMs": 2.221,
"taskDurationMs": 564.7429999999999,
"heapDeltaBytes": -64876,
"heapUsedBytes": 113066764,
"domNodes": -296,
"jsHeapTotalBytes": -1253376,
"scriptDurationMs": 34.888999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.5379999999886,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.322,
"layouts": 8,
"layoutDurationMs": 2.298,
"taskDurationMs": 730.533,
"heapDeltaBytes": -1717180,
"heapUsedBytes": 110669184,
"domNodes": -296,
"jsHeapTotalBytes": -561152,
"scriptDurationMs": 36.19599999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.3450000000321,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.632000000000001,
"layouts": 9,
"layoutDurationMs": 2.58,
"taskDurationMs": 410.077,
"heapDeltaBytes": -1134828,
"heapUsedBytes": 89584120,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 147.87900000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.2860000000055,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.253,
"layouts": 9,
"layoutDurationMs": 2.43,
"taskDurationMs": 391.882,
"heapDeltaBytes": -659112,
"heapUsedBytes": 89850900,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 146.095,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2041.5330000000154,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.841999999999999,
"layouts": 10,
"layoutDurationMs": 3.0719999999999996,
"taskDurationMs": 480.29900000000004,
"heapDeltaBytes": 6214824,
"heapUsedBytes": 97099240,
"domNodes": -218,
"jsHeapTotalBytes": 1630208,
"scriptDurationMs": 11.733,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2042.267000000038,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8719999999999994,
"layouts": 9,
"layoutDurationMs": 2.76,
"taskDurationMs": 618.9879999999999,
"heapDeltaBytes": -1340192,
"heapUsedBytes": 90239156,
"domNodes": -219,
"jsHeapTotalBytes": 843776,
"scriptDurationMs": 10.372000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2041.0969999999793,
"styleRecalcs": 89,
"styleRecalcDurationMs": 18.303,
"layouts": 10,
"layoutDurationMs": 2.936,
"taskDurationMs": 1184.95,
"heapDeltaBytes": -822708,
"heapUsedBytes": 89956048,
"domNodes": -210,
"jsHeapTotalBytes": 2940928,
"scriptDurationMs": 116.366,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1789.5910000000868,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.164999999999997,
"layouts": 10,
"layoutDurationMs": 3.034,
"taskDurationMs": 972.865,
"heapDeltaBytes": -17707852,
"heapUsedBytes": 84152520,
"domNodes": -198,
"jsHeapTotalBytes": 11685888,
"scriptDurationMs": 114.352,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.0579999999654,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.712000000000003,
"layouts": 5,
"layoutDurationMs": 14.203999999999997,
"taskDurationMs": 1060.3300000000002,
"heapDeltaBytes": 35632224,
"heapUsedBytes": 135547392,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 31.155,
"eventListeners": 3244,
"totalBlockingTimeMs": 160,
"frameDurationMs": 19.818918918918925,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8562.803999999971,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.161,
"layouts": 7,
"layoutDurationMs": 2.119,
"taskDurationMs": 5705.072999999999,
"heapDeltaBytes": -31418560,
"heapUsedBytes": 91258604,
"domNodes": -296,
"jsHeapTotalBytes": 188416,
"scriptDurationMs": 2838.0139999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73125,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8260.373000000072,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.465,
"layouts": 7,
"layoutDurationMs": 2.1359999999999997,
"taskDurationMs": 5492.665000000001,
"heapDeltaBytes": 2666984,
"heapUsedBytes": 113212152,
"domNodes": -276,
"jsHeapTotalBytes": -503808,
"scriptDurationMs": 2728.062,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699595959595957,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20097.338999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19488.108,
"heapDeltaBytes": -23942124,
"heapUsedBytes": 281044452,
"domNodes": -3344,
"jsHeapTotalBytes": 8114176,
"scriptDurationMs": 280.003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.214594594594594,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20541.694000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19949.048,
"heapDeltaBytes": -17554924,
"heapUsedBytes": 293168360,
"domNodes": -3344,
"jsHeapTotalBytes": 6279168,
"scriptDurationMs": 290.48799999999994,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.61238615664845,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 25269.898000000012,
"styleRecalcs": 180,
"styleRecalcDurationMs": 22.609999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24975.836,
"heapDeltaBytes": -23374300,
"heapUsedBytes": 296803680,
"domNodes": -3344,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 867.3689999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 48.18492366412214,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 16683.278000000086,
"styleRecalcs": 98,
"styleRecalcDurationMs": 17.78099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16294.627999999999,
"heapDeltaBytes": -8323592,
"heapUsedBytes": 297645660,
"domNodes": -3344,
"jsHeapTotalBytes": 6995968,
"scriptDurationMs": 922.7830000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 135,
"frameDurationMs": 30.31286231884058,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 5007.93299999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.27500000000002,
"layouts": 20,
"layoutDurationMs": 24.34399999999999,
"taskDurationMs": 4920.718000000001,
"heapDeltaBytes": -37498068,
"heapUsedBytes": 263080772,
"domNodes": -307,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 83.20700000000001,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.33684210526316,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 5060.7800000000225,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.80900000000001,
"layouts": 20,
"layoutDurationMs": 23.56799999999999,
"taskDurationMs": 4953.743,
"heapDeltaBytes": -35200460,
"heapUsedBytes": 293456528,
"domNodes": -3344,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 83.449,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.26279069767441,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6966.395000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6460.736000000001,
"heapDeltaBytes": 2735368,
"heapUsedBytes": 265039492,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.325,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.7914590747331,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10026.745000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9815.141000000001,
"heapDeltaBytes": 3083068,
"heapUsedBytes": 275627352,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 135.10900000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.23531598513011,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 130.2360000000249,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.793000000000001,
"layouts": 9,
"layoutDurationMs": 4.08,
"taskDurationMs": 97.83500000000001,
"heapDeltaBytes": 4823796,
"heapUsedBytes": 94981340,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.575000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 118.98299999995743,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.368000000000002,
"layouts": 8,
"layoutDurationMs": 3.1980000000000004,
"taskDurationMs": 84.16999999999999,
"heapDeltaBytes": 4678996,
"heapUsedBytes": 94799700,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.041,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 427.1280000000388,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6539999999999999,
"layouts": 76,
"layoutDurationMs": 15.620000000000001,
"taskDurationMs": 378.091,
"heapDeltaBytes": -15637560,
"heapUsedBytes": 79465076,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 172.47199999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 516.1200000000008,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.666,
"layouts": 76,
"layoutDurationMs": 16.464,
"taskDurationMs": 473.192,
"heapDeltaBytes": -14618120,
"heapUsedBytes": 81836340,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 228.299,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 634.4890000000305,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.169,
"layouts": 76,
"layoutDurationMs": 18.354,
"taskDurationMs": 596.101,
"heapDeltaBytes": 346484,
"heapUsedBytes": 117899776,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 233.63699999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.10263157894738,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 514.9380000000292,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.039,
"layouts": 76,
"layoutDurationMs": 16.246,
"taskDurationMs": 474.04099999999994,
"heapDeltaBytes": -530188,
"heapUsedBytes": 118354800,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 177.66700000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2983 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e791814e382b2a8836572e9d7d3ba37b4b9e88f3
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (124)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
This comment has been minimized.
This comment has been minimized.
threadListRoute does not exist on the 1.58 branches, so the backported AgentPanelRoot tests failed typecheck. Use the same endsWith check the 1.57 backport (#21590) uses.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.58 #22055 +/- ##
=============================================
Coverage ? 85.94%
=============================================
Files ? 2592
Lines ? 135361
Branches ? 38873
=============================================
Hits ? 116332
Misses ? 18612
Partials ? 417
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Faithful backport of #21538 to cloud/1.58 with three test-only URL matcher adaptations.
I applied merged source 340d406, which is on current main, to the target base. The resulting tree differs from this head only in three new unit-test matchers. Main uses a thread-list query-string matcher; cloud/1.58 has no such helper and its listThreads request uses /agent/threads without a query string. The backport uses the target's existing endsWith matcher. Production changes, the browser regression, and all source test cases are retained.
With the target's locked dependencies, all 777 tests across the three changed unit suites passed. Browser typechecking, targeted type-aware lint, and whitespace checks passed. The empty-thread, exhaustion-lifecycle, and free-use-placement browser specs passed all five cases on an explicitly Cloud-configured dev server with retries disabled. I discarded an initial localhost-build run after verifying the distribution mismatch; the Cloud server's initial run hit an app-setup timeout in an unchanged case, then the full warm run passed. The required lint-and-format, test, and e2e-status checks passed. Advisory coverage packaging failed on duplicate inner_clicked lcov records in unchanged LGraphCanvas.ts; the coverage merger is unchanged too. I found no backport divergence.
Backport of #21538 to
cloud/1.58Automatically created by backport workflow.