Repository navigation
[backport cloud/1.57] fix(agent): catalog-mismatch toast says the next message rebuilds the workflow (FE-3493) - #22046
Conversation
… workflow (FE-3493) (#21677) The catalog-mismatch sync toast now says what to do: a node changed, your canvas is untouched, and your next message lets the agent rebuild its copy. Before, it said "incompatible node catalog" with no way forward. Fixes https://linear.app/comfyorg/issue/FE-3493 - Copy in `src/locales/en/main.json`, plus a one-line change to `formatWorkflowSyncErrorDetail` so the host's raw message is not appended for this code (see the note on the frozen directory below) - The existing refused-follower e2e case now runs for `catalog_mismatch` too, and checks the toast copy and that the next message carries the canvas - The formatter no longer appends the host's raw message for `catalog_mismatch`, so the toast does not end by saying retrying will not help <details><summary>Full context for agent readers</summary> **Why the promise is true.** A `catalog_mismatch` `doc_subscribed` refusal is permanent (`PERMANENT_DOC_SUBSCRIBE_REFUSAL_CODES`), so the follower latches `terminal = 'refused'` and the toast fires once. `AgentPanelRoot.targetWorkflowDraft()` only withholds the canvas when the bound canvas may be stale, and a refusal does not mark it stale, so the next prompt posts the draft. On the server, `ensureDoc` treats a `catalog_mismatch` like a stale schema and re-mints from a posted canvas (`reseedCauseOf` / `canReseedStaleSchema` in `services/agent/internal/loop/crdt.go`). That re-mint is shared by hosted and local. On local, Comfy-Org/cloud#14302 (ING-213, merged 2026-10-19) is what makes the subscribe refuse in the first place, so a local build that shows this toast already has the recovery. **Hosted wording.** Hosted subscribe is a state-vector resync without a catalog check, so hosted rarely or never sends this refusal on subscribe. If it does, the same re-mint applies, so the copy still holds. **When the rebuild still fails closed** (server side, unchanged): the prompt targets a workflow the panel is not showing (no canvas posted), the canvas is empty, or `AGENT_STALE_SCHEMA_RESEED=off`. The copy says the next message *sends your canvas so the agent can rebuild*, which is what this frontend guarantees. It does not promise the server outcome. **The raw host message, resolved in this PR (was listed here as a leftover).** `formatWorkflowSyncErrorDetail` used to append the host's raw `message` for every code. For this one the local agent sends `the document was minted under a different widget catalog; retrying will not help` (`catalogMismatchMessage`, `services/agent/local/internal/server/events_doc_frames.go:349`), and the hosted path sends the identical string from `socketDocCode` (`services/agent/server/events_doc_frames.go:637`), so the rendered toast ended by contradicting the new copy. The formatter now returns the localized detail alone for `catalog_mismatch` and still appends the raw message for every other code, which covers both senders where a cloud-side wording change would have needed two edits. Raised by @dante01yoon in review and fixed in `391fb7ad`. **Note on the frozen directory.** That fix edits `src/workbench/extensions/agent/crdt/`, which the informal remote-ops/ECS freeze names. It is copy formatting rather than remote-apply or reconcile work, and the refactor the freeze was protecting landed in #18700, but flagging it so a reviewer can weigh it rather than discover it. **Verification** - `pnpm exec playwright test browser_tests/tests/agent/boundCanvasReadPath.spec.ts --project=cloud`: 4 passed locally (DISTRIBUTION=cloud dev server, own ComfyUI container) - Mutation check: pointing `catalog_mismatch` at the generic detail key fails the new case on the detail assertion; reverted - Mutation check on the formatter: reverting the `catalog_mismatch` arm turns `workflowSyncErrorDetail.test.ts` red and fails the browser case on the rendered toast text; reverted - Toast rendered and inspected: title plus the full new detail, no truncation - `pnpm typecheck:browser`, oxfmt, oxlint green (pre-commit + pre-push) Other locales are regenerated by the i18n workflow, as usual. </details> (cherry picked from commit 740e609)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-27T03:26:54.836Z",
"gitSha": "129c02c4011c2193cc0dfd63d9e8a6d3717616c1",
"branch": "backport-21677-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.1609999999828,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2960000000000003,
"layouts": 9,
"layoutDurationMs": 2.277,
"taskDurationMs": 449.161,
"heapDeltaBytes": -901912,
"heapUsedBytes": 74128448,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.464,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2025.7170000000997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6439999999999997,
"layouts": 10,
"layoutDurationMs": 2.6060000000000003,
"taskDurationMs": 445.726,
"heapDeltaBytes": 2734224,
"heapUsedBytes": 77771588,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 10.059999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1712.1010000000183,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.338000000000001,
"layouts": 9,
"layoutDurationMs": 2.019,
"taskDurationMs": 722.314,
"heapDeltaBytes": -3489424,
"heapUsedBytes": 71111328,
"domNodes": 0,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 123.69899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.7830000000213,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.149000000000003,
"layouts": 10,
"layoutDurationMs": 2.5869999999999997,
"taskDurationMs": 769.312,
"heapDeltaBytes": -2422404,
"heapUsedBytes": 72748452,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 132.771,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.995999999976,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.969,
"layouts": 13,
"layoutDurationMs": 3.309,
"taskDurationMs": 348.066,
"heapDeltaBytes": -4481460,
"heapUsedBytes": 70519144,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.46,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1821.399999999926,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.454,
"layouts": 13,
"layoutDurationMs": 3.006,
"taskDurationMs": 415.93300000000005,
"heapDeltaBytes": -4538400,
"heapUsedBytes": 70524320,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.498,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 551.1960000000045,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.0430000000000006,
"layouts": 9,
"layoutDurationMs": 2.0669999999999997,
"taskDurationMs": 367.938,
"heapDeltaBytes": 24755472,
"heapUsedBytes": 91522600,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 139.10899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 635.1319999999987,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.3099999999999996,
"layouts": 9,
"layoutDurationMs": 2.2279999999999998,
"taskDurationMs": 452.70700000000005,
"heapDeltaBytes": 2785120,
"heapUsedBytes": 77497088,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 147.68300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736848,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1128.3920000000194,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 800.5429999999999,
"heapDeltaBytes": -13024868,
"heapUsedBytes": 81183340,
"domNodes": -192,
"jsHeapTotalBytes": 22028288,
"scriptDurationMs": 53.54400000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 442,
"frameDurationMs": 30.62972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1150.794000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 831.09,
"heapDeltaBytes": -12428868,
"heapUsedBytes": 81737392,
"domNodes": -192,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 65.33,
"eventListeners": -106,
"totalBlockingTimeMs": 462,
"frameDurationMs": 31.078378378378382,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 810.8899999999721,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.53199999999987,
"heapDeltaBytes": -4351748,
"heapUsedBytes": 76420608,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 127.00100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 154,
"frameDurationMs": 22.85428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 760.577000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.0700000000001,
"heapDeltaBytes": -4340572,
"heapUsedBytes": 76927772,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 110.78699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 135,
"frameDurationMs": 22.547058823529422,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8467.677999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7514.034000000001,
"heapDeltaBytes": -2640528,
"heapUsedBytes": 96985568,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 5853.036999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 251,
"frameDurationMs": 25.733738601823713,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8393.08699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7403.891,
"heapDeltaBytes": 1665256,
"heapUsedBytes": 98931416,
"domNodes": -258,
"jsHeapTotalBytes": 13234176,
"scriptDurationMs": 5757.058,
"eventListeners": -68,
"totalBlockingTimeMs": 92,
"frameDurationMs": 25.557926829268297,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6943.967000000043,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5069999999999997,
"layouts": 3,
"layoutDurationMs": 0.687,
"taskDurationMs": 6238.268,
"heapDeltaBytes": -21560236,
"heapUsedBytes": 78626092,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 4989.215999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 129,
"frameDurationMs": 25.27163636363636,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7871.960000000001,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.43099999999999994,
"layouts": 2,
"layoutDurationMs": 0.39499999999999996,
"taskDurationMs": 6960.202,
"heapDeltaBytes": 6852564,
"heapUsedBytes": 83853876,
"domNodes": -258,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 5358.379999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 88,
"frameDurationMs": 24.42950310559006,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 173.3880000000454,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.963,
"layouts": 11,
"layoutDurationMs": 2.8750000000000004,
"taskDurationMs": 135.164,
"heapDeltaBytes": -8213092,
"heapUsedBytes": 79677128,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.388999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.912500000000023,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 196.54500000001462,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.314999999999998,
"layouts": 12,
"layoutDurationMs": 3.291,
"taskDurationMs": 145.8,
"heapDeltaBytes": -8120160,
"heapUsedBytes": 79740924,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.031,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.92500000000001,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2042.5670000000196,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4179999999999993,
"layouts": 9,
"layoutDurationMs": 2.398,
"taskDurationMs": 574.946,
"heapDeltaBytes": -25351852,
"heapUsedBytes": 72305724,
"domNodes": -258,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 34.001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.6829999999873,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8789999999999996,
"layouts": 8,
"layoutDurationMs": 1.8079999999999998,
"taskDurationMs": 434.38100000000003,
"heapDeltaBytes": -2410412,
"heapUsedBytes": 77593976,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 31.537999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2172.699000000023,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.386,
"layouts": 7,
"layoutDurationMs": 1.58,
"taskDurationMs": 1426.0159999999996,
"heapDeltaBytes": 7816504,
"heapUsedBytes": 87865412,
"domNodes": -278,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 664.327,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2200.5830000000515,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.7669999999999995,
"layouts": 8,
"layoutDurationMs": 1.8150000000000002,
"taskDurationMs": 1475.8010000000002,
"heapDeltaBytes": -6060240,
"heapUsedBytes": 70902164,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 702.4599999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564885496183,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3371.667000000002,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.324,
"layouts": 64,
"layoutDurationMs": 11.488,
"taskDurationMs": 1407.095,
"heapDeltaBytes": 682240,
"heapUsedBytes": 82794692,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 669.728,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.748756218905474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3476.762000000008,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.121,
"layouts": 66,
"layoutDurationMs": 12.241,
"taskDurationMs": 1639.8809999999999,
"heapDeltaBytes": -11153664,
"heapUsedBytes": 88755768,
"domNodes": -234,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 688.567,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.746376811594207,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2648.994000000016,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.991,
"layouts": 4,
"layoutDurationMs": 1.0019999999999998,
"taskDurationMs": 1697.9289999999999,
"heapDeltaBytes": 10030400,
"heapUsedBytes": 94045112,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 805.7189999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.878846153846155,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2574.9799999999823,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.925,
"layouts": 5,
"layoutDurationMs": 1.141,
"taskDurationMs": 1655.71,
"heapDeltaBytes": -1297064,
"heapUsedBytes": 82358724,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 788.0619999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77516339869281,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.6360000000254,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.752000000000001,
"layouts": 7,
"layoutDurationMs": 1.6460000000000001,
"taskDurationMs": 568.7739999999999,
"heapDeltaBytes": -2402868,
"heapUsedBytes": 79652500,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 32.30499999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2041.9259999999895,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9999999999999991,
"layouts": 8,
"layoutDurationMs": 2.0359999999999996,
"taskDurationMs": 558.263,
"heapDeltaBytes": -6013696,
"heapUsedBytes": 76160968,
"domNodes": -278,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 30.559999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.2090000000076,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.5200000000000005,
"layouts": 9,
"layoutDurationMs": 2.3780000000000006,
"taskDurationMs": 405.029,
"heapDeltaBytes": 21571764,
"heapUsedBytes": 88595612,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 122.998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.9249999999547,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.420999999999999,
"layouts": 11,
"layoutDurationMs": 2.566,
"taskDurationMs": 376.791,
"heapDeltaBytes": -1481100,
"heapUsedBytes": 75994804,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 120.86600000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.3570000000227,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.025,
"layouts": 9,
"layoutDurationMs": 2.1870000000000003,
"taskDurationMs": 329.624,
"heapDeltaBytes": 21585116,
"heapUsedBytes": 88571720,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 9.645999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2007.1970000000192,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.202,
"layouts": 9,
"layoutDurationMs": 2.156,
"taskDurationMs": 446.722,
"heapDeltaBytes": 22456748,
"heapUsedBytes": 90342720,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.108,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.000999999981,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.573000000000002,
"layouts": 9,
"layoutDurationMs": 2.072,
"taskDurationMs": 700.646,
"heapDeltaBytes": 10928496,
"heapUsedBytes": 78136908,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 93.71099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1944.6759999999585,
"styleRecalcs": 85,
"styleRecalcDurationMs": 15.064999999999998,
"layouts": 9,
"layoutDurationMs": 1.9549999999999996,
"taskDurationMs": 805.6220000000001,
"heapDeltaBytes": 11699972,
"heapUsedBytes": 78705492,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 91.624,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1351.241000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.669,
"layouts": 5,
"layoutDurationMs": 10.562999999999999,
"taskDurationMs": 853.4289999999997,
"heapDeltaBytes": 2228036,
"heapUsedBytes": 110079516,
"domNodes": 15953,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 26.322,
"eventListeners": 3244,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.247887323943655,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8298.577000000023,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.555,
"layouts": 8,
"layoutDurationMs": 1.8830000000000002,
"taskDurationMs": 5234.736,
"heapDeltaBytes": 7853064,
"heapUsedBytes": 87382512,
"domNodes": -258,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2309.288,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733266129032256,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8332.922000000053,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.320999999999998,
"layouts": 8,
"layoutDurationMs": 1.6059999999999999,
"taskDurationMs": 5092.035999999999,
"heapDeltaBytes": -977884,
"heapUsedBytes": 78478348,
"domNodes": -278,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2276.2729999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699198396793587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13175.160000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12677.849,
"heapDeltaBytes": -19868136,
"heapUsedBytes": 263333108,
"domNodes": -3359,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 200.98400000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.690444810543656,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 18520.696000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17599.011000000002,
"heapDeltaBytes": -47597044,
"heapUsedBytes": 253066716,
"domNodes": -3330,
"jsHeapTotalBytes": 5230592,
"scriptDurationMs": 296.462,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.31413612565446,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21960.484000000008,
"styleRecalcs": 159,
"styleRecalcDurationMs": 16.227000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21641.35,
"heapDeltaBytes": -6081756,
"heapUsedBytes": 284806928,
"domNodes": -3330,
"jsHeapTotalBytes": 6475776,
"scriptDurationMs": 767,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 40.01074681238615,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 16634.46499999998,
"styleRecalcs": 105,
"styleRecalcDurationMs": 11.026000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16022.32,
"heapDeltaBytes": -23318892,
"heapUsedBytes": 271642232,
"domNodes": -3330,
"jsHeapTotalBytes": 14147584,
"scriptDurationMs": 777.221,
"eventListeners": -651,
"totalBlockingTimeMs": 22,
"frameDurationMs": 29.707843137254905,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 6440.491000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.731,
"layouts": 20,
"layoutDurationMs": 22.785,
"taskDurationMs": 6336.057000000001,
"heapDeltaBytes": -15886128,
"heapUsedBytes": 260745052,
"domNodes": -3330,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 108.806,
"eventListeners": -653,
"totalBlockingTimeMs": 10,
"frameDurationMs": 37.93941176470588,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6427.4769999999535,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.841,
"layouts": 20,
"layoutDurationMs": 22.493,
"taskDurationMs": 6310.709,
"heapDeltaBytes": -26845812,
"heapUsedBytes": 273699396,
"domNodes": -3330,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 108.021,
"eventListeners": -653,
"totalBlockingTimeMs": 6,
"frameDurationMs": 34.773513513513514,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9340.862999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8760.645,
"heapDeltaBytes": -24457536,
"heapUsedBytes": 248085640,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.637,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.693559322033906,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9239.998000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8861.088,
"heapDeltaBytes": -152888,
"heapUsedBytes": 269575180,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 129.84900000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.785910652920965,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 465.13699999997016,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.597999999999999,
"layouts": 12,
"layoutDurationMs": 4.025,
"taskDurationMs": 133.36199999999997,
"heapDeltaBytes": -12938376,
"heapUsedBytes": 70925452,
"domNodes": 124,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.72,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 447.75800000002164,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.573,
"layouts": 12,
"layoutDurationMs": 2.783,
"taskDurationMs": 95.14000000000001,
"heapDeltaBytes": 6456984,
"heapUsedBytes": 79827204,
"domNodes": 95,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.193,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 353.45699999993485,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.983,
"layouts": 76,
"layoutDurationMs": 13.475000000000001,
"taskDurationMs": 305.89200000000005,
"heapDeltaBytes": 10281272,
"heapUsedBytes": 98723444,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 138.52599999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 310.3290000000243,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.365,
"layouts": 76,
"layoutDurationMs": 13.781,
"taskDurationMs": 272.924,
"heapDeltaBytes": -14602832,
"heapUsedBytes": 78730512,
"domNodes": 4,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 122.43900000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 391.34500000000116,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9120000000000001,
"layouts": 76,
"layoutDurationMs": 13.07,
"taskDurationMs": 354.52099999999996,
"heapDeltaBytes": -879220,
"heapUsedBytes": 121435176,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 133.589,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 409.92000000005646,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.774,
"layouts": 76,
"layoutDurationMs": 13.337,
"taskDurationMs": 363.58000000000004,
"heapDeltaBytes": -5711068,
"heapUsedBytes": 105964180,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 142.095,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2284 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e9668f81a8bf74011afab7499206c33a5fb37a93
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #22046 +/- ##
=============================================
Coverage ? 85.21%
=============================================
Files ? 2524
Lines ? 133150
Branches ? 38350
=============================================
Hits ? 113469
Misses ? 19265
Partials ? 416
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Faithful backport of #21677 to cloud/1.57 with a justified test adaptation.
I compared this head with merged source 740e609, which is on current main. The locale, formatter, and formatter regression test have identical changed lines. The only adaptation omits the source's browser-test changes: I verified that cloud/1.57 lacks both the bound-canvas read-path spec and its permanent-subscribe-refusal helper. The formatter regression test is retained. The target still supplies its serialized canvas with the next message and uses the changed formatter for the sync-error toast.
With cloud/1.57's locked dependencies, I ran the formatter, document-lifecycle, and follower suites: all 154 tests passed, including all seven formatter cases. Targeted type-aware lint and whitespace checks passed. The branch's required lint-and-format, test, and e2e-status checks passed. The advisory coverage-packaging job failed because lcov rejected duplicate inner_clicked records in unchanged LGraphCanvas.ts; the coverage merger is also unchanged by this PR. I am not treating that packaging failure as a backport divergence.
Backport of #21677 to
cloud/1.57.Full context for agent readers
Auto-backport failed on conflicts in test files only (
browser_tests/tests/agent/agentPanelMocks.ts,browser_tests/tests/agent/boundCanvasReadPath.spec.ts).src/locales/en/main.json,workflowSyncErrorDetail.tsand its unit test applied cleanly.Tests: Unit test for the toast text. The e2e spec
boundCanvasReadPath.spec.tsdoes not exist on this branch, so its change is dropped;agentPanelMocks.tsis unchanged.vitest run workflowSyncErrorDetail.test.ts: 7 passed locally;pnpm typecheck:browserpassed on the 1.58 branch.Why backport: local agent users on ComfyUI stable run older frontend trains. The local agent fix this copy describes (Comfy-Org/cloud#14302) ships in the local agent package, so without this they see the old dead-end message.