Repository navigation
[backport core/1.58] fix(agent): catalog-mismatch toast says the next message rebuilds the workflow (FE-3493) - #22043
Conversation
… workflow (FE-3493) (#21677) The catalog-mismatch sync toast now says what to do: a node changed, your canvas is untouched, and your next message lets the agent rebuild its copy. Before, it said "incompatible node catalog" with no way forward. Fixes https://linear.app/comfyorg/issue/FE-3493 - Copy in `src/locales/en/main.json`, plus a one-line change to `formatWorkflowSyncErrorDetail` so the host's raw message is not appended for this code (see the note on the frozen directory below) - The existing refused-follower e2e case now runs for `catalog_mismatch` too, and checks the toast copy and that the next message carries the canvas - The formatter no longer appends the host's raw message for `catalog_mismatch`, so the toast does not end by saying retrying will not help <details><summary>Full context for agent readers</summary> **Why the promise is true.** A `catalog_mismatch` `doc_subscribed` refusal is permanent (`PERMANENT_DOC_SUBSCRIBE_REFUSAL_CODES`), so the follower latches `terminal = 'refused'` and the toast fires once. `AgentPanelRoot.targetWorkflowDraft()` only withholds the canvas when the bound canvas may be stale, and a refusal does not mark it stale, so the next prompt posts the draft. On the server, `ensureDoc` treats a `catalog_mismatch` like a stale schema and re-mints from a posted canvas (`reseedCauseOf` / `canReseedStaleSchema` in `services/agent/internal/loop/crdt.go`). That re-mint is shared by hosted and local. On local, Comfy-Org/cloud#14302 (ING-213, merged 2026-10-19) is what makes the subscribe refuse in the first place, so a local build that shows this toast already has the recovery. **Hosted wording.** Hosted subscribe is a state-vector resync without a catalog check, so hosted rarely or never sends this refusal on subscribe. If it does, the same re-mint applies, so the copy still holds. **When the rebuild still fails closed** (server side, unchanged): the prompt targets a workflow the panel is not showing (no canvas posted), the canvas is empty, or `AGENT_STALE_SCHEMA_RESEED=off`. The copy says the next message *sends your canvas so the agent can rebuild*, which is what this frontend guarantees. It does not promise the server outcome. **The raw host message, resolved in this PR (was listed here as a leftover).** `formatWorkflowSyncErrorDetail` used to append the host's raw `message` for every code. For this one the local agent sends `the document was minted under a different widget catalog; retrying will not help` (`catalogMismatchMessage`, `services/agent/local/internal/server/events_doc_frames.go:349`), and the hosted path sends the identical string from `socketDocCode` (`services/agent/server/events_doc_frames.go:637`), so the rendered toast ended by contradicting the new copy. The formatter now returns the localized detail alone for `catalog_mismatch` and still appends the raw message for every other code, which covers both senders where a cloud-side wording change would have needed two edits. Raised by @dante01yoon in review and fixed in `391fb7ad`. **Note on the frozen directory.** That fix edits `src/workbench/extensions/agent/crdt/`, which the informal remote-ops/ECS freeze names. It is copy formatting rather than remote-apply or reconcile work, and the refactor the freeze was protecting landed in #18700, but flagging it so a reviewer can weigh it rather than discover it. **Verification** - `pnpm exec playwright test browser_tests/tests/agent/boundCanvasReadPath.spec.ts --project=cloud`: 4 passed locally (DISTRIBUTION=cloud dev server, own ComfyUI container) - Mutation check: pointing `catalog_mismatch` at the generic detail key fails the new case on the detail assertion; reverted - Mutation check on the formatter: reverting the `catalog_mismatch` arm turns `workflowSyncErrorDetail.test.ts` red and fails the browser case on the rendered toast text; reverted - Toast rendered and inspected: title plus the full new detail, no truncation - `pnpm typecheck:browser`, oxfmt, oxlint green (pre-commit + pre-push) Other locales are regenerated by the i18n workflow, as usual. </details> (cherry picked from commit 740e609)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-27T03:49:41.919Z",
"gitSha": "699621ac10125f9e5ecc33e6874a0866446fa989",
"branch": "backport-21677-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.970000000015,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.548,
"layouts": 10,
"layoutDurationMs": 2.246,
"taskDurationMs": 347.01699999999994,
"heapDeltaBytes": -36680,
"heapUsedBytes": 90253940,
"domNodes": -200,
"jsHeapTotalBytes": 1363968,
"scriptDurationMs": 8.687999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2019.900000000007,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.141,
"layouts": 10,
"layoutDurationMs": 2.8310000000000004,
"taskDurationMs": 501.20799999999997,
"heapDeltaBytes": 5830240,
"heapUsedBytes": 104914492,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 10.472999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1996.891000000005,
"styleRecalcs": 82,
"styleRecalcDurationMs": 12.052,
"layouts": 10,
"layoutDurationMs": 2.24,
"taskDurationMs": 944.125,
"heapDeltaBytes": 598640,
"heapUsedBytes": 91178936,
"domNodes": -200,
"jsHeapTotalBytes": 2936832,
"scriptDurationMs": 123.38199999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1729.325000000017,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.403,
"layouts": 9,
"layoutDurationMs": 2.2249999999999996,
"taskDurationMs": 676.257,
"heapDeltaBytes": 6753048,
"heapUsedBytes": 96688144,
"domNodes": -180,
"jsHeapTotalBytes": 1626112,
"scriptDurationMs": 128.98299999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.8169999999827,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.348000000000001,
"layouts": 11,
"layoutDurationMs": 2.6629999999999994,
"taskDurationMs": 277.74100000000004,
"heapDeltaBytes": 24079500,
"heapUsedBytes": 114345420,
"domNodes": 47,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.721,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.04899999996,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.055000000000001,
"layouts": 12,
"layoutDurationMs": 2.9610000000000003,
"taskDurationMs": 344.79099999999994,
"heapDeltaBytes": -837336,
"heapUsedBytes": 99815324,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.606999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 596.2989999999877,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.731,
"layouts": 10,
"layoutDurationMs": 2.491,
"taskDurationMs": 426.67799999999994,
"heapDeltaBytes": 5335188,
"heapUsedBytes": 96396060,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 140.417,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 626.1969999999906,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9239999999999995,
"layouts": 9,
"layoutDurationMs": 2.28,
"taskDurationMs": 464.83299999999997,
"heapDeltaBytes": 4323912,
"heapUsedBytes": 104230400,
"domNodes": 0,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 143.29199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631583,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1048.0960000000152,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 710.2549999999999,
"heapDeltaBytes": -15195008,
"heapUsedBytes": 102397416,
"domNodes": -216,
"jsHeapTotalBytes": 14217216,
"scriptDurationMs": 48.929,
"eventListeners": -168,
"totalBlockingTimeMs": 367,
"frameDurationMs": 28.37837837837838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1087.3019999999656,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 720.212,
"heapDeltaBytes": -14575040,
"heapUsedBytes": 102776964,
"domNodes": -210,
"jsHeapTotalBytes": 14217216,
"scriptDurationMs": 56.852,
"eventListeners": -168,
"totalBlockingTimeMs": 404,
"frameDurationMs": 29.278378378378385,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 785.09600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.021,
"heapDeltaBytes": -3291328,
"heapUsedBytes": 97241856,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.82299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.612999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.8400000000003,
"heapDeltaBytes": -3962968,
"heapUsedBytes": 96665112,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.93100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 23.04117647058825,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8079.424000000017,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.31699999999999956,
"layouts": 1,
"layoutDurationMs": 0.294,
"taskDurationMs": 7171.367,
"heapDeltaBytes": 48850296,
"heapUsedBytes": 158767344,
"domNodes": -276,
"jsHeapTotalBytes": 39374848,
"scriptDurationMs": 5829.3949999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 104,
"frameDurationMs": 25.526582278481015,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7439.549999999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7429999999999998,
"layouts": 2,
"layoutDurationMs": 0.6000000000000003,
"taskDurationMs": 6623.206999999999,
"heapDeltaBytes": 34851628,
"heapUsedBytes": 149084300,
"domNodes": -276,
"jsHeapTotalBytes": 35274752,
"scriptDurationMs": 4960.796,
"eventListeners": -130,
"totalBlockingTimeMs": 27,
"frameDurationMs": 23.5968253968254,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7663.99899999999,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5929999999999997,
"layouts": 2,
"layoutDurationMs": 0.4580000000000001,
"taskDurationMs": 6850.221,
"heapDeltaBytes": -6548196,
"heapUsedBytes": 113212780,
"domNodes": -276,
"jsHeapTotalBytes": -901120,
"scriptDurationMs": 5415.2339999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 93,
"frameDurationMs": 24.57179487179487,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7285.524000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6471.525,
"heapDeltaBytes": 25427760,
"heapUsedBytes": 129354528,
"domNodes": -296,
"jsHeapTotalBytes": 27578368,
"scriptDurationMs": 5131.552,
"eventListeners": -130,
"totalBlockingTimeMs": 40,
"frameDurationMs": 24.35819397993311,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 168.96800000000667,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.89,
"layouts": 12,
"layoutDurationMs": 2.795,
"taskDurationMs": 120.857,
"heapDeltaBytes": 13344560,
"heapUsedBytes": 118576992,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.925999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.355555555555537,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 197.1709999999689,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.714,
"layouts": 12,
"layoutDurationMs": 3.4619999999999997,
"taskDurationMs": 137.36499999999998,
"heapDeltaBytes": 13300908,
"heapUsedBytes": 119338172,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 8.164000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2042.3929999999757,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.255,
"layouts": 9,
"layoutDurationMs": 2.034,
"taskDurationMs": 542.8720000000001,
"heapDeltaBytes": -674956,
"heapUsedBytes": 104357768,
"domNodes": -296,
"jsHeapTotalBytes": -3260416,
"scriptDurationMs": 28.438,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.6740000000436,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5130000000000003,
"layouts": 9,
"layoutDurationMs": 2.267,
"taskDurationMs": 632.825,
"heapDeltaBytes": -19931728,
"heapUsedBytes": 104725652,
"domNodes": -276,
"jsHeapTotalBytes": -696320,
"scriptDurationMs": 31.93,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2313.389000000001,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.878999999999998,
"layouts": 7,
"layoutDurationMs": 1.5339999999999998,
"taskDurationMs": 1372.7659999999998,
"heapDeltaBytes": -15455544,
"heapUsedBytes": 107533208,
"domNodes": -296,
"jsHeapTotalBytes": -638976,
"scriptDurationMs": 633.579,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786231884057973,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2766.7829999999753,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.546000000000001,
"layouts": 7,
"layoutDurationMs": 1.693,
"taskDurationMs": 1487.8189999999997,
"heapDeltaBytes": 1138784,
"heapUsedBytes": 104931364,
"domNodes": -276,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 699.2009999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3290.4179999999883,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.028,
"layouts": 67,
"layoutDurationMs": 11.155,
"taskDurationMs": 1422.51,
"heapDeltaBytes": -16112660,
"heapUsedBytes": 97846600,
"domNodes": -272,
"jsHeapTotalBytes": -77824,
"scriptDurationMs": 653.2410000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.750510204081635,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3338.2519999999545,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.369999999999997,
"layouts": 66,
"layoutDurationMs": 11.29,
"taskDurationMs": 1416.198,
"heapDeltaBytes": -12249540,
"heapUsedBytes": 100732584,
"domNodes": -252,
"jsHeapTotalBytes": -339968,
"scriptDurationMs": 650.4830000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2196.419999999989,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.892,
"layouts": 7,
"layoutDurationMs": 1.7630000000000001,
"taskDurationMs": 1441.49,
"heapDeltaBytes": -11787328,
"heapUsedBytes": 102386520,
"domNodes": 0,
"jsHeapTotalBytes": 6295552,
"scriptDurationMs": 764.2909999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.921538461538464,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2514.043000000015,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.118,
"layouts": 7,
"layoutDurationMs": 2.0170000000000003,
"taskDurationMs": 1652.5090000000002,
"heapDeltaBytes": -12325328,
"heapUsedBytes": 102872808,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 798.588,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77785234899329,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.6670000000272,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3369999999999997,
"layouts": 8,
"layoutDurationMs": 2.1060000000000003,
"taskDurationMs": 588.4720000000001,
"heapDeltaBytes": -1430964,
"heapUsedBytes": 111782616,
"domNodes": -296,
"jsHeapTotalBytes": -995328,
"scriptDurationMs": 31.446,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2062.979000000041,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5599999999999996,
"layouts": 8,
"layoutDurationMs": 2.216,
"taskDurationMs": 618.699,
"heapDeltaBytes": -6365244,
"heapUsedBytes": 113306116,
"domNodes": -296,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 38.004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.3589999999854,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.289,
"layouts": 10,
"layoutDurationMs": 2.5170000000000003,
"taskDurationMs": 374.601,
"heapDeltaBytes": 22856060,
"heapUsedBytes": 114741992,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 126.913,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.95100000004,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.2139999999999995,
"layouts": 9,
"layoutDurationMs": 2.088,
"taskDurationMs": 338.18199999999996,
"heapDeltaBytes": -835836,
"heapUsedBytes": 90320724,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 127.03800000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.447000000018,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8299999999999996,
"layouts": 10,
"layoutDurationMs": 2.412,
"taskDurationMs": 436.133,
"heapDeltaBytes": 6975608,
"heapUsedBytes": 116312744,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 7.009000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.1540000000236,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.756,
"layouts": 9,
"layoutDurationMs": 2.609,
"taskDurationMs": 413.04799999999994,
"heapDeltaBytes": 7580540,
"heapUsedBytes": 98629560,
"domNodes": -198,
"jsHeapTotalBytes": 1888256,
"scriptDurationMs": 10.220000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.5829999999796,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.096,
"layouts": 10,
"layoutDurationMs": 2.313,
"taskDurationMs": 565.0959999999999,
"heapDeltaBytes": -6350312,
"heapUsedBytes": 95435656,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 91.33000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.4239999999932,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.469,
"layouts": 10,
"layoutDurationMs": 2.544,
"taskDurationMs": 736.672,
"heapDeltaBytes": -5541932,
"heapUsedBytes": 95907588,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 97.81700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7279999999914,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.454999999999995,
"layouts": 5,
"layoutDurationMs": 12.684000000000001,
"taskDurationMs": 986.805,
"heapDeltaBytes": 39738924,
"heapUsedBytes": 171183464,
"domNodes": 16030,
"jsHeapTotalBytes": 43655168,
"scriptDurationMs": 28.942999999999998,
"eventListeners": 3244,
"totalBlockingTimeMs": 128,
"frameDurationMs": 19.144594594594604,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9577.50100000004,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.651,
"layouts": 9,
"layoutDurationMs": 2.115,
"taskDurationMs": 5040.525000000001,
"heapDeltaBytes": -5791876,
"heapUsedBytes": 104588308,
"domNodes": -297,
"jsHeapTotalBytes": -278528,
"scriptDurationMs": 2196.48,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665913043478263,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10497.891999999978,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.415,
"layouts": 8,
"layoutDurationMs": 2.019,
"taskDurationMs": 5266.795,
"heapDeltaBytes": -13192128,
"heapUsedBytes": 109184372,
"domNodes": -296,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 2369.9500000000003,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.853130016051363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19999.758999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19495.246,
"heapDeltaBytes": -30130376,
"heapUsedBytes": 289380544,
"domNodes": -3344,
"jsHeapTotalBytes": 19124224,
"scriptDurationMs": 264.145,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.83075506445672,
"p95FrameDurationMs": 66.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14553.078000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14065.068,
"heapDeltaBytes": -32559616,
"heapUsedBytes": 278127800,
"domNodes": -3344,
"jsHeapTotalBytes": 27512832,
"scriptDurationMs": 209.73500000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.751150442477876,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 25129.38600000001,
"styleRecalcs": 178,
"styleRecalcDurationMs": 23.24200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24814.903,
"heapDeltaBytes": -14632080,
"heapUsedBytes": 286935252,
"domNodes": -3344,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 800.585,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 48.550386100386106,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 23324.430000000008,
"styleRecalcs": 178,
"styleRecalcDurationMs": 20.661000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23027.445,
"heapDeltaBytes": -12845692,
"heapUsedBytes": 306653084,
"domNodes": -3373,
"jsHeapTotalBytes": 13549568,
"scriptDurationMs": 739.507,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.527480916030534,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 5433.343999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.798000000000016,
"layouts": 20,
"layoutDurationMs": 23.319000000000006,
"taskDurationMs": 5335.36,
"heapDeltaBytes": -5519876,
"heapUsedBytes": 300377668,
"domNodes": -3394,
"jsHeapTotalBytes": 26202112,
"scriptDurationMs": 89.71500000000002,
"eventListeners": -691,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.539106145251395,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "vue-node-resize-workload",
"durationMs": 7027.238000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.848999999999975,
"layouts": 20,
"layoutDurationMs": 21.239999999999995,
"taskDurationMs": 6957.948,
"heapDeltaBytes": -36148008,
"heapUsedBytes": 293654416,
"domNodes": -3344,
"jsHeapTotalBytes": 23056384,
"scriptDurationMs": 101.774,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.61597633136094,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7339.157,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7111.629000000001,
"heapDeltaBytes": 314484,
"heapUsedBytes": 270774388,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.568,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.79399293286219,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9893.847999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9518.396,
"heapDeltaBytes": 150800,
"heapUsedBytes": 293566604,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 128.85100000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.61398601398601,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 444.57700000003797,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.5760000000000005,
"layouts": 12,
"layoutDurationMs": 3.5660000000000003,
"taskDurationMs": 107.83499999999998,
"heapDeltaBytes": 7008056,
"heapUsedBytes": 104795504,
"domNodes": 98,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 8.384999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 458.1749999999829,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.076000000000002,
"layouts": 12,
"layoutDurationMs": 3.4360000000000004,
"taskDurationMs": 105.027,
"heapDeltaBytes": 7039832,
"heapUsedBytes": 97210184,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.793,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 304.8039999999901,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.704,
"layouts": 76,
"layoutDurationMs": 12.398,
"taskDurationMs": 263.036,
"heapDeltaBytes": -21307852,
"heapUsedBytes": 69635168,
"domNodes": 4,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 123.78900000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736813,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 372.4280000000135,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.665,
"layouts": 76,
"layoutDurationMs": 14.206999999999999,
"taskDurationMs": 328.634,
"heapDeltaBytes": -21113184,
"heapUsedBytes": 71008204,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 154.171,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 368.16800000008243,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8259999999999998,
"layouts": 76,
"layoutDurationMs": 11.625,
"taskDurationMs": 340.803,
"heapDeltaBytes": -780796,
"heapUsedBytes": 116123048,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 123.456,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 337.42900000004283,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.3019999999999996,
"layouts": 76,
"layoutDurationMs": 11.381,
"taskDurationMs": 307.093,
"heapDeltaBytes": -1353784,
"heapUsedBytes": 115570152,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.514,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2971 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d9ff01c4b52b7757ff42d0d5b0397d0cc8b89c10
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (118)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #22043 +/- ##
==========================================
Coverage 84.58% 84.58%
==========================================
Files 2935 2935
Lines 161190 161190
Branches 41464 41464
==========================================
Hits 136346 136346
Misses 24453 24453
Partials 391 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Faithful backport of #21677 to core/1.58 with the browser helper adapted to the target branch.
I compared this head with merged source 740e609, which is on current main. The locale, formatter, and formatter regression test have identical changed lines. Both browser refusal cases retain the source's exact toast assertions and next-message canvas checks.
The adaptation keeps the refusal helper inside the spec, where core/1.58 already defines it, rather than changing the shared mocks. It accepts the same refusal code and raw message as the source. The spec also preserves the target's existing turn-settling helpers instead of importing main's newer panel methods. No source behavior or test case is dropped.
With the target's locked dependencies, I ran 180 unit tests across the formatter, document-lifecycle, and follower suites; browser typechecking, targeted type-aware lint, and whitespace checks passed. The browser spec passed all four cases with retries disabled. The first run passed both refusal cases but timed out setting up the app for an unchanged case while Vite optimized dependencies; the full warm run passed.
CI has no failures at the time of review, but unrelated Chromium shards are still running. This approval verifies the backport; it does not claim that CI has finished.
Backport of #21677 to
core/1.58.Full context for agent readers
Auto-backport failed on conflicts in test files only (
browser_tests/tests/agent/agentPanelMocks.ts,browser_tests/tests/agent/boundCanvasReadPath.spec.ts).src/locales/en/main.json,workflowSyncErrorDetail.tsand its unit test applied cleanly.Tests: Unit test for the toast text, plus the existing refused-follower e2e case now also runs for
catalog_mismatch(the e2e helper lives in the spec on this branch, so it was adapted there;agentPanelMocks.tsis unchanged).vitest run workflowSyncErrorDetail.test.ts: 7 passed locally;pnpm typecheck:browserpassed on the 1.58 branch.Why backport: local agent users on ComfyUI stable run older frontend trains. The local agent fix this copy describes (Comfy-Org/cloud#14302) ships in the local agent package, so without this they see the old dead-end message.