Repository navigation
[backport cloud/1.58] fix(assets): clear widget references to deleted media by stored identity - #22042
Conversation
…ity (#21970) When you delete an image from the Assets panel, any Load Image node still pointing at it should go blank, drop its preview, and show a missing-file warning. On Cloud, that cleanup was looking up the file by its friendly name while the node had stored the file's storage ID, like searching a phone book by nickname when the entry is filed under the full legal name. Now cleanup searches by the same ID that was written in, so deleted images actually disappear from the workflow. On Cloud, adding a Generated temp or output asset writes the stored hash filename with its directory annotation (for example `previews/<hash>.png [temp]`). After a successful delete, the cleanup identities did not include that value, so the widget value and the node preview stayed and no missing-media warning appeared. - Deletion identities now annotate both the readable name and the stored hash with the asset's directory type and full subfolder. The temp branch no longer drops the subfolder. The unannotated hash is no longer added for temp and output assets, because it names an input file and could clear an input reference to the same bytes. - Grouped Generated children (`unflattenOutputAssets`) keep each flat asset's `hash` and report `temp` when the preview URL says `type=temp`, not only when the tags do. The job-cover choice uses the same temp check, so a URL-typed temp preview no longer wins over a saved output. Items rebuilt for an opened stack carry their grouped output's root and stored hash on a module-private symbol, set only when the item is built and read only by deletion. The root decides the annotation for the item's name and stored hash, so deleting an output or temp file from the stack clears the hash and name references added from the collapsed card, including drag-and-drop. Server JSON cannot supply that symbol, so `user_metadata` cannot steer it. `asset.hash` stays unset on those items, so add-to-workflow and preview filenames are unchanged. - Missing-media marking, preview clearing and widget clearing all compare `(root folder, path)` through `parseAnnotatedPath`. So `x.png`, `x.png [input]`, `x.png[temp]`, `x.png [TEMP]` and a padded `x.png [temp] ` match their deleted counterparts, while the same basename in another root or subfolder stays untouched. The candidate keeps its original widget text. A deleted value that is only an annotation is ignored, so it cannot match empty widgets. - Preflight still skips unverified temp values. Only a confirmed deletion marks temp references missing. The deleted-value sets passed to the cleanup helpers no longer list the explicit `[input]` alias, because the comparison treats it as equal to the bare name. Three existing expectations were updated to match. Unit tests use a real `LGraph`/`LGraphNode`, the real add-to-workflow path to write widget values, real `unflattenOutputAssets` grouping, the real missing-media scanner and store, and `node.serialize()`. The asset DELETE call and node output store actions are mocked. No local browser or E2E reproduction of the incident was run. Remote CI has run the existing browser and cloud E2E suites on this branch. The original incident's backend data and deletion were not reproduced. New cases cover: - Flat and grouped hash-backed temp, output and preview-URL-temp references being cleared, while input references to the same hashes are kept. - Same-hash references in another root or subfolder, plus the legacy name-only temp form, being kept. - Compact, uppercase and padded temp annotations. - Input name, hash, and `[input]` forms being cleared, with other roots and `clipspace/` kept. - A failed deletion keeping its reference. - A job cover choosing a saved output over a preview typed temp only by its URL (`assetMappers.test.ts`). - Adding the collapsed group card, then deleting the same output or temp file from the expanded stack, using the real `resolveOutputAssetItems` with job assets mocked. - A plain server record whose `user_metadata` names a `storedHash`/`storedType` not clearing an unrelated reference. - The expanded child reaching deletion through a Vue ref and a spread copy, as the stack list and grid pass it. - Subfolder-qualified readable-name temp and output references (the drag-and-drop form) being cleared alongside the hash forms. The deleted-value matcher indexes deleted paths by filepath and derives each widget value's single candidate path from its trailing annotation, parsing only a remainder no longer than an annotation. Measured outside vitest, 1000 deleted assets against 2000 string widgets over four passes takes about 9 ms. Long whitespace in a prompt or file name therefore never reaches the annotation regex; a value with 300k trailing spaces previously took about a minute. An 18-row table of compact, case, padded, subfolder, trailing-space and nested-annotation values gives the same answers as plain `parseAnnotatedPath` comparison. Mutation checks showed that each of these changes, when reverted, fails at least one new case: taking the child type from tags only, dropping the child hash, and comparing the exact candidate name. <details> <summary>Red / green commands and results</summary> Base `6d00a3cd27`, Node 26.8.2. RED: product files at base, with the regression file as it was at the time (historical result; the tests were refined in later review rounds): ``` pnpm exec vitest run src/platform/assets/composables/useMediaAssetActions.test.ts -t "references added from the deleted asset" --maxWorkers=1 --retry=0 ``` Exit 1, 6 failed, 1 passed (failed-deletion control). Failures are assertion failures on retained values, for example `expected 'previews/aa7ecf08.png [temp]' to be ''`, `expected 'aa7ecf08.png[temp]' to be ''`, `expected 'dd90ab12.png [input]' to be ''`. GREEN at that time: same command with the original fix gave exit 0, 7 passed. The final head's results are in the related-suite run below. Job-cover regression, before the cover-sort change: `pnpm exec vitest run src/platform/assets/composables/media/assetMappers.test.ts -t "saved output over a preview typed temp" --maxWorkers=1 --retry=0` gave exit 1, `expected 'preview-id' to be 'saved-id'`; it passes with the change. Related suites: ``` pnpm exec vitest run src/platform/assets/composables/useMediaAssetActions.test.ts src/platform/assets/utils/clearDeletedAssetWidgetValues.test.ts src/platform/assets/utils/clearNodePreviewCacheForValues.test.ts src/platform/assets/utils/markDeletedAssetsAsMissingMedia.test.ts src/platform/assets/composables/media/assetMappers.test.ts src/platform/workflowErrors/missingMedia src/stores/assetsStore.test.ts src/platform/assets/utils/outputAssetUtil.test.ts src/platform/assets/composables/useOutputStacks.test.ts src/utils/createAnnotatedPath.test.ts src/platform/assets/utils/assetDragUtil.test.ts --maxWorkers=1 --retry=0 ``` Exit 0, 16 files, 352 passed. `pnpm typecheck` passed. Pre-commit (lint-staged, typecheck) and pre-push (deps audit, knip, fallow audit) hooks passed. </details> Limits: this fixes cleanup for deletions made in the open workflow. Detecting temp files deleted elsewhere, or after reopening a workflow, still needs a temp inventory and is out of scope. This is a bug fix to existing deletion cleanup, so it has no feature flag. Known gaps outside this fix, found in review: - Other places that write widget values still disagree with each other. For an asset tagged `["output","temp"]`, add-to-workflow writes the `[output]` root. The Vue media dropdown always writes `[output]` without a subfolder. A grouped card injects `jobId`, so it can get a subfolder that its flat card does not. - Whether deleting one cloud record frees bytes that another record with the same hash still uses is a backend fact this PR does not infer. Authored by: agent-work loop. Diagnosed by reproducing the deletion path in unit-level probes against the current code, then written red-first: the regression tests were run against unchanged product code and failed on the retained values before the fix was applied. (cherry picked from commit a991dbe)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-27T03:07:51.989Z",
"gitSha": "f369eb8fdd3170cd004f8dfc52037b90c3153eba",
"branch": "backport-21970-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.1270000000025,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8080000000000007,
"layouts": 9,
"layoutDurationMs": 2.753,
"taskDurationMs": 432.376,
"heapDeltaBytes": 1601552,
"heapUsedBytes": 91886508,
"domNodes": -200,
"jsHeapTotalBytes": 1892352,
"scriptDurationMs": 9.016,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.2769999999837,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8300000000000005,
"layouts": 9,
"layoutDurationMs": 2.8299999999999996,
"taskDurationMs": 420.489,
"heapDeltaBytes": 2921232,
"heapUsedBytes": 93199152,
"domNodes": -200,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 9.674999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1777.0460000000128,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.012,
"layouts": 9,
"layoutDurationMs": 2.7169999999999996,
"taskDurationMs": 860.256,
"heapDeltaBytes": 5047504,
"heapUsedBytes": 94868564,
"domNodes": -180,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 175.266,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1811.3730000000032,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.828999999999999,
"layouts": 9,
"layoutDurationMs": 2.575,
"taskDurationMs": 806.4590000000001,
"heapDeltaBytes": 1691756,
"heapUsedBytes": 92484536,
"domNodes": -200,
"jsHeapTotalBytes": 3727360,
"scriptDurationMs": 166.246,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.820370370370373,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.726000000027,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.017,
"layouts": 11,
"layoutDurationMs": 3.282,
"taskDurationMs": 360.46299999999997,
"heapDeltaBytes": 25449556,
"heapUsedBytes": 115626132,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 15.451000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.6040000000457,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.2829999999999995,
"layouts": 10,
"layoutDurationMs": 3.1879999999999997,
"taskDurationMs": 338.893,
"heapDeltaBytes": 55960,
"heapUsedBytes": 91229208,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 12.016000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 636.509000000018,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1319999999999992,
"layouts": 9,
"layoutDurationMs": 2.661,
"taskDurationMs": 459.098,
"heapDeltaBytes": 4182628,
"heapUsedBytes": 93936824,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 178.10799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 615.7850000000167,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8679999999999994,
"layouts": 9,
"layoutDurationMs": 2.305,
"taskDurationMs": 433.187,
"heapDeltaBytes": 4219392,
"heapUsedBytes": 94072188,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 169.78700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1249.9920000000202,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 883.6409999999998,
"heapDeltaBytes": 13947620,
"heapUsedBytes": 133016932,
"domNodes": -230,
"jsHeapTotalBytes": 13066240,
"scriptDurationMs": 75.09700000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 592,
"frameDurationMs": 35.711428571428584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1201.297000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 845.8449999999999,
"heapDeltaBytes": -15664540,
"heapUsedBytes": 102158616,
"domNodes": -230,
"jsHeapTotalBytes": 15532032,
"scriptDurationMs": 67.44600000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 518,
"frameDurationMs": 32.42972972972974,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.9729999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.64699999999993,
"heapDeltaBytes": -3192460,
"heapUsedBytes": 98183600,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.12300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.75999999999996,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.9660000000231,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.4079999999994,
"heapDeltaBytes": -3998880,
"heapUsedBytes": 98254068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.94799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10278.510000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9397.827,
"heapDeltaBytes": 47994040,
"heapUsedBytes": 135582640,
"domNodes": -296,
"jsHeapTotalBytes": 36175872,
"scriptDurationMs": 7755.677000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1294,
"frameDurationMs": 32.33647798742138,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9250.552999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8482.045,
"heapDeltaBytes": 35527076,
"heapUsedBytes": 139941760,
"domNodes": -296,
"jsHeapTotalBytes": 25223168,
"scriptDurationMs": 6994.999,
"eventListeners": -130,
"totalBlockingTimeMs": 623,
"frameDurationMs": 32.625441696113064,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9941.036999999995,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.07099999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9123.673,
"heapDeltaBytes": 37098052,
"heapUsedBytes": 140159620,
"domNodes": -276,
"jsHeapTotalBytes": 26796032,
"scriptDurationMs": 7519.9169999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 825,
"frameDurationMs": 31.938906752411576,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10828.082999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10041.345,
"heapDeltaBytes": 33492620,
"heapUsedBytes": 147546524,
"domNodes": -276,
"jsHeapTotalBytes": 34922496,
"scriptDurationMs": 8055.032000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 972,
"frameDurationMs": 31.351304347826083,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 233.51499999998282,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.389,
"layouts": 11,
"layoutDurationMs": 3.6769999999999996,
"taskDurationMs": 184.855,
"heapDeltaBytes": -4370032,
"heapUsedBytes": 101743592,
"domNodes": 917,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8.726,
"eventListeners": 196,
"totalBlockingTimeMs": 7,
"frameDurationMs": 25,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "large-combo-open",
"durationMs": 250.6360000000427,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.66,
"layouts": 12,
"layoutDurationMs": 3.501,
"taskDurationMs": 190.64999999999998,
"heapDeltaBytes": 15540356,
"heapUsedBytes": 121039064,
"domNodes": 917,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 8.156,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 22.727272727272727,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2041.7610000000082,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.241,
"layouts": 8,
"layoutDurationMs": 2.146,
"taskDurationMs": 492.48100000000005,
"heapDeltaBytes": -27114152,
"heapUsedBytes": 93833856,
"domNodes": -296,
"jsHeapTotalBytes": -1908736,
"scriptDurationMs": 31.316999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.9259999999895,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2529999999999997,
"layouts": 8,
"layoutDurationMs": 2.2159999999999997,
"taskDurationMs": 490.4759999999999,
"heapDeltaBytes": 245084,
"heapUsedBytes": 110831032,
"domNodes": -296,
"jsHeapTotalBytes": -1253376,
"scriptDurationMs": 36.32799999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2744.669999999985,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.379000000000001,
"layouts": 6,
"layoutDurationMs": 1.417,
"taskDurationMs": 1790.7129999999997,
"heapDeltaBytes": -13948420,
"heapUsedBytes": 108175408,
"domNodes": -296,
"jsHeapTotalBytes": 413696,
"scriptDurationMs": 856.472,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.871604938271602,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2526.658999999995,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.383,
"layouts": 8,
"layoutDurationMs": 1.7300000000000002,
"taskDurationMs": 1707.247,
"heapDeltaBytes": -2368172,
"heapUsedBytes": 108823488,
"domNodes": -296,
"jsHeapTotalBytes": -241664,
"scriptDurationMs": 808.618,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666225165562917,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3588.7469999999553,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.209000000000001,
"layouts": 64,
"layoutDurationMs": 11.284,
"taskDurationMs": 1663.6710000000003,
"heapDeltaBytes": -21233440,
"heapUsedBytes": 91098844,
"domNodes": -272,
"jsHeapTotalBytes": -598016,
"scriptDurationMs": 795.789,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3687.6700000000255,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.117,
"layouts": 64,
"layoutDurationMs": 10.366999999999999,
"taskDurationMs": 1798.7649999999999,
"heapDeltaBytes": -17897312,
"heapUsedBytes": 95678424,
"domNodes": -272,
"jsHeapTotalBytes": 188416,
"scriptDurationMs": 769.771,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.741818181818182,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3252.242000000024,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.9399999999999995,
"layouts": 4,
"layoutDurationMs": 1.1609999999999998,
"taskDurationMs": 2119.29,
"heapDeltaBytes": -9555592,
"heapUsedBytes": 105444588,
"domNodes": -296,
"jsHeapTotalBytes": 4014080,
"scriptDurationMs": 1054.052,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.9265625,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3195.373000000018,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.934000000000001,
"layouts": 4,
"layoutDurationMs": 1.2349999999999999,
"taskDurationMs": 2093.5389999999998,
"heapDeltaBytes": -28081884,
"heapUsedBytes": 98350652,
"domNodes": 0,
"jsHeapTotalBytes": 19156992,
"scriptDurationMs": 1044.249,
"eventListeners": 182,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.200534759358288,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2054.6170000000075,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.417,
"layouts": 7,
"layoutDurationMs": 2.312,
"taskDurationMs": 715.558,
"heapDeltaBytes": -19698868,
"heapUsedBytes": 103264948,
"domNodes": -296,
"jsHeapTotalBytes": -3219456,
"scriptDurationMs": 33.291999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2046.3120000000572,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9500000000000004,
"layouts": 7,
"layoutDurationMs": 1.7360000000000002,
"taskDurationMs": 657.7349999999999,
"heapDeltaBytes": -7041508,
"heapUsedBytes": 97881396,
"domNodes": -296,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 33.357,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 633.418000000006,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.708,
"layouts": 9,
"layoutDurationMs": 2.771,
"taskDurationMs": 446.52400000000006,
"heapDeltaBytes": -1003752,
"heapUsedBytes": 89797932,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 153.365,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.7040000000316,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.829,
"layouts": 9,
"layoutDurationMs": 2.263,
"taskDurationMs": 434.98799999999994,
"heapDeltaBytes": 22550232,
"heapUsedBytes": 113435696,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 146.804,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2041.6189999999972,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2390000000000008,
"layouts": 8,
"layoutDurationMs": 3.079,
"taskDurationMs": 538.4649999999999,
"heapDeltaBytes": 4805256,
"heapUsedBytes": 95685068,
"domNodes": -218,
"jsHeapTotalBytes": 843776,
"scriptDurationMs": 13.046999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.1150000000184,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0680000000000005,
"layouts": 11,
"layoutDurationMs": 2.7689999999999997,
"taskDurationMs": 538.814,
"heapDeltaBytes": 4448032,
"heapUsedBytes": 106275552,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 7.505,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.4420000000105,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.055000000000003,
"layouts": 9,
"layoutDurationMs": 2.7509999999999994,
"taskDurationMs": 782.2529999999999,
"heapDeltaBytes": -2433732,
"heapUsedBytes": 88479840,
"domNodes": -210,
"jsHeapTotalBytes": 1630208,
"scriptDurationMs": 119.66200000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1856.497999999931,
"styleRecalcs": 57,
"styleRecalcDurationMs": 12.158999999999999,
"layouts": 8,
"layoutDurationMs": 2.102,
"taskDurationMs": 813.851,
"heapDeltaBytes": 5905728,
"heapUsedBytes": 96781820,
"domNodes": -198,
"jsHeapTotalBytes": 2678784,
"scriptDurationMs": 108.36500000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576576576577,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 983.2219999999552,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.561,
"layouts": 5,
"layoutDurationMs": 16.939000000000004,
"taskDurationMs": 795.9490000000003,
"heapDeltaBytes": 11532684,
"heapUsedBytes": 132570340,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 26.671,
"eventListeners": 3244,
"totalBlockingTimeMs": 173,
"frameDurationMs": 21.373913043478257,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8477.843000000008,
"styleRecalcs": 248,
"styleRecalcDurationMs": 30.278,
"layouts": 6,
"layoutDurationMs": 1.9020000000000001,
"taskDurationMs": 5708.956,
"heapDeltaBytes": 4967996,
"heapUsedBytes": 116000224,
"domNodes": -297,
"jsHeapTotalBytes": -274432,
"scriptDurationMs": 2936.0709999999995,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.798217821782178,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8820.185000000038,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.007000000000005,
"layouts": 7,
"layoutDurationMs": 1.8210000000000002,
"taskDurationMs": 5938.344,
"heapDeltaBytes": -32547368,
"heapUsedBytes": 89529320,
"domNodes": -296,
"jsHeapTotalBytes": 188416,
"scriptDurationMs": 2678.926,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697722960151804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15724.81399999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14859.013,
"heapDeltaBytes": -50889540,
"heapUsedBytes": 278531796,
"domNodes": -3344,
"jsHeapTotalBytes": 29609984,
"scriptDurationMs": 237.10299999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.63728813559322,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 16340.153999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15356.212,
"heapDeltaBytes": -14716596,
"heapUsedBytes": 290277772,
"domNodes": -307,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 244.13599999999997,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.139931153184165,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 19320.11299999999,
"styleRecalcs": 160,
"styleRecalcDurationMs": 14.988000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18949.807,
"heapDeltaBytes": -8597736,
"heapUsedBytes": 302213852,
"domNodes": -3344,
"jsHeapTotalBytes": 8568832,
"scriptDurationMs": 842.2270000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 10,
"frameDurationMs": 35.247992700729924,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19573.462999999945,
"styleRecalcs": 153,
"styleRecalcDurationMs": 15.00299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19136.428000000004,
"heapDeltaBytes": -9148996,
"heapUsedBytes": 296046928,
"domNodes": -3344,
"jsHeapTotalBytes": 22269952,
"scriptDurationMs": 875.7600000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 15,
"frameDurationMs": 36.09963099630997,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8141.421000000037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.06099999999999,
"layouts": 20,
"layoutDurationMs": 27.889999999999997,
"taskDurationMs": 8000.045,
"heapDeltaBytes": -30610648,
"heapUsedBytes": 286592532,
"domNodes": -3344,
"jsHeapTotalBytes": 1822720,
"scriptDurationMs": 112.39799999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.12485207100593,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7966.143999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.559000000000005,
"layouts": 20,
"layoutDurationMs": 21.54099999999999,
"taskDurationMs": 7848.981999999999,
"heapDeltaBytes": -46929280,
"heapUsedBytes": 273474480,
"domNodes": -3344,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 117.231,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.4190476190476,
"p95FrameDurationMs": 99.99999999999818
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7338.406000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7051.490999999998,
"heapDeltaBytes": -4188664,
"heapUsedBytes": 266566056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 102.06000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.77364864864865,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7826.414999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7429.575,
"heapDeltaBytes": -8746188,
"heapUsedBytes": 275823208,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.18700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.586394557823123,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 116.81299999997918,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.806000000000001,
"layouts": 7,
"layoutDurationMs": 3.245,
"taskDurationMs": 88.652,
"heapDeltaBytes": 4830504,
"heapUsedBytes": 95376152,
"domNodes": 123,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.530000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 484.3420000000833,
"styleRecalcs": 19,
"styleRecalcDurationMs": 11.084,
"layouts": 10,
"layoutDurationMs": 3.9629999999999996,
"taskDurationMs": 125.54300000000002,
"heapDeltaBytes": 7042096,
"heapUsedBytes": 97462888,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.391,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 420.5979999999272,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.626,
"layouts": 76,
"layoutDurationMs": 13.67,
"taskDurationMs": 376.196,
"heapDeltaBytes": -14732824,
"heapUsedBytes": 79452988,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 179.843,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 446.4659999999867,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.703,
"layouts": 76,
"layoutDurationMs": 14.237,
"taskDurationMs": 391.10699999999997,
"heapDeltaBytes": -14957144,
"heapUsedBytes": 79747092,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 188.963,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 504.903000000013,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.616,
"layouts": 76,
"layoutDurationMs": 13.573,
"taskDurationMs": 470.97900000000004,
"heapDeltaBytes": 974052,
"heapUsedBytes": 122194356,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 190.296,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 544.4320000000289,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.02,
"layouts": 76,
"layoutDurationMs": 13.533999999999999,
"taskDurationMs": 508.61,
"heapDeltaBytes": -831768,
"heapUsedBytes": 124566124,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 200.469,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2976 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsFallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (14 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c4d2189ee305d5404e24e8bfd3ec18a423cc53ec
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (124)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22042 +/- ##
=============================================
Coverage ? 85.89%
=============================================
Files ? 2591
Lines ? 135100
Branches ? 38808
=============================================
Hits ? 116049
Misses ? 18634
Partials ? 417
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21970 to
cloud/1.58Manual backport: the automatic cherry-pick of a991dbe conflicted. Conflicts were only import paths:
cloud/1.58uses relative../utilsimports and@/platform/missingMedia/*instead of@/platform/workflowErrors/missingMedia/*. The test file'soutputAssetUtilmock takes{ spy: true }as on main. No behavior differs from #21970.Verified on this branch: related asset, missing-media, assets store and annotated-path suites (66 files, 1120 tests) and
pnpm typecheckpass.