Repository navigation
feat(registry-census): measure the widget-form population, per pack and node - #22022
christian-byrne wants to merge 4 commits into
Conversation
The predicate landed in `src/lib/litegraph/src/node/`, which `fallow`'s
generated boundary map assigns to `graph-model/domain` via the catch-all
`src/lib/litegraph/src/node/**`. It imports `types/widgets.ts`, which is
`node-widgets/domain`, so both the module and its test are cross-zone
boundary violations and the repo's own pre-push gate refuses the push:
✗ dead code: 2 issues · complexity: 2 findings
`src/lib/litegraph/src/widgets/**` is `node-widgets/presentation`, so the same
import becomes presentation -> domain inside one domain, which is the allowed
direction. Nothing else changes: this is a rename plus the four references to
the old path (its own test, the census runner, the census README, and
ADR-ECS-WIDGETS-0023).
This is where the file was meant to be. The PR that added it states the
layer-boundary violation was fixed by moving it out of `node/`, but the commit
has it in `node/` and the violation live. Restoring the stated intent rather
than suppressing the gate.
Gate after the move: `✓ No issues in 11 changed files`. Typecheck, oxlint
--type-aware and knip clean; widgetFormProof's 16 tests and the census
runner's 6 all pass.
`deps:audit` is `depcruise src`, and `build_matrix.py` writes the ecosystem
matrix into `src/__ecs_matrix__/` — 2,512 generated specs plus every executing
pack's real JS, 1.1GB. dependency-cruiser crawls all of it and dies:
FATAL ERROR: Ineffective mark-compacts near heap limit
JavaScript heap out of memory
husky - pre-push script failed (code 134)
So following the census README's own local instructions makes the repo
unpushable until you remember to delete a gitignored directory, and --max-old-
space-size=8192 does not save it.
This is an oversight rather than a choice: `tsconfig.json`, `.oxfmtrc.json`,
`.oxlintrc.json` and `knip.config.ts` all already exclude that path.
dependency-cruiser was the one tool missed.
Excluded in both places it matters -- `doNotFollow` so the tree is never
walked, `exclude` so nothing under it is reported. Verified by running
`deps:audit` with the full 1.1GB tree present: `2815 modules, 17138
dependencies cruised`, byte-identical to the count with the tree deleted. The
exclusion changes what is traversed and nothing about what is audited.
…nd node Points the ecosystem matrix at `proveWidgetForm`. One new row field, `formAgreement`, records per node whether a `widgets_values_form` could be emitted and, when not, which of the predicate's seven refusals applies. It is telemetry, never gated: a refusal is the predicate working, so a floor would fail the run for an ecosystem behaving exactly as documented. The matrix is the only instrument that can produce this number. Deriving an order breaks on precisely the mutations its battery already performs -- wSplice, wReorder, wConvert, wPushPojo, wPushForeignClass -- and the predicate checks array IDENTITY rather than deep equality for that reason. 2,512 packs ship JS and execute here. Two maps, because they answer different questions. `graph` is the standard workflow after the battery mauled it, so it measures whether PACK CODE breaks the proof on nodes the frontend owns. `driven` is each pack's own registered node types, which is the number that would decide coverage -- and the honest scope limit is that only frontend-registered types appear there at all, since the harness registers six hardcoded core defs and has no object_info. Most pack node classes are Python-side and unmeasurable here; an empty `driven` map is unmeasured, not covered. `needsForm` carries needsFormButHasNone: the object-shaped values a form would rescue, which nothing could previously count. The seam is the interesting part. proveWidgetForm needs the array serialiseWidgetValues produced BEFORE the extension serialize hook, and core hands that array to exactly one thing outside LGraphNode -- the node's own onSerialize, which runExtensionSerializeHook calls with the payload itself. So the runner chains one on. It cannot manufacture a pass, because the post-hook identity is read from the returned payload, so a pack hook running after ours, a serialize override writing after super, or SubgraphNode rebuilding from inputs all still refuse. It cannot manufacture a refusal either: installing a hook does force the hook path for a node that would otherwise return early, but that path leaves a JSON-cloneable widgets_values alone -- the writeback skips cloneable values and the one Object.assign that could overwrite the field draws from readExtensionFields, which excludes every canonical field by construction. Both directions are asserted in the test. The measurement runs last, after every gated operation, so the seam cannot reach a gated channel, and it is wrapped: an escaping throw would leave the write-ahead stub in place and stub rate IS gated, so a telemetry channel must not be able to cost a row. `formAgreement` joins EXPECTED_ROW_KEYS, so the field silently ceasing to be written withholds the verdict instead of reading as a clean population. The same doctrine as the detection proof: a measurement channel that stops firing makes every green run since worth less than it looked. Tests: 3 harness cases (clean node provable, no-value node refused, rebuilt array and object-shaped payload refused with the pack hook still called) and 6 verdict cases (refusal histogram, no-values is not a refusal, own types counted apart, missing field withheld, failed measurement named not averaged, malformed field survived). Typecheck, oxlint, depcruise, architecture check and the census unittest suite clean.
`proveWidgetForm` was over the cognitive-complexity threshold (16, limit 15), so the repo's own pre-push health gate refused the push. Split as the PR that added it says it was split: `provenValues` answers "did we write this array", `addressableOrder` answers "can these names address it", and `ourPositionalValues` isolates the identity check that is the whole proof. The seam is not arbitrary. The two halves are different kinds of claim and collapsing them reads as one: a value we did not write is UNKNOWABLE, while a value we wrote but cannot address by name is merely UNDESCRIBABLE. Keeping them apart is why `values_replaced` and `duplicate_widget_name` are not neighbours in the code even though they are neighbours in the refusal enum. Behaviour identical, and the check order is preserved where it is observable. `ourPositionalValues` tests `Array.isArray` before identity, the reverse of the original, which is equivalent in all four cases: a non-array returns `values_not_positional` either way (the original reached it through the `Array.isArray(values) ? ... : ...` ternary, or through the follow-up guard when a non-array happened to BE the produced value), and an array returns `values_replaced` or passes identically. All 16 of the predicate's tests pass unchanged — none were touched, which is what makes them a behaviour guard here rather than a description of the new shape. Gate after the split: `✓ No issues in 9 changed files`.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-26T22:32:12.726Z",
"gitSha": "80207cfbcb70173a6bdffe61eeff957b461dff99",
"branch": "widget-form-population-census",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.1879999999946,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.934,
"layouts": 9,
"layoutDurationMs": 2.885,
"taskDurationMs": 557.338,
"heapDeltaBytes": 1543352,
"heapUsedBytes": 62490292,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 9.970000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.5490000000073,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.995,
"layouts": 8,
"layoutDurationMs": 3.538,
"taskDurationMs": 643.594,
"heapDeltaBytes": 4490132,
"heapUsedBytes": 75219212,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 13.648999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.737000000041,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.232999999999999,
"layouts": 10,
"layoutDurationMs": 2.998,
"taskDurationMs": 916.5590000000001,
"heapDeltaBytes": 22899172,
"heapUsedBytes": 83968500,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 166.05700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.8419999999896,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.034999999999998,
"layouts": 9,
"layoutDurationMs": 2.805,
"taskDurationMs": 978.813,
"heapDeltaBytes": 21495520,
"heapUsedBytes": 82661408,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 172.661,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.4439999999763,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.437999999999999,
"layouts": 11,
"layoutDurationMs": 3.303,
"taskDurationMs": 428.3910000000001,
"heapDeltaBytes": -1155660,
"heapUsedBytes": 59682836,
"domNodes": 56,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 11.769999999999996,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.6280000000152,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.038,
"layouts": 11,
"layoutDurationMs": 3.7210000000000005,
"taskDurationMs": 477.1190000000001,
"heapDeltaBytes": -809796,
"heapUsedBytes": 60133420,
"domNodes": 56,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 14.970999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 716.254000000049,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2769999999999997,
"layouts": 9,
"layoutDurationMs": 2.5370000000000004,
"taskDurationMs": 494.77599999999995,
"heapDeltaBytes": 7500980,
"heapUsedBytes": 77436692,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 166.601,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 775.1309999999876,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.7410000000000005,
"layouts": 8,
"layoutDurationMs": 2.678,
"taskDurationMs": 542.208,
"heapDeltaBytes": 3411288,
"heapUsedBytes": 64543140,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 177.04600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667391304347824,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.4249999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 928.908,
"heapDeltaBytes": -1885244,
"heapUsedBytes": 74755628,
"domNodes": -191,
"jsHeapTotalBytes": 13377536,
"scriptDurationMs": 70.23899999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 515,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1269.8219999999765,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1001.833,
"heapDeltaBytes": -12198452,
"heapUsedBytes": 75104288,
"domNodes": -191,
"jsHeapTotalBytes": 19668992,
"scriptDurationMs": 73.216,
"eventListeners": -106,
"totalBlockingTimeMs": 573,
"frameDurationMs": 34.235135135135145,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.8249999999812,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.12699999999967,
"heapDeltaBytes": 22414976,
"heapUsedBytes": 89267160,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.22799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 854.9080000000231,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.9869999999997,
"heapDeltaBytes": -4821864,
"heapUsedBytes": 69907644,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.73399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11547.665999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10771.053,
"heapDeltaBytes": 84226016,
"heapUsedBytes": 157626256,
"domNodes": -257,
"jsHeapTotalBytes": 78508032,
"scriptDurationMs": 8729.178,
"eventListeners": -68,
"totalBlockingTimeMs": 1384,
"frameDurationMs": 32.49159663865546,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10982.682000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10191.033999999998,
"heapDeltaBytes": 63912832,
"heapUsedBytes": 137682776,
"domNodes": -257,
"jsHeapTotalBytes": 72478720,
"scriptDurationMs": 8177.557,
"eventListeners": -68,
"totalBlockingTimeMs": 1297,
"frameDurationMs": 31.65100864553314,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10557.142999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9742.693000000001,
"heapDeltaBytes": -13228980,
"heapUsedBytes": 65581960,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7869.222,
"eventListeners": 0,
"totalBlockingTimeMs": 987,
"frameDurationMs": 31.447321428571428,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10706.735999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9913.792000000001,
"heapDeltaBytes": 72253632,
"heapUsedBytes": 145362384,
"domNodes": -257,
"jsHeapTotalBytes": 67497984,
"scriptDurationMs": 7974.433,
"eventListeners": -68,
"totalBlockingTimeMs": 1079,
"frameDurationMs": 31.061449275362314,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 287.87200000004987,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.723,
"layouts": 12,
"layoutDurationMs": 3.8360000000000003,
"taskDurationMs": 247.76100000000002,
"heapDeltaBytes": -15203252,
"heapUsedBytes": 67554364,
"domNodes": -2315,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 9.754999999999999,
"eventListeners": -573,
"totalBlockingTimeMs": 11,
"frameDurationMs": 24.24545454545457,
"p95FrameDurationMs": 99.99999999999955
},
{
"name": "large-combo-open",
"durationMs": 290.33300000003237,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.024000000000004,
"layouts": 12,
"layoutDurationMs": 3.8910000000000005,
"taskDurationMs": 266.476,
"heapDeltaBytes": -9518252,
"heapUsedBytes": 65886648,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.511,
"eventListeners": -573,
"totalBlockingTimeMs": 12,
"frameDurationMs": 23.069230769230778,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2054.7449999999685,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1069999999999993,
"layouts": 7,
"layoutDurationMs": 1.8609999999999998,
"taskDurationMs": 686.158,
"heapDeltaBytes": -8761840,
"heapUsedBytes": 65497748,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 33.707,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.5220000000436,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.594,
"layouts": 7,
"layoutDurationMs": 2.3949999999999996,
"taskDurationMs": 773.8859999999999,
"heapDeltaBytes": 3124368,
"heapUsedBytes": 79791804,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 41.5,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2545.48699999998,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.532000000000002,
"layouts": 7,
"layoutDurationMs": 2.052,
"taskDurationMs": 1731.583,
"heapDeltaBytes": -3344040,
"heapUsedBytes": 72250452,
"domNodes": -257,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 843.345,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.775000000000002,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2921.763999999939,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.008000000000001,
"layouts": 6,
"layoutDurationMs": 1.991,
"taskDurationMs": 1910.0230000000001,
"heapDeltaBytes": -16021508,
"heapUsedBytes": 60501764,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 916.9580000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666285714285717,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3839.71600000001,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.662,
"layouts": 64,
"layoutDurationMs": 10.649,
"taskDurationMs": 1863.422,
"heapDeltaBytes": -1271404,
"heapUsedBytes": 79087156,
"domNodes": -233,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 800.941,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665652173913045,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4000.103999999965,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.617999999999999,
"layouts": 65,
"layoutDurationMs": 11.624,
"taskDurationMs": 1996.014,
"heapDeltaBytes": -15844708,
"heapUsedBytes": 60939556,
"domNodes": -233,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 842.828,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66569037656904,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3319.0950000000043,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.8420000000000005,
"layouts": 5,
"layoutDurationMs": 1.5879999999999996,
"taskDurationMs": 2123.493,
"heapDeltaBytes": 7381892,
"heapUsedBytes": 86501548,
"domNodes": -257,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 1028.257,
"eventListeners": -59,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.750761421319794,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3285.2139999999963,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.467,
"layouts": 4,
"layoutDurationMs": 1.2599999999999998,
"taskDurationMs": 2241.958,
"heapDeltaBytes": 10026688,
"heapUsedBytes": 82448108,
"domNodes": -257,
"jsHeapTotalBytes": 3428352,
"scriptDurationMs": 1079.147,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.835714285714285,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3067.7330000000325,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7109999999999999,
"layouts": 6,
"layoutDurationMs": 1.4069999999999998,
"taskDurationMs": 812.2710000000001,
"heapDeltaBytes": -17941184,
"heapUsedBytes": 58685176,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 360.268,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3097.4950000000945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.172,
"layouts": 8,
"layoutDurationMs": 2.109,
"taskDurationMs": 841.75,
"heapDeltaBytes": 2202980,
"heapUsedBytes": 73034892,
"domNodes": -257,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 388.881,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.4020000000146,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.4100000000000006,
"layouts": 7,
"layoutDurationMs": 2.2449999999999997,
"taskDurationMs": 702.173,
"heapDeltaBytes": -8432988,
"heapUsedBytes": 72557956,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 36.726,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.0390000000216,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7119999999999993,
"layouts": 7,
"layoutDurationMs": 2.452,
"taskDurationMs": 765.2039999999998,
"heapDeltaBytes": -9086820,
"heapUsedBytes": 67434476,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 39.754,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2829.140999999993,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.075000000000003,
"layouts": 8,
"layoutDurationMs": 2.497,
"taskDurationMs": 651.586,
"heapDeltaBytes": -15354112,
"heapUsedBytes": 76001100,
"domNodes": -253,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 208.62699999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.764285714285712,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2860.584000000017,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.714,
"layouts": 6,
"layoutDurationMs": 2.0050000000000003,
"taskDurationMs": 641.171,
"heapDeltaBytes": -7348044,
"heapUsedBytes": 69912616,
"domNodes": -274,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 199.37300000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666081871345032,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3462.5750000000153,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.379,
"layouts": 5,
"layoutDurationMs": 1.4569999999999999,
"taskDurationMs": 1090.9529999999997,
"heapDeltaBytes": -24167652,
"heapUsedBytes": 69003500,
"domNodes": -257,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 450.032,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.746376811594207,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3334.6820000000434,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.06,
"layouts": 6,
"layoutDurationMs": 2.0439999999999996,
"taskDurationMs": 1033.958,
"heapDeltaBytes": -17214552,
"heapUsedBytes": 63385816,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 408.434,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 648.7989999999968,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.012,
"layouts": 8,
"layoutDurationMs": 2.4579999999999997,
"taskDurationMs": 457.86500000000007,
"heapDeltaBytes": -1866780,
"heapUsedBytes": 59801672,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 151.023,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 724.4610000000193,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.6899999999999995,
"layouts": 9,
"layoutDurationMs": 2.7899999999999996,
"taskDurationMs": 474.24100000000004,
"heapDeltaBytes": -18300,
"heapUsedBytes": 62086552,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 151.028,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.1679999999883,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.059000000000001,
"layouts": 9,
"layoutDurationMs": 2.841,
"taskDurationMs": 558.654,
"heapDeltaBytes": 1955224,
"heapUsedBytes": 63694744,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.265,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.32599999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.031999999999999,
"layouts": 9,
"layoutDurationMs": 3.265,
"taskDurationMs": 621.918,
"heapDeltaBytes": 6152960,
"heapUsedBytes": 78386892,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 12.325,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.1489999999972,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.952000000000002,
"layouts": 8,
"layoutDurationMs": 2.3350000000000004,
"taskDurationMs": 860.2750000000001,
"heapDeltaBytes": 17460284,
"heapUsedBytes": 79974164,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 119.315,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.8139999999003,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.037999999999998,
"layouts": 10,
"layoutDurationMs": 2.96,
"taskDurationMs": 925.9609999999999,
"heapDeltaBytes": 19312032,
"heapUsedBytes": 81384548,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 123.90499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1486.5260000000262,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.287999999999997,
"layouts": 5,
"layoutDurationMs": 14.696999999999997,
"taskDurationMs": 1184.026,
"heapDeltaBytes": 11570824,
"heapUsedBytes": 113170480,
"domNodes": 16030,
"jsHeapTotalBytes": 10096640,
"scriptDurationMs": 35.24900000000001,
"eventListeners": 3246,
"totalBlockingTimeMs": 170,
"frameDurationMs": 19.735526315789468,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9802.40299999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.168,
"layouts": 7,
"layoutDurationMs": 2.018,
"taskDurationMs": 6148.18,
"heapDeltaBytes": 6025436,
"heapUsedBytes": 80760228,
"domNodes": -257,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2757.549,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10198.233999999957,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.272000000000002,
"layouts": 7,
"layoutDurationMs": 2.199,
"taskDurationMs": 6414.692999999999,
"heapDeltaBytes": 5601128,
"heapUsedBytes": 80043176,
"domNodes": -257,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2854.7659999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23545.458999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23037.546,
"heapDeltaBytes": -28831660,
"heapUsedBytes": 253489704,
"domNodes": -3343,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 326.938,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.28508771929825,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23638.431999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23155.325999999997,
"heapDeltaBytes": -2873032,
"heapUsedBytes": 277969640,
"domNodes": -3343,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 339.34799999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.09965217391305,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28325.736000000004,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.866999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28011.524,
"heapDeltaBytes": -27093956,
"heapUsedBytes": 270091424,
"domNodes": -3343,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 933.9490000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 11,
"frameDurationMs": 53.76129032258065,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28501.123000000007,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.64000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28218.410000000003,
"heapDeltaBytes": -19761516,
"heapUsedBytes": 253164864,
"domNodes": -3373,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 883.614,
"eventListeners": -667,
"totalBlockingTimeMs": 24,
"frameDurationMs": 54.006628787878796,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8314.121999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.84500000000001,
"layouts": 20,
"layoutDurationMs": 29.013000000000012,
"taskDurationMs": 8179.611999999999,
"heapDeltaBytes": -17714488,
"heapUsedBytes": 254632676,
"domNodes": -3343,
"jsHeapTotalBytes": 20439040,
"scriptDurationMs": 124.11500000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.85414364640884,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8589.521999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.16,
"layouts": 20,
"layoutDurationMs": 23.624000000000006,
"taskDurationMs": 8477.4,
"heapDeltaBytes": -31315348,
"heapUsedBytes": 250809872,
"domNodes": -3343,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 126.78099999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.94972067039106,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11396.408999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11148.339,
"heapDeltaBytes": -1148880,
"heapUsedBytes": 255783852,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.72600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.523958333333326,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12424.448999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12004.861000000003,
"heapDeltaBytes": 9446172,
"heapUsedBytes": 284233736,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 174.60200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.93250883392226,
"p95FrameDurationMs": 100
},
{
"name": "workflow-execution",
"durationMs": 127.81099999995149,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.815,
"layouts": 8,
"layoutDurationMs": 3.9000000000000004,
"taskDurationMs": 104.033,
"heapDeltaBytes": 4952236,
"heapUsedBytes": 72642240,
"domNodes": 132,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.367999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 140.92199999993227,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.464,
"layouts": 10,
"layoutDurationMs": 4.8999999999999995,
"taskDurationMs": 105.82399999999998,
"heapDeltaBytes": 4648556,
"heapUsedBytes": 72385492,
"domNodes": 125,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.99,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 545.5100000000357,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.736,
"layouts": 76,
"layoutDurationMs": 17.353,
"taskDurationMs": 492.30400000000003,
"heapDeltaBytes": -3985056,
"heapUsedBytes": 42182764,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 235.66299999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000017,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 528.3059999999296,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7240000000000001,
"layouts": 76,
"layoutDurationMs": 16.244999999999997,
"taskDurationMs": 489.91100000000006,
"heapDeltaBytes": -3840992,
"heapUsedBytes": 38531580,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 235.094,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665624999999977,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 611.0449999999901,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.157,
"layouts": 76,
"layoutDurationMs": 16.165,
"taskDurationMs": 583.018,
"heapDeltaBytes": 2008864,
"heapUsedBytes": 95510848,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 236.60299999999998,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 643.3309999999892,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.711,
"layouts": 76,
"layoutDurationMs": 16.660999999999998,
"taskDurationMs": 615.641,
"heapDeltaBytes": 1384004,
"heapUsedBytes": 95011448,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 256.075,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3121 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsFallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (13 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 93da15218edee3f479f3f8718e8827ac3af2959e
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (208)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## widget-form-proof-predicate #22022 +/- ##
==============================================================
Coverage ? 87.58%
==============================================================
Files ? 2783
Lines ? 154680
Branches ? 39949
==============================================================
Hits ? 135477
Misses ? 18528
Partials ? 675
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Review at exact head
The exact head itself is otherwise mechanically green: 108 check runs are terminal (87 success, 21 skipped), status context |
|
Superseded by #22299 — please do not land both, they touch the same files. #22299 removes the scope limit this PR's body states honestly (six hardcoded core classes plus 103 frontend-only types) by feeding the matrix a real It also rebases onto #22007's current head, which matters: this branch diverged at Two findings this PR could not reach:
The repairs this PR made to the parent are already on |
…ases (Comfy-Org#22505) ## Summary Pins what the Agent wire's widget form proof does in the two cases Comfy-Org#22007 checks for, so Comfy-Org#22007 and Comfy-Org#22022 can close without losing them. ## Changes - **What**: test-only. Three cases in `docOpMinter.test.ts` and `widgetValuesForm.test.ts`: - A class that rewrites `widgets_values_named` after core wrote it is refused. The proof reads the final `node.serialize()` result, so it already sees the last writer. - A `SubgraphNode` host is a virtual node, so `wireNodeSnapshot` sends its positional values, which are the last writer's, and never reaches the proof. The test sets `serialize_widgets = true` as production hosts do. - An uncatalogued node whose hook replaced `widgets_values` keeps its form, and `add_node` applies. The same payload without the form is rejected with `uncatalogued_widget_write`. ## Review Focus The plan was to port `coreIsLastWriter` and the array-identity check from Comfy-Org#22007 into `widgetValuesForm.ts`. A test-first attempt found no failing case on the wire, and found a regression: - `SubgraphNode` rewrites positional `widgets_values` after core, and the wire already sends that positional payload for hosts. They do not reach the proof at all. - Refusing a form when positional values were replaced would turn `applied` into `uncatalogued_widget_write` for any pack node missing from the pinned catalog. `rejectUnprojectableWidgets` in comfy-multi-player refuses named values with no form for an uncatalogued class, and without a form that `add_node` never reaches the document. Mutation control: a suppression on replaced positional values fails 4 tests, the new `add_node` case plus 3 existing ones, including `ignores positional values because the Agent wire sends named values`. The browser spec `agentWidgetFormHookDrift.spec.ts` pins the same behaviour. The ADR record is in a separate docs PR so this one stays inside the Agent paths.
What
Points the Custom Nodes Ecosystem Matrix at
proveWidgetForm, so the widget-form gap has a population number instead of an argument.One new row field,
formAgreement, records per node whether awidgets_values_formcould be emitted and, when not, which of the predicate's seven refusals applies. It is telemetry, never gated — a refusal is the predicate working, so a floor would fail the run for an ecosystem behaving exactly as documented.Stacked on #22007 (base
widget-form-proof-predicate) so it reuses the predicate rather than duplicating the rule. The predicate's behaviour is unchanged; two commits here move it and restructure it so the repo's own gates pass (see Repairs to the parent below).Why this harness
It is the only instrument that can produce this number. Deriving an order breaks on precisely the mutations the matrix battery already performs —
wSplice,wReorder,wConvert,wPushPojo,wPushForeignClass— which is why the predicate checks array identity and not deep equality. The battery already ended inserialize→reload. Nobody had read the form off it.The measured result
2,512 pack specs executed at the checked-in pins; 2,511 rows. Both renderer arms, and three independent runs, give byte-identical numbers.
!createNode_nullaigodlike-comfyui-studiorebuildsCheckpointLoaderSimple'swidgets_values→values_replaced, which is exactly the shape deep equality would have waved through.comfyui-0246turns bothCLIPTextEncodenodes into replayed shells →replayed_serialization.VAEDecodeper pack: no widgets, nothing to order. Not a coverage gap, which is why the per-pack verdict excludes it.needsFormButHasNonefires zero times across the entire executed corpus. No pack serializer produced an object-shapedwidgets_valueson the paths this harness drives. The object-shaped population the ADR describes is real elsewhere — it is what the Agent wire's named projection carries — but it is not coming from pack serializers, and that is worth knowing before anyone sizes the work from it.!createNode_nullis not a form verdict. It fires on exactly the 13 type/pack pairs where the pre-existingdriveTypeschannel already recordscreateNode null— perfect agreement, which is the cross-check that the new channel is not inventing states.Read that against its scope, which is narrow, and is the honest headline
The matrix registers six hardcoded core node defs and has no
object_info. So the only node classes it can measure are those six (CheckpointLoaderSimple,CLIPTextEncode,EmptyLatentImage,KSampler,VAEDecode,SaveImage) plus the 103 frontend-only types that 54 of 2,511 packs register inregisterCustomNodes. Every Python-defined pack node class — where the widget-shape diversity actually lives — is invisible here, as isSubgraphNode, the known hard refusal. A pack with an emptydrivenmap is unmeasured, not covered.So the result is "pack code almost never breaks the proof on the paths this harness drives", not "the form would cover the registry".
What it does establish is the thing that was in doubt: the asymmetric rule costs essentially nothing in coverage on frontend-owned nodes. The worry that proof-not-derivation would refuse most of the ecosystem is not what the ecosystem does — 3 refusals in 17,563 node verdicts.
The seam, which is the part to review
proveWidgetFormneeds the arrayserialiseWidgetValuesproduced before the extension serialize hook — identity is the whole proof — and core hands that array to exactly one thing outsideLGraphNode: the node's ownonSerialize, whichrunExtensionSerializeHookcalls with the payload itself (const view = canonical). So the runner chains one on. It is faithful in both directions:serializeoverride writing aftersuper, orSubgraphNoderebuilding frominputsall still refuse.widgets_valuesalone:writeDetachedCanonicalValuereturns early for cloneable values, and the oneObject.assignthat could overwrite the field draws fromreadExtensionFields, which excludes every canonical field by construction.Both directions are asserted. A clean node reads
provable; a pack that copies the array readsvalues_replaced; and the pack's ownonSerializeis asserted to still have run, because a clobbered hook would turn every row downstream into a measurement of the harness.It is a seam, not the production call site. A producer landing inside
serializeFromStoreStateshould be measured again from there, and the README says so.Containment, because this is a telemetry channel inside a gated instrument
row.hookErrorsis read off before it runs, so re-instantiating a pack's node types cannot add to a gated channel. Measured rather than assumed:hookErrorsis byte-identical for all 2,511 packs before and after that reordering (31 packs with hook errors, same sets).measureFormAgreementis total. An escaping throw would leave the write-ahead stub in place, and stub rate is a gated criterion — a telemetry channel must not be able to cost a row. A hostile serializer gets!serialize_threwper node and the row stays complete; there is a test for exactly that.formAgreementjoinsEXPECTED_ROW_KEYS, so the field silently ceasing to be written withholds the verdict rather than reading as a clean population. Same doctrine as the detection proof: a measurement channel that stops firing makes every green run since worth less than it looked.Repairs to the parent, and to
deps:auditThree things had to be fixed to get a green push rather than suppressed:
knipwas failing onwidget-form-proof-predicate—WidgetFormRefusalwas exported and unused. This branch consumes it as the row's verdict type, which fixes the gate and means a refusal the predicate renames breaks the census rather than quietly widening the histogram with a string nothing reads.widgetFormProof.tswas insrc/lib/litegraph/src/node/, which fallow's boundary map assigns tograph-model/domain; it importstypes/widgets.ts, which isnode-widgets/domain. Both the module and its test were cross-zone violations. Moved towidgets/(node-widgets/presentation), making the import presentation → domain inside one domain. feat(litegraph): prove a node's widget form rather than deriving it #22007's body states this was already done; the commit has it innode/with the violation live.proveWidgetFormwas over the cognitive threshold (16, limit 15). Split intoprovenValues/addressableOrder/ourPositionalValues, again as feat(litegraph): prove a node's widget form rather than deriving it #22007's body states was done. Behaviour identical and all 16 of its tests pass untouched, which is what makes them a guard here rather than a description of the new shape.Separately:
deps:auditisdepcruise src, andbuild_matrix.pywrites 1.1 GB of third-party pack JS intosrc/__ecs_matrix__/. Following the census README's own local instructions therefore made the repo unpushable with an OOM, and--max-old-space-size=8192did not save it.tsconfig.json,.oxfmtrc.json,.oxlintrc.jsonandknip.config.tsalready exclude that path; dependency-cruiser was the one tool missed. Verified the exclusion changes traversal and not coverage:2815 modules, 17138 dependencies cruisedwith the full tree present, byte-identical to the count with it deleted.Verification
matrix_runner.test.ts6/6,widgetFormProof.test.ts16/16 unchanged, census unittest suite 58/58.DETECTION PROOF PASSED— every channel still fires and gates its own criterion, controls clean, 11/11 rows.poison-serialize-throwincidentally reads!serialize_threwon all 7 of its nodes, the new channel agreeing with a known-broken pack.pnpm typecheck,oxlint --type-aware,depcruise,knip,architecture:check, and the pre-commit and pre-push hooks all pass — the pre-push health gate ends✓ No issues in 9 changed files.Caveats to carry with any number quoted from this
firejail— tokenless, no$HOME, no network, private/tmp— because this is unreviewed third-party code on a shared host.--net=noneis a difference from CI, which has network.ComfyUI_RaykoStudio, fails at collection on a malformedpackage.jsonbefore its write-ahead stub exists, which is why the row count is 2,511 and not 2,512. Pre-existing and unrelated to this change.