Repository navigation
[backport cloud/1.57] fix: harden workflow load against null initial state and report occurrences - #21977
Conversation
…rences (#21326) Tolerate a missing initial state or change tracker when activating a workflow, refuse to load stored content that is not a JSON object, refuse to save a workflow with no active state, and report each guard hit so the real trigger can be identified. (cherry picked from commit b31319c)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-26T17:04:43.633Z",
"gitSha": "4955ab0c576243884450e6950d57ac171e32e05a",
"branch": "backport-21326-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.9169999999735,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.279,
"layouts": 9,
"layoutDurationMs": 2.9769999999999994,
"taskDurationMs": 399.806,
"heapDeltaBytes": 21708400,
"heapUsedBytes": 87933880,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 12.163,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.08000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4940000000000007,
"layouts": 10,
"layoutDurationMs": 3.266,
"taskDurationMs": 578.99,
"heapDeltaBytes": 3150432,
"heapUsedBytes": 78605324,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 13.062999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1762.6369999999838,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.396999999999997,
"layouts": 9,
"layoutDurationMs": 2.373999999999999,
"taskDurationMs": 752.8979999999999,
"heapDeltaBytes": 15199744,
"heapUsedBytes": 82049880,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 172.215,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.9960000000165,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.865999999999998,
"layouts": 8,
"layoutDurationMs": 2.387,
"taskDurationMs": 920.601,
"heapDeltaBytes": 15561240,
"heapUsedBytes": 81477440,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 167.899,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.1799999999857,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.672,
"layouts": 11,
"layoutDurationMs": 3.5069999999999997,
"taskDurationMs": 426.42,
"heapDeltaBytes": 87096,
"heapUsedBytes": 75234240,
"domNodes": 47,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 13.775999999999996,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.4620000000114,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.9110000000000005,
"layouts": 11,
"layoutDurationMs": 3.112,
"taskDurationMs": 417.4629999999999,
"heapDeltaBytes": 18698108,
"heapUsedBytes": 85038652,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 13.895999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 675.7780000000366,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.614,
"layouts": 8,
"layoutDurationMs": 2.3759999999999994,
"taskDurationMs": 488.819,
"heapDeltaBytes": 25155436,
"heapUsedBytes": 91685056,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 167.81799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 725.6510000000844,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.561,
"layouts": 8,
"layoutDurationMs": 2.5300000000000002,
"taskDurationMs": 515.182,
"heapDeltaBytes": 3537856,
"heapUsedBytes": 79469968,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 172.093,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.06190476190476,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1227.295999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 927.24,
"heapDeltaBytes": -3763584,
"heapUsedBytes": 81344928,
"domNodes": -192,
"jsHeapTotalBytes": 12853248,
"scriptDurationMs": 68.69200000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 530,
"frameDurationMs": 32.883783783783805,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1226.2870000000703,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 912.531,
"heapDeltaBytes": 1138100,
"heapUsedBytes": 81321996,
"domNodes": -192,
"jsHeapTotalBytes": 13901824,
"scriptDurationMs": 77.043,
"eventListeners": -106,
"totalBlockingTimeMs": 526,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 889.0030000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.8219999999997,
"heapDeltaBytes": -4790200,
"heapUsedBytes": 76110896,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 173.012,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.237142857142864,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.1040000000212,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.4139999999997,
"heapDeltaBytes": -3922596,
"heapUsedBytes": 76734912,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 166.14800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 24.762857142857136,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11506.00399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10628.085000000001,
"heapDeltaBytes": -15758436,
"heapUsedBytes": 83727752,
"domNodes": -258,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 8717.011,
"eventListeners": -68,
"totalBlockingTimeMs": 1524,
"frameDurationMs": 32.351820728291315,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11206.795000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10414.833,
"heapDeltaBytes": 636884,
"heapUsedBytes": 88852088,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 8520.834,
"eventListeners": -68,
"totalBlockingTimeMs": 1383,
"frameDurationMs": 31.637005649717516,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10000.897000000008,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.40399999999999986,
"layouts": 1,
"layoutDurationMs": 0.4269999999999999,
"taskDurationMs": 9166.604,
"heapDeltaBytes": 2251392,
"heapUsedBytes": 89750204,
"domNodes": -278,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 7404.007,
"eventListeners": -68,
"totalBlockingTimeMs": 866,
"frameDurationMs": 31.744761904761905,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9021.43699999999,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.33299999999999996,
"layouts": 2,
"layoutDurationMs": 0.568,
"taskDurationMs": 8255.251,
"heapDeltaBytes": -354800,
"heapUsedBytes": 99678884,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 6920.861,
"eventListeners": -68,
"totalBlockingTimeMs": 744,
"frameDurationMs": 32.4423487544484,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 239.29300000003195,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.573999999999998,
"layouts": 12,
"layoutDurationMs": 4.042000000000001,
"taskDurationMs": 178.36900000000003,
"heapDeltaBytes": -8165412,
"heapUsedBytes": 79219820,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.467000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 222.64399999994566,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.758999999999999,
"layouts": 11,
"layoutDurationMs": 3.5249999999999995,
"taskDurationMs": 172.65399999999997,
"heapDeltaBytes": -8268316,
"heapUsedBytes": 79643080,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.629,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.199999999999985,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2054.904000000022,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.479,
"layouts": 8,
"layoutDurationMs": 2.721,
"taskDurationMs": 675.9269999999999,
"heapDeltaBytes": -21350876,
"heapUsedBytes": 75615208,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 36.424,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2057.9850000000306,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7799999999999994,
"layouts": 8,
"layoutDurationMs": 2.6870000000000003,
"taskDurationMs": 685.4670000000001,
"heapDeltaBytes": -2660436,
"heapUsedBytes": 76546288,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 36.09100000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2606.0050000000388,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.657,
"layouts": 7,
"layoutDurationMs": 1.878,
"taskDurationMs": 1772.2859999999998,
"heapDeltaBytes": -30716612,
"heapUsedBytes": 66988392,
"domNodes": -258,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 827.876,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.881818181818183,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2605.316000000016,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.841000000000001,
"layouts": 5,
"layoutDurationMs": 1.5260000000000005,
"taskDurationMs": 1770.0359999999998,
"heapDeltaBytes": -30010884,
"heapUsedBytes": 67902792,
"domNodes": -258,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 850.7829999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.88246753246753,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3800.6920000000264,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.866999999999999,
"layouts": 64,
"layoutDurationMs": 11.246,
"taskDurationMs": 1851.2970000000003,
"heapDeltaBytes": 3799376,
"heapUsedBytes": 81297652,
"domNodes": -254,
"jsHeapTotalBytes": 1699840,
"scriptDurationMs": 800.4689999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.813274336283186,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3783.7070000000494,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.993,
"layouts": 64,
"layoutDurationMs": 10.916,
"taskDurationMs": 1841.376,
"heapDeltaBytes": 2230696,
"heapUsedBytes": 79895572,
"domNodes": -254,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 811.291,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73982300884955,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3104.9150000000054,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.225,
"layouts": 6,
"layoutDurationMs": 1.753,
"taskDurationMs": 2007.3380000000002,
"heapDeltaBytes": 5505204,
"heapUsedBytes": 89009728,
"domNodes": 0,
"jsHeapTotalBytes": 7565312,
"scriptDurationMs": 992.5030000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846739130434784,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3204.556000000025,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.218999999999999,
"layouts": 5,
"layoutDurationMs": 1.5330000000000001,
"taskDurationMs": 2106.1310000000003,
"heapDeltaBytes": -5608952,
"heapUsedBytes": 78363852,
"domNodes": 0,
"jsHeapTotalBytes": 6643712,
"scriptDurationMs": 1033.459,
"eventListeners": 182,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.01851851851852,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2074.5540000000346,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.4259999999999993,
"layouts": 7,
"layoutDurationMs": 2.561,
"taskDurationMs": 694.6110000000001,
"heapDeltaBytes": -17138832,
"heapUsedBytes": 81263468,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 36.589999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2053.149000000076,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.228999999999999,
"layouts": 7,
"layoutDurationMs": 2.2630000000000003,
"taskDurationMs": 525.0450000000001,
"heapDeltaBytes": -2301636,
"heapUsedBytes": 79272708,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 33.413000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.3500000000163,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.6930000000000005,
"layouts": 8,
"layoutDurationMs": 2.133,
"taskDurationMs": 447.33900000000006,
"heapDeltaBytes": 20303460,
"heapUsedBytes": 87227264,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 146.508,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.5090000000773,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.581999999999999,
"layouts": 9,
"layoutDurationMs": 2.8140000000000005,
"taskDurationMs": 403.56800000000004,
"heapDeltaBytes": 21576992,
"heapUsedBytes": 89049944,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 154.75,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.6419999999716,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5179999999999993,
"layouts": 11,
"layoutDurationMs": 3.7590000000000003,
"taskDurationMs": 572.1270000000001,
"heapDeltaBytes": -268036,
"heapUsedBytes": 77086420,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.479,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.8919999999562,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.899999999999999,
"layouts": 9,
"layoutDurationMs": 2.8060000000000005,
"taskDurationMs": 575.443,
"heapDeltaBytes": -248612,
"heapUsedBytes": 77213504,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.54,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1958.9659999999753,
"styleRecalcs": 86,
"styleRecalcDurationMs": 17.014000000000003,
"layouts": 9,
"layoutDurationMs": 2.4419999999999997,
"taskDurationMs": 1061.783,
"heapDeltaBytes": -11418560,
"heapUsedBytes": 65627108,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 117.32100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66525423728813,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1834.333000000015,
"styleRecalcs": 56,
"styleRecalcDurationMs": 15.303999999999998,
"layouts": 7,
"layoutDurationMs": 2.3660000000000005,
"taskDurationMs": 964.2680000000001,
"heapDeltaBytes": 11542144,
"heapUsedBytes": 79137740,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 119.74,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1453.6150000000134,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.375999999999998,
"layouts": 5,
"layoutDurationMs": 14.411,
"taskDurationMs": 1128.3740000000003,
"heapDeltaBytes": 35850700,
"heapUsedBytes": 116515208,
"domNodes": 15953,
"jsHeapTotalBytes": 11669504,
"scriptDurationMs": 46.93100000000001,
"eventListeners": 3244,
"totalBlockingTimeMs": 148,
"frameDurationMs": 19.553333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8337.418000000014,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.230999999999998,
"layouts": 7,
"layoutDurationMs": 2.0540000000000003,
"taskDurationMs": 5240.982,
"heapDeltaBytes": 7335252,
"heapUsedBytes": 86496916,
"domNodes": -258,
"jsHeapTotalBytes": 3497984,
"scriptDurationMs": 2709.8269999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73319919517103,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9868.95000000004,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.394000000000002,
"layouts": 7,
"layoutDurationMs": 2.715,
"taskDurationMs": 6243.108,
"heapDeltaBytes": -27349480,
"heapUsedBytes": 70431684,
"domNodes": -278,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 2877.43,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.722580645161287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16732.28899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15860.654,
"heapDeltaBytes": -23541896,
"heapUsedBytes": 271908984,
"domNodes": -3330,
"jsHeapTotalBytes": 20172800,
"scriptDurationMs": 255.496,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.89913644214162,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16425.89399999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15526.595999999998,
"heapDeltaBytes": -6881672,
"heapUsedBytes": 288704720,
"domNodes": -3330,
"jsHeapTotalBytes": 25153536,
"scriptDurationMs": 251.348,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.30344827586207,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 27933.762000000002,
"styleRecalcs": 180,
"styleRecalcDurationMs": 17.268000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27521,
"heapDeltaBytes": -26683916,
"heapUsedBytes": 274249852,
"domNodes": -3330,
"jsHeapTotalBytes": 6017024,
"scriptDurationMs": 929.74,
"eventListeners": -651,
"totalBlockingTimeMs": 40,
"frameDurationMs": 51.440699815837945,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27759.591999999997,
"styleRecalcs": 180,
"styleRecalcDurationMs": 16.43699999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27415.771000000004,
"heapDeltaBytes": -20969668,
"heapUsedBytes": 255391740,
"domNodes": -3330,
"jsHeapTotalBytes": 8376320,
"scriptDurationMs": 873.0649999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 33,
"frameDurationMs": 51.35611111111111,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8391.41699999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.822,
"layouts": 20,
"layoutDurationMs": 22.957000000000004,
"taskDurationMs": 8274.556,
"heapDeltaBytes": -36326232,
"heapUsedBytes": 259730520,
"domNodes": -3330,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 144.805,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.63068181818182,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 5997.119999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.76599999999999,
"layouts": 20,
"layoutDurationMs": 22.52299999999999,
"taskDurationMs": 5866.103,
"heapDeltaBytes": -30093880,
"heapUsedBytes": 260646224,
"domNodes": -3330,
"jsHeapTotalBytes": 25939968,
"scriptDurationMs": 100.79400000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 17,
"frameDurationMs": 35.086549707602344,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11470.889,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11257.73,
"heapDeltaBytes": 4518532,
"heapUsedBytes": 281177160,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.25500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.95071428571429,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8211.026999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7763.416000000001,
"heapDeltaBytes": -141412,
"heapUsedBytes": 274517268,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 124.03500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.430449826989612,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 135.8109999999897,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.059000000000003,
"layouts": 8,
"layoutDurationMs": 3.384,
"taskDurationMs": 96.98899999999999,
"heapDeltaBytes": 4562280,
"heapUsedBytes": 77735604,
"domNodes": 116,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.706999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 493.51500000000215,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.86,
"layouts": 12,
"layoutDurationMs": 4.484,
"taskDurationMs": 132.02199999999996,
"heapDeltaBytes": 6724640,
"heapUsedBytes": 79675536,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.897000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 407.44999999992615,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.911,
"layouts": 76,
"layoutDurationMs": 13.635,
"taskDurationMs": 361.107,
"heapDeltaBytes": -14655072,
"heapUsedBytes": 81301972,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 173.702,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 537.5730000000658,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.008,
"layouts": 76,
"layoutDurationMs": 16.272,
"taskDurationMs": 484.064,
"heapDeltaBytes": -20808780,
"heapUsedBytes": 73442664,
"domNodes": 4,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 234.16699999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665624999999977,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 575.0759999999673,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2439999999999998,
"layouts": 76,
"layoutDurationMs": 15.58,
"taskDurationMs": 543.712,
"heapDeltaBytes": 210768,
"heapUsedBytes": 131723464,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 221.09300000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 585.9820000000582,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.5010000000000003,
"layouts": 76,
"layoutDurationMs": 15.294,
"taskDurationMs": 543.892,
"heapDeltaBytes": 1162600,
"heapUsedBytes": 125229328,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 220.79399999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2282 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d2181205fe1b43302ae2605ef5c096775746a785
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.57 #21977 +/- ##
=============================================
Coverage ? 85.21%
=============================================
Files ? 2524
Lines ? 133150
Branches ? 38350
=============================================
Hits ? 113469
Misses ? 19265
Partials ? 416
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed at exact head daface33fae7226aaacdfc84ff0de211a9fab11e. The production hunks preserve merged #21326 on cloud/1.57; the release-only adaptations are limited to test imports and mocks for modules absent from this branch. The null-state refusal and recovery paths remain fail-closed, and browser_tests/tests/workflowNullStoredContent.spec.ts is unchanged. Targeted Vitest passes 338/338 locally, the changed-spec Playwright job passes, and I found no substantive issue.
Requested via Slack thread
Before: if a workflow became the active one without its change tracker ever loading, activating it threw
Cannot read properties of null (reading 'extra')(and a siblingreading 'nodes'of null inChangeTracker.graphEqual). A save from that state could also writenullover the stored workflow file.After: the missing state is tolerated where it is read, an unloaded workflow is loaded instead of being returned as loaded, a save from an unloaded workflow is refused, and each guard hit is reported with enough structure to identify the real trigger.
Manual backport of #21326 (the automatic backport hit conflicts).
Conflict resolved:
src/platform/workflow/core/services/workflowService.test.tsonly, in thevi.mockblock near the top. Kept the new@/base/assertmock and dropped the twolateCustomNodesmocks, since that module does not exist on this branch. The cherry-pick commit message was reworded; no code changes beyond the original PR.Local checks: typecheck (app and browser), oxfmt, oxlint and eslint on touched files, and vitest for
src/platform/workflowandsrc/scripts/changeTracker(64 files, 1232 passed). The new Playwright specbrowser_tests/tests/workflowNullStoredContent.spec.tsis included but was only typechecked locally, not run.Generated by Claude Code