Repository navigation
[backport cloud/1.57] Defer agent onboarding coach while a global dialog is open - #21953
Conversation
- Fixes [PM-2221](https://linear.app/comfyorg/issue/PM-2221/cloud-agent-tutorial-covers-the-sign-in-confirm-modal-on-first-desktop): the Agent onboarding coach no longer covers the managed desktop sign-in confirmation. - Adds `dialog_open` as a coach deferral reason, derived reactively from the dialog store. - Reads the dialog store directly without an intermediate composable; dialog mutation and rendering stay with the dialog host. - [x] `pnpm test:unit src/workbench/extensions/agent/AgentPanelRoot.test.ts --retry=0` (551/551) - [x] `pnpm lint:unstaged:fix` - [x] `pnpm architecture:check` - [x] `pnpm typecheck:app` - [x] pre-push dependency, knip, and Fallow gates - [x] `browser_tests/tests/agent/agentConsent.spec.ts` at buggy parent `78492d6a93` with the new case applied: failed at the visible overlap assertion (`Expected: 1`, `Received: 2` dialogs). - [x] The same focused `@cloud` case at `97f0971cd4`, zero retries: 1 passed. - [x] Full consent spec, zero retries: the new case and 24 others passed; one pre-existing reload case hit the cold-server 15-second timeout and passed immediately when rerun alone. - [x] Browser typecheck, type-aware Oxlint, formatting, dependency cruise, knip, and Fallow gates pass. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-25T22:55:56.246Z",
"gitSha": "79334c93feb402ebe21e4108fbf3952b5396a687",
"branch": "backport-21928-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.0730000000008,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6169999999999995,
"layouts": 9,
"layoutDurationMs": 2.937,
"taskDurationMs": 353.688,
"heapDeltaBytes": 22155360,
"heapUsedBytes": 88237648,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.341,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.8280000000177,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1439999999999992,
"layouts": 10,
"layoutDurationMs": 3.4,
"taskDurationMs": 534.0039999999999,
"heapDeltaBytes": -816304,
"heapUsedBytes": 75118644,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.929000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1960.5609999999842,
"styleRecalcs": 83,
"styleRecalcDurationMs": 15.966999999999999,
"layouts": 11,
"layoutDurationMs": 2.7940000000000005,
"taskDurationMs": 907.3449999999999,
"heapDeltaBytes": 15625164,
"heapUsedBytes": 81518928,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 164.102,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2007.712999999967,
"styleRecalcs": 85,
"styleRecalcDurationMs": 15.947,
"layouts": 9,
"layoutDurationMs": 2.8770000000000002,
"taskDurationMs": 1090.218,
"heapDeltaBytes": -7819944,
"heapUsedBytes": 66824580,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 167.492,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.5130000000113,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.295,
"layouts": 12,
"layoutDurationMs": 3.406,
"taskDurationMs": 305.96999999999997,
"heapDeltaBytes": 18795892,
"heapUsedBytes": 85124132,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 13.326999999999995,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.7440000001006,
"styleRecalcs": 18,
"styleRecalcDurationMs": 8.799000000000001,
"layouts": 11,
"layoutDurationMs": 3.1979999999999995,
"taskDurationMs": 453.38,
"heapDeltaBytes": -91396,
"heapUsedBytes": 75546632,
"domNodes": 47,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 15.567,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 686.8139999999698,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2259999999999995,
"layouts": 10,
"layoutDurationMs": 3.2740000000000005,
"taskDurationMs": 463.65000000000003,
"heapDeltaBytes": 26119212,
"heapUsedBytes": 92347528,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 185.255,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 678.9980000000924,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.091,
"layouts": 9,
"layoutDurationMs": 2.9380000000000006,
"taskDurationMs": 490.36500000000007,
"heapDeltaBytes": 7093056,
"heapUsedBytes": 82095732,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 165.946,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.998999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 906.881,
"heapDeltaBytes": -3775260,
"heapUsedBytes": 81216992,
"domNodes": -212,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 70.352,
"eventListeners": -106,
"totalBlockingTimeMs": 525,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.2539999999635,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 918.1469999999999,
"heapDeltaBytes": -11487748,
"heapUsedBytes": 81717312,
"domNodes": -212,
"jsHeapTotalBytes": 19668992,
"scriptDurationMs": 70.71199999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 524,
"frameDurationMs": 32.01578947368422,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.391000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.66600000000017,
"heapDeltaBytes": -4483008,
"heapUsedBytes": 76224440,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.60000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.0529999999699,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.42999999999984,
"heapDeltaBytes": -3566576,
"heapUsedBytes": 76090692,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 157.914,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 24.759999999999984,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11202.027999999984,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05400000000000023,
"layouts": 1,
"layoutDurationMs": 0.3029999999999999,
"taskDurationMs": 10283.729,
"heapDeltaBytes": -27475296,
"heapUsedBytes": 71993964,
"domNodes": -278,
"jsHeapTotalBytes": 8777728,
"scriptDurationMs": 8378.576000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1347,
"frameDurationMs": 31.998571428571427,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9412.498000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8579.283,
"heapDeltaBytes": 3101560,
"heapUsedBytes": 103292784,
"domNodes": -278,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 6916.042,
"eventListeners": -68,
"totalBlockingTimeMs": 608,
"frameDurationMs": 31.179801324503316,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10592.248000000012,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2149999999999999,
"layouts": 1,
"layoutDurationMs": 0.26200000000000007,
"taskDurationMs": 9805.144,
"heapDeltaBytes": -8425112,
"heapUsedBytes": 88922484,
"domNodes": -258,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 8015.149000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 1081,
"frameDurationMs": 31.546130952380953,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10530.259000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9739.034,
"heapDeltaBytes": -6035976,
"heapUsedBytes": 88863412,
"domNodes": -278,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 7937.526,
"eventListeners": -68,
"totalBlockingTimeMs": 999,
"frameDurationMs": 31.25489614243324,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 213.76300000000015,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.890000000000002,
"layouts": 11,
"layoutDurationMs": 3.4200000000000004,
"taskDurationMs": 153.036,
"heapDeltaBytes": -8145072,
"heapUsedBytes": 79385608,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.470999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.660000000000036,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 218.90399999995225,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.852,
"layouts": 11,
"layoutDurationMs": 3.516,
"taskDurationMs": 167.24000000000004,
"heapDeltaBytes": -8082656,
"heapUsedBytes": 79307224,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.293999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181787,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2041.4670000000115,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.728,
"layouts": 9,
"layoutDurationMs": 2.7340000000000004,
"taskDurationMs": 644.4250000000002,
"heapDeltaBytes": -24132332,
"heapUsedBytes": 73215488,
"domNodes": -258,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 34.897999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.6499999999905,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6440000000000006,
"layouts": 8,
"layoutDurationMs": 2.5820000000000003,
"taskDurationMs": 641.929,
"heapDeltaBytes": -23161312,
"heapUsedBytes": 74121812,
"domNodes": -278,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 32.529,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2461.2169999999765,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.729000000000001,
"layouts": 7,
"layoutDurationMs": 1.9449999999999998,
"taskDurationMs": 1674.4360000000001,
"heapDeltaBytes": -355052,
"heapUsedBytes": 76619560,
"domNodes": -258,
"jsHeapTotalBytes": 2973696,
"scriptDurationMs": 806.688,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780136986301372,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2321.9139999999925,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.693999999999999,
"layouts": 7,
"layoutDurationMs": 2.056,
"taskDurationMs": 1578.0899999999997,
"heapDeltaBytes": -1218736,
"heapUsedBytes": 78570116,
"domNodes": -258,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 826.716,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786861313868613,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3817.8819999999973,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.603000000000001,
"layouts": 64,
"layoutDurationMs": 10.864,
"taskDurationMs": 1805.3799999999999,
"heapDeltaBytes": 3812260,
"heapUsedBytes": 81283924,
"domNodes": -254,
"jsHeapTotalBytes": 1699840,
"scriptDurationMs": 789.109,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.739207048458155,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3846.2430000000722,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.927000000000001,
"layouts": 64,
"layoutDurationMs": 11.325,
"taskDurationMs": 1854.0660000000003,
"heapDeltaBytes": -18068136,
"heapUsedBytes": 81522956,
"domNodes": -234,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 818.6220000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.81135371179039,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3084.6149999999852,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.055,
"layouts": 5,
"layoutDurationMs": 1.3930000000000002,
"taskDurationMs": 1970.386,
"heapDeltaBytes": 16314720,
"heapUsedBytes": 99802424,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 975.488,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84863387978142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3075.5980000000136,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.757000000000001,
"layouts": 4,
"layoutDurationMs": 1.2270000000000003,
"taskDurationMs": 1871.418,
"heapDeltaBytes": 14140184,
"heapUsedBytes": 97513844,
"domNodes": 0,
"jsHeapTotalBytes": 8544256,
"scriptDurationMs": 1020.3909999999998,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.030601092896173,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2056.0449999999832,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9230000000000003,
"layouts": 7,
"layoutDurationMs": 2.245,
"taskDurationMs": 622.381,
"heapDeltaBytes": -4867452,
"heapUsedBytes": 77569908,
"domNodes": -278,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 31.134999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2051.527999999962,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8780000000000006,
"layouts": 8,
"layoutDurationMs": 2.3829999999999996,
"taskDurationMs": 565.807,
"heapDeltaBytes": -3972040,
"heapUsedBytes": 77127524,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 36.065,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 673.2349999999769,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.228000000000001,
"layouts": 9,
"layoutDurationMs": 2.6229999999999998,
"taskDurationMs": 437.59400000000005,
"heapDeltaBytes": 21636656,
"heapUsedBytes": 89084048,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 151.03900000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.6739999999927,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.324999999999999,
"layouts": 10,
"layoutDurationMs": 2.7520000000000007,
"taskDurationMs": 391.407,
"heapDeltaBytes": 21208900,
"heapUsedBytes": 87718656,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 150.824,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.1259999999907,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.934,
"layouts": 9,
"layoutDurationMs": 2.7060000000000004,
"taskDurationMs": 522.446,
"heapDeltaBytes": -666940,
"heapUsedBytes": 75945488,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.363,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2008.93700000006,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4719999999999995,
"layouts": 10,
"layoutDurationMs": 3.339,
"taskDurationMs": 349.657,
"heapDeltaBytes": 22036884,
"heapUsedBytes": 89438208,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.611999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.9589999999735,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.726,
"layouts": 9,
"layoutDurationMs": 2.561,
"taskDurationMs": 807.471,
"heapDeltaBytes": -7279176,
"heapUsedBytes": 69683092,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 110.492,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1971.3540000000194,
"styleRecalcs": 87,
"styleRecalcDurationMs": 17.079,
"layouts": 10,
"layoutDurationMs": 2.862,
"taskDurationMs": 896.241,
"heapDeltaBytes": 11658348,
"heapUsedBytes": 79548152,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 112.084,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.0729999999844,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.165,
"layouts": 5,
"layoutDurationMs": 14.056,
"taskDurationMs": 1091.9969999999998,
"heapDeltaBytes": 14049108,
"heapUsedBytes": 123277884,
"domNodes": 15953,
"jsHeapTotalBytes": 14553088,
"scriptDurationMs": 28.915000000000003,
"eventListeners": 3244,
"totalBlockingTimeMs": 159,
"frameDurationMs": 20.089041095890412,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9385.981999999956,
"styleRecalcs": 248,
"styleRecalcDurationMs": 18.645000000000003,
"layouts": 6,
"layoutDurationMs": 1.7470000000000003,
"taskDurationMs": 5925.448,
"heapDeltaBytes": 114224,
"heapUsedBytes": 78999048,
"domNodes": -258,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2681.9139999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755357142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9807.350000000042,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.126,
"layouts": 8,
"layoutDurationMs": 2.541,
"taskDurationMs": 6097.147000000001,
"heapDeltaBytes": 4594024,
"heapUsedBytes": 83965688,
"domNodes": -258,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 2729.594,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.722866894197953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23111.78000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22534.767,
"heapDeltaBytes": -5236476,
"heapUsedBytes": 285355788,
"domNodes": -3330,
"jsHeapTotalBytes": 9166848,
"scriptDurationMs": 352.06100000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.854827586206895,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 23393.931000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22977.452,
"heapDeltaBytes": -20328860,
"heapUsedBytes": 275299372,
"domNodes": -3330,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 338.79400000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.93653846153846,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 27963.049000000014,
"styleRecalcs": 180,
"styleRecalcDurationMs": 16.254999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27578.308000000005,
"heapDeltaBytes": -16867500,
"heapUsedBytes": 283820776,
"domNodes": -3330,
"jsHeapTotalBytes": 4636672,
"scriptDurationMs": 907.9350000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 57,
"frameDurationMs": 51.094881170018276,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 19111.323999999968,
"styleRecalcs": 165,
"styleRecalcDurationMs": 11.629000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18675.646999999997,
"heapDeltaBytes": -38761196,
"heapUsedBytes": 262943028,
"domNodes": -3330,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 822.1709999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.946800731261426,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8177.068000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.61899999999999,
"layouts": 20,
"layoutDurationMs": 22.564,
"taskDurationMs": 8080.092000000001,
"heapDeltaBytes": -34849580,
"heapUsedBytes": 261055820,
"domNodes": -3330,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 120.73400000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.30057803468208,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8487.148999999932,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.598,
"layouts": 20,
"layoutDurationMs": 24.20399999999999,
"taskDurationMs": 8380.854,
"heapDeltaBytes": -42074252,
"heapUsedBytes": 253948264,
"domNodes": -3330,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 128.672,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.60934065934067,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8237.122999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7740.495999999998,
"heapDeltaBytes": -4409328,
"heapUsedBytes": 249679796,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.66199999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.003401360544217,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11372.744000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10983.818000000001,
"heapDeltaBytes": 4222712,
"heapUsedBytes": 277989464,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.83000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.660544217687075,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 487.88999999999305,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.572000000000003,
"layouts": 12,
"layoutDurationMs": 4.966,
"taskDurationMs": 152.675,
"heapDeltaBytes": -7802796,
"heapUsedBytes": 71671940,
"domNodes": 126,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 19.441000000000003,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 490.56099999995695,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.299999999999999,
"layouts": 11,
"layoutDurationMs": 4.234,
"taskDurationMs": 145.187,
"heapDeltaBytes": 6797476,
"heapUsedBytes": 79839800,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.525,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 517.4329999999827,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.95,
"layouts": 76,
"layoutDurationMs": 16.069,
"taskDurationMs": 475.017,
"heapDeltaBytes": 12155232,
"heapUsedBytes": 83316752,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 231.038,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 491.96100000006027,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.232,
"layouts": 76,
"layoutDurationMs": 15.08,
"taskDurationMs": 437.14799999999997,
"heapDeltaBytes": 11664528,
"heapUsedBytes": 84528272,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 212.457,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 613.381000000004,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.206,
"layouts": 76,
"layoutDurationMs": 15.284,
"taskDurationMs": 580.9449999999999,
"heapDeltaBytes": 1231208,
"heapUsedBytes": 119852476,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 246.824,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 610.9910000000127,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.275,
"layouts": 76,
"layoutDurationMs": 16.064999999999998,
"taskDurationMs": 574.6899999999999,
"heapDeltaBytes": 1042980,
"heapUsedBytes": 128632752,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 238.43,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.11621621621622,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2285 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1f0d5e900a71ad327cb1e6e28268b1db48ca1507
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21953 +/- ##
=============================================
Coverage ? 85.21%
=============================================
Files ? 2524
Lines ? 133099
Branches ? 40757
=============================================
Hits ? 113416
Misses ? 19267
Partials ? 416
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: I approve this faithful backport of #21928.
I compared every changed hunk with merged source commit eb9a4fc557, which is on current main. The component, telemetry type, unit test, and browser regression changes match exactly, with the release branch's existing imports preserved. The omitted architecture changes account for cloud/1.57's older inventory: it has neither the Agent nor dialog-host domain records or corresponding boundary entries. Its architecture check passes without adding those main-only records. No behavior or tests were dropped.
With this branch's locked dependencies, pnpm test:unit src/workbench/extensions/agent/AgentPanelRoot.test.ts --retry=0 passes all 434 tests. Changed-file type-aware Oxlint and git diff --check pass. The required lint-and-format, test, and e2e-status checks are green at the reviewed head. The non-required coverage-packaging job fails on duplicate inner_clicked function metadata in LGraphCanvas, which I verified in its job log, outside this change.
Backport of #21928.
The automated backport run failed because the release branches no longer carry the generated architecture inventory files and the Agent panel tests have branch-specific imports. This carrier preserves the release branch structure and applies only the onboarding-dialog deferral behavior, telemetry reason, unit coverage, and browser regression.
Validation:
AgentPanelRoot.test.tssuite passed on both the 1.56 and 1.57 release lines.git diff --checkpassed.