Repository navigation
refactor: default Iconify icons to size-4 #21949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0a23f21
refactor: default Iconify icons to size-4
DrJKL ee5c6eb
fix: preserve intentional icon sizing exceptions
DrJKL 78e50c4
refactor: normalize icon sizing exceptions
DrJKL 42add94
[automated] Update screenshot expectations
invalid-email-address 140eddc
refactor: normalize icon elements and prevent icon shrinking
DrJKL 247082c
[automated] Update screenshot expectations
invalid-email-address 90b4b25
test: fix agent icon selectors
DrJKL 2e56c24
lint: require Iconify classes on i elements
DrJKL e674e82
fix: preserve category spacing and verify icon overrides
DrJKL fc96d72
fix: distinguish icon classes from comparison operands and other bind…
DrJKL bf82d38
fix: let selection toolbox icons use shared sizing
DrJKL 4976dd2
fix: remove redundant icon layout declarations
DrJKL edf9daf
fix: keep credit badge icons square
DrJKL e128c87
[automated] Update screenshot expectations
invalid-email-address 0e55d7a
Merge main into fix/default-icon-size
DrJKL 1a713a5
[automated] Update screenshot expectations
invalid-email-address b844516
fix: reject redundant default icon utilities
DrJKL 3db486c
Merge branch 'main' into fix/default-icon-size
DrJKL d53ede5
[automated] Update screenshot expectations
invalid-email-address 0faacd7
fix: use shorthand bindings for top-up amount fields
DrJKL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+141 Bytes
(100%)
...ppChrome/appChrome.spec.ts-snapshots/app-chrome-side-toolbar-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+230 Bytes
(100%)
...tests/appChrome/appChrome.spec.ts-snapshots/app-kitchen-sink-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-56 Bytes
(99%)
...ts/tests/canvasSettings.spec.ts-snapshots/canvas-info-hud-on-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+22 Bytes
(100%)
...olorPalette.spec.ts-snapshots/custom-light-palette-menu-open-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { | ||
| comfyExpect as expect, | ||
| comfyPageFixture as test | ||
| } from '@e2e/fixtures/ComfyPage' | ||
|
|
||
| test( | ||
| 'Icon dimensions honor explicit utilities', | ||
| { tag: '@ui' }, | ||
| async ({ comfyPage }) => { | ||
| const sizes = await comfyPage.page.evaluate(() => | ||
| ['', 'size-3', 'size-6 shrink', 'w-8 h-5'].map((utilities) => { | ||
| const icon = document.createElement('i') | ||
| icon.className = `icon-[lucide--check] ${utilities}` | ||
| document.body.append(icon) | ||
| const style = getComputedStyle(icon) | ||
| const dimensions = [style.width, style.height, style.flexShrink] | ||
| icon.remove() | ||
| return dimensions | ||
| }) | ||
| ) | ||
|
|
||
| expect(sizes).toEqual([ | ||
| ['16px', '16px', '0'], | ||
| ['12px', '12px', '0'], | ||
| ['24px', '24px', '1'], | ||
| ['32px', '20px', '0'] | ||
| ]) | ||
| } | ||
| ) |
Binary file modified
BIN
+192 Bytes
(100%)
...execution.spec.ts-snapshots/execution-error-unconnected-slot-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+25 Bytes
(100%)
...tests/links/linkVisibility.spec.ts-snapshots/vue-link-hidden-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+26 Bytes
(100%)
...inkVisibility.spec.ts-snapshots/vue-link-revealed-from-input-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+28 Bytes
(100%)
...nkVisibility.spec.ts-snapshots/vue-link-revealed-from-output-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+27 Bytes
(100%)
...ty.spec.ts-snapshots/vue-link-revealed-while-dragging-output-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+58 Bytes
(100%)
...obileBaseline.spec.ts-snapshots/mobile-default-workflow-mobile-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+124 Bytes
(100%)
...ts/mobileBaseline.spec.ts-snapshots/mobile-empty-canvas-mobile-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+34 Bytes
(100%)
...eBaseline.spec.ts-snapshots/mobile-graph-canvas-toolbar-mobile-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6 Bytes
(100%)
...mobileBaseline.spec.ts-snapshots/mobile-settings-dialog-mobile-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-19 Bytes
(100%)
...r_tests/tests/nodeBadge.spec.ts-snapshots/api-pricing-on-vue-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+39 Bytes
(100%)
...veImageAndWebp.spec.ts-snapshots/save-image-and-webm-preview-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-56 Bytes
(100%)
...ox.spec.ts-snapshots/selection-toolbox-multiple-nodes-border-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+61 Bytes
(100%)
...ec.ts-snapshots/selection-toolbox-multiple-selections-border-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-70 Bytes
(100%)
...ox.spec.ts-snapshots/selection-toolbox-single-node-no-border-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2 Bytes
(100%)
...ates.spec.ts-snapshots/template-filter-bar-select-components-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+114 Bytes
(100%)
...iewport.spec.ts-snapshots/viewport-fits-when-saved-offscreen-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+99 Bytes
(100%)
...s/groups/groups.spec.ts-snapshots/vue-groups-fit-to-contents-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+213 Bytes
(100%)
...canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+191 Bytes
(100%)
...eractions/canvas/zoom.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+80 Bytes
(100%)
...nks/linkInteraction.spec.ts-snapshots/vue-node-dragging-link-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+79 Bytes
(100%)
...nkInteraction.spec.ts-snapshots/vue-node-input-drag-ctrl-alt-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+77 Bytes
(100%)
...eraction.spec.ts-snapshots/vue-node-input-drag-reuses-origin-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+74 Bytes
(100%)
...inkInteraction.spec.ts-snapshots/vue-node-reroute-input-drag-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+77 Bytes
(100%)
...teraction.spec.ts-snapshots/vue-node-shift-output-multi-link-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+77 Bytes
(100%)
...inks/linkInteraction.spec.ts-snapshots/vue-node-snap-to-node-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+80 Bytes
(100%)
...inks/linkInteraction.spec.ts-snapshots/vue-node-snap-to-slot-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+85 Bytes
(100%)
...ingToFront.spec.ts-snapshots/bring-to-front-overlapped-after-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+87 Bytes
(100%)
...ngToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+61 Bytes
(100%)
...deStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+81 Bytes
(100%)
...rs.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+191 Bytes
(100%)
...spec.ts-snapshots/vue-node-required-input-missing-slot-error-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+26 Bytes
(100%)
...s/rerouteNodeSize.spec.ts-snapshots/vue-reroute-node-compact-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+66 Bytes
(100%)
...2ImagePromptRerun.spec.ts-snapshots/flux2-prompt-after-run-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+66 Bytes
(100%)
...2ImagePromptRerun.spec.ts-snapshots/flux2-prompt-after-run-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+65 Bytes
(100%)
...2ImagePromptRerun.spec.ts-snapshots/flux2-prompt-before-runs-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+87 Bytes
(100%)
...dgetHoverColor.spec.ts-snapshots/editable-widget-hover-color-chromium-linux.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's an actual regression here, but from quick testing, I don't think it's caused by this PR. The dropdown arrow should have reduced visibility when no options exist.
Edit: From initial tests, it seems that this was never implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not changed: the base version of WidgetSelectDefault already uses the same muted foreground for both disabled branches and does not dim the arrow when options are empty. This PR changes its dimensions, not that condition. I left the pre-existing empty-options behavior outside this sizing change.