Repository navigation
test(agent): wait for consent state before coach assertion - #21948
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Approval-state assertions browser_tests/tests/agent/agentConsent.spec.ts |
The test retains the agentPanel fixture and checks for exactly one Agent entry separator while approval is open. It continues to check that the coach appears after approval closes. |
Priority:
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Other
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21532: Updates the Desktop Agent consent flow and its test coverage.
- Comfy-Org/ComfyUI_frontend#21928: Adds and tests the Agent onboarding coach deferral while a dialog is open.
Suggested reviewers: drjkl, dante01yoon, ryan-di
Merge Risk: 
Minimal · up to d306e
-
This is a test-only change that waits on a visible Agent entry state that appears only after the consent check settles. No concrete flakiness or product-behavior risk remains, so it is ready to merge.
Pre-merge checks: 
7
-
Full details: Title check
-
Explanation
The title "test(agent): wait for consent state before coach assertion" matches the main change: the coach deferral test now waits for the consent-backed Agent entry state before its assertion. It is specific, concise, and follows a conventional commit style. It names the test scope and the key behavior change.
Full details: Description check
-
Explanation
The description has a Summary section that explains the change: it waits for the consent-backed Agent entry state before asserting that desktop approval is the only open dialog, and it notes the stacking on
#21928and the test-only, nonblocking scope. It has a Verification section listing the typecheck command, the oxfmt check, and a focused Playwright run with repeat results. It does not include a linked issue line, but the template marks that line as optional. The post-release section is also omitted, which the template treats as optional. The summary states the problem in terms of the test behavior rather than the resulting product behavior, which is a minor gap against the template's guidance.
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes only
browser_tests/tests/agent/agentConsent.spec.ts. It updates an end-to-end test and does not change the main frontend application undersrc/orpackages/. The check therefore does not apply.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The only changed file is
browser_tests/tests/agent/agentConsent.spec.ts. It is outsidesrc/lib/litegraph/,src/ecs/, and the listed graph-entity file categories. The ADR-LAYOUT and ADR-ECS checks do not apply.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-25T22:48:39.159Z",
"gitSha": "440071063c2bf5a80100e2ab2b8d396b970102b6",
"branch": "christian/test-agent-coach-consent-readiness",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.932000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9860000000000007,
"layouts": 9,
"layoutDurationMs": 2.829,
"taskDurationMs": 547.768,
"heapDeltaBytes": 6009016,
"heapUsedBytes": 75912688,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 8.674999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2032.654999999977,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1310000000000002,
"layouts": 9,
"layoutDurationMs": 2.864,
"taskDurationMs": 539.213,
"heapDeltaBytes": 6133964,
"heapUsedBytes": 76751432,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 10.059999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.394999999999,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.802000000000001,
"layouts": 8,
"layoutDurationMs": 2.5750000000000006,
"taskDurationMs": 932.218,
"heapDeltaBytes": -9385876,
"heapUsedBytes": 50781612,
"domNodes": -161,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 162.66899999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1787.3979999999392,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.142999999999999,
"layouts": 10,
"layoutDurationMs": 2.8440000000000003,
"taskDurationMs": 932.843,
"heapDeltaBytes": -7969312,
"heapUsedBytes": 52338092,
"domNodes": -161,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 168.08100000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.1719999999964,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.692000000000001,
"layouts": 11,
"layoutDurationMs": 3.287,
"taskDurationMs": 415.14900000000006,
"heapDeltaBytes": 1415820,
"heapUsedBytes": 71489500,
"domNodes": 56,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 11.602999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.9579999999196,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.238999999999999,
"layouts": 9,
"layoutDurationMs": 2.794,
"taskDurationMs": 442.358,
"heapDeltaBytes": -100572,
"heapUsedBytes": 60999960,
"domNodes": 56,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 14.31,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 694.1190000000006,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9709999999999996,
"layouts": 9,
"layoutDurationMs": 2.6820000000000004,
"taskDurationMs": 502.07499999999993,
"heapDeltaBytes": 5645720,
"heapUsedBytes": 66181768,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 171.43900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 701.4000000000351,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.3559999999999994,
"layouts": 10,
"layoutDurationMs": 2.97,
"taskDurationMs": 514.171,
"heapDeltaBytes": 8838552,
"heapUsedBytes": 79469984,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 171.36499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.7130000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 889.1379999999999,
"heapDeltaBytes": -2670632,
"heapUsedBytes": 75017528,
"domNodes": -191,
"jsHeapTotalBytes": 13901824,
"scriptDurationMs": 73.00099999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 518,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.779000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 901.0789999999998,
"heapDeltaBytes": -1530804,
"heapUsedBytes": 75360168,
"domNodes": -191,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 71.77499999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 527,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.9810000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.1570000000002,
"heapDeltaBytes": -4266960,
"heapUsedBytes": 69181392,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 166.88199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.0309999999545,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.7709999999997,
"heapDeltaBytes": -4335672,
"heapUsedBytes": 70376560,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.779,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 25.485294117647086,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10836.714999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9995.285000000002,
"heapDeltaBytes": 67093488,
"heapUsedBytes": 148031596,
"domNodes": -257,
"jsHeapTotalBytes": 70381568,
"scriptDurationMs": 8056.2339999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 1225,
"frameDurationMs": 32.24077380952381,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11344.290999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10555.207,
"heapDeltaBytes": 17671748,
"heapUsedBytes": 78118816,
"domNodes": -257,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 8577.672,
"eventListeners": -68,
"totalBlockingTimeMs": 1434,
"frameDurationMs": 32.0135593220339,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10874.323000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10140.623,
"heapDeltaBytes": -6766108,
"heapUsedBytes": 82316308,
"domNodes": -257,
"jsHeapTotalBytes": 12709888,
"scriptDurationMs": 8323.227,
"eventListeners": -68,
"totalBlockingTimeMs": 1327,
"frameDurationMs": 31.58808139534884,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11607.948999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10815.166,
"heapDeltaBytes": -5009988,
"heapUsedBytes": 84707856,
"domNodes": -257,
"jsHeapTotalBytes": 14020608,
"scriptDurationMs": 8909.641000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1751,
"frameDurationMs": 32.860056657223794,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-combo-open",
"durationMs": 272.80600000000277,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.976999999999999,
"layouts": 11,
"layoutDurationMs": 5.717,
"taskDurationMs": 247.98600000000002,
"heapDeltaBytes": -23187964,
"heapUsedBytes": 65906752,
"domNodes": -2315,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 8.839999999999998,
"eventListeners": -573,
"totalBlockingTimeMs": 4,
"frameDurationMs": 22.23333333333331,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 221.8800000000556,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.722,
"layouts": 7,
"layoutDurationMs": 2.215,
"taskDurationMs": 158.18099999999995,
"heapDeltaBytes": 14589192,
"heapUsedBytes": 73106124,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.357,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.066666666666706,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2055.601999999965,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.768,
"layouts": 8,
"layoutDurationMs": 2.4389999999999996,
"taskDurationMs": 689.543,
"heapDeltaBytes": 2451320,
"heapUsedBytes": 83061532,
"domNodes": -257,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 34.72500000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.2720000000118,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9360000000000004,
"layouts": 9,
"layoutDurationMs": 2.7309999999999994,
"taskDurationMs": 649.056,
"heapDeltaBytes": -24504468,
"heapUsedBytes": 66850312,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 34.144999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2468.2880000000296,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.073,
"layouts": 4,
"layoutDurationMs": 1.0630000000000002,
"taskDurationMs": 1643.278,
"heapDeltaBytes": 15499536,
"heapUsedBytes": 76316132,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 813.615,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66554054054054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2523.922999999968,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.624,
"layouts": 7,
"layoutDurationMs": 1.839,
"taskDurationMs": 1711.7340000000004,
"heapDeltaBytes": -11683084,
"heapUsedBytes": 60373456,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 817.652,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.776666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3783.920999999964,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.014,
"layouts": 64,
"layoutDurationMs": 10.315,
"taskDurationMs": 1804.607,
"heapDeltaBytes": 2794412,
"heapUsedBytes": 74137600,
"domNodes": -233,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 786.98,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666079295154187,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3726.2490000000525,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.001,
"layouts": 63,
"layoutDurationMs": 10.61,
"taskDurationMs": 1805.3849999999998,
"heapDeltaBytes": -2190124,
"heapUsedBytes": 69799692,
"domNodes": -233,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 781.713,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591928251121,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3278.9300000000026,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.637,
"layouts": 5,
"layoutDurationMs": 1.44,
"taskDurationMs": 2157.522,
"heapDeltaBytes": -5063900,
"heapUsedBytes": 80920896,
"domNodes": -257,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 1068.091,
"eventListeners": -63,
"totalBlockingTimeMs": 10,
"frameDurationMs": 16.92205128205128,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3162.078000000065,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.401000000000001,
"layouts": 6,
"layoutDurationMs": 1.5839999999999999,
"taskDurationMs": 2000.9710000000002,
"heapDeltaBytes": -1406416,
"heapUsedBytes": 70898672,
"domNodes": 0,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 995.654,
"eventListeners": 182,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.022459893048133,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3039.873,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.13,
"layouts": 8,
"layoutDurationMs": 2.037,
"taskDurationMs": 767.498,
"heapDeltaBytes": 8120068,
"heapUsedBytes": 78662884,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 352.999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934067,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3085.5779999999413,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.856,
"layouts": 6,
"layoutDurationMs": 1.676,
"taskDurationMs": 769.5139999999999,
"heapDeltaBytes": -5110996,
"heapUsedBytes": 78485352,
"domNodes": -257,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 358.906,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757065217391304,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.847000000028,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.249000000000001,
"layouts": 7,
"layoutDurationMs": 2.0100000000000002,
"taskDurationMs": 649.867,
"heapDeltaBytes": -14429052,
"heapUsedBytes": 76718992,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 32.14300000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2062.1489999999767,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.719,
"layouts": 7,
"layoutDurationMs": 2.374,
"taskDurationMs": 672.6399999999999,
"heapDeltaBytes": -25836180,
"heapUsedBytes": 63929044,
"domNodes": -257,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 36.836,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2742.1429999999987,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.896,
"layouts": 5,
"layoutDurationMs": 1.434,
"taskDurationMs": 600.0519999999999,
"heapDeltaBytes": -10973708,
"heapUsedBytes": 71859004,
"domNodes": -240,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 191.21699999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66646341463414,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2695.681000000036,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.587,
"layouts": 1,
"layoutDurationMs": 0.29800000000000054,
"taskDurationMs": 546.8410000000001,
"heapDeltaBytes": 433144,
"heapUsedBytes": 61423868,
"domNodes": 19,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 196.413,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665432098765432,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3273.5079999999925,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.124,
"layouts": 4,
"layoutDurationMs": 0.9629999999999994,
"taskDurationMs": 952.366,
"heapDeltaBytes": -6666472,
"heapUsedBytes": 76431268,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 386.152,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3239.3619999999146,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.262,
"layouts": 4,
"layoutDurationMs": 1.2129999999999996,
"taskDurationMs": 945.342,
"heapDeltaBytes": 5709344,
"heapUsedBytes": 77708088,
"domNodes": -257,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 364.33500000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666494845360827,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.0139999999878,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.375999999999999,
"layouts": 9,
"layoutDurationMs": 2.6809999999999996,
"taskDurationMs": 458.065,
"heapDeltaBytes": 3319784,
"heapUsedBytes": 75545564,
"domNodes": 0,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 147.799,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.7700000000214,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.557,
"layouts": 9,
"layoutDurationMs": 2.934,
"taskDurationMs": 451.1499999999999,
"heapDeltaBytes": 673008,
"heapUsedBytes": 63480744,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 148.205,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669444444444455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.7039999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.910000000000001,
"layouts": 9,
"layoutDurationMs": 2.401,
"taskDurationMs": 525.424,
"heapDeltaBytes": 6085604,
"heapUsedBytes": 78034248,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 8.501999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.4039999999004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.496000000000001,
"layouts": 8,
"layoutDurationMs": 2.434,
"taskDurationMs": 553.9960000000001,
"heapDeltaBytes": -11588592,
"heapUsedBytes": 51159128,
"domNodes": -183,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.884,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.0249999999874,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.241999999999999,
"layouts": 9,
"layoutDurationMs": 2.599,
"taskDurationMs": 855.304,
"heapDeltaBytes": -4767436,
"heapUsedBytes": 68060608,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 110.66900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.725000000074,
"styleRecalcs": 79,
"styleRecalcDurationMs": 14.572999999999999,
"layouts": 10,
"layoutDurationMs": 2.8840000000000003,
"taskDurationMs": 872.995,
"heapDeltaBytes": 4927892,
"heapUsedBytes": 67062236,
"domNodes": -175,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 115.156,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1470.454000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 26.194999999999997,
"layouts": 5,
"layoutDurationMs": 14.284,
"taskDurationMs": 1120.2620000000002,
"heapDeltaBytes": 11698900,
"heapUsedBytes": 113196004,
"domNodes": 16030,
"jsHeapTotalBytes": 9834496,
"scriptDurationMs": 34.716,
"eventListeners": 3246,
"totalBlockingTimeMs": 164,
"frameDurationMs": 19.517105263157884,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9785.511999999982,
"styleRecalcs": 251,
"styleRecalcDurationMs": 29.877,
"layouts": 9,
"layoutDurationMs": 2.9139999999999997,
"taskDurationMs": 6077.1179999999995,
"heapDeltaBytes": -8782392,
"heapUsedBytes": 61301560,
"domNodes": -257,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 2736.0190000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665928449744463,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9655.42000000005,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.109,
"layouts": 8,
"layoutDurationMs": 2.1470000000000002,
"taskDurationMs": 6083.263,
"heapDeltaBytes": -28808768,
"heapUsedBytes": 62081104,
"domNodes": -257,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 2743.293,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66614853195164,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23082.787999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22459.882999999998,
"heapDeltaBytes": -29809512,
"heapUsedBytes": 252850192,
"domNodes": -3343,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 302.985,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.283420593368234,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 23093.725999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22513.774,
"heapDeltaBytes": 3487960,
"heapUsedBytes": 286009476,
"domNodes": -3343,
"jsHeapTotalBytes": 13094912,
"scriptDurationMs": 319.453,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.14330434782609,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 27776.044999999955,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.210999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27322.417,
"heapDeltaBytes": -9310188,
"heapUsedBytes": 286237296,
"domNodes": -3343,
"jsHeapTotalBytes": 15646720,
"scriptDurationMs": 891.4839999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 45,
"frameDurationMs": 50.20904159132007,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 27791.98299999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.253999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27406.113,
"heapDeltaBytes": -6223064,
"heapUsedBytes": 271109676,
"domNodes": -3343,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 885.205,
"eventListeners": -651,
"totalBlockingTimeMs": 49,
"frameDurationMs": 51.037798165137616,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8282.298999999966,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.28399999999996,
"layouts": 20,
"layoutDurationMs": 28.09199999999999,
"taskDurationMs": 8139.222,
"heapDeltaBytes": -20599420,
"heapUsedBytes": 271605828,
"domNodes": -3343,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 159.66599999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 18,
"frameDurationMs": 45.76243093922651,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 8323.262999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.42799999999998,
"layouts": 20,
"layoutDurationMs": 23.893999999999984,
"taskDurationMs": 8246.156,
"heapDeltaBytes": -9436896,
"heapUsedBytes": 273674412,
"domNodes": -3343,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 130.607,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.522285714285715,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11629.432000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11386.784,
"heapDeltaBytes": 36050036,
"heapUsedBytes": 283744136,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 157.03099999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.44965277777778,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11643.019999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11383.122999999998,
"heapDeltaBytes": -9374996,
"heapUsedBytes": 263197960,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 177.971,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.10565371024735,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 118.77199999992172,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.443999999999999,
"layouts": 8,
"layoutDurationMs": 3.8770000000000002,
"taskDurationMs": 94.336,
"heapDeltaBytes": 4791292,
"heapUsedBytes": 65702176,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.688999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 114.3090000000484,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.041,
"layouts": 8,
"layoutDurationMs": 3.42,
"taskDurationMs": 82.794,
"heapDeltaBytes": 4648644,
"heapUsedBytes": 66008276,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.889,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 485.47499999995125,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.617,
"layouts": 76,
"layoutDurationMs": 15.144,
"taskDurationMs": 433.624,
"heapDeltaBytes": -4353572,
"heapUsedBytes": 40568996,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 209.444,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 449.98999999995704,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.684,
"layouts": 76,
"layoutDurationMs": 15.148,
"taskDurationMs": 409.00600000000003,
"heapDeltaBytes": -4530932,
"heapUsedBytes": 38328176,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 192.62199999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 526.2830000000349,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.847,
"layouts": 76,
"layoutDurationMs": 13.937,
"taskDurationMs": 494.198,
"heapDeltaBytes": 72384,
"heapUsedBytes": 90970968,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 195.416,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 567.9649999999583,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.52,
"layouts": 76,
"layoutDurationMs": 14.458,
"taskDurationMs": 529.613,
"heapDeltaBytes": 1077172,
"heapUsedBytes": 90516872,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 206.759,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3100 passed, 0 failed · 8 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1a2e6b01c114f0cd905ad8372286653ebff58e92
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (199)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
9ff663d to
c2a10ec
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21948 +/- ##
==========================================
+ Coverage 86.62% 87.55% +0.93%
==========================================
Files 3937 2777 -1160
Lines 184596 154072 -30524
Branches 50159 41467 -8692
==========================================
- Hits 159899 134902 -24997
+ Misses 22234 18495 -3739
+ Partials 2463 675 -1788
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
c2a10ec to
d306ef7
Compare
| await expect(approval).toBeVisible() | ||
| await expect(agentPanel.root).toBeVisible() | ||
| await expect.poll(() => agentConsentReads.length).toBeGreaterThan(0) | ||
| await expect(page.getByTestId('agent-entry-separator')).toHaveCount(1) |
There was a problem hiding this comment.
Should this be in the page object?
Summary
Wait for the consent-backed Agent entry state before asserting that desktop approval is the only open dialog. This makes the coach deferral test observe consumed consent state instead of merely observing that its request started.
Stacked on #21928; test-only and nonblocking for the root review.
Verification
pnpm typecheck:browserpnpm exec oxfmt --check browser_tests/tests/agent/agentConsent.spec.ts--repeat-each=5 --workers=1: 5 passed