Repository navigation
test(agent): cover terminal approval expiry (BE-17612) - #21943
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Expired ask fixture and browser test browser_tests/fixtures/data/agent/agentAskFrames.ts, browser_tests/tests/agent/agentAskConsent.spec.ts |
Adds an askExpired fixture that creates an expired resolution frame with no selection. The test sends the frame and checks that the card and Run button disappear while the answer count stays at zero. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Possibly related issues
- Comfy-Org/ComfyUI_frontend#16460: The browser test covers an additional state in the Agent run-consent card flow.
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#20891: Both changes concern the
agent_ask_resolvedwire contract.
Suggested reviewers: drjkl, skishore23
Merge Risk: 
Low · up to ccf72
-
The expiry test may miss a delayed automatic answer request; strengthen the assertion barrier before merging.
Pre-merge checks: 
7
-
Full details: Title check
-
Explanation
The title names the change: test coverage for terminal approval expiry in the agent ask flow, with the ticket reference BE-17612. The changeset adds an askExpired fixture and a spec that checks the run-consent card and Run button disappear on an expired frame and that no answer is sent. The title is specific and matches the main change.
Full details: Description check
-
Explanation
The description follows the template. It has a Summary that explains the problem (a server-terminal agent_ask_resolved{expired} frame must remove the run-consent card and must not emit an answer request) and links the related backend PR and ticket. It has a Verification section that lists typecheck, format and lint commands, the targeted Playwright result (1 passed), and the full spec result (5 passed). It does not include a Fixes line or human QA notes, but those are optional under the template.
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes only files under
browser_tests/:agentAskFrames.tsandagentAskConsent.spec.ts. It adds Playwright coverage for terminal approval expiry and does not change application code undersrc/orpackages/. The check therefore does not identify a missing end-to-end test.
Full details: Website End-To-End Regression Coverage
-
Explanation
No changed file is under
apps/website/src/orapps/website/public/. The PR changes onlybrowser_tests/fixtures/data/agent/agentAskFrames.tsandbrowser_tests/tests/agent/agentAskConsent.spec.ts, so this website-specific check does not apply.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The PR changes only
browser_tests/fixtures/data/agent/agentAskFrames.tsandbrowser_tests/tests/agent/agentAskConsent.spec.ts. These paths are outsidesrc/lib/litegraph/,src/ecs/, and graph-entity files. The ADR compliance check is therefore not applicable.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
📦 Bundle: 11.9 MB gzip 🔴 +8 BDetailsSummary
Category Glance App Entry Points — 6.61 kB (baseline 6.61 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.62 MB (baseline 3.62 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 871 kB (baseline 871 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 33 unchanged User & Accounts — 152 kB (baseline 152 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 16 unchanged Editors & Dialogs — 513 kB (baseline 513 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 17 unchanged UI Components — 337 kB (baseline 337 kB) • ⚪ 0 BReusable component library chunks Status: 31 unchanged Data & Services — 1.84 MB (baseline 1.84 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed / 40 unchanged Utilities & Hooks — 1.33 MB (baseline 1.33 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 79 unchanged Vendor & Third-Party — 9.7 MB (baseline 9.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 15 unchanged Other — 34.6 MB (baseline 34.6 MB) • ⚪ 0 BBundles that do not match a named category
Status: 2 added / 2 removed / 746 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-25T16:26:55.195Z",
"gitSha": "2eee3ee46f2b241167383c6f2e672491c8a1c25f",
"branch": "christian/oploop-977h-be17612-e2e",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.6520000000073,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.8119999999999994,
"layouts": 11,
"layoutDurationMs": 3.1510000000000002,
"taskDurationMs": 554.144,
"heapDeltaBytes": 6018912,
"heapUsedBytes": 76983432,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 9.031,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.4819999999208,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0460000000000003,
"layouts": 9,
"layoutDurationMs": 2.668,
"taskDurationMs": 595.73,
"heapDeltaBytes": -975112,
"heapUsedBytes": 60300976,
"domNodes": -161,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 11.130999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.6970000000283,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.799999999999999,
"layouts": 9,
"layoutDurationMs": 2.713,
"taskDurationMs": 925.3530000000001,
"heapDeltaBytes": -14452900,
"heapUsedBytes": 55457936,
"domNodes": -161,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 165.177,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1923.26300000002,
"styleRecalcs": 79,
"styleRecalcDurationMs": 14.849,
"layouts": 9,
"layoutDurationMs": 2.5839999999999996,
"taskDurationMs": 980.192,
"heapDeltaBytes": 11385668,
"heapUsedBytes": 72331680,
"domNodes": -161,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 172.951,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66521739130435,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1696.3369999999713,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.176,
"layouts": 9,
"layoutDurationMs": 2.709,
"taskDurationMs": 392.039,
"heapDeltaBytes": 22077008,
"heapUsedBytes": 83100748,
"domNodes": 56,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.133000000000003,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1701.9090000000006,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.39,
"layouts": 9,
"layoutDurationMs": 3.1110000000000007,
"taskDurationMs": 485.89400000000006,
"heapDeltaBytes": 22881848,
"heapUsedBytes": 84054128,
"domNodes": 56,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 15.799000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 692.9339999999797,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.9179999999999997,
"layouts": 9,
"layoutDurationMs": 2.569,
"taskDurationMs": 507.83299999999997,
"heapDeltaBytes": 7281596,
"heapUsedBytes": 77763164,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 169.245,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 741.0089999999627,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.461,
"layouts": 10,
"layoutDurationMs": 3.146,
"taskDurationMs": 513.205,
"heapDeltaBytes": 7258976,
"heapUsedBytes": 76746276,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 172.497,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1154.9770000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 839.0350000000001,
"heapDeltaBytes": 18382096,
"heapUsedBytes": 83500388,
"domNodes": 0,
"jsHeapTotalBytes": 12484608,
"scriptDurationMs": 71.484,
"eventListeners": 0,
"totalBlockingTimeMs": 519,
"frameDurationMs": 33.823529411764696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1240.2999999999338,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 944.92,
"heapDeltaBytes": -3631600,
"heapUsedBytes": 74752516,
"domNodes": -191,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 69.1,
"eventListeners": -106,
"totalBlockingTimeMs": 552,
"frameDurationMs": 33.32972972972973,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 909.1679999999656,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.5560000000002,
"heapDeltaBytes": -5547848,
"heapUsedBytes": 76501192,
"domNodes": -191,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 159.08100000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 250,
"frameDurationMs": 25.71428571428574,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.1310000000612,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.75299999999953,
"heapDeltaBytes": -4778120,
"heapUsedBytes": 69769604,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.23399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10864.62800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9931.918,
"heapDeltaBytes": 489148,
"heapUsedBytes": 79193460,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7938.102000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1087,
"frameDurationMs": 31.405202312138726,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12128.706999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11261.539,
"heapDeltaBytes": 8372936,
"heapUsedBytes": 88951788,
"domNodes": -257,
"jsHeapTotalBytes": 18739200,
"scriptDurationMs": 9200.937999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 1699,
"frameDurationMs": 32.52761394101877,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10543.53899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9733.421,
"heapDeltaBytes": 90697400,
"heapUsedBytes": 170013288,
"domNodes": -257,
"jsHeapTotalBytes": 78245888,
"scriptDurationMs": 7813.575,
"eventListeners": -68,
"totalBlockingTimeMs": 868,
"frameDurationMs": 31.254896142433232,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10626.380999999981,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0419999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9847.052999999998,
"heapDeltaBytes": 2284148,
"heapUsedBytes": 91309728,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 7876.8460000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 1050,
"frameDurationMs": 31.041812865497075,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 230.1660000000254,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.222,
"layouts": 8,
"layoutDurationMs": 2.73,
"taskDurationMs": 173.052,
"heapDeltaBytes": 14599032,
"heapUsedBytes": 72593220,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.241,
"eventListeners": 205,
"totalBlockingTimeMs": 6,
"frameDurationMs": 24.077777777777808,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 287.1340000000373,
"styleRecalcs": 24,
"styleRecalcDurationMs": 20.266,
"layouts": 13,
"layoutDurationMs": 4.422000000000001,
"taskDurationMs": 256.85400000000004,
"heapDeltaBytes": -23174568,
"heapUsedBytes": 65754492,
"domNodes": -2315,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.912,
"eventListeners": -573,
"totalBlockingTimeMs": 63,
"frameDurationMs": 28.33000000000002,
"p95FrameDurationMs": 133.4000000000001
},
{
"name": "large-graph-idle",
"durationMs": 2056.8529999999896,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7790000000000004,
"layouts": 9,
"layoutDurationMs": 2.814,
"taskDurationMs": 645.933,
"heapDeltaBytes": -15217828,
"heapUsedBytes": 76834492,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 32.884,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.4780000000073,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7649999999999992,
"layouts": 8,
"layoutDurationMs": 2.236,
"taskDurationMs": 719.8029999999999,
"heapDeltaBytes": -691856,
"heapUsedBytes": 80748772,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 34.815000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2674.4990000000257,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.767000000000001,
"layouts": 7,
"layoutDurationMs": 1.731,
"taskDurationMs": 1772.271,
"heapDeltaBytes": -16341580,
"heapUsedBytes": 76278148,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 852.086,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77106918238994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2685.7949999999846,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.372,
"layouts": 8,
"layoutDurationMs": 2.3949999999999996,
"taskDurationMs": 1836.199,
"heapDeltaBytes": -6776920,
"heapUsedBytes": 86605888,
"domNodes": -257,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 871.537,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.769565217391303,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3833.1139999999664,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.086000000000002,
"layouts": 66,
"layoutDurationMs": 11.026,
"taskDurationMs": 1843.3590000000002,
"heapDeltaBytes": 8315896,
"heapUsedBytes": 79212920,
"domNodes": -233,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 807.1219999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593886462882,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4028.5290000000487,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.833,
"layouts": 64,
"layoutDurationMs": 11.164,
"taskDurationMs": 1979.5529999999997,
"heapDeltaBytes": -23801296,
"heapUsedBytes": 61297548,
"domNodes": -233,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 866.741,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2916.877999999997,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.236999999999999,
"layouts": 6,
"layoutDurationMs": 1.383,
"taskDurationMs": 1897.7839999999999,
"heapDeltaBytes": 16899760,
"heapUsedBytes": 88531600,
"domNodes": 0,
"jsHeapTotalBytes": 4612096,
"scriptDurationMs": 930.3589999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76206896551724,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3217.7689999999757,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.782000000000001,
"layouts": 5,
"layoutDurationMs": 1.6440000000000001,
"taskDurationMs": 2131.919,
"heapDeltaBytes": 4814536,
"heapUsedBytes": 77015964,
"domNodes": -257,
"jsHeapTotalBytes": 3690496,
"scriptDurationMs": 1022.2450000000001,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.841052631578947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3101.0849999999837,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6280000000000001,
"layouts": 6,
"layoutDurationMs": 1.8079999999999996,
"taskDurationMs": 816.104,
"heapDeltaBytes": -2533536,
"heapUsedBytes": 81232744,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 366.917,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3094.8379999999815,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8770000000000002,
"layouts": 6,
"layoutDurationMs": 1.663,
"taskDurationMs": 834.26,
"heapDeltaBytes": 4736136,
"heapUsedBytes": 76323328,
"domNodes": -257,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 378.152,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2044.3970000000036,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.344,
"layouts": 7,
"layoutDurationMs": 2.036,
"taskDurationMs": 652.532,
"heapDeltaBytes": -8463120,
"heapUsedBytes": 82096200,
"domNodes": -257,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 32.097,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2077.4450000000115,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.194000000000001,
"layouts": 7,
"layoutDurationMs": 2.545,
"taskDurationMs": 786.244,
"heapDeltaBytes": -26289240,
"heapUsedBytes": 63409456,
"domNodes": -257,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 41.503,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666400000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2782.4830000000134,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.459999999999999,
"layouts": 7,
"layoutDurationMs": 2.1870000000000003,
"taskDurationMs": 629.3849999999999,
"heapDeltaBytes": -9770112,
"heapUsedBytes": 72983836,
"domNodes": -240,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 190.069,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666467065868265,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2852.6769999999715,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.7,
"layouts": 6,
"layoutDurationMs": 1.8159999999999994,
"taskDurationMs": 661.1450000000001,
"heapDeltaBytes": -16996808,
"heapUsedBytes": 76395640,
"domNodes": -246,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 203.699,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608187134503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3305.022000000008,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8319999999999994,
"layouts": 6,
"layoutDurationMs": 1.5640000000000003,
"taskDurationMs": 960.3810000000001,
"heapDeltaBytes": -8398224,
"heapUsedBytes": 67849332,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 378.525,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.750761421319798,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3317.2779999999875,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0999999999999996,
"layouts": 7,
"layoutDurationMs": 2.1300000000000003,
"taskDurationMs": 1007.3369999999999,
"heapDeltaBytes": -3622320,
"heapUsedBytes": 79046572,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 392.61899999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66633165829146,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.4830000000265,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.328,
"layouts": 10,
"layoutDurationMs": 2.9459999999999997,
"taskDurationMs": 444.06,
"heapDeltaBytes": 3939928,
"heapUsedBytes": 76353008,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 144.14200000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 706.0789999999315,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.645999999999999,
"layouts": 10,
"layoutDurationMs": 2.776,
"taskDurationMs": 480.29200000000003,
"heapDeltaBytes": 3914220,
"heapUsedBytes": 75578344,
"domNodes": 0,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 151.40300000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666657,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.1590000000015,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.458,
"layouts": 10,
"layoutDurationMs": 3.1730000000000005,
"taskDurationMs": 568.1750000000001,
"heapDeltaBytes": 1189376,
"heapUsedBytes": 63497980,
"domNodes": -183,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 8.169,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2037.4749999999722,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6619999999999995,
"layouts": 8,
"layoutDurationMs": 2.273,
"taskDurationMs": 641.489,
"heapDeltaBytes": 12258472,
"heapUsedBytes": 74554108,
"domNodes": -183,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 12.701,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.932999999974,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.941,
"layouts": 9,
"layoutDurationMs": 2.418,
"taskDurationMs": 884.965,
"heapDeltaBytes": 6194116,
"heapUsedBytes": 67906500,
"domNodes": -175,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 111.979,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.3850000000893,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.312999999999999,
"layouts": 8,
"layoutDurationMs": 2.9759999999999995,
"taskDurationMs": 927.6940000000001,
"heapDeltaBytes": -8101116,
"heapUsedBytes": 54869676,
"domNodes": -175,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 117.038,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.956999999989,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.458999999999996,
"layouts": 5,
"layoutDurationMs": 16.732999999999997,
"taskDurationMs": 1159.7499999999998,
"heapDeltaBytes": 38474372,
"heapUsedBytes": 112819044,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 32.693,
"eventListeners": 3246,
"totalBlockingTimeMs": 182,
"frameDurationMs": 19.777333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9574.334999999963,
"styleRecalcs": 251,
"styleRecalcDurationMs": 29.139000000000003,
"layouts": 8,
"layoutDurationMs": 2.241,
"taskDurationMs": 6158.9980000000005,
"heapDeltaBytes": -29392240,
"heapUsedBytes": 62531224,
"domNodes": -257,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 2816.7459999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666027874564463,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10830.762999999934,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.883,
"layouts": 8,
"layoutDurationMs": 2.153,
"taskDurationMs": 6530.538,
"heapDeltaBytes": -18322760,
"heapUsedBytes": 73652668,
"domNodes": -257,
"jsHeapTotalBytes": 5599232,
"scriptDurationMs": 3012.65,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.691679506933745,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23077.732999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22417.935,
"heapDeltaBytes": -25979272,
"heapUsedBytes": 254996240,
"domNodes": -3343,
"jsHeapTotalBytes": 7327744,
"scriptDurationMs": 345.60699999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.32265758091994,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 23876.38000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23297.932000000004,
"heapDeltaBytes": -8883528,
"heapUsedBytes": 274155160,
"domNodes": -3343,
"jsHeapTotalBytes": 12308480,
"scriptDurationMs": 348.399,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.43350694444444,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 27791.917000000012,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.060999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27468.881,
"heapDeltaBytes": -11749344,
"heapUsedBytes": 264705892,
"domNodes": -3343,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 897.4770000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 24,
"frameDurationMs": 51.832276119402984,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28723.90400000006,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.294999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28413.070000000003,
"heapDeltaBytes": -52916796,
"heapUsedBytes": 249170712,
"domNodes": -3343,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 924.1049999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.90656660412759,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8138.422999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.21400000000003,
"layouts": 20,
"layoutDurationMs": 21.317000000000004,
"taskDurationMs": 8007.094999999999,
"heapDeltaBytes": 1011136,
"heapUsedBytes": 266948348,
"domNodes": -3343,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 120.97300000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.43519553072627,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8519.724999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.92900000000002,
"layouts": 20,
"layoutDurationMs": 23.99,
"taskDurationMs": 8402.559,
"heapDeltaBytes": -32704812,
"heapUsedBytes": 251629428,
"domNodes": -3343,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 134.04,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.20847457627117,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11375.264999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11150.027999999998,
"heapDeltaBytes": 13526188,
"heapUsedBytes": 288011004,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.72200000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.30602836879432,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11683.446000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11472.332999999999,
"heapDeltaBytes": 27553284,
"heapUsedBytes": 290835380,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 152.46699999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.694306049822075,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 487.2500000000173,
"styleRecalcs": 19,
"styleRecalcDurationMs": 12.063999999999998,
"layouts": 11,
"layoutDurationMs": 4.13,
"taskDurationMs": 133.245,
"heapDeltaBytes": 7147720,
"heapUsedBytes": 74612484,
"domNodes": 132,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.674000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 138.34799999995084,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.195,
"layouts": 10,
"layoutDurationMs": 3.679,
"taskDurationMs": 97.77299999999998,
"heapDeltaBytes": 4679080,
"heapUsedBytes": 73592648,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.32,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 481.8279999999504,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.623,
"layouts": 76,
"layoutDurationMs": 14.795000000000002,
"taskDurationMs": 440.413,
"heapDeltaBytes": -4240660,
"heapUsedBytes": 40736632,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 213.433,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 458.87900000002446,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.717,
"layouts": 76,
"layoutDurationMs": 14.415000000000001,
"taskDurationMs": 417.56000000000006,
"heapDeltaBytes": -4520036,
"heapUsedBytes": 39607380,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 196.742,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 528.4219999999777,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.251,
"layouts": 76,
"layoutDurationMs": 15.104,
"taskDurationMs": 497.324,
"heapDeltaBytes": 1043536,
"heapUsedBytes": 94806560,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 193.963,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.184375000000017,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 605.6959999999663,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.286,
"layouts": 76,
"layoutDurationMs": 15.633999999999999,
"taskDurationMs": 565.178,
"heapDeltaBytes": 1595444,
"heapUsedBytes": 91404708,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 223.635,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 60.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3105 passed, 0 failed · 4 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 48959e57feec6ecea208dcc0c7fc5ed5b49b6aca
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (194)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 1 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
Panel: 6/6 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21943 +/- ##
==========================================
+ Coverage 86.60% 87.54% +0.93%
==========================================
Files 3933 2774 -1159
Lines 184139 153823 -30316
Branches 47917 41412 -6505
==========================================
- Hits 159475 134661 -24814
+ Misses 22209 18487 -3722
+ Partials 2455 675 -1780
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit ccf72f7 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Summary
Adds black-box coverage for the user-visible half of BE-17612: a server-terminal
agent_ask_resolved{expired}frame removes the run-consent card and cannot emit an answer request. This accompanies the durable backend arbitration in cloud#16307.Verification
pnpm typecheck:browserpnpm exec oxfmt browser_tests/fixtures/data/agent/agentAskFrames.ts browser_tests/tests/agent/agentAskConsent.spec.tspnpm exec oxlint browser_tests/fixtures/data/agent/agentAskFrames.ts browser_tests/tests/agent/agentAskConsent.spec.tsagentAskConsent.spec.tscloud project: 5 passed after the documented cold-Vite first-run retry.