Repository navigation
[backport cloud/1.56] refactor(workflow): report user-initiated tab activations (#21791) - #21923
christian-byrne wants to merge 2 commits into
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T02:29:44.422Z",
"gitSha": "435b87283b82a51ed4951f0f856195a255445b58",
"branch": "backport-21791-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.4699999999602,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.255,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.56199999999995,
"heapDeltaBytes": 1025376,
"heapUsedBytes": 69188756,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.762999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.8289999998215,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.206000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.254,
"heapDeltaBytes": 637596,
"heapUsedBytes": 68789776,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.685999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.7470000000258,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.904,
"layouts": 12,
"layoutDurationMs": 4.912,
"taskDurationMs": 877.4389999999999,
"heapDeltaBytes": -2497084,
"heapUsedBytes": 65033588,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 177.749,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064217,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.2910000001775,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.398999999999997,
"layouts": 12,
"layoutDurationMs": 4.283,
"taskDurationMs": 808.9600000000002,
"heapDeltaBytes": 20562480,
"heapUsedBytes": 80933192,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.55800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665137614678898,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.413999999987,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.218,
"layouts": 6,
"layoutDurationMs": 1.2429999999999997,
"taskDurationMs": 372,
"heapDeltaBytes": 4131660,
"heapUsedBytes": 71061312,
"domNodes": 53,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.817999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.9230000000698,
"styleRecalcs": 29,
"styleRecalcDurationMs": 10.096,
"layouts": 6,
"layoutDurationMs": 1.28,
"taskDurationMs": 395.3789999999999,
"heapDeltaBytes": 4144000,
"heapUsedBytes": 71720152,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.589000000000006,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 731.2099999999191,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.569,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.918,
"heapDeltaBytes": -6378180,
"heapUsedBytes": 61096208,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 178.728,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 761.2589999998818,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.267,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.49399999999997,
"heapDeltaBytes": -6335836,
"heapUsedBytes": 60868432,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 178.96200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1218.5520000000452,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 911.6949999999999,
"heapDeltaBytes": 15224184,
"heapUsedBytes": 82696164,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 70.22200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 580,
"frameDurationMs": 35.785294117647084,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1225.2410000000964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 925.785,
"heapDeltaBytes": 15866680,
"heapUsedBytes": 84331420,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 74.354,
"eventListeners": 0,
"totalBlockingTimeMs": 578,
"frameDurationMs": 35.782352941176455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.107999999921,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.0969999999998,
"heapDeltaBytes": 17436620,
"heapUsedBytes": 103134496,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 176.504,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 894.8310000000674,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.5830000000003,
"heapDeltaBytes": 18177408,
"heapUsedBytes": 102918612,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 187.81599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10706.31400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9682.125000000002,
"heapDeltaBytes": 7030536,
"heapUsedBytes": 85219336,
"domNodes": -142,
"jsHeapTotalBytes": -7737344,
"scriptDurationMs": 7979.711,
"eventListeners": -82,
"totalBlockingTimeMs": 1391,
"frameDurationMs": 33.859493670886074,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10075.890000000072,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9185.149,
"heapDeltaBytes": 14850904,
"heapUsedBytes": 83380364,
"domNodes": -142,
"jsHeapTotalBytes": -12455936,
"scriptDurationMs": 7615.570999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 1058,
"frameDurationMs": 32.89640522875817,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10317.996999999992,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.0420000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9572.7,
"heapDeltaBytes": 15322788,
"heapUsedBytes": 92922376,
"domNodes": -172,
"jsHeapTotalBytes": -5378048,
"scriptDurationMs": 7924.021999999999,
"eventListeners": -82,
"totalBlockingTimeMs": 1224,
"frameDurationMs": 34.56275167785235,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9897.294999999986,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06600000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9056.701000000001,
"heapDeltaBytes": -8230812,
"heapUsedBytes": 68947652,
"domNodes": -143,
"jsHeapTotalBytes": -6164480,
"scriptDurationMs": 7446.836,
"eventListeners": -82,
"totalBlockingTimeMs": 1133,
"frameDurationMs": 33.33198653198653,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2025.7950000000164,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.239,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.6460000000001,
"heapDeltaBytes": -10147376,
"heapUsedBytes": 77821740,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.886,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.0740000001315,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.416999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.984,
"heapDeltaBytes": -10537680,
"heapUsedBytes": 76874276,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 47.06599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2614.2429999999877,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.355,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1659.0730000000003,
"heapDeltaBytes": -18043324,
"heapUsedBytes": 70228552,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 879.7109999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666242038216556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2551.196000000118,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.594,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1603.3840000000002,
"heapDeltaBytes": -18562460,
"heapUsedBytes": 69840288,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 859.082,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.775657894736838,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3821.5739999999414,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.645999999999999,
"layouts": 60,
"layoutDurationMs": 14.486000000000002,
"taskDurationMs": 1730.5830000000003,
"heapDeltaBytes": -17658456,
"heapUsedBytes": 68571184,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 811.4970000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665652173913045,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3770.5499999999574,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.259,
"layouts": 60,
"layoutDurationMs": 14.95,
"taskDurationMs": 1750.2769999999998,
"heapDeltaBytes": -20523496,
"heapUsedBytes": 70060500,
"domNodes": 24,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 814.996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666079295154184,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3134.12100000005,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.470999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1888.8760000000002,
"heapDeltaBytes": 18613500,
"heapUsedBytes": 100707528,
"domNodes": 0,
"jsHeapTotalBytes": 1241088,
"scriptDurationMs": 960.2410000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755913978494622,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3125.5949999999757,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.509999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1957.4180000000001,
"heapDeltaBytes": 8871292,
"heapUsedBytes": 77193100,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 1030.4759999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75483870967742,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.8959999999788,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.7809999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.6659999999999,
"heapDeltaBytes": -10087148,
"heapUsedBytes": 79364128,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.977999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.2759999998816,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.675000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.17,
"heapDeltaBytes": -9569896,
"heapUsedBytes": 79175940,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 37.33599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.1200000000335,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.274,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.90500000000003,
"heapDeltaBytes": -11879680,
"heapUsedBytes": 57860608,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 140.02599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 684.0150000000449,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.062000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.245,
"heapDeltaBytes": 10478048,
"heapUsedBytes": 74378196,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 163.23700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.9800000000796,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.254999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.48199999999997,
"heapDeltaBytes": -2554924,
"heapUsedBytes": 61166020,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.525,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.6950000001361,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.307999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.1389999999999,
"heapDeltaBytes": -2556896,
"heapUsedBytes": 61211792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.422999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.0260000000608,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.173999999999996,
"layouts": 16,
"layoutDurationMs": 5.842,
"taskDurationMs": 813.334,
"heapDeltaBytes": -5887940,
"heapUsedBytes": 63626360,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 121.159,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1792.0110000000022,
"styleRecalcs": 59,
"styleRecalcDurationMs": 19.093,
"layouts": 16,
"layoutDurationMs": 6.330000000000001,
"taskDurationMs": 943.732,
"heapDeltaBytes": -5858352,
"heapUsedBytes": 62802796,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 132.494,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.6009999998296,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.477000000000004,
"layouts": 5,
"layoutDurationMs": 15.113999999999999,
"taskDurationMs": 998.7130000000002,
"heapDeltaBytes": -627652,
"heapUsedBytes": 92619088,
"domNodes": 14227,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 32.576,
"eventListeners": 2463,
"totalBlockingTimeMs": 139,
"frameDurationMs": 19.368918918918922,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9213.469000000032,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.089999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5826.965,
"heapDeltaBytes": -7787804,
"heapUsedBytes": 79997120,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2848.2830000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696188747731398,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9134.64399999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.782,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5859.317,
"heapDeltaBytes": -16479332,
"heapUsedBytes": 70439788,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2835.15,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6963436928702,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17929.830000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17224.110000000004,
"heapDeltaBytes": -48347100,
"heapUsedBytes": 179445940,
"domNodes": -3045,
"jsHeapTotalBytes": 6459392,
"scriptDurationMs": 270.01200000000006,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.601706484641635,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 18341.447000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17442.605,
"heapDeltaBytes": -41737372,
"heapUsedBytes": 179896648,
"domNodes": -3045,
"jsHeapTotalBytes": 1679360,
"scriptDurationMs": 282.483,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.68840830449827,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21973.891999999978,
"styleRecalcs": 172,
"styleRecalcDurationMs": 21.542000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21639.102,
"heapDeltaBytes": -50495564,
"heapUsedBytes": 166437552,
"domNodes": -3045,
"jsHeapTotalBytes": 6901760,
"scriptDurationMs": 874.957,
"eventListeners": -14915,
"totalBlockingTimeMs": 37,
"frameDurationMs": 40.75287569573283,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 22489.31700000003,
"styleRecalcs": 173,
"styleRecalcDurationMs": 23.141999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22154.539,
"heapDeltaBytes": -45621480,
"heapUsedBytes": 166881188,
"domNodes": -3045,
"jsHeapTotalBytes": 7163904,
"scriptDurationMs": 920.18,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.37118644067797,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6516.816999999946,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.14700000000002,
"layouts": 20,
"layoutDurationMs": 24.32999999999999,
"taskDurationMs": 6413,
"heapDeltaBytes": -1228228,
"heapUsedBytes": 213416572,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 110.905,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.236571428571416,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6681.753000000072,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.76699999999998,
"layouts": 20,
"layoutDurationMs": 26.826000000000004,
"taskDurationMs": 6582.882,
"heapDeltaBytes": 1041960,
"heapUsedBytes": 214151876,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 117.47,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.31176470588236,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9309.20100000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8891.364000000001,
"heapDeltaBytes": -36188924,
"heapUsedBytes": 180195464,
"domNodes": -3045,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 144.17799999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.23633217993079,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9346.069999999827,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8942.929999999998,
"heapDeltaBytes": -27881744,
"heapUsedBytes": 187600720,
"domNodes": -3045,
"jsHeapTotalBytes": 5148672,
"scriptDurationMs": 189.96599999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 2,
"frameDurationMs": 33.272953736654806,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 491.4130000001933,
"styleRecalcs": 21,
"styleRecalcDurationMs": 23.325000000000003,
"layouts": 5,
"layoutDurationMs": 2.4019999999999997,
"taskDurationMs": 154.18599999999998,
"heapDeltaBytes": 6022940,
"heapUsedBytes": 72148424,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.39699999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 121.33399999993344,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.905000000000003,
"layouts": 3,
"layoutDurationMs": 1.5730000000000002,
"taskDurationMs": 85.38900000000002,
"heapDeltaBytes": 3640436,
"heapUsedBytes": 69113436,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.582000000000004,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428674,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1022.8010000000722,
"styleRecalcs": 78,
"styleRecalcDurationMs": 110.857,
"layouts": 76,
"layoutDurationMs": 28.264,
"taskDurationMs": 999.1600000000001,
"heapDeltaBytes": 19339104,
"heapUsedBytes": 88394768,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 414.144,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1091.9710000000578,
"styleRecalcs": 78,
"styleRecalcDurationMs": 115.203,
"layouts": 76,
"layoutDurationMs": 29.38,
"taskDurationMs": 1064.5,
"heapDeltaBytes": 19382592,
"heapUsedBytes": 88568896,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 451.67600000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.46031746031746,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1468.7579999999798,
"styleRecalcs": 78,
"styleRecalcDurationMs": 268.142,
"layouts": 76,
"layoutDurationMs": 30.085,
"taskDurationMs": 1447.886,
"heapDeltaBytes": -19107028,
"heapUsedBytes": 108592892,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 489.471,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.564556962025296,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1454.385000000002,
"styleRecalcs": 78,
"styleRecalcDurationMs": 268.928,
"layouts": 76,
"layoutDurationMs": 29.082,
"taskDurationMs": 1426.031,
"heapDeltaBytes": 8526072,
"heapUsedBytes": 115402868,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 471.23900000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.35316455696202,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2204 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (20 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 674a5024ac5fbaf5222fa81bec64e02344dca5c8
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.56 #21923 +/- ##
=============================================
Coverage ? 83.17%
=============================================
Files ? 2399
Lines ? 128100
Branches ? 39168
=============================================
Hits ? 106544
Misses ? 21145
Partials ? 411
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Closing: the 1.56 release line is finished and won't get another patch. |
…) with its CNV06 fix (#22792) (#22865) Backport of workflow chat-follow (#21791 + #21512) to `core/1.58`, **together with the FRONT-3804 fix (#22792)** for the regression chat-follow introduced (agent edits to a background tab only appeared after a reload, frontend 1.60 QA check CNV06). Shipping one without the other would put that regression on the stable line, so this PR carries the whole chain. Decision (2026-11-05): take option 2 from the earlier draft, the full stack, because ComfyUI now pins 1.58.5, so `core/1.58` is the line Core and Desktop users get, and the release owner asked for the backport. The stack turned out smaller than estimated: #21686 is not needed (see below). ## Why `core/1.58` and not the lines the original ask named The ask was "backport chat-follow to 1.58/1.59 so cloud and desktop users get it". Measured against branch ancestry and the live distribution surfaces on 2026-11-03: | Surface | What serves it | Chat-follow (#21791 + #21512) | |---|---|---| | Cloud production | `cloud/1.59` (`frontend-version.json` `releaseBranch`, rotated 2026-10-31); serves commit `072c3c1140` | **already present**, but that commit predates the CNV06 fix (#22813) | | Cloud testcloud | `cloud/1.60` (`testcloudBranch`, rotated 2026-11-03) | **already present** | | Core / Desktop pin | `core/1.58`: `ComfyUI` master pins `comfyui-frontend-package==1.58.5` since Comfy-Org/ComfyUI#17442 merged 2026-11-04 | absent before this PR | | `core/1.59`, `core/1.60` | tagged `v1.59.0` / `v1.60.0` on GitHub; PyPI has only `.dev` builds of these lines, and ComfyUI does not pin them | already present | So **cloud users already have chat-follow**; the gap is Core/Desktop only. `core/1.58` is the line chosen here because it is the newest stable package line and the one the open `ComfyUI` pin bump targets. Retired lines were excluded on the release owner's own stated grounds: `thedatalife` closed #21922/#21923 with "the 1.56 release line is finished and won't get another patch" and #21921 with "cloud.comfy.org now serves cloud/1.58, so cloud/1.57 won't be redeployed" — by the same rule `cloud/1.58` is now superseded by `cloud/1.59`. ## What is carried, in dependency order All four are `cherry-pick -x` from `main`, original authorship preserved. 1. **#20827** — `fix(agent): load every page of Chat history` (41 files, +1197/−434). Required: `core/1.58` forked from `main` on 2026-10-19 and lacks `useAgentChatHistoryRefresh`, `agentThreadList` and the paged `/api/agent/threads?*` client that #21512 modifies. Three conflicts, all incidental: two spec files took the landed `core/1.59` content for the files whose only 1.58→1.59 delta is this PR, and one import union in `agentRestClient.test.ts` aligned to the `@/workbench/...` form 1.59 uses. 2. **#21147** — `fix(agent-crdt): bind the session to the workflow a reload restored (FE-1969)` (9 files, +688/−36). Required: #21512 calls `onWorkflowRestoredAndBound`, and `hasUnsyncedHumanOps` is the guard the follow bind reuses. One conflict, a declaration-order union in `useAgentWorkflowSelection.ts` resolved to the order `core/1.59` landed. 3. **#21791** — `refactor(workflow): report user-initiated tab activations` (17 files, +473/−84, byte-identical stat to `main`). One conflict: `openWorkflow`'s options object, where 1.58 has `keepSavedBaseline` and this PR adds `initiator`. Both kept. 4. **#21512** — `feat(agent): carry workflow chat follow onto current main` (49 files). Seven conflicts; each resolution is stated below. ### #21512 conflict resolutions - `agentConversationStore.ts` (5) — 1.58 carries the snapshot-turn work (`unreconciledSnapshotTurns`, `snapshotTurnSettled`, `publishSnapshotMessage`) that `main` has since renamed. Declarations and the exported surface are unions in `core/1.59`'s order; `replacedSlot` is adopted alongside `unreconciledSnapshotTurns.clear()`; and the transport publish callback **keeps 1.58's `publishSnapshotMessage`**, which does `replaceActive` *plus* announcing a reconcilable snapshot turn, rather than narrowing to `publishMessage`. - `useAgentSession.ts` (1) — took #21512's `openThread`/`outlivedItsNavigation` rewrite with `boundWorkflowId.value = null; rememberedWorkflowId = null` replaced by 1.58's `forgetBinding()` helper (from #22518/#22697). The result is byte-identical to `core/1.59`'s `loadThread`. - `AgentPanelRoot.vue` (2) — import superset, and the `custom-title` fallback through `historyGroups.current`. - `RunNoticeBanner.vue` (2) — **narrow adaptation.** Added the `followFailed` context and the `liveness`/`contextAction` computeds, but **not** `genericNoticeReady` or the `visible` computed: those belong to a different PR that is not on this train, and 1.58's template already gates on `context || !dismissed`. Nothing chat-follow needs is dropped. - `AgentPanel.ts` fixture (2) — added only `historyButton`; `loadFailedMessage`/`loadRetryButton` appeared in the conflict as context from a PR not on this train and are unused here, so they are not introduced. `userMessageBubbles` **was** added (same reason, but the carried specs do use it). - `agentConversationFixture.ts` (1) — took the canvas-relative `canvasOps.click`; `comfyPage.canvas` and `comfyPage.canvasOps` both exist on this train. - `AgentPanelRoot.tabActivity.test.ts` — **path adaptation only.** 1.58 predates the billing module move: `@/platform/billing/composables/useBillingCapabilities` → `@/platform/workspace/composables/useBillingCapabilities`, `@/platform/billing/composables/useBillingContext` → `@/composables/billing/useBillingContext`, `@/platform/billing/subscription/composables/useAccountPreconditionDialog` → `@/platform/cloud/subscription/composables/useAccountPreconditionDialog`. Same three modules `AgentPanelRoot.vue` already imports on this branch. - Seven assertions in `AgentPanelRoot.test.ts` and `useAgentWorkflowSelection.test.ts` were updated to the behaviour the carried commits define, matching `core/1.59` exactly: four `expect(await restoration).toBe(true)` sites became `WorkflowRestoration`-shaped (#21147 changed that return type), and three chat-title tests now expect the server-assigned title (`'build a duck'`, `'my masterpiece'`) rather than `agent.newChatTitle`, which is #21512's own PM-2098 change. These are #21512's and #21147's own test updates; they failed to apply because the surrounding file differs on this train. ### Added on 2026-11-05: the FRONT-3804 chain 5. **#21497** `test: pin agent wire identity across a /ws reconnect` (test harness only). One conflict in `agentFollowerHostSocket.ts`: took #21497's per-connection `sid` and doc comment; 1.58 already had the `comfyConnections` counter from its PM-2123 backport. 6. **#21964** `test(agent): prove a document reset keeps other workflows' mint cursors` (test harness only). Applied clean. 7. **#22596** `fix(agent-crdt): track unconfirmed bind targets as unsynced (FRONT-3581)`. Three conflicts, all from `retrySubscription` and the dynamic-combo test scenario, neither on this train: added only `noteUnboundLocalIntent` to the follower surface; kept 1.58's `workflowByUnsettledOpId` settle bookkeeping and renamed `workflowsWithLostOps` to `workflowsWithUnsyncedOps` as #22596 does; in `docOpMinter.test.ts` added only the `unboundLocalIntents` counter. The new tests do not use the dynamic-combo scenario, so **#21686 is not carried**. 8. **#22792** `fix(agent): bind the workflow a followed chat opens (FRONT-3804)`. One conflict (`retrySubscription` again, dropped). `AgentPanelRoot.vue`, `docOpMinter.ts`, the fixture and the new spec applied clean. 9. `test(agent): import the workflow schema from its core/1.58 path`: the new fixture imported `@comfyorg/graph-model/workflowSchema`, a package 1.58 predates; it now uses `@/platform/workflow/validation/schemas/workflowSchema` like the other 1.58 fixtures. 10. **Rebased 2026-11-05 onto `core/1.58` after #22943** (empty composer on New Chat / draft across refresh). Two conflicts, both resolved to `main`'s and `core/1.59`'s shape: `onNewChat` keeps `retireFollow()` first and then the `history_back` branch, and `agentComposerStore.test.ts` keeps both the "draft presence" and "draft persistence" blocks in `main`'s order. One follow-up commit drops a duplicate `hasDraft` key in the composer store's returned object (both PRs added it; `main` has one). ## Verification - Before the rebase, at `928aaa2bc7`: `pnpm typecheck` and `pnpm typecheck:browser` pass (Node 26). - Vitest, 701 tests in 7 files, all pass: `AgentPanelRoot`, `docOpMinter`, `unsyncedHumanOps`, `followerProductGate`, `crossWorkflowPending`, `agentFollowerHostSocket`, `useAgentWorkflowChatFollow`. - The earlier four commits' 1945-test focused run (27 files) passed at `c10dbfe073`, before the chain was added. - Black-box: `browser_tests/tests/agent/agentBackgroundTabEditsLand.spec.ts` (CNV06 step 5) plus the chat-follow specs `agentTabActivationFollowsChat` and `agentTabChatTransitions` run in this PR's `@cloud` e2e shards. On `main` the CNV06 spec was red at the regressing commit 1a6324c and green with #22792 (see #22792). ## Delivery - **Core / Desktop:** the 1.58.6 release PR (#22908) is open on `core/1.58`. This PR merges first so 1.58.6 carries it; Core and Desktop get it when ComfyUI's pin moves to 1.58.6. - **Cloud:** chat-follow is already on `cloud/1.59` and `cloud/1.60`. The CNV06 fix is merged on both (#22813, #22806) but cloud production still serves `072c3c1140`, which predates it. The open production canary (Comfy-Org/cloud#17917) starts from a `cloud/1.59` tip that includes #22813. Testcloud builds `cloud/1.60` on every push, so it already carries #22806. Known limit, unchanged by this PR: an edit made by hand while a tab is not bound keeps that tab's follow bind refused until a reload plus a turn (the #22596 marker lifecycle). The owner decision is recorded on #22792; the in-session recovery design is #22801. --------- Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: christian-byrne <chrbyrne96@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com>
Manual recovery for the conflicted automated backport of #21791.
Preserves the release branch’s direct workflow-service wiring while porting the user-activation behavior and review fixes. The source-only overflow-menu test was omitted because this release line uses an older PrimeVue command harness; the behavior is covered by the focused workflow/tab/navigation suite.
Validation:
pnpm typecheck:appPre-push note: the release branch’s existing Knip gate reports its pre-existing missing
vitest.console.setup.tsimport fromvite.electron.config.mts; this change does not touch either path.