Repository navigation
[backport core/1.56] refactor(workflow): report user-initiated tab activations (#21791) - #21922
christian-byrne wants to merge 2 commits into
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T02:29:21.307Z",
"gitSha": "78630fc7bb7a18eb6a9ab3abe0182ef5ad6d3559",
"branch": "backport-21791-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2012.9360000000247,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.329,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.56300000000005,
"heapDeltaBytes": 923664,
"heapUsedBytes": 68730588,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.049999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.988999999986,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.678000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.95,
"heapDeltaBytes": 887836,
"heapUsedBytes": 68856388,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.615999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.9029999999866,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.331,
"layouts": 12,
"layoutDurationMs": 4.986,
"taskDurationMs": 811.397,
"heapDeltaBytes": -2056284,
"heapUsedBytes": 66404692,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 165.50400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.641999999999,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.864,
"layouts": 12,
"layoutDurationMs": 4.484,
"taskDurationMs": 785.133,
"heapDeltaBytes": -1760720,
"heapUsedBytes": 66032684,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 166.367,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.7449999999553,
"styleRecalcs": 30,
"styleRecalcDurationMs": 8.966999999999999,
"layouts": 6,
"layoutDurationMs": 1.314,
"taskDurationMs": 343.453,
"heapDeltaBytes": 4112348,
"heapUsedBytes": 71660504,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.350000000000007,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7269999999635,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.737,
"layouts": 6,
"layoutDurationMs": 1.152,
"taskDurationMs": 339.938,
"heapDeltaBytes": 4123712,
"heapUsedBytes": 72599496,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.948999999999993,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 696.8180000000075,
"styleRecalcs": 15,
"styleRecalcDurationMs": 5.554999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.23300000000006,
"heapDeltaBytes": -6386380,
"heapUsedBytes": 61286476,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 165.412,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 721.023999999943,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.4680000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.639,
"heapDeltaBytes": -7126932,
"heapUsedBytes": 61461692,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 170.39100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1147.1769999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 817.2,
"heapDeltaBytes": 15133500,
"heapUsedBytes": 84883032,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 67.333,
"eventListeners": 0,
"totalBlockingTimeMs": 531,
"frameDurationMs": 34.84545454545454,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1149.4480000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.73,
"heapDeltaBytes": 15141948,
"heapUsedBytes": 84358292,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 63.69799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 519,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.9770000000156,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.4289999999999,
"heapDeltaBytes": 17596048,
"heapUsedBytes": 105355048,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 176.60900000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 25.234285714285683,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.5829999999532,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.54200000000003,
"heapDeltaBytes": 17815964,
"heapUsedBytes": 104942344,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 162.46999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9102.462000000003,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.51,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8329.82,
"heapDeltaBytes": -4177984,
"heapUsedBytes": 79918920,
"domNodes": -142,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 7084.857999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 1080,
"frameDurationMs": 36.25378486055777,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9355.613000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8657.983999999999,
"heapDeltaBytes": -14981532,
"heapUsedBytes": 69677756,
"domNodes": -142,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 7153.01,
"eventListeners": -78,
"totalBlockingTimeMs": 917,
"frameDurationMs": 33.39142857142857,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9239.287000000018,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4349999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8597.716999999999,
"heapDeltaBytes": 7649596,
"heapUsedBytes": 85596260,
"domNodes": -142,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 7065.541,
"eventListeners": -74,
"totalBlockingTimeMs": 812,
"frameDurationMs": 33.57454545454546,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8834.760999999959,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9630000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8236.2,
"heapDeltaBytes": 15412292,
"heapUsedBytes": 93490700,
"domNodes": -142,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 6759.169,
"eventListeners": -74,
"totalBlockingTimeMs": 659,
"frameDurationMs": 33.33207547169811,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2016.2750000000074,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0610000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.708,
"heapDeltaBytes": -10062212,
"heapUsedBytes": 78587160,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 30.87200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.2999999999965,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.602000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.4409999999999,
"heapDeltaBytes": -11227268,
"heapUsedBytes": 67469632,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.62199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2342.529000000013,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1561.197,
"heapDeltaBytes": -18983112,
"heapUsedBytes": 70682260,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 835.121,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.785611510791366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2497.4090000000615,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.269,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1597.057,
"heapDeltaBytes": -18615720,
"heapUsedBytes": 71071500,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 876.4350000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777852348993292,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3621.8549999999823,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.165,
"layouts": 60,
"layoutDurationMs": 14.754999999999999,
"taskDurationMs": 1658.4200000000003,
"heapDeltaBytes": 1570576,
"heapUsedBytes": 69323096,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 803.8240000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665596330275232,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3648.8339999999653,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.387,
"layouts": 60,
"layoutDurationMs": 14.166000000000002,
"taskDurationMs": 1629.21,
"heapDeltaBytes": 1248640,
"heapUsedBytes": 70348640,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 790.13,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662100456621,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3137.2269999999958,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.092,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1904.7709999999997,
"heapDeltaBytes": 7927452,
"heapUsedBytes": 77123816,
"domNodes": 0,
"jsHeapTotalBytes": 1241088,
"scriptDurationMs": 1029.026,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755913978494625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3127.029000000107,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.3199999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1882.043,
"heapDeltaBytes": 4485652,
"heapUsedBytes": 73668760,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 999.4439999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755376344086017,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.5540000000228,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.5190000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.58900000000006,
"heapDeltaBytes": -9234180,
"heapUsedBytes": 80154280,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.144999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.9430000000875,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5120000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.7130000000001,
"heapDeltaBytes": -9120640,
"heapUsedBytes": 80546008,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.64,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.9680000000194,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.103999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.463,
"heapDeltaBytes": -11647732,
"heapUsedBytes": 58401068,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 147.60600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.7659999999514,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.098999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.44800000000004,
"heapDeltaBytes": -11926692,
"heapUsedBytes": 58098936,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 146.969,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.1999999999975,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8510000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.13100000000003,
"heapDeltaBytes": 1368800,
"heapUsedBytes": 72451944,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.407,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.4129999999814,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.069999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.029,
"heapDeltaBytes": 1449220,
"heapUsedBytes": 71562796,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.8640000000000025,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.6279999999897,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.183999999999997,
"layouts": 16,
"layoutDurationMs": 5.276000000000001,
"taskDurationMs": 725.4739999999999,
"heapDeltaBytes": 17350800,
"heapUsedBytes": 81264216,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.629,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.4480000000995,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.055000000000003,
"layouts": 16,
"layoutDurationMs": 5.411,
"taskDurationMs": 734.386,
"heapDeltaBytes": 17304948,
"heapUsedBytes": 80400016,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.99100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.9309999999946,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.912000000000003,
"layouts": 5,
"layoutDurationMs": 14.829999999999997,
"taskDurationMs": 929.667,
"heapDeltaBytes": 2976172,
"heapUsedBytes": 98339744,
"domNodes": 14227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.819000000000003,
"eventListeners": 2463,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.44305555555555,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8381.501000000015,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.624,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5435.58,
"heapDeltaBytes": -17684348,
"heapUsedBytes": 70553552,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2714.5969999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699402390438248,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8476.287999999953,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.578,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5483.639,
"heapDeltaBytes": -17955908,
"heapUsedBytes": 70327000,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2775.7110000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698818897637796,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17529.939000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16679.396999999997,
"heapDeltaBytes": -19404748,
"heapUsedBytes": 179709472,
"domNodes": -3045,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 263.406,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.29096989966555,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 17988.395000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17115.4,
"heapDeltaBytes": -43695220,
"heapUsedBytes": 179269340,
"domNodes": -3045,
"jsHeapTotalBytes": 368640,
"scriptDurationMs": 274.791,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.99315525876461,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 22844.36199999999,
"styleRecalcs": 182,
"styleRecalcDurationMs": 21.02900000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22422.49,
"heapDeltaBytes": -18689384,
"heapUsedBytes": 197757128,
"domNodes": -3045,
"jsHeapTotalBytes": 6221824,
"scriptDurationMs": 961.407,
"eventListeners": -14915,
"totalBlockingTimeMs": 7,
"frameDurationMs": 41.80201096892139,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 21903.91299999999,
"styleRecalcs": 173,
"styleRecalcDurationMs": 18.721000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21472.344,
"heapDeltaBytes": -29177120,
"heapUsedBytes": 184083336,
"domNodes": -3045,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 923.658,
"eventListeners": -14915,
"totalBlockingTimeMs": 12,
"frameDurationMs": 38.86749555950267,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6559.089999999969,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.735,
"layouts": 20,
"layoutDurationMs": 24.054000000000006,
"taskDurationMs": 6391.849,
"heapDeltaBytes": -52760,
"heapUsedBytes": 216392352,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 115.658,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.98736263736263,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6313.9549999999645,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.07999999999998,
"layouts": 20,
"layoutDurationMs": 24.028999999999996,
"taskDurationMs": 6246.6050000000005,
"heapDeltaBytes": 1195308,
"heapUsedBytes": 222798040,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 109.313,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.95,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8903.124000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8605.655999999999,
"heapDeltaBytes": -42902708,
"heapUsedBytes": 179377272,
"domNodes": -3045,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 132.919,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.168135593220345,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8692.414999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8409.852,
"heapDeltaBytes": -34735720,
"heapUsedBytes": 179960336,
"domNodes": -3045,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 133.565,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.433898305084746,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 496.4390000000094,
"styleRecalcs": 19,
"styleRecalcDurationMs": 16.488000000000003,
"layouts": 3,
"layoutDurationMs": 1.6219999999999999,
"taskDurationMs": 134.322,
"heapDeltaBytes": 5959188,
"heapUsedBytes": 71689148,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.891,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.257142857142885,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 127.08999999995285,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.248000000000001,
"layouts": 3,
"layoutDurationMs": 1.3430000000000002,
"taskDurationMs": 85.31800000000003,
"heapDeltaBytes": 3728752,
"heapUsedBytes": 69276708,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.559000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 934.8110000000815,
"styleRecalcs": 78,
"styleRecalcDurationMs": 104.797,
"layouts": 76,
"layoutDurationMs": 26.342000000000002,
"taskDurationMs": 904.763,
"heapDeltaBytes": 18592116,
"heapUsedBytes": 86044208,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 373.614,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 886.3999999999805,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.397,
"layouts": 76,
"layoutDurationMs": 25.869,
"taskDurationMs": 853.745,
"heapDeltaBytes": 18004704,
"heapUsedBytes": 83800844,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 349.519,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66792452830188,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1397.8930000000673,
"styleRecalcs": 78,
"styleRecalcDurationMs": 260.37100000000004,
"layouts": 76,
"layoutDurationMs": 29.21,
"taskDurationMs": 1365.61,
"heapDeltaBytes": -18947508,
"heapUsedBytes": 110561980,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 450.356,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.93291139240505,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1444.1870000000563,
"styleRecalcs": 78,
"styleRecalcDurationMs": 272.318,
"layouts": 76,
"layoutDurationMs": 32.114999999999995,
"taskDurationMs": 1416.963,
"heapDeltaBytes": 8850176,
"heapUsedBytes": 115313476,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 464.418,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.901234567901234,
"p95FrameDurationMs": 33.19999999999891
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2207 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (20 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8b3a1d6937013b6462b1f3d5c5cc842f996996ce
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.56 #21922 +/- ##
============================================
Coverage 82.79% 82.79%
============================================
Files 2691 2691
Lines 152058 152092 +34
Branches 36654 38710 +2056
============================================
+ Hits 125892 125922 +30
- Misses 25781 25785 +4
Partials 385 385
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Closing: the 1.56 release line is finished and won't get another patch. |
Pull request was closed
…) with its CNV06 fix (#22792) (#22865) Backport of workflow chat-follow (#21791 + #21512) to `core/1.58`, **together with the FRONT-3804 fix (#22792)** for the regression chat-follow introduced (agent edits to a background tab only appeared after a reload, frontend 1.60 QA check CNV06). Shipping one without the other would put that regression on the stable line, so this PR carries the whole chain. Decision (2026-11-05): take option 2 from the earlier draft, the full stack, because ComfyUI now pins 1.58.5, so `core/1.58` is the line Core and Desktop users get, and the release owner asked for the backport. The stack turned out smaller than estimated: #21686 is not needed (see below). ## Why `core/1.58` and not the lines the original ask named The ask was "backport chat-follow to 1.58/1.59 so cloud and desktop users get it". Measured against branch ancestry and the live distribution surfaces on 2026-11-03: | Surface | What serves it | Chat-follow (#21791 + #21512) | |---|---|---| | Cloud production | `cloud/1.59` (`frontend-version.json` `releaseBranch`, rotated 2026-10-31); serves commit `072c3c1140` | **already present**, but that commit predates the CNV06 fix (#22813) | | Cloud testcloud | `cloud/1.60` (`testcloudBranch`, rotated 2026-11-03) | **already present** | | Core / Desktop pin | `core/1.58`: `ComfyUI` master pins `comfyui-frontend-package==1.58.5` since Comfy-Org/ComfyUI#17442 merged 2026-11-04 | absent before this PR | | `core/1.59`, `core/1.60` | tagged `v1.59.0` / `v1.60.0` on GitHub; PyPI has only `.dev` builds of these lines, and ComfyUI does not pin them | already present | So **cloud users already have chat-follow**; the gap is Core/Desktop only. `core/1.58` is the line chosen here because it is the newest stable package line and the one the open `ComfyUI` pin bump targets. Retired lines were excluded on the release owner's own stated grounds: `thedatalife` closed #21922/#21923 with "the 1.56 release line is finished and won't get another patch" and #21921 with "cloud.comfy.org now serves cloud/1.58, so cloud/1.57 won't be redeployed" — by the same rule `cloud/1.58` is now superseded by `cloud/1.59`. ## What is carried, in dependency order All four are `cherry-pick -x` from `main`, original authorship preserved. 1. **#20827** — `fix(agent): load every page of Chat history` (41 files, +1197/−434). Required: `core/1.58` forked from `main` on 2026-10-19 and lacks `useAgentChatHistoryRefresh`, `agentThreadList` and the paged `/api/agent/threads?*` client that #21512 modifies. Three conflicts, all incidental: two spec files took the landed `core/1.59` content for the files whose only 1.58→1.59 delta is this PR, and one import union in `agentRestClient.test.ts` aligned to the `@/workbench/...` form 1.59 uses. 2. **#21147** — `fix(agent-crdt): bind the session to the workflow a reload restored (FE-1969)` (9 files, +688/−36). Required: #21512 calls `onWorkflowRestoredAndBound`, and `hasUnsyncedHumanOps` is the guard the follow bind reuses. One conflict, a declaration-order union in `useAgentWorkflowSelection.ts` resolved to the order `core/1.59` landed. 3. **#21791** — `refactor(workflow): report user-initiated tab activations` (17 files, +473/−84, byte-identical stat to `main`). One conflict: `openWorkflow`'s options object, where 1.58 has `keepSavedBaseline` and this PR adds `initiator`. Both kept. 4. **#21512** — `feat(agent): carry workflow chat follow onto current main` (49 files). Seven conflicts; each resolution is stated below. ### #21512 conflict resolutions - `agentConversationStore.ts` (5) — 1.58 carries the snapshot-turn work (`unreconciledSnapshotTurns`, `snapshotTurnSettled`, `publishSnapshotMessage`) that `main` has since renamed. Declarations and the exported surface are unions in `core/1.59`'s order; `replacedSlot` is adopted alongside `unreconciledSnapshotTurns.clear()`; and the transport publish callback **keeps 1.58's `publishSnapshotMessage`**, which does `replaceActive` *plus* announcing a reconcilable snapshot turn, rather than narrowing to `publishMessage`. - `useAgentSession.ts` (1) — took #21512's `openThread`/`outlivedItsNavigation` rewrite with `boundWorkflowId.value = null; rememberedWorkflowId = null` replaced by 1.58's `forgetBinding()` helper (from #22518/#22697). The result is byte-identical to `core/1.59`'s `loadThread`. - `AgentPanelRoot.vue` (2) — import superset, and the `custom-title` fallback through `historyGroups.current`. - `RunNoticeBanner.vue` (2) — **narrow adaptation.** Added the `followFailed` context and the `liveness`/`contextAction` computeds, but **not** `genericNoticeReady` or the `visible` computed: those belong to a different PR that is not on this train, and 1.58's template already gates on `context || !dismissed`. Nothing chat-follow needs is dropped. - `AgentPanel.ts` fixture (2) — added only `historyButton`; `loadFailedMessage`/`loadRetryButton` appeared in the conflict as context from a PR not on this train and are unused here, so they are not introduced. `userMessageBubbles` **was** added (same reason, but the carried specs do use it). - `agentConversationFixture.ts` (1) — took the canvas-relative `canvasOps.click`; `comfyPage.canvas` and `comfyPage.canvasOps` both exist on this train. - `AgentPanelRoot.tabActivity.test.ts` — **path adaptation only.** 1.58 predates the billing module move: `@/platform/billing/composables/useBillingCapabilities` → `@/platform/workspace/composables/useBillingCapabilities`, `@/platform/billing/composables/useBillingContext` → `@/composables/billing/useBillingContext`, `@/platform/billing/subscription/composables/useAccountPreconditionDialog` → `@/platform/cloud/subscription/composables/useAccountPreconditionDialog`. Same three modules `AgentPanelRoot.vue` already imports on this branch. - Seven assertions in `AgentPanelRoot.test.ts` and `useAgentWorkflowSelection.test.ts` were updated to the behaviour the carried commits define, matching `core/1.59` exactly: four `expect(await restoration).toBe(true)` sites became `WorkflowRestoration`-shaped (#21147 changed that return type), and three chat-title tests now expect the server-assigned title (`'build a duck'`, `'my masterpiece'`) rather than `agent.newChatTitle`, which is #21512's own PM-2098 change. These are #21512's and #21147's own test updates; they failed to apply because the surrounding file differs on this train. ### Added on 2026-11-05: the FRONT-3804 chain 5. **#21497** `test: pin agent wire identity across a /ws reconnect` (test harness only). One conflict in `agentFollowerHostSocket.ts`: took #21497's per-connection `sid` and doc comment; 1.58 already had the `comfyConnections` counter from its PM-2123 backport. 6. **#21964** `test(agent): prove a document reset keeps other workflows' mint cursors` (test harness only). Applied clean. 7. **#22596** `fix(agent-crdt): track unconfirmed bind targets as unsynced (FRONT-3581)`. Three conflicts, all from `retrySubscription` and the dynamic-combo test scenario, neither on this train: added only `noteUnboundLocalIntent` to the follower surface; kept 1.58's `workflowByUnsettledOpId` settle bookkeeping and renamed `workflowsWithLostOps` to `workflowsWithUnsyncedOps` as #22596 does; in `docOpMinter.test.ts` added only the `unboundLocalIntents` counter. The new tests do not use the dynamic-combo scenario, so **#21686 is not carried**. 8. **#22792** `fix(agent): bind the workflow a followed chat opens (FRONT-3804)`. One conflict (`retrySubscription` again, dropped). `AgentPanelRoot.vue`, `docOpMinter.ts`, the fixture and the new spec applied clean. 9. `test(agent): import the workflow schema from its core/1.58 path`: the new fixture imported `@comfyorg/graph-model/workflowSchema`, a package 1.58 predates; it now uses `@/platform/workflow/validation/schemas/workflowSchema` like the other 1.58 fixtures. 10. **Rebased 2026-11-05 onto `core/1.58` after #22943** (empty composer on New Chat / draft across refresh). Two conflicts, both resolved to `main`'s and `core/1.59`'s shape: `onNewChat` keeps `retireFollow()` first and then the `history_back` branch, and `agentComposerStore.test.ts` keeps both the "draft presence" and "draft persistence" blocks in `main`'s order. One follow-up commit drops a duplicate `hasDraft` key in the composer store's returned object (both PRs added it; `main` has one). ## Verification - Before the rebase, at `928aaa2bc7`: `pnpm typecheck` and `pnpm typecheck:browser` pass (Node 26). - Vitest, 701 tests in 7 files, all pass: `AgentPanelRoot`, `docOpMinter`, `unsyncedHumanOps`, `followerProductGate`, `crossWorkflowPending`, `agentFollowerHostSocket`, `useAgentWorkflowChatFollow`. - The earlier four commits' 1945-test focused run (27 files) passed at `c10dbfe073`, before the chain was added. - Black-box: `browser_tests/tests/agent/agentBackgroundTabEditsLand.spec.ts` (CNV06 step 5) plus the chat-follow specs `agentTabActivationFollowsChat` and `agentTabChatTransitions` run in this PR's `@cloud` e2e shards. On `main` the CNV06 spec was red at the regressing commit 1a6324c and green with #22792 (see #22792). ## Delivery - **Core / Desktop:** the 1.58.6 release PR (#22908) is open on `core/1.58`. This PR merges first so 1.58.6 carries it; Core and Desktop get it when ComfyUI's pin moves to 1.58.6. - **Cloud:** chat-follow is already on `cloud/1.59` and `cloud/1.60`. The CNV06 fix is merged on both (#22813, #22806) but cloud production still serves `072c3c1140`, which predates it. The open production canary (Comfy-Org/cloud#17917) starts from a `cloud/1.59` tip that includes #22813. Testcloud builds `cloud/1.60` on every push, so it already carries #22806. Known limit, unchanged by this PR: an edit made by hand while a tab is not bound keeps that tab's follow bind refused until a reload plus a turn (the #22596 marker lifecycle). The owner decision is recorded on #22792; the in-session recovery design is #22801. --------- Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: christian-byrne <chrbyrne96@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com>
Manual recovery for the conflicted automated backport of #21791.
Preserves the release branch’s direct workflow-service wiring while porting the user-activation behavior and review fixes. The source-only overflow-menu test was omitted because this release line uses an older PrimeVue command harness; the behavior is covered by the focused workflow/tab/navigation suite.
Validation:
pnpm typecheck:appPre-push note: the release branch’s existing Knip gate reports its pre-existing missing
vitest.console.setup.tsimport fromvite.electron.config.mts; this change does not touch either path.