Repository navigation
build: guard the agent graph-API seam against store-first apply - #21916
christian-byrne wants to merge 1 commit into
Conversation
📦 Bundle: 12 MB gzip 🟢 -1.11 kBDetailsSummary
Category Glance App Entry Points — 6.71 kB (baseline 6.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.6 MB (baseline 2.6 MB) • 🟢 -50 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 2 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 9 unchanged Panels & Settings — 879 kB (baseline 879 kB) • 🟢 -88 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed / 29 unchanged User & Accounts — 160 kB (baseline 160 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 12 unchanged Editors & Dialogs — 503 kB (baseline 503 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 10 added / 10 removed / 7 unchanged UI Components — 368 kB (baseline 368 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 27 unchanged Data & Services — 1.94 MB (baseline 1.94 MB) • 🟢 -888 BStores, services, APIs, and repositories
Status: 15 added / 16 removed / 27 unchanged Utilities & Hooks — 2.46 MB (baseline 2.46 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 25 added / 25 removed / 58 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.9 MB (baseline 34.9 MB) • 🟢 -1.44 kBBundles that do not match a named category
Status: 74 added / 74 removed / 680 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-31T16:33:28.283Z",
"gitSha": "a4b0609616f46f558d3fdb309692eaa8c117a256",
"branch": "oploop960f/keepalive14-store-import-guard",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.6809999999732,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2079999999999997,
"layouts": 9,
"layoutDurationMs": 2.9939999999999998,
"taskDurationMs": 692.447,
"heapDeltaBytes": -19433792,
"heapUsedBytes": 53202352,
"domNodes": -178,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 13.732999999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2057.4400000000423,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.082,
"layouts": 9,
"layoutDurationMs": 2.874,
"taskDurationMs": 707.446,
"heapDeltaBytes": -20576356,
"heapUsedBytes": 56705212,
"domNodes": -178,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 14.657999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1941.7900000000259,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.131000000000002,
"layouts": 9,
"layoutDurationMs": 2.997,
"taskDurationMs": 1010.3740000000001,
"heapDeltaBytes": 1359872,
"heapUsedBytes": 74348992,
"domNodes": -178,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 178.477,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66637931034483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1908.7379999999712,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.752,
"layouts": 10,
"layoutDurationMs": 3.262,
"taskDurationMs": 1042.057,
"heapDeltaBytes": -7737524,
"heapUsedBytes": 60903180,
"domNodes": -178,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 175.93,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1773.994000000016,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.893,
"layouts": 12,
"layoutDurationMs": 4.010000000000001,
"taskDurationMs": 526.836,
"heapDeltaBytes": 5167732,
"heapUsedBytes": 73707432,
"domNodes": 57,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 16.399,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.201999999943,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.6080000000000005,
"layouts": 11,
"layoutDurationMs": 3.4579999999999997,
"taskDurationMs": 506.9239999999999,
"heapDeltaBytes": 25393768,
"heapUsedBytes": 85575284,
"domNodes": 57,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 16.666999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 804.7190000000342,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.202,
"layouts": 9,
"layoutDurationMs": 2.9229999999999996,
"taskDurationMs": 569.525,
"heapDeltaBytes": 581356,
"heapUsedBytes": 60735384,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 190.252,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 753.4439999999449,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0260000000000002,
"layouts": 10,
"layoutDurationMs": 2.9179999999999997,
"taskDurationMs": 553.8380000000001,
"heapDeltaBytes": 1157792,
"heapUsedBytes": 59935680,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 184.036,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1291.2959999999885,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1017.797,
"heapDeltaBytes": 17336424,
"heapUsedBytes": 107990748,
"domNodes": -148,
"jsHeapTotalBytes": 20873216,
"scriptDurationMs": 75.874,
"eventListeners": -106,
"totalBlockingTimeMs": 621,
"frameDurationMs": 36.665714285714294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1239.910000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 980.697,
"heapDeltaBytes": 20201696,
"heapUsedBytes": 85504392,
"domNodes": 0,
"jsHeapTotalBytes": 12222464,
"scriptDurationMs": 74.05199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 604,
"frameDurationMs": 36.27058823529414,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 911.5709999999808,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.7600000000001,
"heapDeltaBytes": -11258444,
"heapUsedBytes": 79717160,
"domNodes": -208,
"jsHeapTotalBytes": 3014656,
"scriptDurationMs": 173.14600000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 229,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 871.5100000000575,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.3059999999999,
"heapDeltaBytes": -6699404,
"heapUsedBytes": 90040984,
"domNodes": 0,
"jsHeapTotalBytes": 4198400,
"scriptDurationMs": 167.115,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12528.587000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11617.067000000001,
"heapDeltaBytes": 5795420,
"heapUsedBytes": 80303296,
"domNodes": -274,
"jsHeapTotalBytes": 15331328,
"scriptDurationMs": 9364.916,
"eventListeners": -68,
"totalBlockingTimeMs": 1815,
"frameDurationMs": 32.468652849740934,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11490.552999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10705.097,
"heapDeltaBytes": 77883164,
"heapUsedBytes": 153692132,
"domNodes": -274,
"jsHeapTotalBytes": 73003008,
"scriptDurationMs": 8595.546,
"eventListeners": -68,
"totalBlockingTimeMs": 1699,
"frameDurationMs": 31.28855585831063,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11184.28,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10387.874,
"heapDeltaBytes": 64847420,
"heapUsedBytes": 140515860,
"domNodes": -274,
"jsHeapTotalBytes": 73265152,
"scriptDurationMs": 8310.155999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1222,
"frameDurationMs": 31.196378830083564,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11654.269,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10821.881,
"heapDeltaBytes": 103235556,
"heapUsedBytes": 177712220,
"domNodes": -274,
"jsHeapTotalBytes": 84013056,
"scriptDurationMs": 8713.622,
"eventListeners": -68,
"totalBlockingTimeMs": 1348,
"frameDurationMs": 32.180939226519335,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 276.0240000000067,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.915,
"layouts": 10,
"layoutDurationMs": 3.4730000000000003,
"taskDurationMs": 236.35899999999998,
"heapDeltaBytes": -5964788,
"heapUsedBytes": 69553372,
"domNodes": -2325,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 11.626000000000001,
"eventListeners": -573,
"totalBlockingTimeMs": 8,
"frameDurationMs": 25,
"p95FrameDurationMs": 99.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 237.14200000006258,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.666999999999998,
"layouts": 7,
"layoutDurationMs": 2.287,
"taskDurationMs": 180.788,
"heapDeltaBytes": 14955724,
"heapUsedBytes": 75536740,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.016,
"eventListeners": 205,
"totalBlockingTimeMs": 8,
"frameDurationMs": 23.34000000000001,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2055.632000000003,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.412,
"layouts": 8,
"layoutDurationMs": 2.418,
"taskDurationMs": 781.7409999999999,
"heapDeltaBytes": 7309576,
"heapUsedBytes": 81276200,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 39.249,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.220000000053,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.568,
"layouts": 8,
"layoutDurationMs": 2.7349999999999994,
"taskDurationMs": 805.923,
"heapDeltaBytes": -16446912,
"heapUsedBytes": 76803032,
"domNodes": -274,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 44.608,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2837.065999999993,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.179,
"layouts": 7,
"layoutDurationMs": 2.018,
"taskDurationMs": 1833.2229999999997,
"heapDeltaBytes": -20910876,
"heapUsedBytes": 61259284,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 877.914,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665882352941175,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2935.0369999999657,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.934,
"layouts": 6,
"layoutDurationMs": 1.7359999999999998,
"taskDurationMs": 1921.5110000000002,
"heapDeltaBytes": 5439480,
"heapUsedBytes": 88783484,
"domNodes": -274,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 886.312,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909093,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4040.174000000036,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.155000000000001,
"layouts": 65,
"layoutDurationMs": 10.882,
"taskDurationMs": 1931.028,
"heapDeltaBytes": -22077036,
"heapUsedBytes": 61966768,
"domNodes": -250,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 818.016,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66570247933884,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4135.640999999964,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.749,
"layouts": 63,
"layoutDurationMs": 10.948,
"taskDurationMs": 1970.8329999999999,
"heapDeltaBytes": -9017560,
"heapUsedBytes": 75107496,
"domNodes": -250,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 850.667,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3247.942999999964,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.821,
"layouts": 5,
"layoutDurationMs": 1.647,
"taskDurationMs": 2126.512,
"heapDeltaBytes": 1470616,
"heapUsedBytes": 79945776,
"domNodes": -274,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 1018.3939999999998,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.839583333333334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3213.5500000000548,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.267999999999999,
"layouts": 5,
"layoutDurationMs": 1.294,
"taskDurationMs": 2176.165,
"heapDeltaBytes": -8768652,
"heapUsedBytes": 77201860,
"domNodes": 0,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 1037.1490000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 3,
"frameDurationMs": 16.929473684210524,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3148.3929999999987,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.184,
"layouts": 7,
"layoutDurationMs": 2.043,
"taskDurationMs": 825.752,
"heapDeltaBytes": 2521356,
"heapUsedBytes": 86522924,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 391.673,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665608465608468,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3153.2869999999775,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5450000000000004,
"layouts": 5,
"layoutDurationMs": 1.3859999999999997,
"taskDurationMs": 911.42,
"heapDeltaBytes": -8343208,
"heapUsedBytes": 75588044,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 402.502,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665608465608468,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.3199999999943,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.184,
"layouts": 7,
"layoutDurationMs": 2.057,
"taskDurationMs": 765.273,
"heapDeltaBytes": -20032372,
"heapUsedBytes": 65872484,
"domNodes": -274,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 35.47299999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2058.288999999945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8009999999999997,
"layouts": 8,
"layoutDurationMs": 2.3710000000000004,
"taskDurationMs": 818.004,
"heapDeltaBytes": -10281632,
"heapUsedBytes": 74855004,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 41.021,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3010.7889999999884,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.594999999999999,
"layouts": 8,
"layoutDurationMs": 2.262,
"taskDurationMs": 654.7410000000001,
"heapDeltaBytes": -15771484,
"heapUsedBytes": 77952764,
"domNodes": 19,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 210.918,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665745856353592,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3007.4769999999944,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.18,
"layouts": 5,
"layoutDurationMs": 1.5669999999999997,
"taskDurationMs": 714.0400000000001,
"heapDeltaBytes": -17790544,
"heapUsedBytes": 64903524,
"domNodes": -273,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 215.506,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758333333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3366.0189999999943,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8669999999999998,
"layouts": 6,
"layoutDurationMs": 1.6769999999999996,
"taskDurationMs": 1017.325,
"heapDeltaBytes": -3877056,
"heapUsedBytes": 90353596,
"domNodes": 0,
"jsHeapTotalBytes": 7114752,
"scriptDurationMs": 414.035,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665841584158414,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3416.219999999953,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.596,
"layouts": 5,
"layoutDurationMs": 1.4480000000000002,
"taskDurationMs": 1095.381,
"heapDeltaBytes": -17195548,
"heapUsedBytes": 68050680,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 410.541,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.747549019607845,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 663.9799999999809,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.366999999999999,
"layouts": 10,
"layoutDurationMs": 3.1879999999999997,
"taskDurationMs": 472.53000000000003,
"heapDeltaBytes": 1292416,
"heapUsedBytes": 63478612,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 151.034,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 690.6679999999596,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.3999999999999995,
"layouts": 9,
"layoutDurationMs": 2.869,
"taskDurationMs": 490.19599999999997,
"heapDeltaBytes": 10592196,
"heapUsedBytes": 85341772,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 152.367,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2039.1260000000102,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.915000000000001,
"layouts": 8,
"layoutDurationMs": 2.1899999999999995,
"taskDurationMs": 676.198,
"heapDeltaBytes": -4446708,
"heapUsedBytes": 57004860,
"domNodes": -200,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 12.819,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2055.394999999976,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1990000000000003,
"layouts": 9,
"layoutDurationMs": 3.0919999999999996,
"taskDurationMs": 717.863,
"heapDeltaBytes": 2151336,
"heapUsedBytes": 77082000,
"domNodes": -200,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 14.060999999999996,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1775.212999999951,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.267,
"layouts": 9,
"layoutDurationMs": 2.93,
"taskDurationMs": 963.1139999999999,
"heapDeltaBytes": 1403496,
"heapUsedBytes": 76016892,
"domNodes": -200,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 119.68800000000002,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666981132075474,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.9649999999074,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.257,
"layouts": 9,
"layoutDurationMs": 2.763,
"taskDurationMs": 911.5050000000001,
"heapDeltaBytes": 22959272,
"heapUsedBytes": 85482008,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 119.91300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.9460000000736,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.976999999999997,
"layouts": 5,
"layoutDurationMs": 17.372999999999998,
"taskDurationMs": 1194.349,
"heapDeltaBytes": 13065840,
"heapUsedBytes": 109086920,
"domNodes": 15949,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 32.260999999999996,
"eventListeners": 3246,
"totalBlockingTimeMs": 177,
"frameDurationMs": 20.044594594594596,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 11444.850999999971,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.199,
"layouts": 9,
"layoutDurationMs": 2.9219999999999997,
"taskDurationMs": 6657.408,
"heapDeltaBytes": -9014148,
"heapUsedBytes": 73135832,
"domNodes": -274,
"jsHeapTotalBytes": 3465216,
"scriptDurationMs": 2944.522,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69036496350365,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11554.509999999937,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.805000000000003,
"layouts": 8,
"layoutDurationMs": 2.2430000000000003,
"taskDurationMs": 6798.295999999999,
"heapDeltaBytes": -27493240,
"heapUsedBytes": 62386516,
"domNodes": -274,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 3063.866,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589595375723,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23261.31899999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22814.767,
"heapDeltaBytes": -23094916,
"heapUsedBytes": 255894468,
"domNodes": -3388,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 309.529,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.78771929824562,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 23224.228999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22660.895,
"heapDeltaBytes": -31655504,
"heapUsedBytes": 276466572,
"domNodes": -3388,
"jsHeapTotalBytes": 8634368,
"scriptDurationMs": 348.14500000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.60519713261649,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 28542.141999999898,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.364999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28196.617,
"heapDeltaBytes": -18845004,
"heapUsedBytes": 264789684,
"domNodes": -3388,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 938.3910000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 54.48244274809161,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28478.608000000007,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.816999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28101.842,
"heapDeltaBytes": -25051064,
"heapUsedBytes": 261822500,
"domNodes": -3388,
"jsHeapTotalBytes": 7847936,
"scriptDurationMs": 912.0200000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 27,
"frameDurationMs": 53.107276119402975,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8409.07900000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.38499999999999,
"layouts": 20,
"layoutDurationMs": 23.460999999999995,
"taskDurationMs": 8290.034,
"heapDeltaBytes": -21232624,
"heapUsedBytes": 272919176,
"domNodes": -3388,
"jsHeapTotalBytes": 15974400,
"scriptDurationMs": 140.49100000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.189325842696626,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8401.938000000086,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.89699999999998,
"layouts": 20,
"layoutDurationMs": 23.742,
"taskDurationMs": 8283.172,
"heapDeltaBytes": -32593960,
"heapUsedBytes": 258381312,
"domNodes": -3388,
"jsHeapTotalBytes": 22265856,
"scriptDurationMs": 127.23299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.455932203389835,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12030.57000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11782.160000000002,
"heapDeltaBytes": 28185292,
"heapUsedBytes": 284621260,
"domNodes": 0,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 171.98999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.20856164383561,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11636.795000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11397.591000000002,
"heapDeltaBytes": 3454256,
"heapUsedBytes": 264600796,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 149.29400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.10565371024735,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 155.94499999997424,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.065999999999999,
"layouts": 10,
"layoutDurationMs": 4.5249999999999995,
"taskDurationMs": 130.599,
"heapDeltaBytes": -13090892,
"heapUsedBytes": 60636608,
"domNodes": 135,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 12.683,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 128.63499999991745,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.392000000000001,
"layouts": 8,
"layoutDurationMs": 3.175,
"taskDurationMs": 95.963,
"heapDeltaBytes": -11527628,
"heapUsedBytes": 59886156,
"domNodes": 125,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 6.299,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.649999999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 508.43799999995554,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.646,
"layouts": 76,
"layoutDurationMs": 14.671999999999999,
"taskDurationMs": 459.434,
"heapDeltaBytes": -3788600,
"heapUsedBytes": 43042568,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 225.26,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 400.3339999999298,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.631,
"layouts": 76,
"layoutDurationMs": 13.697000000000001,
"taskDurationMs": 361.49399999999997,
"heapDeltaBytes": -5319432,
"heapUsedBytes": 40642220,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 168.88699999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000016,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 554.9310000000105,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.599,
"layouts": 76,
"layoutDurationMs": 15.274,
"taskDurationMs": 506.57700000000006,
"heapDeltaBytes": 876964,
"heapUsedBytes": 99903460,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 206.264,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.17272727272727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 538.962999999967,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4929999999999999,
"layouts": 76,
"layoutDurationMs": 14.64,
"taskDurationMs": 493.3810000000001,
"heapDeltaBytes": 617560,
"heapUsedBytes": 103806732,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 196.356,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.1875,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 59.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3196 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 86f226e5e4717b78d3cde3ad6b52ddefd21d1624
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (280)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
|
|
Important Review skippedWe couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Dependency rule and audit output .dependency-cruiser.json, package.json |
The dependency configuration blocks imports from agent extensions into the node and link stores. The deps:audit script uses err-long output. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21852: It checks the agent follower graph-API seam for local second-applier imports and other follower invariants.
Suggested reviewers: drjkl
Merge Risk: 
Minimal · previous review 06915
-
No actionable merge-blocking risk was identified in the scoped changes.
Pre-merge checks: 
7
-
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes only dependency-cruiser configuration and the package audit script. It does not change a user-facing feature or bug in the main frontend under
src/orpackages/. No Playwright test is suggested.
Full details: Website End-To-End Regression Coverage
-
Explanation
The PR changes only
.dependency-cruiser.jsonandpackage.json. It does not change files underapps/website/src/orapps/website/public/, so this website end-to-end coverage check does not apply.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21916 +/- ##
==========================================
- Coverage 87.61% 87.57% -0.05%
==========================================
Files 2957 2985 +28
Lines 161209 162196 +987
Branches 41286 42071 +785
==========================================
+ Hits 141246 142043 +797
- Misses 19040 19224 +184
- Partials 923 929 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
The FE-2504 rewrite (#18700) replaced store-first remote apply with one semantic path: a remote agent op reaches the graph through the same LGraph/LGraphNode API humans and extensions use, with provenance on the call. That deleted roughly 3,900 production lines of reconciliation whose only job was re-deriving link validation, widget callbacks and undo tracking after the stores had already been written. CRDT-FOLLOWER-0025 records the rule ("The follower writes the graph API, not the stores"), but nothing fails the build if a future change reintroduces the pattern. The invariant is currently held by reviewer attention and by .agents/checks/follower-boundary.md, which is an agent-read prompt profile rather than a mechanical check. Add a dependency-cruiser rule forbidding any import from src/workbench/extensions/agent/ to the node or link stores. It passes on main as written: no production agent module imports either store today, and the five test files that do are already outside the cruise via the existing exclude. widgetValueStore is deliberately not listed, because docOpMinter.ts and widgetValuesForm.ts read it to mint and project, which is not a store-first apply. Switch deps:audit to the err-long reporter so a violation prints the rule comment, naming the broken invariant and the ADR, instead of only the rule name. The two existing rules carry no comment, so their output is unchanged. deps:audit already runs in .github/actions/repo-checks and in the pre-push hook, and lint-and-format needs repo-checks, so this is enforced by a required check rather than advisory.
06915ca to
6abb3ee
Compare
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 10 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 6abb3ee | Docs | View more details | Give us feedback! |
dante01yoon
left a comment
There was a problem hiding this comment.
Thanks, this is a clean way to make the CRDT-FOLLOWER-0025 rule enforceable. I checked that both stores exist at the matched paths, that no production module under src/workbench/extensions/agent/ imports them today (only the 5 excluded test files do), and that err-long only changes how violations are reported. CI is green apart from two unrelated Playwright video jobs. I left one optional nit-pick.
| }, | ||
| { | ||
| "name": "agent-graph-api-not-stores", | ||
| "comment": "A remote agent op reaches the graph through the LGraph/LGraphNode API that humans and extensions use, never by writing the node or link stores directly. The stores are value holders; the graph API is the one place that owns link validation, widget callbacks and undo tracking, so writing them first means every one of those has to be re-derived afterwards. That re-derivation was the reconciliation layer the FE-2504 rewrite deleted (#18700), and this rule is what stops it growing back. See docs/adr/CRDT-FOLLOWER-0025-in-app-agent-crdt-follower-and-distribution-resolved-boundaries.md, 'The follower writes the graph API, not the stores'. widgetValueStore is deliberately not listed: docOpMinter.ts and widgetValuesForm.ts read it to mint and project, which is not a store-first apply.", |
There was a problem hiding this comment.
nit-pick (non-blocking): This comment is printed on every violation, so it might read better as just the rule and the ADR pointer ("Agent code writes the graph through the LGraph/LGraphNode API, not nodeDataStore/linkStore. See CRDT-FOLLOWER-0025."). The FE-2504/#18700 history and the widgetValueStore reasoning already live in the PR description and the ADR.
|
Closing this rather than merging the filename denylist. The original required-check failures were downstream of the server-fact gate attributing an already-mainline The architecture issue remains. The #21852 review already established that a name-based single-applier guard can stay green when the same behavior moves behind a different name such as |
Summary
The FE-2504 rewrite (#18700) replaced store-first remote apply with one semantic path: a remote agent op reaches the graph through the same
LGraph/LGraphNodeAPI humans and extensions use, with provenance on the call. That removed roughly 3,900 production lines of reconciliation whose only job was re-deriving link validation, widget callbacks and undo tracking after the stores had already been written.CRDT-FOLLOWER-0025records the rule ("The follower writes the graph API, not the stores"), but nothing currently fails the build if a change reintroduces the pattern. The closest thing to a guard is.agents/checks/follower-boundary.md, which is an agent-read prompt profile rather than a mechanical check, so today the invariant is held by reviewer attention.This adds the mechanical half.
What changed
A
.dependency-cruiser.jsonforbiddenrule,agent-graph-api-not-stores, atseverity: error, forbidding any import from^src/workbench/extensions/agent/to^src/stores/(nodeDataStore|linkStore)\.ts$.deps:auditmoves to theerr-longreporter so a violation prints the rule comment, which names the broken invariant and the ADR, rather than only the rule name. The two existing rules carry no comment, so their output is unchanged.It passes on main as written
No production module under
src/workbench/extensions/agent/imports either store today. Five test files do, and they are already outside the cruise through the existingoptions.excludeentry for\.(test|spec|stories)\.ts$, so no exemption was needed and none was added.widgetValueStoreis deliberately not in the rule.docOpMinter.tsandwidgetValuesForm.tsimport it to mint and to project, which is a read rather than a store-first apply, and listing it would fail honest code. The rule comment says so, so the next person does not "complete" the rule by adding it.Verification
Green on unmodified
mainat1a6324c76d, with the rule in place:Red when the pattern is reintroduced. Adding
import { useNodeDataStore } from '@/stores/nodeDataStore'toliveGraphApplier.tsand rerunning:Exit code 1. The violating import was reverted; only the two config files are in the diff.
This is enforced, not advisory
pnpm deps:auditalready runs in.github/actions/repo-checks/action.ymland in thepre-pushhook, andlint-and-formatdeclaresneeds: [lint, typecheck, typecheck-aux, repo-checks]. Sincelint-and-formatis a required check, the rule gates merges without any workflow change.Scope
Deliberately narrow. An import-level rule cannot catch a store write reached indirectly, and it says nothing about
widgetValueStorewrite methods; ano-restricted-syntaxcompanion for those would be the natural follow-up and is not attempted here. This rule covers the specific regression that cost the most to undo.