Repository navigation
fix(agent): keep accepted turns live after storage failures - #21912
Conversation
📦 Bundle: 11.9 MB gzip 🔴 +142 BDetailsSummary
Category Glance App Entry Points — 6.61 kB (baseline 6.61 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.61 MB (baseline 3.61 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 871 kB (baseline 871 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 33 unchanged User & Accounts — 151 kB (baseline 151 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 16 unchanged Editors & Dialogs — 513 kB (baseline 513 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 17 unchanged UI Components — 337 kB (baseline 337 kB) • ⚪ 0 BReusable component library chunks Status: 31 unchanged Data & Services — 1.84 MB (baseline 1.84 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed / 40 unchanged Utilities & Hooks — 1.33 MB (baseline 1.33 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 79 unchanged Vendor & Third-Party — 9.7 MB (baseline 9.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 15 unchanged Other — 34.6 MB (baseline 34.6 MB) • 🔴 +713 BBundles that do not match a named category
Status: 2 added / 2 removed / 746 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-24T18:38:28.371Z",
"gitSha": "5a5bbd6e30db8467ccbf320846973a5f226e3cc9",
"branch": "oploop-957d/accepted-turn-storage-pin",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.0780000000314,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3260000000000005,
"layouts": 9,
"layoutDurationMs": 2.078,
"taskDurationMs": 485.153,
"heapDeltaBytes": -17374596,
"heapUsedBytes": 52769632,
"domNodes": -161,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 9.036999999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.7019999999711,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4459999999999997,
"layouts": 9,
"layoutDurationMs": 2.2520000000000002,
"taskDurationMs": 426.943,
"heapDeltaBytes": 5925656,
"heapUsedBytes": 76388180,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8.382000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1698.7530000000106,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.297,
"layouts": 8,
"layoutDurationMs": 1.829,
"taskDurationMs": 734.976,
"heapDeltaBytes": 18177440,
"heapUsedBytes": 79432836,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 126.56599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.3430000000135,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.719000000000001,
"layouts": 10,
"layoutDurationMs": 2.5050000000000003,
"taskDurationMs": 717.2030000000001,
"heapDeltaBytes": -965692,
"heapUsedBytes": 68612252,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 124.152,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.423999999899,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.668000000000001,
"layouts": 10,
"layoutDurationMs": 2.4579999999999997,
"taskDurationMs": 319.155,
"heapDeltaBytes": 24507136,
"heapUsedBytes": 86951504,
"domNodes": 56,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.843000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1697.3239999999805,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.876,
"layouts": 9,
"layoutDurationMs": 2.389,
"taskDurationMs": 385.503,
"heapDeltaBytes": -91008,
"heapUsedBytes": 59907892,
"domNodes": 56,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 13.103,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 591.762000000017,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.807,
"layouts": 9,
"layoutDurationMs": 2.348,
"taskDurationMs": 423.14900000000006,
"heapDeltaBytes": 5550116,
"heapUsedBytes": 66276788,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 144.179,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 557.9640000000836,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4529999999999994,
"layouts": 9,
"layoutDurationMs": 2.04,
"taskDurationMs": 390.724,
"heapDeltaBytes": 5538984,
"heapUsedBytes": 66281760,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 131.174,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1051.0429999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 731.698,
"heapDeltaBytes": -1498440,
"heapUsedBytes": 75018056,
"domNodes": -191,
"jsHeapTotalBytes": 15474688,
"scriptDurationMs": 47.264,
"eventListeners": -106,
"totalBlockingTimeMs": 365,
"frameDurationMs": 28.37837837837838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1034.012999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 703.1120000000001,
"heapDeltaBytes": -9510108,
"heapUsedBytes": 74899596,
"domNodes": -191,
"jsHeapTotalBytes": 15736832,
"scriptDurationMs": 47.53,
"eventListeners": -106,
"totalBlockingTimeMs": 372,
"frameDurationMs": 28.699999999999996,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 780.2540000000135,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.6920000000002,
"heapDeltaBytes": -4023452,
"heapUsedBytes": 70050132,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.59299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 779.5670000000428,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.72799999999984,
"heapDeltaBytes": -2860996,
"heapUsedBytes": 70152384,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.008,
"eventListeners": 0,
"totalBlockingTimeMs": 154,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7792.067000000032,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5949999999999992,
"layouts": 3,
"layoutDurationMs": 0.6169999999999999,
"taskDurationMs": 6896.132,
"heapDeltaBytes": 62699116,
"heapUsedBytes": 142372860,
"domNodes": -257,
"jsHeapTotalBytes": 65400832,
"scriptDurationMs": 5252.7919999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 57,
"frameDurationMs": 24.021913580246913,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7395.10000000007,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.2750000000000001,
"layouts": 1,
"layoutDurationMs": 0.1910000000000002,
"taskDurationMs": 6562.974999999999,
"heapDeltaBytes": 69936552,
"heapUsedBytes": 144857728,
"domNodes": -257,
"jsHeapTotalBytes": 65925120,
"scriptDurationMs": 4998.406,
"eventListeners": -68,
"totalBlockingTimeMs": 27,
"frameDurationMs": 23.970779220779217,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7737.742999999966,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6379999999999997,
"layouts": 2,
"layoutDurationMs": 0.44600000000000023,
"taskDurationMs": 6814.888,
"heapDeltaBytes": -9898536,
"heapUsedBytes": 78402472,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 5260.15,
"eventListeners": -68,
"totalBlockingTimeMs": 83,
"frameDurationMs": 24.241692789968653,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7674.587000000088,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8129999999999995,
"layouts": 3,
"layoutDurationMs": 0.7960000000000003,
"taskDurationMs": 6848.332,
"heapDeltaBytes": -20958828,
"heapUsedBytes": 69058236,
"domNodes": -257,
"jsHeapTotalBytes": 10874880,
"scriptDurationMs": 5385.5740000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 63,
"frameDurationMs": 24.084639498432598,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-combo-open",
"durationMs": 216.16599999998698,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.690999999999999,
"layouts": 9,
"layoutDurationMs": 3.3539999999999996,
"taskDurationMs": 161.32899999999998,
"heapDeltaBytes": 14689260,
"heapUsedBytes": 73811348,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.882000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.077777777777808,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 218.95900000004076,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.488,
"layouts": 13,
"layoutDurationMs": 3.3810000000000002,
"taskDurationMs": 193.32900000000004,
"heapDeltaBytes": -23446224,
"heapUsedBytes": 65899432,
"domNodes": -2315,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 7.946999999999999,
"eventListeners": -573,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.690909090909084,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2008.8629999999625,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.825,
"layouts": 9,
"layoutDurationMs": 2.3950000000000005,
"taskDurationMs": 610.479,
"heapDeltaBytes": -18058368,
"heapUsedBytes": 63949836,
"domNodes": -257,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 32.718,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.6969999999228,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.341,
"layouts": 9,
"layoutDurationMs": 2.2140000000000004,
"taskDurationMs": 552.6769999999999,
"heapDeltaBytes": -9265052,
"heapUsedBytes": 82570324,
"domNodes": -257,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 30.653,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2453.72900000001,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.373,
"layouts": 9,
"layoutDurationMs": 2.1209999999999996,
"taskDurationMs": 1360.489,
"heapDeltaBytes": -22370184,
"heapUsedBytes": 59965912,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 641.498,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598639455782,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2452.987999999891,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.822000000000001,
"layouts": 8,
"layoutDurationMs": 2.103,
"taskDurationMs": 1425.719,
"heapDeltaBytes": -31855164,
"heapUsedBytes": 60366860,
"domNodes": -257,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 665.979,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598639455782,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3494.743000000028,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.016,
"layouts": 65,
"layoutDurationMs": 10.069999999999999,
"taskDurationMs": 1491.927,
"heapDeltaBytes": -12487244,
"heapUsedBytes": 59508960,
"domNodes": -233,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 640.443,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666190476190476,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3850.4270000000815,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.347999999999999,
"layouts": 63,
"layoutDurationMs": 10.819,
"taskDurationMs": 1671.443,
"heapDeltaBytes": 1915856,
"heapUsedBytes": 79039128,
"domNodes": -233,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 699.958,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580086580087,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2421.0489999999822,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.985999999999999,
"layouts": 8,
"layoutDurationMs": 1.8890000000000005,
"taskDurationMs": 1615.7109999999998,
"heapDeltaBytes": 15404364,
"heapUsedBytes": 94091440,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 795.082,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780689655172413,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3172.5329999999303,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.806,
"layouts": 5,
"layoutDurationMs": 1.4629999999999999,
"taskDurationMs": 1972.165,
"heapDeltaBytes": -16706392,
"heapUsedBytes": 70315008,
"domNodes": 0,
"jsHeapTotalBytes": 6381568,
"scriptDurationMs": 951.6060000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 15,
"frameDurationMs": 16.931914893617023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2987.242999999978,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.855,
"layouts": 7,
"layoutDurationMs": 1.6999999999999997,
"taskDurationMs": 654.66,
"heapDeltaBytes": -16907836,
"heapUsedBytes": 59443248,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 301.267,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665555555555557,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2922.337999999968,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.065,
"layouts": 8,
"layoutDurationMs": 1.799,
"taskDurationMs": 623.4499999999999,
"heapDeltaBytes": 1978352,
"heapUsedBytes": 73226680,
"domNodes": -257,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 278.46700000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.0920000000242,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.132,
"layouts": 8,
"layoutDurationMs": 1.952,
"taskDurationMs": 541.9730000000001,
"heapDeltaBytes": -26823140,
"heapUsedBytes": 65837260,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 31.283000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2051.7880000001014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8310000000000004,
"layouts": 9,
"layoutDurationMs": 2.599,
"taskDurationMs": 648.873,
"heapDeltaBytes": -17076472,
"heapUsedBytes": 72846248,
"domNodes": -257,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 39.783,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2857.849999999985,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.459,
"layouts": 7,
"layoutDurationMs": 1.8950000000000002,
"taskDurationMs": 513.282,
"heapDeltaBytes": 8917512,
"heapUsedBytes": 84670328,
"domNodes": -250,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 156.67600000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666279069767445,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2695.347999999967,
"styleRecalcs": 24,
"styleRecalcDurationMs": 10.497,
"layouts": 5,
"layoutDurationMs": 1.0990000000000002,
"taskDurationMs": 449.51099999999997,
"heapDeltaBytes": 26293592,
"heapUsedBytes": 85716556,
"domNodes": -238,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.052,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3060.437000000036,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.09,
"layouts": 7,
"layoutDurationMs": 1.9129999999999998,
"taskDurationMs": 780.4270000000001,
"heapDeltaBytes": 2960760,
"heapUsedBytes": 87092348,
"domNodes": -257,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 298.999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665760869565215,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3041.162999999983,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.496,
"layouts": 8,
"layoutDurationMs": 2.0950000000000006,
"taskDurationMs": 787.3469999999999,
"heapDeltaBytes": -5379484,
"heapUsedBytes": 86304420,
"domNodes": -257,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 300.135,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.0240000000022,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.029000000000001,
"layouts": 10,
"layoutDurationMs": 2.432,
"taskDurationMs": 351.132,
"heapDeltaBytes": 3006220,
"heapUsedBytes": 75807216,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 119.19899999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.8670000000493,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.5489999999999995,
"layouts": 10,
"layoutDurationMs": 2.7259999999999995,
"taskDurationMs": 385.826,
"heapDeltaBytes": -2083116,
"heapUsedBytes": 61200196,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 125.446,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.7529999999892,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4680000000000004,
"layouts": 9,
"layoutDurationMs": 2.1860000000000004,
"taskDurationMs": 412.06699999999995,
"heapDeltaBytes": 66400,
"heapUsedBytes": 62675012,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.458999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2025.935000000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.398,
"layouts": 9,
"layoutDurationMs": 2.228,
"taskDurationMs": 485.26000000000005,
"heapDeltaBytes": 268604,
"heapUsedBytes": 62711064,
"domNodes": -183,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 9.138,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.9709999999804,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.262,
"layouts": 10,
"layoutDurationMs": 2.4819999999999998,
"taskDurationMs": 703.6009999999999,
"heapDeltaBytes": -4944636,
"heapUsedBytes": 68163616,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 91.98700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.6979999999503,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.657,
"layouts": 10,
"layoutDurationMs": 2.3050000000000006,
"taskDurationMs": 682.509,
"heapDeltaBytes": -4553840,
"heapUsedBytes": 67674072,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 91.31599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1335.0829999999405,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.916,
"layouts": 5,
"layoutDurationMs": 12.144,
"taskDurationMs": 825.3929999999998,
"heapDeltaBytes": 9708716,
"heapUsedBytes": 95320092,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 25.572000000000003,
"eventListeners": 3246,
"totalBlockingTimeMs": 115,
"frameDurationMs": 19.012676056338037,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8827.95900000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.003999999999998,
"layouts": 8,
"layoutDurationMs": 1.8869999999999998,
"taskDurationMs": 4824.217,
"heapDeltaBytes": -12724496,
"heapUsedBytes": 61907016,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 2209.741,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10998.355999999945,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.895,
"layouts": 9,
"layoutDurationMs": 2.0509999999999997,
"taskDurationMs": 5379.819,
"heapDeltaBytes": -9937380,
"heapUsedBytes": 81056556,
"domNodes": -257,
"jsHeapTotalBytes": 6385664,
"scriptDurationMs": 2406.142,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 20012.48200000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19373.086,
"heapDeltaBytes": -22151384,
"heapUsedBytes": 260264840,
"domNodes": -3343,
"jsHeapTotalBytes": 8642560,
"scriptDurationMs": 269.15500000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.458834244080144,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20523.24599999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19928.554,
"heapDeltaBytes": -21205752,
"heapUsedBytes": 275157476,
"domNodes": -3343,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 276.146,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.50498220640569,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 23702.12499999991,
"styleRecalcs": 179,
"styleRecalcDurationMs": 21.02000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23454.87,
"heapDeltaBytes": -10986044,
"heapUsedBytes": 280347832,
"domNodes": -3343,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 765.1650000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.48752399232246,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 24822.50499999998,
"styleRecalcs": 181,
"styleRecalcDurationMs": 25.454000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24587.935999999998,
"heapDeltaBytes": -24707920,
"heapUsedBytes": 266728424,
"domNodes": -3343,
"jsHeapTotalBytes": 15720448,
"scriptDurationMs": 805.3729999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 49.13980198019802,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7132.043000000067,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.754999999999995,
"layouts": 20,
"layoutDurationMs": 21.234,
"taskDurationMs": 7014.710999999999,
"heapDeltaBytes": -22681040,
"heapUsedBytes": 280290516,
"domNodes": -3343,
"jsHeapTotalBytes": 22794240,
"scriptDurationMs": 111.497,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.616374269005846,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7388.678000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.29299999999999,
"layouts": 20,
"layoutDurationMs": 25.07999999999999,
"taskDurationMs": 7317.687999999999,
"heapDeltaBytes": 3671992,
"heapUsedBytes": 280566928,
"domNodes": -3343,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 132.967,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.772254335260115,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10232.606000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9818.242,
"heapDeltaBytes": 26031772,
"heapUsedBytes": 283214092,
"domNodes": 0,
"jsHeapTotalBytes": -1835008,
"scriptDurationMs": 164.13999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.54607142857142,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10094.090999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9843.381,
"heapDeltaBytes": -14329012,
"heapUsedBytes": 257909776,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.081,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.145018450184516,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 462.02900000002955,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.404000000000002,
"layouts": 12,
"layoutDurationMs": 4.069,
"taskDurationMs": 115.682,
"heapDeltaBytes": 7302700,
"heapUsedBytes": 68880268,
"domNodes": 138,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.88,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 108.22800000005373,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.937000000000001,
"layouts": 7,
"layoutDurationMs": 2.5889999999999995,
"taskDurationMs": 75.50899999999999,
"heapDeltaBytes": 4676968,
"heapUsedBytes": 66287884,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.549,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 345.97600000006423,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.629,
"layouts": 76,
"layoutDurationMs": 13.104,
"taskDurationMs": 311.592,
"heapDeltaBytes": -5428972,
"heapUsedBytes": 36039056,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 142.21800000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661904761904765,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 344.56299999999374,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.742,
"layouts": 76,
"layoutDurationMs": 13.419,
"taskDurationMs": 310.892,
"heapDeltaBytes": -5377640,
"heapUsedBytes": 36725100,
"domNodes": 4,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 143.494,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 394.5650000000569,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.907,
"layouts": 76,
"layoutDurationMs": 13.225999999999999,
"taskDurationMs": 357.21799999999996,
"heapDeltaBytes": -1133728,
"heapUsedBytes": 89268608,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 132.938,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 408.2659999999123,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.536,
"layouts": 76,
"layoutDurationMs": 14.063,
"taskDurationMs": 363.62500000000006,
"heapDeltaBytes": -504984,
"heapUsedBytes": 92367120,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 131.73299999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.36250000000003,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3085 passed, 0 failed · 6 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3ee458caef5ef19061f97298d682127932615bc8
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (185)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Isolate accepted-turn side effects src/workbench/extensions/agent/composables/agent/useAgentSession.ts |
The accepted-turn flow runs callbacks, thread activation, thread-ID persistence, and workflow adoption through an error-isolating helper. Errors are reported as non-retryable post-acceptance failures. |
Verify post-acceptance failure handling src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts |
Unit tests verify that persistence and workflow adoption failures leave the accepted turn active and preserve the conversation entries. |
Verify storage failure in the browser browser_tests/tests/agent/agentAcceptedTurnSurvivesStorageFailure.spec.ts |
The browser test simulates thread-ID storage failure and checks that the prompt and stop button remain visible, with no send-failed message. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix · Severity of issue fixed: Medium
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21538: Adds the
onAcceptedcallback tosendMessage, which is part of the post-acceptance callback path addressed here.
Suggested labels: agent, risk:high
Suggested reviewers: drjkl, ryan-di
Merge Risk: 
Minimal · up to b40d0
-
Accepted turns remain visible and active when thread-ID storage fails. No issue requiring a fix before merge was established.
Pre-merge checks: 
7
-
Full details: Description check
-
Explanation
The description includes the problem, resulting behavior, linked issue, verification steps, test results, typecheck results, and hook results. It satisfies the required Summary and Verification sections.
Full details: Linked Issues check
-
Explanation
Issue
#17358requirements are covered.useAgentSession.tsrecords the user and starts the turn before it runs post-acceptance callbacks.runAcceptedTurnSideEffectcatches callback and thread-persistence errors, reports stable error types, and records non-retryable post-acceptance telemetry without changing the accepted result. The unit tests cover throwing thread persistence and workflow adoption callbacks. They verify accepted status, user and assistant entries, active streaming, andreportError()details. The browser test verifies the user message, visible Stop control, absence of Send failed, and one accepted turn. The changes preserve normal stream ingestion because the turn starts before the deferred effects.
Full details: Out of Scope Changes check
-
Explanation
The changed source implements the post-acceptance failure handling required by
#17358. The unit and browser tests directly cover the required storage and adoption failure cases. No unrelated product behavior or unrelated files are introduced.
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes the frontend under
src/to keep an accepted Agent turn live after thread persistence or callback failures. The trigger is user-visible: submit a prompt while local storage or a post-acceptance callback fails. The PR also addsbrowser_tests/tests/agent/agentAcceptedTurnSurvivesStorageFailure.spec.ts, which exercises the storage-failure trigger and verifies the accepted turn remains visible and live. The check encourages this coverage but does not require more.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The changed files are
browser_tests/tests/agent/agentAcceptedTurnSurvivesStorageFailure.spec.ts,src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts, andsrc/workbench/extensions/agent/composables/agent/useAgentSession.ts. None are undersrc/lib/litegraph/orsrc/ecs/, and they are not graph-entity files. The ADR-LAYOUT and ADR-ECS checks do not apply.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21912 +/- ##
==========================================
+ Coverage 86.56% 87.49% +0.92%
==========================================
Files 3926 2767 -1159
Lines 183347 152955 -30392
Branches 49755 41118 -8637
==========================================
- Hits 158722 133833 -24889
+ Misses 22170 18447 -3723
+ Partials 2455 675 -1780
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1170 files with indirect coverage changes 🚀 New features to boost your workflow:
|
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit b40d0eb has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Summary
A server-accepted Agent turn now remains visible and running when thread persistence or another local post-acceptance callback fails. The failure is still reported, but it no longer rewrites a successful acceptance into the false send-failed state from #17358.
Fixes #17358
Verification