Repository navigation
Conversation
…run the open workflow (BE-19373) (#20372) **TL;DR:** with a workflow open, each row of the deployment switcher, Comfy Cloud's row included, says "Runs this workflow", "Missing N nodes" (the node names on hover) or "Not checked". **Why:** today an artist finds the deployment that can run a workflow by picking one, waiting for the reload, and looking for red nodes, one deployment at a time. **Before / After:** before, each row shows the deployment's Build, Release and status only. After, each row also says whether that deployment has every node type the open workflow uses. Ref BE-19373, part of BE-19371 **Not run:** the editor in a browser against a real ingest (the endpoint shipped in Comfy-Org/cloud#12241; no real call was made from this branch, tests stub it). Ran: `pnpm typecheck`, knip, `fallow:audit`, the vitest suites under `src/platform/workspace`, and Storybook in Cloud mode for the screenshots; the pre-commit and pre-push hooks ran in full. - **What**: - `workspaceApi.checkDeploymentCompatibility(workspaceId, nodeTypes)`: `POST /api/workspaces/{id}/deployments/compatibility` with `{"node_types": [...]}`. The answer lists, per deployment, the node types it is missing (or `unknown: true` when its Release has no node list), and the node types Comfy Cloud is missing. The request and response types are `@comfyorg/ingest-types`' generated `DeploymentCompatibilityRequest` and `DeploymentCompatibility`, and the answer is parsed with `zDeploymentCompatibility`, so an answer off the contract fails the check and gives no marks. - `useDeploymentCompatibility` (new, shared): collects the node types of the open workflow, subgraph contents included, leaving out muted and bypassed nodes, frontend-only nodes (notes, reroutes) and subgraph instances. It asks ingest once per distinct set of types, so editing a widget value sends nothing and opening another workflow asks again. It asks only while its switch is on and the switcher is shown with at least one deployment. A failed call, or an answer for a type set the workflow no longer has, gives no marks. - `deployment_compatibility_marks_enabled` (new flag, default off): the marks' own switch, read from `/api/features` and resolved per workspace. While it is off the composable loads no listing, reads no graph, sends no check, and no row carries a mark; turning it off mid-session drops the marks. - `GraphView.vue` starts the composable on Cloud, so the check runs when a workflow loads rather than when the switcher is first opened. The composable starts the switcher's listing if nothing has loaded it yet. - `DeploymentSwitcherRow` takes an optional `mark`; `DeploymentSwitcherList` passes one for Comfy Cloud and for each deployment. - Three strings in `deploymentSwitcher` in `main.json`. - **Dependencies**: none new. - Core node types are sent too: filtering them in the editor would copy ingest's knowledge of what Comfy Cloud has. - While its switch is on, the composable starts the deployment listing through `loadOnce`, the same load #19965 starts at boot, so the two share one request; after a workspace change it loads the new workspace's listing. Taken in Storybook with fixed answers for the check: the Run bar's engine button with its Run on menu open. | Light | Dark | |---|---| |  |  | At 390px wide the menu narrows to fit the screen: every deployment name shows in full, the gray subtitle after it is cut short with an ellipsis, and the marks stay whole: <img src="https://gist.githubusercontent.com/vqt123/ea85d8c0cb273d2723cd2b4676de1be9/raw/3e68cb462ccdf2bec26486d21441d1757b650898/22-menu-marks-phone-390.png" width="200" alt="The Run on menu with marks at 390px wide, inside the screen, names in full and subtitles cut short"> Try it: open the PR's Storybook preview, https://67d5acfd.comfy-storybook.pages.dev/?path=/story/components-deploymentswitcher-row--all-marks, and step through the `DeploymentSwitcherRow` stories (all marks: none, runs, missing nodes, not checked; checked and runs). In the editor itself, the marks show while the `deployment_compatibility_marks_enabled` flag is on. (cherry picked from commit 01e7d63)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-24T08:20:34.105Z",
"gitSha": "062e0c44b2bfa51514366b52e048ae0a6dc0aafe",
"branch": "backport-20372-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.9269999999904,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.144,
"layouts": 8,
"layoutDurationMs": 1.918,
"taskDurationMs": 366.321,
"heapDeltaBytes": 244956,
"heapUsedBytes": 90917752,
"domNodes": -200,
"jsHeapTotalBytes": 1105920,
"scriptDurationMs": 9.424999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.0519999999833,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.498,
"layouts": 9,
"layoutDurationMs": 2.3350000000000004,
"taskDurationMs": 478.57099999999997,
"heapDeltaBytes": 3214456,
"heapUsedBytes": 93414620,
"domNodes": -200,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 9.762000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1679.1860000000156,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.028,
"layouts": 10,
"layoutDurationMs": 2.4800000000000004,
"taskDurationMs": 622.608,
"heapDeltaBytes": -3279796,
"heapUsedBytes": 97359648,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 126.53399999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.4449999999888,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.751,
"layouts": 9,
"layoutDurationMs": 2.317,
"taskDurationMs": 706.208,
"heapDeltaBytes": 1622220,
"heapUsedBytes": 91999840,
"domNodes": -200,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 132.79399999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.898999999974,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.306,
"layouts": 11,
"layoutDurationMs": 3.013,
"taskDurationMs": 380.21,
"heapDeltaBytes": 24565456,
"heapUsedBytes": 114271844,
"domNodes": 47,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.449,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1792.4809999999525,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.414000000000001,
"layouts": 12,
"layoutDurationMs": 2.807,
"taskDurationMs": 397.75500000000005,
"heapDeltaBytes": -1363396,
"heapUsedBytes": 88692004,
"domNodes": 47,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 11.777,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 552.6869999999917,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.017,
"layouts": 10,
"layoutDurationMs": 2.5460000000000003,
"taskDurationMs": 366.39500000000004,
"heapDeltaBytes": 3740408,
"heapUsedBytes": 93513240,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 140.142,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 592.7649999999858,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.857,
"layouts": 9,
"layoutDurationMs": 2.356,
"taskDurationMs": 439.464,
"heapDeltaBytes": 5350016,
"heapUsedBytes": 96466016,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 137.12199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1094.0479999999866,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 780.5999999999999,
"heapDeltaBytes": 159236,
"heapUsedBytes": 102152772,
"domNodes": -231,
"jsHeapTotalBytes": 10289152,
"scriptDurationMs": 66.69200000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 439,
"frameDurationMs": 30.555555555555557,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1082.8329999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.437,
"heapDeltaBytes": 9992324,
"heapUsedBytes": 128970936,
"domNodes": -170,
"jsHeapTotalBytes": 15687680,
"scriptDurationMs": 49.247,
"eventListeners": -168,
"totalBlockingTimeMs": 440,
"frameDurationMs": 31.861764705882344,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 785.7640000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.0139999999996,
"heapDeltaBytes": -1885952,
"heapUsedBytes": 98286652,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.806,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 23.04117647058825,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 765.8200000000193,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.2980000000001,
"heapDeltaBytes": -3563076,
"heapUsedBytes": 97637204,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.202,
"eventListeners": 0,
"totalBlockingTimeMs": 155,
"frameDurationMs": 23.23030303030304,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8879.592000000002,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3309999999999997,
"layouts": 1,
"layoutDurationMs": 0.2519999999999996,
"taskDurationMs": 7969.9800000000005,
"heapDeltaBytes": -29578264,
"heapUsedBytes": 95521692,
"domNodes": -276,
"jsHeapTotalBytes": 23744512,
"scriptDurationMs": 6308.497,
"eventListeners": -130,
"totalBlockingTimeMs": 257,
"frameDurationMs": 25.307692307692307,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7816.478999999958,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.699,
"layouts": 2,
"layoutDurationMs": 0.5859999999999997,
"taskDurationMs": 6978.223,
"heapDeltaBytes": 19090960,
"heapUsedBytes": 132873172,
"domNodes": -276,
"jsHeapTotalBytes": 22171648,
"scriptDurationMs": 5330.395,
"eventListeners": -130,
"totalBlockingTimeMs": 57,
"frameDurationMs": 24.12469135802469,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7178.436000000005,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7930000000000003,
"layouts": 3,
"layoutDurationMs": 0.957,
"taskDurationMs": 6365.825,
"heapDeltaBytes": 38287160,
"heapUsedBytes": 141777552,
"domNodes": -296,
"jsHeapTotalBytes": 28106752,
"scriptDurationMs": 5070.1179999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 38,
"frameDurationMs": 24.210810810810813,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7160.262999999986,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.048999999999999565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6428.521,
"heapDeltaBytes": -6141308,
"heapUsedBytes": 114392008,
"domNodes": -276,
"jsHeapTotalBytes": -3256320,
"scriptDurationMs": 5007.938999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 94,
"frameDurationMs": 24.56907216494845,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 163.75500000000898,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.118,
"layouts": 11,
"layoutDurationMs": 2.8120000000000003,
"taskDurationMs": 130.182,
"heapDeltaBytes": 13315948,
"heapUsedBytes": 118696028,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.1850000000000005,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837499999999977,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 191.0829999999919,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.849,
"layouts": 11,
"layoutDurationMs": 2.807,
"taskDurationMs": 140.44799999999998,
"heapDeltaBytes": -7776992,
"heapUsedBytes": 106218792,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.988999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.000000000000046,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2040.6709999999748,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8579999999999997,
"layouts": 9,
"layoutDurationMs": 2.419,
"taskDurationMs": 667.181,
"heapDeltaBytes": -28267660,
"heapUsedBytes": 94144656,
"domNodes": -301,
"jsHeapTotalBytes": -1908736,
"scriptDurationMs": 32.446999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6650406504065,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.5489999999986,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.239,
"layouts": 8,
"layoutDurationMs": 1.9530000000000003,
"taskDurationMs": 542.527,
"heapDeltaBytes": 190360,
"heapUsedBytes": 109926828,
"domNodes": -296,
"jsHeapTotalBytes": -991232,
"scriptDurationMs": 29.846000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2318.450000000041,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.042000000000002,
"layouts": 7,
"layoutDurationMs": 1.8780000000000003,
"taskDurationMs": 1517.8509999999999,
"heapDeltaBytes": 1824600,
"heapUsedBytes": 113521028,
"domNodes": -296,
"jsHeapTotalBytes": 20480,
"scriptDurationMs": 762.007,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.907246376811596,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2282.670000000053,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.450999999999999,
"layouts": 7,
"layoutDurationMs": 1.7309999999999999,
"taskDurationMs": 1373.4660000000001,
"heapDeltaBytes": 1618476,
"heapUsedBytes": 113820152,
"domNodes": -296,
"jsHeapTotalBytes": -241664,
"scriptDurationMs": 723.3919999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.91492537313433,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3618.9639999999486,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.389,
"layouts": 64,
"layoutDurationMs": 10.71,
"taskDurationMs": 1503.727,
"heapDeltaBytes": 6937472,
"heapUsedBytes": 112642248,
"domNodes": 24,
"jsHeapTotalBytes": 5771264,
"scriptDurationMs": 664.722,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3298.962999999958,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.549000000000001,
"layouts": 66,
"layoutDurationMs": 10.605,
"taskDurationMs": 1351.095,
"heapDeltaBytes": -19374752,
"heapUsedBytes": 100706128,
"domNodes": -273,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 634.381,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.750761421319794,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3090.4859999999985,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.132999999999999,
"layouts": 5,
"layoutDurationMs": 1.47,
"taskDurationMs": 1742.7699999999998,
"heapDeltaBytes": 18222860,
"heapUsedBytes": 121117676,
"domNodes": 0,
"jsHeapTotalBytes": 3567616,
"scriptDurationMs": 834.347,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.94120879120879,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2399.7550000000274,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.944999999999999,
"layouts": 7,
"layoutDurationMs": 1.9519999999999997,
"taskDurationMs": 1491.101,
"heapDeltaBytes": -12248732,
"heapUsedBytes": 102967624,
"domNodes": 0,
"jsHeapTotalBytes": 6295552,
"scriptDurationMs": 783.597,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.900000000000002,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.38800000004,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2110000000000003,
"layouts": 7,
"layoutDurationMs": 1.9989999999999999,
"taskDurationMs": 552.4340000000001,
"heapDeltaBytes": -8490504,
"heapUsedBytes": 110898144,
"domNodes": -297,
"jsHeapTotalBytes": -2527232,
"scriptDurationMs": 28.969,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.7470000000294,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6100000000000003,
"layouts": 8,
"layoutDurationMs": 2.2760000000000002,
"taskDurationMs": 568.817,
"heapDeltaBytes": -26220208,
"heapUsedBytes": 87214536,
"domNodes": -296,
"jsHeapTotalBytes": -204800,
"scriptDurationMs": 33.098,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.133000000003,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.9769999999999985,
"layouts": 9,
"layoutDurationMs": 2.235,
"taskDurationMs": 404.846,
"heapDeltaBytes": 22510500,
"heapUsedBytes": 113400648,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 121.00000000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 544.4340000000238,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.0409999999999995,
"layouts": 10,
"layoutDurationMs": 2.3770000000000007,
"taskDurationMs": 370.089,
"heapDeltaBytes": 2745308,
"heapUsedBytes": 109446296,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 121.252,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.6539999999982,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9589999999999996,
"layouts": 9,
"layoutDurationMs": 2.533,
"taskDurationMs": 562.036,
"heapDeltaBytes": 1034964,
"heapUsedBytes": 91920308,
"domNodes": -218,
"jsHeapTotalBytes": 1105920,
"scriptDurationMs": 10.643,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.1759999999877,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.757,
"layouts": 9,
"layoutDurationMs": 2.3640000000000003,
"taskDurationMs": 373.828,
"heapDeltaBytes": 8172708,
"heapUsedBytes": 99092484,
"domNodes": -218,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 8.499999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.683000000031,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.979000000000001,
"layouts": 9,
"layoutDurationMs": 2.2990000000000004,
"taskDurationMs": 685.5210000000001,
"heapDeltaBytes": 5598188,
"heapUsedBytes": 96578984,
"domNodes": -190,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 100.449,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.7540000000404,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.812,
"layouts": 10,
"layoutDurationMs": 2.4779999999999998,
"taskDurationMs": 710.1370000000001,
"heapDeltaBytes": 20703556,
"heapUsedBytes": 115423756,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 97.619,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.6240000000171,
"styleRecalcs": 21,
"styleRecalcDurationMs": 21.919,
"layouts": 5,
"layoutDurationMs": 12.996,
"taskDurationMs": 695.179,
"heapDeltaBytes": 35800852,
"heapUsedBytes": 139432676,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 24.585000000000008,
"eventListeners": 3244,
"totalBlockingTimeMs": 135,
"frameDurationMs": 20.92790697674418,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10723.050000000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.361,
"layouts": 8,
"layoutDurationMs": 1.937,
"taskDurationMs": 5240.529,
"heapDeltaBytes": -21158172,
"heapUsedBytes": 89355744,
"domNodes": -276,
"jsHeapTotalBytes": -204800,
"scriptDurationMs": 2314.4739999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665940902021774,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8209.092000000055,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.627000000000002,
"layouts": 8,
"layoutDurationMs": 2.098,
"taskDurationMs": 4330.893,
"heapDeltaBytes": -21828532,
"heapUsedBytes": 89313636,
"domNodes": -296,
"jsHeapTotalBytes": -991232,
"scriptDurationMs": 2167.776,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699796747967483,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14503.22699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13871.396,
"heapDeltaBytes": -27166044,
"heapUsedBytes": 280263528,
"domNodes": -3344,
"jsHeapTotalBytes": 27774976,
"scriptDurationMs": 203.133,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.249728752260395,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 19610.084000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19036.702999999998,
"heapDeltaBytes": -45980972,
"heapUsedBytes": 278256288,
"domNodes": -3344,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 254.62400000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.99247706422019,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 23656.377000000022,
"styleRecalcs": 178,
"styleRecalcDurationMs": 21.108999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23365.147,
"heapDeltaBytes": -30293584,
"heapUsedBytes": 293794344,
"domNodes": -3344,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 767.578,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 45.54326923076923,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 17162.849999999933,
"styleRecalcs": 123,
"styleRecalcDurationMs": 14.133000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16831.714,
"heapDeltaBytes": -9687496,
"heapUsedBytes": 291207356,
"domNodes": -3344,
"jsHeapTotalBytes": 25153536,
"scriptDurationMs": 667.288,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 32.41833648393195,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6972.616000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.24800000000001,
"layouts": 20,
"layoutDurationMs": 20.337999999999994,
"taskDurationMs": 6883.358,
"heapDeltaBytes": -40686280,
"heapUsedBytes": 279009416,
"domNodes": -3344,
"jsHeapTotalBytes": 23580672,
"scriptDurationMs": 107.70599999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.22060606060606,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6921.443999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.72300000000001,
"layouts": 20,
"layoutDurationMs": 20.829,
"taskDurationMs": 6844.052,
"heapDeltaBytes": -29455996,
"heapUsedBytes": 277268416,
"domNodes": -307,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 99.518,
"eventListeners": -7,
"totalBlockingTimeMs": 10,
"frameDurationMs": 40.782941176470594,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9602.782000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9414.760000000002,
"heapDeltaBytes": 10441772,
"heapUsedBytes": 294823740,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 128.25300000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.09999999999999,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7150.645000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6893.571999999999,
"heapDeltaBytes": 11334192,
"heapUsedBytes": 287248100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.33399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.480370370370373,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 462.5609999999938,
"styleRecalcs": 20,
"styleRecalcDurationMs": 10.919,
"layouts": 12,
"layoutDurationMs": 3.8699999999999997,
"taskDurationMs": 123.14200000000001,
"heapDeltaBytes": -8684536,
"heapUsedBytes": 92826544,
"domNodes": 126,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 12.964,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 91.08900000001086,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.928,
"layouts": 7,
"layoutDurationMs": 1.802,
"taskDurationMs": 60.602000000000004,
"heapDeltaBytes": 4639968,
"heapUsedBytes": 102246380,
"domNodes": 94,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.063,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 311.7130000000543,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.612,
"layouts": 76,
"layoutDurationMs": 12.237,
"taskDurationMs": 273.557,
"heapDeltaBytes": 10619580,
"heapUsedBytes": 99103352,
"domNodes": 4,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 126.86,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736862,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 324.28600000002916,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.67,
"layouts": 76,
"layoutDurationMs": 13.781,
"taskDurationMs": 293.006,
"heapDeltaBytes": -19579728,
"heapUsedBytes": 70856012,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 132.858,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 348.6809999999423,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.19,
"layouts": 76,
"layoutDurationMs": 11.363,
"taskDurationMs": 309.771,
"heapDeltaBytes": -1315844,
"heapUsedBytes": 115454360,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 111.441,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 373.61599999997,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.0170000000000003,
"layouts": 76,
"layoutDurationMs": 11.969000000000001,
"taskDurationMs": 337.074,
"heapDeltaBytes": -983972,
"heapUsedBytes": 115973616,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.38199999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2969 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since becdcf27506a6880ed602845f7472080a86810b6
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (123)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.58 #21896 +/- ##
=============================================
Coverage ? 85.79%
=============================================
Files ? 2589
Lines ? 134957
Branches ? 38766
=============================================
Hits ? 115792
Misses ? 18748
Partials ? 417
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Two Tailwind arbitrary values here are intentional:
|
Why
Cloud serves the frontend from
cloud/1.58, notmain, so #20372 (the deployment switcher marks which deployments can run the open workflow) reaches Cloud users only through this backport. The marks stay off unlessdeployment_compatibility_marks_enabledis on.Backport of #20372 to
cloud/1.58(cherry-pick of 01e7d63).The automatic backport stopped on a conflict in
src/views/GraphView.vue: the line next to the new one,useDesktopCloudNotification(), exists only on main. This keepscloud/1.58's line as it is and adds only #20372'sif (isCloud) useDeploymentCompatibility()and its import. Nothing else from main comes in.It also carries #21897's fix: an answer now counts only for the check that asked for it, so switching workflows cannot bring back an old or wrong mark.
Screenshots
Same screens as #20372, taken while testing it:
Taken in Storybook with fixed answers for the check: the Run bar's engine button with its Run on menu open.
At 390px wide the menu narrows to fit the screen: every deployment name shows in full, the gray subtitle after it is cut short with an ellipsis, and the marks stay whole:
Try it: open #20372's Storybook preview (the components are identical here), https://67d5acfd.comfy-storybook.pages.dev/?path=/story/components-deploymentswitcher-row--all-marks, and step through the
DeploymentSwitcherRowstories (all marks: none, runs, missing nodes, not checked; checked and runs). In the editor itself, the marks show while thedeployment_compatibility_marks_enabledflag is on.Ref BE-19373
Tests:
pnpm vitest run src/platform/workspace src/composables/useFeatureFlags.test.tsand typecheck pass on this branch, including the stale-answer regression tests from #21897.Not run: a browser run on
cloud/1.58. #20372 was run end to end against staging and a local ingest before it merged.