Repository navigation
[backport cloud/1.58] test(agent): user-story specs — stop survives, output surfaces, failure/stall surfaced, finished-generation preview - #21876
Conversation
…re/stall surfaced, finished-generation preview (#18803) ## Summary Adds black-box user-story specs on the agent harness execution surface (#18790), stacked on the rank-26 golden path (#18802), and extends the golden path with the finished run's history-row thumbnail. ## Changes - **What**: - `agentStopKeepsServerRunAlive.spec.ts` (rank 41): Stop cancels the agent's turn but sends no job interrupt or cancel request, and the submitted job keeps its executing outline. The story fixture records `/api/interrupt`, `/api/jobs/cancel` and `/api/jobs/{id}/cancel` as `jobCancelRequests()`, and accepts the turn-cancel request. - `agentFailedRunIsSurfaced.spec.ts` (rank 99, failure half): a server-submitted run that fails after the turn ends shows its error message in the queue row's details popover, and the agent panel stays idle. - `agentGoldenPathRunIt.spec.ts` (rank 98, fixture-supported half): the finished run's history row renders a thumbnail served from that run's output. - `agentJobReopenedAsWorkflow.spec.ts` (rank 79, folds #18936): "open as workflow" rebuilds the graph when the job carries one, and — as a declared expected failure — says nothing at all when it does not. - All four live beside their fixture in `browser_tests/tests/agent/`. ## Review Focus - **Why the fixture moved.** The fixture and its execution helper additions are used only by the four specs in this PR, so they now live next to them in `browser_tests/tests/agent/` instead of in `browser_tests/fixtures/` — the same shape as `agentPanelMocks.ts` and `agentCreditsExhaustionLifecycleMocks.ts`, which are already `agentTest.extend` fixtures under `tests/agent/`. CODEOWNERS already scoped both files to `@Comfy-Org/agent_devs` through `/browser_tests/fixtures/**/*gent*`, so this does not change who owns them; it only makes the paths agree with that ownership. The branch ruleset's narrower `browser_tests/fixtures/data/agent/**` glob did not cover them, which is why the earlier layout pulled an Agent-test-only PR into the shared-path reviewer entry. - The two story-only additions to the execution surface — the job interrupt/cancel recorder and a per-job `GET /api/jobs/{id}` detail route — are now a subclass in the story fixture rather than changes to the shared `AgentExecutionHelper`, which `agentExecutionFixture.ts` and `agentExecutionLifecycle.spec.ts` also consume. This PR no longer modifies that shared helper. - The stalled-run half of rank 99 and rank 42 (output on the producing node) are not separate specs. `agentExecutionLifecycle.spec.ts` and the stop spec already cover them with the same steps. - The rank-98 agent-panel half (the reply presenting a result link) is deferred until a recorded conversation or a product contract for result links exists. - Product gap, not asserted: for a server-submitted run, `execution_error` does not open the error dialog, because `executionStore.runErrorKeyForJob` cannot resolve a workflow path for the job and buffers the error as unattributable. The queue row details are the surface that does show it. - Verified locally against a cloud dev server at the current head: all four specs pass, with the rank-79 second case failing exactly where it declares it will. The stop spec's empty-cancel-list assertion is proven non-vacuous two ways — mutating Stop to also call `api.interrupt` fails it, and a positive control that issues `/api/interrupt` from the page records it. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-24T02:34:10.773Z",
"gitSha": "2ee85457fe9f799a4babb62bc7525a35a64e7d39",
"branch": "backport-18803-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.4630000000157,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.432,
"layouts": 10,
"layoutDurationMs": 2.975,
"taskDurationMs": 470.887,
"heapDeltaBytes": 5331792,
"heapUsedBytes": 103986568,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 13.171000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2026.843000000099,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1360000000000006,
"layouts": 9,
"layoutDurationMs": 2.6889999999999996,
"taskDurationMs": 351.354,
"heapDeltaBytes": 3767296,
"heapUsedBytes": 94261240,
"domNodes": -200,
"jsHeapTotalBytes": 1630208,
"scriptDurationMs": 11.286000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.2879999999873,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.584999999999997,
"layouts": 9,
"layoutDurationMs": 2.6569999999999996,
"taskDurationMs": 704.751,
"heapDeltaBytes": 4581500,
"heapUsedBytes": 94432492,
"domNodes": -180,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 140.183,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.8499999999976,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.079999999999998,
"layouts": 10,
"layoutDurationMs": 2.6229999999999998,
"taskDurationMs": 685.927,
"heapDeltaBytes": -876100,
"heapUsedBytes": 89811312,
"domNodes": -204,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 123.06599999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.2620000000197,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.558999999999999,
"layouts": 12,
"layoutDurationMs": 3.1750000000000003,
"taskDurationMs": 332.819,
"heapDeltaBytes": 5014592,
"heapUsedBytes": 109099252,
"domNodes": 47,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 14.754,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.6649999999117,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.975999999999999,
"layouts": 11,
"layoutDurationMs": 2.747,
"taskDurationMs": 299.31,
"heapDeltaBytes": 24134152,
"heapUsedBytes": 113946880,
"domNodes": 47,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.204999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 515.8840000000282,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.227,
"layouts": 10,
"layoutDurationMs": 2.4819999999999998,
"taskDurationMs": 341.98699999999997,
"heapDeltaBytes": 4028272,
"heapUsedBytes": 103790860,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 111.241,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66774193548388,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 527.4340000000848,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.031,
"layouts": 9,
"layoutDurationMs": 2.405,
"taskDurationMs": 339.90500000000003,
"heapDeltaBytes": 5707028,
"heapUsedBytes": 96009568,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 112.996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 982.2480000000269,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.75,
"heapDeltaBytes": -15331344,
"heapUsedBytes": 102161960,
"domNodes": -230,
"jsHeapTotalBytes": 15007744,
"scriptDurationMs": 43.974999999999994,
"eventListeners": -168,
"totalBlockingTimeMs": 316,
"frameDurationMs": 27.313888888888894,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 939.8610000000645,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.1769999999999,
"heapDeltaBytes": -4426972,
"heapUsedBytes": 102249108,
"domNodes": -230,
"jsHeapTotalBytes": 8822784,
"scriptDurationMs": 41.68799999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 265,
"frameDurationMs": 25.22702702702704,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 696.548000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.7810000000002,
"heapDeltaBytes": -3421476,
"heapUsedBytes": 90398708,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 101.86300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 96,
"frameDurationMs": 21.209090909090897,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 701.8219999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 302.632,
"heapDeltaBytes": -2128256,
"heapUsedBytes": 95524896,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.48799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 90,
"frameDurationMs": 20.58529411764705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6945.6330000000435,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5799.2519999999995,
"heapDeltaBytes": 55939000,
"heapUsedBytes": 144899600,
"domNodes": -276,
"jsHeapTotalBytes": 35651584,
"scriptDurationMs": 4474.2609999999995,
"eventListeners": -4,
"totalBlockingTimeMs": 35,
"frameDurationMs": 21.801886792452834,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6392.971999999986,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8209999999999988,
"layouts": 2,
"layoutDurationMs": 0.6260000000000002,
"taskDurationMs": 5166.523000000001,
"heapDeltaBytes": 34245688,
"heapUsedBytes": 142999884,
"domNodes": -276,
"jsHeapTotalBytes": 28893184,
"scriptDurationMs": 3960.6449999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.700925925925926,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6756.62200000005,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9030000000000001,
"layouts": 3,
"layoutDurationMs": 0.7769999999999999,
"taskDurationMs": 5829.045,
"heapDeltaBytes": 17256108,
"heapUsedBytes": 126084428,
"domNodes": -277,
"jsHeapTotalBytes": 27582464,
"scriptDurationMs": 4329.103,
"eventListeners": -130,
"totalBlockingTimeMs": 99,
"frameDurationMs": 20.453939393939393,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6596.416000000034,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6110000000000004,
"layouts": 2,
"layoutDurationMs": 4.364,
"taskDurationMs": 5726.0419999999995,
"heapDeltaBytes": 47440620,
"heapUsedBytes": 151333716,
"domNodes": -296,
"jsHeapTotalBytes": 26009600,
"scriptDurationMs": 4307.362999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 70,
"frameDurationMs": 21.304530744336567,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 144.71500000001924,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.291,
"layouts": 12,
"layoutDurationMs": 3.032,
"taskDurationMs": 103.06299999999999,
"heapDeltaBytes": 13359468,
"heapUsedBytes": 118327800,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 5.88,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 156.12899999996444,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.805,
"layouts": 13,
"layoutDurationMs": 3.4570000000000003,
"taskDurationMs": 113.65899999999998,
"heapDeltaBytes": 13327224,
"heapUsedBytes": 118746720,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.229,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.73750000000001,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2043.266000000017,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.86,
"layouts": 8,
"layoutDurationMs": 2.4349999999999996,
"taskDurationMs": 528.077,
"heapDeltaBytes": -543520,
"heapUsedBytes": 101997716,
"domNodes": -296,
"jsHeapTotalBytes": -2289664,
"scriptDurationMs": 31.249,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.5820000000758,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.282,
"layouts": 10,
"layoutDurationMs": 2.88,
"taskDurationMs": 497.513,
"heapDeltaBytes": -438176,
"heapUsedBytes": 101904892,
"domNodes": -276,
"jsHeapTotalBytes": -1241088,
"scriptDurationMs": 30.444,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3067.872999999963,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.996,
"layouts": 8,
"layoutDurationMs": 2.143,
"taskDurationMs": 1406.2160000000001,
"heapDeltaBytes": -1125160,
"heapUsedBytes": 102917004,
"domNodes": -297,
"jsHeapTotalBytes": -1015808,
"scriptDurationMs": 619.817,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092897,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2916.1510000000135,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.189999999999998,
"layouts": 7,
"layoutDurationMs": 1.834,
"taskDurationMs": 1325.014,
"heapDeltaBytes": -14540788,
"heapUsedBytes": 108841300,
"domNodes": -296,
"jsHeapTotalBytes": 151552,
"scriptDurationMs": 620.8710000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3402.0610000000033,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.396999999999998,
"layouts": 66,
"layoutDurationMs": 13.158,
"taskDurationMs": 1297.7660000000003,
"heapDeltaBytes": 6464400,
"heapUsedBytes": 120201376,
"domNodes": 24,
"jsHeapTotalBytes": 5771264,
"scriptDurationMs": 619.377,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3853.1719999999723,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.257,
"layouts": 66,
"layoutDurationMs": 12.423,
"taskDurationMs": 1388.3329999999999,
"heapDeltaBytes": -542608,
"heapUsedBytes": 106692756,
"domNodes": -272,
"jsHeapTotalBytes": -1802240,
"scriptDurationMs": 583.414,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666233766233766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2957.978999999966,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.801,
"layouts": 7,
"layoutDurationMs": 1.9269999999999998,
"taskDurationMs": 1574.584,
"heapDeltaBytes": 16006576,
"heapUsedBytes": 123647784,
"domNodes": 0,
"jsHeapTotalBytes": 5664768,
"scriptDurationMs": 764.354,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759887005649716,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2341.9810000000325,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.0920000000000005,
"layouts": 8,
"layoutDurationMs": 2.0789999999999997,
"taskDurationMs": 1371.587,
"heapDeltaBytes": -11664732,
"heapUsedBytes": 102984064,
"domNodes": 0,
"jsHeapTotalBytes": 7081984,
"scriptDurationMs": 722.994,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2053.8380000000416,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.948,
"layouts": 10,
"layoutDurationMs": 2.6130000000000004,
"taskDurationMs": 523.8230000000001,
"heapDeltaBytes": -25524748,
"heapUsedBytes": 86212852,
"domNodes": -276,
"jsHeapTotalBytes": -2039808,
"scriptDurationMs": 33.152,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2038.9570000000958,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.947,
"layouts": 9,
"layoutDurationMs": 2.4389999999999996,
"taskDurationMs": 474.5880000000001,
"heapDeltaBytes": -26887276,
"heapUsedBytes": 93361632,
"domNodes": -276,
"jsHeapTotalBytes": -2682880,
"scriptDurationMs": 31.348999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.052999999968,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.425,
"layouts": 9,
"layoutDurationMs": 2.5989999999999998,
"taskDurationMs": 355.896,
"heapDeltaBytes": 22552952,
"heapUsedBytes": 113353388,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 112.89099999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.4700000000739,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.68,
"layouts": 9,
"layoutDurationMs": 2.997,
"taskDurationMs": 320.74399999999997,
"heapDeltaBytes": 2697352,
"heapUsedBytes": 109399104,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 105.25,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2025.459000000012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.798,
"layouts": 10,
"layoutDurationMs": 2.995,
"taskDurationMs": 508.91299999999995,
"heapDeltaBytes": -20495672,
"heapUsedBytes": 86108132,
"domNodes": -218,
"jsHeapTotalBytes": 1642496,
"scriptDurationMs": 12.687999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6672131147541,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.3809999999012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.015,
"layouts": 9,
"layoutDurationMs": 2.5090000000000003,
"taskDurationMs": 443.36099999999993,
"heapDeltaBytes": 1438188,
"heapUsedBytes": 92812536,
"domNodes": -218,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 10.420999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.3320000000272,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.586,
"layouts": 9,
"layoutDurationMs": 2.4770000000000003,
"taskDurationMs": 648.9130000000001,
"heapDeltaBytes": 140424,
"heapUsedBytes": 90950828,
"domNodes": -210,
"jsHeapTotalBytes": 3203072,
"scriptDurationMs": 102.91300000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.5549999999757,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.952000000000002,
"layouts": 11,
"layoutDurationMs": 2.8770000000000002,
"taskDurationMs": 580.8050000000001,
"heapDeltaBytes": 5292960,
"heapUsedBytes": 96468420,
"domNodes": -198,
"jsHeapTotalBytes": 2678784,
"scriptDurationMs": 93.65499999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1335.347000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.251,
"layouts": 5,
"layoutDurationMs": 10.454,
"taskDurationMs": 824.9390000000001,
"heapDeltaBytes": 9239384,
"heapUsedBytes": 132272448,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 27.679999999999996,
"eventListeners": 3244,
"totalBlockingTimeMs": 94,
"frameDurationMs": 18.49041095890411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8762.487999999961,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.36,
"layouts": 9,
"layoutDurationMs": 2.374,
"taskDurationMs": 4472.514,
"heapDeltaBytes": 4137088,
"heapUsedBytes": 114188556,
"domNodes": -296,
"jsHeapTotalBytes": -241664,
"scriptDurationMs": 2181.61,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665969581749053,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9777.83199999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.947,
"layouts": 10,
"layoutDurationMs": 2.609,
"taskDurationMs": 4617.571,
"heapDeltaBytes": 3666328,
"heapUsedBytes": 114790136,
"domNodes": -296,
"jsHeapTotalBytes": 20480,
"scriptDurationMs": 2043.0790000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66609880749574,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17502.64999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16977.111999999997,
"heapDeltaBytes": 257378236,
"heapUsedBytes": 610523824,
"domNodes": -3344,
"jsHeapTotalBytes": 263704576,
"scriptDurationMs": 240.12800000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.539790575916236,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 15858.316000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15216.082,
"heapDeltaBytes": -4390944,
"heapUsedBytes": 302220500,
"domNodes": -3344,
"jsHeapTotalBytes": 22269952,
"scriptDurationMs": 214.729,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.864561403508773,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 19295.904000000006,
"styleRecalcs": 149,
"styleRecalcDurationMs": 22.615000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18934.642,
"heapDeltaBytes": -28245020,
"heapUsedBytes": 289128680,
"domNodes": -3344,
"jsHeapTotalBytes": 20697088,
"scriptDurationMs": 692.0039999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 35.90315985130112,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18798.199999999953,
"styleRecalcs": 139,
"styleRecalcDurationMs": 18.651,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18517.666999999998,
"heapDeltaBytes": -49915136,
"heapUsedBytes": 281573528,
"domNodes": -3344,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 649.918,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 35.20468164794006,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6154.904999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.22100000000001,
"layouts": 20,
"layoutDurationMs": 24.25100000000001,
"taskDurationMs": 6046.241,
"heapDeltaBytes": -1599108,
"heapUsedBytes": 309762988,
"domNodes": -3344,
"jsHeapTotalBytes": 27250688,
"scriptDurationMs": 97.07,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.85116279069768,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4779.867999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.314,
"layouts": 20,
"layoutDurationMs": 33.375,
"taskDurationMs": 4644.919000000001,
"heapDeltaBytes": -20336956,
"heapUsedBytes": 299682276,
"domNodes": -3344,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 75.234,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.47083333333333,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8448.949000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8129.088000000002,
"heapDeltaBytes": -16080308,
"heapUsedBytes": 277349324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.44599999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 7,
"frameDurationMs": 30.069750889679725,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8108.5449999999355,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7673.860999999999,
"heapDeltaBytes": 3238208,
"heapUsedBytes": 288934580,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 103.34000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.221602787456447,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 443.7939999999685,
"styleRecalcs": 15,
"styleRecalcDurationMs": 10.013000000000002,
"layouts": 12,
"layoutDurationMs": 3.595,
"taskDurationMs": 100.289,
"heapDeltaBytes": 7204068,
"heapUsedBytes": 97247352,
"domNodes": 100,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.804999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 445.20700000009583,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.573999999999999,
"layouts": 12,
"layoutDurationMs": 3.3369999999999997,
"taskDurationMs": 88.48100000000001,
"heapDeltaBytes": -13097196,
"heapUsedBytes": 88925132,
"domNodes": 95,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.549000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 211.35099999992235,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5900000000000001,
"layouts": 76,
"layoutDurationMs": 10.308,
"taskDurationMs": 171.18999999999997,
"heapDeltaBytes": -18304640,
"heapUsedBytes": 69970864,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 70.573,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 222.33600000004117,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.714,
"layouts": 76,
"layoutDurationMs": 11.325999999999999,
"taskDurationMs": 185.12599999999998,
"heapDeltaBytes": 9445188,
"heapUsedBytes": 97915844,
"domNodes": 4,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 75.815,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 248.8459999999577,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.517,
"layouts": 76,
"layoutDurationMs": 9.862,
"taskDurationMs": 208.758,
"heapDeltaBytes": -7022728,
"heapUsedBytes": 100195704,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 63.762,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 292.0410000000402,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8339999999999999,
"layouts": 76,
"layoutDurationMs": 11.341000000000001,
"taskDurationMs": 246.127,
"heapDeltaBytes": -1721888,
"heapUsedBytes": 115010624,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 82.60500000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2971 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6465ca75011f5c44be7a941e6ff3cef7751c92c3
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (120)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #21876 +/- ##
=============================================
Coverage ? 85.78%
=============================================
Files ? 2588
Lines ? 134835
Branches ? 38723
=============================================
Hits ? 115673
Misses ? 18745
Partials ? 417
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #18803 to
cloud/1.58Automatically created by backport workflow.