Repository navigation
[backport core/1.58] test(agent): user-story specs — stop survives, output surfaces, failure/stall surfaced, finished-generation preview - #21875
Conversation
…re/stall surfaced, finished-generation preview (#18803) ## Summary Adds black-box user-story specs on the agent harness execution surface (#18790), stacked on the rank-26 golden path (#18802), and extends the golden path with the finished run's history-row thumbnail. ## Changes - **What**: - `agentStopKeepsServerRunAlive.spec.ts` (rank 41): Stop cancels the agent's turn but sends no job interrupt or cancel request, and the submitted job keeps its executing outline. The story fixture records `/api/interrupt`, `/api/jobs/cancel` and `/api/jobs/{id}/cancel` as `jobCancelRequests()`, and accepts the turn-cancel request. - `agentFailedRunIsSurfaced.spec.ts` (rank 99, failure half): a server-submitted run that fails after the turn ends shows its error message in the queue row's details popover, and the agent panel stays idle. - `agentGoldenPathRunIt.spec.ts` (rank 98, fixture-supported half): the finished run's history row renders a thumbnail served from that run's output. - `agentJobReopenedAsWorkflow.spec.ts` (rank 79, folds #18936): "open as workflow" rebuilds the graph when the job carries one, and — as a declared expected failure — says nothing at all when it does not. - All four live beside their fixture in `browser_tests/tests/agent/`. ## Review Focus - **Why the fixture moved.** The fixture and its execution helper additions are used only by the four specs in this PR, so they now live next to them in `browser_tests/tests/agent/` instead of in `browser_tests/fixtures/` — the same shape as `agentPanelMocks.ts` and `agentCreditsExhaustionLifecycleMocks.ts`, which are already `agentTest.extend` fixtures under `tests/agent/`. CODEOWNERS already scoped both files to `@Comfy-Org/agent_devs` through `/browser_tests/fixtures/**/*gent*`, so this does not change who owns them; it only makes the paths agree with that ownership. The branch ruleset's narrower `browser_tests/fixtures/data/agent/**` glob did not cover them, which is why the earlier layout pulled an Agent-test-only PR into the shared-path reviewer entry. - The two story-only additions to the execution surface — the job interrupt/cancel recorder and a per-job `GET /api/jobs/{id}` detail route — are now a subclass in the story fixture rather than changes to the shared `AgentExecutionHelper`, which `agentExecutionFixture.ts` and `agentExecutionLifecycle.spec.ts` also consume. This PR no longer modifies that shared helper. - The stalled-run half of rank 99 and rank 42 (output on the producing node) are not separate specs. `agentExecutionLifecycle.spec.ts` and the stop spec already cover them with the same steps. - The rank-98 agent-panel half (the reply presenting a result link) is deferred until a recorded conversation or a product contract for result links exists. - Product gap, not asserted: for a server-submitted run, `execution_error` does not open the error dialog, because `executionStore.runErrorKeyForJob` cannot resolve a workflow path for the job and buffers the error as unattributable. The queue row details are the surface that does show it. - Verified locally against a cloud dev server at the current head: all four specs pass, with the rank-79 second case failing exactly where it declares it will. The stop spec's empty-cancel-list assertion is proven non-vacuous two ways — mutating Stop to also call `api.interrupt` fails it, and a positive control that issues `/api/interrupt` from the page records it. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-24T02:36:53.035Z",
"gitSha": "d58a02409e813f068678b796b6cca2dd0ff5e282",
"branch": "backport-18803-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2052.4660000000094,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0609999999999995,
"layouts": 9,
"layoutDurationMs": 3.2219999999999995,
"taskDurationMs": 546.975,
"heapDeltaBytes": 1752516,
"heapUsedBytes": 91950660,
"domNodes": -200,
"jsHeapTotalBytes": 1105920,
"scriptDurationMs": 14.047,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2040.7399999999711,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1839999999999993,
"layouts": 9,
"layoutDurationMs": 2.9149999999999996,
"taskDurationMs": 558.0769999999999,
"heapDeltaBytes": 2991592,
"heapUsedBytes": 93685100,
"domNodes": -200,
"jsHeapTotalBytes": 2678784,
"scriptDurationMs": 15.777,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1791.9610000000148,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.642000000000003,
"layouts": 9,
"layoutDurationMs": 2.319,
"taskDurationMs": 887.4029999999999,
"heapDeltaBytes": 660304,
"heapUsedBytes": 90856304,
"domNodes": -200,
"jsHeapTotalBytes": 2678784,
"scriptDurationMs": 180.091,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1842.8829999999152,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.625,
"layouts": 9,
"layoutDurationMs": 2.858,
"taskDurationMs": 981.537,
"heapDeltaBytes": -2891860,
"heapUsedBytes": 96911940,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 174.8,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.5469999999964,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.486000000000001,
"layouts": 11,
"layoutDurationMs": 2.915,
"taskDurationMs": 309.753,
"heapDeltaBytes": -1335428,
"heapUsedBytes": 88391228,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 12.045,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1757.7740000000404,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.563000000000001,
"layouts": 11,
"layoutDurationMs": 3.045,
"taskDurationMs": 477.356,
"heapDeltaBytes": -1359876,
"heapUsedBytes": 89355552,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 15.799999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 731.3019999999995,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.883,
"layouts": 8,
"layoutDurationMs": 2.448,
"taskDurationMs": 515.3969999999999,
"heapDeltaBytes": 4176304,
"heapUsedBytes": 94260152,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 172.263,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 768.9320000000635,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.6370000000000005,
"layouts": 7,
"layoutDurationMs": 2.245,
"taskDurationMs": 525.795,
"heapDeltaBytes": 4215040,
"heapUsedBytes": 94656448,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 174.16899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667391304347824,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1242.7649999999915,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 974.221,
"heapDeltaBytes": -15536120,
"heapUsedBytes": 102081628,
"domNodes": -230,
"jsHeapTotalBytes": 15794176,
"scriptDurationMs": 72.02300000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 538,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1308.2549999999742,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1053.019,
"heapDeltaBytes": -9363936,
"heapUsedBytes": 102442356,
"domNodes": -231,
"jsHeapTotalBytes": 8286208,
"scriptDurationMs": 72.03699999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 613,
"frameDurationMs": 35.132432432432424,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.3670000000113,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.9200000000001,
"heapDeltaBytes": -2821680,
"heapUsedBytes": 98208252,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 172.298,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 873.8539999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.7719999999998,
"heapDeltaBytes": -3477140,
"heapUsedBytes": 96943068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.667,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11031.362000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10105.426,
"heapDeltaBytes": 47869776,
"heapUsedBytes": 151669484,
"domNodes": -276,
"jsHeapTotalBytes": 36233216,
"scriptDurationMs": 8020.089000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1126,
"frameDurationMs": 32.16228070175439,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11021.815000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10184.397,
"heapDeltaBytes": -199528,
"heapUsedBytes": 119736436,
"domNodes": -276,
"jsHeapTotalBytes": -3518464,
"scriptDurationMs": 8234.756,
"eventListeners": -130,
"totalBlockingTimeMs": 1190,
"frameDurationMs": 30.911452513966484,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10562.17000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9783.592999999999,
"heapDeltaBytes": 44279020,
"heapUsedBytes": 153353988,
"domNodes": -297,
"jsHeapTotalBytes": 39116800,
"scriptDurationMs": 8136.396000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 1234,
"frameDurationMs": 31.77590361445783,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10489.84200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9674.292999999998,
"heapDeltaBytes": -24955360,
"heapUsedBytes": 96763080,
"domNodes": -276,
"jsHeapTotalBytes": -634880,
"scriptDurationMs": 7791.794,
"eventListeners": -130,
"totalBlockingTimeMs": 1021,
"frameDurationMs": 31.11976401179941,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 217.60100000000193,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.290999999999999,
"layouts": 11,
"layoutDurationMs": 3.165,
"taskDurationMs": 167.85999999999999,
"heapDeltaBytes": 13337416,
"heapUsedBytes": 118532136,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.400999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 247.35700000002225,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.580000000000002,
"layouts": 12,
"layoutDurationMs": 3.953,
"taskDurationMs": 192.037,
"heapDeltaBytes": 15513596,
"heapUsedBytes": 120976212,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.453999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2041.3599999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.751000000000001,
"layouts": 8,
"layoutDurationMs": 2.368,
"taskDurationMs": 524.567,
"heapDeltaBytes": 1194852,
"heapUsedBytes": 111472072,
"domNodes": -296,
"jsHeapTotalBytes": -729088,
"scriptDurationMs": 36.201,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2055.212000000097,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8839999999999995,
"layouts": 8,
"layoutDurationMs": 2.8970000000000002,
"taskDurationMs": 741.479,
"heapDeltaBytes": -21812344,
"heapUsedBytes": 99127292,
"domNodes": -276,
"jsHeapTotalBytes": -1908736,
"scriptDurationMs": 36.019999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2890.410999999972,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.181999999999999,
"layouts": 7,
"layoutDurationMs": 2.298,
"taskDurationMs": 1845.475,
"heapDeltaBytes": -6882868,
"heapUsedBytes": 104608232,
"domNodes": -296,
"jsHeapTotalBytes": -503808,
"scriptDurationMs": 867.0139999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.860818713450293,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2258.1769999999324,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.214,
"layouts": 6,
"layoutDurationMs": 1.7690000000000001,
"taskDurationMs": 1617,
"heapDeltaBytes": -623748,
"heapUsedBytes": 110725220,
"domNodes": -296,
"jsHeapTotalBytes": 282624,
"scriptDurationMs": 829.013,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.789629629629626,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3642.6349999999843,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.629999999999999,
"layouts": 65,
"layoutDurationMs": 11.424999999999999,
"taskDurationMs": 1659.9909999999998,
"heapDeltaBytes": -17376092,
"heapUsedBytes": 95561312,
"domNodes": -272,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 783.327,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3636.3020000000006,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.638,
"layouts": 64,
"layoutDurationMs": 11.166,
"taskDurationMs": 1716.857,
"heapDeltaBytes": -31669620,
"heapUsedBytes": 92747264,
"domNodes": -272,
"jsHeapTotalBytes": -1253376,
"scriptDurationMs": 820.581,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.742396313364058,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3062.5510000000418,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.558999999999999,
"layouts": 5,
"layoutDurationMs": 1.4100000000000001,
"taskDurationMs": 2023.2290000000003,
"heapDeltaBytes": 21920644,
"heapUsedBytes": 129503024,
"domNodes": 0,
"jsHeapTotalBytes": 5664768,
"scriptDurationMs": 979.4600000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.034254143646404,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3148.6119999999573,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.665000000000001,
"layouts": 5,
"layoutDurationMs": 1.3869999999999998,
"taskDurationMs": 1916.062,
"heapDeltaBytes": -23260752,
"heapUsedBytes": 91595016,
"domNodes": 0,
"jsHeapTotalBytes": 1236992,
"scriptDurationMs": 1045.782,
"eventListeners": 182,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.206486486486487,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2061.8860000000154,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2630000000000003,
"layouts": 8,
"layoutDurationMs": 2.371,
"taskDurationMs": 518.9910000000001,
"heapDeltaBytes": 943412,
"heapUsedBytes": 113386848,
"domNodes": -276,
"jsHeapTotalBytes": -466944,
"scriptDurationMs": 35.634,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2075.392000000079,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2649999999999997,
"layouts": 6,
"layoutDurationMs": 2.439,
"taskDurationMs": 800.7370000000001,
"heapDeltaBytes": -33664992,
"heapUsedBytes": 90381200,
"domNodes": -296,
"jsHeapTotalBytes": -585728,
"scriptDurationMs": 41.312999999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.4679999999776,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.254,
"layouts": 9,
"layoutDurationMs": 2.666,
"taskDurationMs": 402.69300000000004,
"heapDeltaBytes": 785720,
"heapUsedBytes": 102617936,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 149.35000000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.15588235294117,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.4309999999523,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.128,
"layouts": 10,
"layoutDurationMs": 3.024,
"taskDurationMs": 416.617,
"heapDeltaBytes": -1374204,
"heapUsedBytes": 89857244,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 153.377,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2055.133000000012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.416999999999999,
"layouts": 10,
"layoutDurationMs": 3.0950000000000006,
"taskDurationMs": 646.4250000000001,
"heapDeltaBytes": -10597832,
"heapUsedBytes": 98422912,
"domNodes": -198,
"jsHeapTotalBytes": 7229440,
"scriptDurationMs": 10.387000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2049.0330000000085,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.7689999999999997,
"layouts": 7,
"layoutDurationMs": 2.516,
"taskDurationMs": 685.919,
"heapDeltaBytes": 2699128,
"heapUsedBytes": 93978088,
"domNodes": -218,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 12.683999999999997,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.777999999987,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.667,
"layouts": 8,
"layoutDurationMs": 2.2300000000000004,
"taskDurationMs": 776.953,
"heapDeltaBytes": -1502736,
"heapUsedBytes": 88985048,
"domNodes": -210,
"jsHeapTotalBytes": 2678784,
"scriptDurationMs": 117.43400000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2024.8699999999644,
"styleRecalcs": 89,
"styleRecalcDurationMs": 16.988,
"layouts": 9,
"layoutDurationMs": 3.0940000000000003,
"taskDurationMs": 1195.08,
"heapDeltaBytes": -23912896,
"heapUsedBytes": 82710856,
"domNodes": -210,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 121.535,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1470.181000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 27.095000000000002,
"layouts": 5,
"layoutDurationMs": 16.816000000000003,
"taskDurationMs": 1143.3210000000001,
"heapDeltaBytes": 9141768,
"heapUsedBytes": 132633792,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 32.686,
"eventListeners": 3244,
"totalBlockingTimeMs": 167,
"frameDurationMs": 19.77600000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8610.670999999968,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.686999999999998,
"layouts": 7,
"layoutDurationMs": 2.3359999999999994,
"taskDurationMs": 5660.351,
"heapDeltaBytes": 8965996,
"heapUsedBytes": 119585008,
"domNodes": -297,
"jsHeapTotalBytes": -1323008,
"scriptDurationMs": 2952.0939999999996,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.730679611650487,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8376.112000000034,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.809000000000005,
"layouts": 9,
"layoutDurationMs": 2.467,
"taskDurationMs": 5713.668000000001,
"heapDeltaBytes": -20367524,
"heapUsedBytes": 90031528,
"domNodes": -296,
"jsHeapTotalBytes": -729088,
"scriptDurationMs": 2815.698,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699203187250998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23232.084000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22679.354,
"heapDeltaBytes": -56232484,
"heapUsedBytes": 273412972,
"domNodes": -3344,
"jsHeapTotalBytes": -16265216,
"scriptDurationMs": 319.084,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.474564459930306,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16288.643999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15608.972000000002,
"heapDeltaBytes": -55852228,
"heapUsedBytes": 274063592,
"domNodes": -3344,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 252.28,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.84060283687943,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 19153.19699999998,
"styleRecalcs": 132,
"styleRecalcDurationMs": 14.751999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18792.057,
"heapDeltaBytes": -3648780,
"heapUsedBytes": 306918480,
"domNodes": -3344,
"jsHeapTotalBytes": 14860288,
"scriptDurationMs": 853.165,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 35.824112149532716,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19384.27300000001,
"styleRecalcs": 153,
"styleRecalcDurationMs": 17.912999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19054.482,
"heapDeltaBytes": 6185576,
"heapUsedBytes": 311597108,
"domNodes": -3344,
"jsHeapTotalBytes": 15646720,
"scriptDurationMs": 867.168,
"eventListeners": -651,
"totalBlockingTimeMs": 8,
"frameDurationMs": 36.161380597014926,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8315.40799999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.96299999999997,
"layouts": 20,
"layoutDurationMs": 22.41399999999999,
"taskDurationMs": 8209.009999999998,
"heapDeltaBytes": -12224084,
"heapUsedBytes": 293112408,
"domNodes": -3344,
"jsHeapTotalBytes": 4706304,
"scriptDurationMs": 124.41,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.35058139534883,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6017.548000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.78699999999998,
"layouts": 20,
"layoutDurationMs": 25.588,
"taskDurationMs": 5915.424000000001,
"heapDeltaBytes": -41530020,
"heapUsedBytes": 268662272,
"domNodes": -307,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 100.81099999999999,
"eventListeners": -7,
"totalBlockingTimeMs": 20,
"frameDurationMs": 36.46363636363636,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8200.377000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7737.585999999998,
"heapDeltaBytes": -8663540,
"heapUsedBytes": 282349260,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 126.78900000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.89013605442177,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11401.8870000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11153.9,
"heapDeltaBytes": -19699832,
"heapUsedBytes": 268455680,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.00799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.308965517241376,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 145.20200000004024,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.292,
"layouts": 10,
"layoutDurationMs": 4.146999999999999,
"taskDurationMs": 106.297,
"heapDeltaBytes": 4853820,
"heapUsedBytes": 102250700,
"domNodes": 99,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.437000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999955,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 102.25100000002385,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.748,
"layouts": 6,
"layoutDurationMs": 2.786,
"taskDurationMs": 71.795,
"heapDeltaBytes": 4594976,
"heapUsedBytes": 94743404,
"domNodes": 116,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.656000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 509.77100000000064,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.725,
"layouts": 76,
"layoutDurationMs": 16.819,
"taskDurationMs": 458.788,
"heapDeltaBytes": 12139848,
"heapUsedBytes": 81219636,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 223.242,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 458.3380000000261,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7020000000000001,
"layouts": 76,
"layoutDurationMs": 15.046000000000001,
"taskDurationMs": 407.616,
"heapDeltaBytes": 11604324,
"heapUsedBytes": 80943480,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 194.813,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 596.6670000000249,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.359,
"layouts": 76,
"layoutDurationMs": 14.334,
"taskDurationMs": 538.116,
"heapDeltaBytes": 730144,
"heapUsedBytes": 117640932,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 217.808,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 632.6609999999846,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.414,
"layouts": 76,
"layoutDurationMs": 16.485,
"taskDurationMs": 595.587,
"heapDeltaBytes": 1888640,
"heapUsedBytes": 123093372,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 245.311,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2968 passed, 0 failed · 2 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c6995b2736d902205e145c991110c784ddf8206a
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (116)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #21875 +/- ##
============================================
Coverage 84.49% 84.49%
============================================
Files 2931 2931
Lines 160912 160912
Branches 39201 41401 +2200
============================================
Hits 135962 135962
Misses 24559 24559
Partials 391 391
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #18803 to
core/1.58Automatically created by backport workflow.