Repository navigation
[backport cloud/1.57] test(agent): user-story specs — stop survives, output surfaces, failure/stall surfaced, finished-generation preview - #21874
Conversation
…re/stall surfaced, finished-generation preview (#18803) ## Summary Adds black-box user-story specs on the agent harness execution surface (#18790), stacked on the rank-26 golden path (#18802), and extends the golden path with the finished run's history-row thumbnail. ## Changes - **What**: - `agentStopKeepsServerRunAlive.spec.ts` (rank 41): Stop cancels the agent's turn but sends no job interrupt or cancel request, and the submitted job keeps its executing outline. The story fixture records `/api/interrupt`, `/api/jobs/cancel` and `/api/jobs/{id}/cancel` as `jobCancelRequests()`, and accepts the turn-cancel request. - `agentFailedRunIsSurfaced.spec.ts` (rank 99, failure half): a server-submitted run that fails after the turn ends shows its error message in the queue row's details popover, and the agent panel stays idle. - `agentGoldenPathRunIt.spec.ts` (rank 98, fixture-supported half): the finished run's history row renders a thumbnail served from that run's output. - `agentJobReopenedAsWorkflow.spec.ts` (rank 79, folds #18936): "open as workflow" rebuilds the graph when the job carries one, and — as a declared expected failure — says nothing at all when it does not. - All four live beside their fixture in `browser_tests/tests/agent/`. ## Review Focus - **Why the fixture moved.** The fixture and its execution helper additions are used only by the four specs in this PR, so they now live next to them in `browser_tests/tests/agent/` instead of in `browser_tests/fixtures/` — the same shape as `agentPanelMocks.ts` and `agentCreditsExhaustionLifecycleMocks.ts`, which are already `agentTest.extend` fixtures under `tests/agent/`. CODEOWNERS already scoped both files to `@Comfy-Org/agent_devs` through `/browser_tests/fixtures/**/*gent*`, so this does not change who owns them; it only makes the paths agree with that ownership. The branch ruleset's narrower `browser_tests/fixtures/data/agent/**` glob did not cover them, which is why the earlier layout pulled an Agent-test-only PR into the shared-path reviewer entry. - The two story-only additions to the execution surface — the job interrupt/cancel recorder and a per-job `GET /api/jobs/{id}` detail route — are now a subclass in the story fixture rather than changes to the shared `AgentExecutionHelper`, which `agentExecutionFixture.ts` and `agentExecutionLifecycle.spec.ts` also consume. This PR no longer modifies that shared helper. - The stalled-run half of rank 99 and rank 42 (output on the producing node) are not separate specs. `agentExecutionLifecycle.spec.ts` and the stop spec already cover them with the same steps. - The rank-98 agent-panel half (the reply presenting a result link) is deferred until a recorded conversation or a product contract for result links exists. - Product gap, not asserted: for a server-submitted run, `execution_error` does not open the error dialog, because `executionStore.runErrorKeyForJob` cannot resolve a workflow path for the job and buffers the error as unattributable. The queue row details are the surface that does show it. - Verified locally against a cloud dev server at the current head: all four specs pass, with the rank-79 second case failing exactly where it declares it will. The stop spec's empty-cancel-list assertion is proven non-vacuous two ways — mutating Stop to also call `api.interrupt` fails it, and a positive control that issues `/api/interrupt` from the page records it. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-24T02:37:41.325Z",
"gitSha": "1e01841c25b9cd8294c075414c434996fd3c3ed1",
"branch": "backport-18803-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.697000000041,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8990000000000005,
"layouts": 10,
"layoutDurationMs": 3.0080000000000005,
"taskDurationMs": 528.109,
"heapDeltaBytes": 22198192,
"heapUsedBytes": 88499952,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.887,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2007.663999999977,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2529999999999997,
"layouts": 9,
"layoutDurationMs": 3.444,
"taskDurationMs": 478.633,
"heapDeltaBytes": 22113096,
"heapUsedBytes": 88092532,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 14.858999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1976.6599999999812,
"styleRecalcs": 84,
"styleRecalcDurationMs": 15.940999999999997,
"layouts": 9,
"layoutDurationMs": 2.623,
"taskDurationMs": 1070.962,
"heapDeltaBytes": -7243100,
"heapUsedBytes": 68192008,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 166.578,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666386554621848,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.6230000000332,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.017999999999997,
"layouts": 8,
"layoutDurationMs": 3.234,
"taskDurationMs": 835.89,
"heapDeltaBytes": 15105512,
"heapUsedBytes": 81500992,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 179.79600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66698113207547,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.442000000034,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.702000000000001,
"layouts": 11,
"layoutDurationMs": 2.9229999999999996,
"taskDurationMs": 422.43199999999996,
"heapDeltaBytes": -4556016,
"heapUsedBytes": 70474592,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 14.062000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1781.2719999999445,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.276,
"layouts": 10,
"layoutDurationMs": 2.9810000000000003,
"taskDurationMs": 517.506,
"heapDeltaBytes": -4560224,
"heapUsedBytes": 70576936,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 17.732000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 634.3799999999646,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.6430000000000002,
"layouts": 8,
"layoutDurationMs": 2.786,
"taskDurationMs": 459.113,
"heapDeltaBytes": 25730588,
"heapUsedBytes": 91224448,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 179.416,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 732.8400000000101,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.406,
"layouts": 10,
"layoutDurationMs": 3.2680000000000002,
"taskDurationMs": 492.786,
"heapDeltaBytes": 26496260,
"heapUsedBytes": 92010000,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 185.15300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1200.4059999999868,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 869.293,
"heapDeltaBytes": -13571916,
"heapUsedBytes": 81118644,
"domNodes": -212,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 71.844,
"eventListeners": -106,
"totalBlockingTimeMs": 531,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1256.4660000000458,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 989.283,
"heapDeltaBytes": -12959504,
"heapUsedBytes": 81663820,
"domNodes": -212,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 74.90299999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 558,
"frameDurationMs": 33.78108108108107,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.4709999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.8099999999998,
"heapDeltaBytes": -4474380,
"heapUsedBytes": 75323040,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 173.68300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 25.48823529411763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 874.2069999999558,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.1240000000003,
"heapDeltaBytes": -4058248,
"heapUsedBytes": 77172656,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 166.18799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10976.972999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10057.701,
"heapDeltaBytes": -24475444,
"heapUsedBytes": 75065692,
"domNodes": -258,
"jsHeapTotalBytes": 6942720,
"scriptDurationMs": 8108.012000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1090,
"frameDurationMs": 31.694508670520236,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10889.903000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9925.768000000002,
"heapDeltaBytes": -16774944,
"heapUsedBytes": 83028244,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 8423.867,
"eventListeners": -68,
"totalBlockingTimeMs": 1492,
"frameDurationMs": 32.10294985250737,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10326.563999999962,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0499999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9431.884,
"heapDeltaBytes": -24423308,
"heapUsedBytes": 75231960,
"domNodes": -278,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 7995.924,
"eventListeners": -68,
"totalBlockingTimeMs": 1222,
"frameDurationMs": 32.238125000000004,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10306.246999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9493.909,
"heapDeltaBytes": -16451172,
"heapUsedBytes": 71241520,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 7658.494,
"eventListeners": -68,
"totalBlockingTimeMs": 914,
"frameDurationMs": 30.79462686567164,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 230.73299999998653,
"styleRecalcs": 24,
"styleRecalcDurationMs": 18.098000000000003,
"layouts": 11,
"layoutDurationMs": 3.4290000000000003,
"taskDurationMs": 179.59200000000004,
"heapDeltaBytes": -8132792,
"heapUsedBytes": 79352164,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.383,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 261.97899999999663,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.913999999999998,
"layouts": 11,
"layoutDurationMs": 3.6249999999999996,
"taskDurationMs": 217.434,
"heapDeltaBytes": -7697164,
"heapUsedBytes": 80598476,
"domNodes": 917,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.731000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.08461538461541,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2040.6580000000076,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9979999999999998,
"layouts": 9,
"layoutDurationMs": 2.838,
"taskDurationMs": 651.3420000000001,
"heapDeltaBytes": -5486932,
"heapUsedBytes": 74024616,
"domNodes": -278,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 33.053000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2056.2529999999697,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8389999999999995,
"layouts": 8,
"layoutDurationMs": 2.9019999999999997,
"taskDurationMs": 589.011,
"heapDeltaBytes": -8048696,
"heapUsedBytes": 71757996,
"domNodes": -278,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 42.94199999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2490.8230000000344,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.083,
"layouts": 7,
"layoutDurationMs": 1.6720000000000004,
"taskDurationMs": 1710.32,
"heapDeltaBytes": -30919548,
"heapUsedBytes": 67521392,
"domNodes": -278,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 824.893,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.778378378378385,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2290.9409999999752,
"styleRecalcs": 65,
"styleRecalcDurationMs": 6.167000000000001,
"layouts": 4,
"layoutDurationMs": 1.465,
"taskDurationMs": 1662.736,
"heapDeltaBytes": 8728572,
"heapUsedBytes": 89615128,
"domNodes": -278,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 864.7739999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.913333333333334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3993.4989999999857,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.722,
"layouts": 64,
"layoutDurationMs": 10.81,
"taskDurationMs": 1913.153,
"heapDeltaBytes": 12592880,
"heapUsedBytes": 90136744,
"domNodes": -254,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 816.9380000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666386554621848,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4058.4769999999253,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.015,
"layouts": 64,
"layoutDurationMs": 11.414,
"taskDurationMs": 1978.6490000000001,
"heapDeltaBytes": -14328684,
"heapUsedBytes": 67599460,
"domNodes": -234,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 847.143,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665843621399173,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2835.690999999997,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.957,
"layouts": 4,
"layoutDurationMs": 1.151,
"taskDurationMs": 1769.893,
"heapDeltaBytes": 12302572,
"heapUsedBytes": 95308340,
"domNodes": 0,
"jsHeapTotalBytes": 7233536,
"scriptDurationMs": 966.8389999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.864285714285714,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3225.014000000101,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.692,
"layouts": 6,
"layoutDurationMs": 1.86,
"taskDurationMs": 1988.8909999999998,
"heapDeltaBytes": -6421100,
"heapUsedBytes": 77020728,
"domNodes": 0,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 1051.443,
"eventListeners": 182,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.10421052631579,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.8409999999626,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1729999999999996,
"layouts": 7,
"layoutDurationMs": 1.948,
"taskDurationMs": 622.631,
"heapDeltaBytes": -5128912,
"heapUsedBytes": 76318972,
"domNodes": -278,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 33.117,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2051.965999999993,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.2159999999999993,
"layouts": 6,
"layoutDurationMs": 2.319,
"taskDurationMs": 776.287,
"heapDeltaBytes": -2731272,
"heapUsedBytes": 75026072,
"domNodes": -278,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 41.985,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.1109999999626,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.992000000000001,
"layouts": 9,
"layoutDurationMs": 2.5849999999999995,
"taskDurationMs": 471.97,
"heapDeltaBytes": -1091180,
"heapUsedBytes": 76321680,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 148.359,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.09230769230769,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.8669999999938,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.417,
"layouts": 8,
"layoutDurationMs": 2.4189999999999996,
"taskDurationMs": 424.339,
"heapDeltaBytes": 21135760,
"heapUsedBytes": 89045348,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 156.28400000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.2340000000218,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.289,
"layouts": 11,
"layoutDurationMs": 3.437,
"taskDurationMs": 588.063,
"heapDeltaBytes": -264120,
"heapUsedBytes": 77529672,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.875000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.3890000000047,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.261,
"layouts": 10,
"layoutDurationMs": 3.1679999999999997,
"taskDurationMs": 645.534,
"heapDeltaBytes": -249620,
"heapUsedBytes": 77292628,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 14.746000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1973.1480000000374,
"styleRecalcs": 88,
"styleRecalcDurationMs": 17.46,
"layouts": 10,
"layoutDurationMs": 2.863,
"taskDurationMs": 1079.374,
"heapDeltaBytes": -11372848,
"heapUsedBytes": 66476388,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 115.749,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1975.0400000000354,
"styleRecalcs": 88,
"styleRecalcDurationMs": 19.545999999999996,
"layouts": 9,
"layoutDurationMs": 2.886,
"taskDurationMs": 1119.922,
"heapDeltaBytes": -11358796,
"heapUsedBytes": 66547400,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 124.797,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.6820000000662,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.520000000000003,
"layouts": 5,
"layoutDurationMs": 16.858,
"taskDurationMs": 1071.7969999999998,
"heapDeltaBytes": 7180384,
"heapUsedBytes": 103493636,
"domNodes": 15953,
"jsHeapTotalBytes": 16912384,
"scriptDurationMs": 30.341999999999995,
"eventListeners": 3244,
"totalBlockingTimeMs": 165,
"frameDurationMs": 19.861643835616444,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9552.018000000033,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.013,
"layouts": 8,
"layoutDurationMs": 2.074,
"taskDurationMs": 6107.504000000001,
"heapDeltaBytes": -25714248,
"heapUsedBytes": 71420236,
"domNodes": -278,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 2773.898,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72434325744308,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8491.498999999976,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.602000000000004,
"layouts": 7,
"layoutDurationMs": 2.143,
"taskDurationMs": 5858.579,
"heapDeltaBytes": 4633592,
"heapUsedBytes": 83760080,
"domNodes": -258,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2973.636,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7980198019802,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22962.94599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22356.194000000003,
"heapDeltaBytes": 6176048,
"heapUsedBytes": 287720172,
"domNodes": -3330,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 316.94,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.010178571428575,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 16868.892999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16049.022,
"heapDeltaBytes": -39043212,
"heapUsedBytes": 260474300,
"domNodes": -3330,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 280.851,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.92967409948542,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 28219.67799999999,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.891000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27808.768,
"heapDeltaBytes": -28219320,
"heapUsedBytes": 262570876,
"domNodes": -3330,
"jsHeapTotalBytes": 4968448,
"scriptDurationMs": 904.0600000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 52.44516728624535,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 29003.85099999994,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.371,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28668.447999999997,
"heapDeltaBytes": -24763052,
"heapUsedBytes": 257317296,
"domNodes": -3330,
"jsHeapTotalBytes": 12046336,
"scriptDurationMs": 934.5120000000002,
"eventListeners": -651,
"totalBlockingTimeMs": 48,
"frameDurationMs": 54.50921052631578,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8276.312000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.56699999999996,
"layouts": 20,
"layoutDurationMs": 22.834000000000007,
"taskDurationMs": 8182.2119999999995,
"heapDeltaBytes": -7295864,
"heapUsedBytes": 269126696,
"domNodes": -3330,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 148.044,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.016666666666666,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 8638.555999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.20500000000003,
"layouts": 20,
"layoutDurationMs": 24.362999999999996,
"taskDurationMs": 8505.342,
"heapDeltaBytes": -4474812,
"heapUsedBytes": 267580552,
"domNodes": -3330,
"jsHeapTotalBytes": 14934016,
"scriptDurationMs": 134.19400000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.425714285714285,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8156.016000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7653.324999999999,
"heapDeltaBytes": 178576,
"heapUsedBytes": 250268032,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.367,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.588513513513515,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12192.7740000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11668.024,
"heapDeltaBytes": -18865800,
"heapUsedBytes": 251251680,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 173.02299999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.74666666666666,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 517.9049999999279,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.779,
"layouts": 11,
"layoutDurationMs": 4.308999999999999,
"taskDurationMs": 160.242,
"heapDeltaBytes": -12709856,
"heapUsedBytes": 70815000,
"domNodes": 124,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 18.058999999999997,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.81379310344826,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 165.81700000006094,
"styleRecalcs": 9,
"styleRecalcDurationMs": 12.19,
"layouts": 8,
"layoutDurationMs": 4.035,
"taskDurationMs": 122.78500000000001,
"heapDeltaBytes": 4476532,
"heapUsedBytes": 77157232,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.864999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.5,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 656.0470000000578,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.415,
"layouts": 76,
"layoutDurationMs": 19.654,
"taskDurationMs": 604.191,
"heapDeltaBytes": -19951624,
"heapUsedBytes": 73399388,
"domNodes": 4,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 295.96900000000005,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 564.6039999999175,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.312,
"layouts": 76,
"layoutDurationMs": 19.649,
"taskDurationMs": 512.992,
"heapDeltaBytes": 11724504,
"heapUsedBytes": 85401436,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 238.54799999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 710.2959999999712,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.857,
"layouts": 76,
"layoutDurationMs": 18.849,
"taskDurationMs": 669.115,
"heapDeltaBytes": 2282788,
"heapUsedBytes": 119303660,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 280.195,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.06190476190477,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 689.249000000018,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.727,
"layouts": 76,
"layoutDurationMs": 18.393,
"taskDurationMs": 646.335,
"heapDeltaBytes": 980784,
"heapUsedBytes": 129550472,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 264.57399999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536612,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2283 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 56d6f68564f812c7df1ab4c8bd50a8bfafd7cdfe
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21874 +/- ##
=============================================
Coverage ? 85.19%
=============================================
Files ? 2522
Lines ? 132939
Branches ? 40683
=============================================
Hits ? 113264
Misses ? 19259
Partials ? 416
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #18803 to
cloud/1.57Automatically created by backport workflow.