Repository navigation
[backport core/1.57] test(agent): user-story specs — stop survives, output surfaces, failure/stall surfaced, finished-generation preview - #21873
Conversation
…re/stall surfaced, finished-generation preview (#18803) ## Summary Adds black-box user-story specs on the agent harness execution surface (#18790), stacked on the rank-26 golden path (#18802), and extends the golden path with the finished run's history-row thumbnail. ## Changes - **What**: - `agentStopKeepsServerRunAlive.spec.ts` (rank 41): Stop cancels the agent's turn but sends no job interrupt or cancel request, and the submitted job keeps its executing outline. The story fixture records `/api/interrupt`, `/api/jobs/cancel` and `/api/jobs/{id}/cancel` as `jobCancelRequests()`, and accepts the turn-cancel request. - `agentFailedRunIsSurfaced.spec.ts` (rank 99, failure half): a server-submitted run that fails after the turn ends shows its error message in the queue row's details popover, and the agent panel stays idle. - `agentGoldenPathRunIt.spec.ts` (rank 98, fixture-supported half): the finished run's history row renders a thumbnail served from that run's output. - `agentJobReopenedAsWorkflow.spec.ts` (rank 79, folds #18936): "open as workflow" rebuilds the graph when the job carries one, and — as a declared expected failure — says nothing at all when it does not. - All four live beside their fixture in `browser_tests/tests/agent/`. ## Review Focus - **Why the fixture moved.** The fixture and its execution helper additions are used only by the four specs in this PR, so they now live next to them in `browser_tests/tests/agent/` instead of in `browser_tests/fixtures/` — the same shape as `agentPanelMocks.ts` and `agentCreditsExhaustionLifecycleMocks.ts`, which are already `agentTest.extend` fixtures under `tests/agent/`. CODEOWNERS already scoped both files to `@Comfy-Org/agent_devs` through `/browser_tests/fixtures/**/*gent*`, so this does not change who owns them; it only makes the paths agree with that ownership. The branch ruleset's narrower `browser_tests/fixtures/data/agent/**` glob did not cover them, which is why the earlier layout pulled an Agent-test-only PR into the shared-path reviewer entry. - The two story-only additions to the execution surface — the job interrupt/cancel recorder and a per-job `GET /api/jobs/{id}` detail route — are now a subclass in the story fixture rather than changes to the shared `AgentExecutionHelper`, which `agentExecutionFixture.ts` and `agentExecutionLifecycle.spec.ts` also consume. This PR no longer modifies that shared helper. - The stalled-run half of rank 99 and rank 42 (output on the producing node) are not separate specs. `agentExecutionLifecycle.spec.ts` and the stop spec already cover them with the same steps. - The rank-98 agent-panel half (the reply presenting a result link) is deferred until a recorded conversation or a product contract for result links exists. - Product gap, not asserted: for a server-submitted run, `execution_error` does not open the error dialog, because `executionStore.runErrorKeyForJob` cannot resolve a workflow path for the job and buffers the error as unattributable. The queue row details are the surface that does show it. - Verified locally against a cloud dev server at the current head: all four specs pass, with the rank-79 second case failing exactly where it declares it will. The stop spec's empty-cancel-list assertion is proven non-vacuous two ways — mutating Stop to also call `api.interrupt` fails it, and a positive control that issues `/api/interrupt` from the page records it. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-24T02:37:27.144Z",
"gitSha": "63998c96131732e69a5c8bd947bec83886ffa0af",
"branch": "backport-18803-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.8279999999754,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.504,
"layouts": 8,
"layoutDurationMs": 2.378,
"taskDurationMs": 492.48799999999994,
"heapDeltaBytes": 21328432,
"heapUsedBytes": 87651988,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.752,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2020.83099999993,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0280000000000005,
"layouts": 10,
"layoutDurationMs": 3.603,
"taskDurationMs": 457.85900000000004,
"heapDeltaBytes": 21716832,
"heapUsedBytes": 88453544,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 15.38,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2020.2889999999911,
"styleRecalcs": 84,
"styleRecalcDurationMs": 15.788999999999998,
"layouts": 8,
"layoutDurationMs": 2.215,
"taskDurationMs": 1066.302,
"heapDeltaBytes": -7291648,
"heapUsedBytes": 68190532,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 165.38499999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.1949999999788,
"styleRecalcs": 79,
"styleRecalcDurationMs": 16.168000000000003,
"layouts": 9,
"layoutDurationMs": 2.6049999999999995,
"taskDurationMs": 934.4939999999999,
"heapDeltaBytes": -7264708,
"heapUsedBytes": 68289524,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 172.71599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.432999999996,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.874999999999999,
"layouts": 12,
"layoutDurationMs": 3.2829999999999995,
"taskDurationMs": 425.62000000000006,
"heapDeltaBytes": -14428,
"heapUsedBytes": 74713144,
"domNodes": 47,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 15.013999999999996,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664761904761907,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1795.1269999999795,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.856999999999999,
"layouts": 12,
"layoutDurationMs": 3.7110000000000003,
"taskDurationMs": 398.32500000000005,
"heapDeltaBytes": 18344808,
"heapUsedBytes": 84625736,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 16.023,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 648.3230000000049,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8409999999999997,
"layouts": 9,
"layoutDurationMs": 2.87,
"taskDurationMs": 489.42800000000005,
"heapDeltaBytes": 6656032,
"heapUsedBytes": 82148604,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 165.673,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 635.2860000000646,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.771,
"layouts": 8,
"layoutDurationMs": 2.52,
"taskDurationMs": 469.06600000000003,
"heapDeltaBytes": 25682872,
"heapUsedBytes": 91585824,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 180.679,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1196.988000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 881.3829999999999,
"heapDeltaBytes": 390188,
"heapUsedBytes": 81677208,
"domNodes": -212,
"jsHeapTotalBytes": 14426112,
"scriptDurationMs": 71.563,
"eventListeners": -106,
"totalBlockingTimeMs": 507,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1357.988999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1075.385,
"heapDeltaBytes": 838752,
"heapUsedBytes": 81415760,
"domNodes": -212,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 73.386,
"eventListeners": -106,
"totalBlockingTimeMs": 648,
"frameDurationMs": 35.526315789473685,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.910000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.94700000000046,
"heapDeltaBytes": -6393968,
"heapUsedBytes": 74337260,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.401,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 872.8770000000168,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.7480000000003,
"heapDeltaBytes": -4770168,
"heapUsedBytes": 76158184,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.82599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 24.757142857142885,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11290.036999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10315.124999999998,
"heapDeltaBytes": -23637852,
"heapUsedBytes": 75532876,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 8421.256,
"eventListeners": -68,
"totalBlockingTimeMs": 1240,
"frameDurationMs": 32.79883720930232,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10442.439000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9628.066,
"heapDeltaBytes": -14595228,
"heapUsedBytes": 84405284,
"domNodes": -258,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 7753.1720000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 962,
"frameDurationMs": 30.866863905325438,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10088.778999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9310.754,
"heapDeltaBytes": -3695980,
"heapUsedBytes": 95952108,
"domNodes": -258,
"jsHeapTotalBytes": 11661312,
"scriptDurationMs": 7962.627,
"eventListeners": -68,
"totalBlockingTimeMs": 1303,
"frameDurationMs": 32.52516129032258,
"p95FrameDurationMs": 66.5
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11297.827999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10479.56,
"heapDeltaBytes": -4199460,
"heapUsedBytes": 83336488,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 8596.261,
"eventListeners": -68,
"totalBlockingTimeMs": 1408,
"frameDurationMs": 31.693258426966292,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 219.12399999996524,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.562000000000001,
"layouts": 11,
"layoutDurationMs": 3.1130000000000004,
"taskDurationMs": 164.21799999999996,
"heapDeltaBytes": 13013224,
"heapUsedBytes": 91779936,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.196,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.670000000000073,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 243.44699999994646,
"styleRecalcs": 25,
"styleRecalcDurationMs": 18.047,
"layouts": 12,
"layoutDurationMs": 3.728,
"taskDurationMs": 181.55800000000002,
"heapDeltaBytes": -8207208,
"heapUsedBytes": 79735612,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.623,
"eventListeners": 195,
"totalBlockingTimeMs": 8,
"frameDurationMs": 20.825000000000045,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2055.361000000005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.361,
"layouts": 7,
"layoutDurationMs": 2.2439999999999998,
"taskDurationMs": 660.6510000000001,
"heapDeltaBytes": -22552656,
"heapUsedBytes": 74863968,
"domNodes": -278,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 35.178000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.5989999999956,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8060000000000005,
"layouts": 8,
"layoutDurationMs": 3.0300000000000002,
"taskDurationMs": 569.3500000000001,
"heapDeltaBytes": -5386008,
"heapUsedBytes": 74395008,
"domNodes": -278,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 40.272000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2305.5589999999597,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.757,
"layouts": 6,
"layoutDurationMs": 1.5020000000000002,
"taskDurationMs": 1518.345,
"heapDeltaBytes": 3436088,
"heapUsedBytes": 83819732,
"domNodes": -278,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 794.403,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78759124087591,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2581.843000000049,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.446,
"layouts": 7,
"layoutDurationMs": 1.825,
"taskDurationMs": 1810.461,
"heapDeltaBytes": -30635836,
"heapUsedBytes": 67042052,
"domNodes": -278,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 855.397,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.995394736842105,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3597.6049999999873,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.829000000000001,
"layouts": 64,
"layoutDurationMs": 10.967,
"taskDurationMs": 1641.3229999999999,
"heapDeltaBytes": -14249064,
"heapUsedBytes": 67590516,
"domNodes": -254,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 793.2729999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.743720930232556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3949.6050000000196,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.405999999999999,
"layouts": 64,
"layoutDurationMs": 11.233,
"taskDurationMs": 1909.838,
"heapDeltaBytes": 12742996,
"heapUsedBytes": 89808508,
"domNodes": -234,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 830.944,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73702127659574,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3193.784999999991,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.295,
"layouts": 6,
"layoutDurationMs": 1.94,
"taskDurationMs": 2084.485,
"heapDeltaBytes": -5944052,
"heapUsedBytes": 77982200,
"domNodes": 0,
"jsHeapTotalBytes": 6643712,
"scriptDurationMs": 1003.263,
"eventListeners": 182,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.019047619047615,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3433.864000000085,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.770000000000001,
"layouts": 4,
"layoutDurationMs": 1.137,
"taskDurationMs": 2217.422,
"heapDeltaBytes": -10249800,
"heapUsedBytes": 68778712,
"domNodes": -278,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 1106.418,
"eventListeners": -53,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82941176470588,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.5400000000072,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.389,
"layouts": 7,
"layoutDurationMs": 2.5279999999999996,
"taskDurationMs": 675.0899999999999,
"heapDeltaBytes": -3307504,
"heapUsedBytes": 78122000,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 35.102999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2056.5579999999954,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.4280000000000004,
"layouts": 7,
"layoutDurationMs": 2.5239999999999996,
"taskDurationMs": 729.897,
"heapDeltaBytes": -1762280,
"heapUsedBytes": 79652240,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 36.897,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.1440000000202,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.375,
"layouts": 10,
"layoutDurationMs": 2.8609999999999998,
"taskDurationMs": 425.309,
"heapDeltaBytes": 21486792,
"heapUsedBytes": 89039932,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 151.57500000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 631.4380000000028,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.349999999999999,
"layouts": 10,
"layoutDurationMs": 3.297,
"taskDurationMs": 447.361,
"heapDeltaBytes": -1135492,
"heapUsedBytes": 76012544,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 147.941,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.8260000000328,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2689999999999992,
"layouts": 9,
"layoutDurationMs": 2.617,
"taskDurationMs": 349.00299999999993,
"heapDeltaBytes": 22463256,
"heapUsedBytes": 89314056,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.037999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.4210000000749,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2470000000000008,
"layouts": 9,
"layoutDurationMs": 3.5039999999999996,
"taskDurationMs": 613.9010000000001,
"heapDeltaBytes": -623000,
"heapUsedBytes": 76859092,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 14,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1971.0129999999708,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.477999999999998,
"layouts": 8,
"layoutDurationMs": 2.4629999999999996,
"taskDurationMs": 1024.9279999999999,
"heapDeltaBytes": 11690796,
"heapUsedBytes": 79442820,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 114.61800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1975.8649999999989,
"styleRecalcs": 87,
"styleRecalcDurationMs": 19.109,
"layouts": 9,
"layoutDurationMs": 3.055,
"taskDurationMs": 1089.128,
"heapDeltaBytes": 11699384,
"heapUsedBytes": 79058456,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 121.11400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.6089999999622,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.073999999999995,
"layouts": 5,
"layoutDurationMs": 14.873000000000001,
"taskDurationMs": 950.7640000000001,
"heapDeltaBytes": 38138148,
"heapUsedBytes": 118168708,
"domNodes": 15953,
"jsHeapTotalBytes": 10096640,
"scriptDurationMs": 46.205,
"eventListeners": 3244,
"totalBlockingTimeMs": 177,
"frameDurationMs": 20.0904109589041,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9972.262999999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.417,
"layouts": 8,
"layoutDurationMs": 2.438,
"taskDurationMs": 6078.463,
"heapDeltaBytes": -19880532,
"heapUsedBytes": 79148944,
"domNodes": -278,
"jsHeapTotalBytes": 5337088,
"scriptDurationMs": 2740.377,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66594323873122,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9699.760999999966,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.547,
"layouts": 7,
"layoutDurationMs": 2.241,
"taskDurationMs": 6203.852000000001,
"heapDeltaBytes": -28805364,
"heapUsedBytes": 68568604,
"domNodes": -278,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 2823.148,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72348877374784,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23171.911999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22612.726,
"heapDeltaBytes": -34173832,
"heapUsedBytes": 256991868,
"domNodes": -3330,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 315.181,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.57094017094017,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 23336.74199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22815.072,
"heapDeltaBytes": -2343808,
"heapUsedBytes": 288875208,
"domNodes": -3330,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 325.661,
"eventListeners": -653,
"totalBlockingTimeMs": 10,
"frameDurationMs": 40.090034364261165,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 19999.766999999963,
"styleRecalcs": 158,
"styleRecalcDurationMs": 13.133000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19612.339,
"heapDeltaBytes": -23663824,
"heapUsedBytes": 271728832,
"domNodes": -3330,
"jsHeapTotalBytes": 13094912,
"scriptDurationMs": 829.0659999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 71,
"frameDurationMs": 37.06648148148148,
"p95FrameDurationMs": 83.20000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 28106.13599999999,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.507999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27716.601000000006,
"heapDeltaBytes": -28270108,
"heapUsedBytes": 253181588,
"domNodes": -3330,
"jsHeapTotalBytes": 7589888,
"scriptDurationMs": 904.0939999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 26,
"frameDurationMs": 51.463186813186816,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8424.171999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.82000000000002,
"layouts": 20,
"layoutDurationMs": 21.654999999999994,
"taskDurationMs": 8305.289999999999,
"heapDeltaBytes": -42369744,
"heapUsedBytes": 258608920,
"domNodes": -3330,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 126.65199999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.91534090909091,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8471.738000000074,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.82199999999999,
"layouts": 20,
"layoutDurationMs": 30.547000000000004,
"taskDurationMs": 8334.191,
"heapDeltaBytes": -3977480,
"heapUsedBytes": 278305396,
"domNodes": -3330,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 131.31300000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.29776536312849,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11434.732999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11267.618999999999,
"heapDeltaBytes": 565300,
"heapUsedBytes": 273547756,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.6620000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.42355072463767,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11502.721000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11295.386,
"heapDeltaBytes": -8598624,
"heapUsedBytes": 268665300,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.41499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.51752577319587,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 524.5589999999538,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.673000000000002,
"layouts": 10,
"layoutDurationMs": 4.374,
"taskDurationMs": 161.357,
"heapDeltaBytes": 7230464,
"heapUsedBytes": 80707872,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.63,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.21999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 114.13199999992685,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.533,
"layouts": 7,
"layoutDurationMs": 2.6470000000000007,
"taskDurationMs": 87.62299999999999,
"heapDeltaBytes": 4444576,
"heapUsedBytes": 78011752,
"domNodes": 94,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.560999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 487.7569999999878,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.021,
"layouts": 76,
"layoutDurationMs": 15.817000000000002,
"taskDurationMs": 445.586,
"heapDeltaBytes": -13714204,
"heapUsedBytes": 82136156,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 216.439,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 499.5649999999614,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9810000000000001,
"layouts": 76,
"layoutDurationMs": 16.619,
"taskDurationMs": 451.78499999999997,
"heapDeltaBytes": -14940056,
"heapUsedBytes": 80456156,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 215.531,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 725.3749999999854,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.3400000000000003,
"layouts": 76,
"layoutDurationMs": 17.732999999999997,
"taskDurationMs": 673.172,
"heapDeltaBytes": -2955380,
"heapUsedBytes": 107619976,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 294.61899999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.457142857142852,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 610.4679999999689,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.4290000000000003,
"layouts": 76,
"layoutDurationMs": 14.347,
"taskDurationMs": 579.166,
"heapDeltaBytes": 1274688,
"heapUsedBytes": 119788184,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 244.71900000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.118918918918908,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2280 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 245684972323768fd1350c2a02b19e3ee6186623
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21873 +/- ##
=============================================
- Coverage 84.12% 84.11% -0.01%
=============================================
Files 2840 2840
Lines 158059 158059
Branches 40597 38431 -2166
=============================================
- Hits 132962 132957 -5
- Misses 24708 24713 +5
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #18803 to
core/1.57Automatically created by backport workflow.