Skip to content

Fix refreshing balance on CurrentUserButton - #21810

Closed
AustinMroz wants to merge 1 commit into
mainfrom
austin/stale-user-balance
Closed

AustinMroz wants to merge 1 commit into
mainfrom
austin/stale-user-balance

Conversation

@AustinMroz

Copy link
Copy Markdown
Collaborator

Migrating the user menu to reka-ui broke balance refreshing because show was triggered before workspacePopoverContent initialized. This is resolved by having the child component instead fetch balance on mount.

@AustinMroz
AustinMroz requested a review from a team October 23, 2026 17:11
@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 3639393 and e08e842.

📒 Files selected for processing: 4
  • src/components/topbar/CurrentUserButton.balance.test.ts
  • src/components/topbar/CurrentUserButton.vue
  • src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts
  • src/platform/workspace/components/CurrentUserPopoverWorkspace.vue
+-----------------------------------------+
| Because, faster merges = more features. |
+-----------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@AustinMroz

Copy link
Copy Markdown
Collaborator Author

Already fixed in #21392

@AustinMroz AustinMroz closed this Oct 23, 2026

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear I reviewed this same PR recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants