Repository navigation
[backport core/1.57] FE-3159 fix(billing): show one ended banner on the Members tab (#21696) - #21796
Conversation
A team workspace whose plan has ended showed two ended notices on the
Members tab: the settings-level `BillingStatusBanner` `planEnded` notice
and the older `MemberUpsellBanner` `reactivate`/`contactSales` variant.
This retires the Members-only variants so the tab shows one.
- Root cause: `MemberUpsellBanner` gained ended variants (DES-1200)
before the unified `planEnded` notice existed. Once
`BillingStatusBanner` rendered `planEnded` on every settings section,
both showed.
- `planEnded` is not gated on `billing_control_enabled`
(`deriveBillingBanner` checks it before the flag), so it already covers
self-serve, Enterprise and unknown-tier ended plans with the same routes
back (Resubscribe / Contact sales). FE-3568 (flag removal) is
unaffected.
- `MemberUpsellBanner` is now only the personal workspace's Team-plan
pitch. The ended-plan footer on the Members tab stays.
- Three now-unused `workspacePanel.members.upsellBanner*` strings
removed.
Linear: FE-3159
- Red then green: the new `MembersPanelContent` case ("leaves the ended
notice to the settings status banner", self-serve and sales-managed)
failed on main with the duplicate `role="status"` banner and passes
here.
- `pnpm vitest run` on MembersPanelContent, MemberUpsellBanner,
useMembersPanel, BillingStatusBanner, WorkspaceMembersPanelContent:
290/290 pass. Ended-plan copy and routing stay covered by
`BillingStatusBanner.test.ts` ("on the Members tab").
- AS IS / TO BE screenshots to follow in a comment.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T11:27:48.380Z",
"gitSha": "701a1cc919e34de7023f2245bfba23a5570cbe08",
"branch": "backport-21696-to-core-1-57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.9969999999657,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.373999999999999,
"layouts": 11,
"layoutDurationMs": 3.6029999999999993,
"taskDurationMs": 552.659,
"heapDeltaBytes": -882492,
"heapUsedBytes": 74486544,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.647999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.4750000000895,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.793,
"layouts": 9,
"layoutDurationMs": 2.949,
"taskDurationMs": 530.297,
"heapDeltaBytes": 21341948,
"heapUsedBytes": 87554748,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.851999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.1290000000008,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.779,
"layouts": 10,
"layoutDurationMs": 2.757,
"taskDurationMs": 702.172,
"heapDeltaBytes": 15648156,
"heapUsedBytes": 81445368,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 143.05800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.256999999965,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.847,
"layouts": 9,
"layoutDurationMs": 2.6890000000000005,
"taskDurationMs": 878.7069999999999,
"heapDeltaBytes": 15602668,
"heapUsedBytes": 81569408,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 150.56399999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.2549999999906,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.943,
"layouts": 12,
"layoutDurationMs": 3.045,
"taskDurationMs": 391.295,
"heapDeltaBytes": -4556576,
"heapUsedBytes": 70788984,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 10.932,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.9179999999787,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.296999999999999,
"layouts": 11,
"layoutDurationMs": 2.9759999999999995,
"taskDurationMs": 310.319,
"heapDeltaBytes": 18739732,
"heapUsedBytes": 84638960,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.893000000000006,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 697.0660000000066,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8089999999999997,
"layouts": 9,
"layoutDurationMs": 2.7399999999999998,
"taskDurationMs": 492.21999999999997,
"heapDeltaBytes": 25219800,
"heapUsedBytes": 91877268,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 164.746,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 683.86600000008,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7369999999999997,
"layouts": 9,
"layoutDurationMs": 2.553,
"taskDurationMs": 501.97700000000003,
"heapDeltaBytes": -1125368,
"heapUsedBytes": 65273936,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 164.497,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926822,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1213.3650000000102,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 923.8799999999999,
"heapDeltaBytes": -13321204,
"heapUsedBytes": 80885048,
"domNodes": -192,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 70.09700000000001,
"eventListeners": -105,
"totalBlockingTimeMs": 534,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.8689999999688,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 904.3220000000001,
"heapDeltaBytes": -11443968,
"heapUsedBytes": 81316904,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 60.83399999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 523,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 808.8730000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.331,
"heapDeltaBytes": -4342584,
"heapUsedBytes": 76543960,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 124.47799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 180,
"frameDurationMs": 24.020588235294113,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 809.3130000000315,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.473,
"heapDeltaBytes": -4464512,
"heapUsedBytes": 76628812,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 134.36400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 176,
"frameDurationMs": 24.020588235294113,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9607.487000000021,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3080000000000001,
"layouts": 1,
"layoutDurationMs": 0.2919999999999997,
"taskDurationMs": 8660.212,
"heapDeltaBytes": -6710008,
"heapUsedBytes": 87228984,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 6739.43,
"eventListeners": -68,
"totalBlockingTimeMs": 293,
"frameDurationMs": 28.317699115044245,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8922.323000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8135.386,
"heapDeltaBytes": -2869040,
"heapUsedBytes": 97171784,
"domNodes": -258,
"jsHeapTotalBytes": 11661312,
"scriptDurationMs": 6344.671,
"eventListeners": -68,
"totalBlockingTimeMs": 317,
"frameDurationMs": 31.898207885304654,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8366.32499999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.28300000000000025,
"layouts": 1,
"layoutDurationMs": 0.3650000000000003,
"taskDurationMs": 7559.081,
"heapDeltaBytes": -24937668,
"heapUsedBytes": 74444016,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 6153.278,
"eventListeners": -68,
"totalBlockingTimeMs": 211,
"frameDurationMs": 28.59452054794521,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8807.038999999975,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.29699999999999954,
"layouts": 1,
"layoutDurationMs": 0.4499999999999999,
"taskDurationMs": 7996.312000000001,
"heapDeltaBytes": -29063592,
"heapUsedBytes": 70976060,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 6544.572999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 200,
"frameDurationMs": 29.33233333333333,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 212.16699999996536,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.226000000000003,
"layouts": 11,
"layoutDurationMs": 3.21,
"taskDurationMs": 161.98100000000002,
"heapDeltaBytes": -8062812,
"heapUsedBytes": 79211740,
"domNodes": 917,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.927,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 221.0370000000239,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.046000000000001,
"layouts": 11,
"layoutDurationMs": 5.962000000000001,
"taskDurationMs": 170.87800000000004,
"heapDeltaBytes": -8143632,
"heapUsedBytes": 79266996,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.830000000000002,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.670000000000027,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2049.878000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.593,
"layouts": 9,
"layoutDurationMs": 2.933,
"taskDurationMs": 633.462,
"heapDeltaBytes": -22767200,
"heapUsedBytes": 74377828,
"domNodes": -258,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 29.918,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2037.8680000000031,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.412,
"layouts": 8,
"layoutDurationMs": 2.3669999999999995,
"taskDurationMs": 502.80899999999997,
"heapDeltaBytes": -2243436,
"heapUsedBytes": 76436680,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 35.315,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2313.5669999999777,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.15,
"layouts": 7,
"layoutDurationMs": 1.9440000000000002,
"taskDurationMs": 1671.408,
"heapDeltaBytes": -30042228,
"heapUsedBytes": 68950696,
"domNodes": -258,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 789.999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618705035971,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2390.560999999934,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.03,
"layouts": 6,
"layoutDurationMs": 1.8190000000000004,
"taskDurationMs": 1735.005,
"heapDeltaBytes": -30424980,
"heapUsedBytes": 67860340,
"domNodes": -258,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 815.796,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78439716312057,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3584.5709999999826,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.416,
"layouts": 64,
"layoutDurationMs": 10.969999999999999,
"taskDurationMs": 1774.5010000000004,
"heapDeltaBytes": -9992488,
"heapUsedBytes": 68706432,
"domNodes": -254,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 740.1379999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665581395348838,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3506.102999999939,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.413,
"layouts": 64,
"layoutDurationMs": 10.824,
"taskDurationMs": 1565.18,
"heapDeltaBytes": 609272,
"heapUsedBytes": 82708580,
"domNodes": 24,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 754.203,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.745454545454542,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3022.059000000013,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.656,
"layouts": 5,
"layoutDurationMs": 1.308,
"taskDurationMs": 1913.9170000000001,
"heapDeltaBytes": 11766692,
"heapUsedBytes": 95142412,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 920.235,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2845.4380000000583,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.718,
"layouts": 4,
"layoutDurationMs": 1.278,
"taskDurationMs": 1735.445,
"heapDeltaBytes": 15448240,
"heapUsedBytes": 98723316,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 924.487,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76449704142012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.9410000000412,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.739,
"layouts": 6,
"layoutDurationMs": 1.9860000000000004,
"taskDurationMs": 624.104,
"heapDeltaBytes": -2028576,
"heapUsedBytes": 79325924,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.828000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.2689999999566,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.9220000000000002,
"layouts": 6,
"layoutDurationMs": 2.0039999999999996,
"taskDurationMs": 638.5889999999998,
"heapDeltaBytes": -2659148,
"heapUsedBytes": 79225084,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 30.631,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.385000000012,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.0009999999999994,
"layouts": 10,
"layoutDurationMs": 2.591,
"taskDurationMs": 428.484,
"heapDeltaBytes": -2276584,
"heapUsedBytes": 74282724,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 139.882,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.2109999999784,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.502000000000001,
"layouts": 10,
"layoutDurationMs": 3.3419999999999996,
"taskDurationMs": 455.735,
"heapDeltaBytes": -1082572,
"heapUsedBytes": 76005244,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 145.42,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.5620000000172,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6759999999999997,
"layouts": 9,
"layoutDurationMs": 2.613,
"taskDurationMs": 523.8280000000001,
"heapDeltaBytes": 22456728,
"heapUsedBytes": 89412980,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.957999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.535000000038,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0549999999999997,
"layouts": 10,
"layoutDurationMs": 3.1139999999999994,
"taskDurationMs": 527.146,
"heapDeltaBytes": -256712,
"heapUsedBytes": 77577872,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.076000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.6659999999702,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.697999999999997,
"layouts": 9,
"layoutDurationMs": 2.4859999999999998,
"taskDurationMs": 884.156,
"heapDeltaBytes": 11680648,
"heapUsedBytes": 78613240,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 99.914,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.8329999999896,
"styleRecalcs": 88,
"styleRecalcDurationMs": 16.608999999999998,
"layouts": 9,
"layoutDurationMs": 2.652,
"taskDurationMs": 1086.128,
"heapDeltaBytes": -11338116,
"heapUsedBytes": 65657868,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 109.754,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.037000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.625999999999994,
"layouts": 5,
"layoutDurationMs": 13.937000000000001,
"taskDurationMs": 1031.623,
"heapDeltaBytes": 2484200,
"heapUsedBytes": 98781004,
"domNodes": 15953,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 29.088,
"eventListeners": 3244,
"totalBlockingTimeMs": 153,
"frameDurationMs": 19.367567567567566,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8288.877999999953,
"styleRecalcs": 250,
"styleRecalcDurationMs": 17.672,
"layouts": 7,
"layoutDurationMs": 2.072,
"taskDurationMs": 5043.674,
"heapDeltaBytes": -231144,
"heapUsedBytes": 78848148,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 2553.0299999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8420.223000000078,
"styleRecalcs": 250,
"styleRecalcDurationMs": 18.653,
"layouts": 8,
"layoutDurationMs": 2.2359999999999998,
"taskDurationMs": 6046.033,
"heapDeltaBytes": -13711968,
"heapUsedBytes": 83956296,
"domNodes": -258,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 2666.4629999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.732270916334663,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14132.885999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13397.094,
"heapDeltaBytes": -26181816,
"heapUsedBytes": 270116188,
"domNodes": -307,
"jsHeapTotalBytes": 26730496,
"scriptDurationMs": 235.33399999999997,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.087588652482268,
"p95FrameDurationMs": 33.5
},
{
"name": "vue-large-graph-idle",
"durationMs": 14260.895000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13529.197,
"heapDeltaBytes": 20443872,
"heapUsedBytes": 296084464,
"domNodes": -3330,
"jsHeapTotalBytes": 22536192,
"scriptDurationMs": 259.151,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.47517857142857,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17156.265000000018,
"styleRecalcs": 112,
"styleRecalcDurationMs": 10.56399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16841.83,
"heapDeltaBytes": -25620616,
"heapUsedBytes": 269650228,
"domNodes": -3330,
"jsHeapTotalBytes": 15982592,
"scriptDurationMs": 796.0690000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 32.146067415730336,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 25063.205000000038,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24765.647,
"heapDeltaBytes": -30042380,
"heapUsedBytes": 270715292,
"domNodes": -3330,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 867.346,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 48.11074856046065,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 5246.4510000000355,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.33,
"layouts": 20,
"layoutDurationMs": 24.512999999999995,
"taskDurationMs": 5152.048000000001,
"heapDeltaBytes": -12114536,
"heapUsedBytes": 278638416,
"domNodes": -3330,
"jsHeapTotalBytes": 23846912,
"scriptDurationMs": 85.72399999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.522093023255817,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 5195.2680000000555,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.70000000000002,
"layouts": 20,
"layoutDurationMs": 23.494,
"taskDurationMs": 5092.741999999999,
"heapDeltaBytes": -5596224,
"heapUsedBytes": 294790812,
"domNodes": -3330,
"jsHeapTotalBytes": 32755712,
"scriptDurationMs": 90.00599999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.587058823529407,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10208.064999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9952.958999999999,
"heapDeltaBytes": 10384636,
"heapUsedBytes": 262794388,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.41500000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.12014925373135,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10168.335999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9917.501,
"heapDeltaBytes": 10370716,
"heapUsedBytes": 257429524,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.89200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.05035460992908,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 477.5889999999663,
"styleRecalcs": 13,
"styleRecalcDurationMs": 13.627999999999998,
"layouts": 13,
"layoutDurationMs": 4.461,
"taskDurationMs": 130.966,
"heapDeltaBytes": 6785192,
"heapUsedBytes": 79487732,
"domNodes": 98,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.445999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 487.2960000000148,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.278999999999998,
"layouts": 12,
"layoutDurationMs": 4.904999999999999,
"taskDurationMs": 147.263,
"heapDeltaBytes": -13467132,
"heapUsedBytes": 69897140,
"domNodes": 121,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.342999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.260714285714293,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 457.0260000000417,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.321,
"layouts": 76,
"layoutDurationMs": 17.621000000000002,
"taskDurationMs": 410.17,
"heapDeltaBytes": 10697080,
"heapUsedBytes": 103631216,
"domNodes": 4,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 182.421,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285717,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 648.6429999999928,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.889,
"layouts": 76,
"layoutDurationMs": 17.7,
"taskDurationMs": 608.4979999999999,
"heapDeltaBytes": 12918928,
"heapUsedBytes": 86185144,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 295.959,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307678,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 581.5959999999905,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2880000000000003,
"layouts": 76,
"layoutDurationMs": 16.69,
"taskDurationMs": 539.369,
"heapDeltaBytes": 98160,
"heapUsedBytes": 131417592,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 214.794,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 606.1399999999821,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.336,
"layouts": 76,
"layoutDurationMs": 15.827999999999998,
"taskDurationMs": 565.4200000000001,
"heapDeltaBytes": -466532,
"heapUsedBytes": 130867520,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 215.674,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.687878787878784,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2280 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b40292d0f2efd573af147c7b5af19ba6fdd3206e
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21796 +/- ##
=============================================
- Coverage 84.12% 84.11% -0.01%
=============================================
Files 2840 2840
Lines 158035 158006 -29
Branches 40605 38421 -2184
=============================================
- Hits 132942 132910 -32
- Misses 24704 24707 +3
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: this backport preserves PR 21696 on the release line. Its documented conflict resolution retains the target styling while removing the duplicate ended-plan banner and obsolete variants.
Full context for agent readers
The full exact-head check set is settled, the review thread set is empty, and no package manifest or export map changes.
Backport of #21696 to core/1.57.
Why
Same fix as #21696, needed on this release branch.
Root cause / How
See #21696. Cherry-picked from its merge commit.
AS IS / TO BE
See #21696.
Conflicts