Repository navigation
[backport cloud/1.57] fix(agent): send human links into dynamic-combo inputs - #21785
Conversation
…lacks (PM-2080) (#21686) When a user wires into a dynamic-combo child input (for example `resize_type.match` on Resize Image/Mask) and the bound document was made under a different combo selection, the link never reached the document the agent reads. Now the connect sends a `grow` for that slot, so the agent sees the wire, and a later disconnect lands too. Linear: [PM-2080](https://linear.app/comfyorg/issue/PM-2080) <details><summary>Full context for agent readers</summary> - A dynamic combo grows a child input only while the option that declares it is selected. `resize_type.match` exists only while `resize_type` is `match size`. - A document minted under another selection has no slot of that name. `mintConnect` resolves the target by name (`docInputIndex`), finds nothing, and `growForMissingSlot` only grew widget-backed and autogrow inputs. So the connect was dropped and reported as `agent_crdt_link_slot_not_in_doc`, and the later disconnect was dropped the same way. - [CLOUD-FRONTEND-PROD-2BG](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-2BG), the PM-2080 alert: `disconnect targets input resize_type.match of node 878135716359488`, release 1.55.18, 2026-10-12T19:37:28Z. The stack starts at the canvas link context menu (`LGraphCanvas.inner_clicked` → `LGraph.removeLink` → `emitGraphIntent` → `mintDisconnect`), so it was a human canvas edit, not an agent op or a reconcile pass. - The same user and node logged `connect targets input resize_type.match of node 878135716359488` at 19:27:48Z, ten minutes earlier. The connect was refused first, so the doc never had the link; the disconnect refusal is the tail of that. - The same refusal recurred on release 1.56.3 on another node (`1216303266011253`, 2026-10-17T13:36:26Z). `growForMissingSlot` also grows an input that the node definition resolves as a child of a dynamic input under the node's current widget values (`nodeDefStore.getInputSpecForWidget`, excluding top-level inputs). The payload is the same `{ name, type }` grow the autogrow path already sends, and the pinned applier appends the slot under that name. Static inputs the doc lacks are still reported, not grown. [#21250](#21250) (FE-3472) records every grow `growForMissingSlot` decides so a disconnect inside the echo window targets the predicted slot. **This is not a trivial rebase, correcting an earlier claim here.** #21250 replaces the `docInputIndex` call in both `mintConnect` and `mintDisconnect` with `resolveDocSlot`, which returns a predicted slot for an unechoed grow. Once this PR's dynamic grows are recorded there, a same-tick disconnect resolves to that predicted slot and never reaches `mintMissingSlotDisconnect`, so the unsent grow is no longer cancelled and `cancels an unsent dynamic-combo grow when disconnected in the same tick` fails. Whichever PR lands second has to order the pending-dynamic-slot check ahead of the predicted-slot fallback and clear both structures together. </details> - Unit (`docOpMinter.test.ts`): a real dynamic-combo node, a doc minted under the other option, then a human connect and disconnect, each applied through the pinned `@comfyorg/comfy-multi-player` applier and read back with `project()`. **Fails on `main`** (no op minted), passes with the fix. - Black-box (`browser_tests/tests/agent/agentDynamicComboChildLink.spec.ts`, `@cloud`): the agent switches the combo over the CRDT doc, the user drags a link into the grown child on the canvas, and the fake host's real applier must project the link on `resize_type.match`; then the link is deleted through `LGraph.removeLink` (the prod stack) and must clear. **Fails on `main`** (`Received: undefined`), passes with the fix; repeated 2x alongside `agentDynamicComboSetWidgetSilentlyDropped` and `agentAutogrowHandWiredLinkSurvivesSend` (6 passed). - `src/workbench/extensions/agent/crdt/` vitest suite: 1200 passed, 1 expected fail. `pnpm typecheck`, `typecheck:browser`, oxlint, oxfmt, and the pre-push knip/fallow/depcruise audits are clean. - After release: `agent_crdt_link_slot_not_in_doc` events whose input is a link-only dynamic-combo child such as `resize_type.match` should stop on releases carrying this. (cherry picked from commit 91e5cfa) (cherry picked from commit 57fe710a7a687c66a07512fba950f45c859e978d)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed target-native port against #21686 and cloud/1.57. Conflict resolution preserves the branch follower/promoted-widget API while adding the dynamic-combo grow/connect path and source black-box regression. Local targeted suite: 162 tests green; browser typecheck, format, lint, and push gates green. Awaiting hosted production-build E2E.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-23T05:54:45.925Z",
"gitSha": "d4e3f2a15747200b4c42b7d32a679b88042026ea",
"branch": "oploop-918f-backport-21686-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.5010000000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.368000000000001,
"layouts": 11,
"layoutDurationMs": 3.09,
"taskDurationMs": 378.542,
"heapDeltaBytes": 22102904,
"heapUsedBytes": 87903996,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.353,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2011.1530000000357,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.876,
"layouts": 9,
"layoutDurationMs": 2.862,
"taskDurationMs": 280.692,
"heapDeltaBytes": 21624420,
"heapUsedBytes": 88113492,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 11.365,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1712.7830000000017,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.564,
"layouts": 10,
"layoutDurationMs": 4.119,
"taskDurationMs": 693.124,
"heapDeltaBytes": -7236820,
"heapUsedBytes": 68071536,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 124.853,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.498000000006,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.732,
"layouts": 10,
"layoutDurationMs": 2.695,
"taskDurationMs": 621.825,
"heapDeltaBytes": -8251096,
"heapUsedBytes": 66809496,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 119.275,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.0330000000336,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.8919999999999995,
"layouts": 12,
"layoutDurationMs": 2.803,
"taskDurationMs": 272.558,
"heapDeltaBytes": -4530520,
"heapUsedBytes": 70348388,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.485999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.7050000000381,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.851,
"layouts": 12,
"layoutDurationMs": 3.1859999999999995,
"taskDurationMs": 308.35,
"heapDeltaBytes": -388584,
"heapUsedBytes": 74693000,
"domNodes": 47,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 14.009000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 544.3029999999567,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.033,
"layouts": 9,
"layoutDurationMs": 2.5650000000000004,
"taskDurationMs": 351.67299999999994,
"heapDeltaBytes": 3904352,
"heapUsedBytes": 78838512,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 116.30699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 599.9390000000631,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.269000000000001,
"layouts": 10,
"layoutDurationMs": 2.7800000000000002,
"taskDurationMs": 396.70500000000004,
"heapDeltaBytes": 3946768,
"heapUsedBytes": 78957452,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 116.197,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 936.9570000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.576,
"heapDeltaBytes": -10986360,
"heapUsedBytes": 81682028,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 41.317,
"eventListeners": -106,
"totalBlockingTimeMs": 279,
"frameDurationMs": 25.925000000000004,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 927.314000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.8680000000002,
"heapDeltaBytes": -13060640,
"heapUsedBytes": 81189792,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 42.165,
"eventListeners": -106,
"totalBlockingTimeMs": 293,
"frameDurationMs": 26.665714285714277,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 716.5170000000103,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.3910000000003,
"heapDeltaBytes": -3562400,
"heapUsedBytes": 76243360,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 101.25900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 96,
"frameDurationMs": 21.076470588235306,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 698.052999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.77200000000005,
"heapDeltaBytes": -4030072,
"heapUsedBytes": 76225184,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 94.79,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.585294117647074,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6685.720000000003,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8880000000000008,
"layouts": 3,
"layoutDurationMs": 0.856,
"taskDurationMs": 5661.818,
"heapDeltaBytes": -26477504,
"heapUsedBytes": 73343468,
"domNodes": -258,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 4275.004,
"eventListeners": -68,
"totalBlockingTimeMs": 1,
"frameDurationMs": 20.936875,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6690.287000000012,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.958999999999999,
"layouts": 3,
"layoutDurationMs": 0.784,
"taskDurationMs": 5606.232999999999,
"heapDeltaBytes": 10712336,
"heapUsedBytes": 87846016,
"domNodes": -258,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 4319.213,
"eventListeners": -68,
"totalBlockingTimeMs": 25,
"frameDurationMs": 20.42591463414634,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6506.680000000017,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1549999999999998,
"layouts": 4,
"layoutDurationMs": 1.076,
"taskDurationMs": 5225.0019999999995,
"heapDeltaBytes": 1401968,
"heapUsedBytes": 88604216,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 4015.522,
"eventListeners": -68,
"totalBlockingTimeMs": 1,
"frameDurationMs": 19.93773006134969,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6612.2139999999945,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8439999999999993,
"layouts": 3,
"layoutDurationMs": 0.7769999999999999,
"taskDurationMs": 5378.17,
"heapDeltaBytes": -4071852,
"heapUsedBytes": 95860696,
"domNodes": -258,
"jsHeapTotalBytes": 8253440,
"scriptDurationMs": 4310.635,
"eventListeners": -68,
"totalBlockingTimeMs": 21,
"frameDurationMs": 20.6240625,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 167.33399999998255,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.632000000000003,
"layouts": 14,
"layoutDurationMs": 3.974999999999999,
"taskDurationMs": 122.17399999999999,
"heapDeltaBytes": -8319976,
"heapUsedBytes": 79765180,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7.009,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.522222222222254,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 148.18199999996295,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.229000000000001,
"layouts": 13,
"layoutDurationMs": 3.2660000000000005,
"taskDurationMs": 112.22200000000001,
"heapDeltaBytes": -8091800,
"heapUsedBytes": 79225980,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.51,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2009.4379999999887,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.862999999999999,
"layouts": 9,
"layoutDurationMs": 2.5100000000000002,
"taskDurationMs": 448.39500000000004,
"heapDeltaBytes": -18892368,
"heapUsedBytes": 77700620,
"domNodes": -258,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 29.784000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2011.269000000084,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8320000000000003,
"layouts": 9,
"layoutDurationMs": 2.609,
"taskDurationMs": 424.436,
"heapDeltaBytes": -2281676,
"heapUsedBytes": 76442300,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 28.967,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2753.485000000012,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.728,
"layouts": 9,
"layoutDurationMs": 3.8070000000000004,
"taskDurationMs": 1301.147,
"heapDeltaBytes": 1139992,
"heapUsedBytes": 77966420,
"domNodes": -258,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 617.537,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666265060240967,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3085.5060000000094,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.431999999999999,
"layouts": 9,
"layoutDurationMs": 2.4879999999999995,
"taskDurationMs": 1397.67,
"heapDeltaBytes": -28392384,
"heapUsedBytes": 69475484,
"domNodes": -258,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 660.037,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3602.631000000031,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.721999999999998,
"layouts": 67,
"layoutDurationMs": 12.947999999999999,
"taskDurationMs": 1298.257,
"heapDeltaBytes": -26885892,
"heapUsedBytes": 72251896,
"domNodes": -234,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 538.952,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3967.9590000000644,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.898999999999997,
"layouts": 64,
"layoutDurationMs": 13.758999999999999,
"taskDurationMs": 1424.409,
"heapDeltaBytes": 1833116,
"heapUsedBytes": 101391960,
"domNodes": 24,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 627.732,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665966386554622,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2915.984000000037,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.405,
"layouts": 7,
"layoutDurationMs": 2.1149999999999998,
"taskDurationMs": 1469.913,
"heapDeltaBytes": 5304340,
"heapUsedBytes": 83292300,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 713.777,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761494252873565,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3087.9340000000184,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.285,
"layouts": 7,
"layoutDurationMs": 2.0239999999999996,
"taskDurationMs": 1555.2659999999998,
"heapDeltaBytes": 16683948,
"heapUsedBytes": 99974608,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 763.98,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756216216216217,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.0879999999634,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8980000000000006,
"layouts": 9,
"layoutDurationMs": 2.554,
"taskDurationMs": 432.067,
"heapDeltaBytes": -2693048,
"heapUsedBytes": 78235836,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 28.001000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2021.0329999999885,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.482999999999999,
"layouts": 8,
"layoutDurationMs": 2.216,
"taskDurationMs": 523.574,
"heapDeltaBytes": -18734444,
"heapUsedBytes": 79030580,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 31.093,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 462.85400000004984,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.936,
"layouts": 10,
"layoutDurationMs": 2.7529999999999992,
"taskDurationMs": 310.986,
"heapDeltaBytes": 21532364,
"heapUsedBytes": 88877104,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 102.556,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 528.6069999999654,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.024000000000001,
"layouts": 11,
"layoutDurationMs": 3.138,
"taskDurationMs": 336.24199999999996,
"heapDeltaBytes": -1109452,
"heapUsedBytes": 75884616,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 108.75800000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.4780000000487,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3559999999999994,
"layouts": 10,
"layoutDurationMs": 2.9450000000000003,
"taskDurationMs": 348.757,
"heapDeltaBytes": 22396508,
"heapUsedBytes": 89676652,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.62,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.4570000000213,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2770000000000006,
"layouts": 10,
"layoutDurationMs": 2.9150000000000005,
"taskDurationMs": 384.764,
"heapDeltaBytes": 22398544,
"heapUsedBytes": 89815256,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.804000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.3500000000136,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.399,
"layouts": 10,
"layoutDurationMs": 2.6159999999999997,
"taskDurationMs": 588.481,
"heapDeltaBytes": -11346420,
"heapUsedBytes": 66028004,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 92.112,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.5450000000092,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.456,
"layouts": 11,
"layoutDurationMs": 2.8469999999999995,
"taskDurationMs": 639.444,
"heapDeltaBytes": -11423404,
"heapUsedBytes": 65586172,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 97.90800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 967.8729999999973,
"styleRecalcs": 21,
"styleRecalcDurationMs": 19.374000000000002,
"layouts": 5,
"layoutDurationMs": 10.249999999999998,
"taskDurationMs": 722.483,
"heapDeltaBytes": 7342024,
"heapUsedBytes": 104736524,
"domNodes": 15953,
"jsHeapTotalBytes": 17965056,
"scriptDurationMs": 22.948999999999998,
"eventListeners": 3244,
"totalBlockingTimeMs": 81,
"frameDurationMs": 18.90961538461539,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9239.506000000005,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.867,
"layouts": 9,
"layoutDurationMs": 3.461,
"taskDurationMs": 4414.902000000001,
"heapDeltaBytes": -13746540,
"heapUsedBytes": 82881596,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 1986.889,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10556.934999999954,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.314,
"layouts": 9,
"layoutDurationMs": 2.5480000000000005,
"taskDurationMs": 4751.568,
"heapDeltaBytes": -10286316,
"heapUsedBytes": 68808024,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 2111.885,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608832807571,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17134.871000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16573.428,
"heapDeltaBytes": 13947420,
"heapUsedBytes": 289018156,
"domNodes": -3330,
"jsHeapTotalBytes": 11526144,
"scriptDurationMs": 237.25399999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.48523131672598,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 13414.105000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12937.376000000002,
"heapDeltaBytes": 8363444,
"heapUsedBytes": 285184328,
"domNodes": -3330,
"jsHeapTotalBytes": 23322624,
"scriptDurationMs": 207.15200000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.585858585858585,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 19207.508999999958,
"styleRecalcs": 148,
"styleRecalcDurationMs": 15.445999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18815.342,
"heapDeltaBytes": -7277280,
"heapUsedBytes": 265089600,
"domNodes": -3330,
"jsHeapTotalBytes": 8380416,
"scriptDurationMs": 669.0360000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.49430740037951,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19375.755000000026,
"styleRecalcs": 157,
"styleRecalcDurationMs": 17.36500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19023.475000000002,
"heapDeltaBytes": -9184664,
"heapUsedBytes": 286182488,
"domNodes": -3330,
"jsHeapTotalBytes": 15720448,
"scriptDurationMs": 703.0310000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.6646408839779,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6044.1950000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.11199999999999,
"layouts": 20,
"layoutDurationMs": 22.811999999999998,
"taskDurationMs": 5900.694999999999,
"heapDeltaBytes": -17075700,
"heapUsedBytes": 284562560,
"domNodes": -3330,
"jsHeapTotalBytes": 31186944,
"scriptDurationMs": 90.109,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.97906976744186,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4909.465999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.377999999999986,
"layouts": 20,
"layoutDurationMs": 26.412000000000006,
"taskDurationMs": 4754.031,
"heapDeltaBytes": -45714720,
"heapUsedBytes": 258435376,
"domNodes": -3330,
"jsHeapTotalBytes": 27254784,
"scriptDurationMs": 108.21900000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.013186813186817,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8363.656999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7970.932999999999,
"heapDeltaBytes": 18686996,
"heapUsedBytes": 277651960,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.87399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.622261484098942,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8306.553000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8066.046000000002,
"heapDeltaBytes": -8636076,
"heapUsedBytes": 252573724,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.591,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.81840277777778,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 436.46000000001095,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.472999999999999,
"layouts": 11,
"layoutDurationMs": 3.295,
"taskDurationMs": 96.31800000000001,
"heapDeltaBytes": -13259856,
"heapUsedBytes": 70370668,
"domNodes": 98,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.578000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230772,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 438.1559999999354,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.466,
"layouts": 12,
"layoutDurationMs": 3.508,
"taskDurationMs": 90.971,
"heapDeltaBytes": 6597212,
"heapUsedBytes": 79679544,
"domNodes": 95,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.008999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 285.14499999994314,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9349999999999999,
"layouts": 76,
"layoutDurationMs": 15.117,
"taskDurationMs": 238.822,
"heapDeltaBytes": 9720328,
"heapUsedBytes": 95973568,
"domNodes": 4,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 105.99300000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670588235294122,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 266.45699999994577,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.212,
"layouts": 76,
"layoutDurationMs": 12.987,
"taskDurationMs": 212.943,
"heapDeltaBytes": 9426720,
"heapUsedBytes": 94679412,
"domNodes": 4,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 93.081,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 342.4289999999246,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2529999999999997,
"layouts": 76,
"layoutDurationMs": 14.928,
"taskDurationMs": 299.906,
"heapDeltaBytes": -6445728,
"heapUsedBytes": 110716320,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 105.94600000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 346.48299999992105,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.578,
"layouts": 76,
"layoutDurationMs": 14.829,
"taskDurationMs": 312.608,
"heapDeltaBytes": 27044576,
"heapUsedBytes": 144109372,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 110.66899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2283 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 33357d4bed5ceaf2f95fb74cab60162c699e341b
Full docs: ADR-DEVEX-LINT-0015 |
|
Exact-head repair 67e89b9: the release fixture still has the pre-main AgentFollowerHostSocket signature |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.57 #21785 +/- ##
=============================================
Coverage ? 84.17%
=============================================
Files ? 2856
Lines ? 158898
Branches ? 38252
=============================================
Hits ? 133748
Misses ? 24761
Partials ? 389
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backports #21686 to cloud/1.57. This repairs PM-2080: when a remote selection creates a dynamic-combo child only on the canvas, a subsequent human link now grows the missing document input before connecting it.
The port preserves the target branch API shape and includes the source black-box Playwright regression.
Testing
Source
Justification: Authorized Agent release backport under Christian’s standing backport review-and-merge grant. Target-native review and acceptance evidence are recorded above; REVIEW_REQUIRED alone is not a blocker under that grant, and unresolved human objections remain blocking.