Repository navigation
[backport cloud/1.56] fix(agent): send human links into dynamic-combo inputs - #21784
Conversation
…lacks (PM-2080) (#21686) When a user wires into a dynamic-combo child input (for example `resize_type.match` on Resize Image/Mask) and the bound document was made under a different combo selection, the link never reached the document the agent reads. Now the connect sends a `grow` for that slot, so the agent sees the wire, and a later disconnect lands too. Linear: [PM-2080](https://linear.app/comfyorg/issue/PM-2080) <details><summary>Full context for agent readers</summary> - A dynamic combo grows a child input only while the option that declares it is selected. `resize_type.match` exists only while `resize_type` is `match size`. - A document minted under another selection has no slot of that name. `mintConnect` resolves the target by name (`docInputIndex`), finds nothing, and `growForMissingSlot` only grew widget-backed and autogrow inputs. So the connect was dropped and reported as `agent_crdt_link_slot_not_in_doc`, and the later disconnect was dropped the same way. - [CLOUD-FRONTEND-PROD-2BG](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-2BG), the PM-2080 alert: `disconnect targets input resize_type.match of node 878135716359488`, release 1.55.18, 2026-10-12T19:37:28Z. The stack starts at the canvas link context menu (`LGraphCanvas.inner_clicked` → `LGraph.removeLink` → `emitGraphIntent` → `mintDisconnect`), so it was a human canvas edit, not an agent op or a reconcile pass. - The same user and node logged `connect targets input resize_type.match of node 878135716359488` at 19:27:48Z, ten minutes earlier. The connect was refused first, so the doc never had the link; the disconnect refusal is the tail of that. - The same refusal recurred on release 1.56.3 on another node (`1216303266011253`, 2026-10-17T13:36:26Z). `growForMissingSlot` also grows an input that the node definition resolves as a child of a dynamic input under the node's current widget values (`nodeDefStore.getInputSpecForWidget`, excluding top-level inputs). The payload is the same `{ name, type }` grow the autogrow path already sends, and the pinned applier appends the slot under that name. Static inputs the doc lacks are still reported, not grown. [#21250](#21250) (FE-3472) records every grow `growForMissingSlot` decides so a disconnect inside the echo window targets the predicted slot. **This is not a trivial rebase, correcting an earlier claim here.** #21250 replaces the `docInputIndex` call in both `mintConnect` and `mintDisconnect` with `resolveDocSlot`, which returns a predicted slot for an unechoed grow. Once this PR's dynamic grows are recorded there, a same-tick disconnect resolves to that predicted slot and never reaches `mintMissingSlotDisconnect`, so the unsent grow is no longer cancelled and `cancels an unsent dynamic-combo grow when disconnected in the same tick` fails. Whichever PR lands second has to order the pending-dynamic-slot check ahead of the predicted-slot fallback and clear both structures together. </details> - Unit (`docOpMinter.test.ts`): a real dynamic-combo node, a doc minted under the other option, then a human connect and disconnect, each applied through the pinned `@comfyorg/comfy-multi-player` applier and read back with `project()`. **Fails on `main`** (no op minted), passes with the fix. - Black-box (`browser_tests/tests/agent/agentDynamicComboChildLink.spec.ts`, `@cloud`): the agent switches the combo over the CRDT doc, the user drags a link into the grown child on the canvas, and the fake host's real applier must project the link on `resize_type.match`; then the link is deleted through `LGraph.removeLink` (the prod stack) and must clear. **Fails on `main`** (`Received: undefined`), passes with the fix; repeated 2x alongside `agentDynamicComboSetWidgetSilentlyDropped` and `agentAutogrowHandWiredLinkSurvivesSend` (6 passed). - `src/workbench/extensions/agent/crdt/` vitest suite: 1200 passed, 1 expected fail. `pnpm typecheck`, `typecheck:browser`, oxlint, oxfmt, and the pre-push knip/fallow/depcruise audits are clean. - After release: `agent_crdt_link_slot_not_in_doc` events whose input is a link-only dynamic-combo child such as `resize_type.match` should stop on releases carrying this. (cherry picked from commit 91e5cfa) (cherry picked from commit 57fe710a7a687c66a07512fba950f45c859e978d)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed target-native port against #21686 and cloud/1.56. Conflict resolution preserves the branch promoted-widget API while adding the dynamic-combo grow/connect path and source black-box regression. Local targeted suite: 133 tests green; browser typecheck, format, lint, and push gates green. Awaiting hosted production-build E2E.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-23T05:56:17.527Z",
"gitSha": "c754a25d37da0da4904ccbf10458491a87e54ff5",
"branch": "oploop-918f-backport-21686-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.739000000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.21,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.507,
"heapDeltaBytes": 1003408,
"heapUsedBytes": 69065704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.658,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2010.3530000000092,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.86600000000004,
"heapDeltaBytes": 962588,
"heapUsedBytes": 69871836,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.250000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.8879999999958,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.366,
"layouts": 12,
"layoutDurationMs": 4.505999999999999,
"taskDurationMs": 585.631,
"heapDeltaBytes": -2007864,
"heapUsedBytes": 65501188,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 118.80399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.7980000000289,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.846999999999998,
"layouts": 12,
"layoutDurationMs": 4.537,
"taskDurationMs": 642.965,
"heapDeltaBytes": -2480200,
"heapUsedBytes": 65030696,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 127.93299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.8899999999599,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.284999999999998,
"layouts": 6,
"layoutDurationMs": 1.3269999999999997,
"taskDurationMs": 259.287,
"heapDeltaBytes": 3918180,
"heapUsedBytes": 71369440,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.202000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.9850000000079,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.379,
"layouts": 6,
"layoutDurationMs": 1.31,
"taskDurationMs": 310.49899999999997,
"heapDeltaBytes": 4165356,
"heapUsedBytes": 71775460,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.469999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 534.3129999999974,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.399,
"heapDeltaBytes": -6356656,
"heapUsedBytes": 61402760,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.96099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 554.9179999999296,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.618,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.356,
"heapDeltaBytes": -6647408,
"heapUsedBytes": 60824316,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 118.15199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 922.172000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.205,
"heapDeltaBytes": 39237500,
"heapUsedBytes": 107755080,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 38.799,
"eventListeners": 0,
"totalBlockingTimeMs": 307,
"frameDurationMs": 27.778787878787874,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 913.1660000000466,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.8309999999999,
"heapDeltaBytes": 16155912,
"heapUsedBytes": 84305672,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 42.156,
"eventListeners": 0,
"totalBlockingTimeMs": 300,
"frameDurationMs": 27.778787878787874,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.9740000000402,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.995,
"heapDeltaBytes": 17526484,
"heapUsedBytes": 99127896,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 102.38999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 95,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 718.1279999999788,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.5910000000004,
"heapDeltaBytes": 13161064,
"heapUsedBytes": 127166008,
"domNodes": 0,
"jsHeapTotalBytes": 3411968,
"scriptDurationMs": 103.51099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 96,
"frameDurationMs": 21.079411764705878,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6640.8930000000055,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.007000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5653.222000000001,
"heapDeltaBytes": 15413492,
"heapUsedBytes": 82996920,
"domNodes": -142,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 4445.746,
"eventListeners": -70,
"totalBlockingTimeMs": 9,
"frameDurationMs": 22.31476510067114,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6072.063000000071,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.5259999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5149.045999999999,
"heapDeltaBytes": 10188856,
"heapUsedBytes": 94664904,
"domNodes": -142,
"jsHeapTotalBytes": -12193792,
"scriptDurationMs": 3949.9189999999994,
"eventListeners": -74,
"totalBlockingTimeMs": 8,
"frameDurationMs": 21.588967971530245,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6107.416000000001,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.4689999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5213.0689999999995,
"heapDeltaBytes": 1332636,
"heapUsedBytes": 69841708,
"domNodes": -142,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 4091.9000000000005,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.28241758241758,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6675.12899999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.1399999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5926.657999999999,
"heapDeltaBytes": 1523336,
"heapUsedBytes": 79179356,
"domNodes": -142,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 4640.057000000001,
"eventListeners": -74,
"totalBlockingTimeMs": 11,
"frameDurationMs": 24.690370370370374,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2007.7519999999822,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.818000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.832,
"heapDeltaBytes": -9705552,
"heapUsedBytes": 78592316,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.92299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.8939999999411,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.378000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.94200000000006,
"heapDeltaBytes": -10324240,
"heapUsedBytes": 77204208,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.11899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2130.7130000000143,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.378,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1123.3080000000002,
"heapDeltaBytes": -19967776,
"heapUsedBytes": 68769904,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 601.947,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2135.815999999977,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.456,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1295.058,
"heapDeltaBytes": -20104832,
"heapUsedBytes": 68449364,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 651.0369999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3124.734999999987,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.938,
"layouts": 60,
"layoutDurationMs": 15.866000000000001,
"taskDurationMs": 1236.5900000000001,
"heapDeltaBytes": -20596992,
"heapUsedBytes": 69395088,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 574.298,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666310160427805,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3139.214999999922,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.828999999999997,
"layouts": 60,
"layoutDurationMs": 17.551000000000002,
"taskDurationMs": 1347.469,
"heapDeltaBytes": -20728920,
"heapUsedBytes": 69139424,
"domNodes": 24,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 612.462,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2191.876000000036,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.459,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1374.0159999999998,
"heapDeltaBytes": 14121068,
"heapUsedBytes": 92006792,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 719.613,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793129770992365,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2289.188999999965,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.336000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1517.02,
"heapDeltaBytes": -14686188,
"heapUsedBytes": 68792724,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 787.941,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78897058823529,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2017.487000000017,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.181999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.95699999999994,
"heapDeltaBytes": -10409964,
"heapUsedBytes": 78463168,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 32.03199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.062000000029,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.900000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.121,
"heapDeltaBytes": -11317112,
"heapUsedBytes": 69035112,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.385,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 427.421000000038,
"styleRecalcs": 50,
"styleRecalcDurationMs": 7.478999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.64199999999994,
"heapDeltaBytes": -11546152,
"heapUsedBytes": 58397268,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 101.818,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.597000000038,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.207000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.666,
"heapDeltaBytes": -11879972,
"heapUsedBytes": 57606852,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.355,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2006.7700000000173,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.7619999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.79699999999997,
"heapDeltaBytes": 1208772,
"heapUsedBytes": 71984812,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.265999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.437000000048,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.511000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.12,
"heapDeltaBytes": -3253768,
"heapUsedBytes": 59035420,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.8059999999564,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.250999999999998,
"layouts": 16,
"layoutDurationMs": 6.3069999999999995,
"taskDurationMs": 562.885,
"heapDeltaBytes": -5860736,
"heapUsedBytes": 63286024,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 90.036,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.169000000059,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.565,
"layouts": 16,
"layoutDurationMs": 5.547999999999999,
"taskDurationMs": 623.796,
"heapDeltaBytes": -5776704,
"heapUsedBytes": 64434356,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 98.04499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1151.8669999999247,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.071,
"layouts": 5,
"layoutDurationMs": 9.815999999999999,
"taskDurationMs": 753.776,
"heapDeltaBytes": 1969664,
"heapUsedBytes": 88758436,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 26.406,
"eventListeners": 2463,
"totalBlockingTimeMs": 80,
"frameDurationMs": 18.81774193548387,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8140.090999999984,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4099.907,
"heapDeltaBytes": -18516644,
"heapUsedBytes": 69399216,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2036.931,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665983606557376,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8219.042999999943,
"styleRecalcs": 251,
"styleRecalcDurationMs": 47.477000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4525.803000000001,
"heapDeltaBytes": 7935232,
"heapUsedBytes": 95895712,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 2225.209,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69979674796748,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13216.42099999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12558.17,
"heapDeltaBytes": -38343980,
"heapUsedBytes": 186457164,
"domNodes": -3045,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 194.999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.35253378378378,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 14025.389000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13212.277,
"heapDeltaBytes": -31620444,
"heapUsedBytes": 181674544,
"domNodes": -3046,
"jsHeapTotalBytes": 9261056,
"scriptDurationMs": 218.65099999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.12409638554217,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 16520.613999999965,
"styleRecalcs": 107,
"styleRecalcDurationMs": 20.542000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16041.208,
"heapDeltaBytes": -26054084,
"heapUsedBytes": 187325576,
"domNodes": -3045,
"jsHeapTotalBytes": 10309632,
"scriptDurationMs": 702.2049999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 6,
"frameDurationMs": 30.677777777777777,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 15230.258999999933,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.656999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14806.689000000002,
"heapDeltaBytes": -25390604,
"heapUsedBytes": 182628560,
"domNodes": -3045,
"jsHeapTotalBytes": 11378688,
"scriptDurationMs": 644.139,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.54556962025316,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 5071.478000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.193,
"layouts": 20,
"layoutDurationMs": 29.203999999999994,
"taskDurationMs": 4964.6720000000005,
"heapDeltaBytes": 32526988,
"heapUsedBytes": 232002460,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 86.78800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.521084337349393,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 4791.860000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.511,
"layouts": 20,
"layoutDurationMs": 24.044999999999998,
"taskDurationMs": 4659.531999999999,
"heapDeltaBytes": -2972020,
"heapUsedBytes": 214395412,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 77.25500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.48908045977011,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6825.118999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6600.0019999999995,
"heapDeltaBytes": -20690764,
"heapUsedBytes": 187252104,
"domNodes": -3045,
"jsHeapTotalBytes": 14766080,
"scriptDurationMs": 106.06900000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.31708185053381,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6655.555999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6364.732,
"heapDeltaBytes": -33099912,
"heapUsedBytes": 180913332,
"domNodes": -3046,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 98.46100000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.40878378378378,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "workflow-execution",
"durationMs": 106.68300000008912,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.76,
"layouts": 3,
"layoutDurationMs": 1.724,
"taskDurationMs": 69.97800000000001,
"heapDeltaBytes": 3898688,
"heapUsedBytes": 69088644,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.545999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 438.0429999999933,
"styleRecalcs": 16,
"styleRecalcDurationMs": 16.596,
"layouts": 2,
"layoutDurationMs": 0.598,
"taskDurationMs": 91.95499999999998,
"heapDeltaBytes": 5665948,
"heapUsedBytes": 64884448,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.7540000000000004,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 391.9469999999592,
"styleRecalcs": 78,
"styleRecalcDurationMs": 71.711,
"layouts": 76,
"layoutDurationMs": 17.718,
"taskDurationMs": 357.58299999999997,
"heapDeltaBytes": -18515320,
"heapUsedBytes": 64622476,
"domNodes": 76,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 112.262,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669565217391288,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 582.3900000000322,
"styleRecalcs": 78,
"styleRecalcDurationMs": 96.558,
"layouts": 76,
"layoutDurationMs": 26.211000000000002,
"taskDurationMs": 536.229,
"heapDeltaBytes": -16379892,
"heapUsedBytes": 65708136,
"domNodes": 76,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 179.49200000000002,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 809.6470000000409,
"styleRecalcs": 78,
"styleRecalcDurationMs": 220.262,
"layouts": 76,
"layoutDurationMs": 26.152,
"taskDurationMs": 790.752,
"heapDeltaBytes": 10063292,
"heapUsedBytes": 128010504,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 195.639,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667346938775506,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1130.533000000014,
"styleRecalcs": 78,
"styleRecalcDurationMs": 313.041,
"layouts": 76,
"layoutDurationMs": 30.895,
"taskDurationMs": 1087.98,
"heapDeltaBytes": 12819952,
"heapUsedBytes": 135225076,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 276.266,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588237,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2205 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a208a074e6826b1becef2c850d473e2347b8cf52
Full docs: ADR-DEVEX-LINT-0015 |
|
Exact-head repair a2219e1: the failed video job correctly exposed a target-fixture API mismatch. This release still uses AgentFollowerHostSocket |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.56 #21784 +/- ##
=============================================
Coverage ? 83.15%
=============================================
Files ? 2397
Lines ? 128006
Branches ? 36834
=============================================
Hits ? 106446
Misses ? 21149
Partials ? 411
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backports #21686 to cloud/1.56. This repairs PM-2080: when a remote selection creates a dynamic-combo child only on the canvas, a subsequent human link now grows the missing document input before connecting it.
The port preserves the target branch API shape and includes the source black-box Playwright regression.
Testing
Source
Justification: Authorized Agent release backport under Christian’s standing backport review-and-merge grant. Target-native review and acceptance evidence are recorded above; REVIEW_REQUIRED alone is not a blocker under that grant, and unresolved human objections remain blocking.