Repository navigation
[backport core/1.56] fix(agent): send human links into dynamic-combo inputs - #21783
Conversation
…lacks (PM-2080) (#21686) When a user wires into a dynamic-combo child input (for example `resize_type.match` on Resize Image/Mask) and the bound document was made under a different combo selection, the link never reached the document the agent reads. Now the connect sends a `grow` for that slot, so the agent sees the wire, and a later disconnect lands too. Linear: [PM-2080](https://linear.app/comfyorg/issue/PM-2080) <details><summary>Full context for agent readers</summary> - A dynamic combo grows a child input only while the option that declares it is selected. `resize_type.match` exists only while `resize_type` is `match size`. - A document minted under another selection has no slot of that name. `mintConnect` resolves the target by name (`docInputIndex`), finds nothing, and `growForMissingSlot` only grew widget-backed and autogrow inputs. So the connect was dropped and reported as `agent_crdt_link_slot_not_in_doc`, and the later disconnect was dropped the same way. - [CLOUD-FRONTEND-PROD-2BG](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-2BG), the PM-2080 alert: `disconnect targets input resize_type.match of node 878135716359488`, release 1.55.18, 2026-10-12T19:37:28Z. The stack starts at the canvas link context menu (`LGraphCanvas.inner_clicked` → `LGraph.removeLink` → `emitGraphIntent` → `mintDisconnect`), so it was a human canvas edit, not an agent op or a reconcile pass. - The same user and node logged `connect targets input resize_type.match of node 878135716359488` at 19:27:48Z, ten minutes earlier. The connect was refused first, so the doc never had the link; the disconnect refusal is the tail of that. - The same refusal recurred on release 1.56.3 on another node (`1216303266011253`, 2026-10-17T13:36:26Z). `growForMissingSlot` also grows an input that the node definition resolves as a child of a dynamic input under the node's current widget values (`nodeDefStore.getInputSpecForWidget`, excluding top-level inputs). The payload is the same `{ name, type }` grow the autogrow path already sends, and the pinned applier appends the slot under that name. Static inputs the doc lacks are still reported, not grown. [#21250](#21250) (FE-3472) records every grow `growForMissingSlot` decides so a disconnect inside the echo window targets the predicted slot. **This is not a trivial rebase, correcting an earlier claim here.** #21250 replaces the `docInputIndex` call in both `mintConnect` and `mintDisconnect` with `resolveDocSlot`, which returns a predicted slot for an unechoed grow. Once this PR's dynamic grows are recorded there, a same-tick disconnect resolves to that predicted slot and never reaches `mintMissingSlotDisconnect`, so the unsent grow is no longer cancelled and `cancels an unsent dynamic-combo grow when disconnected in the same tick` fails. Whichever PR lands second has to order the pending-dynamic-slot check ahead of the predicted-slot fallback and clear both structures together. </details> - Unit (`docOpMinter.test.ts`): a real dynamic-combo node, a doc minted under the other option, then a human connect and disconnect, each applied through the pinned `@comfyorg/comfy-multi-player` applier and read back with `project()`. **Fails on `main`** (no op minted), passes with the fix. - Black-box (`browser_tests/tests/agent/agentDynamicComboChildLink.spec.ts`, `@cloud`): the agent switches the combo over the CRDT doc, the user drags a link into the grown child on the canvas, and the fake host's real applier must project the link on `resize_type.match`; then the link is deleted through `LGraph.removeLink` (the prod stack) and must clear. **Fails on `main`** (`Received: undefined`), passes with the fix; repeated 2x alongside `agentDynamicComboSetWidgetSilentlyDropped` and `agentAutogrowHandWiredLinkSurvivesSend` (6 passed). - `src/workbench/extensions/agent/crdt/` vitest suite: 1200 passed, 1 expected fail. `pnpm typecheck`, `typecheck:browser`, oxlint, oxfmt, and the pre-push knip/fallow/depcruise audits are clean. - After release: `agent_crdt_link_slot_not_in_doc` events whose input is a link-only dynamic-combo child such as `resize_type.match` should stop on releases carrying this. (cherry picked from commit 91e5cfa) (cherry picked from commit 57fe710a7a687c66a07512fba950f45c859e978d) (cherry picked from commit 123a00b3ee8e9680340f916ac63d5dbc4cb3d81b)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed target-native port against #21686 and core/1.56. Conflict resolution preserves the older branch API (including the absence of later promoted-widget plumbing) while adding the dynamic-combo grow/connect path and source black-box regression. Local targeted suite: 89 tests green; browser typecheck, format, lint, and push gates green. Awaiting hosted production-build E2E.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T05:57:57.349Z",
"gitSha": "3d32c51eca964c626f1dfeceb618cdd88589f5b9",
"branch": "oploop-918f-backport-21686-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.452999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.395000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.78799999999995,
"heapDeltaBytes": -2960364,
"heapUsedBytes": 57296292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.094000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2009.2779999999948,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.712000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.474,
"heapDeltaBytes": 981572,
"heapUsedBytes": 68100584,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.115,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.5540000000174,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.908,
"layouts": 12,
"layoutDurationMs": 4.2299999999999995,
"taskDurationMs": 754.794,
"heapDeltaBytes": -1715260,
"heapUsedBytes": 66186160,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.49900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.9420000000555,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.988999999999997,
"layouts": 12,
"layoutDurationMs": 4.237,
"taskDurationMs": 741.6129999999999,
"heapDeltaBytes": -2043600,
"heapUsedBytes": 65916648,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 139.099,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.1520000000314,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.9,
"layouts": 6,
"layoutDurationMs": 1.3679999999999999,
"taskDurationMs": 329.488,
"heapDeltaBytes": 4124920,
"heapUsedBytes": 72280344,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.927000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1697.4239999999554,
"styleRecalcs": 29,
"styleRecalcDurationMs": 10.288,
"layouts": 6,
"layoutDurationMs": 1.335,
"taskDurationMs": 331.164,
"heapDeltaBytes": 4095636,
"heapUsedBytes": 72250344,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.340999999999992,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 584.9949999999922,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8509999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.461,
"heapDeltaBytes": 15553304,
"heapUsedBytes": 75611896,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.33,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 632.1699999999737,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.016000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.468,
"heapDeltaBytes": -6792920,
"heapUsedBytes": 60767916,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 146.847,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1028.5910000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 695.834,
"heapDeltaBytes": 38623284,
"heapUsedBytes": 108173536,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 53.712999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 405,
"frameDurationMs": 30.391176470588242,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1012.0239999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 693.492,
"heapDeltaBytes": 15122400,
"heapUsedBytes": 85537372,
"domNodes": 0,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 51.496,
"eventListeners": 0,
"totalBlockingTimeMs": 395,
"frameDurationMs": 30.806060606060615,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.9019999999787,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.89799999999985,
"heapDeltaBytes": 18977120,
"heapUsedBytes": 95635552,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 128.248,
"eventListeners": 0,
"totalBlockingTimeMs": 166,
"frameDurationMs": 23.035294117647055,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 796.6499999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.5589999999997,
"heapDeltaBytes": 17680924,
"heapUsedBytes": 105250220,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 132.757,
"eventListeners": 0,
"totalBlockingTimeMs": 166,
"frameDurationMs": 23.529411764705884,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7306.209000000024,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0799999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6573.986000000001,
"heapDeltaBytes": 423520,
"heapUsedBytes": 85869472,
"domNodes": -142,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 5290.871,
"eventListeners": -74,
"totalBlockingTimeMs": 66,
"frameDurationMs": 25.8854609929078,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6698.1269999999995,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.3190000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6089.104,
"heapDeltaBytes": -16536636,
"heapUsedBytes": 67485856,
"domNodes": -142,
"jsHeapTotalBytes": -11931648,
"scriptDurationMs": 5021.204,
"eventListeners": -78,
"totalBlockingTimeMs": 53,
"frameDurationMs": 26.273725490196078,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7739.10699999999,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1520000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6934.946,
"heapDeltaBytes": -11081276,
"heapUsedBytes": 73908644,
"domNodes": -142,
"jsHeapTotalBytes": -10096640,
"scriptDurationMs": 5574.125999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 135,
"frameDurationMs": 26.482876712328764,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7378.978000000075,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.45,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6611.108000000001,
"heapDeltaBytes": 2495752,
"heapUsedBytes": 87401244,
"domNodes": -142,
"jsHeapTotalBytes": -12455936,
"scriptDurationMs": 5275.867,
"eventListeners": -78,
"totalBlockingTimeMs": 42,
"frameDurationMs": 24.97050847457627,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2008.2239999999842,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.067,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.973,
"heapDeltaBytes": -9349832,
"heapUsedBytes": 79023976,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 36.50000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.167999999965,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.076000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.653,
"heapDeltaBytes": -9550140,
"heapUsedBytes": 79081500,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.806000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2159.509000000014,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.427000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1418.0380000000002,
"heapDeltaBytes": -19633624,
"heapUsedBytes": 70192560,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 752.737,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665891472868214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2123.7770000000182,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1383.5549999999998,
"heapDeltaBytes": -19958692,
"heapUsedBytes": 69721036,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 721.645,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3352.4250000000393,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.767,
"layouts": 60,
"layoutDurationMs": 15.206000000000001,
"taskDurationMs": 1513.795,
"heapDeltaBytes": 1286604,
"heapUsedBytes": 69680976,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 711.197,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666169154228854,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3276.2709999999515,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.628,
"layouts": 60,
"layoutDurationMs": 14.405,
"taskDurationMs": 1460.1519999999998,
"heapDeltaBytes": 2125864,
"heapUsedBytes": 84521888,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 677.8149999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666326530612245,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2655.244000000039,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.942,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1720.5210000000002,
"heapDeltaBytes": 3457420,
"heapUsedBytes": 72851848,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 891.402,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77151898734177,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2391.796999999997,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.29,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1610.0240000000001,
"heapDeltaBytes": 5926880,
"heapUsedBytes": 74634780,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 833.1039999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7830985915493,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.1500000000292,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.3799999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.1479999999999,
"heapDeltaBytes": -8561296,
"heapUsedBytes": 81176616,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 37.941,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2013.2539999999608,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9880000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.2390000000001,
"heapDeltaBytes": -9016860,
"heapUsedBytes": 80811392,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.747,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 566.2640000000465,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.680000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.222,
"heapDeltaBytes": -11623488,
"heapUsedBytes": 58385912,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 129.344,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.3999999999833,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.3450000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.608,
"heapDeltaBytes": -11653100,
"heapUsedBytes": 57911644,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 120.53,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.2900000000122,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.705,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.49999999999994,
"heapDeltaBytes": 1388144,
"heapUsedBytes": 71498544,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.486000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.387999999968,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.9460000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.9480000000001,
"heapDeltaBytes": 1104504,
"heapUsedBytes": 71215296,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.249999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.337999999983,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.553,
"layouts": 16,
"layoutDurationMs": 5.391,
"taskDurationMs": 684.547,
"heapDeltaBytes": -5990416,
"heapUsedBytes": 64129304,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 100.73599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.7280000000037,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.215999999999998,
"layouts": 16,
"layoutDurationMs": 5.5440000000000005,
"taskDurationMs": 679.834,
"heapDeltaBytes": -5687172,
"heapUsedBytes": 63839532,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 98.811,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1318.6920000000555,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.152999999999995,
"layouts": 5,
"layoutDurationMs": 11.576999999999996,
"taskDurationMs": 861.1019999999999,
"heapDeltaBytes": 3000004,
"heapUsedBytes": 97809912,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 28.504999999999995,
"eventListeners": 2463,
"totalBlockingTimeMs": 95,
"frameDurationMs": 19.04714285714285,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8158.163000000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.264,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4916.0470000000005,
"heapDeltaBytes": -18991724,
"heapUsedBytes": 69742528,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2397.19,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666053169734152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8214.712000000076,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4740.267,
"heapDeltaBytes": -19265440,
"heapUsedBytes": 69730804,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2333.3689999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665922920892495,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16198.751000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15691.407000000001,
"heapDeltaBytes": -29539104,
"heapUsedBytes": 187607656,
"domNodes": -3045,
"jsHeapTotalBytes": 6098944,
"scriptDurationMs": 266.17900000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.638461538461538,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16076.891000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15457.054,
"heapDeltaBytes": -36197684,
"heapUsedBytes": 185455864,
"domNodes": -3045,
"jsHeapTotalBytes": 8757248,
"scriptDurationMs": 240.34599999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.925539568345325,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 19092.78999999998,
"styleRecalcs": 138,
"styleRecalcDurationMs": 20.482,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18851.067,
"heapDeltaBytes": -45835452,
"heapUsedBytes": 185027928,
"domNodes": -3045,
"jsHeapTotalBytes": 5177344,
"scriptDurationMs": 776.216,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.379619047619045,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17668.583000000013,
"styleRecalcs": 135,
"styleRecalcDurationMs": 16.08200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17357.652000000002,
"heapDeltaBytes": -50182032,
"heapUsedBytes": 167286300,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 702.268,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.10405405405405,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5941.180999999971,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.75500000000001,
"layouts": 20,
"layoutDurationMs": 26.185,
"taskDurationMs": 5838.305000000001,
"heapDeltaBytes": -12992732,
"heapUsedBytes": 217584916,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 102.07000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.61590909090909,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5747.406999999953,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.905000000000015,
"layouts": 20,
"layoutDurationMs": 23.398000000000003,
"taskDurationMs": 5646.857,
"heapDeltaBytes": 1224560,
"heapUsedBytes": 216915408,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 97.14399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.429940119760474,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8330.311999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8091.429999999999,
"heapDeltaBytes": -26341276,
"heapUsedBytes": 186003100,
"domNodes": -3045,
"jsHeapTotalBytes": 14233600,
"scriptDurationMs": 132.56,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.192028985507246,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8076.315000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7803.470000000001,
"heapDeltaBytes": -8531932,
"heapUsedBytes": 188559388,
"domNodes": -3044,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 118.62199999999994,
"eventListeners": -14907,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.826199261992624,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 120.13899999999467,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.8180000000000005,
"layouts": 2,
"layoutDurationMs": 0.563,
"taskDurationMs": 73.551,
"heapDeltaBytes": 3927096,
"heapUsedBytes": 69530712,
"domNodes": 97,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.506000000000006,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 92.32599999995728,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.2090000000000005,
"layouts": 2,
"layoutDurationMs": 0.562,
"taskDurationMs": 60.583999999999996,
"heapDeltaBytes": 3767788,
"heapUsedBytes": 69641612,
"domNodes": 94,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.211,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.649999999999938,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 609.6149999999625,
"styleRecalcs": 78,
"styleRecalcDurationMs": 86.69300000000001,
"layouts": 76,
"layoutDurationMs": 21.528,
"taskDurationMs": 581.01,
"heapDeltaBytes": -16756504,
"heapUsedBytes": 67717632,
"domNodes": 76,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 215.39299999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 861.393000000021,
"styleRecalcs": 78,
"styleRecalcDurationMs": 109.904,
"layouts": 76,
"layoutDurationMs": 28.738,
"taskDurationMs": 826.142,
"heapDeltaBytes": 17329088,
"heapUsedBytes": 82122428,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 310.627,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.33199999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1242.07100000001,
"styleRecalcs": 78,
"styleRecalcDurationMs": 256.919,
"layouts": 76,
"layoutDurationMs": 26.482,
"taskDurationMs": 1228.8300000000002,
"heapDeltaBytes": 8172980,
"heapUsedBytes": 115559452,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 379.965,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.88799999999999,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1095.1499999999896,
"styleRecalcs": 78,
"styleRecalcDurationMs": 242.839,
"layouts": 76,
"layoutDurationMs": 24.595,
"taskDurationMs": 1077.1200000000001,
"heapDeltaBytes": -21611928,
"heapUsedBytes": 108114648,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 315.687,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.741935483870968,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.6% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2202 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8cbd61677acedeb52a0204560a86e07eade0a499
Full docs: ADR-DEVEX-LINT-0015 |
|
Exact-head repair e698989: the release fixture still has the pre-main AgentFollowerHostSocket signature |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.56 #21783 +/- ##
============================================
Coverage 85.96% 85.97%
============================================
Files 2484 2484
Lines 141921 142071 +150
Branches 36677 38707 +2030
============================================
+ Hits 122003 122146 +143
- Misses 19534 19541 +7
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backports #21686 to core/1.56. This repairs PM-2080: when a remote selection creates a dynamic-combo child only on the canvas, a subsequent human link now grows the missing document input before connecting it.
The port preserves the target branch API shape and includes the source black-box Playwright regression.
Testing
Source
Justification: Authorized Agent release backport under Christian’s standing backport review-and-merge grant. Target-native review and acceptance evidence are recorded above; REVIEW_REQUIRED alone is not a blocker under that grant, and unresolved human objections remain blocking.