Repository navigation
[backport core/1.57] fix(agent): send human links into dynamic-combo inputs - #21782
Conversation
…lacks (PM-2080) (#21686) When a user wires into a dynamic-combo child input (for example `resize_type.match` on Resize Image/Mask) and the bound document was made under a different combo selection, the link never reached the document the agent reads. Now the connect sends a `grow` for that slot, so the agent sees the wire, and a later disconnect lands too. Linear: [PM-2080](https://linear.app/comfyorg/issue/PM-2080) <details><summary>Full context for agent readers</summary> - A dynamic combo grows a child input only while the option that declares it is selected. `resize_type.match` exists only while `resize_type` is `match size`. - A document minted under another selection has no slot of that name. `mintConnect` resolves the target by name (`docInputIndex`), finds nothing, and `growForMissingSlot` only grew widget-backed and autogrow inputs. So the connect was dropped and reported as `agent_crdt_link_slot_not_in_doc`, and the later disconnect was dropped the same way. - [CLOUD-FRONTEND-PROD-2BG](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-2BG), the PM-2080 alert: `disconnect targets input resize_type.match of node 878135716359488`, release 1.55.18, 2026-10-12T19:37:28Z. The stack starts at the canvas link context menu (`LGraphCanvas.inner_clicked` → `LGraph.removeLink` → `emitGraphIntent` → `mintDisconnect`), so it was a human canvas edit, not an agent op or a reconcile pass. - The same user and node logged `connect targets input resize_type.match of node 878135716359488` at 19:27:48Z, ten minutes earlier. The connect was refused first, so the doc never had the link; the disconnect refusal is the tail of that. - The same refusal recurred on release 1.56.3 on another node (`1216303266011253`, 2026-10-17T13:36:26Z). `growForMissingSlot` also grows an input that the node definition resolves as a child of a dynamic input under the node's current widget values (`nodeDefStore.getInputSpecForWidget`, excluding top-level inputs). The payload is the same `{ name, type }` grow the autogrow path already sends, and the pinned applier appends the slot under that name. Static inputs the doc lacks are still reported, not grown. [#21250](#21250) (FE-3472) records every grow `growForMissingSlot` decides so a disconnect inside the echo window targets the predicted slot. **This is not a trivial rebase, correcting an earlier claim here.** #21250 replaces the `docInputIndex` call in both `mintConnect` and `mintDisconnect` with `resolveDocSlot`, which returns a predicted slot for an unechoed grow. Once this PR's dynamic grows are recorded there, a same-tick disconnect resolves to that predicted slot and never reaches `mintMissingSlotDisconnect`, so the unsent grow is no longer cancelled and `cancels an unsent dynamic-combo grow when disconnected in the same tick` fails. Whichever PR lands second has to order the pending-dynamic-slot check ahead of the predicted-slot fallback and clear both structures together. </details> - Unit (`docOpMinter.test.ts`): a real dynamic-combo node, a doc minted under the other option, then a human connect and disconnect, each applied through the pinned `@comfyorg/comfy-multi-player` applier and read back with `project()`. **Fails on `main`** (no op minted), passes with the fix. - Black-box (`browser_tests/tests/agent/agentDynamicComboChildLink.spec.ts`, `@cloud`): the agent switches the combo over the CRDT doc, the user drags a link into the grown child on the canvas, and the fake host's real applier must project the link on `resize_type.match`; then the link is deleted through `LGraph.removeLink` (the prod stack) and must clear. **Fails on `main`** (`Received: undefined`), passes with the fix; repeated 2x alongside `agentDynamicComboSetWidgetSilentlyDropped` and `agentAutogrowHandWiredLinkSurvivesSend` (6 passed). - `src/workbench/extensions/agent/crdt/` vitest suite: 1200 passed, 1 expected fail. `pnpm typecheck`, `typecheck:browser`, oxlint, oxfmt, and the pre-push knip/fallow/depcruise audits are clean. - After release: `agent_crdt_link_slot_not_in_doc` events whose input is a link-only dynamic-combo child such as `resize_type.match` should stop on releases carrying this. (cherry picked from commit 91e5cfa)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed target-native port against #21686 and core/1.57. Conflict resolution preserves the branch follower/promoted-widget API while adding the dynamic-combo grow/connect path and source black-box regression. Local targeted suite: 162 tests green; browser typecheck, format, lint, and push gates green. Awaiting hosted production-build E2E.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T05:57:30.290Z",
"gitSha": "80c4ef0ed485fc7eeffa868483ab51a250b33a77",
"branch": "oploop-918f-backport-21686-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.019999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4949999999999997,
"layouts": 9,
"layoutDurationMs": 2.392,
"taskDurationMs": 496.24800000000005,
"heapDeltaBytes": -926264,
"heapUsedBytes": 74515536,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.412999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2008.416000000011,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.95,
"layouts": 10,
"layoutDurationMs": 2.8320000000000003,
"taskDurationMs": 487.55099999999993,
"heapDeltaBytes": 2989052,
"heapUsedBytes": 78154696,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 9.048999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1975.091999999961,
"styleRecalcs": 84,
"styleRecalcDurationMs": 15.369000000000002,
"layouts": 10,
"layoutDurationMs": 2.98,
"taskDurationMs": 1025.0590000000002,
"heapDeltaBytes": -7782228,
"heapUsedBytes": 67153268,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 147.847,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66638655462185,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1991.7140000000018,
"styleRecalcs": 85,
"styleRecalcDurationMs": 15.313,
"layouts": 11,
"layoutDurationMs": 3.3970000000000002,
"taskDurationMs": 1027.659,
"heapDeltaBytes": -8252708,
"heapUsedBytes": 66815968,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 143.22899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487396,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.7919999999795,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.756000000000001,
"layouts": 11,
"layoutDurationMs": 2.7289999999999996,
"taskDurationMs": 274.839,
"heapDeltaBytes": 18740860,
"heapUsedBytes": 84631256,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.959000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.084000000038,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.159,
"layouts": 13,
"layoutDurationMs": 3.3019999999999996,
"taskDurationMs": 375.465,
"heapDeltaBytes": -4541284,
"heapUsedBytes": 70960068,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.256000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 644.030999999984,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.907999999999999,
"layouts": 10,
"layoutDurationMs": 2.738,
"taskDurationMs": 467.996,
"heapDeltaBytes": 7804412,
"heapUsedBytes": 82258548,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 160.71699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 666.5749999999662,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.5720000000000005,
"layouts": 8,
"layoutDurationMs": 2.1220000000000003,
"taskDurationMs": 480.558,
"heapDeltaBytes": -1020200,
"heapUsedBytes": 65305940,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 162.525,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307703,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1153.683000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 807.852,
"heapDeltaBytes": -11248056,
"heapUsedBytes": 81363228,
"domNodes": -192,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 61.17499999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 489,
"frameDurationMs": 31.94166666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1162.924999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 857.3940000000001,
"heapDeltaBytes": -3838784,
"heapUsedBytes": 81405300,
"domNodes": -192,
"jsHeapTotalBytes": 14426112,
"scriptDurationMs": 55.358999999999995,
"eventListeners": -106,
"totalBlockingTimeMs": 486,
"frameDurationMs": 31.52972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.8289999999852,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.85199999999963,
"heapDeltaBytes": -4825404,
"heapUsedBytes": 76123232,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 135.86700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 832.9720000000407,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.28700000000055,
"heapDeltaBytes": -4089388,
"heapUsedBytes": 76376264,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 139.03400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 213,
"frameDurationMs": 25.251515151515157,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9710.794999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8773.67,
"heapDeltaBytes": -28657332,
"heapUsedBytes": 70741756,
"domNodes": -258,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 7020.884,
"eventListeners": -68,
"totalBlockingTimeMs": 308,
"frameDurationMs": 28.27871720116618,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9306.728000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8344.624,
"heapDeltaBytes": -25383328,
"heapUsedBytes": 74455136,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 6716.533,
"eventListeners": -68,
"totalBlockingTimeMs": 156,
"frameDurationMs": 27.892814371257487,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8957.630000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8041.557000000001,
"heapDeltaBytes": -9591312,
"heapUsedBytes": 84546984,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 6393.453,
"eventListeners": -68,
"totalBlockingTimeMs": 151,
"frameDurationMs": 27.588615384615384,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9423.333999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8514.739000000001,
"heapDeltaBytes": 8115456,
"heapUsedBytes": 85027316,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 6855.817,
"eventListeners": -68,
"totalBlockingTimeMs": 146,
"frameDurationMs": 28.192514970059882,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 188.89899999999216,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.104,
"layouts": 10,
"layoutDurationMs": 2.904,
"taskDurationMs": 145.104,
"heapDeltaBytes": -8094868,
"heapUsedBytes": 79226052,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.724999999999998,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.899999999999977,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 209.0450000000601,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.934999999999999,
"layouts": 11,
"layoutDurationMs": 3.1350000000000002,
"taskDurationMs": 158.76700000000002,
"heapDeltaBytes": -8146240,
"heapUsedBytes": 79286656,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.324,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2041.214000000025,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.346,
"layouts": 9,
"layoutDurationMs": 2.4229999999999996,
"taskDurationMs": 633.702,
"heapDeltaBytes": -21534672,
"heapUsedBytes": 75442752,
"domNodes": -258,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 40.048,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.90600000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.450999999999999,
"layouts": 9,
"layoutDurationMs": 2.3559999999999994,
"taskDurationMs": 611.246,
"heapDeltaBytes": -21665172,
"heapUsedBytes": 75610148,
"domNodes": -258,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 32.955999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2243.815999999981,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.105,
"layouts": 7,
"layoutDurationMs": 1.7760000000000002,
"taskDurationMs": 1563.152,
"heapDeltaBytes": -30894552,
"heapUsedBytes": 67481480,
"domNodes": -258,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 754.533,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925922,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2237.5710000000026,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.095000000000001,
"layouts": 6,
"layoutDurationMs": 1.576,
"taskDurationMs": 1397.701,
"heapDeltaBytes": 11558012,
"heapUsedBytes": 92297376,
"domNodes": -278,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 751.0479999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79172932330827,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3503.624000000002,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.429,
"layouts": 64,
"layoutDurationMs": 11.11,
"taskDurationMs": 1655.162,
"heapDeltaBytes": -2117264,
"heapUsedBytes": 97388924,
"domNodes": 24,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 757.282,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.745454545454546,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3618.2489999999916,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.787,
"layouts": 65,
"layoutDurationMs": 11.584000000000001,
"taskDurationMs": 1699.6039999999998,
"heapDeltaBytes": 2842768,
"heapUsedBytes": 84476124,
"domNodes": 24,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 790.197,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2610.4080000000067,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.019,
"layouts": 6,
"layoutDurationMs": 1.6330000000000002,
"taskDurationMs": 1679.3020000000004,
"heapDeltaBytes": 11501200,
"heapUsedBytes": 94545536,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 940.896,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.881818181818183,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2777.5030000000243,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.0089999999999995,
"layouts": 5,
"layoutDurationMs": 1.2960000000000003,
"taskDurationMs": 1853.4219999999998,
"heapDeltaBytes": 3438524,
"heapUsedBytes": 82064476,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 927.4089999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.97134146341463,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2036.4640000000236,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.457,
"layouts": 8,
"layoutDurationMs": 2.142,
"taskDurationMs": 460.12399999999997,
"heapDeltaBytes": -2651140,
"heapUsedBytes": 78541348,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 35.471999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.092000000025,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.047,
"layouts": 7,
"layoutDurationMs": 1.9020000000000006,
"taskDurationMs": 613.063,
"heapDeltaBytes": -6212288,
"heapUsedBytes": 76017076,
"domNodes": -278,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 30.826000000000008,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.9139999999916,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.446000000000001,
"layouts": 8,
"layoutDurationMs": 2.325,
"taskDurationMs": 361.031,
"heapDeltaBytes": 21651604,
"heapUsedBytes": 88578452,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 143.61599999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.190624999999983,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.9570000000031,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.063000000000001,
"layouts": 10,
"layoutDurationMs": 2.481,
"taskDurationMs": 421.881,
"heapDeltaBytes": -1114252,
"heapUsedBytes": 76384580,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 144.964,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.4160000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5669999999999997,
"layouts": 9,
"layoutDurationMs": 2.396,
"taskDurationMs": 495.68199999999996,
"heapDeltaBytes": -217512,
"heapUsedBytes": 76823020,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 8.536000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.1730000000325,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4730000000000003,
"layouts": 10,
"layoutDurationMs": 2.589,
"taskDurationMs": 344.389,
"heapDeltaBytes": 22309060,
"heapUsedBytes": 90232496,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.399000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1957.8030000000126,
"styleRecalcs": 86,
"styleRecalcDurationMs": 17.256,
"layouts": 9,
"layoutDurationMs": 2.2640000000000002,
"taskDurationMs": 970.9680000000001,
"heapDeltaBytes": 11736844,
"heapUsedBytes": 79053824,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 100.895,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1972.8999999999814,
"styleRecalcs": 87,
"styleRecalcDurationMs": 16.369000000000003,
"layouts": 9,
"layoutDurationMs": 2.361,
"taskDurationMs": 973.195,
"heapDeltaBytes": 11639972,
"heapUsedBytes": 78608788,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 103.56,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.9380000000256,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.901,
"layouts": 5,
"layoutDurationMs": 14.974000000000002,
"taskDurationMs": 996.275,
"heapDeltaBytes": 7432060,
"heapUsedBytes": 99654788,
"domNodes": 15953,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 29.012000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 140,
"frameDurationMs": 19.634246575342456,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8453.888000000006,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.955,
"layouts": 7,
"layoutDurationMs": 1.858,
"taskDurationMs": 5445.342999999999,
"heapDeltaBytes": -10664964,
"heapUsedBytes": 68653928,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 2504.985,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698814229249013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8436.892999999942,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.386,
"layouts": 7,
"layoutDurationMs": 1.8349999999999997,
"taskDurationMs": 5519.12,
"heapDeltaBytes": 5767304,
"heapUsedBytes": 85392744,
"domNodes": -258,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2544.7980000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.731944444444444,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23434.02100000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22853.212,
"heapDeltaBytes": -42443992,
"heapUsedBytes": 262617728,
"domNodes": -3330,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 351.10200000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.254401408450704,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23089.703999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22484.961,
"heapDeltaBytes": -6328176,
"heapUsedBytes": 276309592,
"domNodes": -3330,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 349.784,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.073611111111106,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27815.191999999966,
"styleRecalcs": 180,
"styleRecalcDurationMs": 16.154000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27392.517,
"heapDeltaBytes": -23345360,
"heapUsedBytes": 277222040,
"domNodes": -3330,
"jsHeapTotalBytes": 9166848,
"scriptDurationMs": 850.5899999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 19,
"frameDurationMs": 51.51018518518518,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 19685.09199999994,
"styleRecalcs": 161,
"styleRecalcDurationMs": 13.424999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19275.849000000002,
"heapDeltaBytes": 18191680,
"heapUsedBytes": 290406724,
"domNodes": -3330,
"jsHeapTotalBytes": 15912960,
"scriptDurationMs": 845.2800000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 22,
"frameDurationMs": 36.35101663585952,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8294.626000000051,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.35800000000002,
"layouts": 20,
"layoutDurationMs": 28.426999999999992,
"taskDurationMs": 8179.1669999999995,
"heapDeltaBytes": -3589716,
"heapUsedBytes": 277898864,
"domNodes": -3330,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 152.46599999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.76298342541437,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8285.303999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.504,
"layouts": 20,
"layoutDurationMs": 22.289,
"taskDurationMs": 8153.582,
"heapDeltaBytes": -8772968,
"heapUsedBytes": 273389544,
"domNodes": -3330,
"jsHeapTotalBytes": 22794240,
"scriptDurationMs": 137.07799999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.60344827586206,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8023.687999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7521.602999999999,
"heapDeltaBytes": 22987196,
"heapUsedBytes": 274259484,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.76700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.700344827586203,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8136.254000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7596.555999999998,
"heapDeltaBytes": -8562884,
"heapUsedBytes": 255429108,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.43399999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.044827586206896,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 506.4289999999687,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.384999999999998,
"layouts": 12,
"layoutDurationMs": 4.487,
"taskDurationMs": 158.632,
"heapDeltaBytes": -12946600,
"heapUsedBytes": 70659304,
"domNodes": 126,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 11.525,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 484.79999999995016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 11.785,
"layouts": 12,
"layoutDurationMs": 4.374999999999999,
"taskDurationMs": 119.71299999999998,
"heapDeltaBytes": 6724588,
"heapUsedBytes": 79662308,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.335999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 523.5069999999951,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.276,
"layouts": 76,
"layoutDurationMs": 16.337999999999997,
"taskDurationMs": 458.40000000000003,
"heapDeltaBytes": -13139632,
"heapUsedBytes": 81441292,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 220.965,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 456.3979999999219,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9940000000000001,
"layouts": 76,
"layoutDurationMs": 15.2,
"taskDurationMs": 409.115,
"heapDeltaBytes": 11285652,
"heapUsedBytes": 87261940,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 196.606,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 518.7349999999924,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.019,
"layouts": 76,
"layoutDurationMs": 14.337000000000002,
"taskDurationMs": 478.498,
"heapDeltaBytes": 382360,
"heapUsedBytes": 127296728,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 194.041,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.203225806451588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 462.95499999996537,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.078,
"layouts": 76,
"layoutDurationMs": 13.658999999999999,
"taskDurationMs": 421.354,
"heapDeltaBytes": -449652,
"heapUsedBytes": 121995872,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 161.71099999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2282 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 893e850fff1af7ec4b67a1c4e3ce9b7d669f605b
Full docs: ADR-DEVEX-LINT-0015 |
|
Exact-head repair 6a0e14c: the release fixture still has the pre-main AgentFollowerHostSocket signature |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.57 #21782 +/- ##
=============================================
- Coverage 85.81% 84.12% -1.70%
=============================================
Files 2704 2840 +136
Lines 152004 158033 +6029
Branches 38469 40633 +2164
=============================================
+ Hits 130446 132939 +2493
- Misses 21170 24705 +3535
- Partials 388 389 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 325 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…22241) ## Summary The backport bot skips a release branch once its own backport PR merged (Comfy-Org#21994). A backport someone made by hand, from a branch the bot did not create, was not seen, so the bot retried that branch. This counts a merged PR to the target as done when: - its title starts with `[backport <target>]` or `[<target>]`, and - it is not a revert and not the bot's backport of another PR (`backport-<M>-to-*`), and - it says it carries the source PR: the title ends with `(#N)`, the head branch has `N` next to `backport` (`backport-N...`, `.../N-backport...`), or a body line starts with `Backport of #N` / `Backport of https://github.com/Comfy-Org/ComfyUI_frontend/pull/N`, and - it is not from a fork. A body or title that only mentions the PR ("Not included: #N", "follow-up to the backport of #N", a PR in another repo) does not count, and neither does a ticket number in a branch name (`be-22010-...` is not FE PR 22010). A false match would skip a needed backport and drop `needs-backport`, so the rule leans toward missing a hand-made backport (old behaviour: retry) over a false skip. Candidates come from listing up to 300 merged PRs on the target (core/1.58 has 64 today), not the search API, so a PR named only in its branch is found and there is no index lag. The target name is compared case-insensitively. The run log shows it as `core/1.58 (merged PR Comfy-Org#21580, made by hand)`. `force_rerun` still retries everything. Fixes FRONT-3651 ## Testing - `scripts/cicd/pr-backport-filter.test.ts`: the match cases were red before the workflow change, and the three mention-only cases were red against the first, broader rule. 28/28 green now; each tightening was red against the commit before it. - Ran the query against real merged PRs. Correct matches: Comfy-Org#21579 to Comfy-Org#21580 and Comfy-Org#21694 to Comfy-Org#21799 (both made by hand, core/1.58), Comfy-Org#21708 to Comfy-Org#21798, Comfy-Org#21285 to Comfy-Org#22223, Comfy-Org#21686 to Comfy-Org#21782. Correctly no match: Comfy-Org#21841 on core/1.57 (Comfy-Org#22051 says "Not included: Comfy-Org#21841") and Comfy-Org#21532 on core/1.58 (Comfy-Org#22232 says it is not on that line), and Comfy-Org#22010 on core/1.58 (Comfy-Org#21580's branch `be-22010-...` is a ticket key). - The existing skip of bot backports was re-checked live: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40871266552 skipped all four targets of Comfy-Org#21829. ## Known limit A hand-made backport whose title has no target prefix, or that does not name the source PR, is still not detected. The bot then retries it as before, and the cherry-pick either conflicts or finds the commit already present.
Summary
Backports #21686 to core/1.57. This repairs PM-2080: when a remote selection creates a dynamic-combo child only on the canvas, a subsequent human link now grows the missing document input before connecting it.
The port preserves the target branch API shape and includes the source black-box Playwright regression.
Testing
Source
Justification: Authorized Agent release backport under Christian’s standing backport review-and-merge grant. Target-native review and acceptance evidence are recorded above; REVIEW_REQUIRED alone is not a blocker under that grant, and unresolved human objections remain blocking.