Skip to content

[backport cloud/1.58] fix(auth): stop session-only Desktop sign-in redirect loop - #21778

Merged
comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-21768-to-cloud-1.58
Oct 23, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-21768-to-cloud-1.58

Conversation

@benceruleanlu

Copy link
Copy Markdown
Member

Backport of #21768 to cloud/1.58.

The automatic backport stopped on a conflict in src/router.ts. On cloud/1.58 the auth guard still calls next(...), while main returns the location. This resolves it by passing the same location to next:

return next({
  name: 'cloud-login',
  query: needsFirebaseForDesktopCode ? { switchAccount: 'true' } : undefined
})

Taking main's return { ... } as-is would hang navigation instead, because vue-router ignores the return value of a guard that takes next. The test file applied cleanly. No open cloud/1.58 backport touches src/router.ts, so this is a real conflict rather than a stacking one.

Verification

  • webSessionFlagOn.test.ts, desktopLoginRedemption.test.ts and onboardingCloudRoutes.test.ts on this branch: 300 passed, retries disabled.
  • With the router change reverted, the 4 new login/account-check loop cases fail, as they do on main.
  • Repository commit and push hooks passed.

Change breakdown

Changed lines = additions + deletions; no merge-only changes.

Category Files and paths Added Deleted Changed Share
Product code 1: src/router.ts 6 1 7 17.1%
Test code 1: src/platform/auth/webSessionFlagOn.test.ts 24 10 34 82.9%
Total 2 files 30 11 41 100%

No documentation, configuration, generated files, lockfiles, or vendored code changed.

A Desktop sign-in opened in a browser with a valid Comfy session but no
Firebase login could bounce indefinitely between the login and
account-check pages. Preserve `switchAccount=true` when account-check
sends this legacy handoff back to login, so the login form remains
available and the pending Desktop code is retained.

This is the immediate redirect repair. It does not change authentication
requirements, enable shared Desktop sessions, or depend on the
account-session migration. Related report:
[DESK2-182](https://linear.app/comfyorg/issue/DESK2-182).

- Both affected suites pass: 268 tests, retries disabled.
- The new login/account-check entry cases fail on the original code
because navigation repeats. All six entry-point/flag combinations pass
with the fix, including shuffled seed 20261023.
- Full shuffled seed 20261022 exposes two pre-existing SSO-hint
failures; the same failures reproduce on unchanged base `9bc3e1d697`. No
tests were skipped or weakened.
- Repository commit and push checks run through the normal hooks.
- Not yet deployed or validated as a packaged release.

Changed lines = additions + deletions; no merge-only changes.

| Category | Files and paths | Added | Deleted | Changed | Share |
|---|---|---:|---:|---:|---:|
| Product code | 1: `src/router.ts` | 6 | 1 | 7 | 17.1% |
| Test code | 1: `src/platform/auth/webSessionFlagOn.test.ts` | 24 | 10
| 34 | 82.9% |
| Total | 2 files | 30 | 11 | 41 | 100% |

No documentation, configuration, generated files, lockfiles, or vendored
code changed.

(cherry picked from commit 0d6d197)
@benceruleanlu benceruleanlu added the backport Backporting a PR onto a release candidate label Oct 23, 2026
@benceruleanlu
benceruleanlu requested a review from a team as a code owner October 23, 2026 03:41
@benceruleanlu benceruleanlu added the backport Backporting a PR onto a release candidate label Oct 23, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T03:43:26.916707Z a628dfd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 93.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.8 MB heap
dom-widget-clipping: · 58.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.4 MB heap
dom-widget-order-dense-n200-w200-i120: · 30.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 531ms TBT · 97.9 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 40.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 217ms TBT · 92.8 MB heap
extension-clean-combined-draw: · 31.1 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1382ms TBT · 141.2 MB heap
extension-rgthree-prototype-draw: · 31.5 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 1096ms TBT · 144.6 MB heap
large-combo-open: · 42.0 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 4ms TBT · 114.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.4 MB heap
large-graph-pan: · 59.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 105.7 MB heap
large-graph-zoom: · 59.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.4 MB heap
legacy-node-drag: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 98.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 110.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.1 MB heap
subgraph-transition-enter: · 50.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 165ms TBT · 128.5 MB heap
viewport-pan-sweep: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
vue-large-graph-idle: · 35.1 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 289.0 MB heap
vue-large-graph-pan: · 19.2 avg FPS · 9.2 P5 FPS ❌ (target: ≥52) · 12ms TBT · 279.1 MB heap
vue-node-resize-workload: · 21.2 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 276.2 MB heap
vue-zoom-out-idle: · 25.4 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 270.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 97.5 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.3 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 113.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 10
canvas-idle: style recalc count 10
canvas-idle: task duration 565ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 93.0 MB
canvas-idle: DOM nodes -180
canvas-idle: event listeners -130
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 840ms
canvas-mouse-sweep: script duration 175ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 86.9 MB
canvas-mouse-sweep: DOM nodes -190
canvas-mouse-sweep: event listeners -130
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 6ms
canvas-zoom-sweep: layout count 12
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 320ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 84.8 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 9
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 520ms
dom-widget-clipping: script duration 172ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 99.4 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 33ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 939ms
dom-widget-order-dense-n200-w200-i120: script duration 72ms
dom-widget-order-dense-n200-w200-i120: TBT 531ms
dom-widget-order-dense-n200-w200-i120: heap used 97.9 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -230
dom-widget-order-dense-n200-w200-i120: event listeners -168
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 495ms
dom-widget-order-sparse-n1000-w20-i120: script duration 159ms
dom-widget-order-sparse-n1000-w20-i120: TBT 217ms
dom-widget-order-sparse-n1000-w20-i120: heap used 92.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 67ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9967ms
extension-clean-combined-draw: script duration 8246ms
extension-clean-combined-draw: TBT 1382ms
extension-clean-combined-draw: heap used 141.2 MB
extension-clean-combined-draw: DOM nodes -276
extension-clean-combined-draw: event listeners -130
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 58ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9531ms
extension-rgthree-prototype-draw: script duration 7808ms
extension-rgthree-prototype-draw: TBT 1096ms
extension-rgthree-prototype-draw: heap used 144.6 MB
extension-rgthree-prototype-draw: DOM nodes -276
extension-rgthree-prototype-draw: event listeners -128
large-combo-open: avg frame time 24ms
large-combo-open: p95 frame time 83ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 15ms
large-combo-open: layout count 11
large-combo-open: style recalc count 23
large-combo-open: task duration 167ms
large-combo-open: script duration 9ms
large-combo-open: TBT 4ms
large-combo-open: heap used 114.9 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 3ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 9
large-graph-idle: task duration 603ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 101.4 MB
large-graph-idle: DOM nodes -286
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 7
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1573ms
large-graph-pan: script duration 822ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 105.7 MB
large-graph-pan: DOM nodes -286
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 64
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1796ms
large-graph-zoom: script duration 817ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 85.4 MB
large-graph-zoom: DOM nodes -262
large-graph-zoom: event listeners -130
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 5
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1829ms
legacy-node-drag: script duration 977ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 98.3 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 7
minimap-idle: style recalc count 8
minimap-idle: task duration 690ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 92.0 MB
minimap-idle: DOM nodes -296
minimap-idle: event listeners -130
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 9
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 467ms
subgraph-dom-widget-clipping: script duration 149ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 110.8 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 10
subgraph-idle: task duration 527ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 92.3 MB
subgraph-idle: DOM nodes -208
subgraph-idle: event listeners -176
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 15ms
subgraph-mouse-sweep: layout count 9
subgraph-mouse-sweep: style recalc count 82
subgraph-mouse-sweep: task duration 924ms
subgraph-mouse-sweep: script duration 116ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 90.1 MB
subgraph-mouse-sweep: DOM nodes -95
subgraph-mouse-sweep: event listeners -84
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1129ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 165ms
subgraph-transition-enter: heap used 128.5 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 31ms
viewport-pan-sweep: layout count 8
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 5903ms
viewport-pan-sweep: script duration 2831ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.0 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 29ms
vue-large-graph-idle: p95 frame time 50ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15540ms
vue-large-graph-idle: script duration 255ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 289.0 MB
vue-large-graph-idle: DOM nodes -3344
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 52ms
vue-large-graph-pan: p95 frame time 108ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 27980ms
vue-large-graph-pan: script duration 879ms
vue-large-graph-pan: TBT 12ms
vue-large-graph-pan: heap used 279.1 MB
vue-large-graph-pan: DOM nodes -3344
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 47ms
vue-node-resize-workload: p95 frame time 100ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 88ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 8168ms
vue-node-resize-workload: script duration 123ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 276.2 MB
vue-node-resize-workload: DOM nodes -3344
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 39ms
vue-zoom-out-idle: p95 frame time 83ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 11089ms
vue-zoom-out-idle: script duration 158ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 270.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 4ms
workflow-execution: style recalc duration 11ms
workflow-execution: layout count 10
workflow-execution: style recalc count 15
workflow-execution: task duration 115ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 97.5 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 14ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 394ms
agent-composer-empty-conversation-typing: script duration 188ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 77.3 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 15ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 532ms
agent-composer-long-conversation-typing: script duration 215ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 113.0 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 294
Raw data
{
  "timestamp": "2026-10-23T03:54:34.674Z",
  "gitSha": "ba9613f92560769164e9ff6cdf5d661f0df2afc0",
  "branch": "backport-21768-to-cloud-1.58",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2056.442000000004,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.5149999999999997,
      "layouts": 10,
      "layoutDurationMs": 3.5889999999999995,
      "taskDurationMs": 666.552,
      "heapDeltaBytes": 6543340,
      "heapUsedBytes": 96266096,
      "domNodes": -180,
      "jsHeapTotalBytes": 2007040,
      "scriptDurationMs": 14.364999999999998,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2025.983999999994,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.616,
      "layouts": 10,
      "layoutDurationMs": 3.2300000000000004,
      "taskDurationMs": 462.474,
      "heapDeltaBytes": 8918576,
      "heapUsedBytes": 98700576,
      "domNodes": -180,
      "jsHeapTotalBytes": 2269184,
      "scriptDurationMs": 12.005999999999998,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1808.1320000000005,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 13.682,
      "layouts": 9,
      "layoutDurationMs": 2.4869999999999997,
      "taskDurationMs": 833.602,
      "heapDeltaBytes": -4014476,
      "heapUsedBytes": 86141352,
      "domNodes": -200,
      "jsHeapTotalBytes": 2269184,
      "scriptDurationMs": 176.526,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666055045871556,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1759.1039999999794,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 15.014,
      "layouts": 10,
      "layoutDurationMs": 2.9370000000000003,
      "taskDurationMs": 847.013,
      "heapDeltaBytes": 6363004,
      "heapUsedBytes": 96118124,
      "domNodes": -180,
      "jsHeapTotalBytes": 2269184,
      "scriptDurationMs": 174.144,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666037735849056,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.8400000000051,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 5.604,
      "layouts": 12,
      "layoutDurationMs": 3.4859999999999993,
      "taskDurationMs": 321.375,
      "heapDeltaBytes": -1742820,
      "heapUsedBytes": 88851620,
      "domNodes": 47,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 13.923000000000002,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384617,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.6679999999278,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.824999999999999,
      "layouts": 11,
      "layoutDurationMs": 3.3429999999999995,
      "taskDurationMs": 318.849,
      "heapDeltaBytes": -1472452,
      "heapUsedBytes": 88917800,
      "domNodes": 47,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 13.674999999999999,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6673076923077,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 742.3919999999953,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 2.9259999999999997,
      "layouts": 8,
      "layoutDurationMs": 2.3010000000000006,
      "taskDurationMs": 525.3779999999999,
      "heapDeltaBytes": 7611428,
      "heapUsedBytes": 114450412,
      "domNodes": 0,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 173.986,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.055813953488364,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 726.8500000000131,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.017000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.531,
      "taskDurationMs": 515.1669999999999,
      "heapDeltaBytes": 3755816,
      "heapUsedBytes": 93960660,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 169.17,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.053488372093028,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1242.5180000000182,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 944.7090000000001,
      "heapDeltaBytes": -14287432,
      "heapUsedBytes": 103053200,
      "domNodes": -230,
      "jsHeapTotalBytes": 15122432,
      "scriptDurationMs": 70.351,
      "eventListeners": -168,
      "totalBlockingTimeMs": 534,
      "frameDurationMs": 32.45263157894736,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1226.7249999999876,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 933.4809999999999,
      "heapDeltaBytes": -15206784,
      "heapUsedBytes": 102280572,
      "domNodes": -230,
      "jsHeapTotalBytes": 15908864,
      "scriptDurationMs": 73.38499999999999,
      "eventListeners": -168,
      "totalBlockingTimeMs": 527,
      "frameDurationMs": 32.88108108108109,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 842.4709999999891,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.1960000000001,
      "heapDeltaBytes": -3000720,
      "heapUsedBytes": 97356252,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 163.26800000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 223,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 842.7889999999252,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.90900000000016,
      "heapDeltaBytes": -3260444,
      "heapUsedBytes": 97158864,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 155.633,
      "eventListeners": 0,
      "totalBlockingTimeMs": 210,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11160.933999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10252.007000000001,
      "heapDeltaBytes": 13783896,
      "heapUsedBytes": 135452128,
      "domNodes": -276,
      "jsHeapTotalBytes": 21209088,
      "scriptDurationMs": 8390.865,
      "eventListeners": -130,
      "totalBlockingTimeMs": 1564,
      "frameDurationMs": 32.08706896551724,
      "p95FrameDurationMs": 66.69999999999982
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10527.828999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9682.092,
      "heapDeltaBytes": 51415776,
      "heapUsedBytes": 160617028,
      "domNodes": -276,
      "jsHeapTotalBytes": 41590784,
      "scriptDurationMs": 8102.067,
      "eventListeners": -130,
      "totalBlockingTimeMs": 1200,
      "frameDurationMs": 32.159938837920485,
      "p95FrameDurationMs": 66.59999999999945
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9613.992999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8746.851999999999,
      "heapDeltaBytes": 19884432,
      "heapUsedBytes": 144203756,
      "domNodes": -276,
      "jsHeapTotalBytes": 28811264,
      "scriptDurationMs": 6975.4839999999995,
      "eventListeners": -126,
      "totalBlockingTimeMs": 620,
      "frameDurationMs": 30.920578778135045,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11139.030999999988,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10315.703,
      "heapDeltaBytes": 55499080,
      "heapUsedBytes": 158944872,
      "domNodes": -276,
      "jsHeapTotalBytes": 39755776,
      "scriptDurationMs": 8639.643999999998,
      "eventListeners": -130,
      "totalBlockingTimeMs": 1571,
      "frameDurationMs": 32.64780058651027,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "large-combo-open",
      "durationMs": 226.15799999999808,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 14.943999999999999,
      "layouts": 10,
      "layoutDurationMs": 3.244,
      "taskDurationMs": 173.98399999999998,
      "heapDeltaBytes": 13220360,
      "heapUsedBytes": 120259032,
      "domNodes": 917,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 9.189000000000002,
      "eventListeners": 196,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 25.922222222222242,
      "p95FrameDurationMs": 100
    },
    {
      "name": "large-combo-open",
      "durationMs": 212.96000000006643,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 14.683,
      "layouts": 11,
      "layoutDurationMs": 3.636,
      "taskDurationMs": 160.833,
      "heapDeltaBytes": 13197336,
      "heapUsedBytes": 120701544,
      "domNodes": 917,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 9.095,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.66999999999998,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.131000000017,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.156999999999999,
      "layouts": 8,
      "layoutDurationMs": 2.8939999999999997,
      "taskDurationMs": 544.4699999999999,
      "heapDeltaBytes": 1142664,
      "heapUsedBytes": 111043716,
      "domNodes": -276,
      "jsHeapTotalBytes": -1662976,
      "scriptDurationMs": 34.88499999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665040650406507,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.762000000049,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.561000000000001,
      "layouts": 7,
      "layoutDurationMs": 2.3510000000000004,
      "taskDurationMs": 662.042,
      "heapDeltaBytes": -3006184,
      "heapUsedBytes": 101669028,
      "domNodes": -296,
      "jsHeapTotalBytes": -2121728,
      "scriptDurationMs": 32.085,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2243.8080000000014,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 9.749,
      "layouts": 8,
      "layoutDurationMs": 2.2450000000000006,
      "taskDurationMs": 1562.8329999999999,
      "heapDeltaBytes": -1985696,
      "heapUsedBytes": 108512508,
      "domNodes": -296,
      "jsHeapTotalBytes": -651264,
      "scriptDurationMs": 819.289,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666417910447763,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2277.851999999939,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.097999999999999,
      "layouts": 6,
      "layoutDurationMs": 2.004,
      "taskDurationMs": 1582.5149999999999,
      "heapDeltaBytes": 1594324,
      "heapUsedBytes": 113103840,
      "domNodes": -276,
      "jsHeapTotalBytes": -126976,
      "scriptDurationMs": 823.8950000000001,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.03880597014925,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4028.605999999968,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 10.266,
      "layouts": 64,
      "layoutDurationMs": 11.295000000000002,
      "taskDurationMs": 1905.5850000000003,
      "heapDeltaBytes": -25307512,
      "heapUsedBytes": 87776836,
      "domNodes": -272,
      "jsHeapTotalBytes": 565248,
      "scriptDurationMs": 827.794,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3607.253999999898,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 10.351,
      "layouts": 64,
      "layoutDurationMs": 11.009,
      "taskDurationMs": 1685.99,
      "heapDeltaBytes": -21455368,
      "heapUsedBytes": 91358196,
      "domNodes": -252,
      "jsHeapTotalBytes": 40960,
      "scriptDurationMs": 806.259,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.743720930232556,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2821.7599999999834,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.348,
      "layouts": 5,
      "layoutDurationMs": 1.327,
      "taskDurationMs": 1780.688,
      "heapDeltaBytes": -11812040,
      "heapUsedBytes": 102478752,
      "domNodes": 0,
      "jsHeapTotalBytes": 6819840,
      "scriptDurationMs": 962.204,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.966867469879517,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3030.2639999999883,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 5.9479999999999995,
      "layouts": 5,
      "layoutDurationMs": 1.3309999999999997,
      "taskDurationMs": 1876.916,
      "heapDeltaBytes": -11029848,
      "heapUsedBytes": 103707132,
      "domNodes": 0,
      "jsHeapTotalBytes": 6295552,
      "scriptDurationMs": 992.2740000000001,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.946629213483146,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2073.6069999999813,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.836,
      "layouts": 7,
      "layoutDurationMs": 2.4200000000000004,
      "taskDurationMs": 683.3260000000001,
      "heapDeltaBytes": -27206816,
      "heapUsedBytes": 97040436,
      "domNodes": -296,
      "jsHeapTotalBytes": -2347008,
      "scriptDurationMs": 35.476,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66612903225806,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2058.441000000016,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.6350000000000002,
      "layouts": 7,
      "layoutDurationMs": 2.4270000000000005,
      "taskDurationMs": 696.0300000000002,
      "heapDeltaBytes": -28143744,
      "heapUsedBytes": 95903188,
      "domNodes": -296,
      "jsHeapTotalBytes": -774144,
      "scriptDurationMs": 34.660000000000004,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 653.2060000000115,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.177000000000001,
      "layouts": 8,
      "layoutDurationMs": 2.622,
      "taskDurationMs": 482.768,
      "heapDeltaBytes": 25247592,
      "heapUsedBytes": 115959016,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 148.695,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664102564102578,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 614.8030000000517,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.539,
      "layouts": 9,
      "layoutDurationMs": 2.89,
      "taskDurationMs": 450.739,
      "heapDeltaBytes": 24200640,
      "heapUsedBytes": 116473320,
      "domNodes": 0,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 148.597,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667567567567563,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.6250000000146,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.149000000000001,
      "layouts": 9,
      "layoutDurationMs": 3.2409999999999997,
      "taskDurationMs": 603.3739999999999,
      "heapDeltaBytes": 8044904,
      "heapUsedBytes": 98471820,
      "domNodes": -198,
      "jsHeapTotalBytes": 1744896,
      "scriptDurationMs": 9.813000000000002,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2026.1849999999413,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.561,
      "layouts": 10,
      "layoutDurationMs": 3.321,
      "taskDurationMs": 450.61899999999997,
      "heapDeltaBytes": 4212128,
      "heapUsedBytes": 95168588,
      "domNodes": -218,
      "jsHeapTotalBytes": 2269184,
      "scriptDurationMs": 9.273,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667213114754095,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 2004.8649999999952,
      "styleRecalcs": 87,
      "styleRecalcDurationMs": 15.448999999999998,
      "layouts": 9,
      "layoutDurationMs": 2.4819999999999998,
      "taskDurationMs": 1122.786,
      "heapDeltaBytes": 1797612,
      "heapUsedBytes": 92545188,
      "domNodes": -190,
      "jsHeapTotalBytes": 2531328,
      "scriptDurationMs": 115.065,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.6500000000715,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 15.183000000000002,
      "layouts": 9,
      "layoutDurationMs": 2.794,
      "taskDurationMs": 725.5690000000001,
      "heapDeltaBytes": -6323644,
      "heapUsedBytes": 96387376,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 116.11099999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665686274509806,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1487.275000000011,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 26.122,
      "layouts": 5,
      "layoutDurationMs": 16.316,
      "taskDurationMs": 1128.9969999999998,
      "heapDeltaBytes": 35634516,
      "heapUsedBytes": 134750692,
      "domNodes": 16030,
      "jsHeapTotalBytes": 16654336,
      "scriptDurationMs": 31.374,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 165,
      "frameDurationMs": 19.736842105263158,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11097.125000000005,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 30.18,
      "layouts": 6,
      "layoutDurationMs": 1.7270000000000003,
      "taskDurationMs": 6391.508,
      "heapDeltaBytes": -32159060,
      "heapUsedBytes": 88830192,
      "domNodes": -276,
      "jsHeapTotalBytes": -774144,
      "scriptDurationMs": 2872.275,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.69112781954887,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8429.872000000047,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 31.112000000000005,
      "layouts": 9,
      "layoutDurationMs": 2.4930000000000003,
      "taskDurationMs": 5414.719,
      "heapDeltaBytes": -20631760,
      "heapUsedBytes": 89497300,
      "domNodes": -276,
      "jsHeapTotalBytes": -352256,
      "scriptDurationMs": 2790.001,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.732142857142858,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16376.765000000034,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15212.56,
      "heapDeltaBytes": -10380916,
      "heapUsedBytes": 301992752,
      "domNodes": -3344,
      "jsHeapTotalBytes": 18075648,
      "scriptDurationMs": 242.49900000000002,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.136286201022152,
      "p95FrameDurationMs": 50.099999999998545
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16874.66400000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15866.593,
      "heapDeltaBytes": -4172032,
      "heapUsedBytes": 304007532,
      "domNodes": -3344,
      "jsHeapTotalBytes": -3158016,
      "scriptDurationMs": 267.099,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.88013698630137,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 28154.626000000007,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 19.94099999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27771.039999999997,
      "heapDeltaBytes": -22574872,
      "heapUsedBytes": 282570048,
      "domNodes": -3344,
      "jsHeapTotalBytes": 10211328,
      "scriptDurationMs": 864.531,
      "eventListeners": -651,
      "totalBlockingTimeMs": 24,
      "frameDurationMs": 52.255287569573284,
      "p95FrameDurationMs": 116.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 28582.276999999976,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 20.961000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 28189.053,
      "heapDeltaBytes": -2152080,
      "heapUsedBytes": 302839820,
      "domNodes": -3344,
      "jsHeapTotalBytes": 7782400,
      "scriptDurationMs": 892.504,
      "eventListeners": -651,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 52.157299270073,
      "p95FrameDurationMs": 100.10000000000218
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8304.323000000011,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.57499999999999,
      "layouts": 20,
      "layoutDurationMs": 28.475,
      "taskDurationMs": 8179.586,
      "heapDeltaBytes": -26093304,
      "heapUsedBytes": 284575808,
      "domNodes": -3344,
      "jsHeapTotalBytes": 11259904,
      "scriptDurationMs": 125.248,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 46.45977653631286,
      "p95FrameDurationMs": 99.90000000000146
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8276.736000000028,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 88.30599999999997,
      "layouts": 20,
      "layoutDurationMs": 23.32799999999999,
      "taskDurationMs": 8156.257999999999,
      "heapDeltaBytes": -34312040,
      "heapUsedBytes": 294721008,
      "domNodes": -3344,
      "jsHeapTotalBytes": 14143488,
      "scriptDurationMs": 121.17999999999999,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 47.87803468208092,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11364.193,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11077.333,
      "heapDeltaBytes": 4334544,
      "heapUsedBytes": 296093656,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 153.75799999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.16289752650176,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11432.592999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11099.96,
      "heapDeltaBytes": 5024160,
      "heapUsedBytes": 271162116,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 161.68900000000008,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 38.62466216216217,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "workflow-execution",
      "durationMs": 481.50299999997515,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 12.209999999999999,
      "layouts": 12,
      "layoutDurationMs": 4.518,
      "taskDurationMs": 137.35500000000002,
      "heapDeltaBytes": 7434540,
      "heapUsedBytes": 97465128,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 17.439999999999998,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665517241379316,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 131.5149999999221,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.446,
      "layouts": 8,
      "layoutDurationMs": 3.864,
      "taskDurationMs": 92.83399999999999,
      "heapDeltaBytes": 4643796,
      "heapUsedBytes": 107027776,
      "domNodes": 117,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.198,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.675000000000068,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 461.736999999971,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.703,
      "layouts": 76,
      "layoutDurationMs": 14.77,
      "taskDurationMs": 406.437,
      "heapDeltaBytes": -14954828,
      "heapUsedBytes": 81083704,
      "domNodes": 4,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 193.459,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667857142857137,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 426.9060000000309,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.798,
      "layouts": 76,
      "layoutDurationMs": 14.039,
      "taskDurationMs": 381.915,
      "heapDeltaBytes": 11645808,
      "heapUsedBytes": 81031544,
      "domNodes": 4,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 183.463,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66538461538462,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 559.9119999999402,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.027,
      "layouts": 76,
      "layoutDurationMs": 14.496,
      "taskDurationMs": 527.722,
      "heapDeltaBytes": 464240,
      "heapUsedBytes": 117013944,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 214.014,
      "eventListeners": 296,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667647058823523,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 588.7820000000374,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.053,
      "layouts": 76,
      "layoutDurationMs": 15.723,
      "taskDurationMs": 535.376,
      "heapDeltaBytes": 1200828,
      "heapUsedBytes": 120052964,
      "domNodes": 4,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 215.024,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Line coverage: 64.0%

Coverage totals
Metric Covered Total Pct
Lines 57068 89174 64.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.5% 1168
src/LGraphNode.ts 70.6% 388
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/core/billing/operationLifecycle.ts 1.3% 303
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 1.1% 280
src/LGraph.ts 78.9% 274
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.4% 255
src/platform/workspace/stores/teamWorkspaceStore.ts 46.8% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 2954 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2276 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 649 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/23/2026, 03:43:00 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 9d65fa1756cbd9e302372b2198fc2af255c3a37a

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (118)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentStatusIcon.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 68 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a628dfd04c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/router.ts Resolved
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 23, 2026
@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/router.ts 50.00% 1 Missing and 1 partial ⚠️
@@              Coverage Diff              @@
##             cloud/1.58   #21778   +/-   ##
=============================================
  Coverage              ?   87.58%           
=============================================
  Files                 ?     2708           
  Lines                 ?   150545           
  Branches              ?    39278           
=============================================
  Hits                  ?   131850           
  Misses                ?    18306           
  Partials              ?      389           
Flag Coverage Δ
unit 85.76% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/router.ts 77.95% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 44f3d5e into cloud/1.58 Oct 23, 2026
147 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-21768-to-cloud-1.58 branch October 23, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants