Repository navigation
[backport core/1.57] fix: open the link context menu only from its centre marker - #21775
Conversation
Right-clicking anywhere on a visible link opened the link menu. On busy graphs the curves cover groups and empty canvas, so the link took right-clicks meant for those. Now only the link's centre marker opens the link menu, the same spot a left-click uses. The rest of the curve falls through to the group or canvas menu. - Hidden-link badges and stack pills keep their menus. - With link markers set to None there is no centre marker, so no link menu opens from the canvas. Left-click already works this way. - Left-click and Shift/Alt curve interactions are unchanged. - Updated unit tests in `getCanvasContextMenuTarget.test.ts` and `LGraphCanvas.linkVisibility.test.ts`. A new case checks that a right-click on a curve away from the marker opens the canvas menu. - The link visibility E2E helpers already right-click the centre marker. - Ran `pnpm exec vitest run` on the litegraph canvas and graph composable suites (907 passed) and `pnpm typecheck`. (cherry picked from commit 81483e1)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T03:00:00.010Z",
"gitSha": "1c81c94a2f357ff1c5e95f4a07b88b4b5c30725d",
"branch": "backport-21759-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.171999999955,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.104,
"layouts": 11,
"layoutDurationMs": 3.0709999999999997,
"taskDurationMs": 484.66700000000003,
"heapDeltaBytes": -858260,
"heapUsedBytes": 73669620,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.895,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.5380000000441,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.555,
"layouts": 10,
"layoutDurationMs": 2.8499999999999996,
"taskDurationMs": 335.504,
"heapDeltaBytes": 21625576,
"heapUsedBytes": 88412132,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.555999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1772.1050000000105,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.637,
"layouts": 9,
"layoutDurationMs": 2.4600000000000004,
"taskDurationMs": 845.387,
"heapDeltaBytes": 15620188,
"heapUsedBytes": 81021580,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 156.82,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1972.8759999999284,
"styleRecalcs": 83,
"styleRecalcDurationMs": 15.95,
"layouts": 10,
"layoutDurationMs": 2.73,
"taskDurationMs": 908.28,
"heapDeltaBytes": 15622956,
"heapUsedBytes": 81550724,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 160.918,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1715.9019999999714,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.633,
"layouts": 10,
"layoutDurationMs": 2.3530000000000006,
"taskDurationMs": 275.28000000000003,
"heapDeltaBytes": 18694308,
"heapUsedBytes": 84337636,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.757000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1789.639999999963,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.254,
"layouts": 11,
"layoutDurationMs": 3.1420000000000003,
"taskDurationMs": 418.545,
"heapDeltaBytes": -4552244,
"heapUsedBytes": 70153868,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.461000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 669.0019999999777,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.542,
"layouts": 9,
"layoutDurationMs": 2.6359999999999997,
"taskDurationMs": 488.15999999999997,
"heapDeltaBytes": 25688728,
"heapUsedBytes": 91033404,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 172.15800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 671.8020000000706,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.025000000000001,
"layouts": 9,
"layoutDurationMs": 2.708,
"taskDurationMs": 493.65400000000005,
"heapDeltaBytes": 25320228,
"heapUsedBytes": 91207288,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 172.913,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1160.505999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 863.203,
"heapDeltaBytes": 782988,
"heapUsedBytes": 80771848,
"domNodes": -192,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 69.15199999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 499,
"frameDurationMs": 32.405555555555566,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.4729999999454,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 881.532,
"heapDeltaBytes": 664784,
"heapUsedBytes": 81526460,
"domNodes": -192,
"jsHeapTotalBytes": 13377536,
"scriptDurationMs": 69.659,
"eventListeners": -106,
"totalBlockingTimeMs": 511,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 829.2319999999904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.34499999999974,
"heapDeltaBytes": -4297564,
"heapUsedBytes": 76228816,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 152.39600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 209,
"frameDurationMs": 24.50882352941177,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.7950000000665,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.1100000000001,
"heapDeltaBytes": -5930164,
"heapUsedBytes": 75391304,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 156.698,
"eventListeners": 0,
"totalBlockingTimeMs": 214,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10728.150999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9734.717999999999,
"heapDeltaBytes": -16077452,
"heapUsedBytes": 83079720,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 7911.852,
"eventListeners": -68,
"totalBlockingTimeMs": 1130,
"frameDurationMs": 32.37522658610272,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10630.117999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9841.153999999999,
"heapDeltaBytes": -10648540,
"heapUsedBytes": 89214728,
"domNodes": -258,
"jsHeapTotalBytes": 12185600,
"scriptDurationMs": 8059.726999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1303,
"frameDurationMs": 31.551632047477742,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9537.721999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8745.151,
"heapDeltaBytes": -887976,
"heapUsedBytes": 86996460,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 7052.073,
"eventListeners": -67,
"totalBlockingTimeMs": 669,
"frameDurationMs": 31.15326797385621,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8554.030000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7828.79,
"heapDeltaBytes": -26621600,
"heapUsedBytes": 73051380,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 6579.386,
"eventListeners": -68,
"totalBlockingTimeMs": 641,
"frameDurationMs": 32.38522727272728,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 214.53800000000456,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.304,
"layouts": 11,
"layoutDurationMs": 3.851,
"taskDurationMs": 173.319,
"heapDeltaBytes": -8331948,
"heapUsedBytes": 79112032,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.725,
"eventListeners": 195,
"totalBlockingTimeMs": 7,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 83.40000000000055
},
{
"name": "large-combo-open",
"durationMs": 230.8730000000878,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.457999999999998,
"layouts": 11,
"layoutDurationMs": 3.067,
"taskDurationMs": 169.33399999999997,
"heapDeltaBytes": -8097020,
"heapUsedBytes": 79650200,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.537999999999998,
"eventListeners": 195,
"totalBlockingTimeMs": 1,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2040.8729999999764,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4929999999999994,
"layouts": 9,
"layoutDurationMs": 2.535,
"taskDurationMs": 456.039,
"heapDeltaBytes": -1715024,
"heapUsedBytes": 76906344,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 32.968999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.7829999999803,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.227,
"layouts": 8,
"layoutDurationMs": 2.157,
"taskDurationMs": 445.82500000000005,
"heapDeltaBytes": -2110384,
"heapUsedBytes": 76790760,
"domNodes": -258,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 32.615,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2392.0020000000477,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.065999999999999,
"layouts": 7,
"layoutDurationMs": 1.833,
"taskDurationMs": 1665.5380000000002,
"heapDeltaBytes": -29583968,
"heapUsedBytes": 68391892,
"domNodes": -258,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 809.032,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2490.2609999999186,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.7700000000000005,
"layouts": 7,
"layoutDurationMs": 1.6829999999999998,
"taskDurationMs": 1703.1650000000002,
"heapDeltaBytes": -8815724,
"heapUsedBytes": 68534192,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 840.149,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777702702702705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3855.468999999971,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.212999999999999,
"layouts": 64,
"layoutDurationMs": 10.465,
"taskDurationMs": 1760.873,
"heapDeltaBytes": 957700,
"heapUsedBytes": 82423300,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 782.142,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.738260869565217,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3768.762000000038,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.334999999999999,
"layouts": 63,
"layoutDurationMs": 10.222999999999999,
"taskDurationMs": 1790.5669999999998,
"heapDeltaBytes": -3396820,
"heapUsedBytes": 78356052,
"domNodes": -234,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 776.194,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592920353982,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2951.816000000008,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.590999999999999,
"layouts": 4,
"layoutDurationMs": 1.1380000000000001,
"taskDurationMs": 1908.3739999999998,
"heapDeltaBytes": 12142152,
"heapUsedBytes": 94955864,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 952.412,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.85657142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3009.2489999999543,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.783,
"layouts": 5,
"layoutDurationMs": 1.2209999999999999,
"taskDurationMs": 1945.436,
"heapDeltaBytes": 3900376,
"heapUsedBytes": 82106260,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 948.082,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.946629213483146,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2059.2120000000023,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.974,
"layouts": 6,
"layoutDurationMs": 2.005,
"taskDurationMs": 611.58,
"heapDeltaBytes": -21316100,
"heapUsedBytes": 77355016,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 32.25899999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.9139999999961,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.4170000000000007,
"layouts": 6,
"layoutDurationMs": 1.598,
"taskDurationMs": 610.6289999999999,
"heapDeltaBytes": -19362048,
"heapUsedBytes": 79515736,
"domNodes": -258,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 30.415000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.7399999999825,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.366,
"layouts": 8,
"layoutDurationMs": 2.1069999999999998,
"taskDurationMs": 425.232,
"heapDeltaBytes": 21623224,
"heapUsedBytes": 88556284,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 149.33400000000003,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.2990000000864,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.706999999999999,
"layouts": 9,
"layoutDurationMs": 2.589,
"taskDurationMs": 431.5210000000001,
"heapDeltaBytes": -1124468,
"heapUsedBytes": 76384320,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 147.804,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.6890000000044,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.011999999999999,
"layouts": 10,
"layoutDurationMs": 3.007,
"taskDurationMs": 509.8640000000001,
"heapDeltaBytes": -638424,
"heapUsedBytes": 76775884,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.438999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.4999999999227,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.358999999999999,
"layouts": 9,
"layoutDurationMs": 2.3390000000000004,
"taskDurationMs": 497.9290000000001,
"heapDeltaBytes": 22471212,
"heapUsedBytes": 89461116,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.014000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1967.8799999999796,
"styleRecalcs": 87,
"styleRecalcDurationMs": 16.578,
"layouts": 10,
"layoutDurationMs": 2.3609999999999993,
"taskDurationMs": 1028.022,
"heapDeltaBytes": -11408916,
"heapUsedBytes": 66053184,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 109.618,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.622999999965,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.26,
"layouts": 10,
"layoutDurationMs": 2.69,
"taskDurationMs": 1000.3930000000001,
"heapDeltaBytes": -11425488,
"heapUsedBytes": 66089656,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 110.99099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.9700000000212,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.604999999999997,
"layouts": 5,
"layoutDurationMs": 16.063,
"taskDurationMs": 1010.0550000000002,
"heapDeltaBytes": 4820568,
"heapUsedBytes": 101849460,
"domNodes": 15953,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 30.282000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 160,
"frameDurationMs": 19.861643835616434,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9167.752000000008,
"styleRecalcs": 249,
"styleRecalcDurationMs": 17.881,
"layouts": 7,
"layoutDurationMs": 1.6969999999999996,
"taskDurationMs": 5789.62,
"heapDeltaBytes": -9023256,
"heapUsedBytes": 87716972,
"domNodes": -258,
"jsHeapTotalBytes": 5337088,
"scriptDurationMs": 2704.275,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.726775956284154,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8935.562000000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.622,
"layouts": 7,
"layoutDurationMs": 2.0360000000000005,
"taskDurationMs": 5768.4169999999995,
"heapDeltaBytes": -942776,
"heapUsedBytes": 78163808,
"domNodes": -258,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 2660.6519999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697196261682244,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23049.931000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22092.734,
"heapDeltaBytes": -30809140,
"heapUsedBytes": 259676860,
"domNodes": -3330,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 318.022,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.43904109589041,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 23065.604000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22277.367,
"heapDeltaBytes": -6685092,
"heapUsedBytes": 284621996,
"domNodes": -3330,
"jsHeapTotalBytes": 12046336,
"scriptDurationMs": 315.81600000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.69982788296042,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19504.475000000013,
"styleRecalcs": 167,
"styleRecalcDurationMs": 12.829000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18986.22,
"heapDeltaBytes": 9892124,
"heapUsedBytes": 291317352,
"domNodes": -3330,
"jsHeapTotalBytes": 16437248,
"scriptDurationMs": 840.434,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 34.849821428571424,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 27917.57699999994,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.867999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27514.390000000003,
"heapDeltaBytes": -17446688,
"heapUsedBytes": 273348068,
"domNodes": -3330,
"jsHeapTotalBytes": 4968448,
"scriptDurationMs": 939.379,
"eventListeners": -651,
"totalBlockingTimeMs": 78,
"frameDurationMs": 51.315441176470586,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8224.085000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.06400000000002,
"layouts": 20,
"layoutDurationMs": 22.56800000000002,
"taskDurationMs": 8067.383,
"heapDeltaBytes": -7519724,
"heapUsedBytes": 269182852,
"domNodes": -3330,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 145.31199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.420338983050854,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8190.08000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 99.22299999999998,
"layouts": 20,
"layoutDurationMs": 24.451,
"taskDurationMs": 8052.289999999999,
"heapDeltaBytes": -16806680,
"heapUsedBytes": 259457324,
"domNodes": -3330,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 153.964,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.96153846153846,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11219.044999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10795.722000000002,
"heapDeltaBytes": -27285552,
"heapUsedBytes": 243553952,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.7710000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.49366197183099,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11342.658000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11028.796,
"heapDeltaBytes": 19462056,
"heapUsedBytes": 268530320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.87499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.246808510638296,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 133.94499999992604,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.812000000000001,
"layouts": 8,
"layoutDurationMs": 3.506,
"taskDurationMs": 103.64599999999999,
"heapDeltaBytes": 4617080,
"heapUsedBytes": 76879104,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.44,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.057142857142804,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 135.45199999998658,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.863999999999999,
"layouts": 8,
"layoutDurationMs": 3.3599999999999994,
"taskDurationMs": 103.473,
"heapDeltaBytes": -15335992,
"heapUsedBytes": 68174188,
"domNodes": 121,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.752999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 471.883000000048,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.26,
"layouts": 76,
"layoutDurationMs": 14.600999999999999,
"taskDurationMs": 427.228,
"heapDeltaBytes": 11510292,
"heapUsedBytes": 88724800,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 209.97199999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662068965517236,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 474.3859999999813,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.013,
"layouts": 76,
"layoutDurationMs": 13.862,
"taskDurationMs": 429.786,
"heapDeltaBytes": 11703404,
"heapUsedBytes": 102512376,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 212.85999999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 507.9889999999523,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9829999999999999,
"layouts": 76,
"layoutDurationMs": 13.261000000000001,
"taskDurationMs": 464.58700000000005,
"heapDeltaBytes": -5081324,
"heapUsedBytes": 112191632,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 189.538,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 564.422000000036,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.778,
"layouts": 76,
"layoutDurationMs": 15.010000000000002,
"taskDurationMs": 514.5300000000001,
"heapDeltaBytes": 360496,
"heapUsedBytes": 126817744,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 203.93800000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.17272727272727,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2282 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 893e850fff1af7ec4b67a1c4e3ce9b7d669f605b
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21775 +/- ##
=============================================
- Coverage 85.81% 84.10% -1.71%
=============================================
Files 2704 2840 +136
Lines 152004 157885 +5881
Branches 38469 38469
=============================================
+ Hits 130446 132796 +2350
- Misses 21170 24700 +3530
- Partials 388 389 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 325 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #21759 to
core/1.57.The automatic backport failed with conflicts in
getCanvasContextMenuTarget.tsand its test. Conflicts came from #20799 (litegraph import cycles), #21423 (import paths) and #20836 (hidden-link stacks), which are not on this branch. The fix keeps the branch's direct relative imports and only adds theisInRectangleandLinkMarkerShapeimports. The stack pill test is left out because stacks do not exist here. The behavior change is the same: only the link's centre marker opens the link menu on right-click.Tests: litegraph canvas and graph composable unit suites pass on this branch, and
pnpm typecheckpasses.