Repository navigation
[backport core/1.58] fix: open the link context menu only from its centre marker - #21773
Conversation
Right-clicking anywhere on a visible link opened the link menu. On busy graphs the curves cover groups and empty canvas, so the link took right-clicks meant for those. Now only the link's centre marker opens the link menu, the same spot a left-click uses. The rest of the curve falls through to the group or canvas menu. - Hidden-link badges and stack pills keep their menus. - With link markers set to None there is no centre marker, so no link menu opens from the canvas. Left-click already works this way. - Left-click and Shift/Alt curve interactions are unchanged. - Updated unit tests in `getCanvasContextMenuTarget.test.ts` and `LGraphCanvas.linkVisibility.test.ts`. A new case checks that a right-click on a curve away from the marker opens the canvas menu. - The link visibility E2E helpers already right-click the centre marker. - Ran `pnpm exec vitest run` on the litegraph canvas and graph composable suites (907 passed) and `pnpm typecheck`. (cherry picked from commit 81483e1)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T02:59:21.561Z",
"gitSha": "2bbfc350275a00c18eebd28c38fecf750f22b0fa",
"branch": "backport-21759-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.3729999999923,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9709999999999996,
"layouts": 9,
"layoutDurationMs": 2.411,
"taskDurationMs": 560.159,
"heapDeltaBytes": 4009964,
"heapUsedBytes": 96136948,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.939,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2039.910999999961,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.5620000000000003,
"layouts": 10,
"layoutDurationMs": 3.312,
"taskDurationMs": 603.494,
"heapDeltaBytes": 6343952,
"heapUsedBytes": 96093216,
"domNodes": -180,
"jsHeapTotalBytes": 696320,
"scriptDurationMs": 10.677000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.1700000000164,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.331000000000001,
"layouts": 8,
"layoutDurationMs": 2.2079999999999997,
"taskDurationMs": 830.74,
"heapDeltaBytes": 2698676,
"heapUsedBytes": 92785384,
"domNodes": -200,
"jsHeapTotalBytes": 2531328,
"scriptDurationMs": 174.82899999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.1929999999584,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.898000000000001,
"layouts": 8,
"layoutDurationMs": 2.557,
"taskDurationMs": 825.4789999999999,
"heapDeltaBytes": 6924352,
"heapUsedBytes": 96724788,
"domNodes": -180,
"jsHeapTotalBytes": 3055616,
"scriptDurationMs": 168.4,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66698113207547,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.9379999999992,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.901,
"layouts": 11,
"layoutDurationMs": 3.663,
"taskDurationMs": 340.16799999999995,
"heapDeltaBytes": -35196,
"heapUsedBytes": 99667884,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 13.951000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1790.6849999999395,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.268,
"layouts": 11,
"layoutDurationMs": 2.9759999999999995,
"taskDurationMs": 461.339,
"heapDeltaBytes": 26638244,
"heapUsedBytes": 127117828,
"domNodes": 47,
"jsHeapTotalBytes": 19398656,
"scriptDurationMs": 11.777,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018691,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 596.8009999999708,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.144,
"layouts": 9,
"layoutDurationMs": 2.6319999999999997,
"taskDurationMs": 446.71799999999996,
"heapDeltaBytes": 3826860,
"heapUsedBytes": 93667672,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 173.798,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 629.3229999999994,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.2450000000000006,
"layouts": 9,
"layoutDurationMs": 2.932,
"taskDurationMs": 463.483,
"heapDeltaBytes": 3665728,
"heapUsedBytes": 93937524,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 179.895,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631583,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1242.5949999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 941.814,
"heapDeltaBytes": -14828128,
"heapUsedBytes": 102585464,
"domNodes": -230,
"jsHeapTotalBytes": 15384576,
"scriptDurationMs": 73.54,
"eventListeners": -168,
"totalBlockingTimeMs": 534,
"frameDurationMs": 32.45526315789474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1237.2480000000223,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 943.3809999999999,
"heapDeltaBytes": -2912968,
"heapUsedBytes": 102373136,
"domNodes": -210,
"jsHeapTotalBytes": 8896512,
"scriptDurationMs": 74.78800000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 536,
"frameDurationMs": 32.45526315789474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.5969999999884,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.43000000000035,
"heapDeltaBytes": -2706608,
"heapUsedBytes": 94572656,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.955,
"eventListeners": 0,
"totalBlockingTimeMs": 210,
"frameDurationMs": 25,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 871.311999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.8659999999998,
"heapDeltaBytes": -4049036,
"heapUsedBytes": 97668608,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.73499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 25.488235294117604,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10927.329000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10063.932999999999,
"heapDeltaBytes": 33160940,
"heapUsedBytes": 138145500,
"domNodes": -276,
"jsHeapTotalBytes": 33267712,
"scriptDurationMs": 7982.333999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1055,
"frameDurationMs": 31.54971098265896,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11367.58100000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10538.110999999999,
"heapDeltaBytes": -29853844,
"heapUsedBytes": 94518648,
"domNodes": -276,
"jsHeapTotalBytes": 19374080,
"scriptDurationMs": 8577.914,
"eventListeners": -130,
"totalBlockingTimeMs": 1555,
"frameDurationMs": 31.660724233983288,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10546.240000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9770.595,
"heapDeltaBytes": 54370584,
"heapUsedBytes": 157829340,
"domNodes": -296,
"jsHeapTotalBytes": 32940032,
"scriptDurationMs": 7752.673,
"eventListeners": -130,
"totalBlockingTimeMs": 821,
"frameDurationMs": 30.936950146627566,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10238.606999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9434.354000000001,
"heapDeltaBytes": 51277372,
"heapUsedBytes": 160480284,
"domNodes": -276,
"jsHeapTotalBytes": 34512896,
"scriptDurationMs": 7444.61,
"eventListeners": -130,
"totalBlockingTimeMs": 773,
"frameDurationMs": 30.679579579579578,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 251.4539999999954,
"styleRecalcs": 26,
"styleRecalcDurationMs": 14.741999999999999,
"layouts": 12,
"layoutDurationMs": 3.3960000000000004,
"taskDurationMs": 198.86100000000002,
"heapDeltaBytes": 13330184,
"heapUsedBytes": 118245792,
"domNodes": 917,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 8.718,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.833333333333332,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 229.49400000004516,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.387999999999998,
"layouts": 11,
"layoutDurationMs": 3.4119999999999995,
"taskDurationMs": 181.492,
"heapDeltaBytes": 13230544,
"heapUsedBytes": 121415984,
"domNodes": 917,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.613,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.21818181818187,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2037.228999999968,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4250000000000003,
"layouts": 8,
"layoutDurationMs": 2.479,
"taskDurationMs": 673.1250000000001,
"heapDeltaBytes": -2522140,
"heapUsedBytes": 101323952,
"domNodes": -276,
"jsHeapTotalBytes": -2215936,
"scriptDurationMs": 34.53,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.6309999999485,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5850000000000004,
"layouts": 8,
"layoutDurationMs": 2.516,
"taskDurationMs": 695.1980000000001,
"heapDeltaBytes": 895388,
"heapUsedBytes": 111215316,
"domNodes": -296,
"jsHeapTotalBytes": -1400832,
"scriptDurationMs": 35.275,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2982.208999999955,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.918,
"layouts": 7,
"layoutDurationMs": 1.7810000000000004,
"taskDurationMs": 1885.1529999999998,
"heapDeltaBytes": 2053232,
"heapUsedBytes": 113606440,
"domNodes": -296,
"jsHeapTotalBytes": -651264,
"scriptDurationMs": 899.974,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.854237288135597,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2950.138000000038,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.594,
"layouts": 7,
"layoutDurationMs": 2.2110000000000003,
"taskDurationMs": 1809.5049999999999,
"heapDeltaBytes": 2145688,
"heapUsedBytes": 113372172,
"domNodes": -276,
"jsHeapTotalBytes": -126976,
"scriptDurationMs": 832.624,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76079545454546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4040.6600000000026,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.493,
"layouts": 63,
"layoutDurationMs": 10.645999999999999,
"taskDurationMs": 1908.246,
"heapDeltaBytes": -25436396,
"heapUsedBytes": 87836628,
"domNodes": -272,
"jsHeapTotalBytes": 303104,
"scriptDurationMs": 800.0110000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3897.640000000024,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.286,
"layouts": 65,
"layoutDurationMs": 10.893,
"taskDurationMs": 1859.91,
"heapDeltaBytes": 3038276,
"heapUsedBytes": 109798672,
"domNodes": -272,
"jsHeapTotalBytes": -2252800,
"scriptDurationMs": 796.763,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581197,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3143.696000000034,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.768999999999999,
"layouts": 5,
"layoutDurationMs": 1.3579999999999999,
"taskDurationMs": 2046.672,
"heapDeltaBytes": -23574916,
"heapUsedBytes": 90365092,
"domNodes": 0,
"jsHeapTotalBytes": 2138112,
"scriptDurationMs": 1002.0690000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.11344086021505,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2886.111000000028,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.151999999999999,
"layouts": 4,
"layoutDurationMs": 1.0530000000000002,
"taskDurationMs": 1786.6009999999999,
"heapDeltaBytes": -11520152,
"heapUsedBytes": 102978028,
"domNodes": 0,
"jsHeapTotalBytes": 7344128,
"scriptDurationMs": 959.11,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.860818713450293,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2057.0490000000063,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4550000000000005,
"layouts": 7,
"layoutDurationMs": 2.0700000000000003,
"taskDurationMs": 699.225,
"heapDeltaBytes": 4991952,
"heapUsedBytes": 110002816,
"domNodes": -276,
"jsHeapTotalBytes": -1335296,
"scriptDurationMs": 32.480000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.5840000000999,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9929999999999999,
"layouts": 7,
"layoutDurationMs": 1.9819999999999998,
"taskDurationMs": 662.2090000000001,
"heapDeltaBytes": -103860,
"heapUsedBytes": 112934260,
"domNodes": -296,
"jsHeapTotalBytes": -1925120,
"scriptDurationMs": 32.22099999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.8249999999966,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.061999999999999,
"layouts": 10,
"layoutDurationMs": 3.218,
"taskDurationMs": 440.29799999999994,
"heapDeltaBytes": -581976,
"heapUsedBytes": 90513468,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 153.35299999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.351000000056,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.316000000000001,
"layouts": 9,
"layoutDurationMs": 2.44,
"taskDurationMs": 446.223,
"heapDeltaBytes": -1438620,
"heapUsedBytes": 89745612,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 146.14,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2040.3239999999983,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5170000000000003,
"layouts": 10,
"layoutDurationMs": 3.1690000000000005,
"taskDurationMs": 630.727,
"heapDeltaBytes": -12226332,
"heapUsedBytes": 96837436,
"domNodes": -198,
"jsHeapTotalBytes": 6266880,
"scriptDurationMs": 9.614,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2037.6209999999446,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.119,
"layouts": 9,
"layoutDurationMs": 3.16,
"taskDurationMs": 494.454,
"heapDeltaBytes": 3274176,
"heapUsedBytes": 94189504,
"domNodes": -218,
"jsHeapTotalBytes": 1482752,
"scriptDurationMs": 11.301999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.8859999999986,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.093000000000002,
"layouts": 10,
"layoutDurationMs": 3.064,
"taskDurationMs": 962.0879999999999,
"heapDeltaBytes": 4187984,
"heapUsedBytes": 106182172,
"domNodes": -218,
"jsHeapTotalBytes": 12296192,
"scriptDurationMs": 117.51400000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.825961538461534,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.929000000051,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.237,
"layouts": 10,
"layoutDurationMs": 2.875,
"taskDurationMs": 937.803,
"heapDeltaBytes": 2302024,
"heapUsedBytes": 92630880,
"domNodes": -190,
"jsHeapTotalBytes": 2793472,
"scriptDurationMs": 115.671,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1454.8729999999637,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.037000000000006,
"layouts": 5,
"layoutDurationMs": 16.974,
"taskDurationMs": 1103.0800000000002,
"heapDeltaBytes": 39646920,
"heapUsedBytes": 174687132,
"domNodes": 16030,
"jsHeapTotalBytes": 44703744,
"scriptDurationMs": 32.748000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 173,
"frameDurationMs": 20.090410958904116,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8359.152999999991,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.743000000000002,
"layouts": 8,
"layoutDurationMs": 2.2,
"taskDurationMs": 5440.416,
"heapDeltaBytes": 2783848,
"heapUsedBytes": 113008808,
"domNodes": -296,
"jsHeapTotalBytes": -651264,
"scriptDurationMs": 2751.836,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6994,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8445.2,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.394000000000002,
"layouts": 9,
"layoutDurationMs": 2.4539999999999997,
"taskDurationMs": 5508.676,
"heapDeltaBytes": 5027736,
"heapUsedBytes": 115168844,
"domNodes": -296,
"jsHeapTotalBytes": -1208320,
"scriptDurationMs": 2906.543,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73188118811881,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23589.601000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23073.963,
"heapDeltaBytes": 123000,
"heapUsedBytes": 305677996,
"domNodes": -3344,
"jsHeapTotalBytes": -10760192,
"scriptDurationMs": 339.484,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.47873070325901,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23109.86700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22541.846,
"heapDeltaBytes": -39435196,
"heapUsedBytes": 289816580,
"domNodes": -3344,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 324.693,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.62109777015438,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 20246.193000000007,
"styleRecalcs": 161,
"styleRecalcDurationMs": 17.797000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19806.106,
"heapDeltaBytes": -39973108,
"heapUsedBytes": 280066272,
"domNodes": -3344,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 865.183,
"eventListeners": -651,
"totalBlockingTimeMs": 28,
"frameDurationMs": 37.291344383057094,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 19766.831000000024,
"styleRecalcs": 156,
"styleRecalcDurationMs": 16.833000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19336.403000000002,
"heapDeltaBytes": -39705492,
"heapUsedBytes": 289409732,
"domNodes": -3344,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 833.758,
"eventListeners": -651,
"totalBlockingTimeMs": 18,
"frameDurationMs": 36.267889908256876,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8526.730999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.01400000000001,
"layouts": 20,
"layoutDurationMs": 29.564000000000007,
"taskDurationMs": 8385.331999999999,
"heapDeltaBytes": -36464624,
"heapUsedBytes": 283930296,
"domNodes": -3344,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 123.67000000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.66457142857143,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8427.342000000066,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.33199999999998,
"layouts": 20,
"layoutDurationMs": 30.266000000000016,
"taskDurationMs": 8267.127999999999,
"heapDeltaBytes": -43123484,
"heapUsedBytes": 268117916,
"domNodes": -3344,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 130.852,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.59060773480664,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8192.09699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7767.803999999998,
"heapDeltaBytes": 10322468,
"heapUsedBytes": 280790172,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 124.24599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.851864406779658,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8311.688000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7889.982999999999,
"heapDeltaBytes": 18789676,
"heapUsedBytes": 289330604,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 127.18699999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.976655052264807,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 116.3190000000327,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.920999999999999,
"layouts": 7,
"layoutDurationMs": 2.2929999999999997,
"taskDurationMs": 77.67399999999999,
"heapDeltaBytes": 4812196,
"heapUsedBytes": 94833200,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.25,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.339999999999964,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "workflow-execution",
"durationMs": 458.4930000000895,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.418,
"layouts": 10,
"layoutDurationMs": 3.293,
"taskDurationMs": 107.09200000000001,
"heapDeltaBytes": 6910704,
"heapUsedBytes": 97456092,
"domNodes": 95,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.937000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 453.47900000001573,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.615,
"layouts": 76,
"layoutDurationMs": 15.104,
"taskDurationMs": 413.813,
"heapDeltaBytes": -14288524,
"heapUsedBytes": 79212236,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 193.92999999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 425.08999999995467,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.88,
"layouts": 76,
"layoutDurationMs": 14.248999999999999,
"taskDurationMs": 384.29400000000004,
"heapDeltaBytes": 11471984,
"heapUsedBytes": 80320368,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 182.35899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 503.93300000007457,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.845,
"layouts": 76,
"layoutDurationMs": 14.251,
"taskDurationMs": 475.047,
"heapDeltaBytes": 243272,
"heapUsedBytes": 117143060,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 188.85399999999998,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 556.508000000008,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7329999999999999,
"layouts": 76,
"layoutDurationMs": 14.095999999999998,
"taskDurationMs": 507.83599999999996,
"heapDeltaBytes": 794652,
"heapUsedBytes": 121127476,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 205.501,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696982,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2955 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0b9923e7af78b4f1d9c80d1ff40c252c1acb0623
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (114)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #21773 +/- ##
=============================================
- Coverage 84.76% 84.47% -0.30%
=============================================
Files 2901 2928 +27
Lines 159293 160599 +1306
Branches 39211 41307 +2096
=============================================
+ Hits 135030 135664 +634
- Misses 23871 24543 +672
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 75 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #21759 to
core/1.58.The automatic backport failed with conflicts in
getCanvasContextMenuTarget.tsand its test. Conflicts came from #21423 (import paths) and #20836 (hidden-link stacks), which are not on this branch. The fix keeps the branch's relative imports and only adds theisInRectangleandLinkMarkerShapeimports. The stack pill test is left out because stacks do not exist here. The behavior change is the same: only the link's centre marker opens the link menu on right-click.Tests: litegraph canvas and graph composable unit suites pass on this branch, and
pnpm typecheckpasses.