Repository navigation
[backport cloud/1.57] feat(workspace): Running on moves to an engine button in the Run bar (#21148) - #21724
Conversation
…button in the Run bar (#21148) Manual backport: the bot's cherry-pick conflicted because cloud/1.57 predates the theme-token rename (#20988) and the template-class pruning (#21159). Conflicts are resolved to #21148's version, with its color classes renamed to the 1.57 tokens that carry the same values: - bg-/ring-accent -> bg-/ring-secondary-background-hover - bg-/ring-secondary -> bg-/ring-secondary-background - ring-background -> ring-base-background - text-foreground -> text-base-foreground - text-warning -> text-warning-foreground - bg-success -> bg-success-background - bg-primary -> bg-primary-background The Run bar test keeps 1.57's StatusBadge stub name. (cherry picked from commit 6d5b6fd)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-22T20:33:48.458Z",
"gitSha": "ff4555c71b1eb79dafc07279549adc921f4beee3",
"branch": "backport-21148-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.167999999993,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1659999999999995,
"layouts": 10,
"layoutDurationMs": 2.9290000000000003,
"taskDurationMs": 383.326,
"heapDeltaBytes": -837496,
"heapUsedBytes": 73578996,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.365,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2009.653999999955,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.85,
"layouts": 10,
"layoutDurationMs": 1.7329999999999999,
"taskDurationMs": 282.74100000000004,
"heapDeltaBytes": -866300,
"heapUsedBytes": 74106644,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 5.607999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.82400000002,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.94,
"layouts": 10,
"layoutDurationMs": 2.6630000000000003,
"taskDurationMs": 608.826,
"heapDeltaBytes": 15478072,
"heapUsedBytes": 81966992,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 115.153,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.5619999999994,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.841000000000001,
"layouts": 10,
"layoutDurationMs": 2.058,
"taskDurationMs": 480.61499999999995,
"heapDeltaBytes": -8232520,
"heapUsedBytes": 66715012,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 87.991,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.100999999966,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.437,
"layouts": 12,
"layoutDurationMs": 2.9360000000000004,
"taskDurationMs": 248.108,
"heapDeltaBytes": -4452008,
"heapUsedBytes": 70796688,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.881,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.6370000000197,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.91,
"layouts": 12,
"layoutDurationMs": 2.5520000000000005,
"taskDurationMs": 210.62900000000002,
"heapDeltaBytes": 18311640,
"heapUsedBytes": 84635952,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 6.324,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 532.4259999999867,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8480000000000008,
"layouts": 9,
"layoutDurationMs": 2.488,
"taskDurationMs": 344.63500000000005,
"heapDeltaBytes": 25700680,
"heapUsedBytes": 91418016,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 110.576,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 414.5730000000185,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.709,
"layouts": 10,
"layoutDurationMs": 2.3649999999999998,
"taskDurationMs": 295.321,
"heapDeltaBytes": 7227464,
"heapUsedBytes": 81220244,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 100.78099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66800000000001,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 914.3980000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.263,
"heapDeltaBytes": -11189760,
"heapUsedBytes": 81368992,
"domNodes": -192,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 37.373,
"eventListeners": -106,
"totalBlockingTimeMs": 280,
"frameDurationMs": 26.188571428571425,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 891.96400000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.301,
"heapDeltaBytes": -3810588,
"heapUsedBytes": 81343288,
"domNodes": -192,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 39.27100000000001,
"eventListeners": -105,
"totalBlockingTimeMs": 258,
"frameDurationMs": 25.714285714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 717.9879999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.62199999999984,
"heapDeltaBytes": -4413488,
"heapUsedBytes": 76587556,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 93.776,
"eventListeners": 0,
"totalBlockingTimeMs": 96,
"frameDurationMs": 21.079411764705878,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 703.3679999999549,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 265.7160000000003,
"heapDeltaBytes": -3325032,
"heapUsedBytes": 76296768,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 87.927,
"eventListeners": 0,
"totalBlockingTimeMs": 86,
"frameDurationMs": 20.591176470588245,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6635.764999999992,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6180000000000005,
"layouts": 2,
"layoutDurationMs": 0.5530000000000002,
"taskDurationMs": 5460.119,
"heapDeltaBytes": -2099944,
"heapUsedBytes": 97142160,
"domNodes": -258,
"jsHeapTotalBytes": 11923456,
"scriptDurationMs": 4329.575,
"eventListeners": -68,
"totalBlockingTimeMs": 26,
"frameDurationMs": 22.40912162162162,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6130.457000000035,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.1060000000000003,
"layouts": 3,
"layoutDurationMs": 1.219,
"taskDurationMs": 5054.766,
"heapDeltaBytes": -10412700,
"heapUsedBytes": 88885588,
"domNodes": -258,
"jsHeapTotalBytes": 8515584,
"scriptDurationMs": 3942.6670000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 14,
"frameDurationMs": 18.64164133738602,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6638.310999999987,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9189999999999997,
"layouts": 3,
"layoutDurationMs": 0.7690000000000001,
"taskDurationMs": 5412.397,
"heapDeltaBytes": -913452,
"heapUsedBytes": 96405348,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 4127.57,
"eventListeners": -68,
"totalBlockingTimeMs": 22,
"frameDurationMs": 19.800298507462685,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5561.311000000046,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7929999999999995,
"layouts": 3,
"layoutDurationMs": 0.6609999999999997,
"taskDurationMs": 4697.119,
"heapDeltaBytes": -2569960,
"heapUsedBytes": 74771144,
"domNodes": -258,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 3708.7270000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.84102564102564,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "large-combo-open",
"durationMs": 163.33399999999187,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.639999999999999,
"layouts": 11,
"layoutDurationMs": 3.8289999999999997,
"taskDurationMs": 120.433,
"heapDeltaBytes": -8001660,
"heapUsedBytes": 79781800,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6.4399999999999995,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 136.11600000001545,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.355,
"layouts": 12,
"layoutDurationMs": 2.763,
"taskDurationMs": 98.66499999999999,
"heapDeltaBytes": -8159416,
"heapUsedBytes": 79046052,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5.615,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2008.9619999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.562,
"layouts": 9,
"layoutDurationMs": 2.2210000000000005,
"taskDurationMs": 403.763,
"heapDeltaBytes": -25002364,
"heapUsedBytes": 73794492,
"domNodes": -258,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 27.123,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.5959999999877,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.274,
"layouts": 10,
"layoutDurationMs": 1.9020000000000001,
"taskDurationMs": 357.29999999999995,
"heapDeltaBytes": -13304524,
"heapUsedBytes": 83066632,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 18.926999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2234.9909999999795,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.247,
"layouts": 8,
"layoutDurationMs": 2.143,
"taskDurationMs": 1177.167,
"heapDeltaBytes": -11357732,
"heapUsedBytes": 68183004,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 602.256,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666165413533836,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2095.6299999999715,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.744000000000001,
"layouts": 9,
"layoutDurationMs": 1.9080000000000001,
"taskDurationMs": 883.149,
"heapDeltaBytes": -12633672,
"heapUsedBytes": 67266608,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 495.76599999999996,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665079365079368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3504.7460000000115,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.402,
"layouts": 66,
"layoutDurationMs": 12.324,
"taskDurationMs": 1255.6290000000001,
"heapDeltaBytes": -14787716,
"heapUsedBytes": 67646796,
"domNodes": -234,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 526.3530000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666190476190476,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3169.64999999999,
"styleRecalcs": 73,
"styleRecalcDurationMs": 7.788,
"layouts": 67,
"layoutDurationMs": 11.118,
"taskDurationMs": 1074.33,
"heapDeltaBytes": 1280404,
"heapUsedBytes": 82880552,
"domNodes": 24,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 481.96099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666315789473686,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2934.1969999999833,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.911999999999999,
"layouts": 7,
"layoutDurationMs": 1.82,
"taskDurationMs": 1378.756,
"heapDeltaBytes": 15385648,
"heapUsedBytes": 98344756,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 667.906,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2313.3300000000077,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.434,
"layouts": 7,
"layoutDurationMs": 1.406,
"taskDurationMs": 1237.572,
"heapDeltaBytes": 3781480,
"heapUsedBytes": 81700568,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 642.5269999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665942028985505,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2022.3059999999577,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.654,
"layouts": 9,
"layoutDurationMs": 1.794,
"taskDurationMs": 388.764,
"heapDeltaBytes": -2256524,
"heapUsedBytes": 78544660,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 24.81,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2006.5199999999663,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.66,
"layouts": 9,
"layoutDurationMs": 1.5430000000000001,
"taskDurationMs": 359.13399999999996,
"heapDeltaBytes": -1972736,
"heapUsedBytes": 79312208,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 17.52,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.69399999999314,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.527,
"layouts": 10,
"layoutDurationMs": 2.284,
"taskDurationMs": 259.998,
"heapDeltaBytes": 19865804,
"heapUsedBytes": 86722076,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 89.01500000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 415.70100000001275,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.726000000000001,
"layouts": 11,
"layoutDurationMs": 2.4850000000000003,
"taskDurationMs": 255.01299999999998,
"heapDeltaBytes": 21607788,
"heapUsedBytes": 89003172,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 89.26500000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2006.8029999999908,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0029999999999997,
"layouts": 10,
"layoutDurationMs": 2.6820000000000004,
"taskDurationMs": 323.34,
"heapDeltaBytes": 22463884,
"heapUsedBytes": 88879812,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.959,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2011.712999999986,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.0709999999999997,
"layouts": 11,
"layoutDurationMs": 1.9149999999999998,
"taskDurationMs": 296.076,
"heapDeltaBytes": 3873372,
"heapUsedBytes": 80789048,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 5.485,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.2420000000116,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.850999999999999,
"layouts": 9,
"layoutDurationMs": 2.1839999999999993,
"taskDurationMs": 575.6060000000001,
"heapDeltaBytes": 11678224,
"heapUsedBytes": 78630164,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 87.033,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.3230000000167,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.34,
"layouts": 10,
"layoutDurationMs": 2.068,
"taskDurationMs": 495.41599999999994,
"heapDeltaBytes": 11677020,
"heapUsedBytes": 79006240,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 79.131,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 834.165999999982,
"styleRecalcs": 19,
"styleRecalcDurationMs": 16.506999999999998,
"layouts": 5,
"layoutDurationMs": 9.315000000000001,
"taskDurationMs": 607.916,
"heapDeltaBytes": 9722364,
"heapUsedBytes": 104793624,
"domNodes": 15953,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 18.698,
"eventListeners": 3244,
"totalBlockingTimeMs": 77,
"frameDurationMs": 19.379069767441866,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8502.593000000048,
"styleRecalcs": 250,
"styleRecalcDurationMs": 23.099999999999998,
"layouts": 9,
"layoutDurationMs": 2.2500000000000004,
"taskDurationMs": 3842.543,
"heapDeltaBytes": -8644888,
"heapUsedBytes": 87380028,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 1898.2160000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666078431372547,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8287.80599999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 22.536,
"layouts": 9,
"layoutDurationMs": 2.231,
"taskDurationMs": 3715.988,
"heapDeltaBytes": 4613976,
"heapUsedBytes": 84214064,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 1844.27,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665995975855136,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14440.20499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13358.402999999998,
"heapDeltaBytes": -3725988,
"heapUsedBytes": 291668744,
"domNodes": -3330,
"jsHeapTotalBytes": 35381248,
"scriptDurationMs": 189.326,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.07081174438687,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 14715.70399999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13811.506,
"heapDeltaBytes": 484344,
"heapUsedBytes": 277257152,
"domNodes": -307,
"jsHeapTotalBytes": 35119104,
"scriptDurationMs": 160.209,
"eventListeners": -7,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.98471986417657,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17383.542999999976,
"styleRecalcs": 142,
"styleRecalcDurationMs": 12.779000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17111.925,
"heapDeltaBytes": -27588496,
"heapUsedBytes": 268007084,
"domNodes": -3330,
"jsHeapTotalBytes": 11788288,
"scriptDurationMs": 611.786,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.15907407407407,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 14431.010000000015,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.48299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13649.835,
"heapDeltaBytes": 11747212,
"heapUsedBytes": 293624676,
"domNodes": -3330,
"jsHeapTotalBytes": 21942272,
"scriptDurationMs": 601.45,
"eventListeners": -651,
"totalBlockingTimeMs": 15,
"frameDurationMs": 25.26118881118881,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 5307.508999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.896000000000015,
"layouts": 20,
"layoutDurationMs": 19.097,
"taskDurationMs": 5206.393999999999,
"heapDeltaBytes": -6937868,
"heapUsedBytes": 274276588,
"domNodes": -3330,
"jsHeapTotalBytes": 35381248,
"scriptDurationMs": 68.696,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.735928143712574,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-node-resize-workload",
"durationMs": 5226.091999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 44.31399999999999,
"layouts": 20,
"layoutDurationMs": 18.19599999999999,
"taskDurationMs": 5092.91,
"heapDeltaBytes": -12365856,
"heapUsedBytes": 283870784,
"domNodes": -3330,
"jsHeapTotalBytes": 36429824,
"scriptDurationMs": 69.635,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.614545454545453,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7174.150999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6600.0120000000015,
"heapDeltaBytes": -3953632,
"heapUsedBytes": 287216376,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 81.70299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.185521885521894,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7171.945000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6668.171000000001,
"heapDeltaBytes": 31558752,
"heapUsedBytes": 281366304,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 79.09799999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.21047297297297,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 436.15500000004204,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.806999999999999,
"layouts": 12,
"layoutDurationMs": 2.795,
"taskDurationMs": 91.97599999999998,
"heapDeltaBytes": -13107532,
"heapUsedBytes": 70460344,
"domNodes": 98,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.1739999999999995,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 436.2740000000258,
"styleRecalcs": 16,
"styleRecalcDurationMs": 9.667,
"layouts": 12,
"layoutDurationMs": 3.3770000000000007,
"taskDurationMs": 96.94699999999999,
"heapDeltaBytes": 6697812,
"heapUsedBytes": 79022800,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.243,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230772,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 186.85299999992822,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8450000000000001,
"layouts": 76,
"layoutDurationMs": 9.719999999999999,
"taskDurationMs": 151.43699999999998,
"heapDeltaBytes": 8714816,
"heapUsedBytes": 99775720,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 63.273999999999994,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 198.84799999999814,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.982,
"layouts": 76,
"layoutDurationMs": 9.404,
"taskDurationMs": 152.17600000000002,
"heapDeltaBytes": 8738228,
"heapUsedBytes": 99044428,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 64.33599999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 232.19700000004195,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.416,
"layouts": 76,
"layoutDurationMs": 9.075,
"taskDurationMs": 188.159,
"heapDeltaBytes": -2391676,
"heapUsedBytes": 128828828,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 61.57,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 238.77700000002733,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4580000000000002,
"layouts": 76,
"layoutDurationMs": 9.346,
"taskDurationMs": 198.096,
"heapDeltaBytes": -2210112,
"heapUsedBytes": 124029188,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 59.995,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2285 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 35e4208ba6817b5e90189d1b890dbfb2af3b078e
Full docs: ADR-DEVEX-LINT-0015 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76629ccc74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| [() => canvasStore.canvas, runningOn], | ||
| ([canvas, label]) => { | ||
| if (canvas && label !== undefined) canvas.info_text = label |
There was a problem hiding this comment.
Invalidate the canvas after updating its info label
When the deployment lookup finishes after the canvas's initial render, such as after a slow response or retry, this watch updates info_text without marking the foreground dirty. LGraphCanvas.draw() only invokes drawFrontCanvas() while dirty_canvas is set, so the displayed line can remain blank or stale until an unrelated pointer or graph event triggers a redraw; call setDirty(true) after assigning the new label.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.57 #21724 +/- ##
=============================================
Coverage ? 85.86%
=============================================
Files ? 2719
Lines ? 152836
Branches ? 40624
=============================================
Hits ? 131237
Misses ? 21210
Partials ? 389
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backport of #21148 to
cloud/1.57. It moves the "Running on" deployment switcher out of the profile menu and into the Run bar. Homestead's e2e prod testing needs it today, and 1.58 won't reach prod in time.The bot's automatic backport hit conflicts.
cloud/1.57predates the theme-token rename (#20988) and the template-class pruning (#21159), so #21148's color classes don't exist on this branch. I took #21148's version of every conflicting file and renamed its color classes to the 1.57 tokens with the same values:bg-accent,ring-accentbg-secondary-background-hover,ring-secondary-background-hoverbg-secondary,ring-secondarybg-secondary-background,ring-secondary-backgroundring-backgroundring-base-backgroundtext-foregroundtext-base-foregroundtext-warningtext-warning-foregroundbg-successbg-success-backgroundbg-primarybg-primary-backgroundThe mapping follows 1.57's own
secondarybutton variant and menu styles, which use these tokens for the same states. The Run bar test keeps 1.57'sStatusBadgestub name.DeploymentSwitcherOwnerFooter.vueis deleted, the same as in #21148. Nothing else changed in behavior.Verification
pnpm typecheck: passesvitest run src/platform/workspace src/components/actionbar/ComfyActionbar.test.ts: 106 files, 3,021 tests pass