Repository navigation
test(agent): pin a mid-turn node recolour reverting on an agent rename (FE-3494) - #21660
christian-byrne wants to merge 1 commit into
Conversation
…e (FE-3494) Colour, shape and properties have no write-back op, yet the follower re-applies them from the document whenever the document edits that node. Expected failure until set_node_field accepts these fields end to end.
|
Superseded by #21661 (same test). Reopened without the Linear id in the title and branch so merging a red test does not auto-close FE-3494. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Comment |
🎭 Playwright: ✅ 3050 passed, 0 failed · 2 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8bf8cf6f8e6c967d9e8b9f99bf4e6282547ac060
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (140)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Summary
Red test only. A node the user recolours while an agent turn is still editing it snaps back to the agent's colour when the agent renames that node. Pinned as
test.fail(); no product change.Tracks FE-3494.
Full context for agent readers
Why it reverts.
set_node_fieldcarries onlytitle,mode,flags.collapsed,flags.pinned(comfy-multi-playerWRITABLE_NODE_FIELDS; frontendNodeFieldWriteingraphIntents.ts). Colour, shape andpropertiessetters emit no intent, so a local edit never reaches the document. But when the document edits a node's title/mode/flags,DocChangeCollectormarks it for resync andLiveGraphApplier.applyFieldsre-applies the document'spropertiesandapplyAppearancere-applies its colour/shape.Scope of the window, measured.
add_node: the user's colour survives the rename (passes).set_widgetframe alone does not revert it: widget changes go throughsyncWidgets, notapplyFields.services/agent/internal/loop/crdt.goensureDoc->replaceDocFromClient). So the live window is a recolour during a turn, on a node the document already holds a colour for (agent-coloured, or any coloured node in a workflow posted at turn start).agentTabSwitchCatchUp.spec.ts"keeps a node color after switching away and back".Fix chain (not in this PR). Same as FE-2592: widen
set_node_fieldin comfy-multi-player, comfy-cli vocabulary, cloud sidecar pin, then the frontend intents from the colour/shape/setPropertysetters. Or decide colour is local-only and stop re-applying it on resync; FE-2592's spike left colour/shape/showAdvancedas an open sync-vs-local call.src/workbench/extensions/agent/crdt/**is under the informal freeze, which permits test-only PRs.Verification
--project=cloud, dev server withDISTRIBUTION=cloud: withtest.fail()removed it fails at the final assertion (expected user redrgb(51, 34, 34), received agent greenrgb(34, 51, 34)) after the rename frame is confirmed applied; withtest.fail()it passes.pnpm typecheck:browser, oxfmt, oxlint, eslint clean.