Repository navigation
Conversation
Selecting a catalog example now fills each media input from that example's own reference_media, using the URL the catalog resolves for it: the Draft preview path in Draft Preview, the public catalog-media path once Live. Mapping per media input: an explicit presentation.inputMedia index, else a stored value that names one of the example's reference files (so existing values holding an absolute demo URL are rewritten to the served path), else the first unused reference when exactly one media input is empty. Same-origin /catalog-media/ and /preview-media/ paths are accepted as example files: they preview in the form, load with same-origin credentials, skip the https-only schema checks because they are uploaded before the request, and are re-uploaded to Cloud on Run. workflowHttpsUrl now rejects unparseable values instead of throwing from its refinement.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsFallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (16 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e2c40e45d8dd679c2bd0fb78eb8776fb9a185e32
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (132)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## work/ccc-mar-integration-20261014 #21637 +/- ##
=====================================================================
- Coverage 86.45% 86.34% -0.11%
=====================================================================
Files 4030 3923 -107
Lines 184642 181423 -3219
Branches 50825 49725 -1100
=====================================================================
- Hits 159627 156653 -2974
+ Misses 22316 22220 -96
+ Partials 2699 2550 -149
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 107 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Selecting a catalog example now fills its image, video and audio inputs from the example's own
reference_media, using the URL the catalog already resolves inwebsite_media(/preview-media/…in Draft Preview,/catalog-media/…once Live). Until now the form only filled media inputs from absolute URLs authored intoexamples[].values, so authors copied a host-specific/catalog-media/URL into every example: it breaks when the host changes, never shows in Draft Preview, and duplicates the reference.Stacked on #21204.
catalog-presentation.ts: per media input (schemaformat: uriorcontrol: media), the value is, in order:presentation.inputMedia[input](areference_mediaindex); else the reference a stored value already names by media id, so existing absolute URLs are rewritten to the served path; else, when exactly one media input is empty, the first unused reference. Several unmapped media inputs stay empty rather than guessing an order.inputMediais not passed on as example presentation.workshop-example-file.ts: same-origin/catalog-media/{uid}/{version}and/preview-media/{rev}/{uid}/{version}paths are example files.PlaygroundFieldpreviews any valueworkshopExampleFileaccepts.credentials: 'same-origin'(Draft media needs the session) and uploaded to Cloud like any URL input.validateFormandprepareWorkflowRenderskip the^https://schema check for them because they are replaced by the upload before the request.workflowHttpsUrlreturns false for unparseable values instead of throwing from its refinement (the uploader reported a relative path asmedia_unavailablerather thaninvalid_input).Open question for the catalog API: example validation currently requires a required media input to be present in
values. With this change the site fills it fromreference_media, sovaluesshould be allowed to omit it.Verification
catalog-presentation.test.ts(fill, rewrite, explicit mapping, untouched template URL, ambiguous inputs, noinputMedialeak),workshop-example-file.test.ts(catalog paths load same-origin; traversal and malformed paths rejected),workshop-workflow-upload.test.ts(credentials per source; malformed paths rejected before fetching),workflow-render.test.ts(an example reference path is uploaded on Run).vitest run src/config src/lib/cms src/components/workshop: 5525 passed.typecheck:website: 0 errors. oxlint/oxfmt clean on changed files.SITE_CATALOG_API_URLpointed at the demo catalog. On/hub/workflows/flux-2-klein-9b-image-edit-563f9b5f6ce3/, "Image to edit" was an empty upload box before; it now previews the example's input, and "Reference image" previews the reference file. No console errors. Draft Preview not exercised (needs a staff session).mainand fails onFacetSheet.vueandExamplesTab.vuefrom the base branch, plusvalidateForm, which this PR touches but reduces from cyclomatic ~54 to 48 by extractinginputSchemaRejects.