Repository navigation
[backport cloud/1.58] feat(workspace): Running on moves to an engine button in the Run bar - #21630
Conversation
…21148) ## Summary "Running on" leaves the account menu for an engine button in the Run bar, between the drag handle and Run. It opens a compact Run on list of Comfy Cloud and the workspace's deployments. Closes DES-1254 **Related follow-ups:** #21183 asks to save unsaved workflows before a switch. #21184 adds the custom deployment dialog, Extensions on Comfy Cloud and the dot on the engine button. #21186 sends what a deployment lacks to its Build. #21188 offers a custom deployment when a workflow Comfy Cloud lacks nodes for is opened. - Who sees it does not change: the button renders only on Cloud sign-ins (`isCloud && !isApiKeyLogin`) whose deployments listing answers, the same accounts that see the switcher in the account menu today. Local and Desktop builds don't change. - Each row shows the Build name, then the deployment and its Release ("staging · v4"). A status shows on the right only when the deployment isn't ready. The engine button's icon carries the status dot. Its hover tooltip and accessible name say when jobs won't run. - Owners choose the workspace default from a Workspace default submenu, which replaces the owner footer. Re-picking the current default does nothing. A default change reloads only when it changes what this browser runs on. - Picking the default's row over an own pick follows the default. Over an own pick of that same deployment, it follows without a reload, and the list stays locked until the server answers. - Create a custom deployment opens the Builds section of Platform's Deploy page (`/profile/deploy#builds`) in a new tab. - During a switch, the picked row shows Switching. After the reload, a toast names where the editor landed, and the canvas line names the deployment instead of always saying Comfy Cloud. - If the page is still in use after a switch reload, for example the user stayed at the browser's leave prompt, the next pointer or key press ends Switching and refreshes the listing. - A 403 or 404 hides the switcher for good, including when a listing was shown before. A failed first listing retries on window focus, one request at a time, after the boot listing. - The floating Run bar stays on screen when the engine button widens it. ## Review focus - `deploymentPickStore`: `followInPlace`, `defaultMovesThisBrowser`, the 404 handling and `listingRefused`. - `deploymentSwitchReload`: the landing mark, and the one-shot listener that recovers a page that stayed. - Copy is English only; the i18n job translates the `deploymentSwitcher` block. - Overlaps Vinh's open drafts #20372 (row marks) and #20373 (switcher from the missing-nodes message). The model-source, listing-retry and boot-hint behavior from #21010 and #21368 is preserved, including main's definitive 404 refusal. ## Verification - Unit: 177 files, 4,342 tests pass across `src/platform/workspace`, `src/components/actionbar`, `src/extensions/core`, `GraphCanvas` and the Issues panel. After the review fixes and the main merge (`5525adb4bb`), the 39 switcher, store, label, reload, actionbar and `GraphCanvas` files (1,702 tests) pass again. After the lock fix (`f9ef7b68d8`), all 111 `src/platform/workspace` files (3,442 tests) pass. - Pre-commit (oxfmt, oxlint, eslint, server-facts lint, `typecheck:app`) and pre-push (knip, fallow) pass with no bypasses. - The Create a custom deployment link was checked against Platform: `pages/profile/deploy` scrolls to the section named by the hash, and `BuildsSection` has `id="builds"`. - Seen in a browser during design review on a stagingcloud dev server: the engine button, the list, a switch and the landing toast. A live switch against staging after the latest changes has not been repeated. ### Changes in the takeover review (`ca54ed1f88`, `f9ef7b68d8`) - Following the default in place now locks the switcher like any other switch (Codex P1). Before, the menu stayed enabled during the clear request, so a second pick could race it on the server and leave the browser on a different deployment than the last one chosen. A new store test fails without the fix. - Restored main's escaped dash in the OAuth consent notice, which an earlier merge had rewritten. - Removed `g.comfyCloud`, which nothing reads now that the canvas line names the boot deployment. - Corrected story descriptions that still said the list tags the default row, and cut the new doc comments to one line. - `markSwitchLanding` no longer returns a value nothing reads. ### Risk and limits - The focus-triggered retry can report a listing failure again on each later focus during an outage. - A click or key press during a slow switch reload clears the landing-toast mark and unlocks the switcher, so a second pick can go out. That later pick wins and the editor reloads onto it. - If the deployments listing fails right after a switch, the editor falls back to Comfy Cloud and the landing toast says "Running on Comfy Cloud" while jobs still run on the picked deployment. The existing "Could not check which deployment this editor runs on" error shows at the same time and stays until closed. Left for a follow-up. ### How to revert Revert this PR. No data migration or production configuration change is required. --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-22T01:47:00.411Z",
"gitSha": "62561fed6784cfca5b32a04bac3f6bd1f40152fc",
"branch": "backport-21148-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2029.9289999999814,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0809999999999995,
"layouts": 8,
"layoutDurationMs": 1.9819999999999998,
"taskDurationMs": 409.55600000000004,
"heapDeltaBytes": 4054236,
"heapUsedBytes": 92457996,
"domNodes": -200,
"jsHeapTotalBytes": -3235840,
"scriptDurationMs": 9.350999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2012.8520000000663,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9710000000000005,
"layouts": 10,
"layoutDurationMs": 2.8330000000000006,
"taskDurationMs": 536.376,
"heapDeltaBytes": 6783292,
"heapUsedBytes": 113255168,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.303,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1898.6110000000167,
"styleRecalcs": 54,
"styleRecalcDurationMs": 11.258,
"layouts": 9,
"layoutDurationMs": 2.534,
"taskDurationMs": 1003.034,
"heapDeltaBytes": -29043820,
"heapUsedBytes": 77520008,
"domNodes": 0,
"jsHeapTotalBytes": 2072576,
"scriptDurationMs": 135.386,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66637168141593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.5380000000578,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.591000000000001,
"layouts": 8,
"layoutDurationMs": 2.2590000000000003,
"taskDurationMs": 752.3100000000001,
"heapDeltaBytes": -13539988,
"heapUsedBytes": 78372008,
"domNodes": -180,
"jsHeapTotalBytes": 2334720,
"scriptDurationMs": 141.596,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.8449999999593,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.853999999999999,
"layouts": 12,
"layoutDurationMs": 2.822,
"taskDurationMs": 394.756,
"heapDeltaBytes": 1835672,
"heapUsedBytes": 105552784,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.243,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.2329999999556,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.9510000000000005,
"layouts": 12,
"layoutDurationMs": 2.792,
"taskDurationMs": 290.33,
"heapDeltaBytes": 1820248,
"heapUsedBytes": 105644828,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 10.81,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 651.7599999999675,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.17,
"layouts": 10,
"layoutDurationMs": 2.7129999999999996,
"taskDurationMs": 485.8500000000001,
"heapDeltaBytes": 6480336,
"heapUsedBytes": 110615308,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 160.496,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 675.2329999999347,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2379999999999995,
"layouts": 10,
"layoutDurationMs": 2.542,
"taskDurationMs": 494.05699999999996,
"heapDeltaBytes": 7371656,
"heapUsedBytes": 111177704,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 162.555,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000018,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1179.2440000000397,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 888.0240000000001,
"heapDeltaBytes": -10746488,
"heapUsedBytes": 101996996,
"domNodes": -231,
"jsHeapTotalBytes": 14086144,
"scriptDurationMs": 60.266,
"eventListeners": -168,
"totalBlockingTimeMs": 495,
"frameDurationMs": 31.978378378378373,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1162.7680000000282,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 867.2109999999999,
"heapDeltaBytes": -16556720,
"heapUsedBytes": 102282348,
"domNodes": -210,
"jsHeapTotalBytes": 16498688,
"scriptDurationMs": 61.22300000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 478,
"frameDurationMs": 31.52972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.4380000000156,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.854,
"heapDeltaBytes": -5585212,
"heapUsedBytes": 96572124,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.148,
"eventListeners": 0,
"totalBlockingTimeMs": 210,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.6620000000185,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.26800000000026,
"heapDeltaBytes": -4179564,
"heapUsedBytes": 97225308,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.11700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9856.648000000007,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.03799999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8965.294,
"heapDeltaBytes": 28289900,
"heapUsedBytes": 150605408,
"domNodes": -296,
"jsHeapTotalBytes": 41328640,
"scriptDurationMs": 6998.4529999999995,
"eventListeners": -126,
"totalBlockingTimeMs": 368,
"frameDurationMs": 27.667415730337076,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8711.032000000047,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.33199999999999985,
"layouts": 1,
"layoutDurationMs": 0.22299999999999967,
"taskDurationMs": 7723.196999999999,
"heapDeltaBytes": 23331088,
"heapUsedBytes": 137127688,
"domNodes": -276,
"jsHeapTotalBytes": 24354816,
"scriptDurationMs": 6335.208,
"eventListeners": -130,
"totalBlockingTimeMs": 150,
"frameDurationMs": 27.530696202531644,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8976.227999999992,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.588,
"layouts": 2,
"layoutDurationMs": 0.42600000000000016,
"taskDurationMs": 7999.165,
"heapDeltaBytes": 11954652,
"heapUsedBytes": 133364472,
"domNodes": -276,
"jsHeapTotalBytes": 36347904,
"scriptDurationMs": 6593.418,
"eventListeners": -130,
"totalBlockingTimeMs": 254,
"frameDurationMs": 28.830546623794216,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9514.70699999993,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2279999999999999,
"layouts": 1,
"layoutDurationMs": 0.21600000000000005,
"taskDurationMs": 8801.587,
"heapDeltaBytes": 33265248,
"heapUsedBytes": 147700572,
"domNodes": -276,
"jsHeapTotalBytes": 35102720,
"scriptDurationMs": 6975.213,
"eventListeners": -130,
"totalBlockingTimeMs": 223,
"frameDurationMs": 29.050764525993884,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 206.6740000000209,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.532000000000002,
"layouts": 10,
"layoutDurationMs": 2.766,
"taskDurationMs": 159.61999999999998,
"heapDeltaBytes": 13256400,
"heapUsedBytes": 118177648,
"domNodes": 917,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 8.072,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 183.75600000001668,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.227999999999998,
"layouts": 10,
"layoutDurationMs": 2.6229999999999998,
"taskDurationMs": 143.10899999999998,
"heapDeltaBytes": 13290644,
"heapUsedBytes": 118229372,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 7.8779999999999974,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.924999999999955,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2039.0320000000202,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1159999999999997,
"layouts": 8,
"layoutDurationMs": 1.9700000000000004,
"taskDurationMs": 648.598,
"heapDeltaBytes": 3406428,
"heapUsedBytes": 105655188,
"domNodes": -276,
"jsHeapTotalBytes": -5595136,
"scriptDurationMs": 36.36599999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66475409836066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.7510000000375,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1029999999999998,
"layouts": 8,
"layoutDurationMs": 2.013,
"taskDurationMs": 646.0210000000001,
"heapDeltaBytes": -46320,
"heapUsedBytes": 102334588,
"domNodes": -296,
"jsHeapTotalBytes": -5595136,
"scriptDurationMs": 39.486,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2247.837000000004,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.717,
"layouts": 6,
"layoutDurationMs": 1.334,
"taskDurationMs": 1606.185,
"heapDeltaBytes": 1224708,
"heapUsedBytes": 104918056,
"domNodes": -276,
"jsHeapTotalBytes": -913408,
"scriptDurationMs": 764.362,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2219.3600000000515,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.761000000000001,
"layouts": 6,
"layoutDurationMs": 1.419,
"taskDurationMs": 1424.2379999999998,
"heapDeltaBytes": 825528,
"heapUsedBytes": 104541044,
"domNodes": -296,
"jsHeapTotalBytes": -1175552,
"scriptDurationMs": 746.4920000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793181818181818,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3514.0519999999924,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.211000000000002,
"layouts": 65,
"layoutDurationMs": 10.955000000000002,
"taskDurationMs": 1660.6330000000003,
"heapDeltaBytes": 7916336,
"heapUsedBytes": 121758416,
"domNodes": 24,
"jsHeapTotalBytes": 5771264,
"scriptDurationMs": 741.092,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66587677725119,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3570.8640000000287,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.972999999999999,
"layouts": 64,
"layoutDurationMs": 10.669,
"taskDurationMs": 1724.5849999999998,
"heapDeltaBytes": -14294976,
"heapUsedBytes": 90764644,
"domNodes": -272,
"jsHeapTotalBytes": -1163264,
"scriptDurationMs": 747.2639999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467293,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2600.6960000000277,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.492,
"layouts": 5,
"layoutDurationMs": 1.408,
"taskDurationMs": 1660.1129999999998,
"heapDeltaBytes": 19021780,
"heapUsedBytes": 125785820,
"domNodes": 0,
"jsHeapTotalBytes": 8024064,
"scriptDurationMs": 917.768,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.99281045751634,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2776.016000000027,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.376999999999999,
"layouts": 5,
"layoutDurationMs": 1.2300000000000002,
"taskDurationMs": 1864.0639999999999,
"heapDeltaBytes": 19279976,
"heapUsedBytes": 125360748,
"domNodes": 0,
"jsHeapTotalBytes": 8286208,
"scriptDurationMs": 919.0409999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86890243902439,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2036.0850000000141,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1919999999999993,
"layouts": 8,
"layoutDurationMs": 2.02,
"taskDurationMs": 482.91799999999995,
"heapDeltaBytes": 671288,
"heapUsedBytes": 104286568,
"domNodes": -296,
"jsHeapTotalBytes": -5857280,
"scriptDurationMs": 36.463,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.5369999999812,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7400000000000002,
"layouts": 7,
"layoutDurationMs": 1.829,
"taskDurationMs": 636.55,
"heapDeltaBytes": -269820,
"heapUsedBytes": 103854632,
"domNodes": -296,
"jsHeapTotalBytes": -5595136,
"scriptDurationMs": 34.32900000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 646.9899999999598,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.211,
"layouts": 10,
"layoutDurationMs": 2.746,
"taskDurationMs": 472.366,
"heapDeltaBytes": 2151168,
"heapUsedBytes": 110984512,
"domNodes": 0,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 145.721,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 550.3479999999854,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.36,
"layouts": 10,
"layoutDurationMs": 2.593,
"taskDurationMs": 376.41799999999995,
"heapDeltaBytes": 2754652,
"heapUsedBytes": 108559620,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 145.277,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2024.7309999999743,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.74,
"layouts": 11,
"layoutDurationMs": 2.829,
"taskDurationMs": 591.9010000000001,
"heapDeltaBytes": -16060208,
"heapUsedBytes": 90170132,
"domNodes": -218,
"jsHeapTotalBytes": 2269184,
"scriptDurationMs": 7.907000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2026.391999999987,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.398,
"layouts": 9,
"layoutDurationMs": 2.3280000000000003,
"taskDurationMs": 409.05800000000005,
"heapDeltaBytes": 4549644,
"heapUsedBytes": 95020380,
"domNodes": -218,
"jsHeapTotalBytes": -3760128,
"scriptDurationMs": 8.202999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1993.0769999999711,
"styleRecalcs": 86,
"styleRecalcDurationMs": 14.660000000000002,
"layouts": 10,
"layoutDurationMs": 2.583,
"taskDurationMs": 1028.1480000000001,
"heapDeltaBytes": -6353760,
"heapUsedBytes": 94459796,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 100.21100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.876000000022,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.154000000000002,
"layouts": 9,
"layoutDurationMs": 2.26,
"taskDurationMs": 621.745,
"heapDeltaBytes": 20641288,
"heapUsedBytes": 113553408,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 97.705,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 933.5790000000088,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.233999999999998,
"layouts": 5,
"layoutDurationMs": 14.940999999999995,
"taskDurationMs": 766.2970000000003,
"heapDeltaBytes": 11582876,
"heapUsedBytes": 133265232,
"domNodes": 16030,
"jsHeapTotalBytes": 16130048,
"scriptDurationMs": 23.593999999999998,
"eventListeners": 3244,
"totalBlockingTimeMs": 132,
"frameDurationMs": 20.742222222222214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8268.52100000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.352999999999998,
"layouts": 7,
"layoutDurationMs": 1.6579999999999997,
"taskDurationMs": 4826.116000000001,
"heapDeltaBytes": 5484788,
"heapUsedBytes": 107933112,
"domNodes": -276,
"jsHeapTotalBytes": -651264,
"scriptDurationMs": 2502.173,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699595959595957,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8450.60799999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.136999999999997,
"layouts": 7,
"layoutDurationMs": 1.802,
"taskDurationMs": 5582.801999999999,
"heapDeltaBytes": -3302664,
"heapUsedBytes": 99288904,
"domNodes": -296,
"jsHeapTotalBytes": -651264,
"scriptDurationMs": 2499.2609999999995,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.732079207920794,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23074.717000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22327.269,
"heapDeltaBytes": -1638676,
"heapUsedBytes": 304199808,
"domNodes": -3344,
"jsHeapTotalBytes": -13119488,
"scriptDurationMs": 330.925,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.93494809688582,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 16392.161999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15426.175,
"heapDeltaBytes": -2632316,
"heapUsedBytes": 302922300,
"domNodes": -3344,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 250.92700000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.57020905923345,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 19531.30699999997,
"styleRecalcs": 155,
"styleRecalcDurationMs": 15.75399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19058.204,
"heapDeltaBytes": -14666772,
"heapUsedBytes": 309961144,
"domNodes": -3344,
"jsHeapTotalBytes": 24891392,
"scriptDurationMs": 865.5189999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 38,
"frameDurationMs": 36.509532710280375,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 27877.087000000072,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.554000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27500.609999999997,
"heapDeltaBytes": -38658620,
"heapUsedBytes": 285200840,
"domNodes": -3344,
"jsHeapTotalBytes": 7327744,
"scriptDurationMs": 841.316,
"eventListeners": -651,
"totalBlockingTimeMs": 34,
"frameDurationMs": 53.51669865642994,
"p95FrameDurationMs": 116.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 8175.516000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.181,
"layouts": 20,
"layoutDurationMs": 33.864999999999995,
"taskDurationMs": 8065.3110000000015,
"heapDeltaBytes": -38956332,
"heapUsedBytes": 290194016,
"domNodes": -3344,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 147.318,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.20404624277456,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8313.25400000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.181,
"layouts": 20,
"layoutDurationMs": 23.360000000000007,
"taskDurationMs": 8181.668000000001,
"heapDeltaBytes": -44649072,
"heapUsedBytes": 275573492,
"domNodes": -3344,
"jsHeapTotalBytes": 12046336,
"scriptDurationMs": 134.40799999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.15738636363637,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11385.331999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11046.561999999998,
"heapDeltaBytes": 9921404,
"heapUsedBytes": 290866344,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.54100000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.32975778546714,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8199.826999999914,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7628.330000000002,
"heapDeltaBytes": 18811144,
"heapUsedBytes": 294813568,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.5,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.701689189189192,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 110.20400000006703,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.5649999999999995,
"layouts": 7,
"layoutDurationMs": 2.3480000000000003,
"taskDurationMs": 73.33299999999998,
"heapDeltaBytes": 4810676,
"heapUsedBytes": 106257548,
"domNodes": 97,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.050999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68571428571431,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 457.1879999999737,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.197,
"layouts": 11,
"layoutDurationMs": 3.8960000000000004,
"taskDurationMs": 103.469,
"heapDeltaBytes": -13096928,
"heapUsedBytes": 88426136,
"domNodes": 95,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.689,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 415.82900000003065,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6819999999999999,
"layouts": 76,
"layoutDurationMs": 14.25,
"taskDurationMs": 373.24999999999994,
"heapDeltaBytes": -15123400,
"heapUsedBytes": 79698028,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 172.47099999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 530.744000000027,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.848,
"layouts": 76,
"layoutDurationMs": 14.938999999999998,
"taskDurationMs": 471.422,
"heapDeltaBytes": -20141848,
"heapUsedBytes": 71597192,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 229.837,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.203225806451588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 476.52000000005046,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.745,
"layouts": 76,
"layoutDurationMs": 13.700000000000001,
"taskDurationMs": 442.445,
"heapDeltaBytes": -4762204,
"heapUsedBytes": 102978488,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.624,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 517.1699999999646,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7260000000000002,
"layouts": 76,
"layoutDurationMs": 13.116,
"taskDurationMs": 475.88399999999996,
"heapDeltaBytes": 504272,
"heapUsedBytes": 117297840,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 192.802,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2951 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9982ad03914b56b00d99e875251018e3dc833adf
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (118)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.58 #21630 +/- ##
=============================================
Coverage ? 86.18%
=============================================
Files ? 2789
Lines ? 154781
Branches ? 39241
=============================================
Hits ? 133393
Misses ? 21001
Partials ? 387
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
benceruleanlu
left a comment
There was a problem hiding this comment.
Clean bot cherry-pick of #21148 (same patch as main), CI green. Needed on 1.58 for Homestead dogfooding.
Backport of #21148 to
cloud/1.58Automatically created by backport workflow.