Skip to content

feat(website): node graph layout for catalog workflows that cannot run - #21581

Closed
comfydesigner wants to merge 10 commits into
work/ccc-mar-integration-20261014from
comfydesigner/hub-node-graph-ccc
Closed

comfydesigner wants to merge 10 commits into
work/ccc-mar-integration-20261014from
comfydesigner/hub-node-graph-ccc

Conversation

@comfydesigner

@comfydesigner comfydesigner commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #21204, so it merges after #21204. Replaces #21462. Brings the node graph workflow design from #21462 to real catalog workflows: a workflow whose Runnable switch is off now uses that layout instead of the single preview column. Runnable workflows are unchanged.

Summary

In WorkflowPage.vue, the !runnable branch renders WorkflowNodeGraphTabs in place of WorkflowPreview, the About section and the download-only API section. The header (WorkflowActions, as on runnable pages) and the catalog FAQ stay as they are.

  • Overview (the Playground's two panels, read-only):
    • About: the catalog longDescription, with paragraphs after the first behind "Read more". "What you provide" lists the graph's loader nodes, images first. The footer has a "Runs in ComfyUI" note and a sticky Try in Cloud, in Run's place. With no Cloud link the footer shows Download instead, and says the workflow only runs in your own ComfyUI only when worksOnCloud is false. Footer clicks fire the same try_in_cloud_clicked and workflow_download_clicked events as the header, with a placement property (header, footer or versions).
    • Output: the catalog examples (examplesForModel) with the Example badge, plus the sample gallery.
  • Details: WorkflowGraph on the selected workflow file, with the version select and Download, falling back to the template preview image. The right column is the existing WorkflowFacts (model links, runs, downloads, Cloud row, author), plus a card listing the graph's custom node packs.
  • Tab switches send tab_switched, and the API tab also sends api_viewed, as on runnable pages.
  • API: the existing catalog WorkflowApi (download-only), now inside the tab.

Where the data comes from:

  • nodeGraphWorkflowFromModel maps catalogDetails onto the layout. It falls back to the static summary.
  • What the reader provides and the custom node packs are not in the catalog record, so useNodeGraphNeeds reads them from the workflow file the graph loads. A skeleton shows while it loads.
  • The loader table is FILE_INPUTS, moved to lib/hub/file-inputs.ts so the island doesn't bundle workflow-detail.ts's server data, plus LoadImageMask. Muted and bypassed nodes are skipped, and only subgraphs the graph instantiates are read.
  • Packs are keyed by cnr_id. Display names come from node-pack-names.ts where the repository's pack lists spell them, then the aux_id repo name, then the id.

Not in this PR: #21462's design preview route and sample. Once this lands they are no longer needed.

For the catalog side (@benjcooley): should the catalog store each workflow's inputs and custom node packs, so the page can render them in its first HTML instead of after reading the graph?

Verification

  • Unit tests: WorkflowNodeGraphTabs.test.ts covers the tabs, inputs read from the graph (images first, with the loading state), the footer for Cloud and local-only workflows, the custom node packs on Details, and the API slot. node-graph-inputs.test.ts, node-graph-workflow.test.ts (including the catalog mapping) and the updated WorkflowPage.test.ts (the generated code is now behind the API tab) also pass.
  • pnpm typecheck:website, eslint, oxlint, knip and pnpm --filter @comfyorg/website build pass. The fallow audit's remaining complexity findings are in FacetSheet.vue and ExamplesTab.vue, which this PR does not change. Copy is added in en and zh-CN.
  • Checked locally with catalog mode on, against a local stand-in for /api/v1/catalog/items serving the seed's singing-character as a native workflow document with runnable: false, at 1440 and 390 wide.

…raph layout

A catalog workflow whose Runnable switch is off now gets the Overview,
Details and API tabs instead of the single preview column. Overview shows
the catalog description, what the reader provides and the sample outputs,
with a sticky Try in Cloud (or Download when it cannot open in Cloud) in
the About footer. Details shows the graph with its models, custom node
packs, output and author, and API keeps the catalog code panel. Inputs and
packs are read from the workflow file, with a loading state. The header
and FAQ are unchanged.
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 50f85eec-d9a6-4302-b283-565532071b38

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since e2c40e45d8dd679c2bd0fb78eb8776fb9a185e32

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (111)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 61 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

🌐 Website E2E

Tip

All tests passed.

View Report

Test results
Status ✅ Passed

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21581.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

Deployment details

This commit: https://website-frontend-6yoww9k2t-comfyui.vercel.app

Last updated: 2026-10-21T23:43:32Z for e07862f

@comfydesigner comfydesigner added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 21, 2026
@comfydesigner
comfydesigner marked this pull request as ready for review October 21, 2026 20:07
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 21, 2026
@datadog-official

This comment has been minimized.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @comfydesigner.

Found 10 finding(s).

Severity Count
🟡 Medium 4
🟢 Low 5
⚪ Nit 1

Panel: 6/6 reviewers contributed findings.

Each subgraph is expanded once and the walk is capped, so nested instances
cannot blow up. Reading the graph waits for mount, aborts on change or
unmount, times out, and reports a failed read instead of no needs. Details
restores the version picker and the pre-rendered graph fallback, the footer
download keeps the page's file name, the runs-in note shows only with an
action, and blank catalog descriptions, authors and model names fall back.
…o components

Keeps the About panel and the tabs within the repository's complexity limit
after the version picker and read states were added.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: node graph layout for non-runnable catalog workflows

The layout is cleanly isolated, the fetch race guard is right, and node-graph-inputs parsing (modes, subgraph recursion guard, Object.hasOwn) and its tests are solid. No blockers. But a few things need fixing before merge.

Severity Count
BLOCKER 0
SHOULD FIX 9
TRIVIAL 4

Main points

  1. Features silently dropped. Swapping WorkflowPreview for the tabs drops the version picker, the model links, the runs/downloads facts, the author avatar and the previewUrl fallback for every non-runnable catalog page. The PR description doesn't mention any of this. Please confirm it's intended or carry them over.
  2. useNodeGraphNeeds fetches during SSR, and treats failure as "needs nothing". The immediate watcher runs on the server (WorkflowGraph gates on useMounted; this doesn't), and a failed read hides the inputs and custom-node sections instead of showing they couldn't be read.
  3. Copy and markup regressions.
    • The footer says "can only run on your own ComfyUI" whenever cloudHref is missing, even when worksOnCloud isn't false.
    • About paragraphs lost whitespace-pre-line / wrap-break-word.
    • Only the first About paragraph is in the SSR HTML.

On your catalog question (@benjcooley): yes, I'd store inputs and custom node packs in the catalog record, or compute them where public/workflow-graphs/ is already read at build time. That fixes the client fetch, the SSR skeleton and the hand-kept node-pack-names.ts table together.

Tests: node-graph-inputs.test.ts passes locally. I could not run the component tests here; the local node_modules is from another branch. Missing coverage is listed inline.

Reuse WorkflowFacts on Details, keep every About paragraph in the
server HTML, give the footer copy for download-only workflows, pause
hidden samples, select samples by id, and report tab switches and
CTA placement.
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.63158% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../src/components/workshop/WorkflowNodeGraphTabs.vue 82.50% 5 Missing and 2 partials ⚠️
.../components/workshop/WorkflowNodeGraphOverview.vue 88.57% 2 Missing and 2 partials ⚠️
...s/website/src/components/workshop/WorkflowPage.vue 85.00% 1 Missing and 2 partials ⚠️
...src/components/workshop/WorkflowNodeGraphAbout.vue 88.88% 1 Missing and 1 partial ⚠️
...mponents/workshop/WorkflowNodeGraphAboutFooter.vue 90.47% 1 Missing and 1 partial ⚠️
.../components/workshop/WorkflowNodeGraphVersions.vue 90.00% 0 Missing and 1 partial ⚠️
apps/website/src/lib/hub/node-graph-inputs.ts 98.43% 0 Missing and 1 partial ⚠️
apps/website/src/lib/hub/node-graph-workflow.ts 92.85% 0 Missing and 1 partial ⚠️
@@                         Coverage Diff                          @@
##             work/ccc-mar-integration-20261014   #21581   +/-   ##
====================================================================
  Coverage                                     ?   86.33%           
====================================================================
  Files                                        ?     3920           
  Lines                                        ?   182240           
  Branches                                     ?    49736           
====================================================================
  Hits                                         ?   157338           
  Misses                                       ?    22528           
  Partials                                     ?     2374           
Flag Coverage Δ
website-unit 80.82% <92.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mponents/workshop/WorkflowNodeGraphCustomNodes.vue 100.00% <100.00%> (ø)
...rc/components/workshop/WorkflowNodeGraphInputs.vue 100.00% <100.00%> (ø)
...ebsite/src/components/workshop/WorkflowPreview.vue 93.33% <100.00%> (ø)
apps/website/src/composables/useNodeGraphNeeds.ts 100.00% <100.00%> (ø)
apps/website/src/lib/hub/file-inputs.ts 100.00% <100.00%> (ø)
apps/website/src/lib/hub/node-pack-names.ts 100.00% <100.00%> (ø)
apps/website/src/lib/hub/workflow-detail.ts 75.43% <ø> (ø)
apps/website/src/scripts/workshop-analytics.ts 95.45% <ø> (ø)
.../components/workshop/WorkflowNodeGraphVersions.vue 90.00% <90.00%> (ø)
apps/website/src/lib/hub/node-graph-inputs.ts 98.43% <98.43%> (ø)
... and 6 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: fix commits f64ef320, ef4daebc, 8ba0e7a8 (merge ac4eca7b doesn't touch PR files)

Good round. 11 of my 13 threads are fixed and resolved:

  • the SSR fetch is gated on mount, with abort and timeout
  • the failed state is shown
  • WorkflowFacts is reused, which brings back model links, runs/downloads and the avatar
  • the version picker and previewUrl fallback are back
  • About text is in the server HTML and keeps its formatting
  • the footer copy is correct
  • samples are selected by id
  • placement, tab_switched and api_viewed are sent

The parser and pack-name replies are reasonable as deferrals. 55 tests pass at ac4eca7b.

Severity Count
BLOCKER 0
SHOULD FIX 4 (2 new inline, 2 open threads)
TRIVIAL 2 inline + a few below

SHOULD FIX

  1. Older Safari. useNodeGraphNeeds calls AbortSignal.any / AbortSignal.timeout directly. On the older Safari the repo explicitly supports (workshop-safari-abort.spec.ts), every read reports "Couldn't read the workflow file." Use @/utils/abortSignal. New from the fix.
  2. Reused subgraphs undercounted. Expanding each subgraph once fixes the blow-up, but a subgraph used twice now lists its inputs once. New from the fix.
  3. Sample video never resumes. The video is paused when the reader leaves Overview, but nothing plays it again on return, so the sample stays frozen (open thread).
  4. No tests for useNodeGraphNeeds. Removing the abort guard, the mount gate, the timeout or the !ok check doesn't fail any test (open thread).

TRIVIAL (not inline)

  • Orphaned i18n key: workshop.nodeGraph.runsWhere (en, zh-CN).
  • Template-backed downloads: downloadName === true renders download="true". The header has the same existing pattern.
  • Footer download and the picked version: the footer still downloads the latest file while the inputs follow the picked version. Fine if intended; a comment would help.

Still open from round 1 as a product decision for @benjcooley: inputs and packs are still read in the browser, so the server HTML has skeletons only. That's fine while workflow pages are noindex, but it should be decided before launch.

Play the looping sample video again when Overview returns. Cover
useNodeGraphNeeds on its own: the mount gate, timeout, error status,
a source change mid-read and an unmount, and check that picking a
version re-reads that file.
…aphs

Use the abortSignal fallbacks, list a reused subgraph's inputs once
per instance, settle a source-less read on the server, let the footer
download follow the picked version, and have WorkflowPreview render
the shared version picker.
@comfydesigner

Copy link
Copy Markdown
Contributor Author

Thanks for the re-review. The non-inline items, in 227f08a:

  • workshop.nodeGraph.runsWhere is removed from en and zh-CN.
  • With a template-backed download, the footer and version buttons now render a bare download attribute instead of download="true". I left the header's existing pattern alone.
  • The footer download now follows the picked version, so it matches the inputs shown.

Server-rendering the inputs and packs stays with you as the catalog decision before launch.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: a8dd9794, 227f08a3 — approving

All 6 open threads are fixed and resolved; I checked the code and ran the tests (84/84 pass across useNodeGraphNeeds, node-graph-*, WorkflowNodeGraphTabs, WorkflowPage, WorkflowPreview):

  • Older Safari: combineAbortSignals / createTimeoutSignal are used, and tests delete each static.
  • Subgraph inputs: counted per instance, with each subgraph's result reused, a cycle guard, and output capped at 5000.
  • No-source read: settles on the server, with no "Reading" flash and no hydration mismatch.
  • Sample video: resumes on return to Overview.
  • useNodeGraphNeeds tests: the mount gate, timeout, abort and stale-response guards now each fail a test when removed.
  • Version picker: WorkflowPreview now uses the shared picker; its standalone branch and the orphaned i18n key are gone. The footer download follows the picked version.
Severity Count
BLOCKER 0
SHOULD FIX 1 (test fixture for the memo; inline)
TRIVIAL 1 inline + below

TRIVIAL (non-blocking)

  • Untested lines: the placement: 'versions' event in WorkflowPreview and the download === true ? '' coercion (footer, Versions) have no test.
  • Header download="true": WorkflowActions still renders download="true" for template workflows. This is on the base branch, not from this PR; normalising downloadName once at the source would fix all three places.
  • Picked version: Try in Cloud and the header download stay on the latest file, while Overview's inputs and footer download follow the pick. Fine, but a one-line comment would help the next reader.
  • Round-2 nits still open: shallowRef, the footer's nested ternary in the template, the borrowed i18n keys, the duplicate paragraphs(), and model_viewed on this path.

Still open as a product decision, not a code issue: inputs and packs are read in the browser, so the server HTML only shows loading states. Fine while workflow pages are noindex.

Share the paragraph splitter with WorkflowPage, hold the graph read in
a shallowRef, name the footer copy in a computed, give the Details tab
its own label, and report model_viewed on non-runnable pages. Test the
version picker's placement and the download file names.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: e07862fc, 580bb725 — still approved

Both remaining threads are addressed and resolved, and the tidy-up is clean:

  • paragraphs() is shared with WorkflowPage.
  • The graph read is held in a shallowRef, and nothing mutates needs in place.
  • The footer copy is chosen in a computed.
  • The Details tab has its own key (en and zh-CN).
  • model_viewed is now sent on non-runnable pages.
  • New tests cover the memo, the input cap, download file names and the Preview picker's placement.

Tests: 89/89 pass across node-graph-*, useNodeGraphNeeds, WorkflowNodeGraphTabs, WorkflowPage and WorkflowPreview. I also ran mutations. The cap, download-name, footer-copy and Preview-placement tests each fail when their code is reverted.

Severity Count
BLOCKER 0
SHOULD FIX 1 (test-only; inline)
TRIVIAL a few, below

SHOULD FIX (test-only): the model_viewed test doesn't fail if the runnable gate, once or the workflowsEnabled gate is removed (inline).

TRIVIAL (non-blocking)

  • Memo test: removing the memo makes it hang rather than fail (see the thread reply).
  • Versions placement: the versions download inside WorkflowNodeGraphTabs isn't asserted to send placement: 'versions'; only the Preview path is.
  • paragraphs(): it lives in the layout-specific node-graph-workflow.ts, and LocalModelPage.vue still has its own copy. A neutral module would suit it better.
  • model_viewed is sent from two places: the Playground (runnable) and the page (non-runnable), kept complementary by hand. Sending it from the page for both would remove that coupling.
  • Round-3 nits still open: the repeated cloudHref || downloadUrl, the reset watch, and the borrowed i18n keys (cccWorkflow.version etc.).

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: a7378262 — still approved

The open model_viewed thread is addressed and resolved. The three new tests kill every mutation that survived last round. Each was re-applied on its own against WorkflowPage.vue:

Mutation Caught by
drop !runnable gate "leaves a runnable page to the Playground"
drop once: true "reports a non-runnable page once, even when access turns on late"
drop workflowsEnabled "reports nothing while Workflows access is off"
drop enabled / mounted caught (new and existing tests)

WorkflowPage.test.ts passes, 26/26. mockReset and restoreMocks stop counts leaking between tests, and there are no timers, so I don't expect flakiness.

Severity Count
BLOCKER 0
SHOULD FIX 0
TRIVIAL 3

TRIVIAL (non-blocking)

  • Test title: "leaves a runnable page to the Playground" stubs the Playground. It proves WorkflowPage sends nothing itself, which is what's needed, but the title reads like a no-double-count check. The Playground's single emission is pinned in WorkflowPlayground.test.ts; consider "does not report a runnable page itself".
  • Payload: views() matches the event name only. Nothing asserts the payload (page_type, model_slug, workflow_id), whereas WorkflowPlayground.test.ts does.
  • Cosmetic: flags() returns workflowsEnabled, which no caller uses. The older test still inlines the model_viewed filter; hoisting views() to module scope would share it.

@comfydesigner

Copy link
Copy Markdown
Contributor Author

Moved to Comfy-Org/comfy-website#35, now that the website lives in comfy-website. It's the same change, on top of Ben's Comfy-Org/comfy-website#19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants