Repository navigation
[backport core/1.58] fix(agent): open the / skill picker when ComfyUI hosts the agent (BE-22010) - #21580
Conversation
PostHog only initializes on Cloud, so the skill catalog gate never turned on for a panel served by ComfyUI's agent feature and typing / did nothing. A ready local agent now enables the catalog; a 404 from its routes still hides the surface.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-21T20:52:09.868Z",
"gitSha": "1b28a16dad2f6fe2d77b707639e4da2c8af108aa",
"branch": "skishore23/be-22010-slash-skill-picker-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.3500000000172,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.762,
"layouts": 10,
"layoutDurationMs": 2.748,
"taskDurationMs": 483.34499999999997,
"heapDeltaBytes": 4433396,
"heapUsedBytes": 102622900,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.705,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2032.6430000000073,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.334,
"layouts": 8,
"layoutDurationMs": 2.2899999999999996,
"taskDurationMs": 520.5300000000001,
"heapDeltaBytes": 372076,
"heapUsedBytes": 88799440,
"domNodes": -200,
"jsHeapTotalBytes": -2977792,
"scriptDurationMs": 10.890000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.8749999999832,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.317,
"layouts": 10,
"layoutDurationMs": 2.306,
"taskDurationMs": 689.3539999999999,
"heapDeltaBytes": -8535444,
"heapUsedBytes": 90922304,
"domNodes": -200,
"jsHeapTotalBytes": 6983680,
"scriptDurationMs": 127.92899999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.7879999999932,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.123,
"layouts": 10,
"layoutDurationMs": 2.48,
"taskDurationMs": 687.519,
"heapDeltaBytes": -9322044,
"heapUsedBytes": 89953676,
"domNodes": -200,
"jsHeapTotalBytes": 7507968,
"scriptDurationMs": 125.96000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.8420000000137,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.970000000000001,
"layouts": 13,
"layoutDurationMs": 3.3400000000000003,
"taskDurationMs": 267.295,
"heapDeltaBytes": 1834752,
"heapUsedBytes": 106087676,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.549999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.0470000000087,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.714,
"layouts": 12,
"layoutDurationMs": 3.198,
"taskDurationMs": 364.28,
"heapDeltaBytes": 21566004,
"heapUsedBytes": 109615804,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.865,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 557.6159999999959,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.936,
"layouts": 10,
"layoutDurationMs": 2.4419999999999997,
"taskDurationMs": 373.32699999999994,
"heapDeltaBytes": 7941208,
"heapUsedBytes": 114338144,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 136.403,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696968,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 567.9230000000075,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7110000000000007,
"layouts": 9,
"layoutDurationMs": 2.257,
"taskDurationMs": 426.55299999999994,
"heapDeltaBytes": 3672184,
"heapUsedBytes": 95150484,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 140.9,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1053.7369999999555,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 741.853,
"heapDeltaBytes": -11142568,
"heapUsedBytes": 102051740,
"domNodes": -210,
"jsHeapTotalBytes": 9416704,
"scriptDurationMs": 47.135,
"eventListeners": -168,
"totalBlockingTimeMs": 387,
"frameDurationMs": 29.166666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1078.3869999999638,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 770.448,
"heapDeltaBytes": -8929620,
"heapUsedBytes": 102030580,
"domNodes": -210,
"jsHeapTotalBytes": 10661888,
"scriptDurationMs": 50.496000000000016,
"eventListeners": -168,
"totalBlockingTimeMs": 408,
"frameDurationMs": 30.091666666666647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 780.9819999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.3000000000003,
"heapDeltaBytes": -4048768,
"heapUsedBytes": 97645184,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.16299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 157,
"frameDurationMs": 23.038235294117626,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.9430000000125,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.7719999999998,
"heapDeltaBytes": -4321304,
"heapUsedBytes": 90674096,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 123.757,
"eventListeners": 0,
"totalBlockingTimeMs": 165,
"frameDurationMs": 23.035294117647055,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7856.831,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2829999999999994,
"layouts": 1,
"layoutDurationMs": 0.24200000000000002,
"taskDurationMs": 6976.587,
"heapDeltaBytes": -1533688,
"heapUsedBytes": 119735964,
"domNodes": -277,
"jsHeapTotalBytes": 9080832,
"scriptDurationMs": 5757.438,
"eventListeners": -130,
"totalBlockingTimeMs": 163,
"frameDurationMs": 25.906600660066008,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7633.668999999998,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5320000000000004,
"layouts": 2,
"layoutDurationMs": 0.451,
"taskDurationMs": 6756.109,
"heapDeltaBytes": -2995288,
"heapUsedBytes": 121413584,
"domNodes": -277,
"jsHeapTotalBytes": 24875008,
"scriptDurationMs": 5170.977,
"eventListeners": -130,
"totalBlockingTimeMs": 73,
"frameDurationMs": 23.70527950310559,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7361.3,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6550000000000002,
"layouts": 2,
"layoutDurationMs": 0.5009999999999997,
"taskDurationMs": 6590.1630000000005,
"heapDeltaBytes": 14916448,
"heapUsedBytes": 135806068,
"domNodes": -276,
"jsHeapTotalBytes": 27168768,
"scriptDurationMs": 5044.131,
"eventListeners": -126,
"totalBlockingTimeMs": 111,
"frameDurationMs": 24.554333333333332,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7318.036000000006,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7400000000000002,
"layouts": 2,
"layoutDurationMs": 0.5049999999999998,
"taskDurationMs": 6451.885,
"heapDeltaBytes": 24780928,
"heapUsedBytes": 146705684,
"domNodes": -276,
"jsHeapTotalBytes": 25595904,
"scriptDurationMs": 5185.5650000000005,
"eventListeners": -126,
"totalBlockingTimeMs": 96,
"frameDurationMs": 24.63434343434343,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 171.21300000002293,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.84,
"layouts": 12,
"layoutDurationMs": 3.285,
"taskDurationMs": 122.03600000000003,
"heapDeltaBytes": 13266300,
"heapUsedBytes": 118162188,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.24,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.850000000000023,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 163.05599999998321,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.221,
"layouts": 10,
"layoutDurationMs": 2.412,
"taskDurationMs": 126.45500000000004,
"heapDeltaBytes": 13312960,
"heapUsedBytes": 117863200,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.646000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.366666666666635,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2022.9180000000042,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6519999999999997,
"layouts": 8,
"layoutDurationMs": 2.248,
"taskDurationMs": 619.2289999999999,
"heapDeltaBytes": -13599412,
"heapUsedBytes": 90062636,
"domNodes": -276,
"jsHeapTotalBytes": -2347008,
"scriptDurationMs": 31.621000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2024.5919999999842,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.359,
"layouts": 8,
"layoutDurationMs": 2.0879999999999996,
"taskDurationMs": 460.7150000000001,
"heapDeltaBytes": 10521032,
"heapUsedBytes": 112228272,
"domNodes": -276,
"jsHeapTotalBytes": -5599232,
"scriptDurationMs": 31.771000000000008,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2816.8779999999742,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.198000000000002,
"layouts": 7,
"layoutDurationMs": 1.709,
"taskDurationMs": 1457.758,
"heapDeltaBytes": 1068488,
"heapUsedBytes": 104156288,
"domNodes": -296,
"jsHeapTotalBytes": -1179648,
"scriptDurationMs": 666.237,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568047337278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2731.060999999954,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.889,
"layouts": 6,
"layoutDurationMs": 1.4020000000000001,
"taskDurationMs": 1481.146,
"heapDeltaBytes": 1883124,
"heapUsedBytes": 105281668,
"domNodes": -282,
"jsHeapTotalBytes": -1179648,
"scriptDurationMs": 694.0889999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.768098159509204,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3255.6900000000155,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.325999999999999,
"layouts": 65,
"layoutDurationMs": 10.798,
"taskDurationMs": 1374.1570000000002,
"heapDeltaBytes": -8363392,
"heapUsedBytes": 96620216,
"domNodes": -272,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 654.237,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3731.2019999999393,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.071,
"layouts": 66,
"layoutDurationMs": 10.502,
"taskDurationMs": 1548.398,
"heapDeltaBytes": -3868488,
"heapUsedBytes": 101311640,
"domNodes": -252,
"jsHeapTotalBytes": -487424,
"scriptDurationMs": 670.0260000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.741255605381166,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2846.2000000000103,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.683,
"layouts": 5,
"layoutDurationMs": 1.3590000000000004,
"taskDurationMs": 1718.6490000000001,
"heapDeltaBytes": 16824012,
"heapUsedBytes": 119723260,
"domNodes": 0,
"jsHeapTotalBytes": 3567616,
"scriptDurationMs": 828.081,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.864285714285714,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2878.4220000000005,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.5360000000000005,
"layouts": 5,
"layoutDurationMs": 1.3220000000000003,
"taskDurationMs": 1708.215,
"heapDeltaBytes": 20517660,
"heapUsedBytes": 126843364,
"domNodes": 0,
"jsHeapTotalBytes": 6189056,
"scriptDurationMs": 840.795,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.7509999999907,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.589,
"layouts": 9,
"layoutDurationMs": 2.3449999999999998,
"taskDurationMs": 428.152,
"heapDeltaBytes": 8595508,
"heapUsedBytes": 111880972,
"domNodes": -276,
"jsHeapTotalBytes": -5337088,
"scriptDurationMs": 32.63999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.4079999999803,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.534,
"layouts": 8,
"layoutDurationMs": 2.3040000000000003,
"taskDurationMs": 482.4830000000001,
"heapDeltaBytes": 4845888,
"heapUsedBytes": 108153500,
"domNodes": -296,
"jsHeapTotalBytes": -5861376,
"scriptDurationMs": 35.963,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.9260000000027,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.555999999999999,
"layouts": 11,
"layoutDurationMs": 3.1009999999999995,
"taskDurationMs": 333.38800000000003,
"heapDeltaBytes": 3131000,
"heapUsedBytes": 109386472,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 126.941,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.2750000000096,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.366,
"layouts": 10,
"layoutDurationMs": 2.591,
"taskDurationMs": 387.80899999999997,
"heapDeltaBytes": 2720280,
"heapUsedBytes": 108511448,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 122.389,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2026.8649999999866,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3,
"layouts": 10,
"layoutDurationMs": 2.6719999999999997,
"taskDurationMs": 390.326,
"heapDeltaBytes": -12257536,
"heapUsedBytes": 79873428,
"domNodes": -198,
"jsHeapTotalBytes": 1806336,
"scriptDurationMs": 9.368000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2027.1170000000893,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6899999999999995,
"layouts": 10,
"layoutDurationMs": 2.386,
"taskDurationMs": 400.543,
"heapDeltaBytes": -7304612,
"heapUsedBytes": 98558532,
"domNodes": -198,
"jsHeapTotalBytes": 2789376,
"scriptDurationMs": 10.082,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.2089999999966,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.514,
"layouts": 9,
"layoutDurationMs": 2.03,
"taskDurationMs": 772.935,
"heapDeltaBytes": -12500952,
"heapUsedBytes": 88377484,
"domNodes": -210,
"jsHeapTotalBytes": 7770112,
"scriptDurationMs": 95.998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.857999999983,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.542000000000002,
"layouts": 10,
"layoutDurationMs": 2.4200000000000004,
"taskDurationMs": 662.853,
"heapDeltaBytes": -637756,
"heapUsedBytes": 90239688,
"domNodes": -211,
"jsHeapTotalBytes": -1929216,
"scriptDurationMs": 100.52000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 933.6470000000077,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.604,
"layouts": 5,
"layoutDurationMs": 12.023,
"taskDurationMs": 669.599,
"heapDeltaBytes": 7142624,
"heapUsedBytes": 124763532,
"domNodes": 16030,
"jsHeapTotalBytes": 18751488,
"scriptDurationMs": 22.529999999999994,
"eventListeners": 3244,
"totalBlockingTimeMs": 109,
"frameDurationMs": 19.85744680851064,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 11558.907000000034,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.086000000000006,
"layouts": 8,
"layoutDurationMs": 2.1229999999999998,
"taskDurationMs": 5439.352000000001,
"heapDeltaBytes": -23285972,
"heapUsedBytes": 88600212,
"domNodes": -296,
"jsHeapTotalBytes": -1036288,
"scriptDurationMs": 2378.441,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599423631124,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8294.342999999913,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.739999999999995,
"layouts": 8,
"layoutDurationMs": 2.024,
"taskDurationMs": 4416.3859999999995,
"heapDeltaBytes": -438764,
"heapUsedBytes": 103275076,
"domNodes": -296,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 2205.841,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665995975855132,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14324.580999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13600.872000000001,
"heapDeltaBytes": -47499376,
"heapUsedBytes": 277205696,
"domNodes": -3344,
"jsHeapTotalBytes": 28299264,
"scriptDurationMs": 197.546,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.29363957597173,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 19979.79799999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19158.071,
"heapDeltaBytes": -49877892,
"heapUsedBytes": 284796828,
"domNodes": -3344,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 271.505,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.683035714285715,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 23355.26199999998,
"styleRecalcs": 176,
"styleRecalcDurationMs": 20.742999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23015.737,
"heapDeltaBytes": -29668172,
"heapUsedBytes": 294537276,
"domNodes": -3344,
"jsHeapTotalBytes": 18862080,
"scriptDurationMs": 798.381,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 43.92048872180451,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 24354.22899999992,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.07799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23995.971,
"heapDeltaBytes": -30628580,
"heapUsedBytes": 298740120,
"domNodes": -3344,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 783.125,
"eventListeners": -651,
"totalBlockingTimeMs": 5,
"frameDurationMs": 46.82519230769231,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7163.980999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.499,
"layouts": 20,
"layoutDurationMs": 27.203999999999994,
"taskDurationMs": 6984.873,
"heapDeltaBytes": -54784860,
"heapUsedBytes": 270211296,
"domNodes": -3344,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 103.437,
"eventListeners": -655,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.855428571428575,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7133.135000000038,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.13300000000001,
"layouts": 20,
"layoutDurationMs": 23.475999999999996,
"taskDurationMs": 7033.663,
"heapDeltaBytes": -8908468,
"heapUsedBytes": 303647892,
"domNodes": -3344,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 109.03000000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.713173652694614,
"p95FrameDurationMs": 83.40000000000055
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9769.58400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9417.984999999999,
"heapDeltaBytes": -4243472,
"heapUsedBytes": 295148380,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.00900000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.44528985507247,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7217.665000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6852.987000000003,
"heapDeltaBytes": 18832812,
"heapUsedBytes": 313662304,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.35799999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.629351535836175,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 464.63799999997946,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.106999999999998,
"layouts": 12,
"layoutDurationMs": 5.74,
"taskDurationMs": 142.207,
"heapDeltaBytes": -12465024,
"heapUsedBytes": 89371056,
"domNodes": 126,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.473999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 120.78399999995781,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.05,
"layouts": 7,
"layoutDurationMs": 2.522,
"taskDurationMs": 84.502,
"heapDeltaBytes": -10563120,
"heapUsedBytes": 91007788,
"domNodes": 116,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 4.680999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 300.8140000000594,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.624,
"layouts": 76,
"layoutDurationMs": 12.219000000000001,
"taskDurationMs": 266.864,
"heapDeltaBytes": 10555508,
"heapUsedBytes": 97836712,
"domNodes": 4,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 124.06200000000001,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661111111111115,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 290.1950000000397,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.648,
"layouts": 76,
"layoutDurationMs": 11.508,
"taskDurationMs": 247.828,
"heapDeltaBytes": 10311904,
"heapUsedBytes": 99244944,
"domNodes": 4,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 113.795,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 344.07499999997526,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4809999999999999,
"layouts": 76,
"layoutDurationMs": 11.011999999999999,
"taskDurationMs": 301.90700000000004,
"heapDeltaBytes": -1147612,
"heapUsedBytes": 115616148,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.53200000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 327.8619999999819,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.0370000000000004,
"layouts": 76,
"layoutDurationMs": 10.112,
"taskDurationMs": 296.107,
"heapDeltaBytes": -6138884,
"heapUsedBytes": 109191652,
"domNodes": 4,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 102.25099999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 63.9% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2948 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 48e89b076464581878268f55a73f30dde6650714
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (114)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #21580 +/- ##
=============================================
- Coverage 86.16% 86.15% -0.01%
=============================================
Files 2786 2786
Lines 154598 154602 +4
Branches 39185 39187 +2
=============================================
- Hits 133210 133204 -6
- Misses 20998 21008 +10
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
…22241) ## Summary The backport bot skips a release branch once its own backport PR merged (Comfy-Org#21994). A backport someone made by hand, from a branch the bot did not create, was not seen, so the bot retried that branch. This counts a merged PR to the target as done when: - its title starts with `[backport <target>]` or `[<target>]`, and - it is not a revert and not the bot's backport of another PR (`backport-<M>-to-*`), and - it says it carries the source PR: the title ends with `(#N)`, the head branch has `N` next to `backport` (`backport-N...`, `.../N-backport...`), or a body line starts with `Backport of #N` / `Backport of https://github.com/Comfy-Org/ComfyUI_frontend/pull/N`, and - it is not from a fork. A body or title that only mentions the PR ("Not included: #N", "follow-up to the backport of #N", a PR in another repo) does not count, and neither does a ticket number in a branch name (`be-22010-...` is not FE PR 22010). A false match would skip a needed backport and drop `needs-backport`, so the rule leans toward missing a hand-made backport (old behaviour: retry) over a false skip. Candidates come from listing up to 300 merged PRs on the target (core/1.58 has 64 today), not the search API, so a PR named only in its branch is found and there is no index lag. The target name is compared case-insensitively. The run log shows it as `core/1.58 (merged PR Comfy-Org#21580, made by hand)`. `force_rerun` still retries everything. Fixes FRONT-3651 ## Testing - `scripts/cicd/pr-backport-filter.test.ts`: the match cases were red before the workflow change, and the three mention-only cases were red against the first, broader rule. 28/28 green now; each tightening was red against the commit before it. - Ran the query against real merged PRs. Correct matches: Comfy-Org#21579 to Comfy-Org#21580 and Comfy-Org#21694 to Comfy-Org#21799 (both made by hand, core/1.58), Comfy-Org#21708 to Comfy-Org#21798, Comfy-Org#21285 to Comfy-Org#22223, Comfy-Org#21686 to Comfy-Org#21782. Correctly no match: Comfy-Org#21841 on core/1.57 (Comfy-Org#22051 says "Not included: Comfy-Org#21841") and Comfy-Org#21532 on core/1.58 (Comfy-Org#22232 says it is not on that line), and Comfy-Org#22010 on core/1.58 (Comfy-Org#21580's branch `be-22010-...` is a ticket key). - The existing skip of bot backports was re-checked live: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40871266552 skipped all four targets of Comfy-Org#21829. ## Known limit A hand-made backport whose title has no target prefix, or that does not name the source PR, is still not detected. The bot then retries it as before, and the cherry-pick either conflicts or finds the commit already present.
Backport of #21579 to core/1.58 for PM-2243 (BE-22010).
Same change, but this branch's
useFeatureFlagshas noagentgetter. The store readsapi.getServerFeature('agent')instead, the same wayagentPanelStoredoes here, and the tests mockapi.getServerFeaturewith a ref.Testing
skillPacksStorecases (hosted agent enables without PostHog; agent that becomes ready later triggers the probe; hosted 404 hides). They fail without the store change and pass with it.src/platform/skills(74 tests) and the agent Composer, ConversationView, Settings and useAgentSession suites (736 tests) pass. Typecheck, oxlint, eslint and oxfmt pass on the touched files.--enable-agent, comfy-agent wheel from cloud main), a private ComfyUI served acore/1.58build. Browser: Playwright Chromium.ready, panel open, typing/opens no menu and the page never requests/api/agent/skills./requests/api/agent/skills(200) and opens the Skills menu, which lists a seeded pack. Clicking it, or ArrowDown then Enter, inserts the/pastel-palettereference.load_skill(ok), and the reply used the pack body.