Repository navigation
[backport core/1.57] feat(deploy): open installation deployment from the run bar (#21202) - #21567
Conversation
…1351 Carries only the deploy-to-cloud declarations that #21351 generated from cloud@c5d79c08: DeployToCloudError, the CreateDeployBundle* and GetDeploySummary* types, their zod schemas, and the deploy_to_cloud feature flag on GetFeaturesResponse. #21202 imports these, so its backport to core/1.57 cannot compile without them. The automatic backport of #21351 conflicted because main had several earlier type regenerations (billing, usage, agent) that core/1.57 never received. Those hunks are left out. Each carried declaration is byte-identical to main. (partially cherry picked from commit 26fe421)
…the run bar (#21202) One conflict in DeployToComfyApiCard.vue: core/1.57 still passes titleId to the card (#21139 removed it on main), and #21202 adds the deploysInstallation prop. Kept both. The changed lines are identical to the source commit. Needs the deploy-to-cloud Ingest API types, carried by the commit below it (#21565). (cherry picked from commit a53d341)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-21T18:42:53.826Z",
"gitSha": "e6f6f707116c95ff3a323f4cc2644d6f31c21f8b",
"branch": "backport-21202-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.041999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.732000000000001,
"layouts": 9,
"layoutDurationMs": 3.5749999999999997,
"taskDurationMs": 629.6149999999999,
"heapDeltaBytes": -891860,
"heapUsedBytes": 74081232,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 14.928,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2023.0750000000626,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.903,
"layouts": 10,
"layoutDurationMs": 3.517,
"taskDurationMs": 589.7610000000001,
"heapDeltaBytes": -806176,
"heapUsedBytes": 73731896,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 14.041999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1913.342,
"styleRecalcs": 81,
"styleRecalcDurationMs": 18.903,
"layouts": 8,
"layoutDurationMs": 2.613,
"taskDurationMs": 988.3309999999999,
"heapDeltaBytes": 15628468,
"heapUsedBytes": 81041216,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 186.618,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608695652174,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2014.4530000000032,
"styleRecalcs": 84,
"styleRecalcDurationMs": 19.447,
"layouts": 10,
"layoutDurationMs": 3.1489999999999996,
"taskDurationMs": 1136.118,
"heapDeltaBytes": -8221628,
"heapUsedBytes": 66862640,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 180.21900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.246000000051,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.446,
"layouts": 11,
"layoutDurationMs": 3.7560000000000002,
"taskDurationMs": 394.41099999999994,
"heapDeltaBytes": 18725560,
"heapUsedBytes": 84691232,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 19.974,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.9800000000068,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.507000000000001,
"layouts": 11,
"layoutDurationMs": 3.2860000000000005,
"taskDurationMs": 426.235,
"heapDeltaBytes": -5005832,
"heapUsedBytes": 70381296,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 14.072999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 684.8099999999704,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.7869999999999995,
"layouts": 9,
"layoutDurationMs": 3.034,
"taskDurationMs": 494.01700000000005,
"heapDeltaBytes": 26427656,
"heapUsedBytes": 91813812,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 185.51800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 760.8099999999922,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0100000000000007,
"layouts": 8,
"layoutDurationMs": 2.309,
"taskDurationMs": 535.184,
"heapDeltaBytes": 3943876,
"heapUsedBytes": 79210084,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 177.97299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.04318181818182,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1274.3040000000292,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 974.9920000000001,
"heapDeltaBytes": -11859652,
"heapUsedBytes": 80771264,
"domNodes": -192,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 85.414,
"eventListeners": -106,
"totalBlockingTimeMs": 575,
"frameDurationMs": 34.229729729729726,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1357.3829999999134,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1039.8780000000002,
"heapDeltaBytes": -208336,
"heapUsedBytes": 81141628,
"domNodes": -192,
"jsHeapTotalBytes": 16523264,
"scriptDurationMs": 100.48700000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 651,
"frameDurationMs": 35.52368421052633,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 871.4860000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.4300000000001,
"heapDeltaBytes": -4587172,
"heapUsedBytes": 76318452,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.82399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 853.8369999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.42099999999965,
"heapDeltaBytes": -4785576,
"heapUsedBytes": 75979476,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 161.26299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 214,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11660.836000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10677.248000000001,
"heapDeltaBytes": -8350416,
"heapUsedBytes": 87837260,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 8586.125,
"eventListeners": -68,
"totalBlockingTimeMs": 1501,
"frameDurationMs": 31.53027027027028,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10975.784999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10146.673999999999,
"heapDeltaBytes": 401052,
"heapUsedBytes": 87441928,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 8203.265,
"eventListeners": -68,
"totalBlockingTimeMs": 1347,
"frameDurationMs": 31.242735042735045,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11661.970000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10796.496,
"heapDeltaBytes": -14914168,
"heapUsedBytes": 73064644,
"domNodes": -278,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 8757.422,
"eventListeners": -68,
"totalBlockingTimeMs": 1490,
"frameDurationMs": 31.70163043478261,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11484.462000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10601.679,
"heapDeltaBytes": -27479464,
"heapUsedBytes": 72332104,
"domNodes": -258,
"jsHeapTotalBytes": 12709888,
"scriptDurationMs": 8633.008,
"eventListeners": -68,
"totalBlockingTimeMs": 1748,
"frameDurationMs": 32.299436619718314,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 238.3710000000292,
"styleRecalcs": 23,
"styleRecalcDurationMs": 20.409,
"layouts": 11,
"layoutDurationMs": 3.9770000000000003,
"taskDurationMs": 189.186,
"heapDeltaBytes": -7577176,
"heapUsedBytes": 79919568,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.035,
"eventListeners": 195,
"totalBlockingTimeMs": 5,
"frameDurationMs": 25.009999999999945,
"p95FrameDurationMs": 99.90000000000055
},
{
"name": "large-combo-open",
"durationMs": 236.96000000006734,
"styleRecalcs": 24,
"styleRecalcDurationMs": 18.377,
"layouts": 11,
"layoutDurationMs": 4.0440000000000005,
"taskDurationMs": 186.99399999999997,
"heapDeltaBytes": -8093372,
"heapUsedBytes": 79150520,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.881999999999998,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.727272727272727,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2063.201000000049,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.371,
"layouts": 6,
"layoutDurationMs": 2.1479999999999997,
"taskDurationMs": 800.8929999999999,
"heapDeltaBytes": -17222952,
"heapUsedBytes": 79963096,
"domNodes": -258,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 45.053,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2054.8749999999245,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.934,
"layouts": 8,
"layoutDurationMs": 2.483,
"taskDurationMs": 736.151,
"heapDeltaBytes": -17514880,
"heapUsedBytes": 79456244,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 43.95,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3108.2759999999325,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.041,
"layouts": 5,
"layoutDurationMs": 1.6320000000000001,
"taskDurationMs": 1980.824,
"heapDeltaBytes": -11568012,
"heapUsedBytes": 68162744,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 945.1239999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.845945945945946,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2818.62000000001,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.386999999999999,
"layouts": 7,
"layoutDurationMs": 2.3259999999999996,
"taskDurationMs": 1882.371,
"heapDeltaBytes": -11192480,
"heapUsedBytes": 68744876,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 901.792,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568047337278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4160.798999999997,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.610999999999999,
"layouts": 64,
"layoutDurationMs": 13.023,
"taskDurationMs": 2080.2189999999996,
"heapDeltaBytes": -27130716,
"heapUsedBytes": 72285348,
"domNodes": -234,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 918.115,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586345381526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3703.9160000000493,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.595,
"layouts": 64,
"layoutDurationMs": 12.454999999999998,
"taskDurationMs": 1763.2060000000001,
"heapDeltaBytes": -5873900,
"heapUsedBytes": 75882892,
"domNodes": -234,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 860.074,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.741176470588233,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3392.932999999971,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.28,
"layouts": 4,
"layoutDurationMs": 1.409,
"taskDurationMs": 2285.5820000000003,
"heapDeltaBytes": 17028376,
"heapUsedBytes": 100431940,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 1111.2340000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.914925373134327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3214.0360000000783,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.091000000000001,
"layouts": 4,
"layoutDurationMs": 1.3160000000000003,
"taskDurationMs": 2151.57,
"heapDeltaBytes": -450316,
"heapUsedBytes": 77962784,
"domNodes": 0,
"jsHeapTotalBytes": 6643712,
"scriptDurationMs": 1060.617,
"eventListeners": 182,
"totalBlockingTimeMs": 29,
"frameDurationMs": 16.927748691099474,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.5380000000168,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.5119999999999996,
"layouts": 6,
"layoutDurationMs": 2.183,
"taskDurationMs": 763.06,
"heapDeltaBytes": -22691140,
"heapUsedBytes": 75808728,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 45.307,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2072.6600000000417,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4519999999999995,
"layouts": 7,
"layoutDurationMs": 2.451,
"taskDurationMs": 695.1429999999999,
"heapDeltaBytes": -26506808,
"heapUsedBytes": 72236916,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 38.231,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 709.9699999999984,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.306000000000001,
"layouts": 9,
"layoutDurationMs": 3.1590000000000003,
"taskDurationMs": 483.11899999999997,
"heapDeltaBytes": 21606832,
"heapUsedBytes": 88890140,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 165.153,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669047619047628,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 646.109000000024,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.130999999999999,
"layouts": 11,
"layoutDurationMs": 3.4009999999999994,
"taskDurationMs": 462.8070000000001,
"heapDeltaBytes": 3277544,
"heapUsedBytes": 80141664,
"domNodes": 0,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 151.324,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.584999999949,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.4999999999999996,
"layouts": 8,
"layoutDurationMs": 3.0719999999999996,
"taskDurationMs": 480.2989999999999,
"heapDeltaBytes": 22412436,
"heapUsedBytes": 89653012,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 14.769999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.7600000000248,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2729999999999997,
"layouts": 9,
"layoutDurationMs": 2.9370000000000003,
"taskDurationMs": 571.516,
"heapDeltaBytes": -206488,
"heapUsedBytes": 77162616,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.568,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2006.136999999967,
"styleRecalcs": 86,
"styleRecalcDurationMs": 20.704,
"layouts": 7,
"layoutDurationMs": 2.351,
"taskDurationMs": 1191.942,
"heapDeltaBytes": 11178084,
"heapUsedBytes": 78498952,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 137.56799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1872.9289999999992,
"styleRecalcs": 82,
"styleRecalcDurationMs": 18.397,
"layouts": 9,
"layoutDurationMs": 3.0610000000000004,
"taskDurationMs": 868.6769999999999,
"heapDeltaBytes": 11709132,
"heapUsedBytes": 78741700,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 123.39500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571424,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1484.2800000000125,
"styleRecalcs": 16,
"styleRecalcDurationMs": 31.567000000000004,
"layouts": 5,
"layoutDurationMs": 17.787999999999997,
"taskDurationMs": 1012.9859999999998,
"heapDeltaBytes": 7122580,
"heapUsedBytes": 100542368,
"domNodes": 15953,
"jsHeapTotalBytes": 17698816,
"scriptDurationMs": 38.391999999999996,
"eventListeners": 3244,
"totalBlockingTimeMs": 189,
"frameDurationMs": 20.83194444444444,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8504.281999999988,
"styleRecalcs": 248,
"styleRecalcDurationMs": 25.103,
"layouts": 6,
"layoutDurationMs": 1.9099999999999997,
"taskDurationMs": 5923.068000000001,
"heapDeltaBytes": 3756976,
"heapUsedBytes": 82544536,
"domNodes": -258,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 2980.851,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.731692913385828,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10685.856999999942,
"styleRecalcs": 250,
"styleRecalcDurationMs": 24.177000000000003,
"layouts": 7,
"layoutDurationMs": 2.194,
"taskDurationMs": 6574.6900000000005,
"heapDeltaBytes": -13460332,
"heapUsedBytes": 84470836,
"domNodes": -278,
"jsHeapTotalBytes": 6647808,
"scriptDurationMs": 2985.6429999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.692175273865413,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18896.41300000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18143.32,
"heapDeltaBytes": -11550796,
"heapUsedBytes": 284643300,
"domNodes": -3330,
"jsHeapTotalBytes": 18604032,
"scriptDurationMs": 345.906,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.95392670157068,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 25064.83700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24392.745000000003,
"heapDeltaBytes": 3044664,
"heapUsedBytes": 280019600,
"domNodes": -3330,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 393.559,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.29136442141623,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 30583.766000000083,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.62600000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 30326.791000000005,
"heapDeltaBytes": -19250204,
"heapUsedBytes": 263304508,
"domNodes": -3334,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 993.676,
"eventListeners": -651,
"totalBlockingTimeMs": 27,
"frameDurationMs": 58.58639846743294,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 21448.766999999974,
"styleRecalcs": 156,
"styleRecalcDurationMs": 16.985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21073.528000000002,
"heapDeltaBytes": -17381124,
"heapUsedBytes": 278108564,
"domNodes": -3330,
"jsHeapTotalBytes": 21745664,
"scriptDurationMs": 988.0759999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 72,
"frameDurationMs": 39.09981785063752,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 9119.07000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.899,
"layouts": 20,
"layoutDurationMs": 26.058999999999983,
"taskDurationMs": 8976.435,
"heapDeltaBytes": -8451952,
"heapUsedBytes": 273149624,
"domNodes": -3330,
"jsHeapTotalBytes": 4706304,
"scriptDurationMs": 169.44400000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 54.26428571428571,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8817.101999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.27999999999999,
"layouts": 20,
"layoutDurationMs": 24.179000000000006,
"taskDurationMs": 8648.965,
"heapDeltaBytes": -30810824,
"heapUsedBytes": 265444416,
"domNodes": -3330,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 135.569,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.9606936416185,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12570.321000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12340.053999999998,
"heapDeltaBytes": 749984,
"heapUsedBytes": 241476628,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 189.35100000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.98028673835125,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12511.348999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12024.594000000001,
"heapDeltaBytes": 18754800,
"heapUsedBytes": 283623600,
"domNodes": 0,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 189.585,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.560992907801435,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "workflow-execution",
"durationMs": 536.7119999999659,
"styleRecalcs": 24,
"styleRecalcDurationMs": 21.12,
"layouts": 13,
"layoutDurationMs": 7.357999999999999,
"taskDurationMs": 184.74399999999997,
"heapDeltaBytes": 7035448,
"heapUsedBytes": 79252436,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 15.880999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 135.89899999999489,
"styleRecalcs": 11,
"styleRecalcDurationMs": 13.224,
"layouts": 9,
"layoutDurationMs": 3.941,
"taskDurationMs": 104.64899999999999,
"heapDeltaBytes": -15437344,
"heapUsedBytes": 68504064,
"domNodes": 120,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.923000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 573.1980000000476,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.274,
"layouts": 76,
"layoutDurationMs": 17.589000000000002,
"taskDurationMs": 515.077,
"heapDeltaBytes": -13157684,
"heapUsedBytes": 82825896,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 245.803,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 639.8330000001806,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9940000000000001,
"layouts": 76,
"layoutDurationMs": 17.334,
"taskDurationMs": 578.989,
"heapDeltaBytes": 13202588,
"heapUsedBytes": 86340500,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 284.339,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 615.7780000000912,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.193,
"layouts": 76,
"layoutDurationMs": 16.979000000000003,
"taskDurationMs": 581.308,
"heapDeltaBytes": 774764,
"heapUsedBytes": 132149752,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 235.05,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 794.7159999998803,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.614,
"layouts": 76,
"layoutDurationMs": 18.301000000000002,
"taskDurationMs": 754.2059999999999,
"heapDeltaBytes": 2438440,
"heapUsedBytes": 121337524,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 319.809,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.012500000000006,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2280 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a5165a4f3d7341510213354f8d8d7ea7fcfb9395
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.57 #21567 +/- ##
=============================================
- Coverage 85.80% 85.23% -0.58%
=============================================
Files 2701 3757 +1056
Lines 151826 180188 +28362
Branches 38425 48611 +10186
=============================================
+ Hits 130277 153586 +23309
- Misses 21161 24586 +3425
- Partials 388 2016 +1628
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1065 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec00922e18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| const emit = defineEmits<{ opened: [] }>() | ||
|
|
||
| const { state, deploy } = useInstallationDeploy() |
There was a problem hiding this comment.
Preserve an in-flight bundle when the dialog closes
If the user dismisses this dialog while the upload is running, this component and its composable-local state are destroyed, but the request has no cancellation path and can still create a server-side bundle. The resulting wizard URL is then written only to the discarded ref, so reopening the dialog starts another upload while the inaccessible bundle continues consuming one of the limited unexpired-bundle slots. Keep the upload state in an owner that survives dialog unmounting, or cancel/recover the in-flight operation when the dialog closes.
Useful? React with 👍 / 👎.
|
@thedatalife requesting your review here. This needs to merge before the 1.57.2 bump (#21560), so the deploy button ships in this patch. The changed lines are identical to #21202's merge commit, apart from one conflict where both props are kept (details in the description). Required checks pass. The failing |
|
The only failure was website-e2e, a timing test for the comfy.org website’s model pages, which this change doesn’t touch. |
|
🔗 Commit SHA: ec00922 | Docs | View more details | Give us feedback! |
There was a problem hiding this comment.
Verdict: Faithful backport of #21202 to core/1.57, with the Ingest types it needs and one conflict resolved correctly.
I compared the cherry-pick commit against the merged source commit a53d341 from #21202. All 14 files add and remove exactly the source's lines, and the new tests (useInstallationDeploy.test.ts, plus the additions to DeployToComfyApiCard.test.ts and TopMenuSection.test.ts) come over unchanged.
Adaptations:
- The first commit adds the deploy-to-cloud Ingest API types (
CreateDeployBundle*,GetDeploySummary*,DeployToCloudError, and their zod schemas). It accounts for #21351 (merged as 26fe421) not being on core/1.57. Every line it adds toindex.ts,types.gen.ts, andzod.gen.tsappears in #21351's diff, and it leaves out #21351's unrelated Agent type changes. Its tree matches #21565's head, so whichever merges first makes that commit drop out of the other. - In
DeployToComfyApiCard.vue, the props keeptitleIdalongside the newdeploysInstallation. core/1.57 still binds:id="titleId"anduseDeployToComfyApiDialogstill passes it, because #21139 removed it only on main. The changed lines themselves match the source.
CI on this head passes lint, typecheck, unit, fallow, preflight, e2e-status, and the re-run website-e2e. Locally, with core/1.57's own dependencies installed, src/platform/workflow/deploy and TopMenuSection.test.ts pass: 135 tests across 6 files.
Summary
Backport of #21202 to
core/1.57, the frontend line ComfyUI currently pins (comfyui-frontend-package==1.57.1). The run-bar rocket renders only when the local server sendsdeploy_to_cloud, so it stays hidden until core ships Comfy-Org/ComfyUI#17203.Two commits:
cherry-pick -xof a53d341. One conflict inDeployToComfyApiCard.vue:core/1.57still passestitleIdto the card (fix: name every headless dialog by a DialogTitle #21139 removed it onmain), and feat(deploy): open installation deployment from the run bar #21202 addsdeploysInstallation. Kept both. The changed lines are identical to the source commit.The bot's backport failed on that conflict, and would not have compiled without the types.
Verification
pnpm test:unit src/platform/workflow/deploy src/components/TopMenuSection.test.ts --retry=0on this branch: 135 tests passed across 6 files.core/1.57: oxfmt, oxlint, eslint, server-facts lint,typecheck:apppassed. Pre-push knip and fallow audit passed.mainchange on 2026-10-21, against Core feat(website): add Explore Builds CTA to managed-builds compare table #17203's branch with--comfy-api-base https://stagingapi.comfy.org, on an install with one custom node pack and one model. The rocket was hidden before a headless prompt and shown after reload. The upload returned a valid bundle, and following the link closed the dialog. The staging build wizard opened with the snapshot, ComfyUI v0.42.0, 1 node pack, 70 pinned packages and 2 workflow models preselected.