Repository navigation
test(agent): name the restored-thread fixture for the targetless state it provides - #21501
christian-byrne wants to merge 19 commits into
Conversation
Addresses review feedback: #18426 (comment)
Addresses review feedback: #18426 (comment)
Addresses review feedback: #18426 (comment)
`role="note"` is no longer unique inside the panel: `FreeUseNotice` landed on main with the same role, and its placement is experiment-gated, so counting every note made the before-focus assertion pass or fail on that flag rather than on the deferral. Filter by the notice's own copy instead, read from the locale file so a reword cannot strand the test, and assert the post-focus count rather than a hard-coded sentence fragment.
…le state The black-box case this replaces could never pass. It asserted that the generic run notice appears after composer focus in a freshly-opened panel, but a fresh panel with a workflow open is always in `following` mode: `initializeTargetTracking` sets that mode when there is no thread, `selectedWorkflow` then resolves to the active workflow, and `targetNotice` returns `'following'`. `RunNoticeBanner` renders one element whose `<template v-if="context">` branch wins, so the generic copy is never rendered in that state. Measured in the cloud harness rather than inferred. The only note in the panel, before and after focus, is "Target workflow follows the visible tab...". Closing the only workflow tab does not reach the targetless state either: the workspace immediately opens a replacement tab, so there is always an active workflow. The targetless state is reachable only through thread-restoration paths (`beginWorkflowRestoration`, or the `setWorkflowTarget(null)` restore-failure arm). That makes this PR's first summary line the half that is observable here -- "keep workflow-binding notices immediate" -- so the case now asserts it: the binding notice is present and visible on open, the generic notice is absent, and engaging the composer does not displace the binding notice. Verified non-vacuous by mutation: making the generic notice win over the binding notice turns the case red. The deferral itself stays covered where the detached state is directly constructible, and both unit tests now take the window from the component instead of repeating 500/499, so the boundary assertion cannot drift from the product.
Addresses the carried round-two finding on AgentPanel.test.ts:508-511 (#18426 (review)): the 499/1 lower bound left with the banner-owned timer and did not come back, so a shorter delay passed. The post-focus advance is now split: 300 ms with the notice still absent, then 200 ms with it present. Measured mutation matrix on the component delay, both unit suites: 100 ms -> 1 failed (was passing) 250 ms -> 1 failed (was passing) 400 ms -> 36 passed (still not caught, see below) 5000 ms -> 2 failed 500 ms -> 36 passed A literal 499/1 split is not expressible in this repo: vite.config.mts:850 sets `fakeTimers: { shouldAdvanceTime: true }`, so the fake clock auto-advances ~20 ms per async flush. Measured directly - `advanceTimersByTimeAsync(0)` after the click moves Date.now() by 20 - which is why 499 + 1 fires the 500 ms timer one assertion early. 300/200 keeps ~180 ms of headroom below the boundary and ~40 ms above it, at the cost of not catching a 400 ms regression.
Moving the timer from the banner into AgentPanel dropped the test's lower bound: the case proved only "not synchronous, visible by 500ms", so delays of 100ms, 250ms and 400ms all passed, and removing the re-entry guard passed too because nothing refocused before the deadline. Drive a blur/refocus at 300ms and assert absent at 499ms, present at 500ms. That pins both the deadline and the fact that refocusing does not restart it. The 499/1 split needs a still clock -- vite.config.mts:850 sets fakeTimers.shouldAdvanceTime project-wide, which leaks ~20ms of fake clock per async flush -- so the case opts out with shouldAdvanceTime: false, the companion suggestion on line 487. This supersedes ed1ba14, which landed concurrently against the same finding. That commit split the post-focus advance 300/200 and concluded a literal 499/1 split was "not expressible in this repo". It is: opting out of shouldAdvanceTime is what makes it expressible, and with the clock pinned the boundary is stable. The 300/200 version caught 100ms and 250ms but, as its own message records, not 400ms -- and because it never refocuses, it did not catch a restart-on-refocus regression either. Also lifts the duplicated render block out of the two deadline cases into one mountTargetlessPanel helper; neither existing mount helper fits because both stub Composer, which these cases need in order to drive focus. Verified by mutation on this exact head: the case now fails for delays of 100, 250, 400 and 5000ms, for a mount-started timer, and for a restart on refocus, and passes on repeated clean runs. #18426 (comment) #18426 (comment) #18426 (comment)
runNoticeEngaged duplicated what the timer already knows: engaged means pending or ready. useTimeoutFn sets isPending on start() and clears it when the callback runs, and nothing calls stop() here, so guarding on pending-or-ready drops a ref without changing behaviour. Safe to make now rather than earlier because the boundary case in the previous commit pins the exact property this could break -- a refocus must not restart the deadline -- and that case fails if the guard is removed. #18426 (comment)
The absence check resolved in about 20ms, well inside the 500ms deadline, so the spec's own claim -- that the notice appears only after the user focuses the composer -- was not actually proven. Injecting a regression that revealed the notice on a timer with no focus at all left the spec green. Idle past the deadline before asserting absence. The spec now fails on that regression and passes clean on repeated runs. The unit suite owns the exact 499/500 boundary; this owns the user-visible claim. Two measurements worth recording, because both contradict a plausible fix. The review raised this as a restoration-ordering race; it is not. The panel is already targetless about 5ms after open(), so hydration was never what the absence check raced -- the deadline is. And page.clock cannot replace the wait: it can only be installed once the panel has mounted, so it does not advance a timer that a mount-time regression already started, and the spec silently goes green again. Also takes the after-focus capture at the same panel framing as the before-focus one so the two compare directly, and records why this spec borrows the performance fixture. #18426 (comment)
…otice AGENTS.md forbids code comments outside curt JSDoc on an exported API. Eight blocks added over this PR's last four commits break that, so they are gone and their content moved where the rule sends it: the refocus-no-restart claim into the unit test's `it` title, the two browser-spec premises into Playwright assertion messages, and the deferral-idle rationale into a `test.step` name. Everything else was narrating code that already says it. The fixed 1.5s real-time sleep in runNotice.spec.ts is replaced by `page.clock`, installed in a `test.beforeEach`. The earlier attempt installed it inside the test body, after `agentComposerPanel` had already booted the app, so it could not advance a timer started at mount and the spec went green on exactly the regression it exists to catch. Playwright sets up a fixture that only the test body requests after the beforeEach hooks run, so installing the clock in a hook puts it in place before `bootAgentApp` navigates. Measured on a cloud-distribution harness: green clean, and red for a mount-started timer, for a focus handler that never starts the timer, and against the merge-base component. The spec also drops from 8.6s to 5.5s per cloud run.
…e it provides runNotice.spec.ts depends on this fixture restoring a conversation with no bound workflow, which is what lets the generic run notice appear at all. The old name pointed readers at the performance suite instead. Both consumers move to the new name; the implementation is unchanged.
Move the run-notice copy change and the restored-thread fixture rename out of this PR so every changed path sits inside the Agent review globs. Both return in a follow-up that needs a frontend-team review on its own. The deferral, its unit cases and the PM-1236 browser spec are unchanged.
…e it provides agentComposerPerformanceTest supplies a restored targetless conversation, which runNotice.spec.ts relies on beyond performance measurement.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 9
✨ Finishing Touches
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-21T00:18:48.958Z",
"gitSha": "6e35865a2f325635b4c2c0b3073733d80952dbc5",
"branch": "christian-byrne/pm-1236-fixture-rename",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2056.4150000000154,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1210000000000004,
"layouts": 9,
"layoutDurationMs": 2.8069999999999995,
"taskDurationMs": 579.3340000000001,
"heapDeltaBytes": 10395932,
"heapUsedBytes": 107486268,
"domNodes": -182,
"jsHeapTotalBytes": 1568768,
"scriptDurationMs": 9.617,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2024.89700000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.494,
"layouts": 9,
"layoutDurationMs": 2.641,
"taskDurationMs": 577.9380000000001,
"heapDeltaBytes": 4714292,
"heapUsedBytes": 108967096,
"domNodes": -182,
"jsHeapTotalBytes": 2879488,
"scriptDurationMs": 9.166999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1833.0279999999561,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.408,
"layouts": 9,
"layoutDurationMs": 2.6439999999999997,
"taskDurationMs": 974.8710000000001,
"heapDeltaBytes": -8721964,
"heapUsedBytes": 88154852,
"domNodes": -202,
"jsHeapTotalBytes": -2478080,
"scriptDurationMs": 167.89399999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.590999999963,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.714,
"layouts": 9,
"layoutDurationMs": 2.3559999999999994,
"taskDurationMs": 914.7829999999999,
"heapDeltaBytes": -3829772,
"heapUsedBytes": 100417980,
"domNodes": -182,
"jsHeapTotalBytes": 2617344,
"scriptDurationMs": 156.22200000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.2519999999786,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.186,
"layouts": 12,
"layoutDurationMs": 3.262,
"taskDurationMs": 294.8500000000001,
"heapDeltaBytes": -560972,
"heapUsedBytes": 102767264,
"domNodes": 58,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 12.1,
"eventListeners": 42,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.5540000000356,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.905999999999999,
"layouts": 11,
"layoutDurationMs": 2.523,
"taskDurationMs": 411.67300000000006,
"heapDeltaBytes": -318848,
"heapUsedBytes": 104151880,
"domNodes": 58,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 10.887999999999998,
"eventListeners": 42,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 694.9410000000285,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.636,
"layouts": 9,
"layoutDurationMs": 2.439,
"taskDurationMs": 502.899,
"heapDeltaBytes": 5235856,
"heapUsedBytes": 108520836,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 171.21999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 684.8619999999528,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.101,
"layouts": 10,
"layoutDurationMs": 2.557,
"taskDurationMs": 501.31499999999994,
"heapDeltaBytes": 4317644,
"heapUsedBytes": 111118608,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 173.35899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1175.4450000000247,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 869.409,
"heapDeltaBytes": 21048512,
"heapUsedBytes": 117581848,
"domNodes": 0,
"jsHeapTotalBytes": 9338880,
"scriptDurationMs": 74.725,
"eventListeners": 0,
"totalBlockingTimeMs": 531,
"frameDurationMs": 34.30882352941177,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1137.2640000000729,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 816.562,
"heapDeltaBytes": 21491736,
"heapUsedBytes": 117284084,
"domNodes": 0,
"jsHeapTotalBytes": 9601024,
"scriptDurationMs": 66.77300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 507,
"frameDurationMs": 33.335294117647045,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.8440000000328,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.80500000000006,
"heapDeltaBytes": -2370344,
"heapUsedBytes": 103697496,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.45999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 211,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.1109999999744,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.9280000000002,
"heapDeltaBytes": -3269224,
"heapUsedBytes": 102787520,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.51600000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10586.645000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9666.513,
"heapDeltaBytes": 16605536,
"heapUsedBytes": 119650060,
"domNodes": 0,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 8233.438000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 1555,
"frameDurationMs": 33.27955974842767,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9674.300000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8824.889000000001,
"heapDeltaBytes": 10652144,
"heapUsedBytes": 122143908,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7084.468999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 606,
"frameDurationMs": 30.882747603833863,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10166.934000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9266.133,
"heapDeltaBytes": -223796,
"heapUsedBytes": 111253584,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7812.372,
"eventListeners": 0,
"totalBlockingTimeMs": 997,
"frameDurationMs": 31.47430340557276,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8806.631000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8037.411999999999,
"heapDeltaBytes": -28843496,
"heapUsedBytes": 98841572,
"domNodes": -298,
"jsHeapTotalBytes": -2519040,
"scriptDurationMs": 6629.188999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 540,
"frameDurationMs": 31.653597122302163,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 212.60899999998628,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.578000000000001,
"layouts": 11,
"layoutDurationMs": 2.9890000000000003,
"taskDurationMs": 158.325,
"heapDeltaBytes": 14519488,
"heapUsedBytes": 119005416,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.205999999999998,
"eventListeners": 205,
"totalBlockingTimeMs": 2,
"frameDurationMs": 27.075000000000045,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 217.2170000000051,
"styleRecalcs": 20,
"styleRecalcDurationMs": 13.201,
"layouts": 7,
"layoutDurationMs": 2.1790000000000003,
"taskDurationMs": 167.195,
"heapDeltaBytes": 14648184,
"heapUsedBytes": 107031616,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.729999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2054.557999999986,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.313,
"layouts": 6,
"layoutDurationMs": 2.164,
"taskDurationMs": 641.386,
"heapDeltaBytes": -7436996,
"heapUsedBytes": 104654676,
"domNodes": -298,
"jsHeapTotalBytes": -4595712,
"scriptDurationMs": 33.171,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.0999999999913,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.483,
"layouts": 8,
"layoutDurationMs": 2.5580000000000003,
"taskDurationMs": 495.763,
"heapDeltaBytes": -29926432,
"heapUsedBytes": 98966300,
"domNodes": -278,
"jsHeapTotalBytes": -1171456,
"scriptDurationMs": 35.68599999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2650.374999999997,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.289,
"layouts": 6,
"layoutDurationMs": 1.6400000000000003,
"taskDurationMs": 1764.336,
"heapDeltaBytes": -35960844,
"heapUsedBytes": 93579608,
"domNodes": -298,
"jsHeapTotalBytes": -217088,
"scriptDurationMs": 807.899,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.771974522292993,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2169.2170000000033,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.827000000000001,
"layouts": 5,
"layoutDurationMs": 1.118,
"taskDurationMs": 1423.9630000000002,
"heapDeltaBytes": 17081972,
"heapUsedBytes": 111308604,
"domNodes": -278,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 799.033,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3423.037000000022,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.301000000000002,
"layouts": 61,
"layoutDurationMs": 9.215,
"taskDurationMs": 1517.5760000000002,
"heapDeltaBytes": 1320312,
"heapUsedBytes": 96215136,
"domNodes": -254,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 751.2560000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3508.860000000027,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.943,
"layouts": 65,
"layoutDurationMs": 11.075000000000001,
"taskDurationMs": 1608.272,
"heapDeltaBytes": -15598844,
"heapUsedBytes": 116668436,
"domNodes": -274,
"jsHeapTotalBytes": -2220032,
"scriptDurationMs": 762.4759999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.826442307692307,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3014.4359999999892,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.5200000000000005,
"layouts": 4,
"layoutDurationMs": 4.489999999999999,
"taskDurationMs": 1929.405,
"heapDeltaBytes": -7933556,
"heapUsedBytes": 101269196,
"domNodes": -263,
"jsHeapTotalBytes": -421888,
"scriptDurationMs": 1010.9189999999999,
"eventListeners": 52,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.044886363636362,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2704.650000000015,
"styleRecalcs": 40,
"styleRecalcDurationMs": 3.712000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1736.17,
"heapDeltaBytes": 17792180,
"heapUsedBytes": 115138060,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 955.8340000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.980503144654087,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2018.4849999999415,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6189999999999998,
"layouts": 2,
"layoutDurationMs": 0.7140000000000002,
"taskDurationMs": 575.2349999999999,
"heapDeltaBytes": 12435228,
"heapUsedBytes": 106261448,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.29899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.7509999999047,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2329999999999997,
"layouts": 4,
"layoutDurationMs": 1.082,
"taskDurationMs": 412.72300000000007,
"heapDeltaBytes": 12390156,
"heapUsedBytes": 105564320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.371000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.3680000000131,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.303999999999999,
"layouts": 10,
"layoutDurationMs": 2.6270000000000002,
"taskDurationMs": 423.87199999999996,
"heapDeltaBytes": -88708,
"heapUsedBytes": 105693904,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 149.331,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.9249999999993,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.9719999999999995,
"layouts": 9,
"layoutDurationMs": 2.282,
"taskDurationMs": 435.68399999999997,
"heapDeltaBytes": -505748,
"heapUsedBytes": 105380804,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 142.491,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.7670000000207,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.765,
"layouts": 9,
"layoutDurationMs": 2.419,
"taskDurationMs": 604.9979999999999,
"heapDeltaBytes": -21165816,
"heapUsedBytes": 87673544,
"domNodes": -220,
"jsHeapTotalBytes": 5124096,
"scriptDurationMs": 8.792,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2024.6329999999944,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7550000000000003,
"layouts": 9,
"layoutDurationMs": 2.687,
"taskDurationMs": 590.365,
"heapDeltaBytes": -15490448,
"heapUsedBytes": 92373900,
"domNodes": -200,
"jsHeapTotalBytes": 1716224,
"scriptDurationMs": 7.8180000000000005,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754095,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2023.2609999999909,
"styleRecalcs": 87,
"styleRecalcDurationMs": 14.867,
"layouts": 9,
"layoutDurationMs": 2.3310000000000004,
"taskDurationMs": 1110.533,
"heapDeltaBytes": -579684,
"heapUsedBytes": 107718628,
"domNodes": -220,
"jsHeapTotalBytes": 3026944,
"scriptDurationMs": 111.93299999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1975.5910000000085,
"styleRecalcs": 86,
"styleRecalcDurationMs": 17.553,
"layouts": 9,
"layoutDurationMs": 2.7390000000000003,
"taskDurationMs": 970.9080000000001,
"heapDeltaBytes": -20470428,
"heapUsedBytes": 89199860,
"domNodes": -200,
"jsHeapTotalBytes": 1024000,
"scriptDurationMs": 112.405,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487393,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.6499999999114,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.999000000000002,
"layouts": 5,
"layoutDurationMs": 16.136,
"taskDurationMs": 1092.819,
"heapDeltaBytes": 40924220,
"heapUsedBytes": 202161004,
"domNodes": 16030,
"jsHeapTotalBytes": 41033728,
"scriptDurationMs": 30.597000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 161,
"frameDurationMs": 20.044594594594585,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9994.125999999938,
"styleRecalcs": 248,
"styleRecalcDurationMs": 28.052999999999997,
"layouts": 5,
"layoutDurationMs": 1.1909999999999998,
"taskDurationMs": 6059.68,
"heapDeltaBytes": -16199576,
"heapUsedBytes": 110265088,
"domNodes": -298,
"jsHeapTotalBytes": -3842048,
"scriptDurationMs": 2728.7850000000003,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9732.636999999955,
"styleRecalcs": 247,
"styleRecalcDurationMs": 28.156,
"layouts": 5,
"layoutDurationMs": 1.5700000000000003,
"taskDurationMs": 6061.486000000001,
"heapDeltaBytes": -15867544,
"heapUsedBytes": 110356560,
"domNodes": -278,
"jsHeapTotalBytes": -5152768,
"scriptDurationMs": 2750.986,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665924657534244,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16337.63799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15242.735,
"heapDeltaBytes": -43303068,
"heapUsedBytes": 272240452,
"domNodes": -3343,
"jsHeapTotalBytes": 7327744,
"scriptDurationMs": 247.84499999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.776700680272107,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 22632.147000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21836.700999999997,
"heapDeltaBytes": -6983108,
"heapUsedBytes": 306139888,
"domNodes": -3343,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 307.302,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.19964476021315,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 27641.04699999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.811999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27259.881,
"heapDeltaBytes": 4251316,
"heapUsedBytes": 314632644,
"domNodes": -3343,
"jsHeapTotalBytes": 10665984,
"scriptDurationMs": 896.2370000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 62,
"frameDurationMs": 49.72823741007194,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 27860.525000000052,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.917999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27437.279,
"heapDeltaBytes": -28045200,
"heapUsedBytes": 296410412,
"domNodes": -3343,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 876.001,
"eventListeners": -651,
"totalBlockingTimeMs": 38,
"frameDurationMs": 51.09871559633027,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8077.329999999961,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.63699999999999,
"layouts": 20,
"layoutDurationMs": 27.052000000000007,
"taskDurationMs": 7925.612999999999,
"heapDeltaBytes": -12321212,
"heapUsedBytes": 302218696,
"domNodes": -3343,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 111.98200000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.6933734939759,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 5913.3600000000115,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.364,
"layouts": 20,
"layoutDurationMs": 21.70799999999999,
"taskDurationMs": 5776.3809999999985,
"heapDeltaBytes": -6755008,
"heapUsedBytes": 311055836,
"domNodes": -3343,
"jsHeapTotalBytes": 26726400,
"scriptDurationMs": 100.70899999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 3,
"frameDurationMs": 34.00229885057472,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11360.87299999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10884.548999999999,
"heapDeltaBytes": 3789988,
"heapUsedBytes": 287383984,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.68500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.39898648648649,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8178.884999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7585.910999999999,
"heapDeltaBytes": -8288296,
"heapUsedBytes": 283084236,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.58700000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.738644067796603,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 116.14799999995284,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.142999999999999,
"layouts": 9,
"layoutDurationMs": 3.7750000000000004,
"taskDurationMs": 94.25800000000001,
"heapDeltaBytes": 5045852,
"heapUsedBytes": 108522304,
"domNodes": 132,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.092,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 460.66000000007534,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.697000000000001,
"layouts": 11,
"layoutDurationMs": 4.612,
"taskDurationMs": 117.447,
"heapDeltaBytes": 6809508,
"heapUsedBytes": 112178760,
"domNodes": 103,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.677,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 420.4650000000356,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.607,
"layouts": 76,
"layoutDurationMs": 14.147,
"taskDurationMs": 375.611,
"heapDeltaBytes": -14905272,
"heapUsedBytes": 78380720,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 177.892,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 423.91299999997045,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.643,
"layouts": 76,
"layoutDurationMs": 14.116,
"taskDurationMs": 374.758,
"heapDeltaBytes": -14575712,
"heapUsedBytes": 78406828,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 175.651,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538459,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 572.0029999999952,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.296,
"layouts": 76,
"layoutDurationMs": 14.87,
"taskDurationMs": 530.5210000000001,
"heapDeltaBytes": 1305656,
"heapUsedBytes": 115083284,
"domNodes": 4,
"jsHeapTotalBytes": 1220608,
"scriptDurationMs": 217.12099999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.152941176470584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 595.7069999999476,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.929,
"layouts": 76,
"layoutDurationMs": 14.945,
"taskDurationMs": 553.157,
"heapDeltaBytes": 1036640,
"heapUsedBytes": 123425420,
"domNodes": 4,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 221.98999999999998,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.181818181818183,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E CoverageLine coverage: 64.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2988 passed, 0 failed · 4 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 820086de4251b8e6414f2e39f0fa8401ee4bc218
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (125)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21501 +/- ##
==========================================
+ Coverage 86.51% 87.44% +0.93%
==========================================
Files 3883 2726 -1157
Lines 180505 150144 -30361
Branches 47770 39696 -8074
==========================================
- Hits 156156 131295 -24861
+ Misses 21939 18214 -3725
+ Partials 2410 635 -1775
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…36-fixture-rename # Conflicts: # browser_tests/tests/agent/runNotice.spec.ts
…rg#21496) ## Summary The Agent's run notice says "Check Run permissions" without saying where that control lives. This names it: the Run permissions popover in the composer toolbar, and what it controls. It also finishes one test-name follow-up from Comfy-Org#18426. This PR holds what remains of PM-1236. Comfy-Org#18426 (merged 2026-10-21 as [`820086de42`](Comfy-Org@820086d)) shipped the deferral. These two changes were moved out of it because they touch files outside the Agent review paths, and those need a frontend-team review: 1. **Copy** (`src/locales/en/main.json`) | | text | | --- | --- | | **before** | The agent can modify the graph. Check Run permissions before allowing it to execute the workflow. | | **after** | The agent can modify the graph. Use Run permissions in the composer toolbar to control whether it asks before executing. | | **before** (expanded) | The agent can modify your workflow. Check Run permissions before allowing it to execute. | | **after** (expanded) | The agent can modify your workflow. Use Run permissions in the composer toolbar to control whether it asks before executing. | The control exists on `main` as `RunModePopover.vue`, labelled `agent.runPermissions` ("Run permissions"). English only; other locales follow through the i18n workflow. 2. **Fixture rename** (`browser_tests/fixtures/agentPanelFixture.ts` plus its two consumers). `agentComposerPerformanceTest` becomes `restoredTargetlessAgentThreadTest`. The fixture provides a restored conversation with no workflow target, and `runNotice.spec.ts` depends on that state, not on performance measurement. The fixture body does not change. This was the reviewer's last P3 on Comfy-Org#18426; it previously sat in draft Comfy-Org#21501, which is now closed in favour of this PR. Linear: PM-1236 ## Verification - No test or source file asserts the old wording. The Agent specs read `enMessages.agent.runNotice`, so they pick up the new copy unchanged. - No references to the old fixture names remain under `browser_tests/` or `src/`. `typecheck:browser` passed in the pre-commit hook. - A rendered comparison of the old and new copy in the same panel frame is in [this Comfy-Org#18426 comment](Comfy-Org#18426 (comment)).
Summary
Renames the Agent panel fixture
agentComposerPerformanceTesttorestoredTargetlessAgentThreadTest. It supplies a restored conversation with no workflow target, andrunNotice.spec.tsrelies on that state for reasons that have nothing to do with performance measurement. The fixture body does not change.This is the follow-up promised in #18426. The rename was reverted there to keep that PR inside the Agent review paths.
browser_tests/fixtures/agentPanelFixture.tsand the performance spec are outside them. The PR is stacked on #18426 and stays a draft until that merges, becauserunNotice.spec.tsonly exists on that branch.Verification
browser_tests/orsrc/.typecheck:browserpassed in the pre-commit hook.