Repository navigation
chore: resync the comfy-multi-player import with upstream main - #21495
christian-byrne wants to merge 4 commits into
Conversation
* fix(widgets): compose node-local order with dynamic combos * fix(widgets): preserve dynamic values across compaction Ported into packages/comfy-multi-player from Comfy-Org/comfy-multi-player@c12150d. The npm self-alias devDependency (comfy-multi-player-v0310) is re-expressed for pnpm; the standalone package-lock.json hunk has no in-tree counterpart.
dcb15be and b3a3b23 made observedDocCounter skip the counterless grow_request / interior_route rows in __stamps. The defect is real, but the standalone repository fixes the same function differently in Comfy-Org/comfy-multi-player#280 (shared companion-row tags in doc.ts, an opt-in skipMalformed read, and schema amendment text). Carrying a second fix here would give one function two behaviours in two trees, and the import ADR says the move hides no semantic change. Restore src/clock.ts and test/clock.test.ts to upstream c12150d so the in-tree package matches the canonical tree. The fix arrives with the next re-sync once #280 lands upstream. The bug is latent: nothing in frontend src, Cloud services, comfy-cli or comfy-cloud-mcp-server calls observedDocCounter, DocDerivedLamportClockStore or persistLamportTick.
…status ADR-PACKAGES-MULTIPLAYER-0041 still described the 2026-10-08 pins (frontend npm 0.3.6, Cloud 0.3.7). Both now pin npm 0.3.10, so after a rebase the npm 0.3.10 the frontend resolves and an in-tree package that also says 0.3.10 would be easy to confuse. Record the import base, the standalone commit the tree now matches, and that the version field names the last release rather than this source. List the unreleased delta in the package changelog.
The port of upstream #288 shifts the existing applier.ts clone group by 67 lines and adds one moderate CRAP finding in compact.ts. Both are measured from the unmodified upstream source, matching how the import baselined its other inherited findings.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-20T23:14:09.509Z",
"gitSha": "1def1ed926568e48cf4e7edd82c8ca6838f30a52",
"branch": "christian-byrne/cmp-import-resync-824e",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.8800000000147,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.389,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.35499999999996,
"heapDeltaBytes": 10434712,
"heapUsedBytes": 81097220,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.043000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2050.485999999978,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7769999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.41299999999995,
"heapDeltaBytes": -49373656,
"heapUsedBytes": 60780972,
"domNodes": -212,
"jsHeapTotalBytes": -1835008,
"scriptDurationMs": 9.241000000000003,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1785.8489999999847,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.678999999999998,
"layouts": 12,
"layoutDurationMs": 4.433000000000001,
"taskDurationMs": 814.423,
"heapDeltaBytes": 943420,
"heapUsedBytes": 57757792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.669,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.1409999999942,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.333000000000002,
"layouts": 12,
"layoutDurationMs": 5.138,
"taskDurationMs": 809.8550000000001,
"heapDeltaBytes": 6052896,
"heapUsedBytes": 76216800,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 159.89999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1758.6769999999774,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.432000000000001,
"layouts": 3,
"layoutDurationMs": 1.043,
"taskDurationMs": 423.22099999999995,
"heapDeltaBytes": -50240068,
"heapUsedBytes": 59580388,
"domNodes": -167,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 11.09,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.842999999988,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.714999999999999,
"layouts": 3,
"layoutDurationMs": 0.9289999999999999,
"taskDurationMs": 361.622,
"heapDeltaBytes": -11034896,
"heapUsedBytes": 98025392,
"domNodes": 45,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.624999999999998,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 626.656999999966,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.3900000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.85699999999997,
"heapDeltaBytes": -4515216,
"heapUsedBytes": 65477356,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 166.965,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 621.4310000000296,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0220000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.31399999999996,
"heapDeltaBytes": 18240392,
"heapUsedBytes": 80834792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.162,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1162.337999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 840.128,
"heapDeltaBytes": 12318064,
"heapUsedBytes": 93390276,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 66.90599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 529,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1172.8129999999055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 835.8740000000001,
"heapDeltaBytes": 17572892,
"heapUsedBytes": 90614668,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 69.465,
"eventListeners": 0,
"totalBlockingTimeMs": 534,
"frameDurationMs": 34.30882352941177,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.5289999999759,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.81799999999987,
"heapDeltaBytes": 19645536,
"heapUsedBytes": 97605292,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 168.48600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.8320000000867,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.81000000000006,
"heapDeltaBytes": -7006640,
"heapUsedBytes": 78232352,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 162.389,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9669.464000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8777.122000000001,
"heapDeltaBytes": 12228244,
"heapUsedBytes": 94857832,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 7439.186000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1009,
"frameDurationMs": 32.99078498293515,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8723.81800000005,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9040000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7831.989000000001,
"heapDeltaBytes": -17458928,
"heapUsedBytes": 70596276,
"domNodes": -141,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 6593.947,
"eventListeners": -73,
"totalBlockingTimeMs": 549,
"frameDurationMs": 32.46468401486989,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9726.328000000023,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5070000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8882.59,
"heapDeltaBytes": -5741600,
"heapUsedBytes": 82645260,
"domNodes": -141,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 7603.243,
"eventListeners": -69,
"totalBlockingTimeMs": 957,
"frameDurationMs": 32.280066445182726,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8779.436000000032,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8289999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7980.6410000000005,
"heapDeltaBytes": -6200136,
"heapUsedBytes": 81989392,
"domNodes": -141,
"jsHeapTotalBytes": -12980224,
"scriptDurationMs": 6772.879,
"eventListeners": -69,
"totalBlockingTimeMs": 633,
"frameDurationMs": 32.89513108614233,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2034.9499999999807,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.6670000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.27699999999993,
"heapDeltaBytes": -47829408,
"heapUsedBytes": 85202968,
"domNodes": -308,
"jsHeapTotalBytes": -4030464,
"scriptDurationMs": 37.561,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80245901639344,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2059.325999999942,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.1459999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.2840000000001,
"heapDeltaBytes": -47638728,
"heapUsedBytes": 85298852,
"domNodes": -308,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 34.49700000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2374.6960000000286,
"styleRecalcs": 65,
"styleRecalcDurationMs": 5.366999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1626.9840000000002,
"heapDeltaBytes": 21690972,
"heapUsedBytes": 87727256,
"domNodes": -308,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 876.8589999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66619718309859,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2310.094999999933,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.720999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1594.723,
"heapDeltaBytes": -55678904,
"heapUsedBytes": 78418952,
"domNodes": -308,
"jsHeapTotalBytes": -3280896,
"scriptDurationMs": 810.6379999999999,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78759124087591,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3637.823000000026,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.696,
"layouts": 60,
"layoutDurationMs": 16.469,
"taskDurationMs": 1714.2470000000003,
"heapDeltaBytes": 13837372,
"heapUsedBytes": 96135780,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 803.419,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3654.2129999999133,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.93,
"layouts": 60,
"layoutDurationMs": 16.688000000000002,
"taskDurationMs": 1726.752,
"heapDeltaBytes": 9588356,
"heapUsedBytes": 95023988,
"domNodes": 24,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 810.2669999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662100456621,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2937.6829999999927,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.296999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.0249999999999,
"heapDeltaBytes": -11469484,
"heapUsedBytes": 75497428,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 990.033,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.85689655172414,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2896.338999999898,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.877000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1870.707,
"heapDeltaBytes": 17917976,
"heapUsedBytes": 89437116,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 990.71,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76279069767441,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.6499999999746,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8540000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.446,
"heapDeltaBytes": -2334376,
"heapUsedBytes": 82972604,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.714999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.8600000000852,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.7410000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.7460000000001,
"heapDeltaBytes": -21671444,
"heapUsedBytes": 86203640,
"domNodes": -308,
"jsHeapTotalBytes": -3805184,
"scriptDurationMs": 30.464999999999993,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.4790000000339,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.889,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.30699999999996,
"heapDeltaBytes": -8371220,
"heapUsedBytes": 64370660,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 148.99,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.8749999999354,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.151000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.08200000000005,
"heapDeltaBytes": -8455236,
"heapUsedBytes": 64228124,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 144.694,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2042.1420000000126,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4479999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.939,
"heapDeltaBytes": -32146928,
"heapUsedBytes": 59878076,
"domNodes": -230,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 8.425,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.1910000000207,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.553000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.25,
"heapDeltaBytes": 6605856,
"heapUsedBytes": 73533704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.674,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.7900000000022,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.057999999999998,
"layouts": 16,
"layoutDurationMs": 6.190000000000001,
"taskDurationMs": 611.952,
"heapDeltaBytes": 22936896,
"heapUsedBytes": 79849312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 103.545,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.3480000000382,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.279999999999998,
"layouts": 16,
"layoutDurationMs": 6.345999999999999,
"taskDurationMs": 744.937,
"heapDeltaBytes": 1877340,
"heapUsedBytes": 74660180,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 106.14299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.6550000000052,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.684999999999995,
"layouts": 6,
"layoutDurationMs": 15.027000000000003,
"taskDurationMs": 998.3279999999999,
"heapDeltaBytes": 32012100,
"heapUsedBytes": 110291172,
"domNodes": 14650,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 31.406000000000002,
"eventListeners": 2456,
"totalBlockingTimeMs": 135,
"frameDurationMs": 19.406849315068477,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8403.378999999972,
"styleRecalcs": 251,
"styleRecalcDurationMs": 21.798000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5619.506,
"heapDeltaBytes": -47184684,
"heapUsedBytes": 85690680,
"domNodes": -308,
"jsHeapTotalBytes": -2265088,
"scriptDurationMs": 2681.024,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8421.157999999992,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.490000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5568.136,
"heapDeltaBytes": -10282740,
"heapUsedBytes": 73033648,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2737.307,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873014,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18602.08299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17739.692,
"heapDeltaBytes": -40887564,
"heapUsedBytes": 184155348,
"domNodes": -3046,
"jsHeapTotalBytes": 8704000,
"scriptDurationMs": 301.956,
"eventListeners": -14914,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.57758913412564,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 18621.38200000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17667.888,
"heapDeltaBytes": -45805300,
"heapUsedBytes": 183476000,
"domNodes": -3046,
"jsHeapTotalBytes": 8978432,
"scriptDurationMs": 281.588,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.876541095890406,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 22690.41699999997,
"styleRecalcs": 177,
"styleRecalcDurationMs": 15.509999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22292.748,
"heapDeltaBytes": -26015640,
"heapUsedBytes": 191033876,
"domNodes": -3045,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 920.673,
"eventListeners": -14913,
"totalBlockingTimeMs": 29,
"frameDurationMs": 40.9731046931408,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 23132.55800000002,
"styleRecalcs": 180,
"styleRecalcDurationMs": 15.714999999999979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22777.96,
"heapDeltaBytes": -39715320,
"heapUsedBytes": 190593344,
"domNodes": -3046,
"jsHeapTotalBytes": 9515008,
"scriptDurationMs": 873.9709999999999,
"eventListeners": -14913,
"totalBlockingTimeMs": 14,
"frameDurationMs": 42.21240875912408,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6697.089000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.80599999999998,
"layouts": 20,
"layoutDurationMs": 24.529999999999998,
"taskDurationMs": 6575.999000000001,
"heapDeltaBytes": 1059532,
"heapUsedBytes": 220303388,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 115.03099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.61038251366121,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4897.780000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.78399999999996,
"layouts": 20,
"layoutDurationMs": 24.284999999999986,
"taskDurationMs": 4784.608,
"heapDeltaBytes": -13268384,
"heapUsedBytes": 216685468,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 90.099,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.339520958083824,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9450.89799999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9028.352000000003,
"heapDeltaBytes": -32022844,
"heapUsedBytes": 183535012,
"domNodes": -3046,
"jsHeapTotalBytes": 7942144,
"scriptDurationMs": 160.24299999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.92432432432432,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9478.310999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9127.770999999999,
"heapDeltaBytes": -35005436,
"heapUsedBytes": 185917644,
"domNodes": -3046,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.35700000000006,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.69931034482758,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 516.6999999999007,
"styleRecalcs": 14,
"styleRecalcDurationMs": 16.775,
"layouts": 3,
"layoutDurationMs": 0.9060000000000001,
"taskDurationMs": 209.346,
"heapDeltaBytes": -49244796,
"heapUsedBytes": 58400508,
"domNodes": -116,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 10.749000000000002,
"eventListeners": -58,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 115.88899999992464,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.917000000000001,
"layouts": 3,
"layoutDurationMs": 1.5419999999999998,
"taskDurationMs": 77.07,
"heapDeltaBytes": 4051220,
"heapUsedBytes": 66007284,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.553,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 801.5419999999267,
"styleRecalcs": 78,
"styleRecalcDurationMs": 87.267,
"layouts": 76,
"layoutDurationMs": 25.422,
"taskDurationMs": 772.49,
"heapDeltaBytes": 17459612,
"heapUsedBytes": 90178564,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 324.50100000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665306122448985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 833.8599999999587,
"styleRecalcs": 78,
"styleRecalcDurationMs": 88.519,
"layouts": 76,
"layoutDurationMs": 26.134,
"taskDurationMs": 800.1469999999999,
"heapDeltaBytes": 17877364,
"heapUsedBytes": 93812196,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 323.318,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665999999999986,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1374.7829999999794,
"styleRecalcs": 78,
"styleRecalcDurationMs": 241.768,
"layouts": 76,
"layoutDurationMs": 28.269,
"taskDurationMs": 1352.514,
"heapDeltaBytes": 13974976,
"heapUsedBytes": 136773388,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 480.58099999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.29124999999999,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1341.1939999999731,
"styleRecalcs": 78,
"styleRecalcDurationMs": 251.19599999999997,
"layouts": 76,
"layoutDurationMs": 28.462999999999997,
"taskDurationMs": 1325.1920000000002,
"heapDeltaBytes": 14017452,
"heapUsedBytes": 134831688,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 484.78200000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.87500000000001,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2239 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b3a3b23b36ec1f65fc4cc7560650d0204421e897
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## jkl/cmp-workspace-import #21495 +/- ##
============================================================
- Coverage 85.80% 84.55% -1.26%
============================================================
Files 3585 3632 +47
Lines 171778 174759 +2981
Branches 45176 46826 +1650
============================================================
+ Hits 147391 147761 +370
- Misses 22372 24987 +2615
+ Partials 2015 2011 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Resync for #20510, stacked on its branch. Four commits on top of
b3a3b23b36:c12150d), which merged after the import base.CHANGELOG.mdUnreleasedlists what this tree adds over npm 0.3.10.Merging this into
jkl/cmp-workspace-importis a fast-forward. It does not mergemain; #20510 still needs that (3 conflicts, resolution below).Full context for agent readers
In-tree vs upstream after this branch:
src/andfixtures/match upstreamc12150dexcept the three non-semantic import edits already in #20510 (global.d.tstype default,read.tsandschema-version.tsexport trims).src/index.tsis unchanged, so the root API is the same.Lamport floor:
observedDocCounterthrows on the counterlessgrow_request/interior_routerows in__stamps. No caller exists in frontendsrc/apps/packages, Cloud, comfy-cli or comfy-cloud-mcp-server, so the defect is latent. Upstream #280 (Simon) is the canonical fix; it currently conflicts with #288 indocs/multiplayer-schema.md, where both add an "Amendment A25", so #280 needs renumbering to A26.Main merge, verified as a trial (not committed here): against
main1853877b25, conflicts are exactlydocs/adr/README.md(take main's deletion, #20669),scripts/check-adrs.test.ts(keep the imported-ADR test, take main's rename ofaccepts identifier-based ADRs), andpnpm-lock.yaml(take main's, runpnpm install). The merged tree passed the root ADR tests,check-adrs.ts,check-adr-links.sh, and the package suite.Still open, not decided here: a freeze point for the standalone repo (it is still taking merges, e.g. comfy-multi-player #289); squash-only
mainversus the "preserve the merge commit" request; and review routing forpackages/comfy-multi-player/**, which falls under the default frontend-devs rule.Verification
typecheck,test(122 files, 1808 passed, 2 skipped),check:purity,check:pins,check:imports,check:stateless,check:coderabbit,check:profile-claims,verify:corpus,verify:package(57 exports) all pass.knip,fallow:audit) pass.