Repository navigation
fix: keep agent wire identity off the reconnecting session id (for #20883) - #21492
Conversation
The human actor and the doc_ops tab moved onto api.clientId, which Cloud ingest reassigns on every websocket reconnect. The actor is minted once, the tab is re-read on every send, so a retry after a reconnect claimed a writer the host refuses (forbidden), and a send before the first status frame carried an empty tab (invalid_frame). Wire identity goes back to one per-follower id; api.clientId stays the diagnostics tag only. The fake host now enforces the relay's empty-tab and actor/tab checks and mints a fresh sid per connection, as Cloud does.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-20T22:50:54.311Z",
"gitSha": "51ce8ac5bbe1331f34d4d46cccae7099b7ce9313",
"branch": "cb/fe-3400-stable-wire-identity",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.7459999999696,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.843,
"layouts": 11,
"layoutDurationMs": 3.4070000000000005,
"taskDurationMs": 506.69300000000004,
"heapDeltaBytes": -8348372,
"heapUsedBytes": 59937104,
"domNodes": -182,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.465000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.3529999999955,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.128,
"layouts": 9,
"layoutDurationMs": 3.002,
"taskDurationMs": 467.818,
"heapDeltaBytes": 538540,
"heapUsedBytes": 68468452,
"domNodes": -162,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.494999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1853.4400000000346,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.625,
"layouts": 9,
"layoutDurationMs": 2.554,
"taskDurationMs": 980.5930000000001,
"heapDeltaBytes": 6850932,
"heapUsedBytes": 81415508,
"domNodes": -162,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 169.578,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.783999999946,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.293,
"layouts": 9,
"layoutDurationMs": 3.0020000000000002,
"taskDurationMs": 986.0210000000001,
"heapDeltaBytes": 4207016,
"heapUsedBytes": 72026360,
"domNodes": -162,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 172.747,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.5060000000376,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.963,
"layouts": 11,
"layoutDurationMs": 3.0589999999999997,
"taskDurationMs": 455.774,
"heapDeltaBytes": 20234908,
"heapUsedBytes": 87995836,
"domNodes": 47,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.005,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.5469999999923,
"styleRecalcs": 19,
"styleRecalcDurationMs": 7.816,
"layouts": 13,
"layoutDurationMs": 3.751,
"taskDurationMs": 456.99100000000004,
"heapDeltaBytes": 20093228,
"heapUsedBytes": 88079504,
"domNodes": 47,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 15.687,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 672.3649999999566,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.198,
"layouts": 10,
"layoutDurationMs": 2.846,
"taskDurationMs": 476.472,
"heapDeltaBytes": 1183952,
"heapUsedBytes": 68960832,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 178.51,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000018,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 714.907999999923,
"styleRecalcs": 15,
"styleRecalcDurationMs": 5.654,
"layouts": 11,
"layoutDurationMs": 3.4470000000000005,
"taskDurationMs": 501.988,
"heapDeltaBytes": 776736,
"heapUsedBytes": 68660564,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 170.627,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1258.3329999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 985.048,
"heapDeltaBytes": -11760556,
"heapUsedBytes": 81504164,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 71.22699999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 564,
"frameDurationMs": 33.78108108108107,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1288.2439999999633,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1009.502,
"heapDeltaBytes": -11529956,
"heapUsedBytes": 81725828,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 74.909,
"eventListeners": -106,
"totalBlockingTimeMs": 586,
"frameDurationMs": 33.771052631578954,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.6140000000455,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.0969999999998,
"heapDeltaBytes": -5392260,
"heapUsedBytes": 75733724,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 167.42299999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 854.7559999999521,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.74399999999963,
"heapDeltaBytes": -5579776,
"heapUsedBytes": 75828820,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 160.63700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11319.806999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10396.249000000002,
"heapDeltaBytes": -4026796,
"heapUsedBytes": 74827472,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 8456.643999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 1312,
"frameDurationMs": 31.966666666666665,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9284.72899999997,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.08200000000000048,
"layouts": 1,
"layoutDurationMs": 0.39099999999999985,
"taskDurationMs": 8436.54,
"heapDeltaBytes": -9485716,
"heapUsedBytes": 70572176,
"domNodes": -258,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 7032.2480000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 697,
"frameDurationMs": 32.06793103448276,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8971.90599999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.28500000000000053,
"layouts": 1,
"layoutDurationMs": 0.4150000000000004,
"taskDurationMs": 8226.297,
"heapDeltaBytes": 2270744,
"heapUsedBytes": 81029484,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 6856.42,
"eventListeners": -67,
"totalBlockingTimeMs": 634,
"frameDurationMs": 32.13727598566309,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10284.444000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9424.526,
"heapDeltaBytes": -8299784,
"heapUsedBytes": 71399576,
"domNodes": -258,
"jsHeapTotalBytes": -2232320,
"scriptDurationMs": 7587.2970000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 881,
"frameDurationMs": 30.879579579579577,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 282.37300000000687,
"styleRecalcs": 24,
"styleRecalcDurationMs": 17.886,
"layouts": 11,
"layoutDurationMs": 3.6,
"taskDurationMs": 239.34199999999998,
"heapDeltaBytes": -30637024,
"heapUsedBytes": 64064744,
"domNodes": 917,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.974,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.23636363636367,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 274.39000000003944,
"styleRecalcs": 24,
"styleRecalcDurationMs": 17.305,
"layouts": 11,
"layoutDurationMs": 3.3649999999999993,
"taskDurationMs": 236.65100000000004,
"heapDeltaBytes": -29485388,
"heapUsedBytes": 64599376,
"domNodes": 917,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.931000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 1,
"frameDurationMs": 23.60833333333335,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2071.8650000000025,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.628,
"layouts": 9,
"layoutDurationMs": 3.362,
"taskDurationMs": 750.331,
"heapDeltaBytes": -1312864,
"heapUsedBytes": 82478104,
"domNodes": -258,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 40.150999999999996,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.4760000000024,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.151999999999999,
"layouts": 9,
"layoutDurationMs": 2.8760000000000003,
"taskDurationMs": 540.368,
"heapDeltaBytes": -491952,
"heapUsedBytes": 83330696,
"domNodes": -258,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 40.768,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2262.564999999995,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.585,
"layouts": 8,
"layoutDurationMs": 2.045,
"taskDurationMs": 1568.8400000000001,
"heapDeltaBytes": 106000,
"heapUsedBytes": 84112292,
"domNodes": -258,
"jsHeapTotalBytes": 5857280,
"scriptDurationMs": 849.759,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925922,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2676.099000000022,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.636,
"layouts": 8,
"layoutDurationMs": 2.6079999999999997,
"taskDurationMs": 1779.388,
"heapDeltaBytes": 3443788,
"heapUsedBytes": 87733444,
"domNodes": -258,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 849.905,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.876582278481013,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3981.8880000000263,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.824000000000002,
"layouts": 66,
"layoutDurationMs": 12.281000000000002,
"taskDurationMs": 1816.8669999999997,
"heapDeltaBytes": 24300692,
"heapUsedBytes": 101978560,
"domNodes": 24,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 812.3580000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.736286919831223,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3878.9279999999735,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.895999999999997,
"layouts": 66,
"layoutDurationMs": 11.898000000000001,
"taskDurationMs": 1861.5230000000001,
"heapDeltaBytes": -24156,
"heapUsedBytes": 86303540,
"domNodes": -234,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 809.559,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73852813852814,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3031.8359999999984,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.072000000000001,
"layouts": 7,
"layoutDurationMs": 2.1569999999999996,
"taskDurationMs": 1820.4179999999997,
"heapDeltaBytes": 17168820,
"heapUsedBytes": 105371412,
"domNodes": 0,
"jsHeapTotalBytes": 6709248,
"scriptDurationMs": 1012.117,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758011049723756,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3086.0509999999977,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.677,
"layouts": 6,
"layoutDurationMs": 1.6139999999999999,
"taskDurationMs": 1989.1499999999999,
"heapDeltaBytes": 17024944,
"heapUsedBytes": 104285380,
"domNodes": 0,
"jsHeapTotalBytes": 7495680,
"scriptDurationMs": 967.5469999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.93621621621622,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2088.827999999978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.081000000000001,
"layouts": 9,
"layoutDurationMs": 4.047000000000001,
"taskDurationMs": 744.2249999999999,
"heapDeltaBytes": -10918100,
"heapUsedBytes": 66609572,
"domNodes": -258,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 39.304,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665599999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.6230000000814,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.672999999999999,
"layouts": 8,
"layoutDurationMs": 2.2860000000000005,
"taskDurationMs": 691.354,
"heapDeltaBytes": -1222000,
"heapUsedBytes": 85015084,
"domNodes": -258,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 35.568,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.2580000000398,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.156,
"layouts": 10,
"layoutDurationMs": 2.6580000000000004,
"taskDurationMs": 451.11400000000003,
"heapDeltaBytes": 23074536,
"heapUsedBytes": 91176848,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 145.16899999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.0440000000117,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.040999999999999,
"layouts": 11,
"layoutDurationMs": 3.336,
"taskDurationMs": 454.818,
"heapDeltaBytes": 22641436,
"heapUsedBytes": 90033048,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 146.323,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.8329999999542,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.027000000000001,
"layouts": 13,
"layoutDurationMs": 4.617,
"taskDurationMs": 659.142,
"heapDeltaBytes": -5607584,
"heapUsedBytes": 70591368,
"domNodes": -180,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 12.440999999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.7700000000505,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.378,
"layouts": 10,
"layoutDurationMs": 3.2420000000000004,
"taskDurationMs": 465.187,
"heapDeltaBytes": 4828428,
"heapUsedBytes": 72980808,
"domNodes": -180,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.895000000000003,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1815.7659999999964,
"styleRecalcs": 61,
"styleRecalcDurationMs": 19.064999999999998,
"layouts": 12,
"layoutDurationMs": 3.374,
"taskDurationMs": 991.372,
"heapDeltaBytes": 1438048,
"heapUsedBytes": 68131016,
"domNodes": -172,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 118.35200000000002,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665137614678905,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2008.6710000000494,
"styleRecalcs": 88,
"styleRecalcDurationMs": 20.275000000000002,
"layouts": 10,
"layoutDurationMs": 4.095,
"taskDurationMs": 1127.8239999999998,
"heapDeltaBytes": -1160748,
"heapUsedBytes": 67130148,
"domNodes": -172,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 117.803,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665833333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.3900000000367,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.101999999999997,
"layouts": 5,
"layoutDurationMs": 16.75,
"taskDurationMs": 1128.2400000000002,
"heapDeltaBytes": 38435276,
"heapUsedBytes": 116624912,
"domNodes": 15956,
"jsHeapTotalBytes": 16130048,
"scriptDurationMs": 31.324000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 159,
"frameDurationMs": 20.0904109589041,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10253.669000000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.575,
"layouts": 8,
"layoutDurationMs": 2.406,
"taskDurationMs": 6275.82,
"heapDeltaBytes": -12471908,
"heapUsedBytes": 86609552,
"domNodes": -258,
"jsHeapTotalBytes": 4550656,
"scriptDurationMs": 2892.5009999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.720391517128874,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10300.595999999929,
"styleRecalcs": 252,
"styleRecalcDurationMs": 21.441000000000003,
"layouts": 10,
"layoutDurationMs": 2.501,
"taskDurationMs": 6138.6539999999995,
"heapDeltaBytes": -28201216,
"heapUsedBytes": 70480992,
"domNodes": -258,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 2803.023,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23562.005999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23121.855,
"heapDeltaBytes": 268316,
"heapUsedBytes": 280356628,
"domNodes": -3330,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 322.996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.88385416666667,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23224.56599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22779.993,
"heapDeltaBytes": -12686096,
"heapUsedBytes": 265942604,
"domNodes": -3330,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 371.919,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.90559566787003,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 19755.14099999998,
"styleRecalcs": 158,
"styleRecalcDurationMs": 13.326000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19383.234,
"heapDeltaBytes": -2418084,
"heapUsedBytes": 295855876,
"domNodes": -3330,
"jsHeapTotalBytes": 15069184,
"scriptDurationMs": 807.747,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 36.074040219378425,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19529.59300000009,
"styleRecalcs": 160,
"styleRecalcDurationMs": 14.761000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19188.251,
"heapDeltaBytes": -7914304,
"heapUsedBytes": 276115276,
"domNodes": -3330,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 863.528,
"eventListeners": -651,
"totalBlockingTimeMs": 58,
"frameDurationMs": 36.1712962962963,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6182.73499999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.51299999999999,
"layouts": 20,
"layoutDurationMs": 24.493000000000002,
"taskDurationMs": 6052.561000000001,
"heapDeltaBytes": -40781708,
"heapUsedBytes": 257410924,
"domNodes": -3330,
"jsHeapTotalBytes": 8847360,
"scriptDurationMs": 104.432,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.69617486338797,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6224.515999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.15300000000003,
"layouts": 20,
"layoutDurationMs": 29.624000000000013,
"taskDurationMs": 6097.189,
"heapDeltaBytes": -14230784,
"heapUsedBytes": 281803748,
"domNodes": -3330,
"jsHeapTotalBytes": 27250688,
"scriptDurationMs": 105.731,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.12090395480226,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8225.099,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7818.137,
"heapDeltaBytes": 19264848,
"heapUsedBytes": 276223012,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 126.56899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.529166666666672,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11843.48799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11625.465000000002,
"heapDeltaBytes": 12267424,
"heapUsedBytes": 287809836,
"domNodes": 0,
"jsHeapTotalBytes": -24379392,
"scriptDurationMs": 192.93899999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.03243243243244,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 145.5349999999953,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.321,
"layouts": 10,
"layoutDurationMs": 4.221,
"taskDurationMs": 106.67600000000002,
"heapDeltaBytes": 4569664,
"heapUsedBytes": 77229476,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.388999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 474.4059999999308,
"styleRecalcs": 13,
"styleRecalcDurationMs": 14.474,
"layouts": 13,
"layoutDurationMs": 4.271000000000001,
"taskDurationMs": 121.11799999999998,
"heapDeltaBytes": -11743836,
"heapUsedBytes": 65863688,
"domNodes": 95,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 10.117,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 582.1169999999256,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.052,
"layouts": 76,
"layoutDurationMs": 15.852000000000002,
"taskDurationMs": 536.156,
"heapDeltaBytes": -12673076,
"heapUsedBytes": 82448020,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 261.069,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285714,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 501.62599999998747,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.346,
"layouts": 76,
"layoutDurationMs": 16.312,
"taskDurationMs": 459.82800000000003,
"heapDeltaBytes": 11769128,
"heapUsedBytes": 85847300,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 217.996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 652.5739999999587,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.604,
"layouts": 76,
"layoutDurationMs": 15.715,
"taskDurationMs": 615.0420000000001,
"heapDeltaBytes": 801984,
"heapUsedBytes": 123015916,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 231.709,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 542.7439999999706,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.245,
"layouts": 76,
"layoutDurationMs": 14.756,
"taskDurationMs": 497.947,
"heapDeltaBytes": -257584,
"heapUsedBytes": 119074872,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 192.674,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2266 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e1a7b74ed0fb7c2b070a90caa3ff0a7f64a060cf
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## drjkl/fe-3400-12-report-lost-human-edits-and-mint-divergence-through #21492 +/- ##
=======================================================================================================
Coverage ? 85.61%
=======================================================================================================
Files ? 2682
Lines ? 150789
Branches ? 40486
=======================================================================================================
Hits ? 129103
Misses ? 21297
Partials ? 389
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
## Summary Pins the agent's human wire identity across a `/ws` reconnect. Main is correct today; this makes the identity change in Comfy-Org#20883 fail CI before it can land, and replaces Comfy-Org#21492, whose harness targets the pre-split `/ws` doc transport. <details><summary>Full context for agent readers</summary> Review finding on Comfy-Org#20883: Comfy-Org#20883 (comment) (blocker) and Comfy-Org#20883 (comment) (same root). The agent refuses a `doc_ops` batch whose ops claim any writer other than `human:<user>:<frame tab>` (cloud `services/agent/server/doc_handler.go`, `messages.HumanActor(userID, req.Tab)`, 403 → `forbidden`), and the relay refuses an empty tab (`DocOpsFrame.Validate`). Cloud ingest mints a new session id per `/ws` connection, which `api.ts` copies into `api.clientId`. `opSender` reads the actor once at mint and the tab on every send and resend, so both must come from the per-follower `tabId`, as on main. Comfy-Org#20883 moved both onto `api.clientId`. Comfy-Org#21492 fixed that against Comfy-Org#20883's head, but Comfy-Org#20883 is 262 commits behind main and main has since moved doc frames onto `/api/agent/events`, separate from `/ws`. Comfy-Org#21492's harness and unit pin conflict with main in three files and its reconnect proof would not survive the rebase. This PR carries the same proof onto main instead. Changes (tests and harness only, no product code): - `agentFollowerHostSocket.ts`: refuses a frame without a tab as `invalid_frame`, and a batch whose envelope and stamp actors do not name one writer `human:<user>:<frame tab>` as `forbidden`, including held batches released later. Mints a fresh sid per `/ws` connection and records each doc frame's tab, writers and `/ws` connection. Adds `disconnectComfySocket()` and `leaveHumanBatchesUnanswered()`, which drops the next acceptable batch as lost in transit so the sender's result-timeout resend is judged. - `agentHumanEditResentAcrossReconnect.spec.ts`: rename, lose the first send, reconnect `/ws` to a new session id; the resend must carry the same op ids, tab and writer on a later `/ws` connection, be accepted, and keep the rename. - `crossWorkflowPending.test.ts`: the retried batch keeps its tab and actor when `api.clientId` changes, and the tab is never empty before the first session id. - `agentFollowerHostSocket.test.ts`: refusal cases (missing tab, actor for another tab, stamp for another tab, stamp for another user), the unanswered-then-resent path, and a refused frame not consuming the drop. Cloud references at `a0997c0498`: `services/agent/server/doc_handler.go` (`messages.HumanActor(userID, req.Tab)`, 403 on mismatch) and `common/websocket/messages/crdt.go` (tab required). </details> ## Verification - Mutation: with `useAgentCrdtFollower.ts` switched to Comfy-Org#20883's identity (`actor` and `tab` from `api.clientId`), the new spec fails (the resend's tab is the new session id) and both unit pins fail (`sid-after-reconnect` vs `sid-before-reconnect`; empty tab). Restored: spec passes on every local run (5/5 and 5/5 repeats, then 3/3 at the final head), unit 10/10. - Fixture unit tests: the new cases fail against main's harness; 13/13 pass. - 22 existing agent specs that use the apply host, held releases or disconnects: 56/58 pass. The 2 failures are `@screenshot` diffs in `agentConversationReplay` (1717 px and 509 px) that fail identically on untouched main on this machine. - `vitest src/workbench/extensions/agent browser_tests/fixtures`: 4328 passed, 1 expected fail; one unrelated `useAgentSession` timing case failed once under load and passes alone (251/251). - `typecheck`, `typecheck:browser`, oxlint, oxfmt, knip, fallow audit: clean.
Pins the agent's human wire identity across a `/ws` reconnect. Main is correct today; this makes the identity change in #20883 fail CI before it can land, and replaces #21492, whose harness targets the pre-split `/ws` doc transport. <details><summary>Full context for agent readers</summary> Review finding on #20883: #20883 (comment) (blocker) and #20883 (comment) (same root). The agent refuses a `doc_ops` batch whose ops claim any writer other than `human:<user>:<frame tab>` (cloud `services/agent/server/doc_handler.go`, `messages.HumanActor(userID, req.Tab)`, 403 → `forbidden`), and the relay refuses an empty tab (`DocOpsFrame.Validate`). Cloud ingest mints a new session id per `/ws` connection, which `api.ts` copies into `api.clientId`. `opSender` reads the actor once at mint and the tab on every send and resend, so both must come from the per-follower `tabId`, as on main. #20883 moved both onto `api.clientId`. behind main and main has since moved doc frames onto `/api/agent/events`, separate from `/ws`. #21492's harness and unit pin conflict with main in three files and its reconnect proof would not survive the rebase. This PR carries the same proof onto main instead. Changes (tests and harness only, no product code): - `agentFollowerHostSocket.ts`: refuses a frame without a tab as `invalid_frame`, and a batch whose envelope and stamp actors do not name one writer `human:<user>:<frame tab>` as `forbidden`, including held batches released later. Mints a fresh sid per `/ws` connection and records each doc frame's tab, writers and `/ws` connection. Adds `disconnectComfySocket()` and `leaveHumanBatchesUnanswered()`, which drops the next acceptable batch as lost in transit so the sender's result-timeout resend is judged. - `agentHumanEditResentAcrossReconnect.spec.ts`: rename, lose the first send, reconnect `/ws` to a new session id; the resend must carry the same op ids, tab and writer on a later `/ws` connection, be accepted, and keep the rename. - `crossWorkflowPending.test.ts`: the retried batch keeps its tab and actor when `api.clientId` changes, and the tab is never empty before the first session id. - `agentFollowerHostSocket.test.ts`: refusal cases (missing tab, actor for another tab, stamp for another tab, stamp for another user), the unanswered-then-resent path, and a refused frame not consuming the drop. Cloud references at `a0997c0498`: `services/agent/server/doc_handler.go` (`messages.HumanActor(userID, req.Tab)`, 403 on mismatch) and `common/websocket/messages/crdt.go` (tab required). </details> - Mutation: with `useAgentCrdtFollower.ts` switched to #20883's identity (`actor` and `tab` from `api.clientId`), the new spec fails (the resend's tab is the new session id) and both unit pins fail (`sid-after-reconnect` vs `sid-before-reconnect`; empty tab). Restored: spec passes on every local run (5/5 and 5/5 repeats, then 3/3 at the final head), unit 10/10. - Fixture unit tests: the new cases fail against main's harness; 13/13 pass. - 22 existing agent specs that use the apply host, held releases or disconnects: 56/58 pass. The 2 failures are `@screenshot` diffs in `agentConversationReplay` (1717 px and 509 px) that fail identically on untouched main on this machine. - `vitest src/workbench/extensions/agent browser_tests/fixtures`: 4328 passed, 1 expected fail; one unrelated `useAgentSession` timing case failed once under load and passes alone (251/251). - `typecheck`, `typecheck:browser`, oxlint, oxfmt, knip, fallow audit: clean. (cherry picked from commit 2a9a4f9)
Pins the agent's human wire identity across a `/ws` reconnect. Main is correct today; this makes the identity change in #20883 fail CI before it can land, and replaces #21492, whose harness targets the pre-split `/ws` doc transport. <details><summary>Full context for agent readers</summary> Review finding on #20883: #20883 (comment) (blocker) and #20883 (comment) (same root). The agent refuses a `doc_ops` batch whose ops claim any writer other than `human:<user>:<frame tab>` (cloud `services/agent/server/doc_handler.go`, `messages.HumanActor(userID, req.Tab)`, 403 → `forbidden`), and the relay refuses an empty tab (`DocOpsFrame.Validate`). Cloud ingest mints a new session id per `/ws` connection, which `api.ts` copies into `api.clientId`. `opSender` reads the actor once at mint and the tab on every send and resend, so both must come from the per-follower `tabId`, as on main. #20883 moved both onto `api.clientId`. behind main and main has since moved doc frames onto `/api/agent/events`, separate from `/ws`. #21492's harness and unit pin conflict with main in three files and its reconnect proof would not survive the rebase. This PR carries the same proof onto main instead. Changes (tests and harness only, no product code): - `agentFollowerHostSocket.ts`: refuses a frame without a tab as `invalid_frame`, and a batch whose envelope and stamp actors do not name one writer `human:<user>:<frame tab>` as `forbidden`, including held batches released later. Mints a fresh sid per `/ws` connection and records each doc frame's tab, writers and `/ws` connection. Adds `disconnectComfySocket()` and `leaveHumanBatchesUnanswered()`, which drops the next acceptable batch as lost in transit so the sender's result-timeout resend is judged. - `agentHumanEditResentAcrossReconnect.spec.ts`: rename, lose the first send, reconnect `/ws` to a new session id; the resend must carry the same op ids, tab and writer on a later `/ws` connection, be accepted, and keep the rename. - `crossWorkflowPending.test.ts`: the retried batch keeps its tab and actor when `api.clientId` changes, and the tab is never empty before the first session id. - `agentFollowerHostSocket.test.ts`: refusal cases (missing tab, actor for another tab, stamp for another tab, stamp for another user), the unanswered-then-resent path, and a refused frame not consuming the drop. Cloud references at `a0997c0498`: `services/agent/server/doc_handler.go` (`messages.HumanActor(userID, req.Tab)`, 403 on mismatch) and `common/websocket/messages/crdt.go` (tab required). </details> - Mutation: with `useAgentCrdtFollower.ts` switched to #20883's identity (`actor` and `tab` from `api.clientId`), the new spec fails (the resend's tab is the new session id) and both unit pins fail (`sid-after-reconnect` vs `sid-before-reconnect`; empty tab). Restored: spec passes on every local run (5/5 and 5/5 repeats, then 3/3 at the final head), unit 10/10. - Fixture unit tests: the new cases fail against main's harness; 13/13 pass. - 22 existing agent specs that use the apply host, held releases or disconnects: 56/58 pass. The 2 failures are `@screenshot` diffs in `agentConversationReplay` (1717 px and 509 px) that fail identically on untouched main on this machine. - `vitest src/workbench/extensions/agent browser_tests/fixtures`: 4328 passed, 1 expected fail; one unrelated `useAgentSession` timing case failed once under load and passes alone (251/251). - `typecheck`, `typecheck:browser`, oxlint, oxfmt, knip, fallow audit: clean. (cherry picked from commit 2a9a4f9)
Summary
Fix for the blocker on #20883, targeting its branch. Human edits retried after a reconnect were refused on Cloud. Wire identity goes back to one id per follower, and
api.clientIdstays the diagnostics tag only.Full context for agent readers
#20883 moved the human
actorand thedoc_opstabontoapi.clientId. Cloud ingest mints a new session id on every/wsconnection, andapi.tscopies it intoclientId. The actor is minted once, but the tab is re-read on every send and resend. So a transport retry or result-timeout resend after a reconnect claims an actor the agent refuses (op.actor != HumanActor(user, frame.Tab), 403, relayed asforbidden), and the edit is reverted. Before the firststatusframe, or afterresetSocket(), the tab was'', which the relay refuses asinvalid_frame. Review finding: #20883 (comment), plus the same-root minor finding #20883 (comment).Changes:
useAgentCrdtFollower.ts: restores the per-followertabIdforactor, the wiretab, and the CRDT debug snapshot's tab id. The debug report already showsclientIdseparately.reportLostEditkeeps taggingtab: api.clientId, as FE-3400 asks. Telemetry payload, privacy and boundedness are unchanged.agentFollowerHostSocket.ts): now enforces the relay's empty-tab refusal and the agent's actor-matches-frame-tab check (envelope and stamp), and mints a fresh sid per connection like Cloud ingest. This harness gap is why the bug passed e2e.agentHumanEditRetriedAcrossReconnect.spec.ts; unit pins incrossWorkflowPending.test.ts; fixture unit cases.This PR does not rebase #20883. #20883 is still
DIRTYagainstmain, and its rebase stays with the author.Verification
vitest src/workbench/extensions/agent src/platform/telemetry: 4026 passed, 1 expected fail.agentConversationReplaywire evidence (1926 px). It fails identically at the untouched head on this machine.typecheck,typecheck:browser, oxlint and oxfmt are clean.