Repository navigation
[backport cloud/1.58] FE-1908 fix(workspace): reopen a reloaded tab on its own workspace - #21488
Conversation
…21464) ## Why Release QA on testcloud (cloud/1.58, 1667189), C-06: tab 1 is on a team workspace and tab 2 switches to Personal. Reloading tab 1 then opens it on Personal. Repro 3/3. C-06 expects a reloaded tab to stay on its own workspace. ## Root cause Each tab keeps its workspace identity in `sessionStorage` (`Comfy.Workspace.Current`), and both auth rails write it. On boot, `teamWorkspaceStore.initialize` only restores it through `workspaceAuthStore.initializeFromSession()`. That restore requires the legacy workspace token as well. Under unified auth the legacy token is retired, so the restore fails. On failure it also clears the stored identity. Boot then falls through to the switch target, then the server's `default_workspace_id`, then `Comfy.Workspace.LastWorkspaceId` in `localStorage`. That last key is shared by every tab, so the tab that switched last decides where any reloaded tab lands. ## How - Snapshot this tab's workspace id from `sessionStorage` once, in `workspaceAuthStore` setup (`bootTabWorkspaceId`). Reading it at init was too late: a boot-time unified mint with no target yet mints Personal, and the snapshot subscriber persists that over the tab's identity before `teamWorkspaceStore` initializes. `workspaceSwitcher.spec.ts` and `topUpSdkRailOutcomes.spec.ts` caught this. - Rank it right after a pending switch target, ahead of the server default and the shared last-used id. This is the order the legacy rail already gets, because a restored legacy session returns before the default is consulted. - The id still has to be in the listed workspaces. If it isn't (for example, the user left that workspace), boot falls through as before. - New tabs and fresh sign-ins have no tab identity, so they land the same as today. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | _placeholder_ | _placeholder_ | ## Plan position | # | Item | PR | Status | | --- | --- | --- | --- | | 1 | Reopen checkout retries a retryable 409 | PR 21463 | in review | | **2** | **Reloaded tab keeps its own workspace** | **this PR** | **open** | ```mermaid flowchart LR QA["release-qa cloud/1.58 FE-1908"] --> A["PR 21463 reopen checkout 409"] QA --> B["this PR: reload keeps tab workspace"]:::current classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ``` - Part of FE-1908
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-20T21:32:37.356Z",
"gitSha": "f1400f487025a54d025d2e0d591eebcdb2bee4f6",
"branch": "backport-21464-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.345999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.03,
"layouts": 9,
"layoutDurationMs": 2.785,
"taskDurationMs": 557.591,
"heapDeltaBytes": 7657832,
"heapUsedBytes": 114270860,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.888000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2025.7100000000037,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.893,
"layouts": 9,
"layoutDurationMs": 2.7419999999999995,
"taskDurationMs": 448.096,
"heapDeltaBytes": -8136828,
"heapUsedBytes": 90616176,
"domNodes": -200,
"jsHeapTotalBytes": 6397952,
"scriptDurationMs": 12.886,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664754098360653,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.335000000006,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.125000000000002,
"layouts": 9,
"layoutDurationMs": 2.2929999999999997,
"taskDurationMs": 746.127,
"heapDeltaBytes": -13280888,
"heapUsedBytes": 90907980,
"domNodes": -200,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 136.537,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1747.871000000032,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.996999999999998,
"layouts": 8,
"layoutDurationMs": 2.1229999999999998,
"taskDurationMs": 841.452,
"heapDeltaBytes": -6799548,
"heapUsedBytes": 83067748,
"domNodes": -180,
"jsHeapTotalBytes": -3100672,
"scriptDurationMs": 133.214,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.4430000000175,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.24,
"layouts": 11,
"layoutDurationMs": 3.097,
"taskDurationMs": 329.27299999999997,
"heapDeltaBytes": 1831360,
"heapUsedBytes": 105567036,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 15.145999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.5230000000192,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.421,
"layouts": 12,
"layoutDurationMs": 3.0970000000000004,
"taskDurationMs": 292.738,
"heapDeltaBytes": 3050224,
"heapUsedBytes": 92803316,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 13.323,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 586.0759999999914,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.147,
"layouts": 10,
"layoutDurationMs": 2.6619999999999995,
"taskDurationMs": 405.34400000000005,
"heapDeltaBytes": 6480612,
"heapUsedBytes": 110716988,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 146.01999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 592.3410000000331,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9709999999999996,
"layouts": 10,
"layoutDurationMs": 2.692,
"taskDurationMs": 457.26199999999994,
"heapDeltaBytes": 5267956,
"heapUsedBytes": 97553632,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 141.29,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1093.8240000000405,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 795.671,
"heapDeltaBytes": -8637960,
"heapUsedBytes": 102903520,
"domNodes": -236,
"jsHeapTotalBytes": 10338304,
"scriptDurationMs": 49.13500000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 411,
"frameDurationMs": 29.72972972972973,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1108.5869999999431,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 821.2600000000001,
"heapDeltaBytes": -9292312,
"heapUsedBytes": 101967816,
"domNodes": -230,
"jsHeapTotalBytes": 10600448,
"scriptDurationMs": 51.724000000000004,
"eventListeners": -168,
"totalBlockingTimeMs": 421,
"frameDurationMs": 29.72702702702704,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.3449999999875,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.6070000000002,
"heapDeltaBytes": 22982000,
"heapUsedBytes": 124692904,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.52700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 853.8879999999835,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.5769999999997,
"heapDeltaBytes": -23230208,
"heapUsedBytes": 105689608,
"domNodes": -231,
"jsHeapTotalBytes": -2932736,
"scriptDurationMs": 128.954,
"eventListeners": -168,
"totalBlockingTimeMs": 194,
"frameDurationMs": 23.613888888888873,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8194.425999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7272.749,
"heapDeltaBytes": -20132872,
"heapUsedBytes": 99994724,
"domNodes": -276,
"jsHeapTotalBytes": 1941504,
"scriptDurationMs": 5987.126,
"eventListeners": -130,
"totalBlockingTimeMs": 107,
"frameDurationMs": 25.544236760124612,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7637.219999999957,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8919999999999996,
"layouts": 3,
"layoutDurationMs": 0.667,
"taskDurationMs": 6759.131,
"heapDeltaBytes": 5534928,
"heapUsedBytes": 126941116,
"domNodes": -276,
"jsHeapTotalBytes": 30777344,
"scriptDurationMs": 5415.82,
"eventListeners": -130,
"totalBlockingTimeMs": 81,
"frameDurationMs": 24.543408360128616,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8042.09800000001,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3820000000000004,
"layouts": 1,
"layoutDurationMs": 0.33,
"taskDurationMs": 7157.273,
"heapDeltaBytes": 20030676,
"heapUsedBytes": 133485916,
"domNodes": -296,
"jsHeapTotalBytes": 21897216,
"scriptDurationMs": 5444.885,
"eventListeners": -130,
"totalBlockingTimeMs": 107,
"frameDurationMs": 24.10059880239521,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8088.8550000000805,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6319999999999998,
"layouts": 2,
"layoutDurationMs": 0.5319999999999999,
"taskDurationMs": 7278.062999999999,
"heapDeltaBytes": -5484212,
"heapUsedBytes": 115681864,
"domNodes": -276,
"jsHeapTotalBytes": 5873664,
"scriptDurationMs": 5981.809,
"eventListeners": -130,
"totalBlockingTimeMs": 51,
"frameDurationMs": 24.87107692307692,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 207.39100000002963,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.086000000000002,
"layouts": 11,
"layoutDurationMs": 3.3720000000000003,
"taskDurationMs": 161.018,
"heapDeltaBytes": 13191396,
"heapUsedBytes": 116344340,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 7.688000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.699999999999985,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 208.67500000008476,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.131,
"layouts": 12,
"layoutDurationMs": 3.4059999999999997,
"taskDurationMs": 146.96899999999997,
"heapDeltaBytes": 13257012,
"heapUsedBytes": 118174308,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.104999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2038.295000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7470000000000003,
"layouts": 8,
"layoutDurationMs": 2.2929999999999997,
"taskDurationMs": 676.0399999999998,
"heapDeltaBytes": -21177652,
"heapUsedBytes": 90816616,
"domNodes": -296,
"jsHeapTotalBytes": -1171456,
"scriptDurationMs": 36.55500000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.1120000000883,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.965999999999999,
"layouts": 9,
"layoutDurationMs": 2.709,
"taskDurationMs": 536.9320000000001,
"heapDeltaBytes": 2957704,
"heapUsedBytes": 106010628,
"domNodes": -296,
"jsHeapTotalBytes": -5922816,
"scriptDurationMs": 33.486999999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2225.2829999999904,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.436,
"layouts": 8,
"layoutDurationMs": 2,
"taskDurationMs": 1426.895,
"heapDeltaBytes": 802684,
"heapUsedBytes": 104156708,
"domNodes": -297,
"jsHeapTotalBytes": -454656,
"scriptDurationMs": 728.169,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666917293233084,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2793.1029999999737,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.264000000000001,
"layouts": 7,
"layoutDurationMs": 1.664,
"taskDurationMs": 1511.954,
"heapDeltaBytes": -2475544,
"heapUsedBytes": 99335356,
"domNodes": -296,
"jsHeapTotalBytes": -978944,
"scriptDurationMs": 671.319,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76626506024096,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3905.951000000016,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.753,
"layouts": 64,
"layoutDurationMs": 10.893,
"taskDurationMs": 1669.7980000000002,
"heapDeltaBytes": 7556444,
"heapUsedBytes": 110887876,
"domNodes": -272,
"jsHeapTotalBytes": -2605056,
"scriptDurationMs": 702.732,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666239316239313,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3812.5179999999546,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.110999999999999,
"layouts": 65,
"layoutDurationMs": 10.499,
"taskDurationMs": 1600.1109999999999,
"heapDeltaBytes": -133392,
"heapUsedBytes": 107618188,
"domNodes": -272,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 676.791,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.739035087719298,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2364.4180000000006,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.652,
"layouts": 6,
"layoutDurationMs": 1.324,
"taskDurationMs": 1586.4989999999998,
"heapDeltaBytes": 19783036,
"heapUsedBytes": 124181964,
"domNodes": 0,
"jsHeapTotalBytes": 6451200,
"scriptDurationMs": 824.287,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.785,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2711.4409999999225,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.023000000000001,
"layouts": 5,
"layoutDurationMs": 1.121,
"taskDurationMs": 1674.66,
"heapDeltaBytes": 16610920,
"heapUsedBytes": 123069692,
"domNodes": 0,
"jsHeapTotalBytes": 5926912,
"scriptDurationMs": 818.465,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.872670807453417,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.135000000073,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7039999999999997,
"layouts": 8,
"layoutDurationMs": 2.126,
"taskDurationMs": 690.8449999999999,
"heapDeltaBytes": -23906528,
"heapUsedBytes": 99095756,
"domNodes": -276,
"jsHeapTotalBytes": -2445312,
"scriptDurationMs": 34.522,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2048.3970000000227,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.659,
"layouts": 8,
"layoutDurationMs": 2.2509999999999994,
"taskDurationMs": 600.672,
"heapDeltaBytes": -339472,
"heapUsedBytes": 103662036,
"domNodes": -296,
"jsHeapTotalBytes": -2211840,
"scriptDurationMs": 31.81,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.886999999946,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.558,
"layouts": 9,
"layoutDurationMs": 2.4099999999999997,
"taskDurationMs": 397.43600000000004,
"heapDeltaBytes": 578920,
"heapUsedBytes": 106656256,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 125.47500000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.2089999999807,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.438999999999999,
"layouts": 9,
"layoutDurationMs": 3.118,
"taskDurationMs": 348.30400000000003,
"heapDeltaBytes": 2718456,
"heapUsedBytes": 108528868,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 126.14599999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.209000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8839999999999995,
"layouts": 9,
"layoutDurationMs": 2.623,
"taskDurationMs": 479.62100000000004,
"heapDeltaBytes": -10113104,
"heapUsedBytes": 96031900,
"domNodes": -218,
"jsHeapTotalBytes": 2727936,
"scriptDurationMs": 12.294,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2024.4330000000446,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.962,
"layouts": 9,
"layoutDurationMs": 2.8670000000000004,
"taskDurationMs": 450.302,
"heapDeltaBytes": -9803340,
"heapUsedBytes": 96413340,
"domNodes": -218,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 12.496999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.3439999999823,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.476999999999999,
"layouts": 10,
"layoutDurationMs": 2.6650000000000005,
"taskDurationMs": 660.334,
"heapDeltaBytes": 21239704,
"heapUsedBytes": 114884208,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 100.549,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.889999999973,
"styleRecalcs": 86,
"styleRecalcDurationMs": 15.317,
"layouts": 10,
"layoutDurationMs": 2.5970000000000004,
"taskDurationMs": 978.1390000000001,
"heapDeltaBytes": -6081808,
"heapUsedBytes": 94511396,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 101.53099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66525423728814,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1283.8309999999638,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.975,
"layouts": 5,
"layoutDurationMs": 13.444,
"taskDurationMs": 823.1780000000002,
"heapDeltaBytes": 35526432,
"heapUsedBytes": 134433440,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 28.87499999999999,
"eventListeners": 3244,
"totalBlockingTimeMs": 131,
"frameDurationMs": 19.696969696969695,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8364.778999999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.568,
"layouts": 8,
"layoutDurationMs": 2.1519999999999997,
"taskDurationMs": 4810.633,
"heapDeltaBytes": 6192308,
"heapUsedBytes": 108341532,
"domNodes": -296,
"jsHeapTotalBytes": -716800,
"scriptDurationMs": 2362.572,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666135458167332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9710.589000000027,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.27,
"layouts": 8,
"layoutDurationMs": 2.0420000000000003,
"taskDurationMs": 4970.238,
"heapDeltaBytes": 6436484,
"heapUsedBytes": 109091312,
"domNodes": -296,
"jsHeapTotalBytes": -1536000,
"scriptDurationMs": 2176.523,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665866209262433,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14691.640000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14177.025,
"heapDeltaBytes": 7146716,
"heapUsedBytes": 315801072,
"domNodes": -3344,
"jsHeapTotalBytes": 29609984,
"scriptDurationMs": 222.718,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.575675675675672,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 19963.503999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19126.821999999996,
"heapDeltaBytes": -7204220,
"heapUsedBytes": 301323044,
"domNodes": -3344,
"jsHeapTotalBytes": 22007808,
"scriptDurationMs": 269.918,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.71717352415027,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 24831.638999999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 26.34799999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24605.819,
"heapDeltaBytes": -20863240,
"heapUsedBytes": 284554244,
"domNodes": -3344,
"jsHeapTotalBytes": 8376320,
"scriptDurationMs": 846.759,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 48.25048543689321,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24075.062,
"styleRecalcs": 180,
"styleRecalcDurationMs": 21.615999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23799.483,
"heapDeltaBytes": -12256620,
"heapUsedBytes": 299200524,
"domNodes": -3011,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 730.3109999999999,
"eventListeners": -586,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.37342519685039,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 5553.983000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.716,
"layouts": 20,
"layoutDurationMs": 36.781000000000006,
"taskDurationMs": 5477.911000000001,
"heapDeltaBytes": 4684212,
"heapUsedBytes": 310228432,
"domNodes": -3344,
"jsHeapTotalBytes": 27250688,
"scriptDurationMs": 92.17,
"eventListeners": -653,
"totalBlockingTimeMs": 46,
"frameDurationMs": 32.64588235294118,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5449.606000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.85700000000001,
"layouts": 20,
"layoutDurationMs": 21.55299999999999,
"taskDurationMs": 5360.055,
"heapDeltaBytes": -35131292,
"heapUsedBytes": 281045420,
"domNodes": -3344,
"jsHeapTotalBytes": 19124224,
"scriptDurationMs": 91.31500000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.50115606936416,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10037.337000000094,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9861.087000000001,
"heapDeltaBytes": 14468080,
"heapUsedBytes": 298435860,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.31699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.65526315789474,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7200.412999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6941.563,
"heapDeltaBytes": 10329268,
"heapUsedBytes": 294324280,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.89900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.805376344086017,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 118.73100000002523,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.426000000000002,
"layouts": 8,
"layoutDurationMs": 3.4130000000000003,
"taskDurationMs": 92.03199999999998,
"heapDeltaBytes": 4917184,
"heapUsedBytes": 101185952,
"domNodes": 99,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.541,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 116.41899999995076,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.453,
"layouts": 9,
"layoutDurationMs": 3.012,
"taskDurationMs": 82.61800000000001,
"heapDeltaBytes": -10650556,
"heapUsedBytes": 93194612,
"domNodes": 117,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 6.001000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 324.2050000000063,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.679,
"layouts": 76,
"layoutDurationMs": 12.71,
"taskDurationMs": 292.822,
"heapDeltaBytes": -21523452,
"heapUsedBytes": 68707824,
"domNodes": 4,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 134.67000000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 286.0599999999067,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.593,
"layouts": 76,
"layoutDurationMs": 11.94,
"taskDurationMs": 244.82299999999998,
"heapDeltaBytes": 10084556,
"heapUsedBytes": 100406096,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 112.903,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670588235294098,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 355.5029999999988,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.951,
"layouts": 76,
"layoutDurationMs": 11.564,
"taskDurationMs": 319.268,
"heapDeltaBytes": -1176772,
"heapUsedBytes": 115422704,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 112.10700000000001,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661904761904744,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 359.4460000000481,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.934,
"layouts": 76,
"layoutDurationMs": 11.313,
"taskDurationMs": 321.29400000000004,
"heapDeltaBytes": -989216,
"heapUsedBytes": 115593464,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 117.795,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 63.9% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2952 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 97c4374a946e797629fb7727e6249d284ccee951
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (111)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #21488 +/- ##
=============================================
Coverage ? 86.15%
=============================================
Files ? 2784
Lines ? 154547
Branches ? 39175
=============================================
Hits ? 133150
Misses ? 21007
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of the approved change; approving to unblock the cloud/1.58 merge.
Backport of #21464 to
cloud/1.58Automatically created by backport workflow.