Skip to content

FE-3467 feat(billing): show plan checkout banners on the Billing tab - #21471

Closed
dante01yoon wants to merge 8 commits into
dante/fe-3467-checkout-bannersfrom
dante/fe-3467-subscribe-banners
Closed

dante01yoon wants to merge 8 commits into
dante/fe-3467-checkout-bannersfrom
dante/fe-3467-subscribe-banners

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Stacked on PR #21468 (base dante/fe-3467-checkout-banners); merge that first. This adds DES-1267's plan banners to the Billing tab. Someone who submits Subscribe and leaves the Stripe tab, or whose bank is still clearing the first payment, or whose payment was declined, sees nothing in ComfyUI today. The Billing tab now reads the pending subscription operation and shows one banner for what the server reports, ranked together with the top-up banners from part 1.

How

Served fact (GET /billing/status → GET /billing/ops/{id}) Banner Action
status: failed with a decline_reason Your {Plan} plan didn't start Dismiss, Try again ↗ (only when retryable: true)
status: pending, authentication_state: processing Payment processing · Your {Plan} plan starts once it clears Dismiss
status: pending, phase: awaiting_payment_method, no action_url, plan served You have an unfinished checkout · Finish paying for your {Plan} plan Dismiss, Continue payment ↗
anything else (including reconciliation_needed, a failure with no payment attempt such as an abandoned checkout, a served action_url) nothing
  • The pending operation is pending_billing_op_id when pending_billing_op_type is not topup (owner-only on the server; the banner is mounted only for can_manage_billing). The plan name is plan.tier from the operation, formatted like the plan row; without a tier the copy drops the name.
  • One ranking for both sources (DES-1234): Checkout failed (plan, credits) 3 > Payment received 4 > Payment processing (plan, credits) 5 > Unfinished checkout 6. Dismissing reveals the next one.
  • Continue payment ↗ / Try again ↗ (designer decision: option 2). The click reserves a tab, then resubmits Subscribe for the operation's plan.slug and plan.team_credit_stop_id. If the response is needs_payment_method, the reserved tab goes to the fresh payment_method_url. If the browser blocked the tab, the button becomes a real link (Button as="a" target="_blank" rel="noopener", no-underline, the PR 21388 pattern) to that fresh session, and nothing is created twice. The session is created on click, never on render: with a card on file the backend supersedes the parked checkout against the card and charges it, so creating it on render could charge without a click. A refused or failed resubmit closes the reserved tab and shows "We couldn't open checkout. Try again." The action is shown only when can_subscribe_self_serve is served true.
  • The resubmit reopens checkout without creating a new operation: ingest re-mints a checkout session for the same parked operation when the target matches and there is no card (services/ingest/.../billing.go, the "continue-payment self-heal" branch).
  • The banner re-reads when the tab becomes visible again. A failed plan banner appears when an operation this tab saw as pending is no longer listed by status and its own read reports the failure.
  • BillingTopupCheckoutBanner.vue is renamed BillingCheckoutBanner.vue since it now hosts both sources.

Missing server fact

BE-21811 asks the backend for two facts this PR cannot get today:

  • One served subscription checkout state. The banner state is currently combined on the client from status, decline_reason, authentication_state, phase and action_url (table above). That combination is wrapped in pendingServerFact('BE-21811', ...) in subscriptionCheckoutBanner.ts, typed as ServerFact<'subscription_checkout_state', 'failed' | 'processing' | 'unfinished' | 'none'>, the same bridge as 'BE-20674' in deploymentPickStore. check:pending-server-facts fails once BE-21811 closes, and the combination is then replaced by the served field. Behavior is unchanged.
  • The last finished subscription operation. /billing/status drops pending_billing_op_id once the operation is terminal and no endpoint lists recent operations. Until BE-21811 ships it, Checkout failed (plan) appears only for an operation this tab already saw pending, by re-reading that operation once status stops listing it; after a reload or on another device the failure cannot be found.

Scope and follow-ups

  • Part 3: the DES-1267 credits flyout line and the Add credits dialog notice. Both live outside the Billing tab and need the top-up facts shared beyond it, which would push this PR past its size budget.
  • "Payment received, plan activating" and "Verify your payment" are not part of DES-1267 and are not added here.

Plan position

Item Ticket PR Status
Hosted top-up read API BE-21226 Comfy-Org/cloud#14023 Merged (staging)
Banner design DES-1267 Final
Top-up banners on the Billing tab FE-3467 part 1 #21468 Open
Plan banners on the Billing tab FE-3467 part 2 this PR Open
Credits flyout line + Add credits dialog notice FE-3467 part 3 Next
Served subscription checkout state + last finished subscription op BE-21811 Filed; bridged with pendingServerFact
graph LR
  BE["BE-21226 read API"] --> P1["Part 1: top-up banners (PR 21468)"]
  DES["DES-1267 design"] --> P1
  P1 --> P2["Part 2: plan banners (this PR)"]
  P2 --> P3["Part 3: flyout + dialog notice"]
  BEX["BE-21811 served checkout state"] -.-> P2
  style P2 fill:#f9d71c,stroke:#333,color:#000
Loading

Verification

  • pnpm exec vitest run src/platform/workspace/components/dialogs/settings/billing/: 7 files, 154 tests pass. New: subscriptionCheckoutBanner.test.ts (served-op table, cross-source ranking); BillingTab.test.ts (copy per state, reserved-tab reopen, blocked tab gives a real link with target/rel and no second subscribe, refused resubmit, can_subscribe_self_serve false, credits processing over unfinished then dismiss reveals it, failure of a watched op). Removing the watched-op fallback makes its test fail.
  • oxfmt, oxlint --type-aware, eslint on touched files; pre-commit typecheck:app and lint:server-facts pass; tsx scripts/pending-server-facts.ts --offline picks up the 'BE-21811' literal.

AS IS / TO BE

These come from the real cloud app (vite on this branch, cloud distribution, unified_billing_settings on), driven by Playwright with the API mocked (setupCloudApp personal owner, can_manage_billing: true). The served operation states need a parked or declined subscription that testcloud cannot produce without a real checkout, so /billing/status and /billing/ops/{id} serve them. Every billing write was intercepted: the only one made was the mocked POST /api/billing/subscribe in the blocked-tab scenario, and nothing reached the backend. AS IS is the same parked operation on part 1's code (base branch).

AS IS (part 1, a checkout is parked) TO BE: unfinished checkout
AS IS unfinished
TO BE: tab blocked, Continue payment is now a link to the fresh session TO BE: authentication_state: processing
blocked processing
TO BE: failed, decline_reason, retryable: true
failed

Read the pending subscription operation from /billing/status and
/billing/ops/{id} and render DES-1267's plan banners beside the hosted
top-up ones, in one DES-1234 ranking: Checkout failed (failed with a
decline_reason), Payment processing (authentication_state processing)
and Unfinished checkout (awaiting_payment_method with no action_url).
Continue payment and Try again resubmit Subscribe for the operation's
plan on click into a reserved tab; when the browser blocks the tab, the
button becomes a real link to that fresh checkout session. The banner
component now hosts both sources and is renamed BillingCheckoutBanner.
@dante01yoon
dante01yoon requested a review from a team as a code owner October 20, 2026 19:26
@dante01yoon dante01yoon added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.58 Backport PRs for core 1.58 cloud/1.58 Backport PRs for cloud 1.58 labels Oct 20, 2026
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f257b6f9-d58c-4efd-b459-6acde72de98b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 8 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 96.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 98.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 100.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 103.3 MB heap
dom-widget-order-dense-n200-w200-i120: · 29.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 538ms TBT · 115.9 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 40.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 215ms TBT · 98.7 MB heap
extension-clean-combined-draw: · 31.7 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 1078ms TBT · 130.4 MB heap
extension-rgthree-prototype-draw: · 32.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 832ms TBT · 121.8 MB heap
large-combo-open: · 35.9 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 2ms TBT · 113.7 MB heap
large-graph-idle: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 98.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.6 MB heap
legacy-node-drag: · 59.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 102.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 109.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 103.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 93.0 MB heap
subgraph-transition-enter: · 49.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 162ms TBT · 141.3 MB heap
viewport-pan-sweep: · 59.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 145.2 MB heap
vue-large-graph-idle: · 25.1 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 277.0 MB heap
vue-large-graph-pan: · 19.0 avg FPS · 8.6 P5 FPS ❌ (target: ≥52) · 14ms TBT · 287.2 MB heap
vue-node-resize-workload: · 21.8 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 6ms TBT · 281.8 MB heap
vue-zoom-out-idle: · 30.2 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 281.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 102.7 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.4 MB heap
agent-composer-long-conversation-typing: · 55.6 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 106.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 9
canvas-idle: style recalc count 10
canvas-idle: task duration 553ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 96.9 MB
canvas-idle: DOM nodes -192
canvas-idle: event listeners -130
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 901ms
canvas-mouse-sweep: script duration 167ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 98.9 MB
canvas-mouse-sweep: DOM nodes -192
canvas-mouse-sweep: event listeners -130
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 6ms
canvas-zoom-sweep: layout count 11
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 464ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 100.5 MB
canvas-zoom-sweep: DOM nodes 58
canvas-zoom-sweep: event listeners 42
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 11
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 504ms
dom-widget-clipping: script duration 172ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 103.3 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 34ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 848ms
dom-widget-order-dense-n200-w200-i120: script duration 67ms
dom-widget-order-dense-n200-w200-i120: TBT 538ms
dom-widget-order-dense-n200-w200-i120: heap used 115.9 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 443ms
dom-widget-order-sparse-n1000-w20-i120: script duration 154ms
dom-widget-order-sparse-n1000-w20-i120: TBT 215ms
dom-widget-order-sparse-n1000-w20-i120: heap used 98.7 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 58ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9868ms
extension-clean-combined-draw: script duration 8068ms
extension-clean-combined-draw: TBT 1078ms
extension-clean-combined-draw: heap used 130.4 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 31ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9734ms
extension-rgthree-prototype-draw: script duration 7752ms
extension-rgthree-prototype-draw: TBT 832ms
extension-rgthree-prototype-draw: heap used 121.8 MB
extension-rgthree-prototype-draw: DOM nodes -288
extension-rgthree-prototype-draw: event listeners -130
large-combo-open: avg frame time 28ms
large-combo-open: p95 frame time 100ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 14ms
large-combo-open: layout count 11
large-combo-open: style recalc count 21
large-combo-open: task duration 152ms
large-combo-open: script duration 8ms
large-combo-open: TBT 2ms
large-combo-open: heap used 113.7 MB
large-combo-open: DOM nodes 936
large-combo-open: event listeners 205
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 7
large-graph-idle: style recalc count 7
large-graph-idle: task duration 715ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 98.5 MB
large-graph-idle: DOM nodes -298
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 7
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1801ms
large-graph-pan: script duration 840ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 89.2 MB
large-graph-pan: DOM nodes -288
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 9ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 1701ms
large-graph-zoom: script duration 792ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 94.6 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 4ms
legacy-node-drag: layout count 1
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1777ms
legacy-node-drag: script duration 973ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 102.6 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 1ms
minimap-idle: style recalc duration 1ms
minimap-idle: layout count 4
minimap-idle: style recalc count 5
minimap-idle: task duration 498ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 101.0 MB
minimap-idle: DOM nodes -288
minimap-idle: event listeners -65
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 9
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 461ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 109.6 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 10
subgraph-idle: task duration 654ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 103.7 MB
subgraph-idle: DOM nodes -200
subgraph-idle: event listeners -176
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 15ms
subgraph-mouse-sweep: layout count 9
subgraph-mouse-sweep: style recalc count 83
subgraph-mouse-sweep: task duration 1029ms
subgraph-mouse-sweep: script duration 115ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 93.0 MB
subgraph-mouse-sweep: DOM nodes -200
subgraph-mouse-sweep: event listeners -176
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 18ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1170ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 162ms
subgraph-transition-enter: heap used 141.3 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 32ms
viewport-pan-sweep: layout count 7
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 6081ms
viewport-pan-sweep: script duration 2865ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 145.2 MB
viewport-pan-sweep: DOM nodes -288
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 40ms
vue-large-graph-idle: p95 frame time 83ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 22433ms
vue-large-graph-idle: script duration 329ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 277.0 MB
vue-large-graph-idle: DOM nodes -3343
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 53ms
vue-large-graph-pan: p95 frame time 117ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 27774ms
vue-large-graph-pan: script duration 887ms
vue-large-graph-pan: TBT 14ms
vue-large-graph-pan: heap used 287.2 MB
vue-large-graph-pan: DOM nodes -3343
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 46ms
vue-node-resize-workload: p95 frame time 100ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 85ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 8195ms
vue-node-resize-workload: script duration 129ms
vue-node-resize-workload: TBT 6ms
vue-node-resize-workload: heap used 281.8 MB
vue-node-resize-workload: DOM nodes -3343
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 33ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 9346ms
vue-zoom-out-idle: script duration 142ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 281.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 4ms
workflow-execution: style recalc duration 12ms
workflow-execution: layout count 10
workflow-execution: style recalc count 14
workflow-execution: task duration 109ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 102.7 MB
workflow-execution: DOM nodes 121
workflow-execution: event listeners 7
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 15ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 422ms
agent-composer-empty-conversation-typing: script duration 201ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 76.4 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 18ms
agent-composer-long-conversation-typing: p95 frame time 25ms
agent-composer-long-conversation-typing: layout duration 14ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 494ms
agent-composer-long-conversation-typing: script duration 201ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 106.4 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-21T13:56:58.714Z",
  "gitSha": "584aaa55a2da3de90565235f03c89f8e09778ec9",
  "branch": "dante/fe-3467-subscribe-banners",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2041.8569999999931,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.04,
      "layouts": 9,
      "layoutDurationMs": 2.866,
      "taskDurationMs": 632.625,
      "heapDeltaBytes": 2197492,
      "heapUsedBytes": 118732588,
      "domNodes": -202,
      "jsHeapTotalBytes": 7221248,
      "scriptDurationMs": 11.184,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2023.2030000000805,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.4819999999999998,
      "layouts": 9,
      "layoutDurationMs": 2.918,
      "taskDurationMs": 472.87499999999994,
      "heapDeltaBytes": -19705380,
      "heapUsedBytes": 84585188,
      "domNodes": -182,
      "jsHeapTotalBytes": 2711552,
      "scriptDurationMs": 12.024,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1825.433999999973,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 14.001,
      "layouts": 9,
      "layoutDurationMs": 2.764,
      "taskDurationMs": 953.5649999999999,
      "heapDeltaBytes": 1563604,
      "heapUsedBytes": 104827136,
      "domNodes": -182,
      "jsHeapTotalBytes": 1568768,
      "scriptDurationMs": 164.659,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666972477064217,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1757.6440000000275,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 14.454999999999998,
      "layouts": 11,
      "layoutDurationMs": 3.333,
      "taskDurationMs": 848.476,
      "heapDeltaBytes": -1640744,
      "heapUsedBytes": 102605852,
      "domNodes": -202,
      "jsHeapTotalBytes": 1925120,
      "scriptDurationMs": 169.713,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714284,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.9819999999822,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 5.6850000000000005,
      "layouts": 11,
      "layoutDurationMs": 3.7320000000000007,
      "taskDurationMs": 492.85699999999997,
      "heapDeltaBytes": -594656,
      "heapUsedBytes": 103229212,
      "domNodes": 58,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 16.581,
      "eventListeners": 42,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.379000000089,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.444,
      "layouts": 11,
      "layoutDurationMs": 2.956,
      "taskDurationMs": 435.092,
      "heapDeltaBytes": -1110124,
      "heapUsedBytes": 107482948,
      "domNodes": 58,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 13.048,
      "eventListeners": 42,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 681.2739999999735,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 2.9179999999999997,
      "layouts": 10,
      "layoutDurationMs": 2.898,
      "taskDurationMs": 501.73,
      "heapDeltaBytes": 4289164,
      "heapUsedBytes": 108079756,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 173.505,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664999999999985,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 692.1690000000353,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 3.6650000000000005,
      "layouts": 11,
      "layoutDurationMs": 3.267,
      "taskDurationMs": 505.756,
      "heapDeltaBytes": 4736268,
      "heapUsedBytes": 108649676,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 170.35699999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1146.8120000000113,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 857.3389999999999,
      "heapDeltaBytes": 21896368,
      "heapUsedBytes": 120190468,
      "domNodes": 0,
      "jsHeapTotalBytes": 15368192,
      "scriptDurationMs": 66.56599999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 520,
      "frameDurationMs": 33.82058823529411,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1185.9289999999874,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 838.106,
      "heapDeltaBytes": 21890368,
      "heapUsedBytes": 122892784,
      "domNodes": 0,
      "jsHeapTotalBytes": 14581760,
      "scriptDurationMs": 67.414,
      "eventListeners": 0,
      "totalBlockingTimeMs": 555,
      "frameDurationMs": 34.80294117647057,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 847.4970000000326,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.57600000000053,
      "heapDeltaBytes": -3305856,
      "heapUsedBytes": 103290628,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 158.124,
      "eventListeners": 0,
      "totalBlockingTimeMs": 222,
      "frameDurationMs": 25.00000000000003,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 831.5170000000762,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.92600000000004,
      "heapDeltaBytes": -3565340,
      "heapUsedBytes": 103609904,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 149.777,
      "eventListeners": 0,
      "totalBlockingTimeMs": 208,
      "frameDurationMs": 24.50882352941177,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11371.965999999986,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10473.418,
      "heapDeltaBytes": 56046104,
      "heapUsedBytes": 150881512,
      "domNodes": 0,
      "jsHeapTotalBytes": 43778048,
      "scriptDurationMs": 8363.334,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1258,
      "frameDurationMs": 31.31212121212121,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10152.053000000024,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9263.445000000002,
      "heapDeltaBytes": 11254628,
      "heapUsedBytes": 122591572,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 7772.360000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 897,
      "frameDurationMs": 31.7175,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10271.007999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9454.948,
      "heapDeltaBytes": 16918844,
      "heapUsedBytes": 137447296,
      "domNodes": -298,
      "jsHeapTotalBytes": 25436160,
      "scriptDurationMs": 7467.72,
      "eventListeners": -130,
      "totalBlockingTimeMs": 639,
      "frameDurationMs": 31.299695121951224,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10833.838000000014,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10013.718,
      "heapDeltaBytes": -9255116,
      "heapUsedBytes": 117945380,
      "domNodes": -278,
      "jsHeapTotalBytes": 532480,
      "scriptDurationMs": 8037.123999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 1025,
      "frameDurationMs": 30.515211267605633,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-combo-open",
      "durationMs": 191.95099999996046,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 13.289000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.785,
      "taskDurationMs": 146.15800000000002,
      "heapDeltaBytes": 14475932,
      "heapUsedBytes": 119313976,
      "domNodes": 936,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.708999999999999,
      "eventListeners": 205,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.571428571428573,
      "p95FrameDurationMs": 100
    },
    {
      "name": "large-combo-open",
      "durationMs": 207.61300000003757,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 14.224,
      "layouts": 11,
      "layoutDurationMs": 3.239,
      "taskDurationMs": 158.64600000000002,
      "heapDeltaBytes": 14524496,
      "heapUsedBytes": 119052220,
      "domNodes": 936,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.793,
      "eventListeners": 205,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 27.074999999999932,
      "p95FrameDurationMs": 99.89999999999964
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2071.4530000000195,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.214000000000001,
      "layouts": 7,
      "layoutDurationMs": 2.0469999999999997,
      "taskDurationMs": 686.8310000000001,
      "heapDeltaBytes": -22539248,
      "heapUsedBytes": 103246384,
      "domNodes": -298,
      "jsHeapTotalBytes": -7180288,
      "scriptDurationMs": 38.00699999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66612903225806,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2068.681999999967,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 2.4649999999999994,
      "layouts": 6,
      "layoutDurationMs": 2.2749999999999995,
      "taskDurationMs": 743.309,
      "heapDeltaBytes": -22726660,
      "heapUsedBytes": 103277836,
      "domNodes": -298,
      "jsHeapTotalBytes": -5869568,
      "scriptDurationMs": 37.290000000000006,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.801626016260165,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2774.3389999999977,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.441999999999998,
      "layouts": 7,
      "layoutDurationMs": 1.9469999999999996,
      "taskDurationMs": 1791.689,
      "heapDeltaBytes": -30509872,
      "heapUsedBytes": 93558128,
      "domNodes": -298,
      "jsHeapTotalBytes": -2052096,
      "scriptDurationMs": 837.3589999999999,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665662650602403,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2749.7470000000703,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.222999999999999,
      "layouts": 7,
      "layoutDurationMs": 2.2809999999999997,
      "taskDurationMs": 1809.9129999999998,
      "heapDeltaBytes": -36413860,
      "heapUsedBytes": 93521648,
      "domNodes": -278,
      "jsHeapTotalBytes": 45056,
      "scriptDurationMs": 841.885,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666060606060608,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3957.2670000000016,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 9.208,
      "layouts": 60,
      "layoutDurationMs": 9.971,
      "taskDurationMs": 1869.999,
      "heapDeltaBytes": 4059324,
      "heapUsedBytes": 99305256,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 820.994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666244725738398,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3505.4320000000416,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 8.408999999999999,
      "layouts": 60,
      "layoutDurationMs": 9.259,
      "taskDurationMs": 1532.37,
      "heapDeltaBytes": 3581416,
      "heapUsedBytes": 99048412,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 763.264,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66619047619048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2924.09200000003,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.011,
      "layouts": 1,
      "layoutDurationMs": 0.196,
      "taskDurationMs": 1786.028,
      "heapDeltaBytes": 6184324,
      "heapUsedBytes": 101940076,
      "domNodes": 0,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 987.193,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.858381502890172,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2737.1819999999616,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 3.972999999999999,
      "layouts": 1,
      "layoutDurationMs": 0.37199999999999994,
      "taskDurationMs": 1767.2859999999998,
      "heapDeltaBytes": 18159548,
      "heapUsedBytes": 113257112,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 957.8539999999999,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.97639751552795,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.4929999999545,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.7550000000000004,
      "layouts": 2,
      "layoutDurationMs": 0.66,
      "taskDurationMs": 488.3389999999998,
      "heapDeltaBytes": 12370636,
      "heapUsedBytes": 106003420,
      "domNodes": -278,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.512,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2047.9540000000043,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 1.5729999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.6970000000000005,
      "taskDurationMs": 508.36899999999997,
      "heapDeltaBytes": -23453876,
      "heapUsedBytes": 105820792,
      "domNodes": -298,
      "jsHeapTotalBytes": -6037504,
      "scriptDurationMs": 35.39799999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 627.9099999999858,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.441000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.59,
      "taskDurationMs": 448.481,
      "heapDeltaBytes": 22942012,
      "heapUsedBytes": 122115620,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 147.80100000000002,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684214,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 663.989000000015,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.6480000000000015,
      "layouts": 9,
      "layoutDurationMs": 2.7620000000000005,
      "taskDurationMs": 473.83599999999996,
      "heapDeltaBytes": -68912,
      "heapUsedBytes": 107821840,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 147.811,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66500000000001,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2057.836000000009,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.367,
      "layouts": 10,
      "layoutDurationMs": 3.144,
      "taskDurationMs": 651.192,
      "heapDeltaBytes": 9458568,
      "heapUsedBytes": 108548716,
      "domNodes": -200,
      "jsHeapTotalBytes": 2093056,
      "scriptDurationMs": 11.765999999999998,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2072.632999999996,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.8860000000000006,
      "layouts": 9,
      "layoutDurationMs": 2.4540000000000006,
      "taskDurationMs": 656.3240000000001,
      "heapDeltaBytes": 2694756,
      "heapUsedBytes": 108992572,
      "domNodes": -200,
      "jsHeapTotalBytes": 2355200,
      "scriptDurationMs": 12.399000000000001,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666935483870965,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 2031.3189999999963,
      "styleRecalcs": 87,
      "styleRecalcDurationMs": 15.868999999999998,
      "layouts": 9,
      "layoutDurationMs": 2.723,
      "taskDurationMs": 1124.112,
      "heapDeltaBytes": -17500836,
      "heapUsedBytes": 89542468,
      "domNodes": -200,
      "jsHeapTotalBytes": 2764800,
      "scriptDurationMs": 115.32,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1758.4249999999884,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 14.078999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.2819999999999996,
      "taskDurationMs": 934.174,
      "heapDeltaBytes": 8173808,
      "heapUsedBytes": 105576260,
      "domNodes": -200,
      "jsHeapTotalBytes": -2363392,
      "scriptDurationMs": 115.437,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1469.3000000000893,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 27.699999999999996,
      "layouts": 5,
      "layoutDurationMs": 17.668,
      "taskDurationMs": 1169.602,
      "heapDeltaBytes": 13709984,
      "heapUsedBytes": 148209676,
      "domNodes": 16030,
      "jsHeapTotalBytes": 16388096,
      "scriptDurationMs": 30.445999999999994,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 162,
      "frameDurationMs": 20.044594594594596,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11351.802000000022,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 32.215,
      "layouts": 7,
      "layoutDurationMs": 2.5619999999999994,
      "taskDurationMs": 6721.3910000000005,
      "heapDeltaBytes": 82935084,
      "heapUsedBytes": 194577068,
      "domNodes": -298,
      "jsHeapTotalBytes": 59707392,
      "scriptDurationMs": 2941.056,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665932452276067,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8325.530000000072,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 32.465,
      "layouts": 6,
      "layoutDurationMs": 2.1040000000000005,
      "taskDurationMs": 5441.251,
      "heapDeltaBytes": -15774272,
      "heapUsedBytes": 109937076,
      "domNodes": -278,
      "jsHeapTotalBytes": -3747840,
      "scriptDurationMs": 2788.3089999999997,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.767070707070705,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23038.730999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22604.734,
      "heapDeltaBytes": -50038208,
      "heapUsedBytes": 279718976,
      "domNodes": -3343,
      "jsHeapTotalBytes": 17551360,
      "scriptDurationMs": 339.882,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.15522648083624,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 22925.46900000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22261.243,
      "heapDeltaBytes": -33670940,
      "heapUsedBytes": 301213440,
      "domNodes": -3343,
      "jsHeapTotalBytes": 14667776,
      "scriptDurationMs": 317.678,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 39.57823834196891,
      "p95FrameDurationMs": 83.30000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 28312.160999999945,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 22.455000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27977.877999999997,
      "heapDeltaBytes": -27685936,
      "heapUsedBytes": 306935796,
      "domNodes": -3343,
      "jsHeapTotalBytes": 13094912,
      "scriptDurationMs": 888.843,
      "eventListeners": -651,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 53.6278409090909,
      "p95FrameDurationMs": 116.60000000000036
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 27893.62600000004,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 19.88899999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27570.434999999998,
      "heapDeltaBytes": -29208300,
      "heapUsedBytes": 295358456,
      "domNodes": -3343,
      "jsHeapTotalBytes": 14143488,
      "scriptDurationMs": 885.4960000000001,
      "eventListeners": -651,
      "totalBlockingTimeMs": 26,
      "frameDurationMs": 51.56913123844732,
      "p95FrameDurationMs": 116.59999999999854
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8444.725000000062,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.74100000000004,
      "layouts": 20,
      "layoutDurationMs": 24.33300000000001,
      "taskDurationMs": 8336.978,
      "heapDeltaBytes": -13671756,
      "heapUsedBytes": 311229764,
      "domNodes": -3343,
      "jsHeapTotalBytes": 14667776,
      "scriptDurationMs": 129.522,
      "eventListeners": -653,
      "totalBlockingTimeMs": 11,
      "frameDurationMs": 45.18502673796792,
      "p95FrameDurationMs": 99.89999999999782
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8206.547999999999,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 84.34700000000004,
      "layouts": 20,
      "layoutDurationMs": 27.727000000000015,
      "taskDurationMs": 8052.250000000001,
      "heapDeltaBytes": -41112332,
      "heapUsedBytes": 279824908,
      "domNodes": -3343,
      "jsHeapTotalBytes": 10997760,
      "scriptDurationMs": 128.112,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 46.58863636363637,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8264.458999999988,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7744.944,
      "heapDeltaBytes": -4480368,
      "heapUsedBytes": 295621528,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 128.96200000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 27.739597315436246,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11366.774000000078,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10947.178,
      "heapDeltaBytes": -362652,
      "heapUsedBytes": 294693432,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 155.54500000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 38.529830508474575,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "workflow-execution",
      "durationMs": 127.74899999999434,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 11.581000000000001,
      "layouts": 9,
      "layoutDurationMs": 3.979,
      "taskDurationMs": 104.55,
      "heapDeltaBytes": 4938028,
      "heapUsedBytes": 105937428,
      "domNodes": 108,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 15.053999999999998,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662500000000023,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 465.2019999999766,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 12.320999999999998,
      "layouts": 11,
      "layoutDurationMs": 3.6270000000000002,
      "taskDurationMs": 113.816,
      "heapDeltaBytes": 7070212,
      "heapUsedBytes": 109494604,
      "domNodes": 133,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.672999999999998,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667857142857137,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 469.93700000007266,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.618,
      "layouts": 76,
      "layoutDurationMs": 14.837,
      "taskDurationMs": 421.03799999999995,
      "heapDeltaBytes": -14351640,
      "heapUsedBytes": 79438776,
      "domNodes": 4,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 197.382,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664285714285693,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 472.3940000000084,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.632,
      "layouts": 76,
      "layoutDurationMs": 15.088000000000001,
      "taskDurationMs": 423.80899999999997,
      "heapDeltaBytes": -14314988,
      "heapUsedBytes": 80791160,
      "domNodes": 4,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 205.267,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668965517241368,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 471.84600000002774,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.553,
      "layouts": 76,
      "layoutDurationMs": 14.226,
      "taskDurationMs": 428.217,
      "heapDeltaBytes": -70284,
      "heapUsedBytes": 116797672,
      "domNodes": 4,
      "jsHeapTotalBytes": 1220608,
      "scriptDurationMs": 168.38400000000001,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.264285714285734,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 609.0090000000146,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.471,
      "layouts": 76,
      "layoutDurationMs": 13.985,
      "taskDurationMs": 559.284,
      "heapDeltaBytes": -3101932,
      "heapUsedBytes": 106437992,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 234.077,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.687878787878784,
      "p95FrameDurationMs": 33.30000000000018
    }
  ]
}

🔬 E2E Coverage

Line coverage: 64.3%

Coverage totals
Metric Covered Total Pct
Lines 57777 89888 64.3% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.9% 1175
src/LGraphNode.ts 71.3% 379
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 39.6% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.6% 312
src/core/billing/operationLifecycle.ts 1.3% 303
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 1.1% 280
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 46.8% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 2995 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2300 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 666 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/21/2026, 01:36:47 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since c511b20ac25d288431bb24705e94e1d030b8e223

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (131)

  • billing path matches no source files: src/components/dialog/content/credit/**. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LiteGraphGlobal.cloneObject.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 81 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

The plan banner state is combined on the client from status, phase,
authentication_state, action_url and decline_reason. Until the backend
serves one subscription checkout state (BE-21811), the combination is a
pendingServerFact so CI flags it once that ticket closes.
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.72131% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../settings/billing/useSubscriptionCheckoutBanner.ts 91.80% 5 Missing ⚠️
...dialogs/settings/billing/BillingCheckoutBanner.vue 98.88% 1 Missing ⚠️
@@                        Coverage Diff                        @@
##           dante/fe-3467-checkout-banners   #21471     +/-   ##
=================================================================
  Coverage                           87.49%   87.49%             
=================================================================
  Files                                2715     2717      +2     
  Lines                              150071   150217    +146     
  Branches                            39544    41802   +2258     
=================================================================
+ Hits                               131300   131433    +133     
- Misses                              18138    18151     +13     
  Partials                              633      633             
Flag Coverage Δ
e2e 64.27% <ø> (-0.02%) ⬇️
unit 85.75% <96.72%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...components/dialogs/settings/billing/BillingTab.vue 96.22% <100.00%> (ø)
...ogs/settings/billing/subscriptionCheckoutBanner.ts 100.00% <100.00%> (ø)
...dialogs/settings/billing/BillingCheckoutBanner.vue 98.88% <98.88%> (ø)
.../settings/billing/useSubscriptionCheckoutBanner.ts 91.80% <91.80%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Local still shows top-up progress. A plan checkout is a Cloud run, so the Billing tab does not read or render it there.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed ae46a27 against its live stacked base (21468), with latest main fetched. Two blocking findings below; this is a COMMENT because I cannot approve or request changes on my own PR.

PASS: own frozen install; 155 billing tests; app typecheck; Cloud build; touched-file Oxlint/format and source ESLint (test/JSON files excluded by ESLint). Removing the Cloud gate fails only its local row (154 other tests pass); removing the watched-op fallback fails only its failure-discovery row (154 pass).

FAIL: an added regression probe leaves the failed-plan banner visible after Subscribe returns subscribed and status has no pending operation. A disposable invalidation control makes all 49 BillingTab tests, including the probe, pass. The PR source was not modified.

Ego browser: actual head component/composables in Storybook, controlled API fixtures. Reserved-tab checkout, one-request blocked-tab link fallback, keyboard activation, and local top-up/hidden-plan behavior pass. The successful-retry/stale-failure defect reproduces there too. Live payment-account/backend validation was NOT_RUN; these are fixture-based checks.

The parent 21468 findings remain with that PR. The Cloud-only plan gate matches Alex's latest Slack decision; local top-up banners remain intentional.

if (previous?.status === 'pending') {
return workspaceApi.getBillingOpStatus(previous.id)
}
return previous

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: [P2] Retire the old failed operation after a successful retry. Starting from a retryable failed operation, openCheckout() can receive { status: 'subscribed', billing_op_id: 'op-new' }. Its subsequent status read has no pending ID, so this branch returns the old failed operation unchanged. The banner still says "Your Creator plan didn't start" and offers Try again even though Subscribe just succeeded; later visibility refreshes retain it as well. I reproduced this in an added BillingTab regression probe and in Ego with the actual component/composables and controlled API responses (one successful Subscribe, two status reads, stale failure still visible). Please invalidate/supersede the old failure based on the new operation/result and add the successful-retry regression, while retaining the existing watched-pending-operation failure coverage.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

48f21dc drops a retained failed operation when Subscribe returns status: 'subscribed' with a different billing_op_id and the status read no longer carries a pending id. 9ae918b keeps that check outside checkout reopen so the complexity gate still passes.

): ServerFact<'subscription_checkout_state', SubscriptionCheckoutState> {
return pendingServerFact(
'BE-21811',
operation.status === 'failed' && operation.decline_reason

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: [P2] Render an authoritative subscription checkout state instead of constructing it here. This combines status, decline_reason, authentication_state, phase, and action_url into a new server-owned state. The generated operation contract does not define that combined classification: for example, it explicitly permits a pending failed_retryable intent with a decline reason, while this classifier only calls terminal failed operations failures. I read the disclosed BE-21811 dependency and the ticketed bridge rationale; pendingServerFact tracks expiry but still executes the same client-side policy. Please land the served checkout-state contract/generated type first and consume that field, rather than shipping this approximation. This is separate from presentation-only copy/ranking, which can remain on the client.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving the combination behind pendingServerFact('BE-21811'). checkout_state is on cloud main from BE-21925, and it is not in @comfyorg/ingest-types on this branch. A type-sync PR will switch this surface once the generated types include the field. I am not inventing the enum here.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for two current billing-operation blockers.

Full context for agent readers

A successful plan retry can leave the prior failed operation in memory after the status response drops its pending operation id. The Billing tab then keeps showing that the plan did not start and continues offering Try again after Subscribe succeeded.

The checkout banner also constructs a server-owned state from several operation fields even though the generated contract permits combinations that this classifier mislabels. The served checkout-state contract should land first, then this surface should consume that authoritative field.

The rebase and failed-top-up Add credits emphasis match the confirmed design. The two current inline threads carry the exact evidence and requested fixes, so I am not duplicating them here.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed 2222c85b18246138188075815a745fc0e58e4945, including the merged top-up emphasis and its adaptation to the combined checkout banner. The new emphasis matches the latest design decision; the two blockers in Christian's review remain current. COMMENT only because this is my own PR.

PASS: own frozen install; seven billing suites / 162 tests; app typecheck; Cloud build; touched-file Oxlint, format and source ESLint (the two test files are excluded by ESLint). Removing white emphasis fails exactly its two intended cases with 66 passing; forcing white everywhere fails five grey/control cases with 63 passing.

PASS in Ego with exact-head BillingCheckoutBanner and Credits card components under controlled Storybook/API fixtures: both buttons white for failed/0, secondary while processing or applying and with positive credit, one retry event, and no Add credits actions when permission is withheld. Actual parent wiring is covered by the executed BillingTab tests. This does not claim a live payment/account check.

FAIL: the successful-subscription retry regression probe still leaves the old failed-plan banner visible (1 failing probe; 50 unrelated cases filtered out). The retained failed operation and client-derived checkout state are unchanged; I am keeping the existing threads rather than duplicating findings. The parent PR's polling/reporting issues remain with 21468.

CI is still running without a failed check in the latest snapshot. No source changes or thread resolutions were made.

A status read with no pending operation was keeping the previous failure, so the Billing tab still offered Try again after the plan started.
…exity

The check that drops a superseded failure sits outside checkout reopen, so that reopen stays within the complexity gate.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed 9ae918b73cb5e2f0cb1162c759087f5355fe1832 against the previously reviewed 2222c85b18246138188075815a745fc0e58e4945, with latest main fetched. I read both new author replies and the full existing conversations. COMMENT only because this is my own PR.

PASS: the retained-failure defect in #21471 (comment) is addressed for the reported successful-retry path. Own frozen install, all seven billing suites / 163 tests, app typecheck, Cloud production build and touched-file type-aware Oxlint/format/source ESLint pass (ESLint excludes the test file). My previous independent regression probe now passes. Removing only the new retirement call in a disposable Vite transform fails the new successful-retry regression, with the other 50 BillingTab cases passing.

PASS in Ego: actual exact-head BillingCheckoutBanner/useSubscriptionCheckoutBanner with controlled API responses. One Subscribe returning subscribed removes the old failed banner; a subsequent simulated visibility return triggers another status read without restoring it. Observed one Subscribe, two status reads after retry and three after return. Live payment/account/backend validation remains NOT_RUN; this is controlled runtime evidence. No source edits or review-thread resolutions were made.

issue: the server-fact blocker in #21471 (comment) remains. The reply says BE-21925 has landed on cloud main but checkout_state is absent from this branch's generated package; I independently confirmed the latter. subscriptionCheckoutState still constructs the checkout state from status, decline_reason, authentication_state, phase and action_url. pendingServerFact does not change that runtime policy. Please land/stack the generated type sync and consume the served field before merging this surface, rather than accepting the bridge as an exception. The successful-retry fix does not clear this separate gate. Existing threads are retained without duplicate inline findings.

…into dante/fe-3467-subscribe-banners

# Conflicts:
#	src/platform/workspace/components/dialogs/settings/billing/BillingTab.test.ts
#	src/platform/workspace/components/dialogs/settings/billing/BillingTab.vue
@github-actions

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the parent-merge head and the subsequent formatting-only update, current e3f27f5c0e4504dc108141c237c16f7db936dcf9, stacked on parent c511b20ac25d288431bb24705e94e1d030b8e223. Latest main was fetched. COMMENT only on my own PR.

PASS on the current head: own frozen install, all seven billing suites / 179 tests, app typecheck, Cloud production build and changed-test formatting. The previous independent successful-retry probe also passes on the merge head. Removing the retirement call in a disposable transform on the current head fails only the successful-retry regression (1 failed / 59 passed).

PASS in Ego on the current head's actual checkout banner/composable with controlled API responses: one successful Subscribe removes the old failed banner, and returning to visibility performs another status read without reviving it. Observed one Subscribe and status-read counts of two then three. Live payment/account/backend checks remain NOT_RUN.

The successful-retry finding remains addressed. The separate server-fact gate at #21471 (comment) remains unresolved: the branch still classifies checkout state from multiple operation fields behind pendingServerFact instead of consuming the served checkout_state contract. The author's planned generated-type sync is still required before merging.

The parent fixes are now integrated. Its architecture issue and newly reproduced slow-read overlap remain tracked on #21468; the top-up composable here is byte-identical to that parent, so these parent concerns are inherited rather than duplicated inline on this PR. CI is running with no failed checks in the latest snapshot. No source edits or review-thread resolutions were made.

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Closing as superseded: the plan checkout banners shipped in #21708 (FE-3527, banners from checkout_state), which covers the Subscribe pending / clearing / declined states this PR added. The hosted top-up banners continue in #21468.

Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 26, 2026
…ling tab (Comfy-Org#21468)

## Summary

A hosted top-up paid with a slow method (bank debit, bank approval)
shows nothing in ComfyUI until the credits land, so an owner who
returns, reloads or switches device sees no sign the payment went
through and may pay again. The Billing tab now reads the served hosted
top-up facts (BE-21226) and shows the one DES-1267 banner for the state
the server reports.

- Linear:
[FE-3467](https://linear.app/comfyorg/issue/FE-3467/show-cross-device-top-up-payment-progress)
· Design: [DES-1267](https://linear.app/comfyorg/issue/DES-1267) (final)
· Priority: [DES-1234](https://linear.app/comfyorg/issue/DES-1234) ·
Backend: [BE-21183](https://linear.app/comfyorg/issue/BE-21183) /
[BE-21226](https://linear.app/comfyorg/issue/BE-21226)
(Comfy-Org/cloud#14023, Comfy-Org#14080, in staging v0.481.2)

### Why

Returning from Stripe, closing the tab or Stripe `complete` is not
settlement. Only `GET /api/billing/topup/checkouts/{id}` knows whether a
payment is still processing, paid and applying credits, fulfilled or
failed. Nothing in the app read it, so the in-between states were
invisible across reloads and devices.

### Root cause

The served `state` of each hosted top-up checkout was never read on the
client, so the only signal of a slow payment was credits eventually
landing.

### How

| Served `state` (detail read) | Banner | Actions | Amount |
| --- | --- | --- | --- |
| `payment_processing` | Payment processing · "…so you don't need to pay
again." | Dismiss | none (per Figma) |
| `credits_applying` | Payment received · "Your credits are being
added…" | Dismiss | none |
| `failed` (newest checkout only) | Your {amount} top-up didn't go
through | Dismiss, Add credits (only when `can_top_up`) |
`payment_amount_cents`; dropped when null |
| `open`, `expired`, `fulfilled` | nothing | | |

- `workspaceApi.listTopupCheckouts` / `getTopupCheckout` return the
generated `HostedTopupCheckoutList` / `HostedTopupCheckout` from
`@comfyorg/ingest-types`. The tab lists the first page (ten newest) and
reads each session independently; one unreadable session is reported
once and does not hide the others.
- `src/platform/billing/components/billingTab/topupCheckoutBanner.ts` is
a pure ranker: failed > credits applying > processing. A failed checkout
only speaks while it is the newest one started. Dismiss is per session
and state.
- `src/platform/billing/composables/useTopupCheckoutBanner.ts` reads
only while `can_manage_billing` is served (the endpoints are
owner-only). It re-reads when the tab becomes visible, polls every 5 s
while any checkout is `credits_applying`, never overlaps reads, and
queues one trailing read when a refresh is asked for during an in-flight
read.
- `BillingTopupCheckoutBanner.vue` is presentational and mounted in
`BillingTab.vue` next to main's `BillingPlanCheckoutBanner` (FE-3527).
Like the plan banner it suppresses `BillingLocalCreditBanner`, whose
auto top-up and credit kinds rank below it.
- Banner Add credits reports `settings_billing_panel`; the credits card
keeps `credits_panel`. Both Add credits buttons turn `inverted` only
when Available is 0 and the shown banner is a failed top-up.
- `amount_cents` is never shown: it is the credit size before
promotions, not the payment.

No server fact is derived on the client and none is missing for these
three banners.

### Scope and follow-ups (split)

- This PR: top-up banners on the Billing tab.
- Follow-up: the credits flyout line and the Add credits dialog notice
from DES-1267.
- Plan checkout banners were split to Comfy-Org#21471, which was closed as
superseded by Comfy-Org#21708 (FE-3527, merged). This PR sits next to that
banner.

### Plan position

| Item | Ticket | PR | Status |
| --- | --- | --- | --- |
| Hosted top-up storage + supersede runtime | BE-21218 / BE-21225 |
Comfy-Org/cloud#14069, Comfy-Org#14080 | Merged |
| Hosted top-up read API | BE-21226 | Comfy-Org/cloud#14023 | Merged
(staging) |
| Banner design | DES-1267 | | Final |
| **Top-up banners on the Billing tab** | **FE-3467** | **this PR** |
**Open** |
| Plan checkout banners | FE-3527 | Comfy-Org#21708 (supersedes Comfy-Org#21471) | Merged
|
| Credits flyout line + Add credits dialog notice | DES-1267 follow-up |
| Next |

```mermaid
graph LR
  BE["BE-21226 read API"] --> TOP["FE-3467 top-up banners (this PR)"]
  DES["DES-1267 design"] --> TOP
  PLAN["FE-3527 plan checkout banners Comfy-Org#21708"] --> TOP
  TOP --> FLY["Flyout + dialog notice"]
  style TOP fill:#f9d71c,stroke:Comfy-Org#333,color:#000
```

## Verification

- Rebased onto main: files now live in
`src/platform/billing/components/billingTab/` and
`src/platform/billing/composables/`.
- `pnpm exec vitest run src/platform/billing/components/billingTab/`: 10
files, 208 tests pass. New: the visibility-during-in-flight-read
regression fails without the queued refresh (1 failed / 56 passed).
- `oxfmt` and `oxlint --type-aware` on touched files; pre-commit hook.
- `fallow audit --base origin/main`: one introduced boundary finding,
`BillingTopupCheckoutBanner.vue` → `Button.vue` (billing/presentation →
design-system/presentation). Every billing component on main makes the
same import and no public entry point exists, so it needs a billing
domain record decision, not a code change. The composable's
`workspaceApi` / `reportError` and the ranker's type import no longer
cross a boundary.

### AS IS / TO BE

Captured from the running app (dev server on `origin/main` vs this
branch at `ea9314acb9`, cloud distribution, real testcloud backend
signed in as a workspace owner, `ff:unified_billing_settings` = `true`).
The account has no hosted top-up checkouts (`GET
/api/billing/topup/checkouts` returns `[]`), so the list and detail
reads are **state forced with a response override** (one
`cs_test_forced1` checkout, `payment_amount_cents: 2500`). Every other
read is the real response. Nothing was clicked.

| AS IS (main), a payment is processing | TO BE: `payment_processing` |
| --- | --- |
| <img width="560" alt="AS IS no banner"
src="https://github.com/user-attachments/assets/b06bab47-a219-42a7-9cb7-4aa6226a9ade"
/> | <img width="560" alt="TO BE processing"
src="https://github.com/user-attachments/assets/98dc9468-822a-411e-90a0-361e3e87edb1"
/> |
| No banner | Payment processing banner with Dismiss |

| TO BE: `credits_applying` | TO BE: `failed`, `payment_amount_cents:
2500` |
| --- | --- |
| <img width="560" alt="TO BE credits applying"
src="https://github.com/user-attachments/assets/28ff32c4-0053-4ba7-a294-62a5cf1073b6"
/> | <img width="560" alt="TO BE failed"
src="https://github.com/user-attachments/assets/4395364e-0864-41d5-ac55-ffc66c82a661"
/> |
| Payment received banner | "Your $25 top-up didn't go through" with
Dismiss and Add credits |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.58 Backport PRs for cloud 1.58 core/1.58 Backport PRs for core 1.58 needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants