Skip to content

[backport cloud/1.58] fix: resolve the multiline widget store id from its current name - #21436

Merged
comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-21293-to-cloud-1.58
Oct 21, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-21293-to-cloud-1.58

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #21293 to cloud/1.58

Automatically created by backport workflow.

)

## Summary

`addMultilineWidget` built its `getValue` / `setValue` closures around
the widget name it was created with. When a DynamicGroup row shift
renames the widget, the widget's name setter moves its store entry to
the new id, but the textarea kept reading and writing the old one. After
a middle row was removed, `loras.1.text` would still edit
`loras.2.text`, and its writes could register an orphan entry that
blocks a later rename into that slot.

The closures now resolve the store id from the widget's current name.
They find the widget instance once, by its textarea element, while
`addDOMWidget` is still adding it, when `ensureUniqueWidgetNames` may
already have renamed a duplicate (for example `prompt` to `prompt#1`).
After that they keep the instance, so a replaced `element` doesn't
matter. They also remember the `WidgetState` they last resolved, which
`renameWidget` carries across renames. A widget counts as detached only
when it is out of `node.widgets` and the entry at its id is no longer
that state (deleted by `removeWidget`, or now owned by another widget).
A detached widget reads and writes only its textarea. A widget an
extension merely splices out keeps writing its own entry.

This latent bug affects any DynamicGroup row with a multiline STRING
field. No shipped node uses one yet.

- Fixes #21093
- Follow-up: #21323 (the widget can't yet tell whether the store entry
it resolves is its own after removal or replacement)

## Red-Green Verification

| Commit | CI Status | Purpose |
|--------|-----------|---------|
| `test: resolve a renamed multiline widget's store entry by its current
name` (f7d6fc4) | 🔴
[Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39136256024)
| Proves the test catches the bug |
| `fix: resolve the multiline widget store id from its current name`
(606901d) | 🟢
[Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39137177712)
| Proves the fix resolves the bug |
| `test: cover a multiline widget renamed to a unique name while it is
added` (e8161b0) | 🔴
[Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39139714397)
| A duplicate renamed during construction read its sibling's entry |
| `fix: find the multiline widget by its element while it is being
added` (d412e9d) | 🟢
[Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39140649304)
| The current name is used during construction too |
| `test: keep a multiline widget's store entry after it leaves the
widget list` (077cf90) | 🔴
[Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39143211120)
| A removed widget fell back to its creation name and read the sibling's
entry |
| `fix: keep the last resolved name when the multiline widget is not in
the list` (4ac4f9f) | 🟢
[Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39143923582)
| The last resolved name is kept |
| `test: leave the store alone after a removed multiline widget's name
is reused` (6754ed0) | 🔴
[Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39146616716)
| A removed widget's cached name pointed at the widget that reused it |
| `fix: stop using the store once the multiline widget leaves its node`
(76d45d6) | 🟢
[Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39147540180)
| A detached widget no longer reads or writes the store |
| `test: keep a spliced-out or re-elemented multiline widget on its own
entry` (c9ef031) | 🔴
[Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39150497995)
| Splicing out or replacing the element stopped store writes |
| `fix: track the multiline widget's own store entry instead of its
listing` (1fd6eee) | 🟢
[Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39151317338)
| Detachment is decided by state identity |

## Test Plan

- [x] CI red on test-only commit (only the new rename case fails)
- [x] CI green on fix commit
- Unit, on a real `LGraph` node: after a rename through the `BaseWidget`
name setter, writes land on the moved entry and nothing is left under
the old name. A multiline widget whose duplicate name is made unique
while it is added starts from its own default and leaves the sibling's
entry alone, keeps writing its own entry while spliced out or after its
element is replaced, and once removed neither reads nor overwrites the
entry of a widget that later takes its name. The existing case where a
saved value is restored synchronously during construction still passes.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 20, 2026
@comfy-pr-bot
comfy-pr-bot requested a review from a team as a code owner October 20, 2026 09:54
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 20, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) October 20, 2026 09:54
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 91.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.6 MB heap
dom-widget-order-dense-n200-w200-i120: · 31.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 506ms TBT · 97.5 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 43.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 144ms TBT · 92.6 MB heap
extension-clean-combined-draw: · 38.7 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 128ms TBT · 115.2 MB heap
extension-rgthree-prototype-draw: · 39.6 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 156ms TBT · 131.6 MB heap
large-combo-open: · 45.6 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 112.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 97.1 MB heap
large-graph-pan: · 59.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.3 MB heap
large-graph-zoom: · 59.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 105.3 MB heap
legacy-node-drag: · 59.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 116.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 103.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-transition-enter: · 51.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 136ms TBT · 131.6 MB heap
viewport-pan-sweep: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.6 MB heap
vue-large-graph-idle: · 32.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 257.8 MB heap
vue-large-graph-pan: · 29.2 avg FPS · 13.3 P5 FPS ❌ (target: ≥52) · 8ms TBT · 280.2 MB heap
vue-node-resize-workload: · 26.6 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 4ms TBT · 265.5 MB heap
vue-zoom-out-idle: · 39.0 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 260.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 97.0 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.3 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 111.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 2ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 10
canvas-idle: style recalc count 10
canvas-idle: task duration 501ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 91.9 MB
canvas-idle: DOM nodes -90
canvas-idle: event listeners -65
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 10ms
canvas-mouse-sweep: layout count 9
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 771ms
canvas-mouse-sweep: script duration 121ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 88.0 MB
canvas-mouse-sweep: DOM nodes -90
canvas-mouse-sweep: event listeners -62
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 13
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 312ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 99.7 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 2ms
dom-widget-clipping: layout count 9
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 367ms
dom-widget-clipping: script duration 138ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.6 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 32ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 850ms
dom-widget-order-dense-n200-w200-i120: script duration 55ms
dom-widget-order-dense-n200-w200-i120: TBT 506ms
dom-widget-order-dense-n200-w200-i120: heap used 97.5 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -220
dom-widget-order-dense-n200-w200-i120: event listeners -168
dom-widget-order-sparse-n1000-w20-i120: avg frame time 23ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 375ms
dom-widget-order-sparse-n1000-w20-i120: script duration 116ms
dom-widget-order-sparse-n1000-w20-i120: TBT 144ms
dom-widget-order-sparse-n1000-w20-i120: heap used 92.6 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 26ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 1
extension-clean-combined-draw: style recalc count 2
extension-clean-combined-draw: task duration 7451ms
extension-clean-combined-draw: script duration 5870ms
extension-clean-combined-draw: TBT 128ms
extension-clean-combined-draw: heap used 115.2 MB
extension-clean-combined-draw: DOM nodes -286
extension-clean-combined-draw: event listeners -130
extension-rgthree-prototype-draw: avg frame time 25ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 2
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 7050ms
extension-rgthree-prototype-draw: script duration 5510ms
extension-rgthree-prototype-draw: TBT 156ms
extension-rgthree-prototype-draw: heap used 131.6 MB
extension-rgthree-prototype-draw: DOM nodes -276
extension-rgthree-prototype-draw: event listeners -130
large-combo-open: avg frame time 22ms
large-combo-open: p95 frame time 58ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 13ms
large-combo-open: layout count 12
large-combo-open: style recalc count 24
large-combo-open: task duration 155ms
large-combo-open: script duration 8ms
large-combo-open: TBT 0ms
large-combo-open: heap used 112.8 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 9
large-graph-idle: task duration 591ms
large-graph-idle: script duration 30ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 97.1 MB
large-graph-idle: DOM nodes -277
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 1ms
large-graph-pan: style recalc duration 7ms
large-graph-pan: layout count 7
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1493ms
large-graph-pan: script duration 689ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 92.3 MB
large-graph-pan: DOM nodes -286
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 65
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1487ms
large-graph-zoom: script duration 664ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 105.3 MB
large-graph-zoom: DOM nodes -124
large-graph-zoom: event listeners -65
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 2ms
legacy-node-drag: style recalc duration 4ms
legacy-node-drag: layout count 7
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1468ms
legacy-node-drag: script duration 768ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 116.1 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 8
minimap-idle: style recalc count 8
minimap-idle: task duration 530ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 99.3 MB
minimap-idle: DOM nodes -286
minimap-idle: event listeners -130
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 4ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 369ms
subgraph-dom-widget-clipping: script duration 123ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 103.9 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 11
subgraph-idle: task duration 509ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 88.4 MB
subgraph-idle: DOM nodes -109
subgraph-idle: event listeners -88
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 12ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 798ms
subgraph-mouse-sweep: script duration 87ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 83.7 MB
subgraph-mouse-sweep: DOM nodes -210
subgraph-mouse-sweep: event listeners -174
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 20ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 909ms
subgraph-transition-enter: script duration 41ms
subgraph-transition-enter: TBT 136ms
subgraph-transition-enter: heap used 131.6 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 27ms
viewport-pan-sweep: layout count 7
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4566ms
viewport-pan-sweep: script duration 2253ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 101.6 MB
viewport-pan-sweep: DOM nodes -287
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 31ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17126ms
vue-large-graph-idle: script duration 244ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 257.8 MB
vue-large-graph-idle: DOM nodes -3354
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 34ms
vue-large-graph-pan: p95 frame time 75ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 125
vue-large-graph-pan: task duration 18660ms
vue-large-graph-pan: script duration 790ms
vue-large-graph-pan: TBT 8ms
vue-large-graph-pan: heap used 280.2 MB
vue-large-graph-pan: DOM nodes -3344
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 38ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 61ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6356ms
vue-node-resize-workload: script duration 110ms
vue-node-resize-workload: TBT 4ms
vue-node-resize-workload: heap used 265.5 MB
vue-node-resize-workload: DOM nodes -3344
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 26ms
vue-zoom-out-idle: p95 frame time 42ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7101ms
vue-zoom-out-idle: script duration 104ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 260.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 7ms
workflow-execution: layout count 8
workflow-execution: style recalc count 8
workflow-execution: task duration 76ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 97.0 MB
workflow-execution: DOM nodes 120
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 14ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 333ms
agent-composer-empty-conversation-typing: script duration 156ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 85.3 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 13ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 391ms
agent-composer-long-conversation-typing: script duration 153ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 111.5 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-20T10:06:58.959Z",
  "gitSha": "2dfa883a52d0b02a8917367b025144e443b2d1ab",
  "branch": "backport-21293-to-cloud-1.58",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2008.542000000034,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.0149999999999992,
      "layouts": 9,
      "layoutDurationMs": 1.9259999999999997,
      "taskDurationMs": 473.30300000000005,
      "heapDeltaBytes": 5059700,
      "heapUsedBytes": 97389132,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 9.610999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2026.1659999999893,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.1870000000000003,
      "layouts": 10,
      "layoutDurationMs": 2.234,
      "taskDurationMs": 528.332,
      "heapDeltaBytes": -11014888,
      "heapUsedBytes": 95302716,
      "domNodes": -180,
      "jsHeapTotalBytes": 5906432,
      "scriptDurationMs": 9.661,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1710.5049999998982,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 10.414,
      "layouts": 9,
      "layoutDurationMs": 1.8169999999999997,
      "taskDurationMs": 731.6310000000001,
      "heapDeltaBytes": -1960656,
      "heapUsedBytes": 90443384,
      "domNodes": 0,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 118.95800000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666990291262135,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1774.3750000000773,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 10.540000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.0509999999999997,
      "taskDurationMs": 809.5699999999999,
      "heapDeltaBytes": -9744104,
      "heapUsedBytes": 94089844,
      "domNodes": -180,
      "jsHeapTotalBytes": 1679360,
      "scriptDurationMs": 122.446,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66603773584906,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1727.025000000026,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.49,
      "layouts": 12,
      "layoutDurationMs": 2.437,
      "taskDurationMs": 277.37500000000006,
      "heapDeltaBytes": 4627384,
      "heapUsedBytes": 103403676,
      "domNodes": 47,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 10.418000000000001,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1792.3620000000255,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 5.206,
      "layouts": 13,
      "layoutDurationMs": 3.073,
      "taskDurationMs": 345.84499999999997,
      "heapDeltaBytes": 1826804,
      "heapUsedBytes": 105584980,
      "domNodes": 47,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 10.863000000000001,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 550.8859999999913,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.248,
      "layouts": 9,
      "layoutDurationMs": 2.1870000000000003,
      "taskDurationMs": 373.40000000000003,
      "heapDeltaBytes": -237124,
      "heapUsedBytes": 88588356,
      "domNodes": 0,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 141.547,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663636363636368,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 532.2270000000344,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 2.0740000000000003,
      "layouts": 9,
      "layoutDurationMs": 1.697,
      "taskDurationMs": 359.627,
      "heapDeltaBytes": -175188,
      "heapUsedBytes": 88876116,
      "domNodes": 0,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 135.406,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66562499999999,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1248.644000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 883.8710000000001,
      "heapDeltaBytes": -2329624,
      "heapUsedBytes": 102314300,
      "domNodes": -210,
      "jsHeapTotalBytes": 10371072,
      "scriptDurationMs": 57.58799999999999,
      "eventListeners": -168,
      "totalBlockingTimeMs": 566,
      "frameDurationMs": 33.78108108108108,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1132.5019999999313,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 816.4309999999999,
      "heapDeltaBytes": -15042832,
      "heapUsedBytes": 102198460,
      "domNodes": -230,
      "jsHeapTotalBytes": 15581184,
      "scriptDurationMs": 51.77799999999999,
      "eventListeners": -168,
      "totalBlockingTimeMs": 446,
      "frameDurationMs": 30.627027027027022,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 777.8439999999591,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 394.68799999999993,
      "heapDeltaBytes": -3860332,
      "heapUsedBytes": 97190376,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 117.46099999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 147,
      "frameDurationMs": 23.038235294117626,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 762.960000000021,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.67199999999974,
      "heapDeltaBytes": -4238396,
      "heapUsedBytes": 96926784,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 114.64100000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 22.547058823529397,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 8925.033999999981,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8029.762,
      "heapDeltaBytes": -11353348,
      "heapUsedBytes": 113077680,
      "domNodes": -276,
      "jsHeapTotalBytes": 16916480,
      "scriptDurationMs": 6251.313,
      "eventListeners": -130,
      "totalBlockingTimeMs": 136,
      "frameDurationMs": 25.76965317919075,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7687.343000000055,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.6310000000000004,
      "layouts": 2,
      "layoutDurationMs": 0.43500000000000005,
      "taskDurationMs": 6872.445,
      "heapDeltaBytes": 6677860,
      "heapUsedBytes": 128475316,
      "domNodes": -296,
      "jsHeapTotalBytes": 31825920,
      "scriptDurationMs": 5487.731,
      "eventListeners": -130,
      "totalBlockingTimeMs": 119,
      "frameDurationMs": 25.868686868686872,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 8168.500999999992,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.6129999999999999,
      "layouts": 2,
      "layoutDurationMs": 0.43500000000000005,
      "taskDurationMs": 7302.223,
      "heapDeltaBytes": 7345336,
      "heapUsedBytes": 129074232,
      "domNodes": -276,
      "jsHeapTotalBytes": 32874496,
      "scriptDurationMs": 5606.384999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 191,
      "frameDurationMs": 24.97308868501529,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7579.66399999998,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.3480000000000002,
      "layouts": 2,
      "layoutDurationMs": 0.34,
      "taskDurationMs": 6797.779,
      "heapDeltaBytes": 25051872,
      "heapUsedBytes": 146829980,
      "domNodes": -276,
      "jsHeapTotalBytes": 27107328,
      "scriptDurationMs": 5412.941999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 120,
      "frameDurationMs": 25.475757575757576,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-combo-open",
      "durationMs": 203.83300000003146,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 13.383,
      "layouts": 11,
      "layoutDurationMs": 2.849,
      "taskDurationMs": 149.19299999999996,
      "heapDeltaBytes": 13187304,
      "heapUsedBytes": 118114452,
      "domNodes": 917,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.018,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 22.22222222222222,
      "p95FrameDurationMs": 66.69999999999982
    },
    {
      "name": "large-combo-open",
      "durationMs": 217.6609999999073,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 12.767999999999999,
      "layouts": 12,
      "layoutDurationMs": 3.165,
      "taskDurationMs": 160.59,
      "heapDeltaBytes": 13251584,
      "heapUsedBytes": 118353912,
      "domNodes": 917,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 7.958999999999999,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.660000000000036,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.251000000012,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.7460000000000002,
      "layouts": 8,
      "layoutDurationMs": 1.8900000000000001,
      "taskDurationMs": 601.677,
      "heapDeltaBytes": 3185200,
      "heapUsedBytes": 105493176,
      "domNodes": -276,
      "jsHeapTotalBytes": -4874240,
      "scriptDurationMs": 30.705000000000002,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.2069999999194,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.5899999999999994,
      "layouts": 8,
      "layoutDurationMs": 1.6589999999999998,
      "taskDurationMs": 579.959,
      "heapDeltaBytes": -5546112,
      "heapUsedBytes": 98121392,
      "domNodes": -277,
      "jsHeapTotalBytes": -1171456,
      "scriptDurationMs": 29.198999999999995,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66475409836065,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2190.958999999907,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 7.210999999999999,
      "layouts": 7,
      "layoutDurationMs": 1.244,
      "taskDurationMs": 1468.4830000000002,
      "heapDeltaBytes": 1535016,
      "heapUsedBytes": 104349344,
      "domNodes": -276,
      "jsHeapTotalBytes": -1241088,
      "scriptDurationMs": 674.96,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66564885496183,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2222.6530000000366,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 6.964,
      "layouts": 6,
      "layoutDurationMs": 1.3300000000000003,
      "taskDurationMs": 1517.1619999999998,
      "heapDeltaBytes": -16923616,
      "heapUsedBytes": 89114480,
      "domNodes": -296,
      "jsHeapTotalBytes": -1097728,
      "scriptDurationMs": 703.3699999999999,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.920610687022897,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3437.7960000000485,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 9.372,
      "layouts": 64,
      "layoutDurationMs": 10.436999999999998,
      "taskDurationMs": 1612.5220000000002,
      "heapDeltaBytes": 2977248,
      "heapUsedBytes": 108811164,
      "domNodes": -272,
      "jsHeapTotalBytes": -548864,
      "scriptDurationMs": 678.597,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.747317073170734,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3324.386000000004,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 9.873999999999999,
      "layouts": 66,
      "layoutDurationMs": 10.955000000000002,
      "taskDurationMs": 1361.1519999999998,
      "heapDeltaBytes": 7164692,
      "heapUsedBytes": 112093236,
      "domNodes": 24,
      "jsHeapTotalBytes": 4198400,
      "scriptDurationMs": 649.8629999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.749999999999996,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2257.6799999999366,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 4.5,
      "layouts": 8,
      "layoutDurationMs": 1.7249999999999999,
      "taskDurationMs": 1479.876,
      "heapDeltaBytes": 15596412,
      "heapUsedBytes": 119923584,
      "domNodes": 0,
      "jsHeapTotalBytes": 5402624,
      "scriptDurationMs": 778.6299999999999,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.791044776119403,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2301.764999999932,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.454000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.3159999999999998,
      "taskDurationMs": 1455.172,
      "heapDeltaBytes": 17380428,
      "heapUsedBytes": 123647296,
      "domNodes": 0,
      "jsHeapTotalBytes": 6451200,
      "scriptDurationMs": 758.1220000000001,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.786861313868613,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2027.680999999916,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.45,
      "layouts": 7,
      "layoutDurationMs": 1.528,
      "taskDurationMs": 594.2749999999999,
      "heapDeltaBytes": -16454164,
      "heapUsedBytes": 97404936,
      "domNodes": -296,
      "jsHeapTotalBytes": -3006464,
      "scriptDurationMs": 29.454,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.9509999999218,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.6940000000000002,
      "layouts": 8,
      "layoutDurationMs": 1.6380000000000001,
      "taskDurationMs": 465.5339999999999,
      "heapDeltaBytes": 8167844,
      "heapUsedBytes": 110910968,
      "domNodes": -276,
      "jsHeapTotalBytes": -5660672,
      "scriptDurationMs": 33.59,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666664,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 531.9909999999481,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 4.566,
      "layouts": 10,
      "layoutDurationMs": 2.3890000000000002,
      "taskDurationMs": 350.137,
      "heapDeltaBytes": 3837980,
      "heapUsedBytes": 105042612,
      "domNodes": 0,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 123.70299999999999,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 556.8759999999884,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 4.209,
      "layouts": 9,
      "layoutDurationMs": 1.9939999999999998,
      "taskDurationMs": 387.83700000000005,
      "heapDeltaBytes": 22930452,
      "heapUsedBytes": 112929596,
      "domNodes": 0,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 122.972,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66470588235295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2040.3740000000425,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.4020000000000006,
      "layouts": 10,
      "layoutDurationMs": 2.6449999999999996,
      "taskDurationMs": 550.38,
      "heapDeltaBytes": -16756972,
      "heapUsedBytes": 89441012,
      "domNodes": -218,
      "jsHeapTotalBytes": 1941504,
      "scriptDurationMs": 8.88,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.7810000000327,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.7659999999999996,
      "layouts": 10,
      "layoutDurationMs": 2.1600000000000006,
      "taskDurationMs": 466.7300000000001,
      "heapDeltaBytes": 3527692,
      "heapUsedBytes": 95956744,
      "domNodes": 0,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 8.481,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1760.84400000002,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 11.135,
      "layouts": 9,
      "layoutDurationMs": 2.1500000000000004,
      "taskDurationMs": 778.124,
      "heapDeltaBytes": -3095356,
      "heapUsedBytes": 87225524,
      "domNodes": -210,
      "jsHeapTotalBytes": -1204224,
      "scriptDurationMs": 85.725,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66603773584906,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1878.614999999968,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 11.967,
      "layouts": 10,
      "layoutDurationMs": 2.017,
      "taskDurationMs": 817.167,
      "heapDeltaBytes": -17990776,
      "heapUsedBytes": 88314764,
      "domNodes": -210,
      "jsHeapTotalBytes": 2727936,
      "scriptDurationMs": 87.92999999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66637168141593,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.1179999999968,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 20.468,
      "layouts": 5,
      "layoutDurationMs": 10.762999999999998,
      "taskDurationMs": 909.4849999999999,
      "heapDeltaBytes": 36030720,
      "heapUsedBytes": 138016156,
      "domNodes": 16030,
      "jsHeapTotalBytes": 7217152,
      "scriptDurationMs": 40.628,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 136,
      "frameDurationMs": 19.40684931506849,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8233.776000000034,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 26.164,
      "layouts": 7,
      "layoutDurationMs": 1.7630000000000001,
      "taskDurationMs": 4577.616,
      "heapDeltaBytes": 2593192,
      "heapUsedBytes": 104224268,
      "domNodes": -277,
      "jsHeapTotalBytes": -454656,
      "scriptDurationMs": 2257.758,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.733739837398375,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8200.34899999996,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 27.168,
      "layouts": 6,
      "layoutDurationMs": 1.395,
      "taskDurationMs": 4553.802,
      "heapDeltaBytes": 6215672,
      "heapUsedBytes": 108877944,
      "domNodes": -296,
      "jsHeapTotalBytes": -978944,
      "scriptDurationMs": 2247.972,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.734081632653062,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18310.165999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17189.502999999997,
      "heapDeltaBytes": -58240320,
      "heapUsedBytes": 270813400,
      "domNodes": -3344,
      "jsHeapTotalBytes": 15192064,
      "scriptDurationMs": 240.55099999999996,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 31.227303754266213,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18188.20200000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17061.983,
      "heapDeltaBytes": -42432232,
      "heapUsedBytes": 269924312,
      "domNodes": -3364,
      "jsHeapTotalBytes": 14667776,
      "scriptDurationMs": 248.41599999999997,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.558991596638652,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22269.72000000001,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 19.426,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21872.565000000002,
      "heapDeltaBytes": -18646560,
      "heapUsedBytes": 285906324,
      "domNodes": -3344,
      "jsHeapTotalBytes": 14405632,
      "scriptDurationMs": 831.847,
      "eventListeners": -651,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 40.77985347985348,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15989.72100000003,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 10.94400000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15447.095999999998,
      "heapDeltaBytes": -22044352,
      "heapUsedBytes": 301796216,
      "domNodes": -3344,
      "jsHeapTotalBytes": 15192064,
      "scriptDurationMs": 747.888,
      "eventListeners": -651,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 27.805555555555554,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6521.590999999944,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 50.299000000000014,
      "layouts": 20,
      "layoutDurationMs": 20.732,
      "taskDurationMs": 6406.775,
      "heapDeltaBytes": -29854096,
      "heapUsedBytes": 280318112,
      "domNodes": -3344,
      "jsHeapTotalBytes": 17551360,
      "scriptDurationMs": 97.908,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 38.10818713450293,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6419.304000000011,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 70.72399999999998,
      "layouts": 20,
      "layoutDurationMs": 32.660999999999994,
      "taskDurationMs": 6304.941000000001,
      "heapDeltaBytes": -34020876,
      "heapUsedBytes": 276502768,
      "domNodes": -3344,
      "jsHeapTotalBytes": 13881344,
      "scriptDurationMs": 122.963,
      "eventListeners": -653,
      "totalBlockingTimeMs": 7,
      "frameDurationMs": 37.08901734104046,
      "p95FrameDurationMs": 66.79999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9107.316999999966,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8519.764999999998,
      "heapDeltaBytes": -3846900,
      "heapUsedBytes": 264457440,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 126.934,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.231229235880406,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6145.619000000011,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5681.984999999999,
      "heapDeltaBytes": 10305356,
      "heapUsedBytes": 281165180,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 81.93000000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.989078498293512,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "workflow-execution",
      "durationMs": 124.21999999992295,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.649,
      "layouts": 9,
      "layoutDurationMs": 3.0959999999999996,
      "taskDurationMs": 81.596,
      "heapDeltaBytes": 4836260,
      "heapUsedBytes": 97049648,
      "domNodes": 123,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 9.078,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.657142857142844,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 94.25900000007914,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.481,
      "layouts": 7,
      "layoutDurationMs": 2.5260000000000002,
      "taskDurationMs": 71.06999999999998,
      "heapDeltaBytes": 4571756,
      "heapUsedBytes": 106437532,
      "domNodes": 116,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.097999999999999,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 376.01900000004207,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.6679999999999999,
      "layouts": 76,
      "layoutDurationMs": 14.352,
      "taskDurationMs": 328.009,
      "heapDeltaBytes": -14354000,
      "heapUsedBytes": 77437448,
      "domNodes": 4,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 151.974,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66818181818181,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 389.60499999984677,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.7380000000000001,
      "layouts": 76,
      "layoutDurationMs": 13.544,
      "taskDurationMs": 337.078,
      "heapDeltaBytes": 11459048,
      "heapUsedBytes": 101470772,
      "domNodes": 4,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 159.124,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 433.7869999999384,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.571,
      "layouts": 76,
      "layoutDurationMs": 13.520000000000001,
      "taskDurationMs": 394.61800000000005,
      "heapDeltaBytes": 61124,
      "heapUsedBytes": 117319828,
      "domNodes": 4,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 155.218,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66296296296295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 429.94400000020505,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.538,
      "layouts": 76,
      "layoutDurationMs": 12.639,
      "taskDurationMs": 386.835,
      "heapDeltaBytes": -146064,
      "heapUsedBytes": 116489708,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 151.629,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66538461538459,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Line coverage: 63.9%

Coverage totals
Metric Covered Total Pct
Lines 56861 88943 63.9% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.5% 1166
src/LGraphNode.ts 70.6% 388
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 1.1% 266
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.0% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 46.6% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 2952 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2271 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 652 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/20/2026, 09:56:59 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since b168d1b61d1ac6a80a6ec2f5d246ffe1d57a05d9

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (111)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 61 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@github-actions
github-actions Bot requested a review from thedatalife October 20, 2026 09:55
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.58   #21436   +/-   ##
=============================================
  Coverage              ?   87.04%           
=============================================
  Files                 ?     2732           
  Lines                 ?   151459           
  Branches              ?    41292           
=============================================
  Hits                  ?   131832           
  Misses                ?    19237           
  Partials              ?      390           
Flag Coverage Δ
e2e 64.04% <100.00%> (?)
unit 85.72% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ns/vueNodes/widgets/composables/useStringWidget.ts 98.03% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 8ee7a78 into cloud/1.58 Oct 21, 2026
142 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-21293-to-cloud-1.58 branch October 21, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants