Repository navigation
[backport core/1.58] fix: resolve the multiline widget store id from its current name - #21435
Conversation
) ## Summary `addMultilineWidget` built its `getValue` / `setValue` closures around the widget name it was created with. When a DynamicGroup row shift renames the widget, the widget's name setter moves its store entry to the new id, but the textarea kept reading and writing the old one. After a middle row was removed, `loras.1.text` would still edit `loras.2.text`, and its writes could register an orphan entry that blocks a later rename into that slot. The closures now resolve the store id from the widget's current name. They find the widget instance once, by its textarea element, while `addDOMWidget` is still adding it, when `ensureUniqueWidgetNames` may already have renamed a duplicate (for example `prompt` to `prompt#1`). After that they keep the instance, so a replaced `element` doesn't matter. They also remember the `WidgetState` they last resolved, which `renameWidget` carries across renames. A widget counts as detached only when it is out of `node.widgets` and the entry at its id is no longer that state (deleted by `removeWidget`, or now owned by another widget). A detached widget reads and writes only its textarea. A widget an extension merely splices out keeps writing its own entry. This latent bug affects any DynamicGroup row with a multiline STRING field. No shipped node uses one yet. - Fixes #21093 - Follow-up: #21323 (the widget can't yet tell whether the store entry it resolves is its own after removal or replacement) ## Red-Green Verification | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: resolve a renamed multiline widget's store entry by its current name` (f7d6fc4) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39136256024) | Proves the test catches the bug | | `fix: resolve the multiline widget store id from its current name` (606901d) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39137177712) | Proves the fix resolves the bug | | `test: cover a multiline widget renamed to a unique name while it is added` (e8161b0) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39139714397) | A duplicate renamed during construction read its sibling's entry | | `fix: find the multiline widget by its element while it is being added` (d412e9d) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39140649304) | The current name is used during construction too | | `test: keep a multiline widget's store entry after it leaves the widget list` (077cf90) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39143211120) | A removed widget fell back to its creation name and read the sibling's entry | | `fix: keep the last resolved name when the multiline widget is not in the list` (4ac4f9f) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39143923582) | The last resolved name is kept | | `test: leave the store alone after a removed multiline widget's name is reused` (6754ed0) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39146616716) | A removed widget's cached name pointed at the widget that reused it | | `fix: stop using the store once the multiline widget leaves its node` (76d45d6) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39147540180) | A detached widget no longer reads or writes the store | | `test: keep a spliced-out or re-elemented multiline widget on its own entry` (c9ef031) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39150497995) | Splicing out or replacing the element stopped store writes | | `fix: track the multiline widget's own store entry instead of its listing` (1fd6eee) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39151317338) | Detachment is decided by state identity | ## Test Plan - [x] CI red on test-only commit (only the new rename case fails) - [x] CI green on fix commit - Unit, on a real `LGraph` node: after a rename through the `BaseWidget` name setter, writes land on the moved entry and nothing is left under the old name. A multiline widget whose duplicate name is made unique while it is added starts from its own default and leaves the sibling's entry alone, keeps writing its own entry while spliced out or after its element is replaced, and once removed neither reads nor overwrites the entry of a widget that later takes its name. The existing case where a saved value is restored synchronously during construction still passes.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-20T10:08:19.358Z",
"gitSha": "3efaaf33c633e2ce0271a3369df497334f5fa949",
"branch": "backport-21293-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.682999999991,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9900000000000007,
"layouts": 8,
"layoutDurationMs": 2.8970000000000002,
"taskDurationMs": 644.636,
"heapDeltaBytes": 3133284,
"heapUsedBytes": 94852960,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 13.634,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2055.4260000000113,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.291999999999999,
"layouts": 9,
"layoutDurationMs": 3.1780000000000004,
"taskDurationMs": 538.6990000000001,
"heapDeltaBytes": -13657028,
"heapUsedBytes": 90639356,
"domNodes": -200,
"jsHeapTotalBytes": 1941504,
"scriptDurationMs": 14.895999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.2320000000168,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.378999999999998,
"layouts": 10,
"layoutDurationMs": 3.2310000000000003,
"taskDurationMs": 833.4019999999999,
"heapDeltaBytes": -8263976,
"heapUsedBytes": 90895900,
"domNodes": -200,
"jsHeapTotalBytes": 7446528,
"scriptDurationMs": 172.16500000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1937.6340000000027,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.693999999999999,
"layouts": 8,
"layoutDurationMs": 2.5409999999999995,
"taskDurationMs": 1015.0489999999999,
"heapDeltaBytes": -7130760,
"heapUsedBytes": 83066512,
"domNodes": -180,
"jsHeapTotalBytes": -2220032,
"scriptDurationMs": 177.03000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.4850000000101,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.849,
"layouts": 11,
"layoutDurationMs": 3.458,
"taskDurationMs": 363.63,
"heapDeltaBytes": 1795912,
"heapUsedBytes": 105981440,
"domNodes": 47,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 15.505,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.3130000000192,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.283,
"layouts": 10,
"layoutDurationMs": 3.1180000000000003,
"taskDurationMs": 537.9809999999999,
"heapDeltaBytes": 1790824,
"heapUsedBytes": 106376648,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 18.62,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 611.992999999984,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.268,
"layouts": 10,
"layoutDurationMs": 3.0429999999999997,
"taskDurationMs": 452.082,
"heapDeltaBytes": 6416240,
"heapUsedBytes": 110639784,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 177.036,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 746.0309999999026,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.797,
"layouts": 8,
"layoutDurationMs": 2.3720000000000003,
"taskDurationMs": 526.742,
"heapDeltaBytes": 228084,
"heapUsedBytes": 90449644,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 178.69600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1259.5199999999807,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 958.6709999999999,
"heapDeltaBytes": -15231840,
"heapUsedBytes": 102720952,
"domNodes": -210,
"jsHeapTotalBytes": 15613952,
"scriptDurationMs": 72.59500000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 556,
"frameDurationMs": 32.89210526315791,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1278.6200000000463,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 974.2940000000001,
"heapDeltaBytes": -8471692,
"heapUsedBytes": 102261636,
"domNodes": -230,
"jsHeapTotalBytes": 10076160,
"scriptDurationMs": 74.257,
"eventListeners": -168,
"totalBlockingTimeMs": 590,
"frameDurationMs": 33.771052631578925,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.4490000000069,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.5759999999997,
"heapDeltaBytes": -4204124,
"heapUsedBytes": 96668504,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.85,
"eventListeners": 0,
"totalBlockingTimeMs": 214,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 888.6919999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.8830000000002,
"heapDeltaBytes": -4741520,
"heapUsedBytes": 96823056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.54000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.536111111111115,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11399.117000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10534.949999999999,
"heapDeltaBytes": -19960420,
"heapUsedBytes": 103998192,
"domNodes": -296,
"jsHeapTotalBytes": 11673600,
"scriptDurationMs": 8469.387,
"eventListeners": -130,
"totalBlockingTimeMs": 1543,
"frameDurationMs": 32.38494318181819,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11335.395000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10483.449999999999,
"heapDeltaBytes": 33399704,
"heapUsedBytes": 144401728,
"domNodes": -277,
"jsHeapTotalBytes": 41201664,
"scriptDurationMs": 8437.632,
"eventListeners": -126,
"totalBlockingTimeMs": 1196,
"frameDurationMs": 31.3524861878453,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11143.135999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10393.003999999999,
"heapDeltaBytes": 24868128,
"heapUsedBytes": 146898332,
"domNodes": -282,
"jsHeapTotalBytes": 50962432,
"scriptDurationMs": 8404.718,
"eventListeners": -130,
"totalBlockingTimeMs": 1394,
"frameDurationMs": 31.3191011235955,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11673.30800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10945.779999999999,
"heapDeltaBytes": 30191100,
"heapUsedBytes": 151688948,
"domNodes": -276,
"jsHeapTotalBytes": 48603136,
"scriptDurationMs": 8852.904,
"eventListeners": -126,
"totalBlockingTimeMs": 1325,
"frameDurationMs": 32.405833333333334,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-combo-open",
"durationMs": 223.61300000000028,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.308,
"layouts": 11,
"layoutDurationMs": 3.46,
"taskDurationMs": 168.65600000000003,
"heapDeltaBytes": 13201196,
"heapUsedBytes": 120751536,
"domNodes": 917,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 9.009,
"eventListeners": 196,
"totalBlockingTimeMs": 1,
"frameDurationMs": 24.066666666666706,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 224.89199999995435,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.845999999999998,
"layouts": 11,
"layoutDurationMs": 3.3629999999999995,
"taskDurationMs": 175.37099999999998,
"heapDeltaBytes": 13233088,
"heapUsedBytes": 118140320,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 8.981,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2058.568999999977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.067,
"layouts": 8,
"layoutDurationMs": 2.797,
"taskDurationMs": 753.763,
"heapDeltaBytes": -427180,
"heapUsedBytes": 101701876,
"domNodes": -296,
"jsHeapTotalBytes": -1990656,
"scriptDurationMs": 35.86,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.324000000018,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.609000000000001,
"layouts": 7,
"layoutDurationMs": 2.409,
"taskDurationMs": 756.013,
"heapDeltaBytes": 5977924,
"heapUsedBytes": 107666024,
"domNodes": -276,
"jsHeapTotalBytes": -5922816,
"scriptDurationMs": 39.27700000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3036.0019999999963,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.389999999999999,
"layouts": 7,
"layoutDurationMs": 2.006,
"taskDurationMs": 1951.563,
"heapDeltaBytes": -2304860,
"heapUsedBytes": 110196772,
"domNodes": -296,
"jsHeapTotalBytes": -421888,
"scriptDurationMs": 966.6210000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758011049723752,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2360.274000000004,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.584,
"layouts": 6,
"layoutDurationMs": 1.9789999999999999,
"taskDurationMs": 1690.533,
"heapDeltaBytes": 969168,
"heapUsedBytes": 104154956,
"domNodes": -296,
"jsHeapTotalBytes": -716800,
"scriptDurationMs": 869.517,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.028260869565216,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3638.6810000000196,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.424,
"layouts": 64,
"layoutDurationMs": 11.548000000000002,
"taskDurationMs": 1747.375,
"heapDeltaBytes": -10111944,
"heapUsedBytes": 92576680,
"domNodes": -252,
"jsHeapTotalBytes": -2646016,
"scriptDurationMs": 830.6060000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665596330275232,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3683.9449999999943,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.300999999999998,
"layouts": 64,
"layoutDurationMs": 12.018,
"taskDurationMs": 1744.1309999999999,
"heapDeltaBytes": 7658164,
"heapUsedBytes": 122369640,
"domNodes": 24,
"jsHeapTotalBytes": 5246976,
"scriptDurationMs": 836.942,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.741818181818182,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3056.1439999999607,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.558,
"layouts": 5,
"layoutDurationMs": 1.3159999999999998,
"taskDurationMs": 1888.2920000000001,
"heapDeltaBytes": 16883184,
"heapUsedBytes": 122744048,
"domNodes": 0,
"jsHeapTotalBytes": 5926912,
"scriptDurationMs": 1004.5569999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.93934426229508,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3186.105999999995,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.002000000000001,
"layouts": 5,
"layoutDurationMs": 1.6269999999999996,
"taskDurationMs": 1971.663,
"heapDeltaBytes": 22301048,
"heapUsedBytes": 129155460,
"domNodes": 0,
"jsHeapTotalBytes": 6451200,
"scriptDurationMs": 1059.651,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.931382978723402,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2040.4809999999998,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.555,
"layouts": 7,
"layoutDurationMs": 2.6819999999999995,
"taskDurationMs": 593.7509999999999,
"heapDeltaBytes": 5180788,
"heapUsedBytes": 108211712,
"domNodes": -296,
"jsHeapTotalBytes": -5660672,
"scriptDurationMs": 40.73000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2061.4610000000084,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.6239999999999997,
"layouts": 6,
"layoutDurationMs": 2.4429999999999996,
"taskDurationMs": 656.6639999999999,
"heapDeltaBytes": 5327000,
"heapUsedBytes": 108561532,
"domNodes": -297,
"jsHeapTotalBytes": -5660672,
"scriptDurationMs": 42.516999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 725.2650000000358,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.4350000000000005,
"layouts": 9,
"layoutDurationMs": 2.7179999999999995,
"taskDurationMs": 497.459,
"heapDeltaBytes": 3168964,
"heapUsedBytes": 109295824,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 149.43,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 645.8390000000236,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.123,
"layouts": 10,
"layoutDurationMs": 3.374,
"taskDurationMs": 441.43600000000004,
"heapDeltaBytes": 2743352,
"heapUsedBytes": 108954956,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 153.98999999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2055.9879999999566,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2029999999999994,
"layouts": 9,
"layoutDurationMs": 2.446,
"taskDurationMs": 588.008,
"heapDeltaBytes": -26703136,
"heapUsedBytes": 79654548,
"domNodes": -224,
"jsHeapTotalBytes": 2244608,
"scriptDurationMs": 8.552000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2074.0279999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.306,
"layouts": 10,
"layoutDurationMs": 3.216,
"taskDurationMs": 539.332,
"heapDeltaBytes": -7277740,
"heapUsedBytes": 98613480,
"domNodes": -198,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 12.697,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.8859999999659,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.562999999999999,
"layouts": 8,
"layoutDurationMs": 2.3589999999999995,
"taskDurationMs": 980.752,
"heapDeltaBytes": -12210256,
"heapUsedBytes": 88307800,
"domNodes": -191,
"jsHeapTotalBytes": 7708672,
"scriptDurationMs": 119.29799999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2041.4320000000998,
"styleRecalcs": 88,
"styleRecalcDurationMs": 16.932000000000002,
"layouts": 9,
"layoutDurationMs": 2.723,
"taskDurationMs": 1071.143,
"heapDeltaBytes": -17045432,
"heapUsedBytes": 89186644,
"domNodes": -210,
"jsHeapTotalBytes": 3252224,
"scriptDurationMs": 129.322,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1483.7330000000293,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.720000000000002,
"layouts": 5,
"layoutDurationMs": 17.562,
"taskDurationMs": 963.8290000000003,
"heapDeltaBytes": 35489216,
"heapUsedBytes": 135901136,
"domNodes": 15950,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 35.366,
"eventListeners": 3244,
"totalBlockingTimeMs": 186,
"frameDurationMs": 20.268918918918914,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8874.031000000003,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.221000000000004,
"layouts": 7,
"layoutDurationMs": 2.0750000000000006,
"taskDurationMs": 6050.36,
"heapDeltaBytes": -13522848,
"heapUsedBytes": 88279120,
"domNodes": -276,
"jsHeapTotalBytes": -8282112,
"scriptDurationMs": 3022.7659999999996,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.728867924528302,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10676.811000000043,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.18300000000001,
"layouts": 8,
"layoutDurationMs": 2.4749999999999996,
"taskDurationMs": 6790.001,
"heapDeltaBytes": -1836156,
"heapUsedBytes": 100479440,
"domNodes": -296,
"jsHeapTotalBytes": -1011712,
"scriptDurationMs": 3005.058,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.71818181818182,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16860.023000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16390.257,
"heapDeltaBytes": -10714312,
"heapUsedBytes": 308161792,
"domNodes": -3337,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 261.857,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.225627240143364,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 24638.728000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23932.211,
"heapDeltaBytes": -15570848,
"heapUsedBytes": 294730140,
"domNodes": -3337,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 362.32399999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.752042628774426,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 28429.65700000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.469999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28089.161000000004,
"heapDeltaBytes": -5544480,
"heapUsedBytes": 295474516,
"domNodes": -3337,
"jsHeapTotalBytes": 11259904,
"scriptDurationMs": 897.355,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.2438202247191,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 20292.768000000025,
"styleRecalcs": 155,
"styleRecalcDurationMs": 17.099000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19889.948,
"heapDeltaBytes": -53340,
"heapUsedBytes": 310558680,
"domNodes": -3337,
"jsHeapTotalBytes": 17219584,
"scriptDurationMs": 841.78,
"eventListeners": -651,
"totalBlockingTimeMs": 11,
"frameDurationMs": 38.2688679245283,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6318.921000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.27200000000002,
"layouts": 20,
"layoutDurationMs": 24.63,
"taskDurationMs": 6171.979,
"heapDeltaBytes": -34933272,
"heapUsedBytes": 288849908,
"domNodes": -3337,
"jsHeapTotalBytes": 6279168,
"scriptDurationMs": 114.487,
"eventListeners": -653,
"totalBlockingTimeMs": 21,
"frameDurationMs": 35.287150837988825,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8344.42999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.985,
"layouts": 20,
"layoutDurationMs": 28.899000000000008,
"taskDurationMs": 8234.72,
"heapDeltaBytes": -24425244,
"heapUsedBytes": 280727504,
"domNodes": -3337,
"jsHeapTotalBytes": 7327744,
"scriptDurationMs": 153.781,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.646368715083796,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11488.34599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11294.577000000001,
"heapDeltaBytes": 4655932,
"heapUsedBytes": 293585988,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.47099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.21648745519714,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11689.092999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11437.109,
"heapDeltaBytes": 4648092,
"heapUsedBytes": 289091148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.34200000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.73775510204081,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 127.56600000000162,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.989,
"layouts": 9,
"layoutDurationMs": 3.041,
"taskDurationMs": 85.93800000000002,
"heapDeltaBytes": 4813036,
"heapUsedBytes": 101774836,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.116,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 117.33800000001793,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.599,
"layouts": 8,
"layoutDurationMs": 3.177,
"taskDurationMs": 75.304,
"heapDeltaBytes": 4592744,
"heapUsedBytes": 106572256,
"domNodes": 116,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.184,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 424.8330000000351,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.98,
"layouts": 76,
"layoutDurationMs": 14.414,
"taskDurationMs": 375.46100000000007,
"heapDeltaBytes": -15441812,
"heapUsedBytes": 78962564,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 171.711,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 553.5039999999753,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.745,
"layouts": 76,
"layoutDurationMs": 16.168,
"taskDurationMs": 502.16099999999994,
"heapDeltaBytes": -13496268,
"heapUsedBytes": 80704932,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 240.951,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 644.4739999999456,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.22,
"layouts": 76,
"layoutDurationMs": 16.806,
"taskDurationMs": 602.1750000000001,
"heapDeltaBytes": 1652528,
"heapUsedBytes": 118777960,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 247.908,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.10263157894736,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 633.4079999999176,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7440000000000002,
"layouts": 76,
"layoutDurationMs": 15.211,
"taskDurationMs": 597.0110000000001,
"heapDeltaBytes": 1746780,
"heapUsedBytes": 118490012,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 253.457,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.10263157894736,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 2949 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b331a9e325df4522e52199f901fe27e7d05fa259
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (111)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #21435 +/- ##
=============================================
- Coverage 87.04% 87.04% -0.01%
=============================================
Files 2726 2726
Lines 151434 151444 +10
Branches 39154 39158 +4
=============================================
Hits 131821 131821
- Misses 19223 19233 +10
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #21293 to
core/1.58Automatically created by backport workflow.