Repository navigation
[backport cloud/1.57] Release models for a picked deployment, with the no-deployment boot fix (#21010, #21368) BE-19187 - #21398
Conversation
## Summary The Model Library and model dropdowns now use the selected deployment's Release models instead of Cloud's asset library. Browsers without a deployment keep the Cloud asset picker. The editor waits for the deployment lookup before constructing widgets. A transient failure (a 5xx, 408, 429, network error or request timeout) is retried up to three attempts, 1s then 2s apart, inside a 45-second limit. A 404 (an ingest without the deployment routes) is treated like the rollout refusal and starts on Cloud quietly. If the lookup still fails or passes 45 seconds, the editor starts on Comfy Cloud's models, as main does, and shows an error that stays until closed, with a Reload button. Chosen behaviour: the pick is a cookie the editor cannot read, so after a failed lookup it cannot tell a user with no deployment from one with a pick; starting on Cloud keeps the editor up for everyone, and a later successful lookup that names a deployment shows the existing "now runs on X, Reload" banner. Leaving the editor during startup clears the loading screen without reporting an exception. Returning to the editor can still report successful startup. Accounts outside the rollout continue on Cloud. Folder refreshes keep using the Release list, including filenames outside the asset library's extension filters. - On a picked deployment, the Model Library button opens the Release folder tree rather than the Cloud asset browser. Cloud keeps its asset browser. **Why** A deployment can contain different models from the shared Cloud library. Showing Cloud models offers files that deployment cannot load and hides files included in its Release. The model-source regression tests reproduce this mismatch with the production changes reverted. ## Verification - Shared Cloud browser boot now supplies an explicit rollout-refusal response. The existing subscription test fails at startup without it; all three subscription browser tests pass with it against the local Cloud bundle. Browser type checking and formatting pass. - Initial implementation: 612 selected tests passed; nine regression checks failed with the production changes reverted. - Latest changes: 123 focused startup, deployment state and telemetry tests pass. Three cancellation/replacement cases fail before the fix. All four billing browser tests pass after supplying the deployment rollout-refusal response; the first fails at startup without that fixture. The browser run uses mocked APIs against the local Cloud bundle. Earlier coverage includes 277 tests across model sources, widget construction and artifact checks, including timeout and recovery-notification mutations. - Type checking, lint, formatting, Cloud build and its artifact check pass. The artifact check accepts the deployment-aware Cloud gate and retains the static-off requirement for local and Desktop builds. Latest change (review): a failed or stalled deployment lookup no longer stops the editor; see the startup paragraph above. Eight new or renamed startup and retry tests fail before the change; 130 deployment, startup and combo-widget tests and 3,440 tests across workspace, model and sidebar suites pass after it. Typecheck, lint, format, Knip and the i18n key check pass. The three lookup-failure captures below show the earlier stop screen, before this change. Previous check: 163 focused deployment, startup, bootstrap-tracing and error-reporting tests pass. Three new failure-reporting cases fail before the fix; expected rollout refusals stay quiet. Earlier, 155 model and sidebar tests passed, including a Model Library button regression that fails before the fix. Local browser checks cover the Release library, checkpoint and LoRA dropdowns, and failed deployment lookup with mocked responses. Not run: live deployment browser validation. Local captures use mocked deployment and model responses. Try it: pick a deployment, open the Model Library and checkpoint/LoRA dropdowns, and compare their files with that Release. Return to Cloud and confirm the asset picker remains available. Fail the initial deployment lookup and confirm the editor starts on Cloud models with the Reload error. Ref BE-19187 - Release models in the Model Library and dropdowns. ## Screenshots Local browser run with mocked deployment and model responses. Each layout shows the Model Library, checkpoint dropdown, LoRA dropdown and failed lookup guidance. <details> <summary>Dark</summary> <img width="1440" height="1000" alt="dark-library" src="https://github.com/user-attachments/assets/b36e21bb-5039-4495-b6e2-da729da1336f" /> <img width="1440" height="1000" alt="dark-checkpoint" src="https://github.com/user-attachments/assets/43caf5bb-12af-46c1-a0ba-dff608860900" /> <img width="1440" height="1000" alt="dark-lora" src="https://github.com/user-attachments/assets/b1dba4dd-5101-4c06-a9cf-b0e71a03a09c" /> <img width="1440" height="1000" alt="dark-lookup-failure" src="https://github.com/user-attachments/assets/6bfed80f-9684-4468-81af-8ef22907e07a" /> </details> <details> <summary>Light</summary> <img width="1440" height="1000" alt="light-library" src="https://github.com/user-attachments/assets/177999c5-6208-4c3c-bb92-fbea0486aac4" /> <img width="1440" height="1000" alt="light-checkpoint" src="https://github.com/user-attachments/assets/db5c7a4b-1916-4d40-b739-67e951462481" /> <img width="1440" height="1000" alt="light-lora" src="https://github.com/user-attachments/assets/fafad8ea-5296-414d-8ac3-312569ce7648" /> <img width="1440" height="1000" alt="light-lookup-failure" src="https://github.com/user-attachments/assets/81c3cea1-e6d6-4210-861a-bf32b2166aa3" /> </details> <details> <summary>Phone</summary> <img width="390" height="844" alt="phone-library" src="https://github.com/user-attachments/assets/d56b84c1-a479-4512-8ffb-71f0254d4ba2" /> <img width="390" height="844" alt="phone-checkpoint" src="https://github.com/user-attachments/assets/d18068a6-0ea7-4c9e-b2d6-a09cdbd12b74" /> <img width="390" height="844" alt="phone-lora" src="https://github.com/user-attachments/assets/c929ac5e-dbaf-4735-a00e-df7c1b549b92" /> <img width="390" height="844" alt="phone-lookup-failure" src="https://github.com/user-attachments/assets/e0a0e8e3-ace1-482a-9359-c6f2738227c7" /> </details> (cherry picked from commit 9aad4ff)
…t, the deployment check (#21368) ## What changes Most Cloud users have no deployment, so the deployment check does not apply to them. After this change, once a browser has learned that it runs on Comfy Cloud, the editor no longer holds its canvas waiting for that check. It also never shows that browser the red "Could not check which deployment this editor runs on" toast when the check fails. **Before:** on Cloud, every editor waited for the deployment listing (`GET /api/workspaces/{id}/deployments`) before it set up the canvas, for up to 45 s, on every load. If the listing failed with anything other than 403 or 404 (a 5xx, a network error, a 401 or a timeout), everyone got the sticky toast, including people with no deployment. **After:** the editor keeps a per-workspace note in `localStorage` saying where this browser last booted: on a deployment, or on Comfy Cloud. - **The note says Comfy Cloud, and the page was not opened from a `deployment` link:** the canvas is set up at once on Comfy Cloud's models, with no wait and no toast. A failed listing is still sent to error tracking. This covers almost every Cloud user from their second load on. - **No note yet** (the first load after this ships, a new browser profile, cleared site data, or a `localStorage` that throws): the editor waits as before. The listing, usually a fast 403, then writes the note. - **The note names a deployment, or the page was opened from a `deployment` link:** the editor waits and shows the toast on failure, as before. The missing-model check follows the same rule. **Why** #21010 made the Cloud editor wait for the deployment listing before it sets up the canvas, and show a sticky toast when that listing fails. That code is on main and has not reached a Cloud release yet. Almost every Cloud user has no deployment: the listing answers them 403. In a recent sample of about 12,140 of these listing requests on Cloud, 8 got no answer or a 401, and the slowest took 20.6 s. With #21010 released, each of those people would wait that long for the canvas and then see a toast about a deployment they never had. This should land before the next Cloud release is cut from main. ## How the note is kept The ticket asked to check the browser's deployment pick cookie. That cookie is HttpOnly, so the page's code cannot read it. A workspace default deployment also puts members on a deployment without any pick. So the editor keeps its own note, `Comfy.Workspace.DeploymentHint.<workspaceId>`: - **Set to the deployment id:** when a listing says the browser runs on a deployment, and just before the reload after a switch onto one (`pick`, `pickFromLink`, `followWorkspace`, `setDefault` while following the workspace). - **Set to `cloud`:** when a listing says Comfy Cloud, on a 403 or 404, and before the reload after a switch to Comfy Cloud. - **Left as it is:** on a transient failure. One case still boots on the wrong models once. The browser's last load was on Comfy Cloud, and since then the workspace owner has set a default deployment. That browser starts on Comfy Cloud's models. The switcher then shows its existing "changed since this page loaded" prompt and updates the note, so the next load waits. ## Tests - `GraphCanvas.test.ts`: - A Comfy Cloud note: the canvas mounts at once with no toast, whether the listing never answers or fails. - No note, or a `deployment` link: the canvas waits and shows the toast on failure, as before. - `waitForDeploymentPick.test.ts` (new): - A Comfy Cloud note returns at once without requesting the listing, including when the listing would hang or fail with a 500, a network error or a 401. - No note waits and boots on the deployment the listing names, for both a workspace default and a browser pick. - A note for another workspace does not count. - A throwing `localStorage` waits. - `deploymentPickStore.test.ts`: - A 200 on a deployment writes its id. A 200 on Comfy Cloud, a 403 and a 404 write `cloud`. A transient failure leaves the note as it was. - The note is written before the reload after `pick`, `pickFromLink`, `followWorkspace` (with and without a default) and `setDefault` while following. - `releaseModelOptions.test.ts`: the missing-model check waits unless the note says Comfy Cloud and there is no link. Without the source change, 35 of these 171 tests fail. With it, all 171 pass. A wider run over `src/platform/workspace`, `src/platform/missingModel` and `src/components/graph` also passes (150 files, 3,829 tests). `pnpm typecheck`, oxlint, eslint, oxfmt, knip, `deps:audit` and `fallow:audit` (on push) all pass. Not run: a real Cloud editor in a browser; the behaviour is covered by unit tests only. Ref BE-21518 (cherry picked from commit 4f11922)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-19T23:52:36.696Z",
"gitSha": "72cc5b6eb5c0de21bcb7025f90690ace2af992ae",
"branch": "backport-21010-21368-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.070000000042,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5820000000000003,
"layouts": 10,
"layoutDurationMs": 2.9179999999999997,
"taskDurationMs": 489.10600000000005,
"heapDeltaBytes": -896784,
"heapUsedBytes": 74542788,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.459999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.0199999999404,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7419999999999995,
"layouts": 10,
"layoutDurationMs": 2.632,
"taskDurationMs": 337.415,
"heapDeltaBytes": 22077456,
"heapUsedBytes": 87954788,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.766999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1975.7459999999583,
"styleRecalcs": 82,
"styleRecalcDurationMs": 14.384999999999998,
"layouts": 10,
"layoutDurationMs": 2.512,
"taskDurationMs": 892.5240000000001,
"heapDeltaBytes": 15573036,
"heapUsedBytes": 81389148,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 162.127,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66638655462185,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.3170000000255,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.274,
"layouts": 9,
"layoutDurationMs": 2.479,
"taskDurationMs": 850.669,
"heapDeltaBytes": -3106832,
"heapUsedBytes": 72196824,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 162.932,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.7539999999622,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.168000000000001,
"layouts": 12,
"layoutDurationMs": 2.842,
"taskDurationMs": 269.391,
"heapDeltaBytes": 18722444,
"heapUsedBytes": 84692364,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.093000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1809.2249999999694,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.089,
"layouts": 12,
"layoutDurationMs": 2.5320000000000005,
"taskDurationMs": 329.16900000000004,
"heapDeltaBytes": 18746400,
"heapUsedBytes": 84579324,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.807999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 596.4700000000107,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.207,
"layouts": 8,
"layoutDurationMs": 2.135,
"taskDurationMs": 429.51099999999997,
"heapDeltaBytes": 25663560,
"heapUsedBytes": 91560500,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 168.241,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 668.9090000000988,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4480000000000004,
"layouts": 9,
"layoutDurationMs": 2.251,
"taskDurationMs": 478.354,
"heapDeltaBytes": 26050940,
"heapUsedBytes": 92000476,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 162.79399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.0650000000192,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 915.3389999999999,
"heapDeltaBytes": 489652,
"heapUsedBytes": 81199856,
"domNodes": -192,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 69.53799999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 547,
"frameDurationMs": 33.79722222222222,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.2029999999313,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 914.4739999999999,
"heapDeltaBytes": -12141652,
"heapUsedBytes": 80927372,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 74.32600000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 533,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 832.952999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.8879999999997,
"heapDeltaBytes": -4840100,
"heapUsedBytes": 75956628,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 149.405,
"eventListeners": 0,
"totalBlockingTimeMs": 208,
"frameDurationMs": 24.50882352941177,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.3430000000708,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.01799999999946,
"heapDeltaBytes": -4798644,
"heapUsedBytes": 76364444,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 155.69500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 214,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10305.08500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9378.545,
"heapDeltaBytes": -16905900,
"heapUsedBytes": 70914704,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 7619.392000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 853,
"frameDurationMs": 32.08629283489097,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9548.009000000093,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8770.662999999999,
"heapDeltaBytes": -1687160,
"heapUsedBytes": 97749476,
"domNodes": -258,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 7027.843000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 595,
"frameDurationMs": 31.413157894736845,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9530.602999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8716.148000000001,
"heapDeltaBytes": -14634868,
"heapUsedBytes": 84492204,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 7020.336,
"eventListeners": -68,
"totalBlockingTimeMs": 571,
"frameDurationMs": 31.461716171617162,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8440.22899999993,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2440000000000003,
"layouts": 1,
"layoutDurationMs": 0.22699999999999976,
"taskDurationMs": 7654.896,
"heapDeltaBytes": -21689432,
"heapUsedBytes": 77926472,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 6368.362,
"eventListeners": -68,
"totalBlockingTimeMs": 468,
"frameDurationMs": 32.434615384615384,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 214.87999999999374,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.382000000000001,
"layouts": 11,
"layoutDurationMs": 3.0060000000000002,
"taskDurationMs": 160.64700000000002,
"heapDeltaBytes": 13076720,
"heapUsedBytes": 91346520,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.229999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 21.660000000000036,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 197.8830000000471,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.003000000000002,
"layouts": 10,
"layoutDurationMs": 2.9319999999999995,
"taskDurationMs": 156.57600000000002,
"heapDeltaBytes": -8140832,
"heapUsedBytes": 79606692,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.429,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.211111111111173,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2055.1269999999704,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.057,
"layouts": 8,
"layoutDurationMs": 2.1870000000000003,
"taskDurationMs": 634.988,
"heapDeltaBytes": -16610172,
"heapUsedBytes": 80173196,
"domNodes": -258,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 33.050999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6650406504065,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2006.74099999992,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.259,
"layouts": 8,
"layoutDurationMs": 2.368,
"taskDurationMs": 447.39099999999985,
"heapDeltaBytes": -3512376,
"heapUsedBytes": 75534244,
"domNodes": -278,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 29.613,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2447.2599999999716,
"styleRecalcs": 69,
"styleRecalcDurationMs": 5.996,
"layouts": 7,
"layoutDurationMs": 1.747,
"taskDurationMs": 1698.236,
"heapDeltaBytes": -29014276,
"heapUsedBytes": 68922768,
"domNodes": -258,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 823.979,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78013698630137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2419.901999999979,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.647,
"layouts": 7,
"layoutDurationMs": 1.6909999999999998,
"taskDurationMs": 1689.7989999999998,
"heapDeltaBytes": -29495004,
"heapUsedBytes": 68214720,
"domNodes": -258,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 809.253,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78194444444445,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3500.8809999999926,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.747999999999999,
"layouts": 64,
"layoutDurationMs": 10.060999999999998,
"taskDurationMs": 1534.127,
"heapDeltaBytes": 11215204,
"heapUsedBytes": 93025544,
"domNodes": -234,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 756.62,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74641148325359,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3654.1670000000295,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.618,
"layouts": 63,
"layoutDurationMs": 10.040000000000001,
"taskDurationMs": 1724.5779999999997,
"heapDeltaBytes": -9628404,
"heapUsedBytes": 72025480,
"domNodes": -234,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 760.941,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666210045662098,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2921.9439999999963,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.449999999999999,
"layouts": 6,
"layoutDurationMs": 1.809,
"taskDurationMs": 1909.577,
"heapDeltaBytes": 2586428,
"heapUsedBytes": 80982396,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 952.6929999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.858045977011496,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2993.6800000000403,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.435,
"layouts": 5,
"layoutDurationMs": 1.1140000000000003,
"taskDurationMs": 1932.6599999999999,
"heapDeltaBytes": 6955788,
"heapUsedBytes": 84893412,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 987.334,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.948587570621466,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2039.950000000033,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.706,
"layouts": 7,
"layoutDurationMs": 1.7070000000000003,
"taskDurationMs": 605.799,
"heapDeltaBytes": -2597000,
"heapUsedBytes": 78591060,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 31.983999999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.3919999999453,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7159999999999997,
"layouts": 7,
"layoutDurationMs": 1.915,
"taskDurationMs": 602.0759999999999,
"heapDeltaBytes": -1560348,
"heapUsedBytes": 79670396,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.302000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.26799999999,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.393,
"layouts": 9,
"layoutDurationMs": 2.297,
"taskDurationMs": 420.562,
"heapDeltaBytes": -1108184,
"heapUsedBytes": 75834716,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 145.596,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66944444444443,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.8130000000392,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.648999999999999,
"layouts": 9,
"layoutDurationMs": 3.068,
"taskDurationMs": 427.516,
"heapDeltaBytes": -1072460,
"heapUsedBytes": 75982244,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 147.396,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2022.4699999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2009999999999996,
"layouts": 9,
"layoutDurationMs": 2.216,
"taskDurationMs": 484.05299999999994,
"heapDeltaBytes": 3804216,
"heapUsedBytes": 80798040,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 7.8889999999999985,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.5039999999362,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4379999999999993,
"layouts": 9,
"layoutDurationMs": 2.6679999999999993,
"taskDurationMs": 338.731,
"heapDeltaBytes": 22434888,
"heapUsedBytes": 89839324,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.6549999999999985,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.519999999994,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.714,
"layouts": 9,
"layoutDurationMs": 2.449,
"taskDurationMs": 808.532,
"heapDeltaBytes": -11372020,
"heapUsedBytes": 65917772,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 105.089,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1958.601999999928,
"styleRecalcs": 87,
"styleRecalcDurationMs": 15.209,
"layouts": 9,
"layoutDurationMs": 2.4210000000000003,
"taskDurationMs": 989.7070000000001,
"heapDeltaBytes": 15160568,
"heapUsedBytes": 91755264,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 105.977,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.7010000000141,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.833999999999996,
"layouts": 5,
"layoutDurationMs": 16.909,
"taskDurationMs": 1036.856,
"heapDeltaBytes": 5031912,
"heapUsedBytes": 100410528,
"domNodes": 15953,
"jsHeapTotalBytes": 17702912,
"scriptDurationMs": 27.226,
"eventListeners": 3244,
"totalBlockingTimeMs": 169,
"frameDurationMs": 19.818918918918925,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8924.43800000001,
"styleRecalcs": 249,
"styleRecalcDurationMs": 16.698999999999998,
"layouts": 6,
"layoutDurationMs": 1.4569999999999999,
"taskDurationMs": 5749.3550000000005,
"heapDeltaBytes": -16514340,
"heapUsedBytes": 80250132,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 2672.0640000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75966228893058,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9022.118999999975,
"styleRecalcs": 250,
"styleRecalcDurationMs": 17.267999999999997,
"layouts": 8,
"layoutDurationMs": 2.27,
"taskDurationMs": 5834.231,
"heapDeltaBytes": -623188,
"heapUsedBytes": 78386128,
"domNodes": -258,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2664.7279999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.727592592592593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22794.25500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21855.609,
"heapDeltaBytes": 12467272,
"heapUsedBytes": 289472204,
"domNodes": -3330,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 304.12300000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.0778730703259,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22918.372999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22017.479000000003,
"heapDeltaBytes": -16227340,
"heapUsedBytes": 284252720,
"domNodes": -3330,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 317.044,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.21061643835616,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27701.29400000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.373,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27250.348,
"heapDeltaBytes": -25851552,
"heapUsedBytes": 269729016,
"domNodes": -3330,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 912.631,
"eventListeners": -651,
"totalBlockingTimeMs": 80,
"frameDurationMs": 51.804859813084114,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27325.994000000035,
"styleRecalcs": 181,
"styleRecalcDurationMs": 14.936000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26922.818,
"heapDeltaBytes": -37043000,
"heapUsedBytes": 263718656,
"domNodes": -3334,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 884.1600000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 50.15064220183486,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8186.059,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.398,
"layouts": 20,
"layoutDurationMs": 27.812000000000005,
"taskDurationMs": 8000.046000000001,
"heapDeltaBytes": -2488520,
"heapUsedBytes": 278821492,
"domNodes": -3330,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 143.285,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.49375,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 5703.853999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.29900000000002,
"layouts": 20,
"layoutDurationMs": 21.994,
"taskDurationMs": 5549.540999999999,
"heapDeltaBytes": -42500720,
"heapUsedBytes": 261804580,
"domNodes": -3330,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 96.689,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.842458100558655,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11318.82300000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10835.011999999999,
"heapDeltaBytes": -24834900,
"heapUsedBytes": 253377072,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.66999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.490476190476194,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7657.623000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7270.968,
"heapDeltaBytes": -27486812,
"heapUsedBytes": 249065080,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.60599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.89999999999999,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 509.584000000018,
"styleRecalcs": 22,
"styleRecalcDurationMs": 16.397,
"layouts": 11,
"layoutDurationMs": 4.727,
"taskDurationMs": 165.269,
"heapDeltaBytes": -12642340,
"heapUsedBytes": 70821268,
"domNodes": 128,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 18.943,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 99.87999999998465,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.223999999999998,
"layouts": 7,
"layoutDurationMs": 2.9390000000000005,
"taskDurationMs": 72.31899999999997,
"heapDeltaBytes": 4369928,
"heapUsedBytes": 77303876,
"domNodes": 116,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.318999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 400.812999999971,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.971,
"layouts": 76,
"layoutDurationMs": 13.526,
"taskDurationMs": 353.75,
"heapDeltaBytes": -15460012,
"heapUsedBytes": 80087056,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 157.63200000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 470.61199999996006,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.251,
"layouts": 76,
"layoutDurationMs": 15.025,
"taskDurationMs": 420.082,
"heapDeltaBytes": -14055024,
"heapUsedBytes": 81341500,
"domNodes": 4,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 205.256,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 489.8880000000645,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.016,
"layouts": 76,
"layoutDurationMs": 13.843,
"taskDurationMs": 448.909,
"heapDeltaBytes": -323948,
"heapUsedBytes": 122112284,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 180.091,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 509.3329999999696,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.975,
"layouts": 76,
"layoutDurationMs": 14.345,
"taskDurationMs": 473.70599999999996,
"heapDeltaBytes": 579604,
"heapUsedBytes": 127430100,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 189.84799999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2283 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2be07da2651f40c8c5112b8f02cde7e308478d9d
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.57 #21398 +/- ##
=============================================
Coverage ? 86.72%
=============================================
Files ? 2663
Lines ? 149431
Branches ? 40740
=============================================
Hits ? 129599
Misses ? 19442
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport to
cloud/1.57of two PRs, applied in this order:The second is a fix to the first, so they ship together in one PR.
Approved for the 1.57 canary by the release sheriff in #frontend-releases: https://comfy-organization.slack.com/archives/C09K9TPU2G7/p1792425969135989
Conflicts: none. Both squash merge commits (
9aad4ff06b,4f119221c2) cherry-picked cleanly ontocloud/1.57with-x; no code was changed beyond the two original commits.Tests run on this branch (Node 26):
pnpm typecheck: passes.src/platform/workspace,src/platform/missingModel,src/components/graph/GraphCanvas,src/platform/assets,src/stores/modelStore,useModelLibrarySidebarTab,bootstrapTracer,useComboWidgetandscripts/checkAssetsFlagArtifact: 182 files, 4,413 tests pass.Ref BE-19187
Ref BE-21518