Repository navigation
[backport cloud/1.57] fix(models): show the selected deployment's Release models - #21387
comfy-pr-bot wants to merge 1 commit into
Conversation
## Summary The Model Library and model dropdowns now use the selected deployment's Release models instead of Cloud's asset library. Browsers without a deployment keep the Cloud asset picker. The editor waits for the deployment lookup before constructing widgets. A transient failure (a 5xx, 408, 429, network error or request timeout) is retried up to three attempts, 1s then 2s apart, inside a 45-second limit. A 404 (an ingest without the deployment routes) is treated like the rollout refusal and starts on Cloud quietly. If the lookup still fails or passes 45 seconds, the editor starts on Comfy Cloud's models, as main does, and shows an error that stays until closed, with a Reload button. Chosen behaviour: the pick is a cookie the editor cannot read, so after a failed lookup it cannot tell a user with no deployment from one with a pick; starting on Cloud keeps the editor up for everyone, and a later successful lookup that names a deployment shows the existing "now runs on X, Reload" banner. Leaving the editor during startup clears the loading screen without reporting an exception. Returning to the editor can still report successful startup. Accounts outside the rollout continue on Cloud. Folder refreshes keep using the Release list, including filenames outside the asset library's extension filters. - On a picked deployment, the Model Library button opens the Release folder tree rather than the Cloud asset browser. Cloud keeps its asset browser. **Why** A deployment can contain different models from the shared Cloud library. Showing Cloud models offers files that deployment cannot load and hides files included in its Release. The model-source regression tests reproduce this mismatch with the production changes reverted. ## Verification - Shared Cloud browser boot now supplies an explicit rollout-refusal response. The existing subscription test fails at startup without it; all three subscription browser tests pass with it against the local Cloud bundle. Browser type checking and formatting pass. - Initial implementation: 612 selected tests passed; nine regression checks failed with the production changes reverted. - Latest changes: 123 focused startup, deployment state and telemetry tests pass. Three cancellation/replacement cases fail before the fix. All four billing browser tests pass after supplying the deployment rollout-refusal response; the first fails at startup without that fixture. The browser run uses mocked APIs against the local Cloud bundle. Earlier coverage includes 277 tests across model sources, widget construction and artifact checks, including timeout and recovery-notification mutations. - Type checking, lint, formatting, Cloud build and its artifact check pass. The artifact check accepts the deployment-aware Cloud gate and retains the static-off requirement for local and Desktop builds. Latest change (review): a failed or stalled deployment lookup no longer stops the editor; see the startup paragraph above. Eight new or renamed startup and retry tests fail before the change; 130 deployment, startup and combo-widget tests and 3,440 tests across workspace, model and sidebar suites pass after it. Typecheck, lint, format, Knip and the i18n key check pass. The three lookup-failure captures below show the earlier stop screen, before this change. Previous check: 163 focused deployment, startup, bootstrap-tracing and error-reporting tests pass. Three new failure-reporting cases fail before the fix; expected rollout refusals stay quiet. Earlier, 155 model and sidebar tests passed, including a Model Library button regression that fails before the fix. Local browser checks cover the Release library, checkpoint and LoRA dropdowns, and failed deployment lookup with mocked responses. Not run: live deployment browser validation. Local captures use mocked deployment and model responses. Try it: pick a deployment, open the Model Library and checkpoint/LoRA dropdowns, and compare their files with that Release. Return to Cloud and confirm the asset picker remains available. Fail the initial deployment lookup and confirm the editor starts on Cloud models with the Reload error. Ref BE-19187 - Release models in the Model Library and dropdowns. ## Screenshots Local browser run with mocked deployment and model responses. Each layout shows the Model Library, checkpoint dropdown, LoRA dropdown and failed lookup guidance. <details> <summary>Dark</summary> <img width="1440" height="1000" alt="dark-library" src="https://github.com/user-attachments/assets/b36e21bb-5039-4495-b6e2-da729da1336f" /> <img width="1440" height="1000" alt="dark-checkpoint" src="https://github.com/user-attachments/assets/43caf5bb-12af-46c1-a0ba-dff608860900" /> <img width="1440" height="1000" alt="dark-lora" src="https://github.com/user-attachments/assets/b1dba4dd-5101-4c06-a9cf-b0e71a03a09c" /> <img width="1440" height="1000" alt="dark-lookup-failure" src="https://github.com/user-attachments/assets/6bfed80f-9684-4468-81af-8ef22907e07a" /> </details> <details> <summary>Light</summary> <img width="1440" height="1000" alt="light-library" src="https://github.com/user-attachments/assets/177999c5-6208-4c3c-bb92-fbea0486aac4" /> <img width="1440" height="1000" alt="light-checkpoint" src="https://github.com/user-attachments/assets/db5c7a4b-1916-4d40-b739-67e951462481" /> <img width="1440" height="1000" alt="light-lora" src="https://github.com/user-attachments/assets/fafad8ea-5296-414d-8ac3-312569ce7648" /> <img width="1440" height="1000" alt="light-lookup-failure" src="https://github.com/user-attachments/assets/81c3cea1-e6d6-4210-861a-bf32b2166aa3" /> </details> <details> <summary>Phone</summary> <img width="390" height="844" alt="phone-library" src="https://github.com/user-attachments/assets/d56b84c1-a479-4512-8ffb-71f0254d4ba2" /> <img width="390" height="844" alt="phone-checkpoint" src="https://github.com/user-attachments/assets/d18068a6-0ea7-4c9e-b2d6-a09cdbd12b74" /> <img width="390" height="844" alt="phone-lora" src="https://github.com/user-attachments/assets/c929ac5e-dbaf-4735-a00e-df7c1b549b92" /> <img width="390" height="844" alt="phone-lookup-failure" src="https://github.com/user-attachments/assets/e0a0e8e3-ace1-482a-9359-c6f2738227c7" /> </details>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-19T22:06:41.637Z",
"gitSha": "d21003e1f3ac229303f5000597f27e4306f8dff8",
"branch": "backport-21010-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.4479999999967,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.3710000000000004,
"layouts": 10,
"layoutDurationMs": 2.0360000000000005,
"taskDurationMs": 393.713,
"heapDeltaBytes": -908500,
"heapUsedBytes": 73981688,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7.637,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.1030000000055,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.145,
"layouts": 10,
"layoutDurationMs": 2.183,
"taskDurationMs": 382.637,
"heapDeltaBytes": -884092,
"heapUsedBytes": 74141664,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.315999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.90599999997,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.173,
"layouts": 10,
"layoutDurationMs": 2.263,
"taskDurationMs": 645.4590000000001,
"heapDeltaBytes": -8279144,
"heapUsedBytes": 66705420,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 108.14399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.6789999999983,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.729,
"layouts": 10,
"layoutDurationMs": 2.1279999999999997,
"taskDurationMs": 648.128,
"heapDeltaBytes": -8289908,
"heapUsedBytes": 66686716,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 109.99600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.6219999999917,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.693000000000001,
"layouts": 12,
"layoutDurationMs": 2.5120000000000005,
"taskDurationMs": 302.68600000000004,
"heapDeltaBytes": 18747496,
"heapUsedBytes": 84067120,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.544,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1808.014000000071,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.52,
"layouts": 12,
"layoutDurationMs": 2.234,
"taskDurationMs": 362.273,
"heapDeltaBytes": 17884604,
"heapUsedBytes": 83700744,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 9.904,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665137614678898,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 529.070000000047,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.3520000000000008,
"layouts": 9,
"layoutDurationMs": 2.19,
"taskDurationMs": 332.161,
"heapDeltaBytes": 26066796,
"heapUsedBytes": 91363340,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 130.631,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 534.0840000000071,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.9319999999999995,
"layouts": 11,
"layoutDurationMs": 2.665,
"taskDurationMs": 340.671,
"heapDeltaBytes": 25517312,
"heapUsedBytes": 91502796,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 135.028,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1020.6609999999614,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.2249999999999,
"heapDeltaBytes": -11497032,
"heapUsedBytes": 80839492,
"domNodes": -192,
"jsHeapTotalBytes": 19931136,
"scriptDurationMs": 46.751,
"eventListeners": -106,
"totalBlockingTimeMs": 359,
"frameDurationMs": 28.238888888888887,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1020.7279999999628,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 689.8940000000001,
"heapDeltaBytes": -11567416,
"heapUsedBytes": 81050224,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 49.52100000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 366,
"frameDurationMs": 29.045714285714297,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 783.0430000000206,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.67300000000023,
"heapDeltaBytes": -4367752,
"heapUsedBytes": 76771488,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 110.21599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 153,
"frameDurationMs": 22.380000000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 779.467000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.2000000000001,
"heapDeltaBytes": -4334324,
"heapUsedBytes": 76228712,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 114.16799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 155,
"frameDurationMs": 23.038235294117626,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6863.069999999993,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.765,
"layouts": 3,
"layoutDurationMs": 0.6890000000000004,
"taskDurationMs": 6212.696,
"heapDeltaBytes": -23755208,
"heapUsedBytes": 70268036,
"domNodes": -258,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 4912.942,
"eventListeners": -68,
"totalBlockingTimeMs": 84,
"frameDurationMs": 24.7884476534296,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6802.002999999957,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3059999999999998,
"layouts": 1,
"layoutDurationMs": 0.281,
"taskDurationMs": 6070.969,
"heapDeltaBytes": -20075328,
"heapUsedBytes": 80410260,
"domNodes": -258,
"jsHeapTotalBytes": 10612736,
"scriptDurationMs": 4752.8859999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 25,
"frameDurationMs": 24.372043010752687,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6773.076000000003,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3819999999999995,
"layouts": 2,
"layoutDurationMs": 0.36800000000000027,
"taskDurationMs": 6150.918,
"heapDeltaBytes": -10698528,
"heapUsedBytes": 76849284,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 4840.601,
"eventListeners": -68,
"totalBlockingTimeMs": 151,
"frameDurationMs": 25.562781954887217,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6137.675000000001,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.7499999999999998,
"layouts": 3,
"layoutDurationMs": 0.7100000000000001,
"taskDurationMs": 5345.895,
"heapDeltaBytes": -3167680,
"heapUsedBytes": 73737768,
"domNodes": -258,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 4399.840999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 31,
"frameDurationMs": 25.239094650205757,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 164.0820000000076,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.882999999999997,
"layouts": 11,
"layoutDurationMs": 2.6239999999999997,
"taskDurationMs": 123.23099999999998,
"heapDeltaBytes": -7507576,
"heapUsedBytes": 80108704,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.542000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.850000000000023,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 155.46899999998232,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.25,
"layouts": 12,
"layoutDurationMs": 2.8060000000000005,
"taskDurationMs": 116.387,
"heapDeltaBytes": -8374576,
"heapUsedBytes": 79143876,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.724,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837499999999977,
"p95FrameDurationMs": 50.09999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2009.4849999999838,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.955,
"layouts": 9,
"layoutDurationMs": 1.807,
"taskDurationMs": 498.756,
"heapDeltaBytes": -19869460,
"heapUsedBytes": 76826372,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 27.496,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2007.949999999937,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.817,
"layouts": 9,
"layoutDurationMs": 1.8379999999999999,
"taskDurationMs": 482.98300000000006,
"heapDeltaBytes": -4574720,
"heapUsedBytes": 74587472,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 26.102,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2135.3320000000053,
"styleRecalcs": 70,
"styleRecalcDurationMs": 5.9879999999999995,
"layouts": 9,
"layoutDurationMs": 1.9320000000000002,
"taskDurationMs": 1126.299,
"heapDeltaBytes": -11594932,
"heapUsedBytes": 68399860,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 613.2729999999999,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2232.4029999999766,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.733,
"layouts": 7,
"layoutDurationMs": 1.553,
"taskDurationMs": 1296.243,
"heapDeltaBytes": -29095868,
"heapUsedBytes": 68821984,
"domNodes": -258,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 606.1080000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3297.4550000000136,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.063,
"layouts": 65,
"layoutDurationMs": 9.895000000000001,
"taskDurationMs": 1401.29,
"heapDeltaBytes": -19926656,
"heapUsedBytes": 79524900,
"domNodes": -234,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 616.313,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.750761421319794,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3185.832000000005,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.153,
"layouts": 65,
"layoutDurationMs": 9.551,
"taskDurationMs": 1208.2000000000003,
"heapDeltaBytes": 1000480,
"heapUsedBytes": 83187796,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 618.437,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665968586387432,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2329.3789999999603,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.807,
"layouts": 6,
"layoutDurationMs": 1.3650000000000002,
"taskDurationMs": 1531.3060000000003,
"heapDeltaBytes": 10354460,
"heapUsedBytes": 93619872,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 773.4870000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.785611510791366,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2277.698999999984,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.735,
"layouts": 6,
"layoutDurationMs": 1.3870000000000002,
"taskDurationMs": 1509.041,
"heapDeltaBytes": 3075588,
"heapUsedBytes": 86879176,
"domNodes": 0,
"jsHeapTotalBytes": 6516736,
"scriptDurationMs": 729.294,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.03955223880597,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2005.5720000000292,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1730000000000005,
"layouts": 9,
"layoutDurationMs": 2.097,
"taskDurationMs": 362.12000000000006,
"heapDeltaBytes": -2333648,
"heapUsedBytes": 79518888,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 26.636000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.850999999956,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7299999999999998,
"layouts": 8,
"layoutDurationMs": 1.585,
"taskDurationMs": 488.22400000000005,
"heapDeltaBytes": -1911172,
"heapUsedBytes": 79716044,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 26.779000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.426999999971,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.011,
"layouts": 10,
"layoutDurationMs": 1.9929999999999999,
"taskDurationMs": 378.557,
"heapDeltaBytes": -1522876,
"heapUsedBytes": 75810216,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 118.44800000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.3920000000435,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.267000000000001,
"layouts": 10,
"layoutDurationMs": 2.2059999999999995,
"taskDurationMs": 326.134,
"heapDeltaBytes": 21478852,
"heapUsedBytes": 88515164,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 113.862,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.593000000019,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.2959999999999994,
"layouts": 10,
"layoutDurationMs": 2.182,
"taskDurationMs": 381.24199999999996,
"heapDeltaBytes": 3799124,
"heapUsedBytes": 80717412,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 7.063999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.9029999999752,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.3899999999999997,
"layouts": 10,
"layoutDurationMs": 2.291,
"taskDurationMs": 389.171,
"heapDeltaBytes": 3727708,
"heapUsedBytes": 80834544,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 7.004999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1960.8769999999822,
"styleRecalcs": 86,
"styleRecalcDurationMs": 13.613,
"layouts": 10,
"layoutDurationMs": 1.984,
"taskDurationMs": 843.481,
"heapDeltaBytes": -11432768,
"heapUsedBytes": 65968032,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 82.617,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1972.7999999999497,
"styleRecalcs": 87,
"styleRecalcDurationMs": 13.535,
"layouts": 11,
"layoutDurationMs": 2.217,
"taskDurationMs": 838.33,
"heapDeltaBytes": -7554636,
"heapUsedBytes": 69640712,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 80.663,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66525423728814,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1218.6140000000023,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.598000000000003,
"layouts": 5,
"layoutDurationMs": 11.895000000000001,
"taskDurationMs": 787.8439999999999,
"heapDeltaBytes": 7319380,
"heapUsedBytes": 103232060,
"domNodes": 15953,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 24.479,
"eventListeners": 3244,
"totalBlockingTimeMs": 104,
"frameDurationMs": 18.684848484848484,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8174.832999999979,
"styleRecalcs": 250,
"styleRecalcDurationMs": 17.355000000000004,
"layouts": 9,
"layoutDurationMs": 1.9700000000000004,
"taskDurationMs": 3837.999,
"heapDeltaBytes": 23312,
"heapUsedBytes": 79241364,
"domNodes": -258,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2019.2730000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665918367346936,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8210.28899999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 17.797,
"layouts": 8,
"layoutDurationMs": 1.7820000000000003,
"taskDurationMs": 3854.216,
"heapDeltaBytes": 58676,
"heapUsedBytes": 79476636,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 2041.3479999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.700000000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18873.730999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18300.466,
"heapDeltaBytes": -8689244,
"heapUsedBytes": 287735328,
"domNodes": -3330,
"jsHeapTotalBytes": 13623296,
"scriptDurationMs": 241.51,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.24940170940171,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 18887.698,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18468.3,
"heapDeltaBytes": -30900316,
"heapUsedBytes": 264522392,
"domNodes": -3330,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 240.56300000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.5,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 16608.466000000022,
"styleRecalcs": 102,
"styleRecalcDurationMs": 8.481999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16114.144,
"heapDeltaBytes": 3375388,
"heapUsedBytes": 284937348,
"domNodes": -3330,
"jsHeapTotalBytes": 20176896,
"scriptDurationMs": 654.4219999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.777777777777786,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-large-graph-pan",
"durationMs": 16584.275999999933,
"styleRecalcs": 114,
"styleRecalcDurationMs": 9.205999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16127.637,
"heapDeltaBytes": -13315496,
"heapUsedBytes": 277589188,
"domNodes": -3330,
"jsHeapTotalBytes": 18604032,
"scriptDurationMs": 648.8050000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 19,
"frameDurationMs": 30.210727272727276,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6921.707000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.29699999999998,
"layouts": 20,
"layoutDurationMs": 20.317,
"taskDurationMs": 6784.497,
"heapDeltaBytes": 12045736,
"heapUsedBytes": 288534200,
"domNodes": -3330,
"jsHeapTotalBytes": 23846912,
"scriptDurationMs": 100.51800000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.589130434782604,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6862.190999999939,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.064,
"layouts": 20,
"layoutDurationMs": 20.055000000000003,
"taskDurationMs": 6702.39,
"heapDeltaBytes": -2426844,
"heapUsedBytes": 288778748,
"domNodes": -307,
"jsHeapTotalBytes": 30924800,
"scriptDurationMs": 95.34800000000001,
"eventListeners": -7,
"totalBlockingTimeMs": 6,
"frameDurationMs": 38.699435028248594,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9394.12200000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9117.092,
"heapDeltaBytes": -3495072,
"heapUsedBytes": 256393612,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.255,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.15547703180212,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9287.144000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9102.337,
"heapDeltaBytes": 27725748,
"heapUsedBytes": 286602428,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.34,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.1993265993266,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 115.76100000002043,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.783999999999999,
"layouts": 8,
"layoutDurationMs": 2.832,
"taskDurationMs": 91.994,
"heapDeltaBytes": -15308904,
"heapUsedBytes": 68049036,
"domNodes": 97,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.555,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 462.73500000006607,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.251,
"layouts": 11,
"layoutDurationMs": 3.4770000000000003,
"taskDurationMs": 105.81199999999998,
"heapDeltaBytes": 6757536,
"heapUsedBytes": 79199640,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.386999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 302.39300000005187,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8630000000000001,
"layouts": 76,
"layoutDurationMs": 11.466000000000001,
"taskDurationMs": 248.554,
"heapDeltaBytes": 9740512,
"heapUsedBytes": 101196512,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 117.242,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 280.65700000001925,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8310000000000001,
"layouts": 76,
"layoutDurationMs": 10.865,
"taskDurationMs": 231.017,
"heapDeltaBytes": 9650188,
"heapUsedBytes": 95511448,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 106.49099999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670588235294122,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 305.89100000008784,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.702,
"layouts": 76,
"layoutDurationMs": 11.096,
"taskDurationMs": 268.75,
"heapDeltaBytes": -1660768,
"heapUsedBytes": 125112632,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.571,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 332.29800000003706,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.611,
"layouts": 76,
"layoutDurationMs": 11.091,
"taskDurationMs": 286.468,
"heapDeltaBytes": 7718144,
"heapUsedBytes": 155485608,
"domNodes": 4,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 100.298,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65999999999999,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2283 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2be07da2651f40c8c5112b8f02cde7e308478d9d
Full docs: ADR-DEVEX-LINT-0015 |
Pull request was converted to draft
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.57 #21387 +/- ##
=============================================
Coverage ? 86.73%
=============================================
Files ? 2662
Lines ? 149394
Branches ? 40730
=============================================
Hits ? 129578
Misses ? 19426
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21010 to
cloud/1.57Automatically created by backport workflow.