Repository navigation
[backport cloud/1.58] FE-3434 fix(billing): lock Run for payment recovery on payment_recovery_available - #21386
Conversation
…ry_available (#21362) ## Why The server now emits `payment_recovery_available` on the billing capabilities response (BE-20313, cloud#13802, synced in PR 20840). The Cloud run button should render it instead of deciding recovery itself. Follow-up to FE-3434 ("Wire `payment_recovery_available`"). ## Root cause `CloudRunButtonWrapper` decided the payment recovery lock on the client: `billing_status` of `payment_failed` (or `paused` behind `v1_payment_recovery`) combined with `canManageSubscription`. That is a frontend copy of backend policy (ADR-API-SERVER-FACTS-0042), and it can disagree with the provider state the server checks. ## How - `useBillingCapabilities` exposes `paymentRecoveryAvailable` as a `ServerFact`, as received. Absent (unknown, older server, billing disabled) reads as `false`. - `useBillingCapabilities` exposes `runDeniedPaymentPastDue`: `denied_reasons.can_run_workflows === 'payment_past_due'` as received, wrapped in `pendingServerFact('BE-21535', …)` until the ingest types list that reason. - `usePaymentRecoveryDialog` exposes `paymentRecoveryLock` (`'owner'` when `payment_recovery_available` is true, else `'member'` when Run is denied `payment_past_due`, otherwise `null`) and `refreshCapabilities`, so the run button reaches capabilities through it and not across the cloud/presentation to billing/application boundary. - `CloudRunButtonWrapper` locks Run with "Update payment to run" only from that lock. It no longer reads `billingStatus`, `permissions.canManageSubscription` or `v1PaymentRecovery`. - The wrapper opens the shared recovery dialog instead of its own copy of the dialog and portal logic. `showPaymentRecoveryDialog(onPortalOpened)` tells the opener when the portal opened, so the wrapper still refreshes once on return. That refresh now includes capabilities, so the lock clears when the fact flips. **Visible changes** - Members of a past-due workspace get the member lock ("Run" + "Ask your workspace owner to restore this subscription") from `denied_reasons.can_run_workflows: payment_past_due` (BE-21535, [cloud PR 14324](Comfy-Org/cloud#14324)), bridged with `pendingServerFact` until it deploys and the ingest types sync. Clicking it opens the recovery dialog without the portal, as before. Until the backend deploys, members see the generic inactive Run prompt ("Contact your workspace owner to resubscribe"). - Owners who were `paused` now see the payment-failed copy in the recovery dialog ("Your payment didn't go through"), the copy the shared dialog already uses for Add credits (FE-3434). **Not in this PR.** - `CurrentUserPopoverWorkspace` still reads `billingStatus` in `hasDelinquentSubscription`. That value feeds two compound gates (`showManagePlan`, `showSubscribeAction`). Replacing it means editing those gates, which the server-fact gate rejects, and the right fix is a fact per menu action, not a swap. Left for a follow-up. ## Backend dependency Members get the member lock from `denied_reasons.can_run_workflows: payment_past_due` on `GET /billing/capabilities`, added by BE-21535 ([cloud PR 14324](Comfy-Org/cloud#14324), not deployed). It does not grant payment management. The read is bridged with `pendingServerFact('BE-21535', …)` until the backend deploys and the ingest types sync; until then members see the generic inactive prompt. ## Verification - `vitest`: `CloudRunButtonWrapper`, `ComfyQueueButton`, `usePaymentRecoveryDialog`, `useBillingCapabilities`, `useBillingDialogs.topUpCredits`, `BillingStatusBanner`, `CurrentUserPopoverWorkspace` (678 tests). - Two tables in `CloudRunButtonWrapper.test.ts` run `billing_status` against the recovery lock (locked rows, unlocked rows). On the old wrapper they fail for `paid` + fact true (no lock) and `payment_failed` + fact false (member lock). - `fallow audit` on the changed files: no issues. - `oxlint --type-aware`, `oxfmt`, `eslint` on the touched files. `lint:server-facts` and `typecheck:app` passed in pre-commit. ## Feature flag - No client flag gates the run-button lock. It follows `payment_recovery_available` from `GET /billing/capabilities` for every Cloud workspace. - `v1_payment_recovery` is no longer read on the client (it was only read here, and is at 100% per FE-3135). Its getter in `useFeatureFlags.ts` stays for BE-17905. - `billing_control_enabled` is unchanged; it still gates the settings banners, not the run button. ## AS IS / TO BE The run button's visible UI changes only for past-due workspaces (see Visible changes). Not captured: no testcloud workspace on the test account is past due. ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Past-due top-up opens payment recovery | FE-3434 | [PR 21265](#21265) | Merged | | Sync ingest types (`payment_recovery_available`) | BE-20313 | [PR 20840](#20840) | Merged | | **Run button locks on `payment_recovery_available`** | **FE-3434 follow-up** | **this PR** | **Draft** | | Avatar menu stops reading `billingStatus` | none yet | — | Needs a fact per action | | Member-facing past-due fact (`denied_reasons.can_run_workflows: payment_past_due`) | BE-21535 | [cloud PR 14324](Comfy-Org/cloud#14324) | Open; this PR renders it via `pendingServerFact` until deployed and synced | ```mermaid graph LR A["PR 21265 past-due top-up"] --> C["This PR: run button on payment_recovery_available"] B["PR 20840 ingest types sync"] --> C C --> D["Avatar menu gates"] E["BE-21535 member past-due fact"] --> C style C fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-19T22:05:54.531Z",
"gitSha": "0189c7268180edb4c152d877790b56fb6344c3df",
"branch": "backport-21362-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2040.2320000000032,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.7600000000000002,
"layouts": 10,
"layoutDurationMs": 3.109,
"taskDurationMs": 633.86,
"heapDeltaBytes": -16086748,
"heapUsedBytes": 88017552,
"domNodes": -200,
"jsHeapTotalBytes": 2265088,
"scriptDurationMs": 11.309,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2015.7329999999547,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3600000000000003,
"layouts": 11,
"layoutDurationMs": 3.446,
"taskDurationMs": 684.02,
"heapDeltaBytes": 4861616,
"heapUsedBytes": 92461336,
"domNodes": -180,
"jsHeapTotalBytes": -2715648,
"scriptDurationMs": 13.786000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.3039999999623,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.852,
"layouts": 9,
"layoutDurationMs": 2.9189999999999996,
"taskDurationMs": 835.309,
"heapDeltaBytes": -7171852,
"heapUsedBytes": 96540044,
"domNodes": -180,
"jsHeapTotalBytes": 3837952,
"scriptDurationMs": 167.488,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2019.3689999999833,
"styleRecalcs": 80,
"styleRecalcDurationMs": 14.972000000000003,
"layouts": 9,
"layoutDurationMs": 2.538,
"taskDurationMs": 1039.8229999999999,
"heapDeltaBytes": -24175264,
"heapUsedBytes": 80053344,
"domNodes": -200,
"jsHeapTotalBytes": 2015232,
"scriptDurationMs": 178.48699999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.353999999953,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.251,
"layouts": 9,
"layoutDurationMs": 2.6400000000000006,
"taskDurationMs": 472.16999999999996,
"heapDeltaBytes": 23698224,
"heapUsedBytes": 115175760,
"domNodes": 47,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 14.808000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66699029126214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.09399999998,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.7090000000000005,
"layouts": 11,
"layoutDurationMs": 4.079,
"taskDurationMs": 516.259,
"heapDeltaBytes": 4512176,
"heapUsedBytes": 103403556,
"domNodes": 47,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 16.290000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 743.0689999999913,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.329,
"layouts": 10,
"layoutDurationMs": 2.6830000000000003,
"taskDurationMs": 525.539,
"heapDeltaBytes": 7348548,
"heapUsedBytes": 111477496,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 176.41600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 722.0849999999928,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.6290000000000004,
"layouts": 10,
"layoutDurationMs": 3.5649999999999995,
"taskDurationMs": 516.623,
"heapDeltaBytes": 6908976,
"heapUsedBytes": 111103404,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 181.894,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046512,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1213.692999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 880.1020000000001,
"heapDeltaBytes": -8747864,
"heapUsedBytes": 101852708,
"domNodes": -230,
"jsHeapTotalBytes": 9089024,
"scriptDurationMs": 73.488,
"eventListeners": -168,
"totalBlockingTimeMs": 534,
"frameDurationMs": 32.88378378378378,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1240.385999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 930.749,
"heapDeltaBytes": -8725564,
"heapUsedBytes": 101968196,
"domNodes": -230,
"jsHeapTotalBytes": 10399744,
"scriptDurationMs": 69.916,
"eventListeners": -168,
"totalBlockingTimeMs": 553,
"frameDurationMs": 33.33513513513515,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 868.4989999999857,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.1099999999999,
"heapDeltaBytes": 23483496,
"heapUsedBytes": 113772432,
"domNodes": -210,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 172.12300000000002,
"eventListeners": -168,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.2330000000311,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.3710000000001,
"heapDeltaBytes": -3745152,
"heapUsedBytes": 96216544,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.619,
"eventListeners": 0,
"totalBlockingTimeMs": 214,
"frameDurationMs": 24.99999999999997,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10033.082999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9085.849999999999,
"heapDeltaBytes": -12839432,
"heapUsedBytes": 108751272,
"domNodes": -296,
"jsHeapTotalBytes": -880640,
"scriptDurationMs": 7548.479,
"eventListeners": -130,
"totalBlockingTimeMs": 1019,
"frameDurationMs": 31.85047619047619,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12048.345000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11243.559000000001,
"heapDeltaBytes": 35236520,
"heapUsedBytes": 157111268,
"domNodes": -296,
"jsHeapTotalBytes": 48140288,
"scriptDurationMs": 9100.095,
"eventListeners": -130,
"totalBlockingTimeMs": 1750,
"frameDurationMs": 32.521081081081086,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10653.742999999991,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04200000000000037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9877.744,
"heapDeltaBytes": 23660524,
"heapUsedBytes": 134108456,
"domNodes": -277,
"jsHeapTotalBytes": 34312192,
"scriptDurationMs": 7909.340999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 939,
"frameDurationMs": 31.507396449704142,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10552.011999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9735.841,
"heapDeltaBytes": 21870004,
"heapUsedBytes": 143611856,
"domNodes": -296,
"jsHeapTotalBytes": 33984512,
"scriptDurationMs": 7701.495000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 955,
"frameDurationMs": 30.936950146627566,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 260.6179999999938,
"styleRecalcs": 26,
"styleRecalcDurationMs": 15.47,
"layouts": 11,
"layoutDurationMs": 3.4169999999999994,
"taskDurationMs": 214.223,
"heapDeltaBytes": 13268976,
"heapUsedBytes": 118554836,
"domNodes": 917,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.871,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.792307692307705,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 239.5050000000083,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.691999999999998,
"layouts": 11,
"layoutDurationMs": 3.4,
"taskDurationMs": 195.46000000000004,
"heapDeltaBytes": 13169796,
"heapUsedBytes": 117630856,
"domNodes": 917,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 9.862,
"eventListeners": 196,
"totalBlockingTimeMs": 3,
"frameDurationMs": 22.727272727272727,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2041.5119999999547,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.045000000000001,
"layouts": 8,
"layoutDurationMs": 3.0689999999999995,
"taskDurationMs": 763.722,
"heapDeltaBytes": 5678912,
"heapUsedBytes": 107491388,
"domNodes": -276,
"jsHeapTotalBytes": -5599232,
"scriptDurationMs": 37.51500000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2051.333999999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.608,
"layouts": 7,
"layoutDurationMs": 2.3280000000000003,
"taskDurationMs": 535.9870000000001,
"heapDeltaBytes": 3445832,
"heapUsedBytes": 105533980,
"domNodes": -296,
"jsHeapTotalBytes": -4288512,
"scriptDurationMs": 35.835,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2430.1980000000185,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.083,
"layouts": 7,
"layoutDurationMs": 1.8740000000000003,
"taskDurationMs": 1637.2999999999997,
"heapDeltaBytes": 565988,
"heapUsedBytes": 103822332,
"domNodes": -296,
"jsHeapTotalBytes": -1179648,
"scriptDurationMs": 862.535,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.89791666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2970.923999999968,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.845,
"layouts": 5,
"layoutDurationMs": 1.45,
"taskDurationMs": 1904.839,
"heapDeltaBytes": -478520,
"heapUsedBytes": 100368928,
"domNodes": -277,
"jsHeapTotalBytes": -1179648,
"scriptDurationMs": 880.919,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759887005649716,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3897.330000000011,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.112000000000002,
"layouts": 65,
"layoutDurationMs": 11.036000000000001,
"taskDurationMs": 1799.725,
"heapDeltaBytes": -18608696,
"heapUsedBytes": 103729676,
"domNodes": 24,
"jsHeapTotalBytes": 6070272,
"scriptDurationMs": 789.2439999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73733905579399,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3763.479000000075,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.384,
"layouts": 63,
"layoutDurationMs": 11.302,
"taskDurationMs": 1810.1229999999998,
"heapDeltaBytes": -3141132,
"heapUsedBytes": 101593488,
"domNodes": -272,
"jsHeapTotalBytes": -1536000,
"scriptDurationMs": 853.4900000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592920353982,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3029.7290000000316,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.443999999999999,
"layouts": 4,
"layoutDurationMs": 1.198,
"taskDurationMs": 1861.0910000000001,
"heapDeltaBytes": -10432408,
"heapUsedBytes": 104918844,
"domNodes": 0,
"jsHeapTotalBytes": 6295552,
"scriptDurationMs": 990.6959999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84945054945055,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3467.924999999923,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.168000000000001,
"layouts": 4,
"layoutDurationMs": 1.0880000000000005,
"taskDurationMs": 2324.5139999999997,
"heapDeltaBytes": -14608280,
"heapUsedBytes": 91708396,
"domNodes": -276,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 1083.2730000000001,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82766990291262,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.6999999999916,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.097,
"layouts": 6,
"layoutDurationMs": 2.1870000000000003,
"taskDurationMs": 726.8080000000001,
"heapDeltaBytes": -1004072,
"heapUsedBytes": 102106428,
"domNodes": -296,
"jsHeapTotalBytes": -1929216,
"scriptDurationMs": 38.471000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2056.587000000036,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.6639999999999997,
"layouts": 7,
"layoutDurationMs": 2.4250000000000003,
"taskDurationMs": 819.245,
"heapDeltaBytes": 6586588,
"heapUsedBytes": 109961960,
"domNodes": -276,
"jsHeapTotalBytes": -5599232,
"scriptDurationMs": 43.830999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 696.9649999999774,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.598,
"layouts": 9,
"layoutDurationMs": 2.6620000000000004,
"taskDurationMs": 505.02599999999995,
"heapDeltaBytes": -78976,
"heapUsedBytes": 100401772,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 149.938,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 739.7130000000516,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.13,
"layouts": 10,
"layoutDurationMs": 2.8560000000000003,
"taskDurationMs": 521.5840000000001,
"heapDeltaBytes": 3182928,
"heapUsedBytes": 108491212,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 160.861,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909075,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2040.249000000017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2530000000000006,
"layouts": 9,
"layoutDurationMs": 2.813,
"taskDurationMs": 634.0179999999999,
"heapDeltaBytes": -22701040,
"heapUsedBytes": 85380664,
"domNodes": -198,
"jsHeapTotalBytes": 1544192,
"scriptDurationMs": 10.967999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2060.7220000000552,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.456999999999999,
"layouts": 9,
"layoutDurationMs": 3.1009999999999995,
"taskDurationMs": 713.403,
"heapDeltaBytes": -15094240,
"heapUsedBytes": 77842916,
"domNodes": -199,
"jsHeapTotalBytes": -290816,
"scriptDurationMs": 11.868,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.8750000000068,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.258,
"layouts": 9,
"layoutDurationMs": 2.408,
"taskDurationMs": 769.7199999999999,
"heapDeltaBytes": -15555968,
"heapUsedBytes": 90540180,
"domNodes": -210,
"jsHeapTotalBytes": 3313664,
"scriptDurationMs": 116.174,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2098.9509999999427,
"styleRecalcs": 90,
"styleRecalcDurationMs": 21.950999999999997,
"layouts": 8,
"layoutDurationMs": 2.971,
"taskDurationMs": 1235.771,
"heapDeltaBytes": -6859964,
"heapUsedBytes": 94031920,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 139.934,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873014,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1500.7130000000188,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.964999999999996,
"layouts": 5,
"layoutDurationMs": 18.127999999999997,
"taskDurationMs": 1196.265,
"heapDeltaBytes": 16364032,
"heapUsedBytes": 137512564,
"domNodes": 15950,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 31.270000000000007,
"eventListeners": 3244,
"totalBlockingTimeMs": 171,
"frameDurationMs": 20.54794520547945,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10409.654999999986,
"styleRecalcs": 248,
"styleRecalcDurationMs": 29.528,
"layouts": 6,
"layoutDurationMs": 1.8249999999999997,
"taskDurationMs": 6237.66,
"heapDeltaBytes": 6346740,
"heapUsedBytes": 109125464,
"domNodes": -296,
"jsHeapTotalBytes": -425984,
"scriptDurationMs": 2791.539,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69278846153846,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9213.629000000083,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.660000000000004,
"layouts": 8,
"layoutDurationMs": 2.489,
"taskDurationMs": 5956.95,
"heapDeltaBytes": -21305620,
"heapUsedBytes": 89544872,
"domNodes": -276,
"jsHeapTotalBytes": 757760,
"scriptDurationMs": 3000.638,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696370235934666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23222.433000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22544.204,
"heapDeltaBytes": -28092648,
"heapUsedBytes": 282056468,
"domNodes": -3337,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 327.278,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.02724137931035,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17118.64000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16322.202000000001,
"heapDeltaBytes": -51060752,
"heapUsedBytes": 277944164,
"domNodes": -3337,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 268.42699999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.010169491525424,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 20407.460000000014,
"styleRecalcs": 155,
"styleRecalcDurationMs": 24.756,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19997.529,
"heapDeltaBytes": -7011736,
"heapUsedBytes": 312924144,
"domNodes": -3337,
"jsHeapTotalBytes": 18530304,
"scriptDurationMs": 926.123,
"eventListeners": -651,
"totalBlockingTimeMs": 84,
"frameDurationMs": 37.52904411764706,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 29549.791000000027,
"styleRecalcs": 181,
"styleRecalcDurationMs": 26.656000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29121.261,
"heapDeltaBytes": -65721152,
"heapUsedBytes": 263089276,
"domNodes": -3337,
"jsHeapTotalBytes": -4206592,
"scriptDurationMs": 975.813,
"eventListeners": -651,
"totalBlockingTimeMs": 35,
"frameDurationMs": 55.128544776119405,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8471.442999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 92.41200000000002,
"layouts": 20,
"layoutDurationMs": 27.427000000000007,
"taskDurationMs": 8288.222999999998,
"heapDeltaBytes": -40829904,
"heapUsedBytes": 278731208,
"domNodes": -3337,
"jsHeapTotalBytes": 4968448,
"scriptDurationMs": 127.061,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.012499999999996,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8918.318,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.417,
"layouts": 20,
"layoutDurationMs": 29.985,
"taskDurationMs": 8750.181,
"heapDeltaBytes": -13898360,
"heapUsedBytes": 290909776,
"domNodes": -3337,
"jsHeapTotalBytes": 2084864,
"scriptDurationMs": 141.068,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.99065934065935,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8215.550000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7797.5459999999985,
"heapDeltaBytes": -4385556,
"heapUsedBytes": 285133120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.16199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.234707903780066,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12390.79199999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11991.221,
"heapDeltaBytes": -4243152,
"heapUsedBytes": 262429344,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 188.62099999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.89020270270269,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 520.103000000006,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.702000000000002,
"layouts": 14,
"layoutDurationMs": 5.688000000000001,
"taskDurationMs": 184.35700000000003,
"heapDeltaBytes": -12368784,
"heapUsedBytes": 89042716,
"domNodes": 128,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 21.625,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 136.91099999994094,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.758000000000001,
"layouts": 8,
"layoutDurationMs": 3.9769999999999994,
"taskDurationMs": 95.35000000000001,
"heapDeltaBytes": 4656196,
"heapUsedBytes": 106147560,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.003,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 754.8299999999699,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7649999999999999,
"layouts": 76,
"layoutDurationMs": 20.722,
"taskDurationMs": 674.432,
"heapDeltaBytes": 14147968,
"heapUsedBytes": 96443304,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 325.27,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667391304347824,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 754.3849999999566,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8720000000000001,
"layouts": 76,
"layoutDurationMs": 20.187,
"taskDurationMs": 688.3290000000001,
"heapDeltaBytes": 14625736,
"heapUsedBytes": 83674408,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 333.069,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 787.5950000000103,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.806,
"layouts": 76,
"layoutDurationMs": 19.779,
"taskDurationMs": 721.8610000000001,
"heapDeltaBytes": 2454416,
"heapUsedBytes": 128921880,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 301.839,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.02127659574468,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 829.3139999999539,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.841,
"layouts": 76,
"layoutDurationMs": 20.613,
"taskDurationMs": 769.402,
"heapDeltaBytes": 2969724,
"heapUsedBytes": 123445636,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 318.68199999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.00199999999999,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 63.9% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2949 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2a9b5574c1761003744a4d546b915aa7e998e094
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (111)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.58 #21386 +/- ##
==============================================
- Coverage 87.64% 87.03% -0.61%
==============================================
Files 2808 2726 -82
Lines 153435 151376 -2059
Branches 40260 39142 -1118
==============================================
- Hits 134481 131755 -2726
- Misses 18406 19231 +825
+ Partials 548 390 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 166 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #21362 to
cloud/1.58Automatically created by backport workflow.