Repository navigation
test(agent): type bound-canvas refusal fixture - #21375
Conversation
📦 Bundle: 11.6 MB gzip 🔴 +123 BDetailsSummary
Category Glance App Entry Points — 6.84 kB (baseline 6.84 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.42 MB (baseline 3.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 834 kB (baseline 834 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 3 added / 3 removed / 32 unchanged User & Accounts — 148 kB (baseline 148 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 17 unchanged Editors & Dialogs — 375 kB (baseline 375 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 14 unchanged UI Components — 228 kB (baseline 228 kB) • ⚪ 0 BReusable component library chunks Status: 30 unchanged Data & Services — 1.21 MB (baseline 1.21 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed / 41 unchanged Utilities & Hooks — 1.01 MB (baseline 1.01 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 75 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 20.6 MB (baseline 20.6 MB) • 🔴 +370 BBundles that do not match a named category
Status: 5 added / 5 removed / 680 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-21T09:30:45.096Z",
"gitSha": "f3e97b954bf142e96818d999cbc3e5dd8cf3b0ba",
"branch": "oploop-781i-fe21238-followup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.1069999999954,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1740000000000004,
"layouts": 11,
"layoutDurationMs": 2.926,
"taskDurationMs": 376.424,
"heapDeltaBytes": -17137000,
"heapUsedBytes": 88430696,
"domNodes": -182,
"jsHeapTotalBytes": 1716224,
"scriptDurationMs": 8.697999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.9539999999934,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9090000000000003,
"layouts": 10,
"layoutDurationMs": 2.5149999999999997,
"taskDurationMs": 353.58,
"heapDeltaBytes": -1593300,
"heapUsedBytes": 103472944,
"domNodes": -202,
"jsHeapTotalBytes": 2355200,
"scriptDurationMs": 7.991000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.9620000000086,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.604999999999999,
"layouts": 9,
"layoutDurationMs": 2.281,
"taskDurationMs": 633.42,
"heapDeltaBytes": -8092436,
"heapUsedBytes": 89206756,
"domNodes": -202,
"jsHeapTotalBytes": -1966080,
"scriptDurationMs": 111.16699999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.77500000003,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.26,
"layouts": 11,
"layoutDurationMs": 2.8409999999999997,
"taskDurationMs": 544.957,
"heapDeltaBytes": 3878988,
"heapUsedBytes": 108524524,
"domNodes": -182,
"jsHeapTotalBytes": 1925120,
"scriptDurationMs": 107.81,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.8850000000093,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.291,
"layouts": 12,
"layoutDurationMs": 3.0140000000000002,
"taskDurationMs": 300.80600000000004,
"heapDeltaBytes": -603476,
"heapUsedBytes": 103583276,
"domNodes": 58,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.416,
"eventListeners": 42,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.4719999999816,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.623,
"layouts": 11,
"layoutDurationMs": 2.587,
"taskDurationMs": 211.16000000000003,
"heapDeltaBytes": 510244,
"heapUsedBytes": 98345340,
"domNodes": 58,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 10.549000000000001,
"eventListeners": 42,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 543.6419999999771,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.9169999999999994,
"layouts": 9,
"layoutDurationMs": 2.395,
"taskDurationMs": 336.418,
"heapDeltaBytes": 8562680,
"heapUsedBytes": 121087328,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 112.064,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 544.5200000000341,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.204,
"layouts": 10,
"layoutDurationMs": 2.555,
"taskDurationMs": 337.798,
"heapDeltaBytes": 6605336,
"heapUsedBytes": 110960868,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 123.09200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 896.9710000000077,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.427,
"heapDeltaBytes": 22456936,
"heapUsedBytes": 122507200,
"domNodes": 0,
"jsHeapTotalBytes": 16678912,
"scriptDurationMs": 39.439,
"eventListeners": 0,
"totalBlockingTimeMs": 288,
"frameDurationMs": 26.470588235294116,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 886.098000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.27299999999997,
"heapDeltaBytes": 19230528,
"heapUsedBytes": 119583852,
"domNodes": 0,
"jsHeapTotalBytes": 17203200,
"scriptDurationMs": 40.093,
"eventListeners": 0,
"totalBlockingTimeMs": 265,
"frameDurationMs": 25.9764705882353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.1230000000287,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.7979999999998,
"heapDeltaBytes": -3971684,
"heapUsedBytes": 103196024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.70500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 20.58529411764705,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 684.8249999999894,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 260.049,
"heapDeltaBytes": -4851648,
"heapUsedBytes": 102286256,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.16000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 82,
"frameDurationMs": 20.097058823529416,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6462.342999999975,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.39400000000000024,
"layouts": 1,
"layoutDurationMs": 0.25300000000000017,
"taskDurationMs": 5336.004,
"heapDeltaBytes": -34744,
"heapUsedBytes": 111472096,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 4222.366,
"eventListeners": 0,
"totalBlockingTimeMs": 10,
"frameDurationMs": 21.063192182410425,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6234.221999999989,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.053000000000000096,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5222.84,
"heapDeltaBytes": -8657132,
"heapUsedBytes": 102719368,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 4095.254000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.1031914893617,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6455.3259999999855,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6359999999999995,
"layouts": 2,
"layoutDurationMs": 0.5479999999999998,
"taskDurationMs": 5244.432,
"heapDeltaBytes": -1911796,
"heapUsedBytes": 110224380,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 4042.845,
"eventListeners": 0,
"totalBlockingTimeMs": 5,
"frameDurationMs": 19.784355828220857,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6521.165999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5417.888000000001,
"heapDeltaBytes": -1149584,
"heapUsedBytes": 110371200,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 4134.79,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.797575757575757,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 145.15800000003765,
"styleRecalcs": 20,
"styleRecalcDurationMs": 11.637000000000002,
"layouts": 10,
"layoutDurationMs": 2.7079999999999993,
"taskDurationMs": 98.80600000000001,
"heapDeltaBytes": 14708636,
"heapUsedBytes": 108434204,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.128,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.216666666666622,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 150.55799999998953,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.295,
"layouts": 10,
"layoutDurationMs": 2.5460000000000003,
"taskDurationMs": 112.94999999999999,
"heapDeltaBytes": 14752028,
"heapUsedBytes": 107308956,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.448,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2027.9439999999909,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2630000000000003,
"layouts": 7,
"layoutDurationMs": 1.8370000000000002,
"taskDurationMs": 409.41900000000004,
"heapDeltaBytes": -22497112,
"heapUsedBytes": 104184324,
"domNodes": -278,
"jsHeapTotalBytes": -6656000,
"scriptDurationMs": 27.306000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2038.8120000000072,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.631,
"layouts": 9,
"layoutDurationMs": 2.633,
"taskDurationMs": 422.022,
"heapDeltaBytes": -7041080,
"heapUsedBytes": 104801724,
"domNodes": -278,
"jsHeapTotalBytes": -6033408,
"scriptDurationMs": 29.310000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2576.656000000014,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.565,
"layouts": 7,
"layoutDurationMs": 2.012,
"taskDurationMs": 1257.835,
"heapDeltaBytes": -34231224,
"heapUsedBytes": 94128708,
"domNodes": -298,
"jsHeapTotalBytes": 1355776,
"scriptDurationMs": 573.508,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.774025974025975,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2578.07600000001,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.406000000000002,
"layouts": 6,
"layoutDurationMs": 1.415,
"taskDurationMs": 1215.529,
"heapDeltaBytes": -1873408,
"heapUsedBytes": 109359964,
"domNodes": -298,
"jsHeapTotalBytes": -6070272,
"scriptDurationMs": 569.65,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6658064516129,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3769.085000000018,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.183000000000002,
"layouts": 63,
"layoutDurationMs": 11.306000000000001,
"taskDurationMs": 1256.9880000000003,
"heapDeltaBytes": 4054560,
"heapUsedBytes": 99258616,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 544.602,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666371681415928,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3624.7050000000627,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.748000000000001,
"layouts": 65,
"layoutDurationMs": 11.903,
"taskDurationMs": 1296.7009999999998,
"heapDeltaBytes": -9736812,
"heapUsedBytes": 101469388,
"domNodes": -274,
"jsHeapTotalBytes": -2822144,
"scriptDurationMs": 531.873,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2384.3310000000315,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.812000000000001,
"layouts": 4,
"layoutDurationMs": 1.0639999999999998,
"taskDurationMs": 1250.196,
"heapDeltaBytes": 6148968,
"heapUsedBytes": 102165552,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 661.023,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66549295774648,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2981.3310000000683,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.406000000000001,
"layouts": 6,
"layoutDurationMs": 1.4000000000000001,
"taskDurationMs": 1437.829,
"heapDeltaBytes": 18112088,
"heapUsedBytes": 110902840,
"domNodes": -298,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 698.187,
"eventListeners": 52,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659217877095,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.611999999986,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3809999999999993,
"layouts": 7,
"layoutDurationMs": 1.9620000000000002,
"taskDurationMs": 538.235,
"heapDeltaBytes": -22908780,
"heapUsedBytes": 105279708,
"domNodes": -278,
"jsHeapTotalBytes": -5083136,
"scriptDurationMs": 35.763,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.3170000000673,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9020000000000001,
"layouts": 6,
"layoutDurationMs": 1.667,
"taskDurationMs": 399.495,
"heapDeltaBytes": 12578188,
"heapUsedBytes": 105684652,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.738999999999997,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 505.2970000000414,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.3790000000000004,
"layouts": 11,
"layoutDurationMs": 2.8789999999999996,
"taskDurationMs": 317.556,
"heapDeltaBytes": 23027476,
"heapUsedBytes": 122656608,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 101.941,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 444.1359999999577,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.111,
"layouts": 11,
"layoutDurationMs": 2.8069999999999995,
"taskDurationMs": 303.268,
"heapDeltaBytes": 1243232,
"heapUsedBytes": 109976340,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 98.474,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.7509999999943,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.164,
"layouts": 10,
"layoutDurationMs": 2.8769999999999993,
"taskDurationMs": 316.454,
"heapDeltaBytes": -23006128,
"heapUsedBytes": 83182600,
"domNodes": -220,
"jsHeapTotalBytes": 2449408,
"scriptDurationMs": 8.780000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2025.0280000000203,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.044,
"layouts": 11,
"layoutDurationMs": 2.7940000000000005,
"taskDurationMs": 354.44,
"heapDeltaBytes": 2169616,
"heapUsedBytes": 108131760,
"domNodes": -200,
"jsHeapTotalBytes": 2879488,
"scriptDurationMs": 6.988999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.0630000000283,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.812,
"layouts": 9,
"layoutDurationMs": 2.087,
"taskDurationMs": 578.121,
"heapDeltaBytes": -8234504,
"heapUsedBytes": 90040080,
"domNodes": -200,
"jsHeapTotalBytes": -1613824,
"scriptDurationMs": 83.764,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.4520000000457,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.015,
"layouts": 9,
"layoutDurationMs": 2.1989999999999994,
"taskDurationMs": 621.31,
"heapDeltaBytes": 1490484,
"heapUsedBytes": 99294460,
"domNodes": -200,
"jsHeapTotalBytes": -1314816,
"scriptDurationMs": 87.554,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1001.5070000000037,
"styleRecalcs": 21,
"styleRecalcDurationMs": 17.448999999999998,
"layouts": 5,
"layoutDurationMs": 9.925999999999997,
"taskDurationMs": 742.4570000000001,
"heapDeltaBytes": 11782740,
"heapUsedBytes": 124882048,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 22.768000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 91,
"frameDurationMs": 19.181132075471705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8612.67399999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.421,
"layouts": 7,
"layoutDurationMs": 1.7409999999999999,
"taskDurationMs": 4162.320000000001,
"heapDeltaBytes": 572272,
"heapUsedBytes": 110157756,
"domNodes": -278,
"jsHeapTotalBytes": -2797568,
"scriptDurationMs": 1917.293,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8774.842000000035,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.292,
"layouts": 9,
"layoutDurationMs": 2.2760000000000002,
"taskDurationMs": 4260.3640000000005,
"heapDeltaBytes": -291892,
"heapUsedBytes": 109168452,
"domNodes": -278,
"jsHeapTotalBytes": -4497408,
"scriptDurationMs": 1950.936,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66596958174905,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16656.63900000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15796.862999999998,
"heapDeltaBytes": -26514788,
"heapUsedBytes": 288831432,
"domNodes": -307,
"jsHeapTotalBytes": 22269952,
"scriptDurationMs": 222.41300000000004,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.558147512864497,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16602.157000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15654.244999999999,
"heapDeltaBytes": -1640528,
"heapUsedBytes": 309298180,
"domNodes": -3343,
"jsHeapTotalBytes": 25415680,
"scriptDurationMs": 219.38200000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.472212692967403,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 15069.169999999986,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.318999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14574.619999999999,
"heapDeltaBytes": -12554676,
"heapUsedBytes": 302569052,
"domNodes": -3343,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 628.511,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 26.837722419928827,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 18637.118999999984,
"styleRecalcs": 146,
"styleRecalcDurationMs": 18.435000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18275.589999999997,
"heapDeltaBytes": -19257748,
"heapUsedBytes": 302091560,
"domNodes": -3343,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 654.489,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.377306273062736,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6117.8590000000095,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.783,
"layouts": 20,
"layoutDurationMs": 28.933,
"taskDurationMs": 6014.124000000001,
"heapDeltaBytes": -27790088,
"heapUsedBytes": 307374068,
"domNodes": -3343,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 93.44899999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.556497175141246,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4669.269999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.947,
"layouts": 20,
"layoutDurationMs": 22.761000000000003,
"taskDurationMs": 4486.738,
"heapDeltaBytes": -16289528,
"heapUsedBytes": 298742496,
"domNodes": -3343,
"jsHeapTotalBytes": 29609984,
"scriptDurationMs": 77.17699999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.514204545454547,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8358.992999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7965.889000000001,
"heapDeltaBytes": 23881976,
"heapUsedBytes": 315797464,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.74000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.113131313131316,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8256.072000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7741.1669999999995,
"heapDeltaBytes": -8616376,
"heapUsedBytes": 286911396,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 108.549,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.05986394557824,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 459.3720000000303,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.304,
"layouts": 12,
"layoutDurationMs": 3.8670000000000004,
"taskDurationMs": 102.641,
"heapDeltaBytes": 7346172,
"heapUsedBytes": 104265092,
"domNodes": 136,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.318999999999999,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 93.87900000001537,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.986,
"layouts": 7,
"layoutDurationMs": 2.7359999999999998,
"taskDurationMs": 64.95,
"heapDeltaBytes": 4665332,
"heapUsedBytes": 106425632,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.709,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 231.38300000005074,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7,
"layouts": 76,
"layoutDurationMs": 11.517,
"taskDurationMs": 194.578,
"heapDeltaBytes": 9706544,
"heapUsedBytes": 95466520,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 85.319,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 207.73699999995188,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.635,
"layouts": 76,
"layoutDurationMs": 11.238,
"taskDurationMs": 178.21399999999997,
"heapDeltaBytes": 9562196,
"heapUsedBytes": 97305052,
"domNodes": 4,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 76.351,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 253.01300000000992,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5050000000000001,
"layouts": 76,
"layoutDurationMs": 9.91,
"taskDurationMs": 213.503,
"heapDeltaBytes": -2416336,
"heapUsedBytes": 135256532,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 67.332,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 243.69200000001,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.368,
"layouts": 76,
"layoutDurationMs": 10.279,
"taskDurationMs": 211.339,
"heapDeltaBytes": -6398928,
"heapUsedBytes": 105850656,
"domNodes": 4,
"jsHeapTotalBytes": 1220608,
"scriptDurationMs": 65.872,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2995 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since dc3247704a35a1e07748a6cca1ab211bb682bce0
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (119)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
| ⚪ Nit | 2 |
Panel: 6/6 reviewers contributed findings.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 95 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21375 +/- ##
==========================================
+ Coverage 86.54% 87.47% +0.93%
==========================================
Files 3887 2712 -1175
Lines 180737 149926 -30811
Branches 49995 39658 -10337
==========================================
- Hits 156412 131150 -25262
+ Misses 22060 18143 -3917
+ Partials 2265 633 -1632
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1439 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The lifecycle imported the permanent refusal tuple from docFrameClient, so the two unit suites that fully mock that client failed at module load (crossWorkflowPending, useAgentCrdtFollower). Move the tuple and its union into docFrameCodes, the dependency-free wire-code module the lifecycle's siblings already use, restoring the lifecycle's prior dependency shape. Values and runtime behaviour are unchanged.
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit ab3200f has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
dante01yoon
left a comment
There was a problem hiding this comment.
One blocking contract issue remains: the new valid server-frame fixture is typed by a handwritten frontend wire interface (G3). The earlier review agreement to move it beside the mocks addresses the production-parser concern; the fixture still needs the backend-owned generated contract.
Exact-head validation with this checkout’s own frozen install: 43 focused unit tests, app/browser typechecks, production Cloud build and all 3 bound-canvas browser cases PASS. A separate built mutation reducing ownership to bound ID only fails the refused-follower case at draftNodeCount, while both controls PASS; restored head passes all 3 again. Changed-file type-aware oxlint, format and ESLint PASS. Current required checks PASS on this SHA. Browser evidence uses a real local core backend with controlled Cloud/agent transport fixtures; no live agent execution was claimed.
|
|
||
| const CANCEL_ACCEPTED: AgentCancelAccepted = { status: 'cancelling' } | ||
|
|
||
| interface RawPermanentDocSubscribedRefusalFrame { |
There was a problem hiding this comment.
issue: RawPermanentDocSubscribedRefusalFrame redeclares the raw server doc_subscribed response (v, workflow_id, ok, code, expected_seq, message) in the frontend. Cloud owns this shape in common/websocket/messages/crdt.go (DocSubscribedFrame), but this interface and the imported refusal-code union are both frontend declarations, so satisfies cannot detect backend contract drift. I read the resolved discussion accepting the move beside the mocks; that fixes where the type lives, while generated contract provenance remains missing. Could we publish/generate the raw socket frame contract into the shared types and import it here, narrowing the generated type for this valid permanent-refusal fixture? If that export is not available yet, please land the shared contract first.
There was a problem hiding this comment.
Agreed; this is substantive and I am preserving the requested-changes verdict. The producer-owned contract landed in Comfy-Org/cloud#14529 (merge b9a4f9c361e0fed9baeb981c712beb22b8da84e2), and its successful projection workflow opened #21450 at f504570 with the generated DocSubscribedFrame/DocSubscribedData exports. #21450 is still open, so I am not folding or duplicating those generated files here. Wake condition: after #21450 merges to main, replace RawPermanentDocSubscribedRefusalFrame with a narrowing of the generated DocSubscribedFrame, rerun the 43 focused unit tests plus all three bound-canvas browser cases and the mutation check, then request a fresh exact-head review.
There was a problem hiding this comment.
Fixed in a7bc25c after merging main with #21450. The fixture now directly satisfies the generated DocSubscribedFrame export; RawPermanentDocSubscribedRefusalFrame and its frontend refusal-code type dependency are removed, with no adapter or cast. Exact-head evidence: 32/32 lifecycle unit tests, app/browser typechecks, targeted static checks, and 3/3 bound-canvas browser cases passed. The fixture bytes/assertions did not change, so the existing refused-follower mutation proof still applies. Fresh review requested.
There was a problem hiding this comment.
One gap against the "narrow the generated type" part: the fixture uses DocSubscribedFrame as generated, and the generated code is a plain string, so the type no longer pins code to a permanent-refusal value. I left it that way because narrowing code means re-adding a frontend-declared union, which is what this thread flagged. A wrong code still fails at runtime: the refused-follower case expects exactly one sync-failure toast, and unsupported or a retryable code produces none. If you want the compile-time pin anyway, satisfies DocSubscribedFrame & { data: { ok: false } } (or adding the code union) is a one-line change.
There was a problem hiding this comment.
Narrowed in 8f63899: the fixture now satisfies DocSubscribedFrame & { data: { ok: false; code: PermanentDocSubscribeRefusalCode } }.
- Generated contract stays the base, so backend drift still fails to compile.
ok: true, a retryable code (conflict), or a missing code now fail typecheck. At a7bc25c all three compiled.- Type-only: transpiled JS of the file is byte-identical, so the 3/3 bound-canvas browser proof carries over.
Full context for agent readers
Mutation matrix, pnpm typecheck:browser on the PR file:
| Mutation | a7bc25c (generated as-is) | 8f63899 (narrowed) |
|---|---|---|
| none | pass | pass |
ok: true |
pass | TS2322 |
code: 'conflict' |
pass | TS2322 |
| code removed | pass | TS2322 |
workflow_id renamed workflowId |
TS2561 | TS2561 (generated contract still the base) |
PermanentDocSubscribeRefusalCode is the production union the lifecycle uses to decide a refusal is permanent. Narrowing to it ties the fixture to the classifier under test; it adds no handwritten wire shape. ts.transpileModule output for the file is identical at both heads (sha256 488206552ea9…). Commit and push hooks passed: oxfmt, type-aware oxlint, server-facts, typecheck:browser, depcruise, knip, fallow (no issues in 5 changed files).
a7bc25c
|
Addressed the blocking generated-contract finding from #21375 (review) in a7bc25c. The refusal fixture now directly satisfies the backend-owned DocSubscribedFrame export added by #21450; the handwritten wire interface is removed, with no adapter or cast. Exact-head validation: 32/32 focused lifecycle unit tests, app and browser typechecks, targeted oxfmt/type-aware oxlint/ESLint, and 3/3 bound-canvas browser cases passed. The fixture bytes and assertions are unchanged, so the existing refused-follower mutation proof remains applicable. Pre-push dependency, Knip, and changed-file Fallow gates also passed. Please provide a fresh review on this head. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 8f63899 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
There was a problem hiding this comment.
Verdict: ready for human review
No blocking defects at 8f63899. The refusal-code refactor keeps runtime behavior identical to main, and the fixture now types against the generated DocSubscribedFrame. What I have left is five P3 items, inline: three comments the repo rules say should go with the code this PR touches, and two placement nits.
dante01yoon's requested-changes review is still on record at ab3200f. I think the current head addresses it (details below), but dismissing it is his call.
Findings without an anchorable line
- P3, integration note. Two open PRs add the same
userMessageBubblesfield tobrowser_tests/fixtures/components/AgentPanel.ts: #21512 and #21113. Each declarespublic readonly userMessageBubbles: Locatorand assignsthis.root.getByTestId('user-message-bubble'), at different spots than this PR does. Whichever lands second has to drop its copy, or the class gets a duplicate member. Nothing needs to change here, but it would help to tell those authors.
Existing findings confirmed or contested
- github-actions, untyped
SILENT_PERMANENT_REFUSAL_CODES(agentCrdtDocLifecycle.ts): addressed. The set is nowReadonlySet<PermanentDocSubscribeRefusalCode>, andisPermanentSubscribeRefusalCodenarrows beforeisNotifyingPermanentRefusalCoderuns. I compared the transpiled base and head lifecycle in a VM across 50 code and event sequences: undefined, unknown, and retryable codes; each of the three permanent codes; duplicate refusals; a refusal after a confirm; reconnect; retarget. Timers, notifications, return values, and latch state matched in every case. - github-actions, handwritten wire type exported from
docFrameClient.ts: addressed. That export is gone, and the fixture imports the generated type. - github-actions, test-specific message in
expectTurnSettled: addressed. The message now reads "the active turn must settle before another turn is composed". The two assertions (stop button gone, composer empty) are unchanged from the old spec helper. - dante01yoon, fixture typed by a handwritten frontend interface (
agentPanelMocks.ts): addressed, in my reading. The fixture usessatisfies DocSubscribedFrame & { data: { ok: false; code: PermanentDocSubscribeRefusalCode } }. The generated type is still the base, so every generated field keeps its obligations, and the intersection only narrowsokandcode. Nothing is redeclared or omitted, which fitsdocs/guidance/typescript.md's allowance for a thin intersection on a generated export. I ran a compiler check against the real generated type and the production union. It accepts the fixture and rejectsok: true,code: 'conflict', a missing code, and a stringv. One limit: generatedDocSubscribedData.codeisstring | undefinedand the generated package has no refusal-code enum, so the narrowing guards fixture shape, not whether the three-code list matches the backend.
Review record
- E1 (Low, github-actions, untyped silent set): addressed in
1b3104e2fd, author reply in thread. - E2 (Nit, github-actions, production wire type): addressed in
1b3104e2fd, then replaced with the generated type ina7bc25c205. - E3 (Nit, github-actions, assertion message): addressed in
1b3104e2fd. - E4 (blocking, dante01yoon, generated contract): addressed in
a7bc25c205and narrowed in8f63899255. dante01yoon has not re-reviewed yet. - This round: P3 export placement in
docFrameCodes.ts, P3 nit on the readiness helper's placement, three P3 comment deletions inagentCrdtDocLifecycle.ts, P3 integration note on #21512/#21113. All open.
Checks at 8f63899: every CI check run is success or skipped, including the four cloud Playwright shards, the new-test video run, the unit shards, typecheck, lint, and knip. playwright test --list --project=cloud finds the three bound-canvas cases. agentPanelMocks.ts transpiles byte-identically at HEAD^ and HEAD. I did not replay the historical followerOwnsDocument mutation proof. The spec still asserts populated draft nodes after the refusal.
Checked and cleared
- Open #16806 has the opposite permanent-refusal policy. It treats
invalid_frameas permanent and letsschema_version_mismatch/catalog_mismatchfall through to retry. That conflict is between #16806 and main, which already has this PR's three-code policy, and this PR doesn't change it (runtime comparison above). Not introduced here. If #16806 is revived, it should use the lifecycle's classification. - Stale references in
useAgentCrdtFollower.ts. Its comments namePERMANENT_SUBSCRIBE_REFUSAL_CODES, which still exists in the lifecycle, so they're accurate at this head. They would go stale if the set moves per thedocFrameCodes.tscomment. - Raw
getByTestId('user-message-bubble')in other specs. 39 call sites in 17 other spec files still use it. This PR migrates every call in the spec it changes and adds no compatibility layer, so a broader migration is out of scope. expectimported from@playwright/testinagentPanelMocks.ts. That matchesagentCreditsExhaustionLifecycleMocks.ts,agentTurnLockFixture.ts, and the AgentPanel page object.expectTurnSettledassertions redundant? No. Stop-button count and empty composer are separate facts.- Done-frame race. The bubble renders after the turn becomes active, so waiting on the bubble text is a real readiness boundary for every current caller.
- Lifecycle unit coverage.
agentCrdtDocLifecycle.test.tsalready covers notifying permanent codes, silentunsupported, and retry for non-permanent codes. No new test is needed for a type-only change.
Coverage
Depth standard. I ran the correctness, maintainability, and tests lanes over all five files. Correctness used blast-radius, regression-risk, boundary-discipline, fix-root-causes, idempotency, and type-system lenses. Maintainability used ponytail, no-comments (zero comment blocks added; four existing blocks in modified code, three flagged, one JSDoc kept), minimize-reader-load, migrate-callers, and type-system. Tests used designing-test-suites, playwright spec review, flaky-e2e, mock-quality, and writing-playwright-tests. The open-PR search covered the changed files plus docFrameClient.ts, useAgentCrdtFollower.ts, the generated ingest frames, and the AgentPanel page object. It was keyword-based, so it may miss an open PR that touches these with an unrelated title. I did not start a local backend; browser evidence comes from CI.
The block above PERMANENT_SUBSCRIBE_REFUSAL_CODES is deleted because this PR modifies that declaration. Its rationale, kept here for history: PM-1604 / BE-11437 are the doc-host's terminal classifications for a document this build can never read back, so these codes skip the retry ladder and latch the same give-up exit an unanswered ack times out into. schema_version_mismatch and catalog_mismatch are cloud's socketDocCode() sibling arms; unsupported (docSurfaceOffReason) is permanent for the life of the connection. Addresses review feedback: #21375 (comment)
SILENT_PERMANENT_REFUSAL_CODES is retyped by this PR, so its comment goes. Rationale for history: unsupported means the doc surface is off for the whole deployment, so latching it must not show an incompatible-document toast. Addresses review feedback: #21375 (comment)
onSubscribeRefused changes in this PR, so its comment goes. The early return already shows the ordering: a stale straggler returns before any probe or backoff timer is cleared. Addresses review feedback: #21375 (comment)
The permanent subscribe-refusal tuple is now private to docFrameCodes, next to the set and the isPermanentSubscribeRefusalCode guard that give it meaning, matching RETRYABLE_RESEED_CODES and isRetryableReseedCode. The lifecycle imports the guard instead of copying the tuple into its own set. The set keeps the PERMANENT_SUBSCRIBE_REFUSAL_CODES name that useAgentCrdtFollower refers to. Addresses review feedback: #21375 (comment)
pushTurnDoneOnceTurnIsActive mixed a DOM assertion with a transport push. The assertion is now AgentPanel.expectUserMessages, beside expectTurnSettled, and each bound-canvas case pushes MESSAGE_DONE_EVENT after it. The helper and the mocks module's expect import are removed. Addresses review feedback: #21375 (comment)
707f056
|
@dante01yoon ready for your re-review at 707f056fc4.
Full context for agent readersCommits since 8f63899, one per review thread:
Validation: 187 CRDT unit tests (lifecycle, frame client, follower), |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 707f056 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
There was a problem hiding this comment.
Verdict: ready for human review
All five items from my last review are fixed at 707f056, and the follow-up commits add no new issues. The only open item on the PR is dante01yoon's requested-changes review from ab3200f. I think the generated-contract point it raised has been met since 8f63899, but updating or dismissing that review is up to him.
Open items since my last review
- christian-byrne's re-review request to dante01yoon (comment): confirmed. The fixture in
agentPanelMocks.tsis stillsatisfies DocSubscribedFrame & { data: { ok: false; code: PermanentDocSubscribeRefusalCode } }, unchanged since8f63899. Last round I checked it against the real generated type: it rejectsok: true,code: 'conflict', a missing code, and a stringv. The comment's summary of the five follow-up commits matches the diff. - comfy-greenlight-bot approval at
707f056: a bot approval, so I have nothing to respond to.
Delta reviewed (`8f63899..707f056`)
docFrameCodes.tsnow keeps the tuple private and exportsisPermanentSubscribeRefusalCodebeside it. The guard body moved verbatim, so classification is unchanged. A repo search finds no other consumer of the tuple.AgentPanel.expectUserMessages(prompts)replaces the mocks-module helper, along with itsexpectimport. All three bound-canvas cases still assert the rendered prompt before pushingMESSAGE_DONE_EVENT, in the same order as before.- The three comment blocks in
agentCrdtDocLifecycle.tsare gone, and the delta adds no new comments. - Checked and cleared: the moved readiness check no longer has its precondition message. That's fine for a generic page-object method, since a failure still names the locator and the expected prompts. The comments in
useAgentCrdtFollower.tsstill namePERMANENT_SUBSCRIBE_REFUSAL_CODES, which still exists with the same meaning (now indocFrameCodes.ts), so they are accurate. - I re-ran the open-PR search on PRs updated since my last round. Of the PRs regenerating the ingest types, #21508 and #21422 carry
DocSubscribedData/DocSubscribedFrameidentical to main's. #21524 touches only the dock locators inAgentPanel.ts, and #21527 touches the follower but not refusal handling. #21512 and #21113 still add their ownuserMessageBubblesfield (the P3 integration note from last round), so whichever merges after this PR should drop its copy.
Review record
Round 1 (review):
- P3, permanent-refusal tuple exported only to be wrapped in the lifecycle: addressed in
d21d2f6a5e, author reply. - P3 Nit, readiness assertion in the mocks module instead of the page object: addressed in
707f056fc4, author reply. - P3, comment block above the permanent-code set: addressed in
a0df110851, author reply. - P3, comment above the silent-code set: addressed in
901126a59f, author reply. - P3, comment inside
onSubscribeRefused: addressed in59a5e8a924, author reply. - P3, #21512/#21113 duplicate
userMessageBubbles: integration note, nothing to change in this PR.
Other reviewers:
- github-actions, untyped silent set: addressed in
1b3104e2fd. - github-actions, production-exported wire type: addressed in
1b3104e2fd, replaced with the generated type ina7bc25c205. - github-actions, test-specific assertion message: addressed in
1b3104e2fd. - dante01yoon, generated contract (blocking): addressed in
a7bc25c205and narrowed in8f63899255. His review is still CHANGES_REQUESTED until he re-reviews.
Checks at 707f056: all 127 CI check runs are success (98) or skipped (29). They include the four cloud Playwright shards, the cloud new-test video run, mobile-safari cloud, unit shards, typecheck, typecheck-aux, lint, and format. I reviewed the delta by reading the code against round 1's evidence: the runtime equivalence across 50 sequences, the compiler check of the fixture, and the three cases found by playwright test --list. The delta only moves code and deletes it, so I did not rerun those checks.
Stale over a verified repair at 707f056. The one finding (fixture typed by a handwritten wire interface, #21375 (comment)) was fixed in 8f63899: the fixture now satisfies DocSubscribedFrame & { data: { ok: false; code: PermanentDocSubscribeRefusalCode } }, with DocSubscribedFrame imported from the generated @comfyorg/ingest-types (types.gen.ts, from cloud via #21450). RawPermanentDocSubscribedRefusalFrame is gone. Independent typecheck:browser at 707f056: control passes; renaming workflow_id or v in the generated type (simulated backend drift) fails the fixture (TS2561/TS2353), as do ok:true, code 'conflict', and a missing code (TS2322). All required checks and the cloud Playwright shards pass on this head. Happy to reopen if you see a remaining gap.
| const PERMANENT_DOC_SUBSCRIBE_REFUSAL_CODES = [ | ||
| 'schema_version_mismatch', | ||
| 'catalog_mismatch', | ||
| 'unsupported' | ||
| ] as const |
There was a problem hiding this comment.
Should this be in an OpenAPI spec?
There was a problem hiding this comment.
The WebSocket frame already is producer-owned: Cloud PR 14529 put doc_subscribed in the ingest OpenAPI, and DocSubscribedFrame here is generated from it.
I do not think this tuple belongs in that schema. It is frontend policy for which valid refusal codes stop retrying, not a second wire shape. The generated schema currently exposes code as a string; if Cloud later publishes a closed refusal-code enum, we should consume that generated type and keep this client-policy subset separate.
#21375 landed the same AgentPanel page-object member, userMessageBubbles, that this branch adds. Git merges the two declarations cleanly, so the merged tree failed typecheck:browser with TS2300 duplicate identifier. Keep main's declaration and initializer and drop this branch's copies.
Summary
Follow up on #21238, which merged before two exact-head CodeRabbit findings were repaired. The raw permanent
doc_subscribedrefusal now satisfies a CRDT wire-boundary type with the three existing terminal codes, while repeated turn-state helpers and the user-message locator live in the Agent fixture/page object instead of the spec.No product behavior changes.
Verification
a8e134a988failed 2 cases, merged headb5d885b3ecpassed 3, and this follow-up passes all 3 focused cloud cases.followerOwnsDocumentto the incorrect bound-ID-only predicate fails the refused-follower case atdraftNodeCountwithReceived: undefined; restoring the production predicate passes the case.pnpm test:unit src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.test.ts src/workbench/extensions/agent/crdt/docFrameClient.test.ts— 43 passed.pnpm typecheck:browser, targeted type-aware oxlint, and oxfmt check passed.typecheck:app,typecheck:browser, dependency cruise, knip, fallow).