Repository navigation
fix(ci): run architecture check without --report on PR heads that predate it - #21349
Conversation
…date it Same-repo PRs check out the PR head, so a branch cut before the architecture CLI gained --report rejected the flag and failed lint, cascading into the other required checks. Only pass --report when the checked-out CLI knows it; the check's own exit code is unchanged. Co-Authored-By: Christian Byrne <cbyrne@comfy.org> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📦 Bundle: 11.6 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 6.95 kB (baseline 6.95 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.39 MB (baseline 3.39 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 784 kB (baseline 784 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 32 unchanged User & Accounts — 153 kB (baseline 153 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 17 unchanged Editors & Dialogs — 362 kB (baseline 362 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 13 unchanged UI Components — 225 kB (baseline 225 kB) • ⚪ 0 BReusable component library chunks Status: 30 unchanged Data & Services — 1.2 MB (baseline 1.2 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 43 unchanged Utilities & Hooks — 1.01 MB (baseline 1.01 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 77 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 20.6 MB (baseline 20.6 MB) • ⚪ 0 BBundles that do not match a named category
Status: 2 added / 2 removed / 685 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-19T06:03:22.726Z",
"gitSha": "e9921e1c825763fedb267e55c2b607c0502326bf",
"branch": "fe-3491-architecture-report-fallback",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.041000000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.6420000000000001,
"layouts": 11,
"layoutDurationMs": 1.783,
"taskDurationMs": 397.885,
"heapDeltaBytes": -12049648,
"heapUsedBytes": 86883816,
"domNodes": -200,
"jsHeapTotalBytes": 6721536,
"scriptDurationMs": 5.8900000000000015,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.957000000019,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.515,
"layouts": 10,
"layoutDurationMs": 1.6010000000000002,
"taskDurationMs": 304.529,
"heapDeltaBytes": -5451620,
"heapUsedBytes": 98285688,
"domNodes": -180,
"jsHeapTotalBytes": 2002944,
"scriptDurationMs": 5.883000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1688.5870000000125,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.838999999999999,
"layouts": 11,
"layoutDurationMs": 1.752,
"taskDurationMs": 506.459,
"heapDeltaBytes": 2315056,
"heapUsedBytes": 90232344,
"domNodes": -200,
"jsHeapTotalBytes": -1404928,
"scriptDurationMs": 87.20100000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673263,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.8490000000097,
"styleRecalcs": 73,
"styleRecalcDurationMs": 7.541999999999999,
"layouts": 10,
"layoutDurationMs": 1.516,
"taskDurationMs": 508.862,
"heapDeltaBytes": -8502424,
"heapUsedBytes": 95269828,
"domNodes": -180,
"jsHeapTotalBytes": 2789376,
"scriptDurationMs": 90.273,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.959000000012,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.283,
"layouts": 11,
"layoutDurationMs": 1.5140000000000002,
"taskDurationMs": 198.21999999999997,
"heapDeltaBytes": 4672740,
"heapUsedBytes": 103391968,
"domNodes": 47,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 6.753,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.328000000004,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.6409999999999996,
"layouts": 12,
"layoutDurationMs": 2.333,
"taskDurationMs": 223.402,
"heapDeltaBytes": 1864844,
"heapUsedBytes": 106033016,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.547999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 433.4140000000275,
"styleRecalcs": 15,
"styleRecalcDurationMs": 1.6579999999999997,
"layouts": 10,
"layoutDurationMs": 1.6829999999999998,
"taskDurationMs": 277.772,
"heapDeltaBytes": 6517784,
"heapUsedBytes": 110623844,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 101.616,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 482.16999999999643,
"styleRecalcs": 15,
"styleRecalcDurationMs": 1.494,
"layouts": 10,
"layoutDurationMs": 1.359,
"taskDurationMs": 300.194,
"heapDeltaBytes": 6499020,
"heapUsedBytes": 110182880,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 96.65,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 987.5030000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.03,
"heapDeltaBytes": -9140608,
"heapUsedBytes": 101888680,
"domNodes": -230,
"jsHeapTotalBytes": 9089024,
"scriptDurationMs": 38.1,
"eventListeners": -168,
"totalBlockingTimeMs": 333,
"frameDurationMs": 28.094285714285718,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 939.8449999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.252,
"heapDeltaBytes": -7841060,
"heapUsedBytes": 101756844,
"domNodes": -210,
"jsHeapTotalBytes": 9613312,
"scriptDurationMs": 35.81999999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 309,
"frameDurationMs": 27.142857142857128,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 699.0810000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.93999999999994,
"heapDeltaBytes": -4698636,
"heapUsedBytes": 97299540,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 76.509,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 713.5650000000169,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.6979999999999,
"heapDeltaBytes": -3364372,
"heapUsedBytes": 91495076,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 89.123,
"eventListeners": 0,
"totalBlockingTimeMs": 110,
"frameDurationMs": 21.715151515151497,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5874.299000000008,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5259999999999996,
"layouts": 3,
"layoutDurationMs": 0.47800000000000015,
"taskDurationMs": 4837.164,
"heapDeltaBytes": -8236088,
"heapUsedBytes": 113205612,
"domNodes": -276,
"jsHeapTotalBytes": 167936,
"scriptDurationMs": 3921.46,
"eventListeners": -130,
"totalBlockingTimeMs": 43,
"frameDurationMs": 19.480463576158943,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5769.445000000019,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.44899999999999973,
"layouts": 3,
"layoutDurationMs": 0.4680000000000001,
"taskDurationMs": 4937.875,
"heapDeltaBytes": 17908896,
"heapUsedBytes": 138925920,
"domNodes": -276,
"jsHeapTotalBytes": 31363072,
"scriptDurationMs": 3769.008,
"eventListeners": -130,
"totalBlockingTimeMs": 27,
"frameDurationMs": 18.020000000000003,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5933.780000000013,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.6240000000000004,
"layouts": 4,
"layoutDurationMs": 0.7539999999999999,
"taskDurationMs": 4973.9890000000005,
"heapDeltaBytes": 4307628,
"heapUsedBytes": 125490212,
"domNodes": -276,
"jsHeapTotalBytes": 28479488,
"scriptDurationMs": 3938.3940000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 33,
"frameDurationMs": 20.123809523809527,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5955.386000000033,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.43900000000000017,
"layouts": 3,
"layoutDurationMs": 0.399,
"taskDurationMs": 5088.762,
"heapDeltaBytes": 28538356,
"heapUsedBytes": 133508012,
"domNodes": -276,
"jsHeapTotalBytes": 20942848,
"scriptDurationMs": 3891.52,
"eventListeners": -130,
"totalBlockingTimeMs": 50,
"frameDurationMs": 18.94808917197452,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-combo-open",
"durationMs": 130.67700000001992,
"styleRecalcs": 21,
"styleRecalcDurationMs": 9.247,
"layouts": 12,
"layoutDurationMs": 2.194,
"taskDurationMs": 96.49700000000001,
"heapDeltaBytes": 13245076,
"heapUsedBytes": 120150052,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.548,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.057142857142804,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 142.84000000003516,
"styleRecalcs": 22,
"styleRecalcDurationMs": 9.171000000000003,
"layouts": 13,
"layoutDurationMs": 2.4280000000000004,
"taskDurationMs": 95.206,
"heapDeltaBytes": 13233552,
"heapUsedBytes": 118075924,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.6770000000000005,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.042857142857105,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2008.7859999999864,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.4960000000000004,
"layouts": 9,
"layoutDurationMs": 1.4089999999999998,
"taskDurationMs": 428.354,
"heapDeltaBytes": -20876824,
"heapUsedBytes": 90670600,
"domNodes": -296,
"jsHeapTotalBytes": -2650112,
"scriptDurationMs": 16.507999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2010.4010000000017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.3930000000000002,
"layouts": 9,
"layoutDurationMs": 1.4509999999999998,
"taskDurationMs": 457.0210000000001,
"heapDeltaBytes": 3107452,
"heapUsedBytes": 104968020,
"domNodes": -276,
"jsHeapTotalBytes": -5861376,
"scriptDurationMs": 17.384,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2096.0640000000126,
"styleRecalcs": 70,
"styleRecalcDurationMs": 4.800000000000001,
"layouts": 10,
"layoutDurationMs": 1.531,
"taskDurationMs": 881.4570000000001,
"heapDeltaBytes": 1272644,
"heapUsedBytes": 104701344,
"domNodes": -296,
"jsHeapTotalBytes": -393216,
"scriptDurationMs": 448.819,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666400000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2098.2849999999758,
"styleRecalcs": 69,
"styleRecalcDurationMs": 4.867,
"layouts": 9,
"layoutDurationMs": 1.2570000000000001,
"taskDurationMs": 986.069,
"heapDeltaBytes": 562188,
"heapUsedBytes": 103763180,
"domNodes": -296,
"jsHeapTotalBytes": -131072,
"scriptDurationMs": 504.85,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3107.221000000038,
"styleRecalcs": 72,
"styleRecalcDurationMs": 5.644,
"layouts": 66,
"layoutDurationMs": 6.896999999999999,
"taskDurationMs": 1077.179,
"heapDeltaBytes": 3898056,
"heapUsedBytes": 106688708,
"domNodes": 24,
"jsHeapTotalBytes": 4984832,
"scriptDurationMs": 445.516,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3121.928999999966,
"styleRecalcs": 74,
"styleRecalcDurationMs": 5.6819999999999995,
"layouts": 68,
"layoutDurationMs": 7.008,
"taskDurationMs": 965.167,
"heapDeltaBytes": 7182684,
"heapUsedBytes": 111473220,
"domNodes": 24,
"jsHeapTotalBytes": 4198400,
"scriptDurationMs": 426.17400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2168.5959999999795,
"styleRecalcs": 46,
"styleRecalcDurationMs": 2.762,
"layouts": 7,
"layoutDurationMs": 0.9199999999999998,
"taskDurationMs": 1140.558,
"heapDeltaBytes": -10895324,
"heapUsedBytes": 103891512,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 511.22600000000006,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538461,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2188.8849999999707,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.036,
"layouts": 7,
"layoutDurationMs": 1.1409999999999998,
"taskDurationMs": 1138.581,
"heapDeltaBytes": 17748464,
"heapUsedBytes": 123619788,
"domNodes": 0,
"jsHeapTotalBytes": 5402624,
"scriptDurationMs": 510.1150000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66641221374046,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.1300000000042,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.45,
"layouts": 9,
"layoutDurationMs": 1.503,
"taskDurationMs": 431.01900000000006,
"heapDeltaBytes": 472164,
"heapUsedBytes": 104327672,
"domNodes": -296,
"jsHeapTotalBytes": -5861376,
"scriptDurationMs": 15.227999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.022999999957,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.3610000000000002,
"layouts": 9,
"layoutDurationMs": 1.42,
"taskDurationMs": 420.26399999999995,
"heapDeltaBytes": 540520,
"heapUsedBytes": 103594572,
"domNodes": -296,
"jsHeapTotalBytes": -4550656,
"scriptDurationMs": 16.224,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 415.8639999999991,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.119,
"layouts": 10,
"layoutDurationMs": 1.3750000000000002,
"taskDurationMs": 261.55799999999994,
"heapDeltaBytes": 22529144,
"heapUsedBytes": 112881392,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 80.42399999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.96499999999105,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.0850000000000004,
"layouts": 10,
"layoutDurationMs": 1.5779999999999998,
"taskDurationMs": 274.94,
"heapDeltaBytes": 2742204,
"heapUsedBytes": 109035116,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 84.79599999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2010.0120000000175,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.5229999999999997,
"layouts": 10,
"layoutDurationMs": 1.4609999999999999,
"taskDurationMs": 305.99,
"heapDeltaBytes": -10333468,
"heapUsedBytes": 95816488,
"domNodes": -218,
"jsHeapTotalBytes": 2265088,
"scriptDurationMs": 5.357000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2011.4540000000147,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.431,
"layouts": 10,
"layoutDurationMs": 1.532,
"taskDurationMs": 289.546,
"heapDeltaBytes": 4607500,
"heapUsedBytes": 94970164,
"domNodes": -218,
"jsHeapTotalBytes": -1929216,
"scriptDurationMs": 5.177000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.161999999978,
"styleRecalcs": 76,
"styleRecalcDurationMs": 8.579,
"layouts": 10,
"layoutDurationMs": 1.76,
"taskDurationMs": 528.7270000000001,
"heapDeltaBytes": -17855484,
"heapUsedBytes": 88341736,
"domNodes": -210,
"jsHeapTotalBytes": 2527232,
"scriptDurationMs": 66.87400000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.5610000000256,
"styleRecalcs": 75,
"styleRecalcDurationMs": 7.752,
"layouts": 10,
"layoutDurationMs": 1.52,
"taskDurationMs": 466.673,
"heapDeltaBytes": -10717488,
"heapUsedBytes": 95026612,
"domNodes": -190,
"jsHeapTotalBytes": 3051520,
"scriptDurationMs": 58.119,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 817.0549999999821,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.204000000000002,
"layouts": 5,
"layoutDurationMs": 9.021,
"taskDurationMs": 637.6300000000001,
"heapDeltaBytes": 16278724,
"heapUsedBytes": 137378876,
"domNodes": 15950,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 16.262999999999998,
"eventListeners": 3244,
"totalBlockingTimeMs": 99,
"frameDurationMs": 20.4125,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8118.947999999989,
"styleRecalcs": 250,
"styleRecalcDurationMs": 14.383,
"layouts": 9,
"layoutDurationMs": 1.2460000000000002,
"taskDurationMs": 3517.4529999999995,
"heapDeltaBytes": -6045948,
"heapUsedBytes": 114844960,
"domNodes": -276,
"jsHeapTotalBytes": -290816,
"scriptDurationMs": 1530.155,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611909650924,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8154.3779999999515,
"styleRecalcs": 251,
"styleRecalcDurationMs": 14.354,
"layouts": 9,
"layoutDurationMs": 1.36,
"taskDurationMs": 3416.696,
"heapDeltaBytes": 3134752,
"heapUsedBytes": 105553676,
"domNodes": -296,
"jsHeapTotalBytes": -917504,
"scriptDurationMs": 1481.5690000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665848670756645,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 8431.828999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7608.798999999999,
"heapDeltaBytes": -35996256,
"heapUsedBytes": 288825960,
"domNodes": -3337,
"jsHeapTotalBytes": 36687872,
"scriptDurationMs": 83.82100000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.351646090534977,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12402.85,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11019.356,
"heapDeltaBytes": -25637824,
"heapUsedBytes": 284498264,
"domNodes": -3337,
"jsHeapTotalBytes": 25939968,
"scriptDurationMs": 96.839,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.839495798319327,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 13751.325000000008,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.990999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13015.425999999998,
"heapDeltaBytes": -18431380,
"heapUsedBytes": 282084012,
"domNodes": -3337,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 530.2819999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 48,
"frameDurationMs": 23.61252144082333,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 13797.33299999998,
"styleRecalcs": 65,
"styleRecalcDurationMs": 7.776000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13104.717999999999,
"heapDeltaBytes": -31496932,
"heapUsedBytes": 280213076,
"domNodes": -3337,
"jsHeapTotalBytes": -4206592,
"scriptDurationMs": 496.93399999999997,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.394336283185844,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4107.191999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 38.774000000000015,
"layouts": 20,
"layoutDurationMs": 15.273999999999996,
"taskDurationMs": 3976.157,
"heapDeltaBytes": -25044052,
"heapUsedBytes": 304987628,
"domNodes": -3367,
"jsHeapTotalBytes": 32231424,
"scriptDurationMs": 45.586,
"eventListeners": -691,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.933139534883722,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4061.272000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 37.603999999999985,
"layouts": 20,
"layoutDurationMs": 14.998999999999999,
"taskDurationMs": 3918.271,
"heapDeltaBytes": -32065532,
"heapUsedBytes": 278042140,
"domNodes": -3337,
"jsHeapTotalBytes": 28037120,
"scriptDurationMs": 41.08600000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.751685393258423,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 4134.445999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3582.2530000000006,
"heapDeltaBytes": 10505696,
"heapUsedBytes": 300858896,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.80699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.939344262295077,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6020.317999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5218.1669999999995,
"heapDeltaBytes": 14590336,
"heapUsedBytes": 312342820,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 43.321,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.326013513513512,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 445.22100000000364,
"styleRecalcs": 21,
"styleRecalcDurationMs": 7.686,
"layouts": 13,
"layoutDurationMs": 2.973,
"taskDurationMs": 110.401,
"heapDeltaBytes": -12535476,
"heapUsedBytes": 88852848,
"domNodes": 128,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.399,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 71.80800000003273,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.491999999999999,
"layouts": 5,
"layoutDurationMs": 1.208,
"taskDurationMs": 45.469,
"heapDeltaBytes": 4670140,
"heapUsedBytes": 106496268,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.569000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.649999999999977,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 254.99599999989186,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.47800000000000004,
"layouts": 76,
"layoutDurationMs": 11.661,
"taskDurationMs": 208.317,
"heapDeltaBytes": 9962672,
"heapUsedBytes": 96040264,
"domNodes": 4,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 91.24300000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 220.26400000004287,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.431,
"layouts": 76,
"layoutDurationMs": 10.645999999999999,
"taskDurationMs": 169.129,
"heapDeltaBytes": 9453448,
"heapUsedBytes": 97107232,
"domNodes": 4,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 70.547,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.653846153846153,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 243.69500000000244,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.073,
"layouts": 76,
"layoutDurationMs": 10.516,
"taskDurationMs": 204.012,
"heapDeltaBytes": -6871192,
"heapUsedBytes": 108355800,
"domNodes": 4,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 68.08500000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 276.5400000000682,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.232,
"layouts": 76,
"layoutDurationMs": 11.095,
"taskDurationMs": 228.692,
"heapDeltaBytes": -6223016,
"heapUsedBytes": 107011084,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 78.727,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 63.9% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2947 passed, 0 failed · 2 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 286917914daadbdc5145e0cdd5daf9cc772179b6
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (103)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 2 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 2 |
Panel: 6/6 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21349 +/- ##
==========================================
+ Coverage 86.65% 87.48% +0.82%
==========================================
Files 3775 2698 -1077
Lines 178549 149886 -28663
Branches 47255 41189 -6066
==========================================
- Hits 154725 131122 -23603
+ Misses 21757 18374 -3383
+ Partials 2067 390 -1677
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…ing its source Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
christian-byrne
left a comment
There was a problem hiding this comment.
Logic checks out against current main. Needs a human review; assigning @DrJKL.
Full context for agent readers
- Probe: on main,
tools/architecture/src/cli.tsreturns--report requires a file pathfor--report=(line 197-198), so heads with the new CLI take the--reportbranch. Older heads fail the probe with an unknown-option error and fall back to a plainpnpm architecture:check, which keeps the pass/fail signal. GITHUB_ACTIONS=on the probe keeps it from emitting annotations.- The fallback still writes a findings file, so the "Explain architecture verdict" step's
details-fileexists either way. - Main still runs
pnpm architecture:check --report "$RUNNER_TEMP/architecture-findings.md"unconditionally, so the problem this fixes is still live for older branches. - Head a24fc4e: mergeable, no failing checks, CodeRabbit approved. No human approval yet.
| findings="$RUNNER_TEMP/architecture-findings.md" | ||
| probe=$(GITHUB_ACTIONS= pnpm --silent architecture:check --report= 2>&1 || true) | ||
| if grep -q -- '--report requires a file path' <<< "$probe"; then | ||
| pnpm architecture:check --report "$findings" |
There was a problem hiding this comment.
Won't this now run it multiple times?
There was a problem hiding this comment.
Right: with --report= the full check never runs. parseOptions rejects the empty value (tools/architecture/src/cli.ts:197), and main returns 1 at line 208, before runArchitecture is called. So the probe costs only the time it takes to parse the arguments, and the real check still runs exactly once in whichever branch is chosen.
| id: architecture | ||
| if: ${{ !cancelled() && steps.setup.outcome == 'success' && hashFiles('tools/architecture/src/cli.ts') != '' }} | ||
| run: pnpm architecture:check --report "$RUNNER_TEMP/architecture-findings.md" | ||
| # PR heads branched before --report existed reject it; drop the fallback once those have rebased. |
There was a problem hiding this comment.
Not never, but you are right that the comment gives no checkable trigger. Here is a concrete one: the fallback can go once no open PR has a merge base older than eb0e38a (#21015, merged 2026-10-19). Right now 142 open PRs were created before that merge. Some have been rebased since; the rest will rebase or go stale. I left the comment wording as it is because a push to this branch would dismiss your approval. If you would like the comment to name that commit, say so and I will push it. Otherwise I can drop the fallback in a small follow-up once that condition holds.
|
Merging at a24fc4e via the merge queue. No backport needed. Full context for agent readers
|
ELI5
Pull requests started before a recent CI tooling change were all failing five required checks, even though nothing was wrong with their code. This makes CI cope with those older branches, so authors only see red checks for real problems.
Summary
lint-pr / lintchecks out the PR head for same-repo PRs, but the workflow file comes from the merge ref. Heads branched before #21015 have an architecture CLI without--report, sopnpm architecture:check --report …failed withUnknown option '--report'. That failure then took downlint-and-format,preflight,testande2e-status. The step now checks whether the checked-out CLI supports--report. If it does, the step passes--report. If it doesn't, the step emits a::warning::, writes a placeholder findings file that points at the run log and annotations, and runs plainpnpm architecture:check. The exit code is still the real check's, so a contract failure stays a failure. Left alone, as scoped: the head_ref checkout, the CLI's strict parsing, andci-lint-format-queue.yaml.Judgment call: support is detected by a behavioral probe, not a source grep. The step runs
architecture:check --report=withGITHUB_ACTIONSunset, so the probe emits no annotation. It then matches the CLI's own--report requires a file pathrejection; a pre-#21015 CLI answersUnknown option '--report'instead. The CLI has no--help. The probe's output is captured before grep so the default-eo pipefailshell doesn't flip the test. This is a time-boxed guard and can be removed once old branches have rebased.Verification
eb0e38abcc^:tools/architecture/src/cli.tscopied over the current one): running the step's script underbash -eo pipefailtakes the fallback, prints the warning, writes the placeholder and exits 0 ("passed with 103 warning(s)"). The unguarded command reproducesCould not parse arguments: Unknown option '--report', exit 1.--check --report "$RUNNER_TEMP/architecture-findings.md", exits 0, and writes the report (6.9 KB).oxfmt --checkclean on the workflow file.docs/architecture/domains/README.md:101still accurately describes--report).Residual
lint-pr / linton a real pre-feat: add architecture findings to the shared PR report comment #21015 PR branch in GitHub Actions. I checked it locally by running the step's script against the old CLI.--reportbranch.Provenance
bash -eo pipefail: probe picks the fallback, warning plus placeholder findings written, exit 0--report, exit 0, findings file writtenarchitecture:checkon both branches--report=, not the--helpprobe the ticket suggested, because the CLI has no--help.🤖 Generated with Claude Code