Repository navigation
[backport cloud/1.56] fix(agent): keep op sender stamps and displaced admissions - #21310
Conversation
## Summary Fixes three related `OpSender` admission issues: duplicate creator-owned Lamport counters after workflow transitions, displaced admissions being dropped during reentrant sealing, and delivery starting before an admission is fully placed. ## What - Keep one mint cursor per workflow and advance it only after an admission has a target. - Preserve a displaced admission at its original queue position with its original `op_id`s. - Defer the delivery pump for the full admission so earlier-minted operations are placed before work enqueued by reentrant serialization. - Relative to `main`, change `resumes a pump requested during workflow-change sealing` from "node 3 delivered first" — the dropped-admission outcome — to "node 2 first, displaced admission kept", and add the abort-slug `reportError` assertions to `does not rechunk a prefix after serialization aborts and throws`. #19874 had already moved both tests off their older values. - Add regressions for unbound admission, switching away and back, re-subscribing before acknowledgement, and resetting one workflow without resetting another workflow's cursor. - Pin the cursor against two mutants that left the suite fully green (`2b89b579f6`). These two pass on base production code: they do not pin new behavior, they stop the new cursor from silently losing behavior the old single-cursor code also had. - `lastMintedVersions.set(target, baseVersion)` in place of `baseVersion + minted.length - 1`. Every other cursor test admits one operation at a time, so the cursor's dependence on the admission's length was unasserted. Under the mutant a three-operation admission followed by another admission in the same tick re-mints `base_version` 42 and duplicates `(actor, 42)` on one document. Reachable: an undo/redo restore makes `restoreOpMinter` admit a whole multi-operation diff synchronously from `onAfterGraphConfigure`, while `docOpMinter`'s already-queued microtask admits again before the coalescer's deferred flush — two admissions, one flush, the first multi-operation. - `Math.max(observed, lastMinted + 1)` reduced to `lastMinted + 1`. No test advanced the observed sequence past the cursor, so the floor keeping a stamp at or above the sequence this follower has observed was unasserted. ## Breaking None. No exported signatures change. ## Ordering and cursor rationale Mint order is preserved within each document. A reentrant seal can change transport order across documents, but those operations have no shared document ordering relation. Workflow cursors have no capacity- or age-based eviction. During re-subscription, the observed sequence is `0` until acknowledgement, so the retained cursor is the only safe floor above stamps this actor previously minted for that workflow. A document reset clears only that document's cursor because only its lineage has been replaced. The `opSender.test.ts` conflict with #19874 was resolved by merging `main` at `0a0595747b`: this branch's pump expectation and both `reportError` assertions were kept, main's `summarizeSettlement` and `nodeIdsOf` helpers were adopted, and `opSender.ts` was left byte-identical to the pre-merge head. ## Verification At head `2b89b579f6`: - `src/workbench/extensions/agent/crdt/opSender.test.ts`: 93 passed. - The same tests against base production `opSender.ts` (`b365e2a847`): 5 failed, 88 passed. The failures are the four cursor regressions plus `resumes a pump requested during workflow-change sealing`. - Mutation results, each run as the only change to `opSender.ts`: - `abortAll` clearing every cursor → 1 failed (reset isolation). - Restoring an LRU cursor bound of 1 → 3 failed (reset isolation, switch-away-and-back, unacknowledged re-subscribe). - Displaced admission settled `undeliverable` again → 1 failed (the pump test). - Removing `admit`'s pump deferral → 1 failed (the pump test). - Placing the displaced admission at the current queue tail instead of its admitted index → 1 failed (the pump test). - Appending the displaced admission after the nested group instead of prepending → 1 failed (same-workflow reentrant order). - Cursor set to `baseVersion` → 1 failed (the new multi-operation pin); `Math.max` floor dropped → 1 failed (the new observed-sequence pin). Both were green before this commit. - Agent extension suite: 136 files, 2,616 passed, 1 pre-existing expected-fail in `semanticLayoutSeparation.guard.test.ts`. - `pnpm typecheck`, oxfmt, ESLint, type-aware oxlint, and the vitest-cleanup oxlint config all clean on the changed file. - `fallow audit --changed-since origin/main`: verdict `pass`, 0 introduced findings (1 inherited complexity finding on `opSender.ts`). - Trial merge of current `main` (`cb92c2272`) is clean, and #19865's new `opSender.test.ts` cases pass against this head's `opSender.ts`: 94 passed. - The black-box carrier is #19876 (`agentHumanEditAfterOtherWorkflowReset.spec.ts`), stacked so this PR stays production plus unit tests. It proves the cursor half; there is no black-box case yet for a displaced admission still reaching the wire.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-18T22:29:30.644Z",
"gitSha": "abbc86ed55181200307d41b4c8bd091e84344fbf",
"branch": "backport-19871-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.3739999999993,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.897000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.271,
"heapDeltaBytes": 963724,
"heapUsedBytes": 68745476,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.702000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.5999999999212,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.216999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.0089999999999,
"heapDeltaBytes": 1227932,
"heapUsedBytes": 68837500,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.858000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1772.2200000000043,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.227,
"layouts": 12,
"layoutDurationMs": 4.287000000000001,
"taskDurationMs": 845.051,
"heapDeltaBytes": -2508472,
"heapUsedBytes": 64990184,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 173.44799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.598000000051,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.976,
"layouts": 12,
"layoutDurationMs": 4.463,
"taskDurationMs": 873.1129999999999,
"heapDeltaBytes": -2374888,
"heapUsedBytes": 65504868,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 172.82899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.267999999991,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.597999999999997,
"layouts": 6,
"layoutDurationMs": 1.2579999999999998,
"taskDurationMs": 370.061,
"heapDeltaBytes": 3577240,
"heapUsedBytes": 70777448,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.699999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1749.5610000000852,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.94,
"layouts": 6,
"layoutDurationMs": 1.3860000000000001,
"taskDurationMs": 410.92999999999995,
"heapDeltaBytes": 4171684,
"heapUsedBytes": 72370832,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 17.310999999999993,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 722.0439999999826,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.045999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.54300000000006,
"heapDeltaBytes": -6364912,
"heapUsedBytes": 61135624,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 168.391,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 731.5549999999575,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.824,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.359,
"heapDeltaBytes": -6380052,
"heapUsedBytes": 61327096,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 173.049,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1228.0529999999885,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 939.1679999999999,
"heapDeltaBytes": 39255504,
"heapUsedBytes": 107883768,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 76.32600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 602,
"frameDurationMs": 36.27352941176471,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1299.7960000000148,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1010.1309999999999,
"heapDeltaBytes": 15117488,
"heapUsedBytes": 84446060,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 72.87899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 664,
"frameDurationMs": 38.23235294117646,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.9389999999776,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.06000000000006,
"heapDeltaBytes": 16984380,
"heapUsedBytes": 101788736,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 156.881,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 872.9929999999513,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.1990000000003,
"heapDeltaBytes": 16423976,
"heapUsedBytes": 92532856,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 177.63400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 237,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9331.902000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8631.099,
"heapDeltaBytes": 15835600,
"heapUsedBytes": 92787864,
"domNodes": -142,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 7295.962,
"eventListeners": -74,
"totalBlockingTimeMs": 1195,
"frameDurationMs": 35.486311787072246,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9193.535999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8402.875,
"heapDeltaBytes": 7171000,
"heapUsedBytes": 84164356,
"domNodes": -142,
"jsHeapTotalBytes": -8261632,
"scriptDurationMs": 7051.731,
"eventListeners": -78,
"totalBlockingTimeMs": 1068,
"frameDurationMs": 34.91634980988593,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9956.015999999978,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06399999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9029.489,
"heapDeltaBytes": -9894496,
"heapUsedBytes": 68144784,
"domNodes": -143,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 7410.65,
"eventListeners": -82,
"totalBlockingTimeMs": 1028,
"frameDurationMs": 33.055149501661134,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11069.37800000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10044.605000000001,
"heapDeltaBytes": -13467564,
"heapUsedBytes": 70866588,
"domNodes": -142,
"jsHeapTotalBytes": -4329472,
"scriptDurationMs": 8271.055,
"eventListeners": -78,
"totalBlockingTimeMs": 1425,
"frameDurationMs": 33.68780487804877,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2033.7509999999952,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.575999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.572,
"heapDeltaBytes": -10343684,
"heapUsedBytes": 77319084,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.63499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.8210000000217,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.2049999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 611.9919999999998,
"heapDeltaBytes": -7686968,
"heapUsedBytes": 76570296,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 41.43899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2682.054999999991,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.804,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1671.3560000000002,
"heapDeltaBytes": -18300888,
"heapUsedBytes": 70138704,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 876.05,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316774,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2819.552999999928,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.790999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1692.5960000000002,
"heapDeltaBytes": -18682208,
"heapUsedBytes": 70272384,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 880.902,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666863905325442,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3689.1780000000267,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.850000000000001,
"layouts": 60,
"layoutDurationMs": 14.979999999999999,
"taskDurationMs": 1705.531,
"heapDeltaBytes": -17720728,
"heapUsedBytes": 68718292,
"domNodes": 24,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 805.537,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576576576577,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3854.612999999972,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.234,
"layouts": 60,
"layoutDurationMs": 15.061,
"taskDurationMs": 1783.485,
"heapDeltaBytes": -20459192,
"heapUsedBytes": 69639872,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 842.13,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580086580086,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3141.5199999999572,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.317,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1952.388,
"heapDeltaBytes": 4812472,
"heapUsedBytes": 73208672,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 1016.756,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75508021390374,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3130.017000000066,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.474999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1905.697,
"heapDeltaBytes": 4847148,
"heapUsedBytes": 73541436,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 987.152,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.845161290322583,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2023.527999999942,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.573,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.5289999999999,
"heapDeltaBytes": -9524556,
"heapUsedBytes": 79857440,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.40700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.8570000000445,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.244,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.8739999999999,
"heapDeltaBytes": -9597040,
"heapUsedBytes": 79686072,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 41.028999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 640.8420000000206,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.423000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.88599999999997,
"heapDeltaBytes": -12215288,
"heapUsedBytes": 57787224,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 147.83,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 677.552999999989,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.376999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.57,
"heapDeltaBytes": -12269784,
"heapUsedBytes": 58149648,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 151.251,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.7350000000301,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.588,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.247,
"heapDeltaBytes": 1190260,
"heapUsedBytes": 70978992,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.219,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.9890000000187,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.7360000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.982,
"heapDeltaBytes": 1163456,
"heapUsedBytes": 70680072,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.407000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.1810000000196,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.482,
"layouts": 16,
"layoutDurationMs": 6.075,
"taskDurationMs": 772.726,
"heapDeltaBytes": -5841280,
"heapUsedBytes": 63855784,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.14899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.0809999999738,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.645999999999997,
"layouts": 16,
"layoutDurationMs": 5.630999999999999,
"taskDurationMs": 788.3140000000001,
"heapDeltaBytes": -5808700,
"heapUsedBytes": 63590796,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 117.39,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.9680000000262,
"styleRecalcs": 15,
"styleRecalcDurationMs": 33.319,
"layouts": 5,
"layoutDurationMs": 15.882,
"taskDurationMs": 1058.086,
"heapDeltaBytes": 3035780,
"heapUsedBytes": 98668256,
"domNodes": 14227,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 33.64800000000001,
"eventListeners": 2463,
"totalBlockingTimeMs": 159,
"frameDurationMs": 20.137499999999996,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9070.634999999982,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.614999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5895.594,
"heapDeltaBytes": 12960896,
"heapUsedBytes": 91058524,
"domNodes": 0,
"jsHeapTotalBytes": 753664,
"scriptDurationMs": 2889.999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69668508287293,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9939.245000000028,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.113,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6071.052999999999,
"heapDeltaBytes": 11630420,
"heapUsedBytes": 95774920,
"domNodes": 0,
"jsHeapTotalBytes": 1540096,
"scriptDurationMs": 2971.454,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593959731544,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18652.36799999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17752.819,
"heapDeltaBytes": -36144244,
"heapUsedBytes": 179705112,
"domNodes": -3045,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 296.34299999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.933732876712327,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 18615.11900000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17856.535,
"heapDeltaBytes": -22784380,
"heapUsedBytes": 179188832,
"domNodes": -3045,
"jsHeapTotalBytes": 4624384,
"scriptDurationMs": 301.28999999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.207612456747405,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 23803.147999999965,
"styleRecalcs": 182,
"styleRecalcDurationMs": 27.305000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23474.257,
"heapDeltaBytes": -22401988,
"heapUsedBytes": 192498356,
"domNodes": -3045,
"jsHeapTotalBytes": 6766592,
"scriptDurationMs": 1017.0669999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 20,
"frameDurationMs": 45.245247148288975,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 23326.527000000056,
"styleRecalcs": 178,
"styleRecalcDurationMs": 26.865000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22991.313,
"heapDeltaBytes": -40473864,
"heapUsedBytes": 175624172,
"domNodes": -3045,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 964.021,
"eventListeners": -14915,
"totalBlockingTimeMs": 37,
"frameDurationMs": 44.35817490494297,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6723.148999999921,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.19100000000002,
"layouts": 20,
"layoutDurationMs": 25.84099999999999,
"taskDurationMs": 6602.134,
"heapDeltaBytes": 1016876,
"heapUsedBytes": 217046876,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 118.57,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.59942528735632,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6696.829999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.29000000000003,
"layouts": 20,
"layoutDurationMs": 26.500999999999998,
"taskDurationMs": 6599.486,
"heapDeltaBytes": 1020312,
"heapUsedBytes": 216976268,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 119.97300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.01546961325966,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9618.38499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9239.014,
"heapDeltaBytes": -35991432,
"heapUsedBytes": 180379468,
"domNodes": -3045,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 156.84400000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.74105263157895,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9584.293000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9300.072000000002,
"heapDeltaBytes": -29158500,
"heapUsedBytes": 180833124,
"domNodes": -3045,
"jsHeapTotalBytes": 6721536,
"scriptDurationMs": 160.30999999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.93127147766323,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 469.90500000003976,
"styleRecalcs": 12,
"styleRecalcDurationMs": 13.748999999999999,
"layouts": 3,
"layoutDurationMs": 1.0459999999999998,
"taskDurationMs": 124.35199999999999,
"heapDeltaBytes": 5668528,
"heapUsedBytes": 71453532,
"domNodes": 102,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.747000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 124.91399999998976,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.330999999999998,
"layouts": 3,
"layoutDurationMs": 1.8780000000000001,
"taskDurationMs": 94.55199999999999,
"heapDeltaBytes": 3655424,
"heapUsedBytes": 68233688,
"domNodes": 113,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.179999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.44999999999997,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1111.8529999999964,
"styleRecalcs": 78,
"styleRecalcDurationMs": 113.80999999999999,
"layouts": 76,
"layoutDurationMs": 29.361,
"taskDurationMs": 1080.2019999999998,
"heapDeltaBytes": 20082580,
"heapUsedBytes": 86779676,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 461.989,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 959.2780000000403,
"styleRecalcs": 78,
"styleRecalcDurationMs": 110.07799999999999,
"layouts": 76,
"layoutDurationMs": 28.455000000000002,
"taskDurationMs": 919.987,
"heapDeltaBytes": 18310192,
"heapUsedBytes": 86350012,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 368.117,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664912280701763,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1643.273000000022,
"styleRecalcs": 78,
"styleRecalcDurationMs": 329.073,
"layouts": 76,
"layoutDurationMs": 33.007000000000005,
"taskDurationMs": 1622.931,
"heapDeltaBytes": 8835808,
"heapUsedBytes": 114993332,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 543.205,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.12073170731707,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1490.3179999998883,
"styleRecalcs": 78,
"styleRecalcDurationMs": 288.315,
"layouts": 76,
"layoutDurationMs": 30.229,
"taskDurationMs": 1463.768,
"heapDeltaBytes": 8470760,
"heapUsedBytes": 115457044,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 476.352,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.775949367088597,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E CoverageLine coverage: 64.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2203 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1b0ddf2ef25caee1fb682ca2f08b352475983bdf
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #21310 +/- ##
=============================================
Coverage ? 85.93%
=============================================
Files ? 2504
Lines ? 142868
Branches ? 36653
=============================================
Hits ? 122770
Misses ? 19712
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: this is a faithful cloud/1.56 backport and CI is settled green at this exact head.
Full context for agent readers
The mechanical fidelity pass matches the merged original, including the changed-file result. There are no package manifest or export changes, no unresolved review threads, and no workspace-scope change.
Backport of #19871 to
cloud/1.56Automatically created by backport workflow.