Skip to content

fix(website): align MCP hero spacing with Desktop - #21306

Merged
bertfy merged 1 commit into
codex/cli-system-polishfrom
codex/mcp-setup-treatment
Oct 19, 2026
Merged

bertfy merged 1 commit into
codex/cli-system-polishfrom
codex/mcp-setup-treatment

Conversation

@bertfy

@bertfy bertfy commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Summary

MCP's desktop hero was vertically centered against a viewport-height minimum, leaving an oversized gap under navigation. It now uses content height, top-aligned columns and 56px top padding while preserving existing mobile spacing, content, CTAs and media.

This is an explicit stack on codex/cli-system-polish (#21305), reusing the existing dependency-equipped workspace without installing or copying another dependency tree. Against that PR base, the diff contains only the MCP hero spacing fix and review screenshots. The CLI redesign is reviewed separately; the MCP setup sketch is not part of this diff.

Verification

  • Independent source and desktop/mobile visual reviews found no material regression. Browser checks at 1024/1280/1440/1920/2048px confirm 56px desktop spacing and no horizontal overflow; 390px retains existing spacing and demo-first order.
  • Live Desktop reference matches 56px at 1280/1440px. Its illustration centering varies at other widths, so this normalizes spacing rather than copying every responsive offset.
  • Normal commit/pre-push checks passed without bypasses. No new dependency installation or copies.

Before desktop: Before desktop

After desktop: After desktop

After mobile: After mobile

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a93589b9-aebe-4a7a-b1ff-f8d6841bb762

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@bertfy

bertfy commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 5d9167c1bc5d388331ecc132acbe857947817a71

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

View Report

Test results
Status ✅ Passed

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21306.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

Deployment details

This commit: https://website-frontend-j1qwv4q6b-comfyui.vercel.app

Last updated: 2026-10-18T21:26:32Z for 52ae906

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T19:40:54.646681Z 52ae906 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 52ae9068b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov

codecov Bot commented Oct 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                     Coverage Diff                     @@
##           codex/cli-system-polish   #21306      +/-   ##
===========================================================
- Coverage                    86.53%   86.53%   -0.01%     
===========================================================
  Files                         3653     3653              
  Lines                       174037   174038       +1     
  Branches                     47795    47795              
===========================================================
  Hits                        150598   150598              
- Misses                       21507    21508       +1     
  Partials                      1932     1932              
Flag Coverage Δ
website-unit 81.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/templates/mcp/HeroSection.vue 0.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 18, 2026
@bertfy
bertfy marked this pull request as ready for review October 19, 2026 19:38
@bertfy
bertfy merged commit 5f3ab26 into codex/cli-system-polish Oct 19, 2026
98 checks passed
@bertfy
bertfy deleted the codex/mcp-setup-treatment branch October 19, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant