Repository navigation
fix(website): align MCP hero spacing with Desktop - #21306
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@codex review |
📦 Bundle Size
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 5d9167c1bc5d388331ecc132acbe857947817a71
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed. Test results
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21306.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. Deployment detailsThis commit: https://website-frontend-j1qwv4q6b-comfyui.vercel.app Last updated: 2026-10-18T21:26:32Z for |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## codex/cli-system-polish #21306 +/- ##
===========================================================
- Coverage 86.53% 86.53% -0.01%
===========================================================
Files 3653 3653
Lines 174037 174038 +1
Branches 47795 47795
===========================================================
Hits 150598 150598
- Misses 21507 21508 +1
Partials 1932 1932
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
MCP's desktop hero was vertically centered against a viewport-height minimum, leaving an oversized gap under navigation. It now uses content height, top-aligned columns and 56px top padding while preserving existing mobile spacing, content, CTAs and media.
This is an explicit stack on
codex/cli-system-polish(#21305), reusing the existing dependency-equipped workspace without installing or copying another dependency tree. Against that PR base, the diff contains only the MCP hero spacing fix and review screenshots. The CLI redesign is reviewed separately; the MCP setup sketch is not part of this diff.Verification
Before desktop:
After desktop:
After mobile: