Repository navigation
[backport cloud/1.57] fix(agent): send human links into widget inputs the agent-built doc lacks (PM-1897) - #21262
Conversation
…acks (PM-1897) (#21244) *PR Created by the Glary-Bot Agent* --- Reported for local rc34: the agent said `frame_load_cap` on Load Video (VHS) and an agent-made custom node was "a plain widget = 1000" when the user had wired a PrimitiveInt into both. Linear: PM-1897. ## Cause - When the agent creates a node, comfy-cli `workflow_ops._build_node` puts only its link inputs (`p.is_link`) into the CRDT doc. Widget-backed inputs like `frame_load_cap` get no input slot. - On the canvas, the same node does have a `frame_load_cap` socket. - When the user wires into that socket, `mintConnect` resolves the target by name against the doc's inputs (`docInputIndex`) and finds nothing. It only reports `agent_crdt_link_slot_not_in_doc` and never sends the connect. - So the doc, and the agent's `workflow print`, keep showing the static widget value. ## Commits 1. **Failing regression test** (`agentBuiltWidgetInputLink.regression.test.ts`). It sends a human connect through the real `attachDocOpMinter`, applies it with the pinned `comfy-multi-player` applier, then runs `project()` on the doc. On this commit no ops are minted, so the test fails. 2. **Fix** (pushed as a follow-up commit). When the doc has no slot for a widget-backed input, `mintConnect` sends a `grow` connect carrying the widget name. This is the same payload already used for autogrow inputs. The applier appends a named, widget-backed slot, and peers resolve it by name. The bypass half of the same report (Video Combine shown as bypassed) did not reproduce, so it is out of scope here. ## Status The fix commit is pushed. The regression test fails without the fix and passes with it. All other `agent/crdt` tests still pass, except `agentSubgraphDefinitions.test.ts > scans deeply nested definition ids`, which already fails on `main` with a stack overflow. ## Known limitation (follow-up) There is a narrow window after the user draws the link and before the server echoes the new slot back. During it, the local doc has no slot for this input yet: - **Disconnect in that window:** the disconnect is dropped, so the doc keeps a link the user already removed. - **Replace in that window:** a second grow is sent, so the doc ends up with two slots (`frame_load_cap` and `frame_load_cap.frame_load_cap0`). `main` already has the same weakness for autogrow inputs. The proper fix is to track grows that haven't been echoed yet, keyed by node and input name, and let a later disconnect or reconnect act on that pending slot. It could also be fixed on the applier side: comfy-multi-player could treat a grow that carries `widget` as a claim on an existing slot with the same name. ## Follow-ups (tracked) - Grow echo window (disconnect/replace before the echo): https://linear.app/comfyorg/issue/FE-3472 - Undo/redo restore drops a link into a doc-absent slot: https://linear.app/comfyorg/issue/FE-3473 - Root-cause companion for new agent-built nodes: Comfy-Org/comfy-cli#1028. A third test case pins that once the doc carries the widget socket (the shape that PR writes), the minter sends an ordinary connect with no grow. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-18T03:46:42.467Z",
"gitSha": "326aad250f188054d03890a7e488c82758f324dd",
"branch": "backport-21244-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.2389999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.819999999999999,
"layouts": 10,
"layoutDurationMs": 4.161,
"taskDurationMs": 445.93699999999995,
"heapDeltaBytes": -873276,
"heapUsedBytes": 74263452,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 13.467000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2009.5119999999724,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.9530000000000007,
"layouts": 10,
"layoutDurationMs": 2.589,
"taskDurationMs": 322.515,
"heapDeltaBytes": -914588,
"heapUsedBytes": 74513316,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.404999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.6539999999573,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.683,
"layouts": 9,
"layoutDurationMs": 2.608,
"taskDurationMs": 698.723,
"heapDeltaBytes": -7275112,
"heapUsedBytes": 68028612,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 128.33700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.7780000000225,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.042,
"layouts": 9,
"layoutDurationMs": 2.307,
"taskDurationMs": 657.4029999999999,
"heapDeltaBytes": 15615668,
"heapUsedBytes": 81834696,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 124.73500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.0989999999615,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.461,
"layouts": 13,
"layoutDurationMs": 3.4930000000000003,
"taskDurationMs": 264.383,
"heapDeltaBytes": 18756836,
"heapUsedBytes": 84424088,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 15.662000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.7960000000398,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.334000000000001,
"layouts": 12,
"layoutDurationMs": 2.6119999999999997,
"taskDurationMs": 237.54200000000003,
"heapDeltaBytes": 19099072,
"heapUsedBytes": 85468452,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.77,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 582.4390000000221,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.4200000000000004,
"layouts": 10,
"layoutDurationMs": 2.942,
"taskDurationMs": 398.962,
"heapDeltaBytes": 25272580,
"heapUsedBytes": 91089728,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 125.05,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 549.1150000000289,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.333,
"layouts": 10,
"layoutDurationMs": 2.853,
"taskDurationMs": 372.245,
"heapDeltaBytes": -1089028,
"heapUsedBytes": 65163028,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 122.12200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 912.5459999999634,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.6669999999999,
"heapDeltaBytes": -12698944,
"heapUsedBytes": 81341660,
"domNodes": -192,
"jsHeapTotalBytes": 19931136,
"scriptDurationMs": 42.611999999999995,
"eventListeners": -106,
"totalBlockingTimeMs": 276,
"frameDurationMs": 26.188571428571425,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 961.3800000000197,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.718,
"heapDeltaBytes": -3515580,
"heapUsedBytes": 80867652,
"domNodes": -192,
"jsHeapTotalBytes": 13377536,
"scriptDurationMs": 35.553,
"eventListeners": -106,
"totalBlockingTimeMs": 331,
"frameDurationMs": 27.619999999999994,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 712.5070000000164,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.6080000000001,
"heapDeltaBytes": -5203608,
"heapUsedBytes": 75677880,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 102.48100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 21.076470588235306,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 703.3950000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.1649999999998,
"heapDeltaBytes": -3850356,
"heapUsedBytes": 76802868,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 88.24199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 87,
"frameDurationMs": 20.585294117647074,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6306.363000000005,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9459999999999998,
"layouts": 3,
"layoutDurationMs": 0.7530000000000002,
"taskDurationMs": 5158.3189999999995,
"heapDeltaBytes": -26546944,
"heapUsedBytes": 72401472,
"domNodes": -258,
"jsHeapTotalBytes": 9302016,
"scriptDurationMs": 4089.1710000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 26,
"frameDurationMs": 20.62899022801303,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6667.754999999999,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2850000000000006,
"layouts": 4,
"layoutDurationMs": 1.206,
"taskDurationMs": 5442.654,
"heapDeltaBytes": -23470412,
"heapUsedBytes": 75671832,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 4147.797,
"eventListeners": -68,
"totalBlockingTimeMs": 25,
"frameDurationMs": 19.969069069069068,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6422.8039999999855,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2050000000000003,
"layouts": 4,
"layoutDurationMs": 0.9429999999999998,
"taskDurationMs": 5365.174,
"heapDeltaBytes": -17387248,
"heapUsedBytes": 82364628,
"domNodes": -258,
"jsHeapTotalBytes": 11661312,
"scriptDurationMs": 4148.535,
"eventListeners": -68,
"totalBlockingTimeMs": 42,
"frameDurationMs": 20.95472312703583,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6070.030000000032,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.17,
"layouts": 4,
"layoutDurationMs": 1.025,
"taskDurationMs": 4908.965999999999,
"heapDeltaBytes": -4654756,
"heapUsedBytes": 72172056,
"domNodes": -254,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 3782.867,
"eventListeners": -67,
"totalBlockingTimeMs": 2,
"frameDurationMs": 19.13690851735016,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 147.32699999999,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.232,
"layouts": 13,
"layoutDurationMs": 2.9700000000000006,
"taskDurationMs": 111.415,
"heapDeltaBytes": -9047784,
"heapUsedBytes": 79141060,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6.0169999999999995,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 144.04500000000553,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.343000000000002,
"layouts": 13,
"layoutDurationMs": 3.097,
"taskDurationMs": 106.431,
"heapDeltaBytes": -9298812,
"heapUsedBytes": 78996540,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6.863000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.76249999999999,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2011.8190000000027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4549999999999996,
"layouts": 8,
"layoutDurationMs": 2.1470000000000002,
"taskDurationMs": 344.1790000000001,
"heapDeltaBytes": -1381204,
"heapUsedBytes": 77621132,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 26.872000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.5520000000088,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.728,
"layouts": 9,
"layoutDurationMs": 2.3880000000000003,
"taskDurationMs": 404.289,
"heapDeltaBytes": -19225868,
"heapUsedBytes": 77417844,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 26.677,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2435.4960000000005,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.560999999999999,
"layouts": 8,
"layoutDurationMs": 1.857,
"taskDurationMs": 1170.8159999999998,
"heapDeltaBytes": -11754252,
"heapUsedBytes": 67950052,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 561.414,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666438356164385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2532.4339999999665,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.800999999999999,
"layouts": 8,
"layoutDurationMs": 2.0660000000000003,
"taskDurationMs": 1241.2869999999998,
"heapDeltaBytes": -12405384,
"heapUsedBytes": 67880664,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 571.0659999999999,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3838.741999999968,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.754,
"layouts": 67,
"layoutDurationMs": 13.015,
"taskDurationMs": 1367.2520000000002,
"heapDeltaBytes": 3344800,
"heapUsedBytes": 101492340,
"domNodes": 24,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 592.928,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665652173913042,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3534.6480000000042,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.344,
"layouts": 67,
"layoutDurationMs": 12.776,
"taskDurationMs": 1285,
"heapDeltaBytes": -22440344,
"heapUsedBytes": 76396228,
"domNodes": -234,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 548.9849999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66556603773585,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2508.0130000000054,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.692000000000001,
"layouts": 8,
"layoutDurationMs": 1.7750000000000001,
"taskDurationMs": 1323.059,
"heapDeltaBytes": 12897244,
"heapUsedBytes": 95666988,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 642.771,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665562913907284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2773.280999999997,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.003,
"layouts": 7,
"layoutDurationMs": 1.7750000000000001,
"taskDurationMs": 1392.385,
"heapDeltaBytes": 2594468,
"heapUsedBytes": 80194592,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 700.879,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.1499999999915,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0750000000000006,
"layouts": 10,
"layoutDurationMs": 2.7670000000000003,
"taskDurationMs": 457.91700000000003,
"heapDeltaBytes": -3395964,
"heapUsedBytes": 73463376,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 30.906000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2005.8589999999867,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9989999999999999,
"layouts": 9,
"layoutDurationMs": 1.754,
"taskDurationMs": 373.067,
"heapDeltaBytes": -16936048,
"heapUsedBytes": 81315620,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 19.333999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 513.1880000000137,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.331,
"layouts": 10,
"layoutDurationMs": 2.4290000000000003,
"taskDurationMs": 351.825,
"heapDeltaBytes": -1521096,
"heapUsedBytes": 75773692,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 99.879,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 463.5170000000244,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.596,
"layouts": 10,
"layoutDurationMs": 3.4469999999999996,
"taskDurationMs": 310.693,
"heapDeltaBytes": -1065332,
"heapUsedBytes": 76299412,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 105.879,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.572999999989,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2319999999999998,
"layouts": 10,
"layoutDurationMs": 2.108,
"taskDurationMs": 301.007,
"heapDeltaBytes": 21972996,
"heapUsedBytes": 89306240,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.480999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.4109999999764,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8199999999999985,
"layouts": 9,
"layoutDurationMs": 2.516,
"taskDurationMs": 333.323,
"heapDeltaBytes": 22457328,
"heapUsedBytes": 89339972,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.801,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.3839999999846,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.232,
"layouts": 10,
"layoutDurationMs": 2.694,
"taskDurationMs": 566.9709999999999,
"heapDeltaBytes": 11611096,
"heapUsedBytes": 78890400,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 90.62299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.0510000000058,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.699,
"layouts": 11,
"layoutDurationMs": 2.5379999999999994,
"taskDurationMs": 567.0930000000001,
"heapDeltaBytes": -11442820,
"heapUsedBytes": 65517344,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 88.329,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 835.8450000000062,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.011000000000003,
"layouts": 5,
"layoutDurationMs": 9.533999999999999,
"taskDurationMs": 628.287,
"heapDeltaBytes": 7447324,
"heapUsedBytes": 99575036,
"domNodes": 15953,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 19.073,
"eventListeners": 3244,
"totalBlockingTimeMs": 74,
"frameDurationMs": 19.379069767441866,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8752.173999999968,
"styleRecalcs": 250,
"styleRecalcDurationMs": 23.637999999999998,
"layouts": 8,
"layoutDurationMs": 2.0860000000000003,
"taskDurationMs": 4210.561000000001,
"heapDeltaBytes": -15029884,
"heapUsedBytes": 82866264,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 1962.501,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615969581749,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8372.349999999984,
"styleRecalcs": 251,
"styleRecalcDurationMs": 23.403999999999996,
"layouts": 10,
"layoutDurationMs": 2.124,
"taskDurationMs": 3875.2190000000005,
"heapDeltaBytes": -9543352,
"heapUsedBytes": 86536764,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 1913.3519999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593625498008,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16703.13699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15731.343,
"heapDeltaBytes": -35529688,
"heapUsedBytes": 260112152,
"domNodes": -3330,
"jsHeapTotalBytes": 11788288,
"scriptDurationMs": 230.021,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.497098976109214,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 11786.029999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10903.969,
"heapDeltaBytes": 6583360,
"heapUsedBytes": 282605092,
"domNodes": -3330,
"jsHeapTotalBytes": 50585600,
"scriptDurationMs": 147.47299999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.033276740237692,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 14939.968000000023,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.718000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14282.559000000003,
"heapDeltaBytes": -19156596,
"heapUsedBytes": 290942588,
"domNodes": -3330,
"jsHeapTotalBytes": 16961536,
"scriptDurationMs": 631.7349999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 31,
"frameDurationMs": 26.677540106951874,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 14891.773000000057,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.679999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14294.418,
"heapDeltaBytes": -24054500,
"heapUsedBytes": 267162300,
"domNodes": -3330,
"jsHeapTotalBytes": 8118272,
"scriptDurationMs": 619.664,
"eventListeners": -651,
"totalBlockingTimeMs": 5,
"frameDurationMs": 26.912839059674504,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 6079.887999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.155000000000015,
"layouts": 20,
"layoutDurationMs": 24.185,
"taskDurationMs": 5916.6309999999985,
"heapDeltaBytes": -37199716,
"heapUsedBytes": 254133208,
"domNodes": -3330,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 112.43200000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.367796610169485,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5624.964999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.45200000000002,
"layouts": 20,
"layoutDurationMs": 19.461999999999993,
"taskDurationMs": 5504.1720000000005,
"heapDeltaBytes": -16948996,
"heapUsedBytes": 274328476,
"domNodes": -3330,
"jsHeapTotalBytes": 36167680,
"scriptDurationMs": 102.325,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.233136094674556,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7895.291999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7495.794999999999,
"heapDeltaBytes": -4001656,
"heapUsedBytes": 273742444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 103.964,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.24068965517241,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8085.239999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7543.8279999999995,
"heapDeltaBytes": 18961824,
"heapUsedBytes": 280346216,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.07499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.4,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "workflow-execution",
"durationMs": 437.05700000003844,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.856,
"layouts": 13,
"layoutDurationMs": 3.411,
"taskDurationMs": 84.31700000000001,
"heapDeltaBytes": 6705536,
"heapUsedBytes": 79148688,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.392999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230772,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 87.00499999997646,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.285,
"layouts": 6,
"layoutDurationMs": 2.113,
"taskDurationMs": 60.07599999999999,
"heapDeltaBytes": -15533204,
"heapUsedBytes": 68045864,
"domNodes": 121,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 4.395000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.680000000000017,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 200.74799999997595,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.124,
"layouts": 76,
"layoutDurationMs": 9.744,
"taskDurationMs": 163.578,
"heapDeltaBytes": 8734484,
"heapUsedBytes": 100202908,
"domNodes": 4,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 71.191,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923079,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 204.22899999994115,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.856,
"layouts": 76,
"layoutDurationMs": 9.244,
"taskDurationMs": 155.257,
"heapDeltaBytes": 8748244,
"heapUsedBytes": 100349640,
"domNodes": 4,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 65.65899999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.658333333333342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 313.75100000002476,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9880000000000002,
"layouts": 76,
"layoutDurationMs": 12.902000000000001,
"taskDurationMs": 270.727,
"heapDeltaBytes": -6678120,
"heapUsedBytes": 104892080,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 93.43900000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 280.69699999991826,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.823,
"layouts": 76,
"layoutDurationMs": 11.286,
"taskDurationMs": 247.15,
"heapDeltaBytes": -7072656,
"heapUsedBytes": 106877872,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 81.931,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66111111111109,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.6% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2281 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fbd57000bb08a2c0a10d973a2bc1dc7bd2cc0e87
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21262 +/- ##
=============================================
Coverage ? 87.19%
=============================================
Files ? 2628
Lines ? 147755
Branches ? 38462
=============================================
Hits ? 128833
Misses ? 18532
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport fidelity verified against merged PR 21244: all 310 sorted changed lines match, the same three files are changed, and no package manifest or lockfile is touched. The exact-head CI rollup is fully settled green with no review threads.
…21275) ## ELI5 The job that tags cloud releases after each backport merge used to go red whenever our shared GitHub account hit its request limit, even when there was nothing to do. Now it waits briefly and tries again, and if the limit really is exhausted it fails with a message that says so plainly. That way a red job means a real problem again. ## Summary `scripts/cicd/cloud-backport-tag.sh` called `gh api` with no retry, so a rate-limit 403/429 showed up as `Failed to verify that commit ... belongs to cloud/x.y` and the job exited 1 (seen on PR #21262's post-merge run 39096161847 and its re-run, plus runs 39097122311, 38849263424 and 38821590813). - A new `gh_api` wrapper now handles every `gh api` call in the script (branch-head lookup, both compares, package.json read, tag lookup, tag peel, ref create). - Rate-limit responses (`rate limit` text or `HTTP 429`): if `rate_limit` reports `core.remaining == 0`, it sleeps until `core.reset`. Otherwise (a secondary limit) it waits 60s per retry, per GitHub's secondary-limit guidance. HTTP 5xx backs off 5/10/20s. - Retries are capped at 4 attempts per call and a **300s retry budget per run**. The budget is shared across all calls and measured as the larger of wall-clock time since the run started (`date +%s`, so slow requests count) and accumulated sleep, which leaves plenty of room under the job's 10-minute timeout. If the next reset would land past the budget, it fails right away instead of sleeping for nothing. - When retries run out on a rate limit, it logs `::error::GitHub API rate limited on <endpoint>; gave up after N attempt(s) and Ns` (plus `(next reset in Ns)` only when the reset came from the `rate_limit` probe) before the caller's existing error line. Exhausted 5xx retries log a matching `::error::GitHub API <endpoint> failed after N attempt(s) and Ns`. - Retry warnings stay visible when the tag lookup ends in the expected 404 (only the 404 line itself is dropped), so pressure that recovered still leaves a trace. - `Retry-After` is not read: `gh api` only exposes headers via `--include`, which would corrupt the `--jq` output, so secondary limits use GitHub's documented 60s fallback. - Any other failure still returns immediately. That keeps the 404-means-missing-tag path and the 422 create-race path exactly as they were. A POST retried after a 5xx that actually succeeded on GitHub's side gets a 422 and falls into the existing race handler. - Unchanged: the tag-preservation rules, creating refs through the REST API, how the credential is confined, and the token itself. ## Verification - `scripts/cicd/cloud-backport-tag.test.ts`: the `gh` stub can now return rate-limit errors on chosen calls, `sleep` is stubbed so the planned waits are recorded and asserted, and `date` is stubbed so elapsed time is fixed rather than read from the wall clock. New cases: - rate-limited once, then the tag is created after a reset-aware wait of about 30s - rate-limited twice (secondary), then an existing tag is kept after 60s/60s; run once with the primary-limit text and once with a bare `HTTP 429` so both detection alternations are pinned - a rate-limited tag lookup followed by a 404 creates the tag and still logs the retry warning - always rate-limited with a reset beyond the budget: fails at once with the rate-limit error and no sleeps - always rate-limited with a secondary limit: waits 60/60/60s, then reports the rate-limit error without a made-up reset time, with total sleep under the budget - the budget is shared across calls (budget 150s: `[60, 60]`, then gives up) - the existing HTTP 503 case now retries 5/10/20s and still fails closed with the exhausted-retry error; at a 5s budget it stops after `[5]`; with 1s already elapsed at that budget it refuses to retry at all - a 404 is never retried - Against the original script, the new rate-limit cases and the updated 503 case fail. All 18 tests pass with the change. - `check-shell.sh` (shellcheck), oxfmt, oxlint, typecheck and `typecheck:scripts` all pass. - Doc-drift sweep: 3 references checked, 0 updated. That is the targeted grep for `cloud-backport-tag` and the new `GH_API_*` names in `docs/release-process.md` and `backport-auto-merge.yaml`; none describe retry behaviour. The sweep's other 1005 hits are generic `node:fs` identifiers from the test imports and were not individually judged. ## Residual - Not checked against live GitHub: the failing runs named above (39096161847, 39097122311, 38849263424, 38821590813) were not re-run. I only matched the stub's rate-limit message to the `gh: API rate limit exceeded for user ID …` text quoted from the run log. The first real proof will be the next backport merge that hits a rate limit. - Assumption: rate-limit detection reads `gh`'s stderr text plus `rate_limit`'s `core` bucket. If the exhausted bucket were something other than `core`, it falls back to the fixed 60s wait instead of a reset-aware wait. The endpoints this script uses are all core REST, so that fallback should not trigger in practice. - Out of scope: the shared `PR_GH_TOKEN` running out of requests, which is the underlying cause, is tracked separately. This change only stops the job from failing outright on a short exhaustion. If the token stays exhausted for longer than about 5 minutes, the job still goes red, now with a clear rate-limit message. ## Provenance - **Authored by:** agent-work loop - **Verified:** - unit/shell tests with stubbed `gh`, `sleep` and `date`: 18/18, stable across 5 consecutive runs - shellcheck, oxfmt, oxlint, `typecheck:scripts`, knip and fallow (pre-push) pass - red-check against the pre-change script: new cases fail, including the retry-logging cases from review - the `HTTP 429` case fails if its message is changed to a status the detector does not match - CI on the current head: all checks pass, including the required ones; no merge-queue run yet - **Deviations:** - the retry budget is shared across the whole run and counts wall-clock time, not per-call sleep, so back-to-back rate-limited or slow calls cannot add up to more than the job timeout - a POST that succeeded behind a 5xx is reported through the race handler ("already exists"), not "Created"; the outcome is correct - the new env knobs `GH_API_MAX_ATTEMPTS` and `GH_API_RETRY_BUDGET_SECONDS` default to 4 and 300 and are only overridden in tests.
Backport of #21244 to
cloud/1.57Automatically created by backport workflow.